dce-reactkit 3.5.2 → 3.5.3

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "dce-reactkit",
-  "version": "3.5.2",
+  "version": "3.5.3",
   "description": "Shared components for Harvard DCE apps",
   "main": "dist/cjs/index.js",
   "module": "dist/esm/index.js",

package/src/helpers/compareArraysByProp.test.ts

@@ -99,4 +99,49 @@ describe('compareArraysByProp', () => {
     const result = compareArraysByProp(a, b, 'id');
     expect(result).toEqual(false);
   });
+
+  it('should return true for two arrays with the same objects with multiple properties and multiple props', () => {
+    const a = [
+      { id: 1, name: 'Alice', age: 25 },
+      { id: 2, name: 'Bob', age: 30 },
+      { id: 3, name: 'Charlie', age: 35 },
+    ];
+    const b = [
+      { id: 1, name: 'Alice', age: 25 },
+      { id: 2, name: 'Bob', age: 30 },
+      { id: 3, name: 'Charlie', age: 35 },
+    ];
+    const result = compareArraysByProp(a, b, ['id', 'name']);
+    expect(result).toEqual(true);
+  });
+
+  it('should return true for two arrays with the same objects with multiple properties and multiple props in a different order', () => {
+    const a = [
+      { id: 1, name: 'Alice', age: 25 },
+      { id: 2, name: 'Bob', age: 30 },
+      { id: 3, name: 'Charlie', age: 35 },
+    ];
+    const b = [
+      { id: 3, name: 'Charlie', age: 35 },
+      { id: 1, name: 'Alice', age: 25 },
+      { id: 2, name: 'Bob', age: 30 },
+    ];
+    const result = compareArraysByProp(a, b, ['id', 'name']);
+    expect(result).toEqual(true);
+  });
+
+  it('should return false for two arrays with different objects with multiple properties and multiple props', () => {
+    const a = [
+      { id: 1, name: 'Alice', age: 25 },
+      { id: 2, name: 'Bob', age: 30 },
+      { id: 3, name: 'Charlie', age: 35 },
+    ];
+    const b = [
+      { id: 1, name: 'Bob', age: 40 },
+      { id: 2, name: 'Alice', age: 45 },
+      { id: 3, name: 'Charlie', age: 50 },
+    ];
+    const result = compareArraysByProp(a, b, ['id', 'name']);
+    expect(result).toEqual(false);
+  });
 });

package/src/helpers/compareArraysByProp.ts

@@ -1,6 +1,3 @@
-// Import shared helpers
-import extractProp from './extractProp';
-
 /**
  * Compare two arrays of objects by only comparing the values in a specific
  *  property (e.g. compare user arrays by comparing their user.id values)
@@ -34,8 +31,8 @@ const compareArraysByProp = (
     const matchingIndex = bCloned.findIndex((bItem) => {
       // Compare based on all props
       return props.every((propToCompareBy) => {
-        const aVal = extractProp(a[i], propToCompareBy);
-        const bVal = extractProp(bItem, propToCompareBy);
+        const aVal = (a[i] ?? {})[propToCompareBy];
+        const bVal = (bItem ?? {})[propToCompareBy];
         return aVal === bVal;
       });
     });

package/src/helpers/getTimeInfoInET.test.ts

@@ -38,7 +38,7 @@ describe('getTimeInfoInET', () => {
     const expectedHour = 19;
     const expectedHour12 = 7;
     const expectedMinute = 0;
-    const expectedIsPM = false;
+    const expectedIsPM = true;
     expect(result.timestamp).toEqual(expectedTimestamp);
     expect(result.year).toEqual(expectedYear);
     expect(result.month).toEqual(expectedMonth);
@@ -59,7 +59,7 @@ describe('getTimeInfoInET', () => {
     const expectedHour = 19;
     const expectedHour12 = 7;
     const expectedMinute = 0;
-    const expectedIsPM = false;
+    const expectedIsPM = true;
     expect(result.timestamp).toEqual(expectedTimestamp);
     expect(result.year).toEqual(expectedYear);
     expect(result.month).toEqual(expectedMonth);

package/src/helpers/validators/validateString.test.ts

@@ -167,8 +167,6 @@ test(
         errorMessage: `${INVALID_STRING_ERRORS.MESSAGE_INTRO}${genCommaList(triple.error)}.`,
       };
 
-      console.log(invalidResponse.errorMessage);
-
       expect(validateString(triple.input, triple.reqs)).toStrictEqual(invalidResponse);
     });
   },