dce-reactkit 3.2.2-beta.5 → 3.2.2-beta.51

package/src/components/SimpleDateChooser.tsx

@@ -62,11 +62,7 @@ const SimpleDateChooser: React.FC<Props> = (props) => {
     onChange,
     chooseFromPast,
   } = props;
-  let numMonthsToShow = forceNumIntoBounds(
-    (props.numMonthsToShow ?? 6),
-    1,
-    12,
-  );
+  const numMonthsToShow = (props.numMonthsToShow ?? 6);
 
   /*------------------------------------------------------------------------*/
   /*                                 Render                                 */
@@ -88,7 +84,7 @@ const SimpleDateChooser: React.FC<Props> = (props) => {
   let startMonth = today.month;
   if (chooseFromPast) {
     startMonth -= Math.max(0, numMonthsToShow - 1);
-    if (startMonth <= 0) {
+    while (startMonth <= 0) {
       startMonth += 12;
       startYear -= 1;
     }
@@ -96,28 +92,37 @@ const SimpleDateChooser: React.FC<Props> = (props) => {
   for (let i = 0; i < numMonthsToShow; i++) {
     // Get month and year info
     const unmoddedMonth = (startMonth + i);
-    const month = (
-      unmoddedMonth > 12
-        ? unmoddedMonth - 12
-        : unmoddedMonth
-    );
+    let month = unmoddedMonth;
+    while (month > 12) {
+      month -= 12;
+    }
     const monthName = getMonthName(month).full;
-    const year = (
-      unmoddedMonth > 12
-        ? startYear + 1
-        : startYear
-    );
+    // Year is start year +1 for each 12 months
+    const year = (startYear + (Math.floor(unmoddedMonth / 12)));
 
     // Figure out which days are allowed
     const days = [];
     const numDaysInMonth = (new Date(year, month, 0)).getDate();
-    const firstDay = (
-      month === today.month
-        ? today.day // Current month: start at current date
-        : 1 // Future month: start at beginning of month
-    );
-    for (let day = firstDay; day <= numDaysInMonth; day++) {
-      days.push(day);
+    if (chooseFromPast) {
+      // Past selection
+      const numDaysToAdd = (
+        (month === today.month)
+          ? today.day // Current month, only add up to today
+          : numDaysInMonth // Past month, add all days
+      );
+      for (let day = 1; day <= numDaysToAdd; day++) {
+        days.push(day);
+      }
+    } else {
+      // Future selection: add all remaining days of the month
+      const firstDay = (
+        month === today.month
+          ? today.day // Current month: start at current date
+          : 1 // Future month: start at beginning of month
+      );
+      for (let day = firstDay; day <= numDaysInMonth; day++) {
+        days.push(day);
+      }
     }
 
     choices.push({

package/src/helpers/genCSV.ts

@@ -5,13 +5,13 @@
  * @returns escaped cell text
  */
 const escapeCellText = (text: string): string => {
-  if (!text.includes(',')) {
+  if (!String(text).includes(',')) {
     // No need to escape
-    return text;
+    return String(text);
   }
 
   // Perform escape
-  return `"${text.replace(/"/g, '""')}`;
+  return `"${String(text).replace(/"/g, '""')}`;
 };
 
 /**
@@ -43,10 +43,28 @@ const genCSV = (
 
   // Add each row
   data.forEach((datum) => {
+    csv += '\n';
     csv += (
       columns
         .map((column) => {
-          return escapeCellText(datum[column.param]);
+          let contents: string;
+          const cell = datum[column.param];
+          if (
+            typeof cell === 'string'
+            || typeof cell === 'number'
+          ) {
+            contents = String(cell);
+          } else if (
+            typeof cell === 'undefined'
+            || cell === null
+          ) {
+            contents = '';
+          } else if (typeof cell === 'object') {
+            contents = JSON.stringify(cell);
+          } else {
+            contents = '';
+          }
+          return escapeCellText(contents);
         })
         .join(',')
     );

package/src/helpers/genRouteHandler.ts

@@ -500,7 +500,7 @@ const genRouteHandler = (
           isAdmin: !!launchInfo.isAdmin,
           isTTM: !!launchInfo.isTTM,
           courseId: launchInfo.courseId,
-          courseName: launchInfo.courseName,
+          courseName: launchInfo.contextLabel,
           browser,
           device,
           year,
@@ -539,7 +539,7 @@ const genRouteHandler = (
               type: LogType.Action,
               target: (
                 (opts as any).target
-                ?? LogBuiltInMetadata.Target.NoSpecificTarget
+                ?? LogBuiltInMetadata.Target.NoTarget
               ),
               action: (
                 (opts as any).action

package/src/helpers/logClientEvent.tsx

@@ -53,7 +53,7 @@ const logClientEvent: LogFunction = async (opts) => {
         (opts as any).action
           ? (
             (opts as any).target
-            ?? LogBuiltInMetadata.Target.NoSpecificTarget
+            ?? LogBuiltInMetadata.Target.NoTarget
           )
           : undefined
       ),

package/src/server/initServer.ts

@@ -249,10 +249,14 @@ const initServer = (
       },
       handler: async ({ params }) => {
         // Get user info
-        const { userId, isAdmin } = params;
+        const {
+          year,
+          month,
+          userId,
+          isAdmin,
+        } = params;
 
         // Validate user
-        // isAdmin is already checked because path starts with '/admin'
         const canReview = await canReviewLogs(userId, isAdmin);
         if (!canReview) {
           throw new ErrorWithCode(
@@ -262,7 +266,10 @@ const initServer = (
         }
 
         // Query for logs
-        const logs: Log[] = await _logCollection.find({ userId });
+        const logs: Log[] = await _logCollection.find({
+          year,
+          month,
+        });
 
         // Return logs
         return logs;

package/src/types/LogAction.ts

@@ -4,37 +4,37 @@
  */
 enum LogAction {
   // Target was opened by the user (it was not on screen, but now it is)
-  Open = 'open',
+  Open = 'Open',
   // Target was closed by the user (it was on screen, but now it is not)
-  Close = 'close',
+  Close = 'Close',
   // Target was cancelled by the user (it was on closed without saving)
-  Cancel = 'cancel',
+  Cancel = 'Cancel',
   // Target was expanded by the user (it always remains on screen, but size was changed)
-  Expand = 'expand',
+  Expand = 'Expand',
   // Target was collapsed by the user (it always remains on screen, but size was changed)
-  Collapse = 'collapse',
+  Collapse = 'Collapse',
   // Target was viewed by the user (only for items that are not opened or closed, those must use Open/Close actions)
-  View = 'view',
+  View = 'View',
   // Target interrupted the user (popup, dialog, validation message, etc. appeared without user prompting)
-  Interrupt = 'interrupt',
+  Interrupt = 'Interrupt',
   // Target was created by the user (it did not exist before)
-  Create = 'create',
+  Create = 'Create',
   // Target was edited by the user (it existed and was changed)
-  Edit = 'edit',
+  Edit = 'Edit',
   // Target was deleted by the user (it existed and now it doesn't)
-  Delete = 'delete',
+  Delete = 'Delete',
   // Target was added by the user (it already existed and was added to another place)
-  Add = 'add',
+  Add = 'Add',
   // Target was removed by the user (it was removed from something but still exists)
-  Remove = 'remove',
+  Remove = 'Remove',
   // Target was activated by the user (click, check, tap, keypress, etc.)
-  Activate = 'activate',
+  Activate = 'Activate',
   // Target was deactivated by the user (click away, uncheck, tap outside of, tab away, etc.)
-  Deactivate = 'deactivate',
+  Deactivate = 'Deactivate',
   // User showed interest in a target (hover, peek, etc.)
-  Peek = 'peek',
+  Peek = 'Peek',
   // Unknown action
-  Unknown = 'unknown',
+  Unknown = 'Unknown',
 };
 
 export default LogAction;

package/src/types/LogBuiltInMetadata.ts

@@ -5,14 +5,14 @@
 const LogBuiltInMetadata = {
   // Contexts
   Context: {
-    Uncategorized: 'n/a',
-    ServerRenderedErrorPage: '_server-rendered-error-page',
-    ServerEndpointError: '_server-endpoint-error',
-    ClientFatalError: '_client-fatal-error',
+    Uncategorized: 'Uncategorized',
+    ServerRenderedErrorPage: 'ServerRenderedErrorPage',
+    ServerEndpointError: 'ServerEndpointError',
+    ClientFatalError: 'ClientFatalError',
   },
   // Targets
   Target: {
-    NoSpecificTarget: 'n/a',
+    NoTarget: 'NoTarget',
   },
 };
 

package/src/types/LogMetadataContextMap.ts

@@ -0,0 +1,15 @@
+/**
+ * Type of the context map in a LogMetadata file
+ * @author Gabe Abrams
+ */
+type LogMetadataContextMap = {
+  [k: string]: (
+    | string
+    | {
+      _: string,
+      [k: string]: string
+    }
+  )
+};
+
+export default LogMetadataContextMap;

package/src/types/LogMetadataTagMap.ts

@@ -0,0 +1,9 @@
+/**
+ * Type of the tag map inside a LogMetadata file
+ * @author Gabe Abrams
+ */
+type LogMetadataTagMap = {
+  [k: string]: string
+};
+
+export default LogMetadataTagMap;

package/src/types/LogMetadataTargetMap.ts

@@ -0,0 +1,9 @@
+/**
+ * Type of the target map inside a LogMetadata file
+ * @author Gabe Abrams
+ */
+type LogMetadataTargetMap = {
+  [k: string]: string
+};
+
+export default LogMetadataTargetMap;

package/src/types/LogMetadataType.ts

@@ -1,23 +1,16 @@
+// Import shared types
+import LogMetadataContextMap from './LogMetadataContextMap';
+import LogMetadataTagMap from './LogMetadataTagMap';
+import LogMetadataTargetMap from './LogMetadataTargetMap';
+
 /**
  * Type of a LogMetadata file
  * @author Gabe Abrams
  */
 type LogMetadataType = {
-  Context?: {
-    [k: string]: (
-      | string
-      | {
-        _: string,
-        [k: string]: string
-      }
-    )
-  },
-  Tag?: {
-    [k: string]: string
-  },
-  Target?: {
-    [k: string]: string
-  },
+  Context?: LogMetadataContextMap,
+  Tag?: LogMetadataTagMap,
+  Target?: LogMetadataTargetMap,
 };
 
 export default LogMetadataType;