db-migrate 1.0.0-beta.21 → 1.0.0-beta.23

package/README.md

@@ -1,10 +1,6 @@
 [![Backers on Open Collective](https://opencollective.com/node-db-migrate/backers/badge.svg)](#backers) [![Sponsors on Open Collective](https://opencollective.com/node-db-migrate/sponsors/badge.svg)](#sponsors)
 [![Build Status](https://github.com/db-migrate/node-db-migrate/actions/workflows/ci.yml/badge.svg?branch=master)](https://github.com/db-migrate/node-db-migrate/actions/workflows/ci.yml)
-[![Dependency Status](https://david-dm.org/db-migrate/node-db-migrate.svg)](https://david-dm.org/db-migrate/node-db-migrate)
-[![devDependency Status](https://david-dm.org/db-migrate/node-db-migrate/dev-status.svg)](https://david-dm.org/db-migrate/node-db-migrate#info=devDependencies)
 [![Documentation Status](https://readthedocs.org/projects/db-migrate/badge/?version=latest)](https://readthedocs.org/projects/db-migrate/?badge=latest)
-[![Code Quality: Javascript](https://img.shields.io/lgtm/grade/javascript/g/db-migrate/node-db-migrate.svg?logo=lgtm&logoWidth=18)](https://lgtm.com/projects/g/db-migrate/node-db-migrate/context:javascript)
-[![Total Alerts](https://img.shields.io/lgtm/alerts/g/db-migrate/node-db-migrate.svg?logo=lgtm&logoWidth=18)](https://lgtm.com/projects/g/db-migrate/node-db-migrate/alerts)
 
 # db-migrate
 

package/api.js

@@ -245,6 +245,31 @@ dbmigrate.prototype = {
     );
   },
 
+  fix: function (specification, opts, callback) {
+    var executeFix = load('fix');
+
+    if (arguments.length > 0) {
+      if (typeof specification === 'string') {
+        this.internals.argv.destination = specification;
+      } else if (typeof specification === 'number') {
+        this.internals.argv.count = specification;
+      } else if (typeof specification === 'function') {
+        callback = specification;
+      }
+
+      if (typeof opts === 'string') {
+        this.internals.migrationMode = opts;
+        this.internals.matching = opts;
+      } else if (typeof opts === 'function') {
+        callback = opts;
+      }
+    }
+
+    return Promise.resolve(executeFix(this.internals, this.config)).nodeify(
+      callback
+    );
+  },
+
   check: function (specification, opts, callback) {
     var executeCheck = load('check');
 

package/lib/commands/fix.js

@@ -0,0 +1,52 @@
+var path = require('path');
+var log = require('db-migrate-shared').log;
+var migrationHook = require('./helper/migration-hook.js');
+
+async function prepare (internals, config) {
+  try {
+    await migrationHook(internals);
+    var Migrator = require('../walker.js');
+    var index = require('../../connect');
+
+    if (!internals.argv.count) {
+      internals.argv.count = Number.MAX_VALUE;
+    }
+    const migrator = await index.connect(
+      {
+        config: config.getCurrent().settings,
+        internals: internals,
+        prefix: 'migration'
+      },
+      Migrator
+    );
+
+    if (internals.locTitle) {
+      migrator.directory = path.resolve(
+        internals.argv['migrations-dir'],
+        internals.locTitle
+      );
+    } else {
+      migrator.directory = path.resolve(internals.argv['migrations-dir']);
+    }
+
+    internals.migrationsDir = migrator.directory;
+
+    await migrator.createMigrationsTable();
+    log.verbose('migration table created');
+
+    return migrator;
+  } catch (err) {
+    throw err;
+  }
+}
+
+module.exports = async function (internals, config) {
+  const migrator = await prepare(internals, config);
+
+  try {
+    const res = await migrator.fix(internals.argv);
+    return internals.onComplete(migrator, internals, null, res);
+  } catch (err) {
+    return internals.onComplete(migrator, internals, err);
+  }
+};

package/lib/commands/generated.js

@@ -9,6 +9,7 @@ const files = {
   "db": require('./db.js'),
   "down": require('./down.js'),
   "dump": require('./dump.js'),
+  "fix": require('./fix.js'),
   "fn/plugin": require('./fn/plugin.js'),
   "generated": require('./generated.js'),
   "helper/assert": require('./helper/assert.js'),

package/lib/commands/run.js

@@ -36,6 +36,7 @@ function run (internals, config) {
 
       executeSync(internals, config);
       break;
+    case 'fix':
     case 'up':
     case 'down':
     case 'reset':
@@ -58,6 +59,9 @@ function run (internals, config) {
       if (action === 'up') {
         var executeUp = load('up');
         executeUp(internals, config);
+      } else if (action === 'fix') {
+        var executeFix = load('fix');
+        executeFix(internals, config);
       } else {
         var executeDown = load('down');
         executeDown(internals, config);

package/lib/executors/versioned/v2.js

@@ -9,6 +9,7 @@ const StateTravel = require('../../methods/v2/statetravel');
 const Migrate = require('../../methods/v2/migrate');
 const TranslateState = require('../../methods/v2/translatestate');
 const AddConventions = require('../../methods/v2/conventions');
+const util = require('util');
 
 const execUnit = {
   _extend: (context, type) => {
@@ -65,6 +66,45 @@ const execUnit = {
     // end migration, same as start migration
   },
 
+  fix: async function (context, driver, file) {
+    const _file = file.get();
+    const chain = new Chain(context._driver, file, driver, context.internals);
+    if (!_file._meta.noDefaultColumn) {
+      chain.addChain(AddConventions);
+    }
+    chain.addChain(Learn);
+    // chain.addChain(StateTravel);
+
+    await State.startMigration(context._driver, file, context.internals);
+    // startMigration - needs secondary instance since we can not afford to
+    // loose state and the transaction start will include these for roll back
+    // we will disable them probably at all from DDL when the driver does not
+    // explicitly signal DDL transaction support (like crdb)
+    try {
+      await _file.migrate(chain, {
+        options: context.internals.safeOptions,
+        seedLink: context.seedLink,
+        dbm: context.internals.safeOptions.dbmigrate
+      });
+    } catch (err) {
+      context.internals.rollback = true;
+
+      // transfer last state
+      chain.transferInt();
+
+      log.error(
+        'An error occured. No alternative failure strategy defined. Rolling back!',
+        err
+      );
+      await execUnit.down(context, driver, file);
+      throw err;
+    }
+    await Promise.promisify(context.writeMigrationRecord.bind(context))(file);
+    await State.endMigration(context._driver, file, context.internals);
+    log.verbose(`[fix] current schema`, util.inspect(context.internals.schema, false, null, true));
+    // end migration, same as start migration
+  },
+
   down: async function (context, driver, file) {
     // start migration, see up comments
     await State.startMigration(context._driver, file, context.internals);

package/lib/learn.js

@@ -2,7 +2,7 @@ const Promise = require('bluebird');
 const Shadow = require('./driver/shadow');
 
 class STD {
-  constructor ({ schema, modSchema: mod }, driver) {
+  constructor ({ schema, modSchema: mod, unlearn }, driver) {
     this.checkColumn = function (t, c) {
       if (!this.schema[t]) {
         throw new Error(`There is no ${t} table in schema!`);
@@ -12,6 +12,7 @@ class STD {
         throw new Error(`There is no ${c} column in schema!`);
       }
     };
+    this.unlearn = unlearn;
     this.validations = {};
     this.driver = driver;
     this.indizies = schema.i;
@@ -21,10 +22,14 @@ class STD {
       schema.e = {};
     }
     this.extra = schema.e;
+    if (unlearn) {
+      this.modC = [];
+    } else {
+      this.modC = mod.s;
+    }
     this.modS = mod.c;
     this.modI = mod.i;
     this.modF = mod.f;
-    this.modC = mod.s;
   }
 
   dropTable (t) {
@@ -124,7 +129,7 @@ class STD {
     const hasColumns = this.schema[t].columns !== undefined;
     const columns = hasColumns ? this.schema[t].columns : this.schema[t];
 
-    if (columns[c].notNull === true) {
+    if (columns[c].notNull === true && !this.unlearn) {
       if (this.validations.columnStrategies !== true) {
         if (
           this.driver._meta &&
@@ -172,7 +177,7 @@ class STD {
 
     this.modS[t] = {};
 
-    if (columns[c].notNull === true) {
+    if (columns[c].notNull === true && !this.unlearn) {
       switch (o.columnStrategy) {
         case 'delay':
           this.modS[t][c] = columns[c];
@@ -196,7 +201,7 @@ class STD {
           this.modC.push({ t: 1, a: 'addColumn', c: [t, c, o] });
           break;
       }
-    } else {
+    } else if (!this.unlearn) {
       this.modS[t][c] = columns[c];
 
       this.modC.push({ t: 1, a: 'addColumn', c: [t, c, o] });

package/lib/methods/v2/translatestate.js

@@ -2,6 +2,7 @@ const Promise = require('bluebird');
 const State = require('../../state');
 const Chain = require('../../chain');
 const Migrate = require('./migrate');
+const Learn = require('../../learn');
 const log = require('db-migrate-shared').log;
 
 const methods = {
@@ -107,7 +108,9 @@ module.exports = async (context, file, driver, internals) => {
   const mod = internals.modSchema;
 
   const chain = new Chain(context, file, driver, internals);
-  // chain.addChain(Learn);
+  internals.unlearn = true;
+
+  chain.addChain(Learn);
   chain.addChain(Migrate);
   await Promise.resolve(mod.s.reverse()).each(args =>
     processEntry(context, file, chain, internals, args)

package/lib/walker.js

@@ -239,6 +239,65 @@ Walker.prototype = {
       .nodeify(callback);
   },
 
+  fix: function (options, callback) {
+    const partialName = options.destination;
+    const count = options.count;
+    const sortFn = function (a, b) {
+      a = a.name.slice(0, a.name.indexOf('-'));
+      b = b.name.slice(0, b.name.indexOf('-'));
+
+      if (!isNaN(a)) {
+        return a - b;
+      }
+
+      return a.localeCompare(b);
+    };
+
+    const files = File.loadFromDatabase(
+      this.directory,
+      this.prefix,
+      this._driver,
+      this.internals
+    ).then(completedFiles => {
+      const toRun = dbmUtil.filterDown(completedFiles, partialName, count).sort(sortFn);
+
+      if (toRun.length === 0) {
+        log.info(this.title + 'Nothing to run');
+      }
+
+      if (this.internals.check) {
+        const toRunNames = toRun.map(migration => migration.name);
+        log.info(this.title + 'run:', toRunNames);
+        return toRunNames;
+      }
+
+      return toRun;
+    });
+
+    if (this.internals.check) {
+      return files.nodeify(callback);
+    }
+
+    return files
+      .each(file => {
+        log.verbose(this.title + 'preparing to run fix:', file.name);
+        const _meta = file.get()._meta || {};
+        const version = _meta.version || 1;
+        if (version < 2) {
+          log.warn(`${this.title} skipping "${file.name}" as v1 migrations do not maintain a schema`);
+          return Promise.resolve();
+        }
+
+        this.internals.modSchema = { i: {}, c: {}, f: {}, s: [] };
+        return require(`./executors/versioned/v${version}`).fix(
+          this,
+          this.driver,
+          file
+        );
+      })
+      .nodeify(callback);
+  },
+
   check: function (options, callback) {
     return Promise.all([
       File.loadFromDatabase(

package/package.json

@@ -31,7 +31,7 @@
     "programable",
     "api"
   ],
-  "version": "1.0.0-beta.21",
+  "version": "1.0.0-beta.23",
   "engines": {
     "node": ">=8.0.0"
   },
@@ -54,7 +54,6 @@
     "parse-database-url": "~0.3.0",
     "rc": "^1.2.8",
     "resolve": "^1.19.0",
-    "semver": "^5.3.0",
     "tunnel-ssh": "^4.0.0",
     "yargs": "^17.5.1"
   },
@@ -64,8 +63,8 @@
     "@hapi/eslint-plugin": "^6.0.0",
     "@hapi/lab": "25.x",
     "db-migrate-base": "^2.1.1",
-    "db-migrate-mysql": "^2.1.1",
-    "db-migrate-sqlite3": "^0.4.0",
+    "db-migrate-mysql": "^2.2.0",
+    "db-migrate-sqlite3": "^0.5.0",
     "eslint": "^7.32.0",
     "eslint-config-standard": "^14.1.1",
     "eslint-plugin-import": "^2.26.0",