dazscript-framework 1.0.40 → 1.0.41

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "dazscript-framework",
-  "version": "1.0.40",
+  "version": "1.0.41",
   "author": "Freddy Diaz",
   "license": "MPL-2.0",
   "description": "",

package/src/helpers/file-helper.test.ts

@@ -36,11 +36,39 @@ vi.stubGlobal('DzDir', FakeDir)
 import { saveToFile } from './file-helper'
 
 describe('saveToFile', () => {
-    beforeEach(() => vi.clearAllMocks())
+    beforeEach(() => {
+        vi.clearAllMocks()
+        open.mockReturnValue(false)
+        write.mockReturnValue(-1)
+    })
 
     it('fails without writing when the file cannot be opened', () => {
         expect(saveToFile('C:/temp/settings.json', '{}')).toBe(false)
         expect(open).toHaveBeenCalledWith(FakeFile.WriteOnly)
         expect(write).not.toHaveBeenCalled()
     })
+
+    it('fails when writing reports an error', () => {
+        open.mockReturnValue(true)
+
+        expect(saveToFile('C:/temp/settings.json', '{}')).toBe(false)
+        expect(write).toHaveBeenCalledWith('{}')
+        expect(close).toHaveBeenCalledOnce()
+    })
+
+    it('fails when writing stores no bytes', () => {
+        open.mockReturnValue(true)
+        write.mockReturnValue(0)
+
+        expect(saveToFile('C:/temp/settings.json', '{}')).toBe(false)
+        expect(close).toHaveBeenCalledOnce()
+    })
+
+    it('succeeds when the file opens and writes', () => {
+        open.mockReturnValue(true)
+        write.mockReturnValue(2)
+
+        expect(saveToFile('C:/temp/settings.json', '{}')).toBe(true)
+        expect(close).toHaveBeenCalledOnce()
+    })
 })

package/src/helpers/file-helper.ts

@@ -32,22 +32,26 @@ export const readFromFile = <T>(filePath: string, cache: boolean = false): T | n
  * @returns
  */
 export const saveToFile = (filePath: string, content: string): boolean => {
+    let fileInfo: DzFileInfo | null = null
+    let file: DzFile | null = null
+    let opened = false
     try {
         if (!filePath || !content) return false
-        let fileInfo = new DzFileInfo(filePath)
+        fileInfo = new DzFileInfo(filePath)
         let path = fileInfo.absolutePath()
         var dzDir = new DzDir(path)
         dzDir.mkpath(path)
-        var file = new DzFile(`${filePath}`)
-        file.open(DzFile.WriteOnly)
-        file.write(content)
-        file.close()
-        fileInfo.deleteLater()
-        file.deleteLater()
-        return true
+        file = new DzFile(`${filePath}`)
+        opened = file.open(DzFile.WriteOnly)
+        if (!opened) return false
+        return file.write(content) > 0
     } catch (error) {
         log.error(`Error while saving file ${filePath}`)
         return false
+    } finally {
+        if (opened) file?.close()
+        fileInfo?.deleteLater()
+        file?.deleteLater()
     }
 }