daycare-cli 0.0.0-canary.f57680e

package/dist/engine/agents/ops/agentLoopRun.spec.js

@@ -0,0 +1,1074 @@
+import { describe, expect, it, vi } from "vitest";
+import { agentLoopRun } from "./agentLoopRun.js";
+import { messageExtractText } from "../../messages/messageExtractText.js";
+describe("agentLoopRun", () => {
+    it("does not auto-send files from tool results when model has no final text", async () => {
+        const connectorSend = vi.fn(async (_targetId, _message) => undefined);
+        const connector = connectorBuild(connectorSend);
+        const entry = entryBuild();
+        const context = contextBuild();
+        const inferenceRouter = inferenceRouterBuild([
+            assistantMessageBuild([
+                toolCallBuild("call-1", "generate_image", { prompt: "draw cat" })
+            ]),
+            assistantMessageBuild([])
+        ]);
+        const toolResolver = toolResolverBuild(async (toolCall) => {
+            if (toolCall.name !== "generate_image") {
+                throw new Error(`Unexpected tool: ${toolCall.name}`);
+            }
+            return toolResultGeneratedBuild("/workspace/files/generated-image.png", toolCall.id, toolCall.name);
+        });
+        await agentLoopRun(optionsBuild({
+            entry,
+            context,
+            connector,
+            inferenceRouter,
+            toolResolver
+        }));
+        expect(connectorSend).not.toHaveBeenCalled();
+    });
+    it("reads skills via facade before each inference call", async () => {
+        const firstSkills = [
+            {
+                id: "config:alpha",
+                name: "alpha",
+                description: "first",
+                path: "/tmp/alpha/SKILL.md",
+                source: "config"
+            }
+        ];
+        const secondSkills = [
+            {
+                id: "config:beta",
+                name: "beta",
+                description: "second",
+                path: "/tmp/beta/SKILL.md",
+                source: "config"
+            }
+        ];
+        const skillsList = vi
+            .fn(async () => firstSkills)
+            .mockResolvedValueOnce(firstSkills)
+            .mockResolvedValueOnce(secondSkills);
+        const skills = { list: skillsList };
+        const tools = [
+            {
+                name: "run_python",
+                description: "run python",
+                parameters: {}
+            }
+        ];
+        const toolDescriptionsSeen = [];
+        const toolResolverSkills = [];
+        const connector = connectorBuild(vi.fn(async () => undefined));
+        const entry = entryBuild();
+        const context = contextBuild();
+        const inferenceRouter = {
+            complete: vi
+                .fn()
+                .mockImplementationOnce(async (incomingContext) => {
+                toolDescriptionsSeen.push(String(incomingContext.tools?.[0]?.description ?? ""));
+                return {
+                    message: assistantMessageBuild([
+                        toolCallBuild("call-1", "run_python", { code: "print(1)" })
+                    ]),
+                    providerId: "provider-1",
+                    modelId: "model-1"
+                };
+            })
+                .mockImplementationOnce(async (incomingContext) => {
+                toolDescriptionsSeen.push(String(incomingContext.tools?.[0]?.description ?? ""));
+                return {
+                    message: assistantMessageBuild([]),
+                    providerId: "provider-1",
+                    modelId: "model-1"
+                };
+            })
+        };
+        const toolResolver = {
+            listTools: vi.fn(() => tools),
+            execute: vi.fn(async (_toolCall, executeContext) => {
+                toolResolverSkills.push(executeContext.skills);
+                return toolResultTextBuild("call-1", "run_python", "ok");
+            })
+        };
+        await agentLoopRun(optionsBuild({
+            entry,
+            context,
+            connector,
+            inferenceRouter,
+            toolResolver,
+            skills,
+            rlm: true
+        }));
+        expect(skillsList).toHaveBeenCalledTimes(2);
+        expect(toolDescriptionsSeen).toHaveLength(2);
+        expect(toolDescriptionsSeen[0]).toContain("Execute Python code to complete the task.");
+        expect(toolDescriptionsSeen[1]).toContain("Execute Python code to complete the task.");
+        expect(toolDescriptionsSeen[0]).not.toContain("alpha");
+        expect(toolDescriptionsSeen[1]).not.toContain("beta");
+        expect(toolResolverSkills).toHaveLength(1);
+        expect(toolResolverSkills[0]).toEqual(firstSkills);
+    });
+    it("completes unfinished tool calls with abort records", async () => {
+        const controller = new AbortController();
+        const appended = [];
+        const connector = connectorBuild(vi.fn(async () => undefined));
+        const entry = entryBuild();
+        const context = contextBuild();
+        const inferenceRouter = inferenceRouterBuild([
+            assistantMessageBuild([
+                toolCallBuild("call-1", "run_python", { code: "print(1)" }),
+                toolCallBuild("call-2", "read_file", { path: "notes.txt" })
+            ])
+        ]);
+        const toolResolver = toolResolverBuild(async () => {
+            controller.abort();
+            const error = new Error("aborted");
+            error.name = "AbortError";
+            throw error;
+        });
+        const result = await agentLoopRun(optionsBuild({
+            entry,
+            context,
+            connector,
+            inferenceRouter,
+            toolResolver,
+            abortSignal: controller.signal,
+            appendHistoryRecord: async (record) => {
+                appended.push(record.type);
+            }
+        }));
+        const abortedResults = result.historyRecords.filter((record) => record.type === "tool_result");
+        expect(abortedResults).toHaveLength(2);
+        for (const record of abortedResults) {
+            if (record.type !== "tool_result") {
+                continue;
+            }
+            expect(record.output.toolMessage.isError).toBe(true);
+            expect(record.output.toolMessage.content).toEqual([
+                { type: "text", text: "User aborted before tool completion." }
+            ]);
+        }
+        expect(appended).toEqual(["assistant_message", "tool_result", "tool_result"]);
+    });
+    it("passes appendHistoryRecord through tool execution context", async () => {
+        const appendHistoryRecord = vi.fn(async () => undefined);
+        const connector = connectorBuild(vi.fn(async () => undefined));
+        const entry = entryBuild();
+        const context = contextBuild();
+        const inferenceRouter = inferenceRouterBuild([
+            assistantMessageBuild([toolCallBuild("call-1", "read_file", { path: "x" })]),
+            assistantMessageBuild([])
+        ]);
+        const execute = vi.fn(async () => toolResultTextBuild("call-1", "read_file", "ok"));
+        const toolResolver = {
+            listTools: () => [],
+            execute
+        };
+        await agentLoopRun(optionsBuild({
+            entry,
+            context,
+            connector,
+            inferenceRouter,
+            toolResolver,
+            appendHistoryRecord,
+            rlm: true
+        }));
+        expect(execute).toHaveBeenCalledTimes(1);
+        expect(execute).toHaveBeenCalledWith(expect.anything(), expect.objectContaining({ appendHistoryRecord, rlmToolOnly: true }));
+    });
+    it("uses persisted inference session id for inference calls", async () => {
+        const connector = connectorBuild(vi.fn(async () => undefined));
+        const entry = entryBuild();
+        const context = contextBuild();
+        const inferenceRouter = {
+            complete: vi.fn(async () => ({
+                message: assistantMessageBuild([]),
+                providerId: "provider-1",
+                modelId: "model-1"
+            }))
+        };
+        const toolResolver = toolResolverBuild(async () => toolResultTextBuild("call-1", "noop", "ok"));
+        await agentLoopRun(optionsBuild({
+            entry,
+            context,
+            connector,
+            inferenceRouter,
+            toolResolver,
+            inferenceSessionId: "session-abc"
+        }));
+        expect(inferenceRouter.complete).toHaveBeenCalledTimes(1);
+        expect(inferenceRouter.complete).toHaveBeenCalledWith(expect.anything(), "session-abc", expect.anything());
+    });
+    it("executes run_python tags and injects python_result user messages in noTools mode", async () => {
+        const appendHistoryTypes = [];
+        const contexts = [];
+        const connector = connectorBuild(vi.fn(async () => undefined));
+        const entry = entryBuild();
+        const context = contextBuild();
+        const inferenceRouter = {
+            complete: vi.fn(async (incomingContext) => {
+                contexts.push(structuredClone(incomingContext));
+                if (contexts.length === 1) {
+                    return {
+                        message: assistantMessageBuild([
+                            { type: "text", text: "<run_python>value = echo()\nvalue</run_python>" }
+                        ]),
+                        providerId: "provider-1",
+                        modelId: "model-1"
+                    };
+                }
+                return {
+                    message: assistantMessageBuild([{ type: "text", text: "done" }]),
+                    providerId: "provider-1",
+                    modelId: "model-1"
+                };
+            })
+        };
+        const execute = vi.fn(async (toolCall) => {
+            if (toolCall.name !== "echo") {
+                throw new Error(`Unexpected tool: ${toolCall.name}`);
+            }
+            return toolResultTextBuild(toolCall.id, toolCall.name, "ok");
+        });
+        const toolResolver = {
+            listTools: vi.fn(() => [
+                { name: "run_python", description: "", parameters: {} },
+                { name: "echo", description: "", parameters: {} }
+            ]),
+            execute
+        };
+        await agentLoopRun(optionsBuild({
+            entry,
+            context,
+            connector,
+            inferenceRouter,
+            toolResolver,
+            noTools: true,
+            rlm: true,
+            say: true,
+            appendHistoryRecord: async (record) => {
+                appendHistoryTypes.push(record.type);
+            }
+        }));
+        expect(inferenceRouter.complete).toHaveBeenCalledTimes(2);
+        expect(contexts[0]?.tools).toEqual([]);
+        expect(execute).toHaveBeenCalledTimes(1);
+        const secondIterationMessages = contexts[1]?.messages ?? [];
+        const hasPythonResultMessage = secondIterationMessages.some((message) => {
+            if (message.role !== "user" || !Array.isArray(message.content)) {
+                return false;
+            }
+            return message.content.some((part) => part.type === "text" &&
+                typeof part.text === "string" &&
+                part.text.includes("<python_result>") &&
+                part.text.includes("Python execution completed."));
+        });
+        expect(hasPythonResultMessage).toBe(true);
+        expect(appendHistoryTypes).toContain("rlm_start");
+        expect(appendHistoryTypes).toContain("rlm_tool_call");
+        expect(appendHistoryTypes).toContain("rlm_tool_result");
+        expect(appendHistoryTypes).toContain("rlm_complete");
+    });
+    it("executes multiple run_python tags sequentially and stops at the first failure", async () => {
+        const contexts = [];
+        const connector = connectorBuild(vi.fn(async () => undefined));
+        const entry = entryBuild();
+        const context = contextBuild();
+        const inferenceRouter = {
+            complete: vi.fn(async (incomingContext) => {
+                contexts.push(structuredClone(incomingContext));
+                if (contexts.length === 1) {
+                    return {
+                        message: assistantMessageBuild([
+                            {
+                                type: "text",
+                                text: [
+                                    "<run_python>echo()</run_python>",
+                                    "<run_python>fail()</run_python>",
+                                    "<run_python>tail()</run_python>"
+                                ].join("")
+                            }
+                        ]),
+                        providerId: "provider-1",
+                        modelId: "model-1"
+                    };
+                }
+                return {
+                    message: assistantMessageBuild([{ type: "text", text: "done" }]),
+                    providerId: "provider-1",
+                    modelId: "model-1"
+                };
+            })
+        };
+        const execute = vi.fn(async (toolCall) => {
+            if (toolCall.name === "echo") {
+                return toolResultTextBuild(toolCall.id, toolCall.name, "ok");
+            }
+            if (toolCall.name === "fail") {
+                throw new Error("boom");
+            }
+            throw new Error(`Unexpected tool: ${toolCall.name}`);
+        });
+        const toolResolver = {
+            listTools: vi.fn(() => [
+                { name: "run_python", description: "", parameters: {} },
+                { name: "echo", description: "", parameters: {} },
+                { name: "fail", description: "", parameters: {} },
+                { name: "tail", description: "", parameters: {} }
+            ]),
+            execute
+        };
+        await agentLoopRun(optionsBuild({
+            entry,
+            context,
+            connector,
+            inferenceRouter,
+            toolResolver,
+            noTools: true,
+            rlm: true,
+            say: true
+        }));
+        expect(inferenceRouter.complete).toHaveBeenCalledTimes(2);
+        expect(execute).toHaveBeenCalledTimes(2);
+        expect(execute).toHaveBeenNthCalledWith(1, expect.objectContaining({ name: "echo" }), expect.anything());
+        expect(execute).toHaveBeenNthCalledWith(2, expect.objectContaining({ name: "fail" }), expect.anything());
+        const assistantMessage = contexts[1]?.messages.find((message) => message.role === "assistant");
+        const assistantText = assistantMessage ? messageExtractText(assistantMessage) ?? "" : "";
+        expect(assistantText).toContain("<run_python>echo()</run_python>");
+        expect(assistantText).toContain("<run_python>fail()</run_python>");
+        expect(assistantText).not.toContain("<run_python>tail()</run_python>");
+        const secondIterationMessages = contexts[1]?.messages ?? [];
+        const pythonResultTexts = secondIterationMessages
+            .filter((message) => message.role === "user")
+            .flatMap((message) => (Array.isArray(message.content) ? message.content : []))
+            .filter((part) => part.type === "text" && typeof part.text === "string" && part.text.includes("<python_result>"))
+            .map((part) => part.text);
+        expect(pythonResultTexts).toHaveLength(2);
+        expect(pythonResultTexts[0]).toContain("Python execution completed.");
+        expect(pythonResultTexts[1]).toContain("Python runtime error.");
+    });
+    it("suppresses raw run_python text delivery in noTools mode", async () => {
+        const connectorSend = vi.fn(async () => undefined);
+        const connector = connectorBuild(connectorSend);
+        const entry = entryBuild();
+        const context = contextBuild();
+        const inferenceRouter = inferenceRouterBuild([
+            assistantMessageBuild([
+                { type: "text", text: "<run_python>echo()</run_python>" }
+            ]),
+            assistantMessageBuild([])
+        ]);
+        const execute = vi.fn(async (toolCall) => {
+            return toolResultTextBuild(toolCall.id, toolCall.name, "ok");
+        });
+        const toolResolver = {
+            listTools: vi.fn(() => [
+                { name: "run_python", description: "", parameters: {} },
+                { name: "echo", description: "", parameters: {} }
+            ]),
+            execute
+        };
+        await agentLoopRun(optionsBuild({
+            entry,
+            context,
+            connector,
+            inferenceRouter,
+            toolResolver,
+            noTools: true,
+            rlm: true,
+            say: true
+        }));
+        expect(execute).toHaveBeenCalledTimes(1);
+        expect(connectorSend).not.toHaveBeenCalled();
+    });
+    it("appends assistant_rewrite history events for say-after and failed run_python rewrites", async () => {
+        const appendedRecords = [];
+        const connector = connectorBuild(vi.fn(async () => undefined));
+        const entry = entryBuild();
+        const context = contextBuild();
+        const inferenceRouter = inferenceRouterBuild([
+            assistantMessageBuild([
+                {
+                    type: "text",
+                    text: [
+                        "<say>before</say>",
+                        "<run_python>echo()</run_python>",
+                        "<run_python>fail()</run_python>",
+                        "<run_python>tail()</run_python>",
+                        "<say>after</say>"
+                    ].join("")
+                }
+            ]),
+            assistantMessageBuild([])
+        ]);
+        const execute = vi.fn(async (toolCall) => {
+            if (toolCall.name === "echo") {
+                return toolResultTextBuild(toolCall.id, toolCall.name, "ok");
+            }
+            if (toolCall.name === "fail") {
+                throw new Error("boom");
+            }
+            throw new Error(`Unexpected tool: ${toolCall.name}`);
+        });
+        const toolResolver = {
+            listTools: vi.fn(() => [
+                { name: "run_python", description: "", parameters: {} },
+                { name: "echo", description: "", parameters: {} },
+                { name: "fail", description: "", parameters: {} },
+                { name: "tail", description: "", parameters: {} }
+            ]),
+            execute
+        };
+        await agentLoopRun(optionsBuild({
+            entry,
+            context,
+            connector,
+            inferenceRouter,
+            toolResolver,
+            noTools: true,
+            rlm: true,
+            say: true,
+            appendHistoryRecord: async (record) => {
+                appendedRecords.push(record);
+            }
+        }));
+        const assistant = appendedRecords.find((record) => record.type === "assistant_message");
+        if (!assistant || assistant.type !== "assistant_message") {
+            throw new Error("Expected assistant history record.");
+        }
+        expect(assistant.text).toContain("<run_python>tail()</run_python>");
+        expect(assistant.text).toContain("<say>after</say>");
+        const rewrites = appendedRecords.filter((record) => record.type === "assistant_rewrite");
+        expect(rewrites).toHaveLength(2);
+        expect(rewrites[0]).toMatchObject({
+            type: "assistant_rewrite",
+            reason: "run_python_say_after_trim"
+        });
+        expect(rewrites[1]).toMatchObject({
+            type: "assistant_rewrite",
+            reason: "run_python_failure_trim"
+        });
+        expect(rewrites[0]?.assistantAt).toBe(assistant.at);
+        expect(rewrites[1]?.assistantAt).toBe(assistant.at);
+        expect(rewrites[0]?.text).not.toContain("<say>after</say>");
+        expect(rewrites[1]?.text).not.toContain("<run_python>tail()</run_python>");
+    });
+    it("does not execute run_python tags unless noTools, rlm, and say are all enabled", async () => {
+        const connectorSend = vi.fn(async () => undefined);
+        const connector = connectorBuild(connectorSend);
+        const entry = entryBuild();
+        const context = contextBuild();
+        const inferenceRouter = inferenceRouterBuild([
+            assistantMessageBuild([{ type: "text", text: "<run_python>echo()</run_python>" }])
+        ]);
+        const execute = vi.fn(async (toolCall) => {
+            return toolResultTextBuild(toolCall.id, toolCall.name, "ok");
+        });
+        const toolResolver = {
+            listTools: vi.fn(() => [
+                { name: "run_python", description: "", parameters: {} },
+                { name: "echo", description: "", parameters: {} }
+            ]),
+            execute
+        };
+        await agentLoopRun(optionsBuild({
+            entry,
+            context,
+            connector,
+            inferenceRouter,
+            toolResolver,
+            noTools: true,
+            rlm: true,
+            say: false
+        }));
+        expect(execute).not.toHaveBeenCalled();
+        expect(connectorSend).toHaveBeenCalledTimes(1);
+        expect(connectorSend).toHaveBeenCalledWith("channel-1", {
+            text: "<run_python>echo()</run_python>",
+            replyToMessageId: undefined
+        });
+    });
+});
+describe("agentLoopRun say tag", () => {
+    it("sends only say block content when say feature enabled", async () => {
+        const connectorSend = vi.fn(async () => undefined);
+        const connector = connectorBuild(connectorSend);
+        const entry = entryBuild();
+        const context = contextBuild();
+        const inferenceRouter = inferenceRouterBuild([
+            assistantMessageBuild([{ type: "text", text: "thinking... <say>hello user</say> done" }])
+        ]);
+        const toolResolver = toolResolverBuild(async () => {
+            throw new Error("unexpected");
+        });
+        await agentLoopRun(optionsBuild({ entry, context, connector, inferenceRouter, toolResolver, say: true }));
+        expect(connectorSend).toHaveBeenCalledTimes(1);
+        expect(connectorSend).toHaveBeenCalledWith("channel-1", {
+            text: "hello user",
+            replyToMessageId: undefined
+        });
+    });
+    it("does not fall back to raw text when say send fails", async () => {
+        const connectorSend = vi.fn(async () => {
+            throw new Error("send failed");
+        });
+        const connector = connectorBuild(connectorSend);
+        const entry = entryBuild();
+        const context = contextBuild();
+        const inferenceRouter = inferenceRouterBuild([
+            assistantMessageBuild([{ type: "text", text: "thinking... <say>hello user</say> done" }])
+        ]);
+        const toolResolver = toolResolverBuild(async () => {
+            throw new Error("unexpected");
+        });
+        await agentLoopRun(optionsBuild({ entry, context, connector, inferenceRouter, toolResolver, say: true }));
+        expect(connectorSend).toHaveBeenCalledTimes(1);
+        expect(connectorSend).toHaveBeenCalledWith("channel-1", {
+            text: "hello user",
+            replyToMessageId: undefined
+        });
+    });
+    it("sends multiple say blocks as separate messages", async () => {
+        const connectorSend = vi.fn(async () => undefined);
+        const connector = connectorBuild(connectorSend);
+        const entry = entryBuild();
+        const context = contextBuild();
+        const inferenceRouter = inferenceRouterBuild([
+            assistantMessageBuild([
+                { type: "text", text: "reasoning <say>first</say> more <say>second</say> end" }
+            ])
+        ]);
+        const toolResolver = toolResolverBuild(async () => {
+            throw new Error("unexpected");
+        });
+        await agentLoopRun(optionsBuild({ entry, context, connector, inferenceRouter, toolResolver, say: true }));
+        expect(connectorSend).toHaveBeenCalledTimes(2);
+        expect(connectorSend).toHaveBeenNthCalledWith(1, "channel-1", {
+            text: "first",
+            replyToMessageId: undefined
+        });
+        expect(connectorSend).toHaveBeenNthCalledWith(2, "channel-1", {
+            text: "second",
+            replyToMessageId: undefined
+        });
+    });
+    it("suppresses output when say enabled but no say tags present", async () => {
+        const connectorSend = vi.fn(async () => undefined);
+        const connector = connectorBuild(connectorSend);
+        const entry = entryBuild();
+        const context = contextBuild();
+        const inferenceRouter = inferenceRouterBuild([
+            assistantMessageBuild([{ type: "text", text: "just thinking, no say tags" }])
+        ]);
+        const toolResolver = toolResolverBuild(async () => {
+            throw new Error("unexpected");
+        });
+        await agentLoopRun(optionsBuild({ entry, context, connector, inferenceRouter, toolResolver, say: true }));
+        expect(connectorSend).not.toHaveBeenCalled();
+    });
+    it("does not apply say filtering for background agents", async () => {
+        const connectorSend = vi.fn(async () => undefined);
+        const connector = connectorBuild(connectorSend);
+        const entry = entryBuild();
+        const context = contextBuild();
+        // Background agent with <say> tags — say feature should not activate
+        const inferenceRouter = inferenceRouterBuild([
+            assistantMessageBuild([{ type: "text", text: "thinking <say>hi</say> done" }])
+        ]);
+        const toolResolver = toolResolverBuild(async () => {
+            throw new Error("unexpected");
+        });
+        const result = await agentLoopRun(optionsBuild({
+            entry, context, connector, inferenceRouter, toolResolver,
+            say: true, agentType: "subagent"
+        }));
+        // Background agents have no target (agentDescriptorTargetResolve returns null).
+        // responseText is the full unfiltered text (say not applied to background agents).
+        expect(result.responseText).toBe("thinking <say>hi</say> done");
+    });
+    it("sends full text when say feature disabled", async () => {
+        const connectorSend = vi.fn(async () => undefined);
+        const connector = connectorBuild(connectorSend);
+        const entry = entryBuild();
+        const context = contextBuild();
+        const inferenceRouter = inferenceRouterBuild([
+            assistantMessageBuild([{ type: "text", text: "thinking <say>hi</say> more" }])
+        ]);
+        const toolResolver = toolResolverBuild(async () => {
+            throw new Error("unexpected");
+        });
+        await agentLoopRun(optionsBuild({ entry, context, connector, inferenceRouter, toolResolver, say: false }));
+        // Full text sent, say tags are just text
+        expect(connectorSend).toHaveBeenCalledTimes(1);
+        expect(connectorSend).toHaveBeenCalledWith("channel-1", {
+            text: "thinking <say>hi</say> more",
+            replyToMessageId: undefined
+        });
+    });
+    it("processes say tags before run_python execution when noTools is enabled", async () => {
+        const connectorSend = vi.fn(async () => undefined);
+        const connector = connectorBuild(connectorSend);
+        const entry = entryBuild();
+        const context = contextBuild();
+        const inferenceRouter = inferenceRouterBuild([
+            assistantMessageBuild([
+                {
+                    type: "text",
+                    text: "thinking <say>working</say> <run_python>echo()</run_python>"
+                }
+            ]),
+            assistantMessageBuild([{ type: "text", text: "<say>done</say>" }])
+        ]);
+        const execute = vi.fn(async (toolCall) => {
+            return toolResultTextBuild(toolCall.id, toolCall.name, "ok");
+        });
+        const toolResolver = {
+            listTools: vi.fn(() => [
+                { name: "run_python", description: "", parameters: {} },
+                { name: "echo", description: "", parameters: {} }
+            ]),
+            execute
+        };
+        await agentLoopRun(optionsBuild({
+            entry,
+            context,
+            connector,
+            inferenceRouter,
+            toolResolver,
+            say: true,
+            noTools: true,
+            rlm: true
+        }));
+        expect(connectorSend).toHaveBeenNthCalledWith(1, "channel-1", {
+            text: "working",
+            replyToMessageId: undefined
+        });
+        expect(execute).toHaveBeenCalledTimes(1);
+        const firstSendOrder = connectorSend.mock.invocationCallOrder[0];
+        const firstExecuteOrder = execute.mock.invocationCallOrder[0];
+        expect(firstSendOrder).toBeDefined();
+        expect(firstExecuteOrder).toBeDefined();
+        if (firstSendOrder === undefined || firstExecuteOrder === undefined) {
+            throw new Error("Expected both send and execute calls to be recorded.");
+        }
+        expect(firstSendOrder).toBeLessThan(firstExecuteOrder);
+    });
+    it("ignores post-run_python <say> tags even when execution succeeds", async () => {
+        const connectorSend = vi.fn(async () => undefined);
+        const connector = connectorBuild(connectorSend);
+        const entry = entryBuild();
+        const context = contextBuild();
+        const inferenceRouter = inferenceRouterBuild([
+            assistantMessageBuild([
+                {
+                    type: "text",
+                    text: "<say>before</say><run_python>echo()</run_python><say>after</say>"
+                }
+            ]),
+            assistantMessageBuild([])
+        ]);
+        const execute = vi.fn(async (toolCall) => {
+            return toolResultTextBuild(toolCall.id, toolCall.name, "ok");
+        });
+        const toolResolver = {
+            listTools: vi.fn(() => [
+                { name: "run_python", description: "", parameters: {} },
+                { name: "echo", description: "", parameters: {} }
+            ]),
+            execute
+        };
+        await agentLoopRun(optionsBuild({
+            entry,
+            context,
+            connector,
+            inferenceRouter,
+            toolResolver,
+            say: true,
+            noTools: true,
+            rlm: true
+        }));
+        expect(connectorSend).toHaveBeenCalledTimes(1);
+        expect(connectorSend).toHaveBeenNthCalledWith(1, "channel-1", {
+            text: "before",
+            files: undefined,
+            replyToMessageId: undefined
+        });
+        expect(execute).toHaveBeenCalledTimes(1);
+        const beforeOrder = connectorSend.mock.invocationCallOrder[0];
+        const executeOrder = execute.mock.invocationCallOrder[0];
+        expect(beforeOrder).toBeDefined();
+        expect(executeOrder).toBeDefined();
+        if (beforeOrder === undefined || executeOrder === undefined) {
+            throw new Error("Expected ordered send/execute calls to be recorded.");
+        }
+        expect(beforeOrder).toBeLessThan(executeOrder);
+    });
+    it("rewrites context history by removing post-run_python <say> without adding ignored notice", async () => {
+        const connectorSend = vi.fn(async (_targetId, _message) => undefined);
+        const connector = connectorBuild(connectorSend);
+        const entry = entryBuild();
+        const context = contextBuild();
+        const contexts = [];
+        const inferenceRouter = {
+            complete: vi.fn(async (incomingContext) => {
+                contexts.push(structuredClone(incomingContext));
+                if (contexts.length === 1) {
+                    return {
+                        message: assistantMessageBuild([
+                            {
+                                type: "text",
+                                text: "<say>before</say><run_python>def broken(</run_python><say>after</say>"
+                            }
+                        ]),
+                        providerId: "provider-1",
+                        modelId: "model-1"
+                    };
+                }
+                return {
+                    message: assistantMessageBuild([{ type: "text", text: "<say>next</say>" }]),
+                    providerId: "provider-1",
+                    modelId: "model-1"
+                };
+            })
+        };
+        const toolResolver = {
+            listTools: vi.fn(() => [
+                { name: "run_python", description: "", parameters: {} }
+            ]),
+            execute: vi.fn(async () => {
+                throw new Error("unexpected");
+            })
+        };
+        await agentLoopRun(optionsBuild({
+            entry,
+            context,
+            connector,
+            inferenceRouter,
+            toolResolver,
+            say: true,
+            noTools: true,
+            rlm: true
+        }));
+        expect(contexts).toHaveLength(2);
+        const assistantMessage = contexts[1]?.messages.find((message) => message.role === "assistant");
+        const assistantText = assistantMessage ? messageExtractText(assistantMessage) ?? "" : "";
+        expect(assistantText).toContain("<say>before</say>");
+        expect(assistantText).toContain("</run_python>");
+        expect(assistantText).not.toContain("<say>after</say>");
+        const pythonResultTexts = (contexts[1]?.messages ?? [])
+            .filter((message) => message.role === "user")
+            .flatMap((message) => (Array.isArray(message.content) ? message.content : []))
+            .filter((part) => part.type === "text" && typeof part.text === "string" && part.text.includes("<python_result>"))
+            .map((part) => part.text);
+        expect(pythonResultTexts).toHaveLength(1);
+        expect(pythonResultTexts[0]).toContain("Python syntax error. Fix the code and retry.");
+        const hasPythonResultMessage = (contexts[1]?.messages ?? []).some((message) => {
+            if (message.role !== "user" || !Array.isArray(message.content)) {
+                return false;
+            }
+            return message.content.some((part) => part.type === "text" &&
+                typeof part.text === "string" &&
+                part.text.includes("<python_result>"));
+        });
+        expect(hasPythonResultMessage).toBe(true);
+        const sentTexts = connectorSend.mock.calls.map((call) => {
+            const message = call[1];
+            return message.text ?? null;
+        });
+        expect(sentTexts).toEqual(["before", "next"]);
+    });
+    it("attaches <file> tags to the final <say> block", async () => {
+        const connectorSend = vi.fn(async () => undefined);
+        const connector = connectorBuild(connectorSend);
+        const entry = entryBuild();
+        const context = contextBuild();
+        const inferenceRouter = inferenceRouterBuild([
+            assistantMessageBuild([
+                {
+                    type: "text",
+                    text: [
+                        "<say>first</say>",
+                        "<say>second</say>",
+                        '<file mode="doc">/tmp/file-1__report.pdf</file>'
+                    ].join("")
+                }
+            ])
+        ]);
+        const toolResolver = toolResolverBuild(async () => {
+            throw new Error("unexpected");
+        });
+        await agentLoopRun(optionsBuild({
+            entry,
+            context,
+            connector,
+            inferenceRouter,
+            toolResolver,
+            say: true,
+            fileStore: fileStoreBuild()
+        }));
+        expect(connectorSend).toHaveBeenCalledTimes(2);
+        expect(connectorSend).toHaveBeenNthCalledWith(1, "channel-1", {
+            text: "first",
+            files: undefined,
+            replyToMessageId: undefined
+        });
+        expect(connectorSend).toHaveBeenNthCalledWith(2, "channel-1", {
+            text: "second",
+            files: [
+                {
+                    id: "file-1",
+                    name: "report.pdf",
+                    mimeType: "application/pdf",
+                    size: 10,
+                    path: "/tmp/file-1__report.pdf",
+                    sendAs: "document"
+                }
+            ],
+            replyToMessageId: undefined
+        });
+    });
+    it("sends files with null text when only <file> tags exist in say mode", async () => {
+        const connectorSend = vi.fn(async () => undefined);
+        const connector = connectorBuild(connectorSend);
+        const entry = entryBuild();
+        const context = contextBuild();
+        const inferenceRouter = inferenceRouterBuild([
+            assistantMessageBuild([
+                {
+                    type: "text",
+                    text: "thinking... <file>/tmp/file-1__report.pdf</file>"
+                }
+            ])
+        ]);
+        const toolResolver = toolResolverBuild(async () => {
+            throw new Error("unexpected");
+        });
+        await agentLoopRun(optionsBuild({
+            entry,
+            context,
+            connector,
+            inferenceRouter,
+            toolResolver,
+            say: true,
+            fileStore: fileStoreBuild()
+        }));
+        expect(connectorSend).toHaveBeenCalledTimes(1);
+        expect(connectorSend).toHaveBeenCalledWith("channel-1", {
+            text: null,
+            files: [
+                {
+                    id: "file-1",
+                    name: "report.pdf",
+                    mimeType: "application/pdf",
+                    size: 10,
+                    path: "/tmp/file-1__report.pdf",
+                    sendAs: "auto"
+                }
+            ],
+            replyToMessageId: undefined
+        });
+    });
+});
+function optionsBuild(params) {
+    const logger = {
+        debug: vi.fn(),
+        info: vi.fn(),
+        warn: vi.fn(),
+        error: vi.fn()
+    };
+    const connectorRegistry = connectorRegistryBuild();
+    const skills = params.skills ??
+        {
+            list: vi.fn(async () => [])
+        };
+    return {
+        entry: params.entry,
+        agent: {
+            id: "agent-1",
+            descriptor: {
+                type: params.agentType ?? "user",
+                connector: "telegram",
+                channelId: "channel-1",
+                userId: "user-1"
+            },
+            state: {
+                inferenceSessionId: params.inferenceSessionId ?? "session-agent-1",
+                permissions: {
+                    workingDir: "/workspace",
+                    writeDirs: ["/workspace"],
+                    readDirs: ["/workspace"],
+                    network: false,
+                    events: false
+                }
+            }
+        },
+        source: "telegram",
+        context: params.context,
+        connector: params.connector,
+        connectorRegistry,
+        inferenceRouter: params.inferenceRouter,
+        toolResolver: params.toolResolver,
+        fileStore: params.fileStore ?? {},
+        authStore: {},
+        eventBus: { emit: vi.fn() },
+        assistant: null,
+        agentSystem: {
+            config: {
+                current: {
+                    features: {
+                        rlm: params.rlm ?? false,
+                        say: params.say ?? false,
+                        noTools: params.noTools ?? false
+                    }
+                }
+            },
+            imageRegistry: { list: () => [] }
+        },
+        heartbeats: {},
+        skills,
+        providersForAgent: [],
+        verbose: false,
+        logger: logger,
+        abortSignal: params.abortSignal,
+        appendHistoryRecord: params.appendHistoryRecord,
+        notifySubagentFailure: vi.fn(async () => undefined)
+    };
+}
+function connectorBuild(send) {
+    return {
+        capabilities: {
+            sendText: true,
+            sendFiles: { modes: ["photo"] }
+        },
+        onMessage: () => () => undefined,
+        sendMessage: send,
+        startTyping: () => () => undefined
+    };
+}
+function contextBuild() {
+    return {
+        messages: [],
+        tools: []
+    };
+}
+function entryBuild() {
+    return {
+        id: "message-1",
+        message: { text: "generate", files: [] },
+        context: {},
+        receivedAt: Date.now()
+    };
+}
+function inferenceRouterBuild(messages) {
+    return {
+        complete: vi.fn(async () => {
+            const message = messages.shift();
+            if (!message) {
+                throw new Error("No inference response prepared");
+            }
+            return {
+                message,
+                providerId: "provider-1",
+                modelId: "model-1"
+            };
+        })
+    };
+}
+function toolResolverBuild(execute) {
+    return {
+        listTools: () => [],
+        execute: vi.fn(async (toolCall) => execute(toolCall))
+    };
+}
+function connectorRegistryBuild() {
+    return {
+        get: () => ({ capabilities: { sendFiles: { modes: ["photo"] }, reactions: false } }),
+        list: () => ["telegram"]
+    };
+}
+function assistantMessageBuild(content) {
+    return {
+        role: "assistant",
+        content,
+        api: "openai-responses",
+        provider: "test-provider",
+        model: "test-model",
+        usage: {
+            input: 0,
+            output: 0,
+            cacheRead: 0,
+            cacheWrite: 0,
+            totalTokens: 0,
+            cost: {
+                input: 0,
+                output: 0,
+                cacheRead: 0,
+                cacheWrite: 0,
+                total: 0
+            }
+        },
+        stopReason: "stop",
+        timestamp: Date.now()
+    };
+}
+function toolCallBuild(id, name, argumentsValue) {
+    return {
+        id,
+        name,
+        type: "toolCall",
+        arguments: argumentsValue
+    };
+}
+function toolResultGeneratedBuild(workspacePath, toolCallId, toolName) {
+    return {
+        toolMessage: {
+            role: "toolResult",
+            toolCallId,
+            toolName,
+            content: [{ type: "text", text: "generated" }],
+            details: {
+                workspace: {
+                    files: [{ path: workspacePath }]
+                }
+            },
+            isError: false,
+            timestamp: Date.now()
+        },
+        typedResult: { text: "generated" }
+    };
+}
+function toolResultTextBuild(toolCallId, toolName, text) {
+    return {
+        toolMessage: {
+            role: "toolResult",
+            toolCallId,
+            toolName,
+            content: [{ type: "text", text }],
+            isError: false,
+            timestamp: Date.now()
+        },
+        typedResult: { text }
+    };
+}
+function fileStoreBuild() {
+    return {
+        get: async (id) => {
+            if (id !== "file-1") {
+                return null;
+            }
+            return {
+                id: "file-1",
+                name: "report.pdf",
+                path: "/tmp/file-1__report.pdf",
+                mimeType: "application/pdf",
+                size: 10,
+                source: "test",
+                createdAt: "2026-01-01T00:00:00.000Z"
+            };
+        }
+    };
+}
+//# sourceMappingURL=agentLoopRun.spec.js.map