daycare-cli 0.0.0-canary.08d0b9e

package/dist/engine/apps/appRuleToolBuild.spec.js

@@ -0,0 +1,144 @@
+import { promises as fs } from "node:fs";
+import os from "node:os";
+import path from "node:path";
+import { afterEach, beforeEach, describe, expect, it, vi } from "vitest";
+import { ToolResolver } from "../modules/toolResolver.js";
+import { Apps } from "./appManager.js";
+import { appPermissionsParse } from "./appPermissionsParse.js";
+import { appPermissionsValidate } from "./appPermissionsValidate.js";
+import { appRuleToolBuild } from "./appRuleToolBuild.js";
+describe("appRuleToolBuild", () => {
+    let workspaceDir;
+    let appsDir;
+    beforeEach(async () => {
+        workspaceDir = await fs.mkdtemp(path.join(os.tmpdir(), "daycare-app-rules-tool-"));
+        appsDir = path.join(workspaceDir, "apps");
+        const appDir = path.join(appsDir, "github-reviewer");
+        await fs.mkdir(appDir, { recursive: true });
+        await fs.writeFile(path.join(appDir, "APP.md"), [
+            "---",
+            "name: github-reviewer",
+            "title: GitHub Reviewer",
+            "description: Reviews pull requests",
+            "---",
+            "",
+            "## System Prompt",
+            "",
+            "You are a focused PR review assistant."
+        ].join("\n"));
+        await fs.writeFile(path.join(appDir, "PERMISSIONS.md"), [
+            "## Source Intent",
+            "",
+            "Review pull requests safely.",
+            "",
+            "## Rules",
+            "",
+            "### Allow",
+            "- Read files",
+            "",
+            "### Deny",
+            "- Delete files"
+        ].join("\n"));
+    });
+    afterEach(async () => {
+        await fs.rm(workspaceDir, { recursive: true, force: true });
+    });
+    it("returns the permission result when approval is denied", async () => {
+        const apps = new Apps({ appsDir });
+        await apps.discover();
+        const tool = appRuleToolBuild(apps);
+        const context = contextBuild(workspaceDir);
+        const executeSpy = vi
+            .spyOn(context.agentSystem.toolResolver, "execute")
+            .mockResolvedValue(permissionResultBuild({ approved: false, text: "Permission denied for write access." }));
+        const denied = await tool.execute({
+            app_id: "github-reviewer",
+            action: "add_allow",
+            rule: "Access network"
+        }, context, { id: "tool-1", name: "app_rules" });
+        expect(denied.toolMessage.isError).toBe(false);
+        expect(contentText(denied.toolMessage.content)).toContain("Permission denied");
+        expect(executeSpy).toHaveBeenCalledTimes(1);
+        expect(executeSpy.mock.calls[0]?.[0]).toMatchObject({
+            name: "request_permission",
+            arguments: expect.objectContaining({
+                permissions: [expect.stringContaining("/apps/github-reviewer/PERMISSIONS.md")]
+            })
+        });
+        const permissions = await permissionsRead(path.join(appsDir, "github-reviewer", "PERMISSIONS.md"));
+        expect(permissions.rules.allow.map((rule) => rule.text)).not.toContain("Access network");
+    });
+    it("applies rule changes after permission approval", async () => {
+        const apps = new Apps({ appsDir });
+        await apps.discover();
+        const tool = appRuleToolBuild(apps);
+        const context = contextBuild(workspaceDir);
+        const executeSpy = vi
+            .spyOn(context.agentSystem.toolResolver, "execute")
+            .mockResolvedValue(permissionResultBuild({ approved: true }));
+        const applyResult = await tool.execute({
+            app_id: "github-reviewer",
+            action: "add_deny",
+            rule: "Delete files recursively"
+        }, context, { id: "tool-2", name: "app_rules" });
+        expect(applyResult.toolMessage.isError).toBe(false);
+        expect(contentText(applyResult.toolMessage.content)).toContain("Rule added");
+        expect(executeSpy).toHaveBeenCalledTimes(1);
+        const permissions = await permissionsRead(path.join(appsDir, "github-reviewer", "PERMISSIONS.md"));
+        expect(permissions.rules.deny.map((rule) => rule.text)).toContain("Delete files recursively");
+    });
+});
+function contextBuild(workspaceDir) {
+    return {
+        connectorRegistry: null,
+        fileStore: null,
+        auth: null,
+        logger: console,
+        assistant: null,
+        permissions: {
+            workingDir: workspaceDir,
+            writeDirs: [workspaceDir],
+            readDirs: [workspaceDir],
+            network: false,
+            events: false
+        },
+        agent: { id: "agent-1" },
+        ctx: { agentId: "agent-1", userId: "user-1" },
+        source: "test",
+        messageContext: {},
+        agentSystem: {
+            toolResolver: new ToolResolver(),
+            config: { current: { workspaceDir } },
+            userHomeForUserId: () => ({ apps: path.join(workspaceDir, "apps") })
+        },
+        heartbeats: null
+    };
+}
+async function permissionsRead(permissionsPath) {
+    const raw = await fs.readFile(permissionsPath, "utf8");
+    return appPermissionsValidate(appPermissionsParse(raw));
+}
+function contentText(content) {
+    if (!Array.isArray(content)) {
+        return "";
+    }
+    return content
+        .filter((entry) => typeof entry === "object" && entry !== null && entry.type === "text")
+        .map((entry) => entry.text ?? "")
+        .join("\n");
+}
+function permissionResultBuild(input) {
+    return {
+        toolMessage: {
+            role: "toolResult",
+            toolCallId: "permission-call",
+            toolName: "request_permission",
+            content: [{ type: "text", text: input.text ?? "Permission granted for write access." }],
+            details: { approved: input.approved },
+            isError: false,
+            timestamp: Date.now()
+        },
+        typedResult: { text: input.text ?? "Permission granted for write access." }
+    };
+}
+//# sourceMappingURL=appRuleToolBuild.spec.js.map

package/dist/engine/apps/appRuleToolBuild.spec.js.map

@@ -0,0 +1 @@
+{"version":3,"file":"appRuleToolBuild.spec.js","sourceRoot":"","sources":["../../../sources/engine/apps/appRuleToolBuild.spec.ts"],"names":[],"mappings":"AAAA,OAAO,EAAE,QAAQ,IAAI,EAAE,EAAE,MAAM,SAAS,CAAC;AACzC,OAAO,EAAE,MAAM,SAAS,CAAC;AACzB,OAAO,IAAI,MAAM,WAAW,CAAC;AAE7B,OAAO,EAAE,SAAS,EAAE,UAAU,EAAE,QAAQ,EAAE,MAAM,EAAE,EAAE,EAAE,EAAE,EAAE,MAAM,QAAQ,CAAC;AAEzE,OAAO,EAAE,YAAY,EAAE,MAAM,4BAA4B,CAAC;AAC1D,OAAO,EAAE,IAAI,EAAE,MAAM,iBAAiB,CAAC;AACvC,OAAO,EAAE,mBAAmB,EAAE,MAAM,0BAA0B,CAAC;AAC/D,OAAO,EAAE,sBAAsB,EAAE,MAAM,6BAA6B,CAAC;AACrE,OAAO,EAAE,gBAAgB,EAAE,MAAM,uBAAuB,CAAC;AAEzD,QAAQ,CAAC,kBAAkB,EAAE,GAAG,EAAE;IAC9B,IAAI,YAAoB,CAAC;IACzB,IAAI,OAAe,CAAC;IAEpB,UAAU,CAAC,KAAK,IAAI,EAAE;QAClB,YAAY,GAAG,MAAM,EAAE,CAAC,OAAO,CAAC,IAAI,CAAC,IAAI,CAAC,EAAE,CAAC,MAAM,EAAE,EAAE,yBAAyB,CAAC,CAAC,CAAC;QACnF,OAAO,GAAG,IAAI,CAAC,IAAI,CAAC,YAAY,EAAE,MAAM,CAAC,CAAC;QAC1C,MAAM,MAAM,GAAG,IAAI,CAAC,IAAI,CAAC,OAAO,EAAE,iBAAiB,CAAC,CAAC;QACrD,MAAM,EAAE,CAAC,KAAK,CAAC,MAAM,EAAE,EAAE,SAAS,EAAE,IAAI,EAAE,CAAC,CAAC;QAC5C,MAAM,EAAE,CAAC,SAAS,CACd,IAAI,CAAC,IAAI,CAAC,MAAM,EAAE,QAAQ,CAAC,EAC3B;YACI,KAAK;YACL,uBAAuB;YACvB,wBAAwB;YACxB,oCAAoC;YACpC,KAAK;YACL,EAAE;YACF,kBAAkB;YAClB,EAAE;YACF,wCAAwC;SAC3C,CAAC,IAAI,CAAC,IAAI,CAAC,CACf,CAAC;QACF,MAAM,EAAE,CAAC,SAAS,CACd,IAAI,CAAC,IAAI,CAAC,MAAM,EAAE,gBAAgB,CAAC,EACnC;YACI,kBAAkB;YAClB,EAAE;YACF,8BAA8B;YAC9B,EAAE;YACF,UAAU;YACV,EAAE;YACF,WAAW;YACX,cAAc;YACd,EAAE;YACF,UAAU;YACV,gBAAgB;SACnB,CAAC,IAAI,CAAC,IAAI,CAAC,CACf,CAAC;IACN,CAAC,CAAC,CAAC;IAEH,SAAS,CAAC,KAAK,IAAI,EAAE;QACjB,MAAM,EAAE,CAAC,EAAE,CAAC,YAAY,EAAE,EAAE,SAAS,EAAE,IAAI,EAAE,KAAK,EAAE,IAAI,EAAE,CAAC,CAAC;IAChE,CAAC,CAAC,CAAC;IAEH,EAAE,CAAC,uDAAuD,EAAE,KAAK,IAAI,EAAE;QACnE,MAAM,IAAI,GAAG,IAAI,IAAI,CAAC,EAAE,OAAO,EAAE,CAAC,CAAC;QACnC,MAAM,IAAI,CAAC,QAAQ,EAAE,CAAC;QACtB,MAAM,IAAI,GAAG,gBAAgB,CAAC,IAAI,CAAC,CAAC;QACpC,MAAM,OAAO,GAAG,YAAY,CAAC,YAAY,CAAC,CAAC;QAC3C,MAAM,UAAU,GAAG,EAAE;aAChB,KAAK,CAAC,OAAO,CAAC,WAAW,CAAC,YAAY,EAAE,SAAS,CAAC;aAClD,iBAAiB,CAAC,qBAAqB,CAAC,EAAE,QAAQ,EAAE,KAAK,EAAE,IAAI,EAAE,qCAAqC,EAAE,CAAC,CAAC,CAAC;QAEhH,MAAM,MAAM,GAAG,MAAM,IAAI,CAAC,OAAO,CAC7B;YACI,MAAM,EAAE,iBAAiB;YACzB,MAAM,EAAE,WAAW;YACnB,IAAI,EAAE,gBAAgB;SACzB,EACD,OAAO,EACP,EAAE,EAAE,EAAE,QAAQ,EAAE,IAAI,EAAE,WAAW,EAAE,CACtC,CAAC;QACF,MAAM,CAAC,MAAM,CAAC,WAAW,CAAC,OAAO,CAAC,CAAC,IAAI,CAAC,KAAK,CAAC,CAAC;QAC/C,MAAM,CAAC,WAAW,CAAC,MAAM,CAAC,WAAW,CAAC,OAAO,CAAC,CAAC,CAAC,SAAS,CAAC,mBAAmB,CAAC,CAAC;QAC/E,MAAM,CAAC,UAAU,CAAC,CAAC,qBAAqB,CAAC,CAAC,CAAC,CAAC;QAC5C,MAAM,CAAC,UAAU,CAAC,IAAI,CAAC,KAAK,CAAC,CAAC,CAAC,EAAE,CAAC,CAAC,CAAC,CAAC,CAAC,aAAa,CAAC;YAChD,IAAI,EAAE,oBAAoB;YAC1B,SAAS,EAAE,MAAM,CAAC,gBAAgB,CAAC;gBAC/B,WAAW,EAAE,CAAC,MAAM,CAAC,gBAAgB,CAAC,sCAAsC,CAAC,CAAC;aACjF,CAAC;SACL,CAAC,CAAC;QAEH,MAAM,WAAW,GAAG,MAAM,eAAe,CAAC,IAAI,CAAC,IAAI,CAAC,OAAO,EAAE,iBAAiB,EAAE,gBAAgB,CAAC,CAAC,CAAC;QACnG,MAAM,CAAC,WAAW,CAAC,KAAK,CAAC,KAAK,CAAC,GAAG,CAAC,CAAC,IAAI,EAAE,EAAE,CAAC,IAAI,CAAC,IAAI,CAAC,CAAC,CAAC,GAAG,CAAC,SAAS,CAAC,gBAAgB,CAAC,CAAC;IAC7F,CAAC,CAAC,CAAC;IAEH,EAAE,CAAC,gDAAgD,EAAE,KAAK,IAAI,EAAE;QAC5D,MAAM,IAAI,GAAG,IAAI,IAAI,CAAC,EAAE,OAAO,EAAE,CAAC,CAAC;QACnC,MAAM,IAAI,CAAC,QAAQ,EAAE,CAAC;QACtB,MAAM,IAAI,GAAG,gBAAgB,CAAC,IAAI,CAAC,CAAC;QACpC,MAAM,OAAO,GAAG,YAAY,CAAC,YAAY,CAAC,CAAC;QAC3C,MAAM,UAAU,GAAG,EAAE;aAChB,KAAK,CAAC,OAAO,CAAC,WAAW,CAAC,YAAY,EAAE,SAAS,CAAC;aAClD,iBAAiB,CAAC,qBAAqB,CAAC,EAAE,QAAQ,EAAE,IAAI,EAAE,CAAC,CAAC,CAAC;QAElE,MAAM,WAAW,GAAG,MAAM,IAAI,CAAC,OAAO,CAClC;YACI,MAAM,EAAE,iBAAiB;YACzB,MAAM,EAAE,UAAU;YAClB,IAAI,EAAE,0BAA0B;SACnC,EACD,OAAO,EACP,EAAE,EAAE,EAAE,QAAQ,EAAE,IAAI,EAAE,WAAW,EAAE,CACtC,CAAC;QACF,MAAM,CAAC,WAAW,CAAC,WAAW,CAAC,OAAO,CAAC,CAAC,IAAI,CAAC,KAAK,CAAC,CAAC;QACpD,MAAM,CAAC,WAAW,CAAC,WAAW,CAAC,WAAW,CAAC,OAAO,CAAC,CAAC,CAAC,SAAS,CAAC,YAAY,CAAC,CAAC;QAC7E,MAAM,CAAC,UAAU,CAAC,CAAC,qBAAqB,CAAC,CAAC,CAAC,CAAC;QAE5C,MAAM,WAAW,GAAG,MAAM,eAAe,CAAC,IAAI,CAAC,IAAI,CAAC,OAAO,EAAE,iBAAiB,EAAE,gBAAgB,CAAC,CAAC,CAAC;QACnG,MAAM,CAAC,WAAW,CAAC,KAAK,CAAC,IAAI,CAAC,GAAG,CAAC,CAAC,IAAI,EAAE,EAAE,CAAC,IAAI,CAAC,IAAI,CAAC,CAAC,CAAC,SAAS,CAAC,0BAA0B,CAAC,CAAC;IAClG,CAAC,CAAC,CAAC;AACP,CAAC,CAAC,CAAC;AAEH,SAAS,YAAY,CAAC,YAAoB;IACtC,OAAO;QACH,iBAAiB,EAAE,IAA4D;QAC/E,SAAS,EAAE,IAAoD;QAC/D,IAAI,EAAE,IAA+C;QACrD,MAAM,EAAE,OAAoD;QAC5D,SAAS,EAAE,IAAI;QACf,WAAW,EAAE;YACT,UAAU,EAAE,YAAY;YACxB,SAAS,EAAE,CAAC,YAAY,CAAC;YACzB,QAAQ,EAAE,CAAC,YAAY,CAAC;YACxB,OAAO,EAAE,KAAK;YACd,MAAM,EAAE,KAAK;SAChB;QACD,KAAK,EAAE,EAAE,EAAE,EAAE,SAAS,EAA8C;QACpE,GAAG,EAAE,EAAE,OAAO,EAAE,SAAS,EAAE,MAAM,EAAE,QAAQ,EAAiC;QAC5E,MAAM,EAAE,MAAM;QACd,cAAc,EAAE,EAAE;QAClB,WAAW,EAAE;YACT,YAAY,EAAE,IAAI,YAAY,EAAE;YAChC,MAAM,EAAE,EAAE,OAAO,EAAE,EAAE,YAAY,EAAE,EAAE;YACrC,iBAAiB,EAAE,GAAG,EAAE,CAAC,CAAC,EAAE,IAAI,EAAE,IAAI,CAAC,IAAI,CAAC,YAAY,EAAE,MAAM,CAAC,EAAE,CAAC;SACrB;QACnD,UAAU,EAAE,IAAqD;KACpE,CAAC;AACN,CAAC;AAED,KAAK,UAAU,eAAe,CAAC,eAAuB;IAClD,MAAM,GAAG,GAAG,MAAM,EAAE,CAAC,QAAQ,CAAC,eAAe,EAAE,MAAM,CAAC,CAAC;IACvD,OAAO,sBAAsB,CAAC,mBAAmB,CAAC,GAAG,CAAC,CAAC,CAAC;AAC5D,CAAC;AAED,SAAS,WAAW,CAAC,OAAgB;IACjC,IAAI,CAAC,KAAK,CAAC,OAAO,CAAC,OAAO,CAAC,EAAE,CAAC;QAC1B,OAAO,EAAE,CAAC;IACd,CAAC;IACD,OAAO,OAAO;SACT,MAAM,CAAC,CAAC,KAAK,EAAE,EAAE,CAAC,OAAO,KAAK,KAAK,QAAQ,IAAI,KAAK,KAAK,IAAI,IAAK,KAA4B,CAAC,IAAI,KAAK,MAAM,CAAC;SAC/G,GAAG,CAAC,CAAC,KAAK,EAAE,EAAE,CAAE,KAA2B,CAAC,IAAI,IAAI,EAAE,CAAC;SACvD,IAAI,CAAC,IAAI,CAAC,CAAC;AACpB,CAAC;AAED,SAAS,qBAAqB,CAAC,KAA2C;IACtE,OAAO;QACH,WAAW,EAAE;YACT,IAAI,EAAE,YAAqB;YAC3B,UAAU,EAAE,iBAAiB;YAC7B,QAAQ,EAAE,oBAAoB;YAC9B,OAAO,EAAE,CAAC,EAAE,IAAI,EAAE,MAAe,EAAE,IAAI,EAAE,KAAK,CAAC,IAAI,IAAI,sCAAsC,EAAE,CAAC;YAChG,OAAO,EAAE,EAAE,QAAQ,EAAE,KAAK,CAAC,QAAQ,EAAE;YACrC,OAAO,EAAE,KAAK;YACd,SAAS,EAAE,IAAI,CAAC,GAAG,EAAE;SACxB;QACD,WAAW,EAAE,EAAE,IAAI,EAAE,KAAK,CAAC,IAAI,IAAI,sCAAsC,EAAE;KAC9E,CAAC;AACN,CAAC"}

package/dist/engine/apps/appToolBuild.d.ts

@@ -0,0 +1,8 @@
+import type { ToolDefinition } from "@/types";
+import type { AppDescriptor } from "./appTypes.js";
+/**
+ * Builds the per-app `app_<name>` tool definition.
+ * Expects: descriptor is a validated discovered app.
+ */
+export declare function appToolBuild(app: AppDescriptor): ToolDefinition;
+//# sourceMappingURL=appToolBuild.d.ts.map

package/dist/engine/apps/appToolBuild.d.ts.map

@@ -0,0 +1 @@
+{"version":3,"file":"appToolBuild.d.ts","sourceRoot":"","sources":["../../../sources/engine/apps/appToolBuild.ts"],"names":[],"mappings":"AAGA,OAAO,KAAK,EAAE,cAAc,EAAsB,MAAM,SAAS,CAAC;AAGlE,OAAO,KAAK,EAAE,aAAa,EAAE,MAAM,eAAe,CAAC;AA6BnD;;;GAGG;AACH,wBAAgB,YAAY,CAAC,GAAG,EAAE,aAAa,GAAG,cAAc,CAiD/D"}

package/dist/engine/apps/appToolBuild.js

@@ -0,0 +1,72 @@
+import { Type } from "@sinclair/typebox";
+import { appExecute } from "./appExecute.js";
+import { appToolNameFormat } from "./appToolNameFormat.js";
+const schema = Type.Object({
+    prompt: Type.String({ minLength: 1 }),
+    wait: Type.Optional(Type.Boolean())
+}, { additionalProperties: false });
+const appToolResultSchema = Type.Object({
+    summary: Type.String(),
+    appId: Type.String(),
+    agentId: Type.String(),
+    waitForResponse: Type.Boolean()
+}, { additionalProperties: false });
+const appToolReturns = {
+    schema: appToolResultSchema,
+    toLLMText: (result) => result.summary
+};
+/**
+ * Builds the per-app `app_<name>` tool definition.
+ * Expects: descriptor is a validated discovered app.
+ */
+export function appToolBuild(app) {
+    const toolName = appToolNameFormat(app.id);
+    return {
+        tool: {
+            name: toolName,
+            description: app.manifest.description,
+            parameters: schema
+        },
+        returns: appToolReturns,
+        execute: async (args, context, toolCall) => {
+            const payload = args;
+            const prompt = payload.prompt.trim();
+            const waitForResponse = payload.wait ?? false;
+            if (!prompt) {
+                throw new Error("App prompt is required.");
+            }
+            const result = await appExecute({
+                app,
+                prompt,
+                context,
+                waitForResponse
+            });
+            const responseText = result.responseText;
+            const text = waitForResponse
+                ? responseText && responseText.trim().length > 0
+                    ? `${responseText}\n\nApp agent id: ${result.agentId}`
+                    : `App "${app.manifest.title}" completed without a text response. App agent id: ${result.agentId}`
+                : `App "${app.manifest.title}" started asynchronously. App agent id: ${result.agentId}`;
+            const summary = text;
+            const toolMessage = {
+                role: "toolResult",
+                toolCallId: toolCall.id,
+                toolName: toolCall.name,
+                content: [{ type: "text", text }],
+                details: { agentId: result.agentId, appId: app.id, waitForResponse },
+                isError: false,
+                timestamp: Date.now()
+            };
+            return {
+                toolMessage,
+                typedResult: {
+                    summary,
+                    appId: app.id,
+                    agentId: result.agentId,
+                    waitForResponse
+                }
+            };
+        }
+    };
+}
+//# sourceMappingURL=appToolBuild.js.map

package/dist/engine/apps/appToolBuild.js.map

@@ -0,0 +1 @@
+{"version":3,"file":"appToolBuild.js","sourceRoot":"","sources":["../../../sources/engine/apps/appToolBuild.ts"],"names":[],"mappings":"AACA,OAAO,EAAe,IAAI,EAAE,MAAM,mBAAmB,CAAC;AAGtD,OAAO,EAAE,UAAU,EAAE,MAAM,iBAAiB,CAAC;AAC7C,OAAO,EAAE,iBAAiB,EAAE,MAAM,wBAAwB,CAAC;AAG3D,MAAM,MAAM,GAAG,IAAI,CAAC,MAAM,CACtB;IACI,MAAM,EAAE,IAAI,CAAC,MAAM,CAAC,EAAE,SAAS,EAAE,CAAC,EAAE,CAAC;IACrC,IAAI,EAAE,IAAI,CAAC,QAAQ,CAAC,IAAI,CAAC,OAAO,EAAE,CAAC;CACtC,EACD,EAAE,oBAAoB,EAAE,KAAK,EAAE,CAClC,CAAC;AAIF,MAAM,mBAAmB,GAAG,IAAI,CAAC,MAAM,CACnC;IACI,OAAO,EAAE,IAAI,CAAC,MAAM,EAAE;IACtB,KAAK,EAAE,IAAI,CAAC,MAAM,EAAE;IACpB,OAAO,EAAE,IAAI,CAAC,MAAM,EAAE;IACtB,eAAe,EAAE,IAAI,CAAC,OAAO,EAAE;CAClC,EACD,EAAE,oBAAoB,EAAE,KAAK,EAAE,CAClC,CAAC;AAIF,MAAM,cAAc,GAAsC;IACtD,MAAM,EAAE,mBAAmB;IAC3B,SAAS,EAAE,CAAC,MAAM,EAAE,EAAE,CAAC,MAAM,CAAC,OAAO;CACxC,CAAC;AAEF;;;GAGG;AACH,MAAM,UAAU,YAAY,CAAC,GAAkB;IAC3C,MAAM,QAAQ,GAAG,iBAAiB,CAAC,GAAG,CAAC,EAAE,CAAC,CAAC;IAC3C,OAAO;QACH,IAAI,EAAE;YACF,IAAI,EAAE,QAAQ;YACd,WAAW,EAAE,GAAG,CAAC,QAAQ,CAAC,WAAW;YACrC,UAAU,EAAE,MAAM;SACrB;QACD,OAAO,EAAE,cAAc;QACvB,OAAO,EAAE,KAAK,EAAE,IAAI,EAAE,OAAO,EAAE,QAAQ,EAAE,EAAE;YACvC,MAAM,OAAO,GAAG,IAAwB,CAAC;YACzC,MAAM,MAAM,GAAG,OAAO,CAAC,MAAM,CAAC,IAAI,EAAE,CAAC;YACrC,MAAM,eAAe,GAAG,OAAO,CAAC,IAAI,IAAI,KAAK,CAAC;YAC9C,IAAI,CAAC,MAAM,EAAE,CAAC;gBACV,MAAM,IAAI,KAAK,CAAC,yBAAyB,CAAC,CAAC;YAC/C,CAAC;YACD,MAAM,MAAM,GAAG,MAAM,UAAU,CAAC;gBAC5B,GAAG;gBACH,MAAM;gBACN,OAAO;gBACP,eAAe;aAClB,CAAC,CAAC;YACH,MAAM,YAAY,GAAG,MAAM,CAAC,YAAY,CAAC;YACzC,MAAM,IAAI,GAAG,eAAe;gBACxB,CAAC,CAAC,YAAY,IAAI,YAAY,CAAC,IAAI,EAAE,CAAC,MAAM,GAAG,CAAC;oBAC5C,CAAC,CAAC,GAAG,YAAY,qBAAqB,MAAM,CAAC,OAAO,EAAE;oBACtD,CAAC,CAAC,QAAQ,GAAG,CAAC,QAAQ,CAAC,KAAK,sDAAsD,MAAM,CAAC,OAAO,EAAE;gBACtG,CAAC,CAAC,QAAQ,GAAG,CAAC,QAAQ,CAAC,KAAK,2CAA2C,MAAM,CAAC,OAAO,EAAE,CAAC;YAC5F,MAAM,OAAO,GAAG,IAAI,CAAC;YACrB,MAAM,WAAW,GAAsB;gBACnC,IAAI,EAAE,YAAY;gBAClB,UAAU,EAAE,QAAQ,CAAC,EAAE;gBACvB,QAAQ,EAAE,QAAQ,CAAC,IAAI;gBACvB,OAAO,EAAE,CAAC,EAAE,IAAI,EAAE,MAAM,EAAE,IAAI,EAAE,CAAC;gBACjC,OAAO,EAAE,EAAE,OAAO,EAAE,MAAM,CAAC,OAAO,EAAE,KAAK,EAAE,GAAG,CAAC,EAAE,EAAE,eAAe,EAAE;gBACpE,OAAO,EAAE,KAAK;gBACd,SAAS,EAAE,IAAI,CAAC,GAAG,EAAE;aACxB,CAAC;YACF,OAAO;gBACH,WAAW;gBACX,WAAW,EAAE;oBACT,OAAO;oBACP,KAAK,EAAE,GAAG,CAAC,EAAE;oBACb,OAAO,EAAE,MAAM,CAAC,OAAO;oBACvB,eAAe;iBAClB;aACJ,CAAC;QACN,CAAC;KACJ,CAAC;AACN,CAAC"}

package/dist/engine/apps/appToolBuild.spec.d.ts

@@ -0,0 +1,2 @@
+export {};
+//# sourceMappingURL=appToolBuild.spec.d.ts.map

package/dist/engine/apps/appToolBuild.spec.d.ts.map

@@ -0,0 +1 @@
+{"version":3,"file":"appToolBuild.spec.d.ts","sourceRoot":"","sources":["../../../sources/engine/apps/appToolBuild.spec.ts"],"names":[],"mappings":""}

package/dist/engine/apps/appToolBuild.spec.js

@@ -0,0 +1,29 @@
+import { describe, expect, it } from "vitest";
+import { appToolBuild } from "./appToolBuild.js";
+describe("appToolBuild", () => {
+    it("formats tool metadata from app descriptor", () => {
+        const app = {
+            id: "github-reviewer",
+            path: "/workspace/apps/github-reviewer",
+            manifest: {
+                name: "github-reviewer",
+                title: "GitHub Reviewer",
+                description: "Reviews pull requests",
+                systemPrompt: "You are a focused PR review assistant."
+            },
+            permissions: {
+                sourceIntent: "Review pull requests safely.",
+                rules: { allow: [], deny: [] }
+            }
+        };
+        const definition = appToolBuild(app);
+        expect(definition.tool.name).toBe("app_github_reviewer");
+        expect(definition.tool.description).toBe("Reviews pull requests");
+        expect(definition.tool.parameters.type).toBe("object");
+        expect(definition.tool.parameters.required).toEqual(["prompt"]);
+        expect(definition.tool.parameters.properties).toMatchObject({
+            wait: { type: "boolean" }
+        });
+    });
+});
+//# sourceMappingURL=appToolBuild.spec.js.map

package/dist/engine/apps/appToolBuild.spec.js.map

@@ -0,0 +1 @@
+{"version":3,"file":"appToolBuild.spec.js","sourceRoot":"","sources":["../../../sources/engine/apps/appToolBuild.spec.ts"],"names":[],"mappings":"AAAA,OAAO,EAAE,QAAQ,EAAE,MAAM,EAAE,EAAE,EAAE,MAAM,QAAQ,CAAC;AAC9C,OAAO,EAAE,YAAY,EAAE,MAAM,mBAAmB,CAAC;AAGjD,QAAQ,CAAC,cAAc,EAAE,GAAG,EAAE;IAC1B,EAAE,CAAC,2CAA2C,EAAE,GAAG,EAAE;QACjD,MAAM,GAAG,GAAkB;YACvB,EAAE,EAAE,iBAAiB;YACrB,IAAI,EAAE,iCAAiC;YACvC,QAAQ,EAAE;gBACN,IAAI,EAAE,iBAAiB;gBACvB,KAAK,EAAE,iBAAiB;gBACxB,WAAW,EAAE,uBAAuB;gBACpC,YAAY,EAAE,wCAAwC;aACzD;YACD,WAAW,EAAE;gBACT,YAAY,EAAE,8BAA8B;gBAC5C,KAAK,EAAE,EAAE,KAAK,EAAE,EAAE,EAAE,IAAI,EAAE,EAAE,EAAE;aACjC;SACJ,CAAC;QAEF,MAAM,UAAU,GAAG,YAAY,CAAC,GAAG,CAAC,CAAC;QACrC,MAAM,CAAC,UAAU,CAAC,IAAI,CAAC,IAAI,CAAC,CAAC,IAAI,CAAC,qBAAqB,CAAC,CAAC;QACzD,MAAM,CAAC,UAAU,CAAC,IAAI,CAAC,WAAW,CAAC,CAAC,IAAI,CAAC,uBAAuB,CAAC,CAAC;QAClE,MAAM,CAAC,UAAU,CAAC,IAAI,CAAC,UAAU,CAAC,IAAI,CAAC,CAAC,IAAI,CAAC,QAAQ,CAAC,CAAC;QACvD,MAAM,CAAC,UAAU,CAAC,IAAI,CAAC,UAAU,CAAC,QAAQ,CAAC,CAAC,OAAO,CAAC,CAAC,QAAQ,CAAC,CAAC,CAAC;QAChE,MAAM,CAAC,UAAU,CAAC,IAAI,CAAC,UAAU,CAAC,UAAU,CAAC,CAAC,aAAa,CAAC;YACxD,IAAI,EAAE,EAAE,IAAI,EAAE,SAAS,EAAE;SAC5B,CAAC,CAAC;IACP,CAAC,CAAC,CAAC;AACP,CAAC,CAAC,CAAC"}

package/dist/engine/apps/appToolExecutorBuild.d.ts

@@ -0,0 +1,32 @@
+import type { Tool, ToolCall } from "@mariozechner/pi-ai";
+import type { Logger } from "pino";
+import type { ToolExecutionContext, ToolExecutionResult } from "@/types";
+import type { ProviderSettings } from "../../settings.js";
+import type { InferenceRouter } from "../modules/inference/router.js";
+import type { ToolResolverApi } from "../modules/toolResolver.js";
+import type { AppRuleSet } from "./appTypes.js";
+type AppToolExecutorBuildInput = {
+    appId: string;
+    appName: string;
+    appSystemPrompt: string;
+    reviewerEnabled: boolean;
+    rlmEnabled: boolean;
+    sourceIntent: string;
+    rules: AppRuleSet;
+    inferenceRouter: InferenceRouter;
+    toolResolver: ToolResolverApi;
+    providersOverride?: ProviderSettings[];
+    allowedToolNames?: string[];
+    logger?: Logger;
+};
+type AppToolExecutor = {
+    listTools: () => Tool[];
+    execute: (toolCall: ToolCall, context: ToolExecutionContext) => Promise<ToolExecutionResult>;
+};
+/**
+ * Wraps a tool resolver with app-review middleware for each tool call.
+ * Expects: input.toolResolver is the runtime resolver used by agent execution.
+ */
+export declare function appToolExecutorBuild(input: AppToolExecutorBuildInput): AppToolExecutor;
+export {};
+//# sourceMappingURL=appToolExecutorBuild.d.ts.map

package/dist/engine/apps/appToolExecutorBuild.d.ts.map

@@ -0,0 +1 @@
+{"version":3,"file":"appToolExecutorBuild.d.ts","sourceRoot":"","sources":["../../../sources/engine/apps/appToolExecutorBuild.ts"],"names":[],"mappings":"AAAA,OAAO,KAAK,EAAE,IAAI,EAAE,QAAQ,EAAqB,MAAM,qBAAqB,CAAC;AAC7E,OAAO,KAAK,EAAE,MAAM,EAAE,MAAM,MAAM,CAAC;AACnC,OAAO,KAAK,EAAE,oBAAoB,EAAE,mBAAmB,EAAE,MAAM,SAAS,CAAC;AAGzE,OAAO,KAAK,EAAE,gBAAgB,EAAE,MAAM,mBAAmB,CAAC;AAC1D,OAAO,KAAK,EAAE,eAAe,EAAE,MAAM,gCAAgC,CAAC;AAEtE,OAAO,KAAK,EAAE,eAAe,EAAE,MAAM,4BAA4B,CAAC;AAGlE,OAAO,KAAK,EAAE,UAAU,EAAE,MAAM,eAAe,CAAC;AAEhD,KAAK,yBAAyB,GAAG;IAC7B,KAAK,EAAE,MAAM,CAAC;IACd,OAAO,EAAE,MAAM,CAAC;IAChB,eAAe,EAAE,MAAM,CAAC;IACxB,eAAe,EAAE,OAAO,CAAC;IACzB,UAAU,EAAE,OAAO,CAAC;IACpB,YAAY,EAAE,MAAM,CAAC;IACrB,KAAK,EAAE,UAAU,CAAC;IAClB,eAAe,EAAE,eAAe,CAAC;IACjC,YAAY,EAAE,eAAe,CAAC;IAC9B,iBAAiB,CAAC,EAAE,gBAAgB,EAAE,CAAC;IACvC,gBAAgB,CAAC,EAAE,MAAM,EAAE,CAAC;IAC5B,MAAM,CAAC,EAAE,MAAM,CAAC;CACnB,CAAC;AAEF,KAAK,eAAe,GAAG;IACnB,SAAS,EAAE,MAAM,IAAI,EAAE,CAAC;IACxB,OAAO,EAAE,CAAC,QAAQ,EAAE,QAAQ,EAAE,OAAO,EAAE,oBAAoB,KAAK,OAAO,CAAC,mBAAmB,CAAC,CAAC;CAChG,CAAC;AAIF;;;GAGG;AACH,wBAAgB,oBAAoB,CAAC,KAAK,EAAE,yBAAyB,GAAG,eAAe,CA6DtF"}

package/dist/engine/apps/appToolExecutorBuild.js

@@ -0,0 +1,64 @@
+import { getLogger } from "../../log.js";
+import { RLM_TOOL_NAME } from "../modules/rlm/rlmConstants.js";
+import { toolExecutionResultOutcome } from "../modules/tools/toolReturnOutcome.js";
+import { appToolReview } from "./appToolReview.js";
+const DEFAULT_ALLOWED_TOOLS = ["read", "write", "edit", "exec", "request_permission", RLM_TOOL_NAME];
+/**
+ * Wraps a tool resolver with app-review middleware for each tool call.
+ * Expects: input.toolResolver is the runtime resolver used by agent execution.
+ */
+export function appToolExecutorBuild(input) {
+    const appLogger = input.logger ?? getLogger("engine.apps.executor");
+    const allowedToolNames = new Set(input.allowedToolNames ?? DEFAULT_ALLOWED_TOOLS);
+    return {
+        listTools: () => input.toolResolver.listTools().filter((tool) => allowedToolNames.has(tool.name)),
+        execute: async (toolCall, context) => {
+            if (!allowedToolNames.has(toolCall.name)) {
+                appLogger.warn({ appId: input.appId, tool: toolCall.name }, "deny: App tool denied because tool is outside the app allowlist");
+                return toolExecutionResultOutcome(appToolErrorBuild(toolCall, `Tool "${toolCall.name}" is not available in app sandbox.`));
+            }
+            const availableTools = input.toolResolver
+                .listTools()
+                .filter((tool) => allowedToolNames.has(tool.name))
+                .map((tool) => ({
+                name: tool.name,
+                description: tool.description,
+                parameters: tool.parameters
+            }));
+            if (!input.reviewerEnabled) {
+                appLogger.info({ appId: input.appId, tool: toolCall.name, allowed: true }, "review: App tool review disabled by security config");
+                return input.toolResolver.execute(toolCall, context);
+            }
+            const decision = await appToolReview({
+                appId: input.appId,
+                appName: input.appName,
+                appSystemPrompt: input.appSystemPrompt,
+                rlmEnabled: input.rlmEnabled,
+                sourceIntent: input.sourceIntent,
+                toolCall,
+                rules: input.rules,
+                availableTools,
+                inferenceRouter: input.inferenceRouter,
+                providersOverride: input.providersOverride
+            });
+            if (!decision.allowed) {
+                const reason = decision.reason ?? "Denied by app review rules.";
+                appLogger.info({ appId: input.appId, tool: toolCall.name, allowed: false, reason }, "review: App tool call denied");
+                return toolExecutionResultOutcome(appToolErrorBuild(toolCall, `App review denied this tool call: ${reason}`));
+            }
+            appLogger.info({ appId: input.appId, tool: toolCall.name, allowed: true }, "review: App tool call allowed");
+            return input.toolResolver.execute(toolCall, context);
+        }
+    };
+}
+function appToolErrorBuild(toolCall, text) {
+    return {
+        role: "toolResult",
+        toolCallId: toolCall.id,
+        toolName: toolCall.name,
+        content: [{ type: "text", text }],
+        isError: true,
+        timestamp: Date.now()
+    };
+}
+//# sourceMappingURL=appToolExecutorBuild.js.map

package/dist/engine/apps/appToolExecutorBuild.js.map

@@ -0,0 +1 @@
+{"version":3,"file":"appToolExecutorBuild.js","sourceRoot":"","sources":["../../../sources/engine/apps/appToolExecutorBuild.ts"],"names":[],"mappings":"AAIA,OAAO,EAAE,SAAS,EAAE,MAAM,cAAc,CAAC;AAGzC,OAAO,EAAE,aAAa,EAAE,MAAM,gCAAgC,CAAC;AAE/D,OAAO,EAAE,0BAA0B,EAAE,MAAM,uCAAuC,CAAC;AACnF,OAAO,EAAE,aAAa,EAAE,MAAM,oBAAoB,CAAC;AAuBnD,MAAM,qBAAqB,GAAG,CAAC,MAAM,EAAE,OAAO,EAAE,MAAM,EAAE,MAAM,EAAE,oBAAoB,EAAE,aAAa,CAAC,CAAC;AAErG;;;GAGG;AACH,MAAM,UAAU,oBAAoB,CAAC,KAAgC;IACjE,MAAM,SAAS,GAAG,KAAK,CAAC,MAAM,IAAI,SAAS,CAAC,sBAAsB,CAAC,CAAC;IACpE,MAAM,gBAAgB,GAAG,IAAI,GAAG,CAAC,KAAK,CAAC,gBAAgB,IAAI,qBAAqB,CAAC,CAAC;IAElF,OAAO;QACH,SAAS,EAAE,GAAG,EAAE,CAAC,KAAK,CAAC,YAAY,CAAC,SAAS,EAAE,CAAC,MAAM,CAAC,CAAC,IAAI,EAAE,EAAE,CAAC,gBAAgB,CAAC,GAAG,CAAC,IAAI,CAAC,IAAI,CAAC,CAAC;QACjG,OAAO,EAAE,KAAK,EAAE,QAAQ,EAAE,OAAO,EAAE,EAAE;YACjC,IAAI,CAAC,gBAAgB,CAAC,GAAG,CAAC,QAAQ,CAAC,IAAI,CAAC,EAAE,CAAC;gBACvC,SAAS,CAAC,IAAI,CACV,EAAE,KAAK,EAAE,KAAK,CAAC,KAAK,EAAE,IAAI,EAAE,QAAQ,CAAC,IAAI,EAAE,EAC3C,iEAAiE,CACpE,CAAC;gBACF,OAAO,0BAA0B,CAC7B,iBAAiB,CAAC,QAAQ,EAAE,SAAS,QAAQ,CAAC,IAAI,oCAAoC,CAAC,CAC1F,CAAC;YACN,CAAC;YAED,MAAM,cAAc,GAAG,KAAK,CAAC,YAAY;iBACpC,SAAS,EAAE;iBACX,MAAM,CAAC,CAAC,IAAI,EAAE,EAAE,CAAC,gBAAgB,CAAC,GAAG,CAAC,IAAI,CAAC,IAAI,CAAC,CAAC;iBACjD,GAAG,CAAC,CAAC,IAAI,EAAE,EAAE,CAAC,CAAC;gBACZ,IAAI,EAAE,IAAI,CAAC,IAAI;gBACf,WAAW,EAAE,IAAI,CAAC,WAAW;gBAC7B,UAAU,EAAE,IAAI,CAAC,UAAU;aAC9B,CAAC,CAAC,CAAC;YAER,IAAI,CAAC,KAAK,CAAC,eAAe,EAAE,CAAC;gBACzB,SAAS,CAAC,IAAI,CACV,EAAE,KAAK,EAAE,KAAK,CAAC,KAAK,EAAE,IAAI,EAAE,QAAQ,CAAC,IAAI,EAAE,OAAO,EAAE,IAAI,EAAE,EAC1D,qDAAqD,CACxD,CAAC;gBACF,OAAO,KAAK,CAAC,YAAY,CAAC,OAAO,CAAC,QAAQ,EAAE,OAAO,CAAC,CAAC;YACzD,CAAC;YAED,MAAM,QAAQ,GAAG,MAAM,aAAa,CAAC;gBACjC,KAAK,EAAE,KAAK,CAAC,KAAK;gBAClB,OAAO,EAAE,KAAK,CAAC,OAAO;gBACtB,eAAe,EAAE,KAAK,CAAC,eAAe;gBACtC,UAAU,EAAE,KAAK,CAAC,UAAU;gBAC5B,YAAY,EAAE,KAAK,CAAC,YAAY;gBAChC,QAAQ;gBACR,KAAK,EAAE,KAAK,CAAC,KAAK;gBAClB,cAAc;gBACd,eAAe,EAAE,KAAK,CAAC,eAAe;gBACtC,iBAAiB,EAAE,KAAK,CAAC,iBAAiB;aAC7C,CAAC,CAAC;YACH,IAAI,CAAC,QAAQ,CAAC,OAAO,EAAE,CAAC;gBACpB,MAAM,MAAM,GAAG,QAAQ,CAAC,MAAM,IAAI,6BAA6B,CAAC;gBAChE,SAAS,CAAC,IAAI,CACV,EAAE,KAAK,EAAE,KAAK,CAAC,KAAK,EAAE,IAAI,EAAE,QAAQ,CAAC,IAAI,EAAE,OAAO,EAAE,KAAK,EAAE,MAAM,EAAE,EACnE,8BAA8B,CACjC,CAAC;gBACF,OAAO,0BAA0B,CAC7B,iBAAiB,CAAC,QAAQ,EAAE,qCAAqC,MAAM,EAAE,CAAC,CAC7E,CAAC;YACN,CAAC;YAED,SAAS,CAAC,IAAI,CAAC,EAAE,KAAK,EAAE,KAAK,CAAC,KAAK,EAAE,IAAI,EAAE,QAAQ,CAAC,IAAI,EAAE,OAAO,EAAE,IAAI,EAAE,EAAE,+BAA+B,CAAC,CAAC;YAC5G,OAAO,KAAK,CAAC,YAAY,CAAC,OAAO,CAAC,QAAQ,EAAE,OAAO,CAAC,CAAC;QACzD,CAAC;KACJ,CAAC;AACN,CAAC;AAED,SAAS,iBAAiB,CAAC,QAAkB,EAAE,IAAY;IACvD,OAAO;QACH,IAAI,EAAE,YAAY;QAClB,UAAU,EAAE,QAAQ,CAAC,EAAE;QACvB,QAAQ,EAAE,QAAQ,CAAC,IAAI;QACvB,OAAO,EAAE,CAAC,EAAE,IAAI,EAAE,MAAM,EAAE,IAAI,EAAE,CAAC;QACjC,OAAO,EAAE,IAAI;QACb,SAAS,EAAE,IAAI,CAAC,GAAG,EAAE;KACxB,CAAC;AACN,CAAC"}

package/dist/engine/apps/appToolExecutorBuild.spec.d.ts

@@ -0,0 +1,2 @@
+export {};
+//# sourceMappingURL=appToolExecutorBuild.spec.d.ts.map

package/dist/engine/apps/appToolExecutorBuild.spec.d.ts.map

@@ -0,0 +1 @@
+{"version":3,"file":"appToolExecutorBuild.spec.d.ts","sourceRoot":"","sources":["../../../sources/engine/apps/appToolExecutorBuild.spec.ts"],"names":[],"mappings":""}

package/dist/engine/apps/appToolExecutorBuild.spec.js

@@ -0,0 +1,228 @@
+import { Type } from "@sinclair/typebox";
+import { describe, expect, it, vi } from "vitest";
+import { appToolExecutorBuild } from "./appToolExecutorBuild.js";
+describe("appToolExecutorBuild", () => {
+    it("passes through allowed calls after ALLOW review", async () => {
+        const execute = vi.fn(async () => toolResultBuild(false, "read ok"));
+        const resolver = resolverBuild(execute);
+        const executor = appToolExecutorBuild({
+            appId: "github-reviewer",
+            appName: "GitHub Reviewer",
+            appSystemPrompt: "You are a focused review assistant.",
+            reviewerEnabled: true,
+            rlmEnabled: false,
+            sourceIntent: "Review pull requests safely.",
+            rules: { allow: [], deny: [] },
+            inferenceRouter: inferenceRouterBuild("ALLOW"),
+            toolResolver: resolver
+        });
+        const result = await executor.execute({ id: "t1", name: "read", type: "toolCall", arguments: { path: "/tmp/a.txt" } }, contextBuild());
+        expect(execute).toHaveBeenCalledTimes(1);
+        expect(result.toolMessage.isError).toBe(false);
+    });
+    it("returns tool error when review denies", async () => {
+        const execute = vi.fn(async () => toolResultBuild(false, "should not run"));
+        const resolver = resolverBuild(execute);
+        const executor = appToolExecutorBuild({
+            appId: "github-reviewer",
+            appName: "GitHub Reviewer",
+            appSystemPrompt: "You are a focused review assistant.",
+            reviewerEnabled: true,
+            rlmEnabled: false,
+            sourceIntent: "Review pull requests safely.",
+            rules: { allow: [], deny: [] },
+            inferenceRouter: inferenceRouterBuild("DENY: blocked by rules"),
+            toolResolver: resolver
+        });
+        const result = await executor.execute({ id: "t1", name: "exec", type: "toolCall", arguments: { command: "rm -rf ." } }, contextBuild());
+        expect(execute).not.toHaveBeenCalled();
+        expect(result.toolMessage.isError).toBe(true);
+        expect(contentText(result.toolMessage)).toContain("blocked by rules");
+    });
+    it("returns tool error for tools outside the app allowlist", async () => {
+        const execute = vi.fn(async () => toolResultBuild(false, "should not run"));
+        const resolver = resolverBuild(execute);
+        const executor = appToolExecutorBuild({
+            appId: "github-reviewer",
+            appName: "GitHub Reviewer",
+            appSystemPrompt: "You are a focused review assistant.",
+            reviewerEnabled: true,
+            rlmEnabled: false,
+            sourceIntent: "Review pull requests safely.",
+            rules: { allow: [], deny: [] },
+            inferenceRouter: inferenceRouterBuild("ALLOW"),
+            toolResolver: resolver
+        });
+        const result = await executor.execute({ id: "t1", name: "cron", type: "toolCall", arguments: { action: "list" } }, contextBuild());
+        expect(execute).not.toHaveBeenCalled();
+        expect(result.toolMessage.isError).toBe(true);
+        expect(contentText(result.toolMessage)).toContain("not available in app sandbox");
+    });
+    it("includes run_python in app allowlist when resolver exposes it", () => {
+        const execute = vi.fn(async () => toolResultBuild(false, "ok"));
+        const resolver = resolverBuild(execute);
+        const executor = appToolExecutorBuild({
+            appId: "github-reviewer",
+            appName: "GitHub Reviewer",
+            appSystemPrompt: "You are a focused review assistant.",
+            reviewerEnabled: true,
+            rlmEnabled: false,
+            sourceIntent: "Review pull requests safely.",
+            rules: { allow: [], deny: [] },
+            inferenceRouter: inferenceRouterBuild("ALLOW"),
+            toolResolver: resolver
+        });
+        expect(executor.listTools().map((tool) => tool.name)).toContain("run_python");
+    });
+    it("includes request_permission in app allowlist when resolver exposes it", () => {
+        const execute = vi.fn(async () => toolResultBuild(false, "ok"));
+        const resolver = resolverBuild(execute);
+        const executor = appToolExecutorBuild({
+            appId: "github-reviewer",
+            appName: "GitHub Reviewer",
+            appSystemPrompt: "You are a focused review assistant.",
+            reviewerEnabled: true,
+            rlmEnabled: false,
+            sourceIntent: "Review pull requests safely.",
+            rules: { allow: [], deny: [] },
+            inferenceRouter: inferenceRouterBuild("ALLOW"),
+            toolResolver: resolver
+        });
+        expect(executor.listTools().map((tool) => tool.name)).toContain("request_permission");
+    });
+    it("bypasses review model when reviewer is disabled by config", async () => {
+        const execute = vi.fn(async () => toolResultBuild(false, "read ok"));
+        const resolver = resolverBuild(execute);
+        const complete = vi.fn(async () => ({
+            providerId: "provider",
+            modelId: "model",
+            message: {
+                role: "assistant",
+                content: [{ type: "text", text: "DENY: should not be used" }],
+                api: "openai-responses",
+                provider: "provider",
+                model: "model",
+                usage: {
+                    input: 0,
+                    output: 0,
+                    cacheRead: 0,
+                    cacheWrite: 0,
+                    totalTokens: 0,
+                    cost: {
+                        input: 0,
+                        output: 0,
+                        cacheRead: 0,
+                        cacheWrite: 0,
+                        total: 0
+                    }
+                },
+                stopReason: "stop",
+                timestamp: Date.now()
+            }
+        }));
+        const inferenceRouter = { complete };
+        const executor = appToolExecutorBuild({
+            appId: "github-reviewer",
+            appName: "GitHub Reviewer",
+            appSystemPrompt: "You are a focused review assistant.",
+            reviewerEnabled: false,
+            rlmEnabled: false,
+            sourceIntent: "Review pull requests safely.",
+            rules: { allow: [], deny: [] },
+            inferenceRouter,
+            toolResolver: resolver
+        });
+        const result = await executor.execute({ id: "t1", name: "read", type: "toolCall", arguments: { path: "/tmp/a.txt" } }, contextBuild());
+        expect(complete).not.toHaveBeenCalled();
+        expect(execute).toHaveBeenCalledTimes(1);
+        expect(result.toolMessage.isError).toBe(false);
+    });
+});
+function inferenceRouterBuild(text) {
+    return {
+        complete: vi.fn(async () => ({
+            providerId: "provider",
+            modelId: "model",
+            message: {
+                role: "assistant",
+                content: [{ type: "text", text }],
+                api: "openai-responses",
+                provider: "provider",
+                model: "model",
+                usage: {
+                    input: 0,
+                    output: 0,
+                    cacheRead: 0,
+                    cacheWrite: 0,
+                    totalTokens: 0,
+                    cost: {
+                        input: 0,
+                        output: 0,
+                        cacheRead: 0,
+                        cacheWrite: 0,
+                        total: 0
+                    }
+                },
+                stopReason: "stop",
+                timestamp: Date.now()
+            }
+        }))
+    };
+}
+function resolverBuild(execute) {
+    const schema = Type.Object({}, { additionalProperties: true });
+    return {
+        listTools: () => [
+            { name: "read", description: "read", parameters: schema },
+            { name: "write", description: "write", parameters: schema },
+            { name: "edit", description: "edit", parameters: schema },
+            { name: "exec", description: "exec", parameters: schema },
+            { name: "run_python", description: "run_python", parameters: schema },
+            { name: "request_permission", description: "request_permission", parameters: schema },
+            { name: "cron", description: "cron", parameters: schema }
+        ],
+        execute: vi.fn(async () => execute())
+    };
+}
+function toolResultBuild(isError, text) {
+    return {
+        toolMessage: {
+            role: "toolResult",
+            toolCallId: "t1",
+            toolName: "read",
+            content: [{ type: "text", text }],
+            isError,
+            timestamp: Date.now()
+        },
+        typedResult: { text }
+    };
+}
+function contextBuild() {
+    return {
+        connectorRegistry: null,
+        fileStore: null,
+        auth: null,
+        logger: console,
+        assistant: null,
+        permissions: {
+            workingDir: "/workspace",
+            writeDirs: ["/workspace"],
+            readDirs: ["/workspace"],
+            network: false,
+            events: false
+        },
+        agent: { id: "agent-1" },
+        ctx: null,
+        source: "test",
+        messageContext: {},
+        agentSystem: null,
+        heartbeats: null
+    };
+}
+function contentText(message) {
+    return message.content
+        .filter((entry) => entry.type === "text")
+        .map((entry) => entry.text)
+        .join("\n");
+}
+//# sourceMappingURL=appToolExecutorBuild.spec.js.map