davinci-resolve-mcp 4.8.1 → 4.8.2

package/CHANGELOG.md

@@ -2,6 +2,76 @@
 
 Release history for the DaVinci Resolve MCP Server. The latest release is summarized in the root README; older entries live here to keep the README focused.
 
+## What's New in v4.8.2 — a clip id that resolves to nothing fails the whole clip batch
+
+### Fixed
+
+- **`media_pool` `delete_clips`, `move_clips`, `relink` and `unlink` no longer act on
+  the part of a batch that happened to resolve.** All four resolved `clip_ids` with
+  `[_find_clip(root, cid) for cid in ...]` and then dropped every miss, so Resolve was
+  handed whatever was left. `delete_clips` errored only when *every* id missed
+  (`"No clips found"`); a mixed batch deleted the subset that resolved and answered
+  `{"success": true}`, and with confirm tokens on, the preview and the token covered
+  that subset too. `move_clips`, `relink` and `unlink` did not check for an empty
+  result at all: an all-missing batch reached `MoveClips([], target)` /
+  `RelinkClips([], path)` / `UnlinkClips([])` and reported whatever Resolve's bool
+  said. The caller could not tell a partial change from a whole one.
+  - A new `_clips_from_ids` resolver fails the call before anything reaches Resolve
+    (and before a confirm token is issued) with `CLIP_NOT_FOUND` /
+    `invalid_input`, naming the ids in `error.state.unresolved_clip_ids` and
+    `error.state.resolved_clip_ids`. Nothing is deleted, moved, relinked or unlinked.
+  - An empty or non-list `clip_ids` returns `INVALID_CLIP_IDS` instead of iterating a
+    bare string character by character; a missing one keeps the surface-wide
+    `MISSING_CLIP_IDS`.
+
+### Not changed
+
+- The same drop-the-misses pattern remains in four other `media_pool` actions, which
+  this release does not touch: `create_timeline_from_clips` (simple `clip_ids` mode)
+  builds the timeline from the subset, `append_to_timeline` (legacy `clip_ids` mode)
+  appends the subset and verifies against the resolved count, `export_metadata`
+  exports the subset — and with every id missing calls `ExportMetadata(path, [])`,
+  whose behaviour on an empty list is not measured — and `auto_sync_audio` syncs the
+  subset. The granular server's `delete_media_pool_clips` and `move_clips_to_folder`
+  have the same partial-batch behaviour (they do report a count). The `safe_*` /
+  `organize_clips` family reports its misses in `missing` rather than dropping them
+  silently.
+
+### Validation
+
+- New `tests/test_media_pool_clip_ids.py` pins all four actions against a fake
+  Media Pool that records every mutation call: a partial batch, an all-missing
+  batch, a partial `delete_clips` under confirm-token gating (no token is issued),
+  and the missing / empty / bare-string `clip_ids` shapes, plus the happy path with
+  a clip two folders deep. Against the pre-fix code 5 of its 10 tests fail
+  (17 subtests — every partial and all-missing case, the token case and both
+  shape cases); the 5 that pin preserved behaviour pass on both. All 10 pass after.
+- Offline suite: 3,721 tests run, 84 skipped, 11 errors — all environment gaps on the
+  machine that ran it (`numpy` and `requests` absent from the venv, so five test
+  modules fail to import and one LUT test cannot do arithmetic; `node_modules` not
+  installed, so five `test_offline_fallback` cases cannot load `jszip`). None touch
+  `media_pool`. Drift guards, api-parity, api-limitations and read/write symmetry
+  clean; `test_static_undefined_names` skipped because pyflakes is not installed.
+- **Live-validated on Resolve Studio 21.1.0.14** with the new
+  `tests/live_clip_ids_check.py` (`venv/bin/python tests/live_clip_ids_check.py`)
+  against a real project of 144 folders and 2,600 clips, probing a clip seven
+  folders deep. Partial and all-missing batches came back `CLIP_NOT_FOUND` for all
+  four actions, with no confirm token for the partial delete; bare string and
+  empty list → `INVALID_CLIP_IDS`, no key → `MISSING_CLIP_IDS`; a whole batch still
+  resolved to the real clip. The check is strictly non-destructive: the MediaPool it
+  hands the actions forwards only `GetRootFolder` / `GetCurrentFolder` and
+  intercepts every other method, so `DeleteClips` / `MoveClips` / `RelinkClips` /
+  `UnlinkClips` never reach Resolve whatever the code does; token gating is forced
+  on and no token is passed; the destructive hook's analysis-root writes are
+  disabled and its logs go to a temp directory. Every clip's folder, every folder's
+  parent and the probe clip's File Path read back identical after the run.
+- The same live check against the pre-fix code fails with 18 findings: the tripwire
+  intercepted 10 MediaPool mutations the old code sent — `MoveClips`,
+  `RelinkClips` and `UnlinkClips` with just the probe clip for the partial batches,
+  the same three with an empty list for the all-missing batches, `UnlinkClips([])`
+  for `clip_ids: []` — and the partial `delete_clips` was issued a confirm token.
+  The pool was unchanged after that run too.
+
 ## What's New in v4.8.1 — text modifiers (Follower) attach to TextPlus inputs
 
 ### Added

package/README.md

@@ -2,7 +2,7 @@
 
 English | [简体中文](README.zh-CN.md)
 
-[![Version](https://img.shields.io/badge/version-4.8.1-blue.svg)](https://github.com/samuelgursky/davinci-resolve-mcp/releases)
+[![Version](https://img.shields.io/badge/version-4.8.2-blue.svg)](https://github.com/samuelgursky/davinci-resolve-mcp/releases)
 [![npm](https://img.shields.io/npm/v/davinci-resolve-mcp.svg?label=npm&color=CB3837)](https://www.npmjs.com/package/davinci-resolve-mcp)
 [![API Coverage](https://img.shields.io/badge/API%20Coverage-100%25-brightgreen.svg)](docs/reference/api-coverage.md)
 [![Tools](https://img.shields.io/badge/MCP%20Tools-37%20(389%20full)-blue.svg)](#server-modes)

package/README.zh-CN.md

@@ -2,7 +2,7 @@
 
 [English](README.md) | 简体中文
 
-[![Version](https://img.shields.io/badge/version-4.8.1-blue.svg)](https://github.com/samuelgursky/davinci-resolve-mcp/releases)
+[![Version](https://img.shields.io/badge/version-4.8.2-blue.svg)](https://github.com/samuelgursky/davinci-resolve-mcp/releases)
 [![npm](https://img.shields.io/npm/v/davinci-resolve-mcp.svg?label=npm&color=CB3837)](https://www.npmjs.com/package/davinci-resolve-mcp)
 [![API Coverage](https://img.shields.io/badge/API%20Coverage-100%25-brightgreen.svg)](docs/reference/api-coverage.md)
 [![Tools](https://img.shields.io/badge/MCP%20Tools-37%20(389%20full)-blue.svg)](#服务器模式)
@@ -12,7 +12,7 @@
 [![Python](https://img.shields.io/badge/python-3.10+-green.svg)](https://www.python.org/downloads/)
 [![License](https://img.shields.io/badge/license-MIT-blue.svg)](https://opensource.org/licenses/MIT)
 
-> 本翻译对应 v4.8.1 版 README。如与英文原版有出入，以 [英文原版](README.md) 为准。
+> 本翻译对应 v4.8.2 版 README。如与英文原版有出入，以 [英文原版](README.md) 为准。
 
 一个 Model Context Protocol (MCP) 服务器，让 AI 助手通过官方脚本 API 控制 DaVinci Resolve Studio（达芬奇）。它提供完整的 API 覆盖，外加带护栏的工作流助手，涵盖剪辑、媒体池整理、渲染设置、审阅标记、调色、Fusion、Fairlight、项目生命周期任务、扩展开发，以及不碰源媒体的媒体分析。
 

package/docs/SKILL.md

@@ -922,6 +922,11 @@ Key actions: `get_root_folder`, `get_current_folder`, `set_current_folder(path)`
 `setup_multicam_timeline(name, clip_ids|angles, sync_mode?, include_audio?, dry_run?)`,
 `get_selected`, `set_selected(clip_id)`, `export_metadata(path, clip_ids?)`
 
+`delete_clips`, `move_clips`, `relink` and `unlink` are all-or-nothing: if any id
+in `clip_ids` matches no clip, the call fails with `CLIP_NOT_FOUND` (the
+unresolved and resolved ids are in `error.state`) and no clip is changed. Drop the
+stale ids and retry; do not read a partial batch as done.
+
 Media Pool / Ingest kernel actions (v2.8.0+) add safer agent-facing workflows:
 `ingest_capabilities`, `probe_media_pool`, `probe_ingest_item`,
 `safe_import_media`, `safe_import_sequence`, `safe_import_folder`,

package/install.py

@@ -37,7 +37,7 @@ from src.utils.update_check import (
 
 # ─── Version ──────────────────────────────────────────────────────────────────
 
-VERSION = "4.8.1"
+VERSION = "4.8.2"
 # Only hard floor: mcp[cli] requires Python 3.10+. There is no upper bound —
 # Resolve's scripting bridge loads into newer interpreters on recent builds
 # (Python 3.14 verified against Resolve Studio 20.3.2). Older Resolve builds

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "davinci-resolve-mcp",
-  "version": "4.8.1",
+  "version": "4.8.2",
   "description": "NPM bootstrapper for the DaVinci Resolve MCP Server.",
   "license": "MIT",
   "author": "Samuel Gursky <samgursky@gmail.com>",

package/src/granular/common.py

@@ -93,7 +93,7 @@ if not logging.getLogger().handlers:
         handlers=[logging.StreamHandler()],
     )
 
-VERSION = "4.8.1"
+VERSION = "4.8.2"
 logger = logging.getLogger("davinci-resolve-mcp")
 logger.info(f"Starting DaVinci Resolve MCP Server v{VERSION}")
 logger.info(f"Detected platform: {get_platform()}")

package/src/server.py

@@ -11,7 +11,7 @@ Usage:
     python src/server.py --full       # Start the 377-tool granular server instead
 """
 
-VERSION = "4.8.1"
+VERSION = "4.8.2"
 
 import base64
 import os
@@ -2912,6 +2912,45 @@ def _find_clip(folder, clip_id):
     return None
 
 
+def _clips_from_ids(root, clip_ids, *, verb):
+    """Resolve Media Pool clip unique IDs to clip objects. Returns (clips, error).
+
+    Unresolved ids abort the call instead of being dropped. The raw clip actions
+    used to filter misses out and hand Resolve whatever was left, so a mixed batch
+    deleted, moved, relinked or unlinked the subset that happened to resolve and
+    answered plain {"success": true} — indistinguishable from every id having
+    resolved. move_clips/relink/unlink did not even stop at an empty result:
+    MoveClips([], target) moved nothing and still reported success.
+
+    A non-list is refused rather than iterated: a bare string used to become one
+    id per character, each matching nothing and each silently dropped.
+    """
+    if not isinstance(clip_ids, list) or not clip_ids:
+        return None, _err(
+            "clip_ids must be a non-empty list of Media Pool clip unique IDs",
+            code="INVALID_CLIP_IDS", category="invalid_input",
+            remediation="Pass clip_ids as a list, e.g. params={\"clip_ids\": [\"<id>\"]}.")
+    clips, resolved, unresolved = [], [], []
+    for cid in clip_ids:
+        cid = str(cid)
+        found = _find_clip(root, cid)
+        if found is None:
+            unresolved.append(cid)
+        else:
+            clips.append(found)
+            resolved.append(cid)
+    if unresolved:
+        return None, _err(
+            f"Clip(s) not found: {', '.join(unresolved)}",
+            code="CLIP_NOT_FOUND", category="invalid_input",
+            reason=(f"{len(unresolved)} of {len(clip_ids)} clip_ids matched no clip "
+                    f"anywhere in the Media Pool; nothing was {verb}."),
+            remediation=("List clips with folder get_clips (or media_pool get_selected) "
+                         "and pass only ids that still exist."),
+            state={"unresolved_clip_ids": unresolved, "resolved_clip_ids": resolved})
+    return clips, None
+
+
 def _find_clip_with_parent(folder, clip_id, _parent=None):
     """Return (clip, parent_folder) for clip_id, searching recursively.
 
@@ -21086,6 +21125,9 @@ def media_pool(action: str, params: Optional[Dict[str, Any]] = None) -> Dict[str
           Example: [{"FilePath": "frame_%03d.dpx", "StartIndex": 1, "EndIndex": 100}]
       delete_clips(clip_ids) -> {success}
         DESTRUCTIVE. Removes clips from the Media Pool (does not touch source files).
+        An id matching no clip fails the whole call (CLIP_NOT_FOUND) rather than
+        deleting the ids that did resolve; the same holds for move_clips, relink
+        and unlink.
       move_clips(clip_ids, target_path) -> {success}
       relink(clip_ids, folder_path) -> {success}
         UNSAFE. No dry_run. Prefer safe_relink.
@@ -21393,10 +21435,9 @@ def media_pool(action: str, params: Optional[Dict[str, Any]] = None) -> Dict[str
             result = mp.ImportMedia(paths)
         return {"imported": len(result) if result else 0}
     elif action == "delete_clips":
-        clips = [_find_clip(root, cid) for cid in p["clip_ids"]]
-        clips = [c for c in clips if c]
-        if not clips:
-            return _err("No clips found")
+        clips, clips_err = _clips_from_ids(root, p["clip_ids"], verb="deleted")
+        if clips_err:
+            return clips_err
         if "confirm_token" not in p and "confirmToken" not in p and _confirm_token_required():
             return _issue_confirm_token(
                 action="media_pool.delete_clips", params=p,
@@ -21413,16 +21454,19 @@ def media_pool(action: str, params: Optional[Dict[str, Any]] = None) -> Dict[str
         target = _navigate_folder(mp, p["target_path"])
         if not target:
             return _err(f"Target folder not found: {p['target_path']}")
-        clips = [_find_clip(root, cid) for cid in p["clip_ids"]]
-        clips = [c for c in clips if c]
+        clips, clips_err = _clips_from_ids(root, p["clip_ids"], verb="moved")
+        if clips_err:
+            return clips_err
         return {"success": bool(mp.MoveClips(clips, target))}
     elif action == "relink":
-        clips = [_find_clip(root, cid) for cid in p["clip_ids"]]
-        clips = [c for c in clips if c]
+        clips, clips_err = _clips_from_ids(root, p["clip_ids"], verb="relinked")
+        if clips_err:
+            return clips_err
         return {"success": bool(mp.RelinkClips(clips, p["folder_path"]))}
     elif action == "unlink":
-        clips = [_find_clip(root, cid) for cid in p["clip_ids"]]
-        clips = [c for c in clips if c]
+        clips, clips_err = _clips_from_ids(root, p["clip_ids"], verb="unlinked")
+        if clips_err:
+            return clips_err
         return {"success": bool(mp.UnlinkClips(clips))}
     elif action == "export_metadata":
         clip_ids = p.get("clip_ids")