davinci-resolve-mcp 4.13.0 → 4.13.1

package/CHANGELOG.md

@@ -2,6 +2,51 @@
 
 Release history for the DaVinci Resolve MCP Server. The latest release is summarized in the root README; older entries live here to keep the README focused.
 
+## What's New in v4.13.1 — Windows: liveness checks no longer kill the process they check, and the offline suite runs clean
+
+Closes #278, reported by @AllastorV with the failures grouped by cause. Nobody
+here runs Windows, so everything below was worked out from the code and
+simulated on macOS: the Windows-only API calls are covered by tests that run
+only on Windows.
+
+### Fixes
+
+- **On Windows, three pid liveness checks terminated the process they asked
+  about.** Python's `os.kill(pid, 0)` is a harmless existence check on POSIX,
+  but on Windows any signal other than `CTRL_C_EVENT`/`CTRL_BREAK_EVENT` goes
+  through `TerminateProcess`. `resolve_busy._pid_alive` (the busy sidecar),
+  `mcp_transport.read_transport_state` (the networked-transport state file)
+  and `server._control_panel_pid_alive` (the control-panel pidfile) used it,
+  and all three are routinely asked about the server's own pid. On Windows they
+  now use `proc.windows_pid_alive` (`OpenProcess` + `WaitForSingleObject`, the
+  approach the bridge already used); POSIX is unchanged. A new AST guard fails
+  the suite if a signal-0 probe lands in `src/` without a Windows branch.
+- **`.gitattributes` pins `eol=lf` on the 32 generated agent-rule files**, so
+  a default `core.autocrlf=true` checkout no longer fails
+  `generate.mjs --check`. Existing Windows clones need
+  `git add --renormalize .` or a fresh checkout.
+
+### Tests (Windows portability, no behaviour change)
+
+- **SQLite handles closed before temp dirs are removed** (56 tests across
+  `test_resolve_ai_ledger`, `test_resolve_ai_governance`,
+  `test_resolve21_actions`, `test_provenance`, `MediaAnalysisPlanningTests` and
+  others). Each class follows the existing pattern, closing with
+  `timeline_brain_db.close_all` registered so it runs before the removal. No
+  central hook was added, so a test that leaks a handle still shows. The list
+  came from a macOS run that flags any removal under a live connection: 56
+  before, 0 after.
+- Path expectations are built the way the code builds them, not as POSIX
+  strings (`test_cdl_and_install_config` and others).
+- Symlink-dependent cases skip, with the `OSError` as the reason, when the
+  process cannot create symlinks.
+- One-offs: `sys.executable` instead of `python3`/`cat`; `tempfile.gettempdir()`
+  instead of a literal `/tmp`; the home directory stays resolvable
+  (`USERPROFILE` as well as `HOME`); sandbox-container installer tests pinned
+  to macOS; the unwritable-target installer tests reworked so they still test
+  Windows; a stale `taskkill` expectation updated; `proc.kill()` instead of
+  `SIGKILL`.
+
 ## What's New in v4.13.0 — Resolve 21.1 render-setting parity, `SetHighPriority(bool)`, and a project-destroying preset order
 
 Lands the three items queued for @legionsound in #207. The 21.1 behaviour

package/README.md

@@ -2,7 +2,7 @@
 
 English | [简体中文](README.zh-CN.md)
 
-[![Version](https://img.shields.io/badge/version-4.13.0-blue.svg)](https://github.com/samuelgursky/davinci-resolve-mcp/releases)
+[![Version](https://img.shields.io/badge/version-4.13.1-blue.svg)](https://github.com/samuelgursky/davinci-resolve-mcp/releases)
 [![npm](https://img.shields.io/npm/v/davinci-resolve-mcp.svg?label=npm&color=CB3837)](https://www.npmjs.com/package/davinci-resolve-mcp)
 [![API Coverage](https://img.shields.io/badge/API%20Coverage-100%25-brightgreen.svg)](docs/reference/api-coverage.md)
 [![Tools](https://img.shields.io/badge/MCP%20Tools-37%20(390%20full)-blue.svg)](#server-modes)

package/README.zh-CN.md

@@ -2,7 +2,7 @@
 
 [English](README.md) | 简体中文
 
-[![Version](https://img.shields.io/badge/version-4.13.0-blue.svg)](https://github.com/samuelgursky/davinci-resolve-mcp/releases)
+[![Version](https://img.shields.io/badge/version-4.13.1-blue.svg)](https://github.com/samuelgursky/davinci-resolve-mcp/releases)
 [![npm](https://img.shields.io/npm/v/davinci-resolve-mcp.svg?label=npm&color=CB3837)](https://www.npmjs.com/package/davinci-resolve-mcp)
 [![API Coverage](https://img.shields.io/badge/API%20Coverage-100%25-brightgreen.svg)](docs/reference/api-coverage.md)
 [![Tools](https://img.shields.io/badge/MCP%20Tools-37%20(390%20full)-blue.svg)](#服务器模式)
@@ -12,7 +12,7 @@
 [![Python](https://img.shields.io/badge/python-3.10+-green.svg)](https://www.python.org/downloads/)
 [![License](https://img.shields.io/badge/license-MIT-blue.svg)](https://opensource.org/licenses/MIT)
 
-> 本翻译对应 v4.13.0 版 README。如与英文原版有出入，以 [英文原版](README.md) 为准。
+> 本翻译对应 v4.13.1 版 README。如与英文原版有出入，以 [英文原版](README.md) 为准。
 
 一个 Model Context Protocol (MCP) 服务器，让 AI 助手通过官方脚本 API 控制 DaVinci Resolve Studio（达芬奇）。它提供完整的 API 覆盖，外加带护栏的工作流助手，涵盖剪辑、媒体池整理、渲染设置、审阅标记、调色、Fusion、Fairlight、项目生命周期任务、扩展开发，以及不碰源媒体的媒体分析。
 

package/install.py

@@ -37,7 +37,7 @@ from src.utils.update_check import (
 
 # ─── Version ──────────────────────────────────────────────────────────────────
 
-VERSION = "4.13.0"
+VERSION = "4.13.1"
 # Only hard floor: mcp[cli] requires Python 3.10+. There is no upper bound —
 # Resolve's scripting bridge loads into newer interpreters on recent builds
 # (Python 3.14 verified against Resolve Studio 20.3.2). Older Resolve builds

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "davinci-resolve-mcp",
-  "version": "4.13.0",
+  "version": "4.13.1",
   "description": "NPM bootstrapper for the DaVinci Resolve MCP Server.",
   "license": "MIT",
   "author": "Samuel Gursky <samgursky@gmail.com>",

package/src/granular/common.py

@@ -91,7 +91,7 @@ if not logging.getLogger().handlers:
         handlers=[logging.StreamHandler()],
     )
 
-VERSION = "4.13.0"
+VERSION = "4.13.1"
 logger = logging.getLogger("davinci-resolve-mcp")
 logger.info(f"Starting DaVinci Resolve MCP Server v{VERSION}")
 logger.info(f"Detected platform: {get_platform()}")

package/src/server.py

@@ -11,7 +11,7 @@ Usage:
     python src/server.py --full       # Start the 377-tool granular server instead
 """
 
-VERSION = "4.13.0"
+VERSION = "4.13.1"
 
 import base64
 import os
@@ -75,7 +75,7 @@ from src.utils.page_lock import (
     restoring_page as _restoring_page,
     page_lock as _page_lock,
 )
-from src.utils.proc import safe_run
+from src.utils.proc import safe_run, windows_pid_alive
 from src.utils.readback import verify_by_readback, verification_stats as _verification_stats
 from src.utils import operation_result as _operation_result
 from src.utils import operation_log as _operation_log
@@ -18015,6 +18015,9 @@ def _control_panel_pid_alive(pid: int) -> bool:
     """Check whether a PID is alive on this OS without killing it."""
     if not pid or pid <= 0:
         return False
+    if os.name == "nt":
+        # os.kill(pid, 0) is TerminateProcess on Windows, not a probe.
+        return windows_pid_alive(pid) is True
     try:
         os.kill(pid, 0)  # signal 0 = existence check
     except (ProcessLookupError, PermissionError):

package/src/utils/mcp_transport.py

@@ -28,6 +28,7 @@ import sys
 import time
 
 from src.utils.private_state import private_state_dir, write_private_json
+from src.utils.proc import windows_pid_alive
 
 logger = logging.getLogger("davinci-resolve-mcp")
 
@@ -172,6 +173,12 @@ def read_transport_state():
         return None
     pid = state.get("pid")
     if isinstance(pid, int):
+        if os.name == "nt":
+            # os.kill(pid, 0) is TerminateProcess on Windows, not a probe: the
+            # state file normally names the running server itself.
+            if windows_pid_alive(pid) is not True:
+                return None
+            return state
         try:
             os.kill(pid, 0)
         except (OSError, ProcessLookupError):

package/src/utils/proc.py

@@ -5,9 +5,12 @@ process that inherits stdin can race-read bytes off the protocol stream and
 corrupt it; ``capture_output`` only redirects stdout/stderr. These wrappers
 default ``stdin`` to ``DEVNULL`` so subprocess hygiene is centralized rather
 than re-applied at every call site.
+
+``windows_pid_alive`` lives here too: the Windows replacement for the
+``os.kill(pid, 0)`` liveness probe, which on Windows terminates the process.
 """
 import subprocess
-from typing import Any
+from typing import Any, Optional
 
 
 def safe_run(*args: Any, **kwargs: Any) -> "subprocess.CompletedProcess":
@@ -24,3 +27,59 @@ def safe_popen(*args: Any, **kwargs: Any) -> "subprocess.Popen":
     """subprocess.Popen with stdin defaulted to DEVNULL (override by passing stdin)."""
     kwargs.setdefault("stdin", subprocess.DEVNULL)
     return subprocess.Popen(*args, **kwargs)
+
+
+#: OpenProcess access rights and status codes used by `windows_pid_alive`.
+_WIN_SYNCHRONIZE = 0x00100000
+_WIN_PROCESS_QUERY_LIMITED_INFORMATION = 0x1000
+_WIN_WAIT_OBJECT_0 = 0x0
+_WIN_WAIT_TIMEOUT = 0x102
+_WIN_ERROR_ACCESS_DENIED = 5
+_WIN_ERROR_INVALID_PARAMETER = 87
+
+
+def windows_pid_alive(pid: int) -> Optional[bool]:
+    """Whether `pid` is a running process on Windows, without touching it.
+
+    The POSIX liveness probe, ``os.kill(pid, 0)``, must never run on Windows:
+    there any signal other than CTRL_C_EVENT/CTRL_BREAK_EVENT goes through
+    ``TerminateProcess``, so the "existence check" kills the process it asks
+    about — including this one, when a record names our own pid.
+
+    True: running (access-denied counts, since only a live process can refuse).
+    False: no such process, or it has exited. None: could not be determined.
+    """
+    if not isinstance(pid, int) or pid <= 0:
+        return False
+    try:
+        import ctypes
+        from ctypes import wintypes
+
+        kernel32 = ctypes.WinDLL("kernel32", use_last_error=True)
+        kernel32.OpenProcess.argtypes = [wintypes.DWORD, wintypes.BOOL, wintypes.DWORD]
+        kernel32.OpenProcess.restype = wintypes.HANDLE
+        kernel32.WaitForSingleObject.argtypes = [wintypes.HANDLE, wintypes.DWORD]
+        kernel32.WaitForSingleObject.restype = wintypes.DWORD
+        kernel32.CloseHandle.argtypes = [wintypes.HANDLE]
+        kernel32.CloseHandle.restype = wintypes.BOOL
+
+        access = _WIN_SYNCHRONIZE | _WIN_PROCESS_QUERY_LIMITED_INFORMATION
+        handle = kernel32.OpenProcess(access, False, pid)
+        if not handle:
+            error = ctypes.get_last_error()
+            if error == _WIN_ERROR_INVALID_PARAMETER:
+                return False
+            if error == _WIN_ERROR_ACCESS_DENIED:
+                return True
+            return None
+        try:
+            status = kernel32.WaitForSingleObject(handle, 0)
+        finally:
+            kernel32.CloseHandle(handle)
+        if status == _WIN_WAIT_OBJECT_0:
+            return False  # signalled == exited
+        if status == _WIN_WAIT_TIMEOUT:
+            return True
+        return None
+    except Exception:
+        return None

package/src/utils/resolve_busy.py

@@ -34,6 +34,8 @@ import time
 from contextlib import contextmanager
 from typing import Any, Dict, Optional
 
+from src.utils.proc import windows_pid_alive
+
 _SIDECAR = os.path.join(tempfile.gettempdir(), "davinci_resolve_mcp_busy.json")
 # A long op that has run this long is presumed crashed/leaked and ignored.
 MAX_OP_AGE_SECONDS = 2 * 60 * 60
@@ -47,6 +49,10 @@ _local_owner: Optional[int] = None  # thread ident of the in-process registrant
 
 
 def _pid_alive(pid: int) -> bool:
+    if os.name == "nt":
+        # os.kill(pid, 0) is TerminateProcess on Windows, not a probe: a record
+        # naming this process would kill it.
+        return windows_pid_alive(pid) is True
     try:
         os.kill(pid, 0)
         return True