davinci-resolve-mcp 2.55.2 → 2.56.1

package/CHANGELOG.md

@@ -2,6 +2,46 @@
 
 Release history for the DaVinci Resolve MCP Server. The latest release is summarized in the root README; older entries live here to keep the README focused.
 
+## What's New in v2.56.1
+
+Final reliability batch from the exhaustive audit (Wave B + P2/P3 selections).
+
+- **Fixed** (EX11) `audio_track_probe` reported `available: true` for track index 0
+  (and negatives); audio tracks are 1-indexed, so it now requires
+  `1 <= index <= track_count`.
+- **Fixed** (EX10) `_find_timeline_item_by_id` no longer silently skips a whole
+  track type when `GetTrackCount` errors — it logs the failure so a real API error
+  isn't mistaken for "item not found".
+- **Fixed** (P3) the raw `timeline_item_color.set_cdl` now validates the ASC-CDL
+  payload (shape/ranges) before `SetCDL`, matching its safe twin — malformed CDL
+  returns a structured error instead of being silently rejected by Resolve.
+- **Fixed** (P2) `media_pool.delete_timelines` is read-back verified: it reports
+  `verified` from the project's timeline count dropping, not the unreliable boolean.
+  `import_folder` now validates its required `path`.
+
+## What's New in v2.56.0
+
+Destructive-action registry audit (EX-REG) — a systemic version of the EX2 bug.
+
+Many destructive actions were registered under the **wrong tool key**, so
+`is_destructive()` returned False and **version-on-mutate archiving / change
+logging silently never fired** for them. Examples: `create_timeline`,
+`auto_sync_audio`, `create_stereo_clip`, `append_to_timeline` were filed under
+`timeline` though `media_pool` dispatches them; `set_cdl`, `copy_grades`,
+`export_lut`, the version ops were under `timeline_item` though
+`timeline_item_color` dispatches them; the Fusion-comp and take actions used stale
+names (`add_fusion_comp`, `delete_take`) that matched no real handler.
+
+- **Fixed** rebuilt `DESTRUCTIVE_ACTIONS_BY_TOOL` so every action is keyed under
+  the tool that actually dispatches it (stale names mapped to real ones:
+  `*_fusion_comp` → `*_comp`, `*_take` → `add`/`delete`/`select`/`finalize`,
+  `import_into` → `import_into_timeline`, `create_subtitles_from_audio` →
+  `create_subtitles`). Inert entries whose tool isn't governed (media_pool_item
+  `replace_clip`/`link_*`) were dropped. Catastrophic take/Fusion-comp deletes and
+  the media-pool create/sync ops are now archived as intended.
+- **Added** the registry-drift guard now asserts *every* registry action is a real
+  handler of its tool (broad check enabled), so this class can't regress.
+
 ## What's New in v2.55.2
 
 Deep-QC P1 1b — required-param validation. Mutating/destructive actions that

package/README.md

@@ -1,6 +1,6 @@
 # DaVinci Resolve MCP Server
 
-[![Version](https://img.shields.io/badge/version-2.55.2-blue.svg)](https://github.com/samuelgursky/davinci-resolve-mcp/releases)
+[![Version](https://img.shields.io/badge/version-2.56.1-blue.svg)](https://github.com/samuelgursky/davinci-resolve-mcp/releases)
 [![npm](https://img.shields.io/npm/v/davinci-resolve-mcp.svg?label=npm&color=CB3837)](https://www.npmjs.com/package/davinci-resolve-mcp)
 [![API Coverage](https://img.shields.io/badge/API%20Coverage-100%25-brightgreen.svg)](docs/reference/api-coverage.md)
 [![Tools](https://img.shields.io/badge/MCP%20Tools-34%20(341%20full)-blue.svg)](#server-modes)

package/install.py

@@ -35,7 +35,7 @@ from src.utils.update_check import (
 
 # ─── Version ──────────────────────────────────────────────────────────────────
 
-VERSION = "2.55.2"
+VERSION = "2.56.1"
 # Only hard floor: mcp[cli] requires Python 3.10+. There is no upper bound —
 # Resolve's scripting bridge loads into newer interpreters on recent builds
 # (Python 3.14 verified against Resolve Studio 20.3.2). Older Resolve builds

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "davinci-resolve-mcp",
-  "version": "2.55.2",
+  "version": "2.56.1",
   "description": "NPM bootstrapper for the DaVinci Resolve MCP Server.",
   "license": "MIT",
   "author": "Samuel Gursky <samgursky@gmail.com>",

package/src/granular/common.py

@@ -80,7 +80,7 @@ if not logging.getLogger().handlers:
         handlers=[logging.StreamHandler()],
     )
 
-VERSION = "2.55.2"
+VERSION = "2.56.1"
 logger = logging.getLogger("davinci-resolve-mcp")
 logger.info(f"Starting DaVinci Resolve MCP Server v{VERSION}")
 logger.info(f"Detected platform: {get_platform()}")

package/src/server.py

@@ -11,7 +11,7 @@ Usage:
     python src/server.py --full       # Start the 341-tool granular server instead
 """
 
-VERSION = "2.55.2"
+VERSION = "2.56.1"
 
 import base64
 import os
@@ -1891,7 +1891,10 @@ def _find_timeline_item_by_id(tl, timeline_item_id) -> Optional[Any]:
     for track_type in ("video", "audio", "subtitle"):
         try:
             track_count = int(tl.GetTrackCount(track_type) or 0)
-        except Exception:
+        except Exception as exc:
+            # Don't silently skip a whole track type on API error — log it so a
+            # genuine API failure isn't mistaken for "item not found" (EX10).
+            logger.warning("_find_timeline_item_by_id: GetTrackCount(%s) failed, skipping: %s", track_type, exc)
             continue
         for track_index in range(1, track_count + 1):
             for item in (tl.GetItemListInTrack(track_type, track_index) or []):
@@ -5691,8 +5694,11 @@ def _audio_capabilities():
 def _audio_track_probe(tl, p: Dict[str, Any]):
     track_index = int(p.get("track_index", 1))
     track_count = int(tl.GetTrackCount("audio") or 0)
-    out = {"track_index": track_index, "track_count": track_count, "available": track_index <= track_count}
-    if track_index > track_count:
+    # Resolve audio tracks are 1-indexed; track_index < 1 is invalid (EX11 — the
+    # old `track_index <= track_count` reported available:true for index 0).
+    out = {"track_index": track_index, "track_count": track_count,
+           "available": 1 <= track_index <= track_count}
+    if not (1 <= track_index <= track_count):
         return out
     for key, getter, args in (
         ("sub_type", "GetTrackSubType", ("audio", track_index)),
@@ -15158,7 +15164,13 @@ def media_pool(action: str, params: Optional[Dict[str, Any]] = None) -> Dict[str
         blocked = _consume_confirm_token(action="media_pool.delete_timelines", params=p)
         if blocked:
             return blocked
-        return {"success": bool(mp.DeleteTimelines(timelines))}
+        # Read-back: DeleteTimelines' bool is unreliable; verify by the project's
+        # timeline count dropping (P2).
+        before_n = proj.GetTimelineCount()
+        raw = bool(mp.DeleteTimelines(timelines))
+        after_n = proj.GetTimelineCount()
+        return {"success": raw, "verified": after_n < before_n,
+                "timelines_before": before_n, "timelines_after": after_n}
     elif action == "append_to_timeline":
         if p.get("clip_infos") is not None:
             raw = p["clip_infos"]
@@ -15321,6 +15333,8 @@ def media_pool(action: str, params: Optional[Dict[str, Any]] = None) -> Dict[str
             return _err("Clip not found")
         return {"success": bool(mp.DeleteClipMattes(clip, p["paths"]))}
     elif action == "import_folder":
+        if not p.get("path"):
+            return _err("import_folder requires path")
         return {"success": bool(mp.ImportFolderFromFile(p["path"], p.get("source_clips_path", "")))}
     elif action == "ingest_capabilities":
         return _media_pool_ingest_capabilities()
@@ -20377,7 +20391,12 @@ def timeline_item_color(action: str, params: Optional[Dict[str, Any]] = None) ->
     elif action == "grade_boundary_report":
         return _grade_boundary_report(proj, item, p)
     elif action == "set_cdl":
-        return {"success": bool(item.SetCDL(_normalize_cdl(p["cdl"])))}
+        # Validate ASC-CDL shape before SetCDL (malformed CDL is silently rejected
+        # by Resolve); the raw action shares the safe twin's validator now (P3 #22).
+        validation, err = _validate_cdl_payload(p.get("cdl"))
+        if err:
+            return err
+        return {"success": bool(item.SetCDL(_normalize_cdl(validation["cdl"])))}
     elif action == "copy_grades":
         # Find target items by IDs
         _, tl, _ = _get_tl()

package/src/utils/destructive_hook.py

@@ -40,13 +40,17 @@ logger = logging.getLogger("resolve-mcp.destructive-hook")
 # here; (b) optionally add a metric-capture entry below if it has a sensible
 # default metric.
 
+# Each action is keyed under the tool whose @_destructive_op wrapper actually
+# DISPATCHES it. Historically many entries were filed under the wrong tool key
+# (e.g. create_timeline/auto_sync_audio under "timeline" though they are media_pool
+# actions; set_cdl/copy_grades under "timeline_item" though timeline_item_color
+# dispatches them; *_fusion_comp / *_take stale names that never matched), so
+# is_destructive() returned False and version-on-mutate archiving silently did not
+# fire. EX-REG re-filed every action under its real dispatcher and dropped inert
+# entries whose tool is not @_destructive_op-wrapped (e.g. media_pool_item
+# replace_clip/link_*). The test_destructive_registry_drift guard asserts every
+# string here is a real handler so this can't regress.
 DESTRUCTIVE_ACTIONS_BY_TOOL: Dict[str, FrozenSet[str]] = {
-    # Real COMPOUND media_pool action strings (the @destructive_op("media_pool")
-    # wrapper queries is_destructive("media_pool", <compound action>)). The prior
-    # entries used granular function names (delete_media_pool_clips, …) and
-    # media_pool_item names that the compound tool never dispatches, so catastrophic
-    # deletes silently bypassed version-on-mutate archiving (EX2). media_pool_item
-    # link/replace actions are governed separately (its own tool is not yet wrapped).
     "media_pool": frozenset({
         "delete_clips",
         "delete_folders",
@@ -54,6 +58,14 @@ DESTRUCTIVE_ACTIONS_BY_TOOL: Dict[str, FrozenSet[str]] = {
         "move_folders",
         "delete_clip_mattes",
         "delete_timelines",
+        "create_timeline",
+        "create_timeline_from_clips",
+        "append_to_timeline",
+        "setup_multicam_timeline",
+        "create_stereo_clip",
+        "auto_sync_audio",
+        "set_clip_marks",
+        "clear_clip_marks",
     }),
     "edit_engine": frozenset({
         "execute_selects",
@@ -61,11 +73,6 @@ DESTRUCTIVE_ACTIONS_BY_TOOL: Dict[str, FrozenSet[str]] = {
         "execute_swap",
     }),
     "timeline": frozenset({
-        "create_timeline",
-        "create_timeline_from_clips",
-        "setup_multicam_timeline",
-        "delete_timelines",
-        "append_to_timeline",
         "delete_clips",
         "move_clips",
         "duplicate_clips",
@@ -75,19 +82,9 @@ DESTRUCTIVE_ACTIONS_BY_TOOL: Dict[str, FrozenSet[str]] = {
         "overwrite_range",
         "lift_range",
         "apply_cuts",
-        "create_stereo_clip",
-        "auto_sync_audio",
         "create_compound_clip",
         "create_fusion_clip",
         "convert_to_stereo",
-        "create_subtitles_from_audio",
-        "set_clip_marks",
-        "clear_clip_marks",
-        "set_clip_property",
-        "set_clip_color",
-        "clear_clip_color",
-        "replace_clip",
-        "replace_clip_preserve_sub_clip",
         "set_clips_linked",
         "duplicate",
         "insert_generator",
@@ -108,7 +105,7 @@ DESTRUCTIVE_ACTIONS_BY_TOOL: Dict[str, FrozenSet[str]] = {
         "set_mark_in_out",
         "clear_mark_in_out",
         "set_title_text",
-        "import_into",
+        "import_into_timeline",
     }),
     "timeline_markers": frozenset({
         "add",
@@ -120,77 +117,64 @@ DESTRUCTIVE_ACTIONS_BY_TOOL: Dict[str, FrozenSet[str]] = {
     "timeline_ai": frozenset({
         "detect_scene_cuts",
         "analyze_dolby_vision",
+        "create_subtitles",
     }),
     "timeline_item": frozenset({
         "set_clip_enabled",
-        "set_clip_color",
-        "clear_clip_color",
-        "add_flag",
-        "clear_flags",
         "set_property",
         "set_name",
-        "assign_to_color_group",
-        "remove_from_color_group",
-        "create_magic_mask",
-        "regenerate_magic_mask",
-        "smart_reframe",
-        "stabilize",
         "set_voice_isolation_state",
-        "set_cdl",
-        "copy_grades",
-        "reset_all_node_colors",
-        "set_color_output_cache",
-        "set_fusion_output_cache",
         "update_sidecar",
-        "export_lut",
-        "add_take",
-        "delete_take",
-        "select_take",
-        "finalize_take",
-        "add_version",
-        "delete_version",
-        "load_version",
-        "rename_version",
         "set_transform",
         "set_crop",
         "set_retime",
         "set_composite",
         "set_audio",
-        "set_stabilization",
     }),
     "timeline_item_markers": frozenset({
         "add",
+        "add_flag",
+        "clear_flags",
+        "set_clip_color",
+        "clear_clip_color",
         "delete_at_frame",
         "delete_by_custom_data",
         "delete_by_color",
         "update_custom_data",
     }),
     "timeline_item_fusion": frozenset({
-        "add_fusion_comp",
-        "delete_fusion_comp",
-        "import_fusion_comp",
-        "load_fusion_comp",
-        "rename_fusion_comp",
+        "add_comp",
+        "delete_comp",
+        "import_comp",
+        "load_comp",
+        "rename_comp",
     }),
     "timeline_item_color": frozenset({
         "set_cdl",
         "copy_grades",
         "reset_all_node_colors",
-        "set_node_enabled",
-        "set_node_cache_mode",
-        "set_lut",
-        "apply_grade_from_drx",
-        "apply_arri_cdl_lut",
+        "assign_color_group",
+        "remove_from_color_group",
+        "create_magic_mask",
+        "regenerate_magic_mask",
+        "smart_reframe",
+        "stabilize",
+        "export_lut",
+        "add_version",
+        "delete_version",
+        "load_version",
+        "rename_version",
+        "set_color_cache",
+        "set_fusion_cache",
     }),
     "timeline_item_takes": frozenset({
-        "add_take",
-        "delete_take",
-        "select_take",
-        "finalize_take",
+        "add",
+        "delete",
+        "select",
+        "finalize",
     }),
     "graph": frozenset({
         "set_lut",
-        "set_node_cache_mode",
         "set_node_enabled",
         "apply_arri_cdl_lut",
         "apply_grade_from_drx",
@@ -227,8 +211,10 @@ NO_ARCHIVE_ON_KEYS: Dict[Tuple[str, str], frozenset] = {
 # first, the user almost certainly wants to know before losing data.
 
 STRICT_DEFAULT_ACTIONS: frozenset = frozenset({
-    ("timeline", "delete_timelines"),
     ("timeline", "delete_track"),
+    # NOTE: delete_timelines is a media_pool action (EX-REG re-keyed it); it is
+    # archive+confirm-token gated (EX3) rather than strict, per the decision that
+    # strict over-blocks deletes when there is nothing to archive.
     # delete_clips with ripple=True is destructive in a way single-clip delete
     # isn't — handled separately in is_strict_required() because it depends on
     # the params payload, not just the action name.