davinci-resolve-mcp 2.37.1 → 2.37.3

package/CHANGELOG.md

@@ -2,6 +2,54 @@
 
 Release history for the DaVinci Resolve MCP Server. The latest release is summarized in the root README; older entries live here to keep the README focused.
 
+## What's New in v2.37.3
+
+Deep-audit fixes, rounds two and three: agent-facing action discovery,
+crash-safe user-state persistence, and resource hygiene.
+
+- **Fixed** three tools' unknown-action error lists drifting from their real
+  dispatch: `timeline` omitted `clip_where` and `action_help`;
+  `timeline_item_color` and `graph` omitted `action_help`. Agents recovering
+  from a typo now see the full action set. A static AST test keeps every
+  tool's advertised list in both-way sync with its dispatch (and verifies
+  docstring-advertised actions are real).
+- **Fixed** user-state files being vulnerable to truncation by a crash
+  mid-write. Affected files all reset to `{}` on corruption, so the next
+  save would silently wipe remaining user data. Writers now use atomic
+  temp-file + `os.replace`: `media-analysis-preferences.json` (all
+  analysis/caps/governance/update defaults — including the
+  `set_resolution_tier` and `set_caps_preset` paths, now routed through the
+  shared writer), `update-check.json`, the dashboard's `analysis.json`
+  transcription patch, and `transcript-corrections.json`.
+- **Fixed** `_safe_project_delete` discarding `SaveProject()`'s result when
+  closing the current project before deletion; a failed save now surfaces
+  as a warning in the response.
+- **Fixed** a file-descriptor leak: the parent kept its copy of the control
+  panel's log handle open after spawning the detached child.
+- Audit classes verified clean: bare excepts, mutable default arguments,
+  `asyncio.run` inside running loops, subprocess timeouts, docstring phantom
+  actions, silent-success swallows in metadata/marker/archive write paths.
+
+## What's New in v2.37.2
+
+Static-audit fixes — four undefined-name references that silently fell back
+to defaults instead of erroring (the same bug class as the v2.37.0
+confirm-token fix), plus a regression guard.
+
+- **Fixed** the `status://mcp_version` resource reporting update channel
+  `"stable"` unconditionally; it now calls the real `get_update_channel()`,
+  so beta/dev channel installs report correctly.
+- **Fixed** the `versioning_auto_run_idle_timeout_seconds` preference being
+  silently ignored (auto-run idle timeout was always 90s) due to a
+  misspelled preference-reader name in the destructive hook.
+- **Fixed** resolve-state snapshot tokens always falling back to a timestamp
+  because `short_hash` was never imported; tokens are now content-stable.
+- **Fixed** the timeline-kernel live probe's MCP-stub fallback crashing with
+  a `NameError` (missing `types` import) exactly when the mcp library is
+  absent — the only case the fallback exists for.
+- **Added** a static test that runs pyflakes over `src/` and fails on any
+  undefined name, so this bug class cannot reappear unnoticed.
+
 ## What's New in v2.37.1
 
 Test-suite hygiene — no server behavior changed.

package/README.md

@@ -1,6 +1,6 @@
 # DaVinci Resolve MCP Server
 
-[![Version](https://img.shields.io/badge/version-2.37.1-blue.svg)](https://github.com/samuelgursky/davinci-resolve-mcp/releases)
+[![Version](https://img.shields.io/badge/version-2.37.3-blue.svg)](https://github.com/samuelgursky/davinci-resolve-mcp/releases)
 [![npm](https://img.shields.io/npm/v/davinci-resolve-mcp.svg?label=npm&color=CB3837)](https://www.npmjs.com/package/davinci-resolve-mcp)
 [![API Coverage](https://img.shields.io/badge/API%20Coverage-100%25-brightgreen.svg)](docs/reference/api-coverage.md)
 [![Tools](https://img.shields.io/badge/MCP%20Tools-33%20(341%20full)-blue.svg)](#server-modes)

package/install.py

@@ -35,7 +35,7 @@ from src.utils.update_check import (
 
 # ─── Version ──────────────────────────────────────────────────────────────────
 
-VERSION = "2.37.1"
+VERSION = "2.37.3"
 # Only hard floor: mcp[cli] requires Python 3.10+. There is no upper bound —
 # Resolve's scripting bridge loads into newer interpreters on recent builds
 # (Python 3.14 verified against Resolve Studio 20.3.2). Older Resolve builds

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "davinci-resolve-mcp",
-  "version": "2.37.1",
+  "version": "2.37.3",
   "description": "NPM bootstrapper for the DaVinci Resolve MCP Server.",
   "license": "MIT",
   "author": "Samuel Gursky <samgursky@gmail.com>",

package/src/analysis_dashboard.py

@@ -21,6 +21,7 @@ from typing import Any, Dict, List, Optional, Tuple
 from urllib.parse import parse_qs, unquote, urlparse
 
 from src.utils.media_analysis import (
+    _write_json as _atomic_write_json,
     analysis_index_status,
     analysis_root_coverage,
     build_analysis_index,
@@ -12605,9 +12606,7 @@ def regenerate_clip_transcript(
     if payload.get("words"):
         updated_report["transcription"]["words"] = payload["words"]
     try:
-        with open(artifacts["analysis_json"], "w", encoding="utf-8") as handle:
-            json.dump(updated_report, handle, indent=2)
-            handle.write("\n")
+        _atomic_write_json(artifacts["analysis_json"], updated_report)
     except Exception as exc:
         return {"success": False, "error": f"transcript written but analysis.json patch failed: {exc}"}
     word_segment_count = sum(1 for seg in (payload.get("segments") or []) if isinstance(seg, dict) and seg.get("words"))
@@ -12779,9 +12778,7 @@ def save_clip_transcript_corrections(project_root: str, clip_id: str, body: Dict
         },
     }
     try:
-        with open(path, "w", encoding="utf-8") as handle:
-            json.dump(payload, handle, indent=2)
-            handle.write("\n")
+        _atomic_write_json(path, payload)
     except Exception as exc:
         return {"success": False, "error": str(exc)}
     return {

package/src/granular/common.py

@@ -80,7 +80,7 @@ if not logging.getLogger().handlers:
         handlers=[logging.StreamHandler()],
     )
 
-VERSION = "2.37.1"
+VERSION = "2.37.3"
 logger = logging.getLogger("davinci-resolve-mcp")
 logger.info(f"Starting DaVinci Resolve MCP Server v{VERSION}")
 logger.info(f"Detected platform: {get_platform()}")

package/src/granular/resolve_control.py

@@ -534,5 +534,5 @@ def quit_resolve() -> Dict[str, Any]:
     resolve = get_resolve()
     if resolve is None:
         return {"error": "Not connected to DaVinci Resolve"}
-    result = resolve.Quit()
+    resolve.Quit()
     return {"success": True, "message": "DaVinci Resolve is quitting"}

package/src/server.py

@@ -11,7 +11,7 @@ Usage:
     python src/server.py --full       # Start the 341-tool granular server instead
 """
 
-VERSION = "2.37.1"
+VERSION = "2.37.3"
 
 import base64
 import os
@@ -53,6 +53,7 @@ from src.utils.update_check import (
     check_for_updates,
     clear_update_prompt_preferences,
     get_cached_update_status,
+    get_update_channel,
     get_update_mode,
     ignore_update_version,
     set_update_mode,
@@ -78,6 +79,7 @@ from src.utils.media_analysis import (
     load_report as load_media_analysis_report,
     query_analysis_index,
     resolve_output_root as resolve_media_analysis_output_root,
+    short_hash,
     slugify,
     summarize_reports as summarize_media_analysis_reports,
 )
@@ -6942,11 +6944,22 @@ def _read_media_analysis_preferences() -> Dict[str, Any]:
 
 
 def _write_media_analysis_preferences(preferences: Dict[str, Any]) -> None:
+    # Atomic replace: a crash mid-write must not truncate the file, because the
+    # reader resets to {} on corruption and the next save would then wipe every
+    # remaining user preference.
     path = _media_analysis_preferences_path()
     os.makedirs(os.path.dirname(path), exist_ok=True)
-    with open(path, "w", encoding="utf-8") as handle:
-        json.dump(preferences, handle, indent=2, sort_keys=True)
-        handle.write("\n")
+    tmp_path = f"{path}.tmp-{os.getpid()}-{threading.get_ident()}-{time.time_ns()}"
+    try:
+        with open(tmp_path, "w", encoding="utf-8") as handle:
+            json.dump(preferences, handle, indent=2, sort_keys=True)
+            handle.write("\n")
+        os.replace(tmp_path, path)
+    finally:
+        try:
+            os.remove(tmp_path)
+        except OSError:
+            pass
 
 
 def _setup_text_key(value: Any) -> str:
@@ -11551,6 +11564,11 @@ def _open_control_panel(p: Dict[str, Any]) -> Dict[str, Any]:
         )
     except (OSError, FileNotFoundError) as exc:
         return _err(f"Failed to launch control panel: {type(exc).__name__}: {exc}")
+    finally:
+        # The child holds its own copy of the fd; keeping ours open would leak
+        # one descriptor per panel launch.
+        if log_handle is not subprocess.DEVNULL:
+            log_handle.close()
 
     # Verify the child actually came up. Bind errors (port in use), import
     # failures, etc. would otherwise leave us reporting "launched" while the
@@ -11671,7 +11689,7 @@ def _resolve_save_state() -> Dict[str, Any]:
                     state["current_folder_name"] = current_folder.GetName()
         except Exception:
             pass
-    token = short_hash(json.dumps(state, sort_keys=True, default=str), length=12) if "short_hash" in globals() else str(int(time.time() * 1000))
+    token = short_hash(json.dumps(state, sort_keys=True, default=str), length=12)
     _RESOLVE_STATE_SNAPSHOTS[token] = state
     # Prune old snapshots (keep last 20)
     if len(_RESOLVE_STATE_SNAPSHOTS) > 20:
@@ -12268,11 +12286,14 @@ def _safe_project_delete(pm, p: Dict[str, Any]) -> Dict[str, Any]:
     if current_name == name:
         if not p.get("close_current", False):
             return _err("Refusing to delete the currently open project; pass close_current=True")
-        if p.get("save_current", True):
-            pm.SaveProject()
+        saved = bool(pm.SaveProject()) if p.get("save_current", True) else None
         closed = bool(pm.CloseProject(current))
         if not closed:
             return _err(f"Failed to close current project '{name}' before delete")
+        result = {"success": bool(pm.DeleteProject(name))}
+        if saved is False:
+            result["warning"] = "SaveProject returned False before close; unsaved changes may have been discarded"
+        return result
     return {"success": bool(pm.DeleteProject(name))}
 
 
@@ -14757,10 +14778,7 @@ async def media_analysis(action: str, params: Optional[Dict[str, Any]] = None, c
         prefs["resolve_ai_governance_preset"] = preset
         if isinstance(p.get("overrides"), dict):
             prefs["resolve_ai_governance_overrides"] = p["overrides"]
-        path = _media_analysis_preferences_path()
-        os.makedirs(os.path.dirname(path), exist_ok=True)
-        with open(path, "w", encoding="utf-8") as fh:
-            json.dump(prefs, fh, indent=2)
+        _write_media_analysis_preferences(prefs)
         return {"success": True, "tier": preset, "overrides": prefs.get("resolve_ai_governance_overrides") or {}}
     if action == "set_caps_preset":
         preset = (p.get("preset") or "").strip().lower()
@@ -14772,10 +14790,7 @@ async def media_analysis(action: str, params: Optional[Dict[str, Any]] = None, c
         prefs["analysis_caps_preset"] = preset
         if isinstance(p.get("overrides"), dict):
             prefs["analysis_caps_overrides"] = p["overrides"]
-        path = _media_analysis_preferences_path()
-        os.makedirs(os.path.dirname(path), exist_ok=True)
-        with open(path, "w", encoding="utf-8") as fh:
-            json.dump(prefs, fh, indent=2)
+        _write_media_analysis_preferences(prefs)
         return {"success": True, "preset": preset, "overrides": prefs.get("analysis_caps_overrides") or {}}
     if action == "get_usage":
         from src.utils import analysis_caps as _ac
@@ -16097,7 +16112,7 @@ def timeline(action: str, params: Optional[Dict[str, Any]] = None) -> Dict[str,
         if mp_err:
             return mp_err
         return _fairlight_boundary_report(proj, mp, tl, p)
-    return _unknown(action, ["list","get_current","set_current","get_name","set_name","get_start_frame","get_end_frame","get_start_timecode","set_start_timecode","get_track_count","add_track","delete_track","get_track_sub_type","set_track_enable","get_track_enabled","set_track_lock","get_track_locked","get_track_name","set_track_name","get_items","delete_clips","set_clips_linked","duplicate","duplicate_clips","copy_clips","move_clips","copy_range","duplicate_range","overwrite_range","lift_range","story_spine_report","create_variant_from_ranges","bulk_set_item_properties","apply_look_to_items","thumbnail_contact_sheet","marker_thumbnail_review","edit_kernel_capabilities","probe_edit_kernel_item","title_property_scan","set_title_text","bulk_set_title_text","create_compound_clip","create_fusion_clip","import_into_timeline","export","get_setting","set_setting","insert_generator","insert_fusion_generator","insert_fusion_composition","insert_ofx_generator","insert_title","insert_fusion_title","get_unique_id","get_node_graph","get_media_pool_item","get_transcript","propose_cuts","apply_cuts","get_mark_in_out","set_mark_in_out","clear_mark_in_out","convert_to_stereo","get_items_in_track","get_voice_isolation_state","set_voice_isolation_state","extract_source_frame_ranges","audio_mix_capability_report",*_TIMELINE_CONFORM_KERNEL_ACTIONS,*_TIMELINE_AUDIO_KERNEL_ACTIONS])
+    return _unknown(action, ["list","get_current","set_current","get_name","set_name","get_start_frame","get_end_frame","get_start_timecode","set_start_timecode","get_track_count","add_track","delete_track","get_track_sub_type","set_track_enable","get_track_enabled","set_track_lock","get_track_locked","get_track_name","set_track_name","get_items","delete_clips","set_clips_linked","duplicate","duplicate_clips","copy_clips","move_clips","copy_range","duplicate_range","overwrite_range","lift_range","story_spine_report","create_variant_from_ranges","bulk_set_item_properties","apply_look_to_items","thumbnail_contact_sheet","marker_thumbnail_review","edit_kernel_capabilities","probe_edit_kernel_item","title_property_scan","set_title_text","bulk_set_title_text","create_compound_clip","create_fusion_clip","import_into_timeline","export","get_setting","set_setting","insert_generator","insert_fusion_generator","insert_fusion_composition","insert_ofx_generator","insert_title","insert_fusion_title","get_unique_id","get_node_graph","get_media_pool_item","get_transcript","propose_cuts","apply_cuts","get_mark_in_out","set_mark_in_out","clear_mark_in_out","convert_to_stereo","get_items_in_track","get_voice_isolation_state","set_voice_isolation_state","extract_source_frame_ranges","audio_mix_capability_report","clip_where","action_help",*_TIMELINE_CONFORM_KERNEL_ACTIONS,*_TIMELINE_AUDIO_KERNEL_ACTIONS])
 
 
 # ═══════════════════════════════════════════════════════════════════════════════
@@ -18016,7 +18031,7 @@ def timeline_item_color(action: str, params: Optional[Dict[str, Any]] = None) ->
         return {"success": bool(item.CreateMagicMask(p.get("mode", "F")))}
     elif action == "regenerate_magic_mask":
         return {"success": bool(item.RegenerateMagicMask())}
-    return _unknown(action, ["set_cdl","copy_grades","add_version","get_current_version","get_version_names","load_version","rename_version","delete_version","get_node_graph","get_color_group","assign_color_group","remove_from_color_group","export_lut","get_color_cache","set_color_cache","get_fusion_cache","set_fusion_cache","reset_all_node_colors","stabilize","smart_reframe","create_magic_mask","regenerate_magic_mask",*_COLOR_GRADE_KERNEL_ACTIONS])
+    return _unknown(action, ["set_cdl","copy_grades","add_version","get_current_version","get_version_names","load_version","rename_version","delete_version","get_node_graph","get_color_group","assign_color_group","remove_from_color_group","export_lut","get_color_cache","set_color_cache","get_fusion_cache","set_fusion_cache","reset_all_node_colors","stabilize","smart_reframe","create_magic_mask","regenerate_magic_mask","action_help",*_COLOR_GRADE_KERNEL_ACTIONS])
 
 
 # ═══════════════════════════════════════════════════════════════════════════════
@@ -18400,7 +18415,7 @@ def graph(action: str, params: Optional[Dict[str, Any]] = None) -> Dict[str, Any
         if blocked:
             return blocked
         return {"success": bool(g.ResetAllGrades())}
-    return _unknown(action, ["get_num_nodes","get_lut","set_lut","get_node_cache","set_node_cache","get_node_label","get_tools_in_node","set_node_enabled","apply_grade_from_drx","apply_arri_cdl_lut","reset_all_grades"])
+    return _unknown(action, ["get_num_nodes","get_lut","set_lut","get_node_cache","set_node_cache","get_node_label","get_tools_in_node","set_node_enabled","apply_grade_from_drx","apply_arri_cdl_lut","reset_all_grades","action_help"])
 
 
 # ═══════════════════════════════════════════════════════════════════════════════
@@ -21155,7 +21170,7 @@ def _resource_mcp_version() -> Dict[str, Any]:
     """Server version, build, and update channel. Pure read — no Resolve required."""
     return {
         "version": VERSION,
-        "channel": _update_channel_current() if "_update_channel_current" in globals() else "stable",
+        "channel": get_update_channel(),
     }
 
 

package/src/utils/destructive_hook.py

@@ -369,7 +369,7 @@ def _extract_analysis_run_id(params: Optional[Dict[str, Any]], project_root: Opt
             return str(rid)
     if project_root:
         try:
-            timeout = float(_preference("versioning_auto_run_idle_timeout_seconds", default=90))
+            timeout = float(_read_preference("versioning_auto_run_idle_timeout_seconds", default=90))
         except Exception:
             timeout = 90.0
         try:

package/src/utils/timeline_kernel_live_probe.py

@@ -18,6 +18,7 @@ import subprocess
 import sys
 import tempfile
 import time
+import types
 import traceback
 from pathlib import Path
 from typing import Any, Dict, Iterable, List, Optional, Tuple

package/src/utils/update_check.py

@@ -631,13 +631,22 @@ def _read_state(path: Path) -> Dict[str, Any]:
 
 
 def _write_state(path: Path, result: Mapping[str, Any]) -> None:
+    # Atomic replace: _read_state resets to {} on a corrupt file, so a crash
+    # mid-write would silently drop snooze/ignore preferences.
+    tmp_path = path.with_name(f"{path.name}.tmp-{os.getpid()}")
     try:
         path.parent.mkdir(parents=True, exist_ok=True)
-        with path.open("w", encoding="utf-8") as handle:
+        with tmp_path.open("w", encoding="utf-8") as handle:
             json.dump(result, handle, indent=2, sort_keys=True)
             handle.write("\n")
+        os.replace(tmp_path, path)
     except OSError:
         return
+    finally:
+        try:
+            os.remove(tmp_path)
+        except OSError:
+            pass
 
 
 def _set_cached_status(result: Mapping[str, Any]) -> None: