davinci-resolve-mcp 2.210.0 → 2.211.0
This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
- package/CHANGELOG.md +66 -0
- package/README.md +1 -1
- package/README.zh-CN.md +2 -2
- package/docs/SKILL.md +11 -3
- package/docs/reference/api-limitations.md +10 -1
- package/install.py +1 -1
- package/package.json +1 -1
- package/src/granular/common.py +1 -1
- package/src/server.py +38 -8
- package/src/utils/api_truth.py +31 -0
- package/src/utils/destructive_hook.py +121 -0
package/CHANGELOG.md
CHANGED
|
@@ -2,6 +2,72 @@
|
|
|
2
2
|
|
|
3
3
|
Release history for the DaVinci Resolve MCP Server. The latest release is summarized in the root README; older entries live here to keep the README focused.
|
|
4
4
|
|
|
5
|
+
## What's New in v2.211.0 — dry_run on an action that cannot honour it now refuses instead of executing
|
|
6
|
+
|
|
7
|
+
### Changed
|
|
8
|
+
|
|
9
|
+
- **An explicit `dry_run=true` on a destructive action with no native dry-run path is refused, not executed.**
|
|
10
|
+
102 of the 108 registered destructive actions never read the flag, so
|
|
11
|
+
`timeline_markers.add` with `dry_run=true` added a real marker and
|
|
12
|
+
`timeline.delete_track` with `dry_run=true` deleted the track — and the
|
|
13
|
+
agent guidance says to prefer `dry_run` where it exists, which cannot be
|
|
14
|
+
told from outside. The destructive-operation wrapper now returns
|
|
15
|
+
`DRY_RUN_UNAVAILABLE` (`status: dry_run_unavailable`, `dry_run: true`,
|
|
16
|
+
`simulated: false`, `executed: false`, the same static risk block as
|
|
17
|
+
`inspect_operation`, and a remediation) before any archive, state lookup,
|
|
18
|
+
or handler execution. The security audit log records it as
|
|
19
|
+
`blocked` / `dry_run_unavailable`. This is a refusal, not a synthesised
|
|
20
|
+
preview — the lifecycle pipeline's original interceptor answered
|
|
21
|
+
`success: true` for calls it never ran and was removed for it.
|
|
22
|
+
|
|
23
|
+
- **The six actions that do honour `dry_run` are an allowlist, `NATIVE_DRY_RUN_ACTIONS`.**
|
|
24
|
+
`media_pool.set_clip_marks`, `media_pool.clear_clip_marks`,
|
|
25
|
+
`media_pool.setup_multicam_timeline`, `timeline.apply_cuts`,
|
|
26
|
+
`timeline.ripple_insert`, `timeline_ai.create_subtitles`. A static drift
|
|
27
|
+
test pins the list to the handlers by following the params object into
|
|
28
|
+
helper calls; that is what excluded `edit_engine.execute_tighten` and
|
|
29
|
+
`execute_silence_ripple`, which call a dry_run-aware helper but hand it a
|
|
30
|
+
fresh dict without the flag. Add a native dry-run branch and the test says
|
|
31
|
+
to list it; list an action without one and the test refuses.
|
|
32
|
+
|
|
33
|
+
- **The refusal is keyed on registry membership, not on `is_destructive()`**, so
|
|
34
|
+
the no-archive filters (a Notes edit) cannot let a dry-run request through to
|
|
35
|
+
a handler that would execute it.
|
|
36
|
+
|
|
37
|
+
- Adapted from PR #190 by @Rohitkanithi, which introduced the refusal shape
|
|
38
|
+
as a denylist of the fourteen marker actions; landed as an allowlist so the
|
|
39
|
+
other 88 actions that ignore the flag are covered too.
|
|
40
|
+
|
|
41
|
+
## What's New in v2.210.1 — frame capture and verify_output no longer read JobStatus in English
|
|
42
|
+
|
|
43
|
+
### Fixed
|
|
44
|
+
|
|
45
|
+
- **Single-frame capture failed with `RENDER_FAILED` on every non-English Resolve (issue #191).**
|
|
46
|
+
`GetRenderJobStatus()["JobStatus"]` is a localized display string — `"Concluso"`
|
|
47
|
+
on an Italian install — and the capture gate compared it to the English word,
|
|
48
|
+
so a finished render with the file already on disk reported "Render did not
|
|
49
|
+
complete". Completion is now decided by `_render_job_completed()` on
|
|
50
|
+
`CompletionPercentage` and `Error`, which are locale-independent, with the
|
|
51
|
+
file-written check as the real proof. `render.verify_output` carried the same
|
|
52
|
+
comparison in its "not Complete" warning and its missing-file warning; both
|
|
53
|
+
use the same rule now, so a localized finished job verifies and a localized
|
|
54
|
+
failed job still does not. Reported with an exact API readback by
|
|
55
|
+
@gabrieleleonardi-sya.
|
|
56
|
+
|
|
57
|
+
### Documentation
|
|
58
|
+
|
|
59
|
+
- New API truth entry for the localized `JobStatus` field, submitted to the
|
|
60
|
+
Blackmagic-facing report as a missing locale-independent status code, and a
|
|
61
|
+
regenerated `docs/reference/api-limitations.md`.
|
|
62
|
+
|
|
63
|
+
### Validation
|
|
64
|
+
|
|
65
|
+
- Unit tests cover the reporter's readback (`Concluso` at 100%), a localized
|
|
66
|
+
failed job carrying `Error`, and a localized incomplete job without one; the
|
|
67
|
+
English fast path is unchanged. No localized Resolve is available on the
|
|
68
|
+
release machine, so the live evidence is the reporter's session on Studio
|
|
69
|
+
21.0.2.4.
|
|
70
|
+
|
|
5
71
|
## What's New in v2.210.0 — every destructive action now carries a real risk rating
|
|
6
72
|
|
|
7
73
|
### Changed
|
package/README.md
CHANGED
|
@@ -2,7 +2,7 @@
|
|
|
2
2
|
|
|
3
3
|
English | [简体中文](README.zh-CN.md)
|
|
4
4
|
|
|
5
|
-
[](https://github.com/samuelgursky/davinci-resolve-mcp/releases)
|
|
6
6
|
[](https://www.npmjs.com/package/davinci-resolve-mcp)
|
|
7
7
|
[](docs/reference/api-coverage.md)
|
|
8
8
|
[-blue.svg)](#server-modes)
|
package/README.zh-CN.md
CHANGED
|
@@ -2,7 +2,7 @@
|
|
|
2
2
|
|
|
3
3
|
[English](README.md) | 简体中文
|
|
4
4
|
|
|
5
|
-
[](https://github.com/samuelgursky/davinci-resolve-mcp/releases)
|
|
6
6
|
[](https://www.npmjs.com/package/davinci-resolve-mcp)
|
|
7
7
|
[](docs/reference/api-coverage.md)
|
|
8
8
|
[-blue.svg)](#服务器模式)
|
|
@@ -12,7 +12,7 @@
|
|
|
12
12
|
[](https://www.python.org/downloads/)
|
|
13
13
|
[](https://opensource.org/licenses/MIT)
|
|
14
14
|
|
|
15
|
-
> 本翻译对应 v2.
|
|
15
|
+
> 本翻译对应 v2.211.0 版 README。如与英文原版有出入,以 [英文原版](README.md) 为准。
|
|
16
16
|
|
|
17
17
|
一个 Model Context Protocol (MCP) 服务器,让 AI 助手通过官方脚本 API 控制 DaVinci Resolve Studio(达芬奇)。它提供完整的 API 覆盖,外加带护栏的工作流助手,涵盖剪辑、媒体池整理、渲染设置、审阅标记、调色、Fusion、Fairlight、项目生命周期任务、扩展开发,以及不碰源媒体的媒体分析。
|
|
18
18
|
|
package/docs/SKILL.md
CHANGED
|
@@ -289,12 +289,20 @@ Example trace shape returned by `resolve_control(action="get_execution_trace")`:
|
|
|
289
289
|
availability was not determined, never that there is none; and
|
|
290
290
|
`pre_state_available` separates "no project open" from "state never read".
|
|
291
291
|
For an actual preview, use the action's own `dry_run` where it has one.
|
|
292
|
+
Where it has none, an explicit `dry_run=true` on a registered destructive
|
|
293
|
+
action is refused with `DRY_RUN_UNAVAILABLE` (`status: dry_run_unavailable`,
|
|
294
|
+
`simulated: false`, `executed: false`, plus the same static risk block)
|
|
295
|
+
before any archive, state lookup, or handler execution. Until v2.211.0 the
|
|
296
|
+
flag was silently ignored on those actions and the mutation ran; the
|
|
297
|
+
actions that do honour it are listed in `NATIVE_DRY_RUN_ACTIONS`
|
|
298
|
+
(`src/utils/destructive_hook.py`) and pinned to the handlers by a test.
|
|
292
299
|
- **`list_lifecycle_hooks()`**: Returns active execution lifecycle pipeline hooks
|
|
293
300
|
(`risk_classification`, `resolve_state_inspection`, `readback_verification`,
|
|
294
301
|
`drift_detection`, `provenance_trace`). All of them observe; none replaces a
|
|
295
|
-
tool result. `dry_run` therefore
|
|
296
|
-
|
|
297
|
-
|
|
302
|
+
tool result. `dry_run` is therefore never answered on a handler's behalf:
|
|
303
|
+
an action with a native dry-run path runs it, and every other registered
|
|
304
|
+
destructive action refuses the flag instead of either simulating or
|
|
305
|
+
executing.
|
|
298
306
|
|
|
299
307
|
Explicit correlation is also supported per-call: pass `params={"execution_id": ...}`
|
|
300
308
|
or `params={"trace_id": ...}` in any tool call to associate it with a specific trace.
|
|
@@ -12,7 +12,7 @@ that none exists).
|
|
|
12
12
|
|
|
13
13
|
**Verified on:** DaVinci Resolve Studio 21.0.2
|
|
14
14
|
|
|
15
|
-
**Totals:**
|
|
15
|
+
**Totals:** 42 missing capabilities, 50 bugs / unreliable behaviors.
|
|
16
16
|
|
|
17
17
|
The authoritative source is the runtime-queryable `api_truth` ledger
|
|
18
18
|
(`resolve_control api_truth "<query>"`); this document is generated from
|
|
@@ -228,6 +228,15 @@ equivalent, blocking full automation.
|
|
|
228
228
|
- **Workaround / current handling:** capture_media_template harvests mediaStartTime and the native clip elements; drt.assemble clones the source's own captured clip per cut (render-verified: the TC-bearing source plays picture and audio, and the full AAF route renders frame-accurately). Re-capture templates for TC-bearing media. The assemble bridge merges identical audio channel legs (report.audioChannelLegsMerged) instead of refusing them as a same-track overlap.
|
|
229
229
|
- **Tags:** timecode, aaf, audio, drt, silent-failure
|
|
230
230
|
|
|
231
|
+
### Project.GetRenderJobStatus JobStatus (localized display string)
|
|
232
|
+
|
|
233
|
+
- **Object:** `Project`
|
|
234
|
+
- **Signature:** `(jobId) -> {JobStatus, CompletionPercentage, TimeTakenToRenderInMs, Error?}`
|
|
235
|
+
- **Behavior:** JobStatus is a display string that follows the application language, not an enum. An English install reports "Complete"; an Italian install reports "Concluso" for the same finished job — read back as {JobStatus: "Concluso", CompletionPercentage: 100, TimeTakenToRenderInMs: 1225} on Studio 21.0.2.4 / macOS 15 with the output file complete on disk (issue #191, reporter's session). Any code that compares the field to the English word fails every non-English Resolve with an error that says the opposite of what happened; this server's single-frame capture did exactly that until v2.210.1. CompletionPercentage is numeric and locale-independent, and Error is populated on a failed job in every language.
|
|
236
|
+
- **Workaround / current handling:** Never gate on the JobStatus string. Treat a job as finished when CompletionPercentage reaches 100 and Error is empty, then confirm the output file exists — the file is the real proof either way (see the recordFrame entry above for a Complete job that wrote a stub). Report JobStatus verbatim for humans only. This server's _render_job_completed() applies the rule to frame capture and render.verify_output.
|
|
237
|
+
- **Reference:** [issue #191](https://github.com/samuelgursky/davinci-resolve-mcp/issues/191)
|
|
238
|
+
- **Tags:** render, localization, silent-failure
|
|
239
|
+
|
|
231
240
|
### MediaPool.ImportMedia (current-folder destination only)
|
|
232
241
|
|
|
233
242
|
- **Object:** `MediaPool`
|
package/install.py
CHANGED
|
@@ -37,7 +37,7 @@ from src.utils.update_check import (
|
|
|
37
37
|
|
|
38
38
|
# ─── Version ──────────────────────────────────────────────────────────────────
|
|
39
39
|
|
|
40
|
-
VERSION = "2.
|
|
40
|
+
VERSION = "2.211.0"
|
|
41
41
|
# Only hard floor: mcp[cli] requires Python 3.10+. There is no upper bound —
|
|
42
42
|
# Resolve's scripting bridge loads into newer interpreters on recent builds
|
|
43
43
|
# (Python 3.14 verified against Resolve Studio 20.3.2). Older Resolve builds
|
package/package.json
CHANGED
package/src/granular/common.py
CHANGED
|
@@ -87,7 +87,7 @@ if not logging.getLogger().handlers:
|
|
|
87
87
|
handlers=[logging.StreamHandler()],
|
|
88
88
|
)
|
|
89
89
|
|
|
90
|
-
VERSION = "2.
|
|
90
|
+
VERSION = "2.211.0"
|
|
91
91
|
logger = logging.getLogger("davinci-resolve-mcp")
|
|
92
92
|
logger.info(f"Starting DaVinci Resolve MCP Server v{VERSION}")
|
|
93
93
|
logger.info(f"Detected platform: {get_platform()}")
|
package/src/server.py
CHANGED
|
@@ -11,7 +11,7 @@ Usage:
|
|
|
11
11
|
python src/server.py --full # Start the 353-tool granular server instead
|
|
12
12
|
"""
|
|
13
13
|
|
|
14
|
-
VERSION = "2.
|
|
14
|
+
VERSION = "2.211.0"
|
|
15
15
|
|
|
16
16
|
import base64
|
|
17
17
|
import os
|
|
@@ -14823,6 +14823,28 @@ def _playhead_frame_preview(tl, p: Dict[str, Any]):
|
|
|
14823
14823
|
_restore_playhead(tl, original_tc, what="the thumbnail capture")
|
|
14824
14824
|
|
|
14825
14825
|
|
|
14826
|
+
def _render_job_completed(status: Optional[Dict[str, Any]]) -> bool:
|
|
14827
|
+
"""Whether GetRenderJobStatus says the job finished — without reading English.
|
|
14828
|
+
|
|
14829
|
+
JobStatus is a localized display string that follows the application
|
|
14830
|
+
language: "Complete" on an English install, "Concluso" on an Italian one
|
|
14831
|
+
(issue #191). Comparing it to the English literal fails every non-English
|
|
14832
|
+
Resolve with an error that says the opposite of what happened. The
|
|
14833
|
+
locale-independent signals are CompletionPercentage (numeric) and Error
|
|
14834
|
+
(populated on a failed job), so those decide; the English literal is kept
|
|
14835
|
+
only as a fast path for the common case.
|
|
14836
|
+
"""
|
|
14837
|
+
status = status or {}
|
|
14838
|
+
if str(status.get("JobStatus") or "") == "Complete":
|
|
14839
|
+
return True
|
|
14840
|
+
if status.get("Error"):
|
|
14841
|
+
return False
|
|
14842
|
+
try:
|
|
14843
|
+
return float(status.get("CompletionPercentage")) >= 100
|
|
14844
|
+
except (TypeError, ValueError):
|
|
14845
|
+
return False
|
|
14846
|
+
|
|
14847
|
+
|
|
14826
14848
|
def _playhead_frame_render(proj, tl, p: Dict[str, Any]):
|
|
14827
14849
|
"""Render exactly one frame — the only frame-accurate capture route.
|
|
14828
14850
|
|
|
@@ -14944,9 +14966,14 @@ def _playhead_frame_render(proj, tl, p: Dict[str, Any]):
|
|
|
14944
14966
|
time.sleep(0.25)
|
|
14945
14967
|
waited += 0.25
|
|
14946
14968
|
status = _ser(proj.GetRenderJobStatus(job)) or {}
|
|
14947
|
-
|
|
14969
|
+
# Localized JobStatus ("Concluso" on an Italian install, issue #191)
|
|
14970
|
+
# cannot be compared to the English word; the file check below is the
|
|
14971
|
+
# real proof anyway.
|
|
14972
|
+
if not _render_job_completed(status):
|
|
14948
14973
|
return _err(
|
|
14949
|
-
f"Render did not complete: {status.get('JobStatus')}"
|
|
14974
|
+
f"Render did not complete: JobStatus {status.get('JobStatus')!r} "
|
|
14975
|
+
f"at {status.get('CompletionPercentage')}%"
|
|
14976
|
+
+ (f" — {status.get('Error')}" if status.get("Error") else ""),
|
|
14950
14977
|
code="RENDER_FAILED", category="api_error",
|
|
14951
14978
|
state={"status": status, "frame": frame},
|
|
14952
14979
|
)
|
|
@@ -20350,16 +20377,19 @@ def render(action: str, params: Optional[Dict[str, Any]] = None) -> Dict[str, An
|
|
|
20350
20377
|
"issue #164)."
|
|
20351
20378
|
)
|
|
20352
20379
|
else:
|
|
20353
|
-
if status
|
|
20380
|
+
if _render_job_completed(status):
|
|
20354
20381
|
warnings.append(
|
|
20355
|
-
"JobStatus is
|
|
20382
|
+
f"JobStatus is {job_status!r} (complete) but the output "
|
|
20383
|
+
"file does not exist."
|
|
20356
20384
|
)
|
|
20357
|
-
if job_status and
|
|
20385
|
+
if job_status and not _render_job_completed(status):
|
|
20358
20386
|
# Spotted live: a Failed job that wrote a stub file otherwise
|
|
20359
20387
|
# produced verified:true — a duration ratio means nothing when
|
|
20360
|
-
# Resolve itself says the job did not complete.
|
|
20388
|
+
# Resolve itself says the job did not complete. Decided on the
|
|
20389
|
+
# locale-independent fields, not the JobStatus word (issue #191).
|
|
20361
20390
|
warnings.append(
|
|
20362
|
-
f"JobStatus is {job_status!r}
|
|
20391
|
+
f"JobStatus is {job_status!r} at "
|
|
20392
|
+
f"{status.get('CompletionPercentage')}%, not complete"
|
|
20363
20393
|
+ (f": {status.get('Error')}" if status.get("Error") else "")
|
|
20364
20394
|
)
|
|
20365
20395
|
result["warnings"] = warnings
|
package/src/utils/api_truth.py
CHANGED
|
@@ -2182,6 +2182,37 @@ API_TRUTH: List[Dict[str, Any]] = [
|
|
|
2182
2182
|
"tags": ["timeline", "edit", "render", "silent-failure", "media-pool"],
|
|
2183
2183
|
"issue": 164,
|
|
2184
2184
|
},
|
|
2185
|
+
{
|
|
2186
|
+
"symbol": "Project.GetRenderJobStatus JobStatus (localized display string)",
|
|
2187
|
+
"object": "Project",
|
|
2188
|
+
"signature": "(jobId) -> {JobStatus, CompletionPercentage, "
|
|
2189
|
+
"TimeTakenToRenderInMs, Error?}",
|
|
2190
|
+
"reality": "JobStatus is a display string that follows the application "
|
|
2191
|
+
"language, not an enum. An English install reports "
|
|
2192
|
+
"\"Complete\"; an Italian install reports \"Concluso\" for "
|
|
2193
|
+
"the same finished job — read back as {JobStatus: "
|
|
2194
|
+
"\"Concluso\", CompletionPercentage: 100, "
|
|
2195
|
+
"TimeTakenToRenderInMs: 1225} on Studio 21.0.2.4 / macOS 15 "
|
|
2196
|
+
"with the output file complete on disk (issue #191, "
|
|
2197
|
+
"reporter's session). Any code that compares the field to "
|
|
2198
|
+
"the English word fails every non-English Resolve with an "
|
|
2199
|
+
"error that says the opposite of what happened; this "
|
|
2200
|
+
"server's single-frame capture did exactly that until "
|
|
2201
|
+
"v2.210.1. CompletionPercentage is numeric and "
|
|
2202
|
+
"locale-independent, and Error is populated on a failed "
|
|
2203
|
+
"job in every language.",
|
|
2204
|
+
"recommended": "Never gate on the JobStatus string. Treat a job as "
|
|
2205
|
+
"finished when CompletionPercentage reaches 100 and "
|
|
2206
|
+
"Error is empty, then confirm the output file exists — "
|
|
2207
|
+
"the file is the real proof either way (see the "
|
|
2208
|
+
"recordFrame entry above for a Complete job that wrote "
|
|
2209
|
+
"a stub). Report JobStatus verbatim for humans only. "
|
|
2210
|
+
"This server's _render_job_completed() applies the rule "
|
|
2211
|
+
"to frame capture and render.verify_output.",
|
|
2212
|
+
"tags": ["render", "localization", "silent-failure"],
|
|
2213
|
+
"submit": "missing",
|
|
2214
|
+
"issue": 191,
|
|
2215
|
+
},
|
|
2185
2216
|
{
|
|
2186
2217
|
"symbol": "Timeline.DeleteClips (requires the Edit page; flaky first attempt)",
|
|
2187
2218
|
"object": "Timeline",
|
|
@@ -252,6 +252,104 @@ DRY_RUN_DEFAULT_TRUE_ACTIONS: frozenset = frozenset({
|
|
|
252
252
|
})
|
|
253
253
|
|
|
254
254
|
|
|
255
|
+
# ── Native dry-run allowlist ────────────────────────────────────────────────
|
|
256
|
+
#
|
|
257
|
+
# Registered destructive actions whose handler genuinely reads `dry_run` and
|
|
258
|
+
# returns a plan instead of mutating. Every OTHER registered destructive action
|
|
259
|
+
# ignores the flag: `timeline_markers.add` with `dry_run=true` added a real
|
|
260
|
+
# marker, `timeline.delete_track` with `dry_run=true` deleted the track. An
|
|
261
|
+
# agent following the guidance "prefer dry_run where it exists" cannot tell
|
|
262
|
+
# the two apart from the outside, so an explicit `dry_run=true` on a registered
|
|
263
|
+
# destructive action outside this set is REFUSED (DRY_RUN_UNAVAILABLE) before
|
|
264
|
+
# archive, state lookup, or handler execution — nothing simulated, nothing
|
|
265
|
+
# executed, and the response says so.
|
|
266
|
+
#
|
|
267
|
+
# This is deliberately a refusal and not a synthesised preview: the lifecycle
|
|
268
|
+
# pipeline's original dry-run interceptor answered `success: true` for calls
|
|
269
|
+
# it never ran and was removed for it (see
|
|
270
|
+
# execution_lifecycle.LifecyclePipeline._register_default_hooks). A dry run
|
|
271
|
+
# that always succeeds is worse than none, because it is trusted.
|
|
272
|
+
#
|
|
273
|
+
# The set is pinned by tests.test_destructive_hook against a static scan of
|
|
274
|
+
# src/server.py that follows the params object into helpers: add a native
|
|
275
|
+
# dry-run branch to a handler and the test tells you to list it here; list an
|
|
276
|
+
# action here without one and the test refuses.
|
|
277
|
+
|
|
278
|
+
NATIVE_DRY_RUN_ACTIONS: frozenset = frozenset({
|
|
279
|
+
("media_pool", "clear_clip_marks"),
|
|
280
|
+
("media_pool", "set_clip_marks"),
|
|
281
|
+
("media_pool", "setup_multicam_timeline"),
|
|
282
|
+
("timeline", "apply_cuts"),
|
|
283
|
+
("timeline", "ripple_insert"),
|
|
284
|
+
("timeline_ai", "create_subtitles"),
|
|
285
|
+
})
|
|
286
|
+
|
|
287
|
+
|
|
288
|
+
def _explicit_dry_run_requested(params: Optional[Dict[str, Any]]) -> bool:
|
|
289
|
+
if not isinstance(params, dict):
|
|
290
|
+
return False
|
|
291
|
+
if "dry_run" in params:
|
|
292
|
+
return bool(params["dry_run"])
|
|
293
|
+
if "dryRun" in params:
|
|
294
|
+
return bool(params["dryRun"])
|
|
295
|
+
return False
|
|
296
|
+
|
|
297
|
+
|
|
298
|
+
def lacks_native_dry_run(
|
|
299
|
+
tool_name: str, action: str, params: Optional[Dict[str, Any]] = None,
|
|
300
|
+
) -> bool:
|
|
301
|
+
"""True when the caller asked for a dry run this destructive action cannot honour.
|
|
302
|
+
|
|
303
|
+
Keyed on the destructive registry rather than `is_destructive()` so the
|
|
304
|
+
no-archive filters (a Notes edit, say) cannot let a dry-run request slip
|
|
305
|
+
through to a handler that would execute it for real.
|
|
306
|
+
"""
|
|
307
|
+
return (
|
|
308
|
+
_explicit_dry_run_requested(params)
|
|
309
|
+
and action in DESTRUCTIVE_ACTIONS_BY_TOOL.get(tool_name, frozenset())
|
|
310
|
+
and (tool_name, action) not in NATIVE_DRY_RUN_ACTIONS
|
|
311
|
+
)
|
|
312
|
+
|
|
313
|
+
|
|
314
|
+
def _dry_run_unavailable_response(
|
|
315
|
+
*,
|
|
316
|
+
operation_id: str,
|
|
317
|
+
tool_name: str,
|
|
318
|
+
action: str,
|
|
319
|
+
assessment: RiskAssessment,
|
|
320
|
+
) -> Dict[str, Any]:
|
|
321
|
+
return {
|
|
322
|
+
"success": False,
|
|
323
|
+
"status": "dry_run_unavailable",
|
|
324
|
+
"dry_run": True,
|
|
325
|
+
"simulated": False,
|
|
326
|
+
"executed": False,
|
|
327
|
+
"operation_id": operation_id,
|
|
328
|
+
"security": {
|
|
329
|
+
"risk_level": assessment.level.value,
|
|
330
|
+
"risk_established": assessment.recognised,
|
|
331
|
+
"safe_mode": _safe_mode_enabled(),
|
|
332
|
+
"blocked": True,
|
|
333
|
+
"policy": "destructive.dry_run_support",
|
|
334
|
+
},
|
|
335
|
+
"risk": assessment.to_dict(),
|
|
336
|
+
"error": {
|
|
337
|
+
"message": (
|
|
338
|
+
f"'{tool_name}.{action}' has no native dry-run path, so dry_run=true "
|
|
339
|
+
"cannot be honoured. Nothing was simulated and nothing was executed."
|
|
340
|
+
),
|
|
341
|
+
"code": "DRY_RUN_UNAVAILABLE",
|
|
342
|
+
"category": "dry_run_unavailable",
|
|
343
|
+
"retryable": False,
|
|
344
|
+
"remediation": (
|
|
345
|
+
"Use inspect_operation for the static risk assessment, use a "
|
|
346
|
+
"probe_*/safe_* action where one exists, or call again without "
|
|
347
|
+
"dry_run once the operation has been reviewed."
|
|
348
|
+
),
|
|
349
|
+
},
|
|
350
|
+
}
|
|
351
|
+
|
|
352
|
+
|
|
255
353
|
def _payload_is_plan_only(
|
|
256
354
|
tool_name: str, action: str, params: Optional[Dict[str, Any]],
|
|
257
355
|
) -> bool:
|
|
@@ -627,6 +725,29 @@ def destructive_op(tool_name: str) -> Callable[[Callable[..., Any]], Callable[..
|
|
|
627
725
|
def decorator(fn: Callable[..., Any]) -> Callable[..., Any]:
|
|
628
726
|
@functools.wraps(fn)
|
|
629
727
|
def wrapper(action: str, params: Optional[Dict[str, Any]] = None, *args, **kwargs) -> Any:
|
|
728
|
+
if lacks_native_dry_run(tool_name, action, params):
|
|
729
|
+
# An explicit dry-run request this handler would silently
|
|
730
|
+
# execute for real. Refuse before archive, state lookup, or the
|
|
731
|
+
# handler itself; see NATIVE_DRY_RUN_ACTIONS.
|
|
732
|
+
operation_id = f"op_{uuid.uuid4().hex[:12]}"
|
|
733
|
+
assessment = assess_action_risk(tool_name, action, params)
|
|
734
|
+
_audit_security_event(
|
|
735
|
+
operation_id=operation_id,
|
|
736
|
+
tool_name=tool_name,
|
|
737
|
+
action=action,
|
|
738
|
+
risk_level=assessment.level.value,
|
|
739
|
+
status="blocked",
|
|
740
|
+
params=params,
|
|
741
|
+
reason="dry_run_unavailable",
|
|
742
|
+
recognised=assessment.recognised,
|
|
743
|
+
)
|
|
744
|
+
return _dry_run_unavailable_response(
|
|
745
|
+
operation_id=operation_id,
|
|
746
|
+
tool_name=tool_name,
|
|
747
|
+
action=action,
|
|
748
|
+
assessment=assessment,
|
|
749
|
+
)
|
|
750
|
+
|
|
630
751
|
if not is_destructive(tool_name, action, params):
|
|
631
752
|
return fn(action, params, *args, **kwargs)
|
|
632
753
|
|