datavis-glide 4.0.0 → 4.0.2

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "datavis-glide",
-  "version": "4.0.0",
+  "version": "4.0.2",
   "description": "DataVis GLIDE (Graphical Layer for Interactive Data Exploration)",
   "keywords": [
     "data",

package/src/operations_palette.js

@@ -5,7 +5,7 @@ import jQuery from 'jquery';
 
 import { trans } from './trans.js';
 import {
-	icon,
+	makeOperationButton,
 	makeSubclass,
 	mixinLogging,
 } from './util/misc.js';
@@ -93,20 +93,8 @@ OperationsPalette.prototype.drawPalette = function () {
 			var catLabel = jQuery('<span>').text(c).appendTo(catDiv);
 		}
 		_.each(ops, function (op) {
-			var btn = jQuery('<button>', {
-				'type': 'button',
-				'class': 'wcdv_operation',
-				'data-operation-index': op.idx
-			}).appendTo(catDiv);
-			if (op.label == null) {
-				btn.addClass('no_label');
-			}
-			if (op.icon) {
-				btn.append(icon(op.icon));
-			}
-			if (op.label) {
-				btn.append(op.label);
-			}
+			var btn = makeOperationButton('all', op, op.idx);
+			catDiv.append(btn);
 		});
 	});
 };

package/src/renderers/grid/table.js

@@ -900,6 +900,7 @@ GridTable.prototype._addSortingToHeader = function (data, orientation, spec, con
 
 	// Create the sort icon container with an initial neutral "sortable" icon.
 	var sortIcon_btn = document.createElement('button');
+	sortIcon_btn.setAttribute('type', 'button');
 	sortIcon_btn.classList.add('wcdv_icon_button');
 	sortIcon_btn.classList.add(sortIcon_class);
 	sortIcon_btn.classList.add(sortIcon_orientationClass);
@@ -968,7 +969,10 @@ GridTable.prototype._addSortingToHeader = function (data, orientation, spec, con
 		self.view.clearSort();
 	});
 
-	sortIcon_btn.addEventListener('click', function () {
+	// Bind with jQuery (not the native addEventListener) so that the handler survives when the
+	// TableTool floating-header feature clones the table header via jQuery's clone(true).  Native
+	// listeners are not copied by clone(true), which would leave the cloned sort icon inert.
+	jQuery(sortIcon_btn).on('click', function () {
 		sortIcon_menu.open(sortIcon_btn);
 	});
 
@@ -1021,6 +1025,7 @@ GridTable.prototype._addFilterToHeader = function (container, field, displayText
 	}
 
 	jQuery('<button>', {
+		'type': 'button',
 		'data-tooltip': trans('GRID.TABLE.ADD_FILTER_HELP', field)
 	})
 		.addClass('wcdv_icon_button')

package/src/ui/slider.js

@@ -61,6 +61,7 @@ Slider.prototype.draw = function (root) {
 	});
 	self.ui.header = jQuery('<h1>');
 	self.ui.closeBtn = jQuery('<button>', {
+		'type': 'button',
 		'class': 'wcdv-slider-close'
 	}).text('×').on('click', function () {
 		self.hide();

package/src/util/misc.js

@@ -537,6 +537,7 @@ export function setTableCell(cell, value, opts) {
 		}
 
 		var showValueBtn = document.createElement('button');
+		showValueBtn.setAttribute('type', 'button');
 		showValueBtn.setAttribute('title', 'Full value has been truncated; click to show it.');
 		showValueBtn.classList.add('wcdv_icon_button');
 		showValueBtn.classList.add('wcdv_icon_button_incell');
@@ -681,10 +682,16 @@ export function makeOperationButton(type, op, index, opts) {
 	}
 	else {
 		if (op.icon) {
-			btn.appendChild(makeOperationIcon(op));
+			var icon = makeOperationIcon(op);
+			if (op.label) {
+				icon.style.paddingRight = '0.25em';
+			}
+			btn.setAttribute('data-icon', op.icon);
+			btn.appendChild(icon);
 		}
 		if (op.label) {
 			btn.classList.add('wcdv_nowrap');
+			btn.setAttribute('aria-label', op.label);
 			btn.append(op.label);
 		}
 		else {
@@ -693,6 +700,7 @@ export function makeOperationButton(type, op, index, opts) {
 	}
 	if (op.tooltip) {
 		btn.setAttribute('title', op.tooltip);
+		btn.setAttribute('aria-description', op.tooltip);
 	}
 	return btn;
 }