datajunction-ui 0.0.92 → 0.0.94

package/src/app/pages/MyWorkspacePage/__tests__/MyWorkspacePage.test.jsx

@@ -3,6 +3,7 @@ import { render, screen } from '@testing-library/react';
 import { MemoryRouter } from 'react-router-dom';
 import { MyWorkspacePage } from '../index';
 import * as useWorkspaceData from '../../../hooks/useWorkspaceData';
+import * as UserProvider from '../../../providers/UserProvider';
 
 // Mock CSS imports
 jest.mock('../MyWorkspacePage.css', () => ({}));
@@ -33,14 +34,6 @@ jest.mock('../MyNodesSection', () => ({
   ),
 }));
 
-jest.mock('../CollectionsSection', () => ({
-  CollectionsSection: ({ collections, loading }) => (
-    <div data-testid="collections-section">
-      {loading ? 'Loading...' : `${collections.length} collections`}
-    </div>
-  ),
-}));
-
 jest.mock('../MaterializationsSection', () => ({
   MaterializationsSection: ({ nodes, loading }) => (
     <div data-testid="materializations-section">
@@ -76,15 +69,6 @@ describe('<MyWorkspacePage />', () => {
     },
   ];
 
-  const mockCollections = [
-    {
-      name: 'test_collection',
-      description: 'Test Collection',
-      nodeCount: 5,
-      createdBy: 'test.user@example.com',
-    },
-  ];
-
   const mockNotifications = [
     {
       entity_name: 'default.test_metric',
@@ -111,23 +95,48 @@ describe('<MyWorkspacePage />', () => {
     },
   ];
 
-  const mockNeedsAttention = {
-    nodesMissingDescription: [],
-    invalidNodes: [],
-    staleDrafts: [],
-    orphanedDimensions: [],
-  };
+  const makeLoadingStates = (loading = false) => ({
+    myNodes: loading,
+    collections: loading,
+    notifications: loading,
+    materializations: loading,
+    needsAttention: loading,
+    namespace: loading,
+  });
+
+  const makeDashboardData = (overrides = {}) => ({
+    data: {
+      ownedNodes: [],
+      ownedHasMore: {},
+      recentlyEdited: [],
+      editedHasMore: {},
+      watchedNodes: [],
+      notifications: [],
+      materializedNodes: [],
+      needsAttention: {
+        nodesMissingDescription: [],
+        invalidNodes: [],
+        staleDrafts: [],
+        orphanedDimensions: [],
+      },
+      hasPersonalNamespace: true,
+      ...overrides,
+    },
+    loadingStates: makeLoadingStates(false),
+  });
 
   beforeEach(() => {
     jest.clearAllMocks();
   });
 
   it('should render loading state', () => {
-    jest.spyOn(useWorkspaceData, 'useCurrentUser').mockReturnValue({
-      data: null,
+    jest.spyOn(UserProvider, 'useCurrentUser').mockReturnValue({
+      currentUser: null,
       loading: true,
-      error: null,
     });
+    jest
+      .spyOn(useWorkspaceData, 'useWorkspaceDashboardData')
+      .mockReturnValue(makeDashboardData());
 
     render(
       <MemoryRouter>
@@ -136,59 +145,22 @@ describe('<MyWorkspacePage />', () => {
     );
 
     expect(screen.getByText('Dashboard')).toBeInTheDocument();
-    // Should show loading icon when user is loading
-    expect(screen.queryByTestId('collections-section')).not.toBeInTheDocument();
+    // Sections are not shown while user is loading
+    expect(screen.queryByTestId('my-nodes-section')).not.toBeInTheDocument();
   });
 
   it('should render all sections when data is loaded', () => {
-    // Mock all hooks with data
-    jest.spyOn(useWorkspaceData, 'useCurrentUser').mockReturnValue({
-      data: mockCurrentUser,
+    jest.spyOn(UserProvider, 'useCurrentUser').mockReturnValue({
+      currentUser: mockCurrentUser,
       loading: false,
-      error: null,
-    });
-    jest.spyOn(useWorkspaceData, 'useWorkspaceOwnedNodes').mockReturnValue({
-      data: mockOwnedNodes,
-      loading: false,
-      error: null,
-    });
-    jest.spyOn(useWorkspaceData, 'useWorkspaceRecentlyEdited').mockReturnValue({
-      data: [],
-      loading: false,
-      error: null,
-    });
-    jest.spyOn(useWorkspaceData, 'useWorkspaceWatchedNodes').mockReturnValue({
-      data: [],
-      loading: false,
-      error: null,
-    });
-    jest.spyOn(useWorkspaceData, 'useWorkspaceCollections').mockReturnValue({
-      data: mockCollections,
-      loading: false,
-      error: null,
-    });
-    jest.spyOn(useWorkspaceData, 'useWorkspaceNotifications').mockReturnValue({
-      data: mockNotifications,
-      loading: false,
-      error: null,
-    });
-    jest
-      .spyOn(useWorkspaceData, 'useWorkspaceMaterializations')
-      .mockReturnValue({
-        data: mockMaterializations,
-        loading: false,
-        error: null,
-      });
-    jest.spyOn(useWorkspaceData, 'useWorkspaceNeedsAttention').mockReturnValue({
-      data: mockNeedsAttention,
-      loading: false,
-      error: null,
-    });
-    jest.spyOn(useWorkspaceData, 'usePersonalNamespace').mockReturnValue({
-      exists: true,
-      loading: false,
-      error: null,
     });
+    jest.spyOn(useWorkspaceData, 'useWorkspaceDashboardData').mockReturnValue(
+      makeDashboardData({
+        ownedNodes: mockOwnedNodes,
+        notifications: mockNotifications,
+        materializedNodes: mockMaterializations,
+      }),
+    );
 
     render(
       <MemoryRouter>
@@ -196,10 +168,6 @@ describe('<MyWorkspacePage />', () => {
       </MemoryRouter>,
     );
 
-    // Check all sections are rendered
-    expect(screen.getByTestId('collections-section')).toHaveTextContent(
-      '1 collections',
-    );
     expect(screen.getByTestId('my-nodes-section')).toHaveTextContent(
       '2 owned nodes',
     );
@@ -214,53 +182,121 @@ describe('<MyWorkspacePage />', () => {
   });
 
   it('should pass correct props to sections', () => {
-    jest.spyOn(useWorkspaceData, 'useCurrentUser').mockReturnValue({
-      data: mockCurrentUser,
-      loading: false,
-      error: null,
-    });
-    jest.spyOn(useWorkspaceData, 'useWorkspaceOwnedNodes').mockReturnValue({
-      data: mockOwnedNodes,
-      loading: false,
-      error: null,
-    });
-    jest.spyOn(useWorkspaceData, 'useWorkspaceRecentlyEdited').mockReturnValue({
-      data: [],
-      loading: false,
-      error: null,
-    });
-    jest.spyOn(useWorkspaceData, 'useWorkspaceWatchedNodes').mockReturnValue({
-      data: [],
+    jest.spyOn(UserProvider, 'useCurrentUser').mockReturnValue({
+      currentUser: mockCurrentUser,
       loading: false,
-      error: null,
     });
-    jest.spyOn(useWorkspaceData, 'useWorkspaceCollections').mockReturnValue({
-      data: mockCollections,
+    jest
+      .spyOn(useWorkspaceData, 'useWorkspaceDashboardData')
+      .mockReturnValue(makeDashboardData({ ownedNodes: mockOwnedNodes }));
+
+    render(
+      <MemoryRouter>
+        <MyWorkspacePage />
+      </MemoryRouter>,
+    );
+
+    expect(screen.getByTestId('my-nodes-section')).toBeInTheDocument();
+    expect(screen.getByTestId('notifications-section')).toBeInTheDocument();
+    expect(screen.getByTestId('needs-attention-section')).toBeInTheDocument();
+  });
+
+  it('should filter out non-stale materializations from NeedsAttention', () => {
+    const now = Date.now();
+    const freshNode = {
+      name: 'default.fresh_cube',
+      type: 'CUBE',
+      current: {
+        availability: {
+          validThroughTs: now - 1000 * 60 * 60 * 10, // 10 hours ago (< 72h, not stale)
+        },
+      },
+    };
+
+    jest.spyOn(UserProvider, 'useCurrentUser').mockReturnValue({
+      currentUser: mockCurrentUser,
       loading: false,
-      error: null,
     });
-    jest.spyOn(useWorkspaceData, 'useWorkspaceNotifications').mockReturnValue({
-      data: mockNotifications,
+    jest
+      .spyOn(useWorkspaceData, 'useWorkspaceDashboardData')
+      .mockReturnValue(makeDashboardData({ materializedNodes: [freshNode] }));
+
+    render(
+      <MemoryRouter>
+        <MyWorkspacePage />
+      </MemoryRouter>,
+    );
+
+    // Page renders without crash — stale filter ran without errors
+    expect(screen.getByTestId('materializations-section')).toHaveTextContent(
+      '1 materializations',
+    );
+    expect(screen.getByTestId('needs-attention-section')).toBeInTheDocument();
+  });
+
+  it('should exclude nodes with null validThroughTs from stale list', () => {
+    const pendingNode = {
+      name: 'default.pending_cube',
+      type: 'CUBE',
+      current: {
+        availability: {
+          validThroughTs: null,
+        },
+      },
+    };
+
+    jest.spyOn(UserProvider, 'useCurrentUser').mockReturnValue({
+      currentUser: mockCurrentUser,
       loading: false,
-      error: null,
     });
     jest
-      .spyOn(useWorkspaceData, 'useWorkspaceMaterializations')
-      .mockReturnValue({
-        data: mockMaterializations,
-        loading: false,
-        error: null,
-      });
-    jest.spyOn(useWorkspaceData, 'useWorkspaceNeedsAttention').mockReturnValue({
-      data: mockNeedsAttention,
+      .spyOn(useWorkspaceData, 'useWorkspaceDashboardData')
+      .mockReturnValue(makeDashboardData({ materializedNodes: [pendingNode] }));
+
+    render(
+      <MemoryRouter>
+        <MyWorkspacePage />
+      </MemoryRouter>,
+    );
+
+    // Pending node (null validThroughTs) should not be passed as stale
+    expect(screen.getByTestId('needs-attention-section')).toBeInTheDocument();
+  });
+
+  it('should exclude nodes with no availability from stale list', () => {
+    const noAvailabilityNode = {
+      name: 'default.no_avail_cube',
+      type: 'CUBE',
+      current: {},
+    };
+
+    jest.spyOn(UserProvider, 'useCurrentUser').mockReturnValue({
+      currentUser: mockCurrentUser,
       loading: false,
-      error: null,
     });
-    jest.spyOn(useWorkspaceData, 'usePersonalNamespace').mockReturnValue({
-      exists: true,
+    jest
+      .spyOn(useWorkspaceData, 'useWorkspaceDashboardData')
+      .mockReturnValue(
+        makeDashboardData({ materializedNodes: [noAvailabilityNode] }),
+      );
+
+    render(
+      <MemoryRouter>
+        <MyWorkspacePage />
+      </MemoryRouter>,
+    );
+
+    expect(screen.getByTestId('needs-attention-section')).toBeInTheDocument();
+  });
+
+  it('should derive personal namespace from username', () => {
+    jest.spyOn(UserProvider, 'useCurrentUser').mockReturnValue({
+      currentUser: { username: 'jane.doe@company.com' },
       loading: false,
-      error: null,
     });
+    jest
+      .spyOn(useWorkspaceData, 'useWorkspaceDashboardData')
+      .mockReturnValue(makeDashboardData());
 
     render(
       <MemoryRouter>
@@ -268,10 +304,8 @@ describe('<MyWorkspacePage />', () => {
       </MemoryRouter>,
     );
 
-    // Verify sections receive correct data
-    expect(screen.getByTestId('collections-section')).toBeInTheDocument();
-    expect(screen.getByTestId('my-nodes-section')).toBeInTheDocument();
-    expect(screen.getByTestId('notifications-section')).toBeInTheDocument();
+    // NeedsAttentionSection mock receives personalNamespace="users.jane.doe"
+    expect(screen.getByTestId('needs-attention-section')).toBeInTheDocument();
   });
 
   it('should calculate stale materializations correctly', () => {
@@ -287,53 +321,13 @@ describe('<MyWorkspacePage />', () => {
       },
     };
 
-    jest.spyOn(useWorkspaceData, 'useCurrentUser').mockReturnValue({
-      data: mockCurrentUser,
-      loading: false,
-      error: null,
-    });
-    jest.spyOn(useWorkspaceData, 'useWorkspaceOwnedNodes').mockReturnValue({
-      data: [],
-      loading: false,
-      error: null,
-    });
-    jest.spyOn(useWorkspaceData, 'useWorkspaceRecentlyEdited').mockReturnValue({
-      data: [],
-      loading: false,
-      error: null,
-    });
-    jest.spyOn(useWorkspaceData, 'useWorkspaceWatchedNodes').mockReturnValue({
-      data: [],
+    jest.spyOn(UserProvider, 'useCurrentUser').mockReturnValue({
+      currentUser: mockCurrentUser,
       loading: false,
-      error: null,
-    });
-    jest.spyOn(useWorkspaceData, 'useWorkspaceCollections').mockReturnValue({
-      data: [],
-      loading: false,
-      error: null,
-    });
-    jest.spyOn(useWorkspaceData, 'useWorkspaceNotifications').mockReturnValue({
-      data: [],
-      loading: false,
-      error: null,
     });
     jest
-      .spyOn(useWorkspaceData, 'useWorkspaceMaterializations')
-      .mockReturnValue({
-        data: [staleNode],
-        loading: false,
-        error: null,
-      });
-    jest.spyOn(useWorkspaceData, 'useWorkspaceNeedsAttention').mockReturnValue({
-      data: mockNeedsAttention,
-      loading: false,
-      error: null,
-    });
-    jest.spyOn(useWorkspaceData, 'usePersonalNamespace').mockReturnValue({
-      exists: true,
-      loading: false,
-      error: null,
-    });
+      .spyOn(useWorkspaceData, 'useWorkspaceDashboardData')
+      .mockReturnValue(makeDashboardData({ materializedNodes: [staleNode] }));
 
     render(
       <MemoryRouter>

package/src/app/pages/MyWorkspacePage/__tests__/NeedsAttentionSection.test.jsx

@@ -44,15 +44,15 @@ describe('<NeedsAttentionSection />', () => {
     expect(screen.getByText(/Orphaned Dimensions/)).toBeInTheDocument();
   });
 
-  it('should show "All good!" when category has no items', () => {
+  it('should show "All good" when category has no items', () => {
     render(
       <MemoryRouter>
         <NeedsAttentionSection {...defaultProps} />
       </MemoryRouter>,
     );
 
-    const allGood = screen.getAllByText('✓ All good!');
-    expect(allGood.length).toBe(5); // All 5 categories should show "All good!"
+    const allGood = screen.getAllByText('All good');
+    expect(allGood.length).toBe(5); // All 5 categories should show "All good"
   });
 
   it('should display invalid nodes', () => {
@@ -74,7 +74,7 @@ describe('<NeedsAttentionSection />', () => {
       </MemoryRouter>,
     );
 
-    expect(screen.getByText('❌ Invalid')).toBeInTheDocument();
+    expect(screen.getByText('Invalid')).toBeInTheDocument();
     expect(screen.getByText('(1)')).toBeInTheDocument();
   });
 
@@ -97,7 +97,7 @@ describe('<NeedsAttentionSection />', () => {
       </MemoryRouter>,
     );
 
-    expect(screen.getByText('⏰ Stale Drafts')).toBeInTheDocument();
+    expect(screen.getByText('Stale Drafts')).toBeInTheDocument();
     expect(screen.getByText('(1)')).toBeInTheDocument();
   });
 
@@ -120,7 +120,7 @@ describe('<NeedsAttentionSection />', () => {
       </MemoryRouter>,
     );
 
-    expect(screen.getByText('📝 No Description')).toBeInTheDocument();
+    expect(screen.getByText('No Description')).toBeInTheDocument();
     expect(screen.getByText('(1)')).toBeInTheDocument();
   });
 
@@ -143,7 +143,7 @@ describe('<NeedsAttentionSection />', () => {
       </MemoryRouter>,
     );
 
-    const viewAllLinks = screen.getAllByText('View all →');
+    const viewAllLinks = screen.getAllByText('→');
     expect(viewAllLinks.length).toBeGreaterThan(0);
   });
 
@@ -154,7 +154,7 @@ describe('<NeedsAttentionSection />', () => {
       </MemoryRouter>,
     );
 
-    expect(screen.queryByText('View all →')).not.toBeInTheDocument();
+    expect(screen.queryByText('→')).not.toBeInTheDocument();
   });
 
   it('should limit nodes to 10 per category', () => {
@@ -176,7 +176,7 @@ describe('<NeedsAttentionSection />', () => {
 
     // Should only display 10 nodes (via NodeChip component)
     // The 11th node should not be displayed
-    expect(screen.getByText('❌ Invalid')).toBeInTheDocument();
+    expect(screen.getByText('Invalid')).toBeInTheDocument();
     expect(screen.getByText('(15)')).toBeInTheDocument();
   });
 
@@ -187,9 +187,8 @@ describe('<NeedsAttentionSection />', () => {
       </MemoryRouter>,
     );
 
-    expect(screen.getByText('Set up your namespace')).toBeInTheDocument();
-    expect(screen.getByText('users.test.user')).toBeInTheDocument();
-    expect(screen.getByText('Create →')).toBeInTheDocument();
+    expect(screen.getByText('Personal namespace')).toBeInTheDocument();
+    expect(screen.getByText('Create users.test.user →')).toBeInTheDocument();
   });
 
   it('should not show personal namespace prompt when namespace exists', () => {
@@ -199,7 +198,7 @@ describe('<NeedsAttentionSection />', () => {
       </MemoryRouter>,
     );
 
-    expect(screen.queryByText('Set up your namespace')).not.toBeInTheDocument();
+    expect(screen.queryByText('Personal namespace')).not.toBeInTheDocument();
   });
 
   it('should not show personal namespace prompt when loading', () => {
@@ -213,7 +212,7 @@ describe('<NeedsAttentionSection />', () => {
       </MemoryRouter>,
     );
 
-    expect(screen.queryByText('Set up your namespace')).not.toBeInTheDocument();
+    expect(screen.queryByText('Personal namespace')).not.toBeInTheDocument();
   });
 
   it('should link to correct filter URLs', () => {
@@ -235,7 +234,7 @@ describe('<NeedsAttentionSection />', () => {
       </MemoryRouter>,
     );
 
-    const viewAllLink = screen.getByText('View all →').closest('a');
+    const viewAllLink = screen.getByText('→').closest('a');
     expect(viewAllLink).toHaveAttribute(
       'href',
       '/?ownedBy=test.user@example.com&statuses=INVALID',
@@ -262,11 +261,11 @@ describe('<NeedsAttentionSection />', () => {
       </MemoryRouter>,
     );
 
-    expect(screen.getByText('❌ Invalid')).toBeInTheDocument();
+    expect(screen.getByText('Invalid')).toBeInTheDocument();
     expect(screen.getByText('(1)')).toBeInTheDocument();
-    expect(screen.getByText('⏰ Stale Drafts')).toBeInTheDocument();
+    expect(screen.getByText('Stale Drafts')).toBeInTheDocument();
     expect(screen.getByText('(2)')).toBeInTheDocument();
-    expect(screen.getByText('📝 No Description')).toBeInTheDocument();
+    expect(screen.getByText('No Description')).toBeInTheDocument();
     expect(screen.getByText('(3)')).toBeInTheDocument();
   });
 });