datajunction-ui 0.0.78 → 0.0.79

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "datajunction-ui",
-  "version": "0.0.78",
+  "version": "0.0.79",
   "description": "DataJunction UI",
   "module": "src/index.tsx",
   "repository": {

package/src/app/pages/AddEditNodePage/__tests__/AddEditNodePageFormSuccess.test.jsx

@@ -201,7 +201,7 @@ describe('AddEditNodePage submission succeeded', () => {
         '',
         '',
         '',
-        '',
+        undefined,
         ['dj'],
         null,
       );

package/src/app/pages/AddEditNodePage/index.jsx

@@ -147,7 +147,10 @@ export function AddEditNodePage({ extensions = {} }) {
       values.primary_key ? primaryKeyToList(values.primary_key) : null,
       values.metric_direction,
       values.metric_unit,
-      values.required_dimensions,
+      // Only send required_dimensions if it's set (for metrics)
+      values.required_dimensions && Array.isArray(values.required_dimensions)
+        ? values.required_dimensions
+        : undefined,
       parseCustomMetadata(values.custom_metadata),
     );
     if (status === 200 || status === 201) {
@@ -182,7 +185,10 @@ export function AddEditNodePage({ extensions = {} }) {
       values.metric_direction,
       values.metric_unit,
       values.significant_digits,
-      values.required_dimensions,
+      // Only send required_dimensions if it's set (for metrics)
+      values.required_dimensions && Array.isArray(values.required_dimensions)
+        ? values.required_dimensions
+        : undefined,
       values.owners,
       parseCustomMetadata(values.custom_metadata),
     );

package/src/app/services/DJService.js

@@ -673,23 +673,30 @@ export const DataJunctionAPI = {
             unit: metric_unit,
           }
         : null;
+    // Build request body, filtering out undefined values
+    const requestBody = {
+      name: name,
+      display_name: display_name,
+      description: description,
+      query: query,
+      mode: mode,
+      namespace: namespace,
+      primary_key: primary_key,
+      metric_metadata: metricMetadata,
+      required_dimensions: required_dimensions,
+      custom_metadata: custom_metadata,
+    };
+    // Remove undefined fields to avoid sending them to the API
+    Object.keys(requestBody).forEach(
+      key => requestBody[key] === undefined && delete requestBody[key],
+    );
+
     const response = await fetch(`${DJ_URL}/nodes/${nodeType}`, {
       method: 'POST',
       headers: {
         'Content-Type': 'application/json',
       },
-      body: JSON.stringify({
-        name: name,
-        display_name: display_name,
-        description: description,
-        query: query,
-        mode: mode,
-        namespace: namespace,
-        primary_key: primary_key,
-        metric_metadata: metricMetadata,
-        required_dimensions: required_dimensions,
-        custom_metadata: custom_metadata,
-      }),
+      body: JSON.stringify(requestBody),
       credentials: 'include',
     });
     return { status: response.status, json: await response.json() };
@@ -718,22 +725,29 @@ export const DataJunctionAPI = {
               significant_digits: significant_digits || null,
             }
           : null;
+      // Build request body, filtering out undefined values
+      const requestBody = {
+        display_name: display_name,
+        description: description,
+        query: query,
+        mode: mode,
+        primary_key: primary_key,
+        metric_metadata: metricMetadata,
+        required_dimensions: required_dimensions,
+        owners: owners,
+        custom_metadata: custom_metadata,
+      };
+      // Remove undefined fields to avoid sending them to the API
+      Object.keys(requestBody).forEach(
+        key => requestBody[key] === undefined && delete requestBody[key],
+      );
+
       const response = await fetch(`${DJ_URL}/nodes/${name}`, {
         method: 'PATCH',
         headers: {
           'Content-Type': 'application/json',
         },
-        body: JSON.stringify({
-          display_name: display_name,
-          description: description,
-          query: query,
-          mode: mode,
-          primary_key: primary_key,
-          metric_metadata: metricMetadata,
-          required_dimensions: required_dimensions,
-          owners: owners,
-          custom_metadata: custom_metadata,
-        }),
+        body: JSON.stringify(requestBody),
         credentials: 'include',
       });
       return { status: response.status, json: await response.json() };