datajunction-ui 0.0.1-a93 → 0.0.1-a94

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "datajunction-ui",
-  "version": "0.0.1a93",
+  "version": "0.0.1a94",
   "description": "DataJunction Metrics Platform UI",
   "module": "src/index.tsx",
   "repository": {

package/src/app/pages/AddEditNodePage/MetricMetadataFields.jsx

@@ -24,11 +24,17 @@ export const MetricMetadataFields = () => {
   }, [djClient]);
 
   return (
-    <>
-      <div
-        className="MetricDirectionInput NodeCreationInput"
-        style={{ width: '25%' }}
-      >
+    <div
+      style={{
+        borderRadius: '8px',
+        padding: '10px 10px 20px 10px',
+        margin: '32px 0',
+        background: '#f9f9f9',
+        width: 'max-content',
+        display: 'flex',
+      }}
+    >
+      <div style={{ margin: '15px 25px' }}>
         <ErrorMessage name="metric_direction" component="span" />
         <label htmlFor="MetricDirection">Metric Direction</label>
         <Field as="select" name="metric_direction" id="MetricDirection">
@@ -40,10 +46,7 @@ export const MetricMetadataFields = () => {
           ))}
         </Field>
       </div>
-      <div
-        className="MetricUnitInput NodeCreationInput"
-        style={{ width: '25%' }}
-      >
+      <div style={{ margin: '15px 25px' }}>
         <ErrorMessage name="metric_unit" component="span" />
         <label htmlFor="MetricUnit">Metric Unit</label>
         <Field as="select" name="metric_unit" id="MetricUnit">
@@ -55,6 +58,18 @@ export const MetricMetadataFields = () => {
           ))}
         </Field>
       </div>
-    </>
+      <div style={{ margin: '15px 25px' }}>
+        <ErrorMessage name="significant_digits" component="span" />
+        <label htmlFor="SignificantDigits">Significant Digits</label>
+        <Field as="select" name="significant_digits" id="SignificantDigits">
+          <option value=""></option>
+          {[1, 2, 3, 4, 5, 6, 7, 8, 9, 10].map(val => (
+            <option value={val} key={val}>
+              {val}
+            </option>
+          ))}
+        </Field>
+      </div>
+    </div>
   );
 };

package/src/app/pages/AddEditNodePage/__tests__/AddEditNodePageFormSuccess.test.jsx

@@ -192,6 +192,7 @@ describe('AddEditNodePage submission succeeded', () => {
         undefined,
         undefined,
         undefined,
+        undefined,
       );
       expect(mockDjClient.DataJunctionAPI.tagsNode).toBeCalledTimes(1);
       expect(mockDjClient.DataJunctionAPI.tagsNode).toBeCalledWith(
@@ -251,6 +252,7 @@ describe('AddEditNodePage submission succeeded', () => {
         [],
         'neutral',
         'unitless',
+        4,
         undefined,
       );
       expect(mockDjClient.DataJunctionAPI.tagsNode).toBeCalledTimes(1);

package/src/app/pages/AddEditNodePage/index.jsx

@@ -152,6 +152,7 @@ export function AddEditNodePage({ extensions = {} }) {
       values.primary_key ? primaryKeyToList(values.primary_key) : null,
       values.metric_direction,
       values.metric_unit,
+      values.significant_digits,
       values.required_dimensions,
     );
     const tagsResponse = await djClient.tagsNode(
@@ -270,6 +271,12 @@ export function AddEditNodePage({ extensions = {} }) {
         data.metric_metadata.unit.name.toLowerCase(),
       );
     }
+    if (data.metric_metadata?.significant_digits) {
+      setFieldValue(
+        'significant_digits',
+        data.metric_metadata.significant_digits,
+      );
+    }
     if (data.expression) {
       setFieldValue('aggregate_expression', data.expression);
     }

package/src/app/pages/NodePage/NodeInfoTab.jsx

@@ -181,6 +181,18 @@ export default function NodeInfoTab({ node }) {
                 : 'None'}
             </p>
           </div>
+          {console.log('node?.metric_metadata', node?.metric_metadata)}
+          <div style={{ marginRight: '2rem' }}>
+            <h6 className="mb-0 w-100">Significant Digits</h6>
+            <p
+              className="mb-0 opacity-75"
+              role="dialog"
+              aria-hidden="false"
+              aria-label="SignificantDigits"
+            >
+              {node?.metric_metadata?.significantDigits || 'None'}
+            </p>
+          </div>
         </div>
       </div>
     ) : (

package/src/app/services/DJService.js

@@ -139,6 +139,7 @@ export const DataJunctionAPI = {
               direction
               unit { name }
               expression
+              significantDigits
               incompatibleDruidFunctions
             }
             requiredDimensions {
@@ -267,6 +268,7 @@ export const DataJunctionAPI = {
     primary_key,
     metric_direction,
     metric_unit,
+    significant_digits,
     required_dimensions,
   ) {
     try {
@@ -275,6 +277,7 @@ export const DataJunctionAPI = {
           ? {
               direction: metric_direction,
               unit: metric_unit,
+              significant_digits: significant_digits || null,
             }
           : null;
       const response = await fetch(`${DJ_URL}/nodes/${name}`, {

package/src/app/services/__tests__/DJService.test.jsx

@@ -203,6 +203,7 @@ describe('DataJunctionAPI', () => {
         metric_metadata: {
           direction: 'neutral',
           unit: '',
+          significant_digits: null,
         },
       }),
       credentials: 'include',

package/src/mocks/mockNodes.jsx

@@ -278,6 +278,9 @@ export const mocks = {
         label: 'Unitless',
       },
       direction: 'neutral',
+      max_decimal_exponent: null,
+      min_decimal_exponent: null,
+      significant_digits: 4,
     },
     upstream_node: 'default.repair_orders',
     expression: 'count(repair_order_id)',