dashcam 1.4.13-beta.1 → 1.4.13-beta.3

package/bin/dashcam.js

@@ -6,6 +6,7 @@ import { logger, setVerbose } from '../lib/logger.js';
 import { APP } from '../lib/config.js';
 import { createPattern } from '../lib/tracking.js';
 import { processManager } from '../lib/processManager.js';
+import { cleanupSystemInfo } from '../lib/systemInfo.js';
 import { fileURLToPath } from 'url';
 import { dirname } from 'path';
 import path from 'path';
@@ -39,6 +40,9 @@ async function gracefulShutdown(signal) {
   logger.info('Received shutdown signal, cleaning up...', { signal });
   
   try {
+    // Clean up systeminformation child processes first to prevent stack overflow
+    cleanupSystemInfo();
+    
     // Check if there's an active recording and stop it
     if (processManager.isRecordingActive()) {
       logger.info('Stopping active recording before exit...');
@@ -456,8 +460,6 @@ program
   .description('Stop the current recording and wait for upload completion')
   .action(async () => {
 
-    console.log('!!!! Updated Stop')
-
     try {
       // Enable verbose logging for stop command
       setVerbose(true);

package/lib/recorder.js

@@ -469,10 +469,10 @@ export async function startRecording({
     });
 
     if (currentRecording.all) {
-      currentRecording.all.setEncoding('utf8');
       currentRecording.all.on('data', (data) => {
         // Parse FFmpeg output for useful information
-        const output = data.toString().trim();
+        // Handle potentially invalid UTF-8 sequences by replacing them
+        const output = data.toString('utf8').replace(/\uFFFD/g, '').trim();
         logger.info(`FFmpeg output: ${output}`);
         
         // Check for actual permission issues (not fallback messages)

package/lib/systemInfo.js

@@ -1,6 +1,23 @@
 import si from 'systeminformation';
 import { logger } from './logger.js';
 
+/**
+ * Cleanup systeminformation child processes to prevent stack overflow on exit
+ */
+export function cleanupSystemInfo() {
+  try {
+    logger.debug('Cleaning up systeminformation processes...');
+    // The systeminformation library keeps child processes running
+    // We need to clean them up to prevent stack overflow on Windows
+    if (si && typeof si.powerShellRelease === 'function') {
+      si.powerShellRelease();
+    }
+    logger.debug('Systeminformation cleanup complete');
+  } catch (error) {
+    logger.debug('Error cleaning up systeminformation', { error: error.message });
+  }
+}
+
 /**
  * Collects comprehensive system information including CPU, memory, OS, and graphics data.
  * This matches the data format expected by the Dashcam backend (same as desktop app).
@@ -30,6 +47,10 @@ export async function getSystemInfo() {
     } catch (error) {
       logger.debug('Graphics info timed out, using empty graphics data');
     }
+    
+    // Immediately cleanup PowerShell processes after collection to prevent race conditions
+    // This prevents the stack overflow issue if an error occurs later during upload
+    cleanupSystemInfo();
 
     const systemInfo = {
       cpu: {

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "dashcam",
-  "version": "1.4.13-beta.1",
+  "version": "1.4.13-beta.3",
   "description": "Minimal CLI version of Dashcam desktop app",
   "main": "bin/dashcam.js",
   "bin": {

package/LINUX_PERF_FIX.md

@@ -1,184 +0,0 @@
-# Linux Performance Tracking Fixes
-
-## Problem
-Performance data from dashcam-cli-minimal was not working on Ubuntu Linux.
-
-## Root Causes Identified
-
-### 1. **ps command compatibility**
-- Some Linux distributions (especially minimal/container images) use BusyBox `ps` which doesn't support the `--sort` option
-- The code was failing when trying to use `ps --sort=-pcpu`
-
-### 2. **Missing error handling**
-- Insufficient logging made it hard to diagnose where the performance tracking was failing
-- No fallback mechanisms when certain system calls failed
-
-### 3. **Network metrics parsing**
-- The macOS netstat parsing had an off-by-one error in the parts length check
-- Could cause network metrics to fail silently
-
-### 4. **Import optimization**
-- The Linux network code was using `await import('fs')` dynamically when `fs` was already imported at the top
-
-## Fixes Applied
-
-### topProcesses.js
-1. **Added fallback for ps --sort**:
-   ```javascript
-   try {
-     // Try with --sort first
-     const result = await execFileAsync('ps', ['-eo', 'pid,pcpu,pmem,comm', '--sort=-pcpu'], ...);
-   } catch (sortError) {
-     // Fallback to unsorted and sort in JavaScript
-     const result = await execFileAsync('ps', ['-eo', 'pid,pcpu,pmem,comm'], ...);
-   }
-   ```
-
-2. **Improved parsing with filtering**:
-   - Now filters out invalid entries (pid <= 0)
-   - Handles missing/undefined CPU and memory values
-   - Always sorts by CPU in JavaScript as a backup
-
-3. **Added timeouts**:
-   - All process listings now have 5-10 second timeouts to prevent hanging
-
-### performanceTracker.js
-1. **Fixed network metrics**:
-   - Corrected macOS netstat parsing (parts.length >= 10 instead of >= 7)
-   - Removed redundant `await import('fs')` on Linux
-   - Already using `fs` from the top-level import
-
-2. **Enhanced error handling**:
-   - All metric collection methods now have comprehensive try/catch blocks
-   - Graceful degradation - if one metric fails, others continue
-   - Better logging with platform and error context
-
-3. **Improved logging**:
-   - Added debug logs for successful operations
-   - More detailed error messages including platform info
-   - Stack traces for debugging
-
-## Testing
-
-### Quick Test (10 seconds)
-```bash
-cd dashcam-cli-minimal
-node test-perf-linux.js
-```
-
-This will:
-- Test `pidusage` library
-- Test `getTopProcesses` function
-- Test network metrics reading
-- Test system metrics
-- Run full performance tracker for 10 seconds
-- Show detailed results and identify any failures
-
-### Full Recording Test
-```bash
-# Start a recording with performance tracking
-dashcam start
-
-# Do some work for 10-15 seconds
-# ...
-
-# Stop recording  
-dashcam stop
-
-# Check the output for performance data
-```
-
-### Expected Output
-The test should show:
-```
-✓ pidusage: PASS
-✓ topProcesses: PASS  
-✓ networkMetrics: PASS
-✓ systemMetrics: PASS
-✓ performanceTracker: PASS
-
-Overall: ✓ ALL TESTS PASSED
-```
-
-## Platform-Specific Notes
-
-### Ubuntu/Debian
-- Should work on all versions
-- Uses `/proc/net/dev` for network stats
-- Falls back if `ps --sort` not available
-
-### Alpine Linux / Docker
-- BusyBox `ps` detected automatically
-- Sorts processes in JavaScript instead
-- May have limited network stats in containers
-
-### CentOS/RHEL
-- Full GNU ps support
-- Should use `--sort` option
-- Full network stats available
-
-## Troubleshooting
-
-### If performance data is still empty:
-
-1. **Check pidusage works**:
-   ```bash
-   node -e "import('pidusage').then(m => m.default(process.pid).then(console.log))"
-   ```
-
-2. **Check ps command**:
-   ```bash
-   ps -eo pid,pcpu,pmem,comm --sort=-pcpu | head -5
-   # If this fails, try:
-   ps -eo pid,pcpu,pmem,comm | head -5
-   ```
-
-3. **Check /proc/net/dev exists**:
-   ```bash
-   cat /proc/net/dev
-   ```
-
-4. **Run with verbose logging**:
-   ```bash
-   dashcam start --verbose
-   # ... do work ...
-   dashcam stop --verbose
-   ```
-
-5. **Check the performance file directly**:
-   ```bash
-   # Look for performance.jsonl in the output directory
-   cat ~/.dashcam/recordings/*/performance.jsonl | head -1 | jq
-   ```
-
-## What Gets Tracked
-
-Even with the fixes, the following is tracked every 5 seconds:
-
-- ✅ Process CPU usage (dashcam process)
-- ✅ Process memory usage (dashcam process)
-- ✅ System-wide memory usage
-- ✅ System CPU core count
-- ✅ Top 10 processes by CPU
-- ✅ Network I/O (where available)
-
-## API Upload
-
-The performance data is uploaded to the API with the recording:
-
-```javascript
-{
-  performance: {
-    samples: [...], // Array of samples taken during recording
-    summary: {      // Aggregated statistics
-      avgProcessCPU: 12.3,
-      maxProcessCPU: 18.7,
-      avgProcessMemoryMB: 128.0,
-      maxProcessMemoryMB: 192.0,
-      // ...
-    }
-  }
-}
-```
-
-This data is then displayed in the web UI under the "Performance" tab.

package/LOG_TRACKING_GUIDE.md

@@ -1,225 +0,0 @@
-# Dashcam CLI - Log Tracking Guide
-
-The Dashcam CLI can track both **file-based logs** (from CLI applications) and **web browser logs** (from browser extensions). This guide explains how to use the log tracking features.
-
-## File Log Tracking (CLI Applications)
-
-### Adding Log Files to Track
-
-Track log files during recordings:
-
-```bash
-# Add a single log file
-dashcam logs --add /var/log/myapp.log
-
-# Add multiple log files
-dashcam logs --add /tmp/debug.log
-dashcam logs --add ~/.npm/_logs/npm.log
-dashcam logs --add /var/log/nginx/access.log
-```
-
-### Removing Log Files
-
-```bash
-# Remove a log file from tracking
-dashcam logs --remove /var/log/myapp.log
-```
-
-### Viewing Tracked Files
-
-```bash
-# List all currently tracked log files
-dashcam logs --list
-
-# Show detailed tracking status
-dashcam logs --status
-```
-
-## Web Browser Log Tracking
-
-### Setting Up Web App Tracking
-
-Web log tracking requires configuring patterns for URLs you want to monitor:
-
-```bash
-# Create a config file for web apps (web-logs.json)
-cat > web-logs.json << 'EOF'
-[
-  {
-    "id": "my-web-app",
-    "type": "web",
-    "name": "My Web Application",
-    "enabled": true,
-    "patterns": [
-      "*localhost:3000*",
-      "*myapp.com*",
-      "*staging.myapp.com*"
-    ]
-  },
-  {
-    "id": "github",
-    "type": "web", 
-    "name": "GitHub",
-    "enabled": true,
-    "patterns": [
-      "*github.com*"
-    ]
-  }
-]
-EOF
-```
-
-### Updating Web Log Configuration
-
-```javascript
-// In your Node.js script or through the API
-import { logsTrackerManager } from './lib/logs/index.js';
-
-const webConfig = [
-  {
-    id: 'my-app',
-    type: 'web',
-    name: 'My Application',
-    enabled: true,
-    patterns: ['*localhost:3000*', '*myapp.com*']
-  }
-];
-
-logsTrackerManager.updateLogsConfig(webConfig);
-```
-
-## Recording with Log Tracking
-
-### Start a Recording with Logs
-
-```bash
-# Start recording (logs are automatically included if configured)
-dashcam record --duration 30
-
-# The recording will include:
-# - All tracked log files (--add files above)
-# - Web browser events (if browser extension is installed)
-```
-
-### Browser Extension Setup
-
-1. **Install the Dashcam browser extension** (Chrome/Firefox)
-2. **The CLI automatically starts a WebSocket server** on ports: 10368, 16240, 21855, 24301, or 25928
-3. **Extension connects automatically** when CLI is running
-4. **Web events are captured** based on your URL patterns
-
-## Log Event Types
-
-### File Logs
-- **Line events**: Each new line written to tracked files
-- **Timestamps**: Precise timing for synchronization with video
-- **Error detection**: Automatic highlighting of error lines
-
-### Web Logs  
-- **Console logs**: `console.log()`, `console.error()`, etc.
-- **Network requests**: HTTP requests and responses
-- **Navigation events**: Page loads and URL changes
-- **Tab management**: Tab switches and window focus
-
-## Example Workflow
-
-```bash
-# 1. Add log files to track
-dashcam logs --add /var/log/myapp.log
-dashcam logs --add /tmp/debug.log
-
-# 2. Check status
-dashcam logs --status
-# Output:
-# Log tracking status:
-#   Active recording instances: 0
-#   Configured CLI log files: 2
-#   Total recent events: 15
-#   File tracker details:
-#     /var/log/myapp.log: 8 events (last minute)
-#     /tmp/debug.log: 7 events (last minute)
-
-# 3. Start recording
-dashcam record --duration 60
-
-# 4. During recording:
-# - CLI monitors all tracked log files in real-time
-# - Browser extension sends web events via WebSocket
-# - All events are timestamped and synchronized
-
-# 5. After recording:
-# - Logs are automatically trimmed to match video duration
-# - Events are saved in JSONL format alongside video
-# - Logs can be replayed in sync with video
-```
-
-## Advanced Configuration
-
-### Custom WebSocket Port
-
-```javascript
-// If you need to use specific ports
-import { server } from './lib/websocket/server.js';
-await server.start(); // Uses predefined port list
-```
-
-### Pattern Matching for Web Apps
-
-Patterns support wildcards:
-- `*example.com*` - Matches any URL containing "example.com"
-- `*localhost:3000*` - Matches local development server
-- `*github.com/myuser/*` - Matches specific GitHub paths
-
-### Log File Requirements
-
-- **Files must exist** before adding to tracking
-- **Files must be readable** by the CLI process  
-- **Real-time writes** are monitored (uses `tail` library)
-- **Log rotation** is automatically handled
-
-## Troubleshooting
-
-### Common Issues
-
-1. **"Log file does not exist"**
-   ```bash
-   # Ensure file exists first
-   touch /var/log/myapp.log
-   dashcam logs --add /var/log/myapp.log
-   ```
-
-2. **"WebSocket connection failed"** 
-   - Check that browser extension is installed
-   - Verify no firewall blocking local ports
-   - Ensure CLI is running when opening browser
-
-3. **"No events captured"**
-   ```bash
-   # Check if files are being written to
-   tail -f /var/log/myapp.log
-   
-   # Verify tracking status
-   dashcam logs --status
-   ```
-
-### Getting Help
-
-```bash
-# Show all log tracking options
-dashcam logs --help
-
-# Show general CLI help
-dashcam --help
-```
-
-## Integration with Recordings
-
-When you create a recording, all configured logs are:
-
-1. **Automatically included** in the recording
-2. **Synchronized** with video timestamps  
-3. **Trimmed** to match video start/end times
-4. **Saved** in JSON Lines format for replay
-5. **Uploaded** along with video files
-
-The result is a complete recording with both visual and log context, making debugging and analysis much more effective.

package/NPM_PUBLISH_FIX.md

@@ -1,104 +0,0 @@
-# NPM Publish & Version Sync Issues
-
-## Problem
-
-The npm publish workflow was failing with:
-```
-npm error 404 'dashcam@1.0.1-beta.17' is not in this registry.
-```
-
-## Root Cause
-
-**Version drift** between local git tags, package.json, and npm registry:
-
-- **NPM registry**: `1.0.1-beta.13` (latest successfully published)
-- **Local package.json**: `1.0.1-beta.16` (from failed publish attempts)
-- **Git tags**: Only up to `v1.0.1-beta.9`
-
-This happened because the workflow:
-1. Bumped version in package.json
-2. Created git tag
-3. Tried to publish
-4. **Publish failed** (possibly due to test failures or video encoding issues)
-5. Git changes were not reverted, leaving version incremented
-
-## Fixes Applied
-
-### 1. Updated Publish Workflow
-
-**Before**: Version bump → Push → Publish (wrong order!)
-
-**After**: 
-1. Sync with npm registry version
-2. Bump version
-3. **Publish first** ✅
-4. Push only if publish succeeded ✅
-
-```yaml
-- name: Bump version
-  run: |
-    # Get current version from npm
-    CURRENT_NPM_VERSION=$(npm view dashcam dist-tags.beta)
-    
-    # Sync before bumping
-    npm version $CURRENT_NPM_VERSION --no-git-tag-version --allow-same-version
-    
-    # Bump to next
-    npm version prerelease --preid=beta
-
-- name: Publish to npm
-  run: npm publish --access public --tag beta
-
-- name: Push changes  # Only runs if publish succeeded
-  run: git push --follow-tags
-```
-
-### 2. Created Version Sync Script
-
-`scripts/sync-version.sh` - Helps detect and fix version drift:
-
-```bash
-./scripts/sync-version.sh
-```
-
-This will:
-- Compare local version with npm registry
-- Offer to sync package.json
-- Show unpublished git tags that need cleanup
-
-### 3. Synced package.json
-
-Reset from `1.0.1-beta.16` → `1.0.1-beta.13` (current npm version)
-
-## Video Issue Connection
-
-The failed publishes were likely caused by **test failures due to the video encoding bugs** we fixed:
-
-- Frame rate conflicts
-- Buffer size issues
-- Frame dropping
-- Incomplete container metadata
-
-All of these are now fixed in the recorder.js, so future CI runs should succeed.
-
-## Next Steps
-
-1. ✅ Package.json is synced
-2. ✅ Workflow is fixed
-3. ⚠️  Need to clean up unpublished git tags manually (optional):
-
-```bash
-# List tags
-git tag | grep beta
-
-# Delete local tags for unpublished versions (14-16)
-git tag -d v1.0.1-beta.14 v1.0.1-beta.15 v1.0.1-beta.16
-
-# If they exist on remote, delete them
-git push origin :refs/tags/v1.0.1-beta.14
-git push origin :refs/tags/v1.0.1-beta.15
-git push origin :refs/tags/v1.0.1-beta.16
-```
-
-4. Push the fixes to trigger a new publish
-5. Next version will be `1.0.1-beta.14` ✅