dashcam 1.0.1-beta.4 → 1.0.1-beta.6

package/lib/logs/index.js

@@ -15,7 +15,13 @@ const CLI_CONFIG_FILE = path.join(process.cwd(), '.dashcam', 'cli-config.json');
 
 // Simple trim function for CLI (adapted from desktop app)
 async function trimLogs(groupLogStatuses, startMS, endMS, clientStartDate, clipId) {
-  logger.info('Trimming logs', { count: groupLogStatuses.length });
+  logger.info('Trimming logs', { 
+    count: groupLogStatuses.length,
+    startMS,
+    endMS,
+    clientStartDate,
+    clientStartDateReadable: new Date(clientStartDate).toISOString()
+  });
   
   const REPLAY_DIR = path.join(os.tmpdir(), 'dashcam', 'recordings');
   
@@ -36,12 +42,24 @@ async function trimLogs(groupLogStatuses, startMS, endMS, clientStartDate, clipI
       let events = content;
       
       // Convert events to relative time
-      let relativeEvents = events.map((event) => {
+      let relativeEvents = events.map((event, index) => {
+        const originalTime = event.time;
         event.time = parseInt(event.time + '') - startMS;
         // Check if it's not already relative time
         if (event.time > 1_000_000_000_000) {
           // relative time = absolute time - clip start time
           event.time = event.time - clientStartDate;
+          if (index === 0) {
+            // Log first event for debugging
+            logger.info('First event timestamp conversion', {
+              originalTime,
+              clientStartDate,
+              relativeTime: event.time,
+              relativeSeconds: (event.time / 1000).toFixed(2),
+              startMS,
+              line: event.line ? event.line.substring(0, 50) : 'N/A'
+            });
+          }
         }
         return event;
       });
@@ -56,16 +74,19 @@ async function trimLogs(groupLogStatuses, startMS, endMS, clientStartDate, clipI
         });
 
         if (status.type === 'cli') {
-          // Remap logFile indices for CLI logs
-          let map = {};
-          filteredEvents = filteredEvents.map((event) => {
-            let name = map[event.logFile] ?? Object.keys(map).length + 1;
-            if (!map[event.logFile]) map[event.logFile] = name;
-            return {
-              ...event,
-              logFile: name,
-            };
+          // For CLI logs, keep the file paths in logFile field for UI display
+          // No need to remap to numeric indices
+          
+          // Create items array showing unique files and their event counts
+          const fileCounts = {};
+          filteredEvents.forEach(event => {
+            fileCounts[event.logFile] = (fileCounts[event.logFile] || 0) + 1;
           });
+          
+          status.items = Object.entries(fileCounts).map(([filePath, count]) => ({
+            item: filePath,
+            count
+          }));
         }
       } else if (status.type === 'web' && !webHandled) {
         logger.debug('Found web groupLog, handling all web groupLogs at once');
@@ -243,6 +264,41 @@ class LogsTrackerManager {
     this.removeCliTrackedPath(filePath);
   }
 
+  addPipedLog(content) {
+    // Find active recording instance
+    const activeInstances = Object.values(this.instances);
+    if (activeInstances.length === 0) {
+      logger.warn('No active recording to add piped content to');
+      return;
+    }
+    
+    // Add to the most recent active instance (last one)
+    const instance = activeInstances[activeInstances.length - 1];
+    const timestamp = Date.now();
+    
+    // Write to CLI tracker's temp file
+    if (instance.trackers && instance.trackers.cli) {
+      const pipedLog = {
+        time: timestamp,
+        logFile: 'piped-input',
+        content: content
+      };
+      
+      // Write to the CLI tracker's output file
+      try {
+        const outputFile = path.join(instance.directory, 'cli-logs.jsonl');
+        const logLine = JSON.stringify(pipedLog) + '\n';
+        fs.appendFileSync(outputFile, logLine);
+        logger.info('Added piped content to recording', { 
+          recorderId: instance.recorderId,
+          contentLength: content.length 
+        });
+      } catch (error) {
+        logger.error('Failed to write piped content', { error });
+      }
+    }
+  }
+
   removeTracker(id) {
     // Try removing from web trackers first
     if (this.webLogsConfig[id]) {

package/lib/processManager.js

@@ -50,11 +50,18 @@ class ProcessManager {
 
   writeUploadResult(result) {
     try {
+      logger.info('Writing upload result to file', { path: RESULT_FILE, shareLink: result.shareLink });
       fs.writeFileSync(RESULT_FILE, JSON.stringify({
         ...result,
         timestamp: Date.now()
       }, null, 2));
-      logger.debug('Wrote upload result to file', { shareLink: result.shareLink });
+      logger.info('Successfully wrote upload result to file');
+      // Verify it was written
+      if (fs.existsSync(RESULT_FILE)) {
+        logger.info('Verified upload result file exists');
+      } else {
+        logger.error('Upload result file does not exist after write!');
+      }
     } catch (error) {
       logger.error('Failed to write upload result file', { error });
     }
@@ -104,7 +111,8 @@ class ProcessManager {
     const status = this.readStatus();
     
     if (!pid || !this.isProcessRunning(pid)) {
-      this.cleanup();
+      // Clean up but preserve upload result in case the background process just finished uploading
+      this.cleanup({ preserveResult: true });
       return false;
     }
     
@@ -116,11 +124,12 @@ class ProcessManager {
     return this.readStatus();
   }
 
-  cleanup() {
+  cleanup(options = {}) {
+    const { preserveResult = false } = options;
     try {
       if (fs.existsSync(PID_FILE)) fs.unlinkSync(PID_FILE);
       if (fs.existsSync(STATUS_FILE)) fs.unlinkSync(STATUS_FILE);
-      if (fs.existsSync(RESULT_FILE)) fs.unlinkSync(RESULT_FILE);
+      if (!preserveResult && fs.existsSync(RESULT_FILE)) fs.unlinkSync(RESULT_FILE);
     } catch (error) {
       logger.error('Failed to cleanup process files', { error });
     }
@@ -174,8 +183,8 @@ class ProcessManager {
             hasApps: result.apps?.length > 0
           });
           
-          // Cleanup process files
-          this.cleanup();
+          // Cleanup process files but preserve upload result for stop command
+          this.cleanup({ preserveResult: true });
           
           return result;
         } catch (recorderError) {
@@ -193,7 +202,7 @@ class ProcessManager {
             logs: []
           };
           
-          this.cleanup();
+          this.cleanup({ preserveResult: true });
           return result;
         }
       } else {

package/lib/recorder.js

@@ -278,8 +278,11 @@ export async function startRecording({
   // Construct FFmpeg command arguments
   const platformArgs = await getPlatformArgs({ fps, includeAudio });
   const outputArgs = [
-    '-c:v', 'libvpx',      // Use VP8 codec instead of VP9 for better compatibility
-    '-b:v', '1M',          // Set specific bitrate instead of variable
+    '-c:v', 'libvpx-vp9',  // Use VP9 codec for better quality and compression
+    '-quality', 'good',    // Use good quality preset for better encoding
+    '-cpu-used', '2',      // Higher quality encoding (0-5, lower = slower but better quality)
+    '-deadline', 'good',   // Good quality encoding mode
+    '-b:v', '5M',          // Higher bitrate for better quality
     // Remove explicit pixel format to let ffmpeg handle conversion automatically
     '-r', fps.toString(),   // Ensure output framerate matches input
     '-g', '30',            // Keyframe every 30 frames
@@ -358,13 +361,11 @@ export async function startRecording({
       all: true, // Capture both stdout and stderr
       stdin: 'pipe' // Enable stdin for sending 'q' to stop recording
     });
-
-    recordingStartTime = Date.now();
     
     logger.info('FFmpeg process spawned', { 
       pid: currentRecording.pid,
       args: args.slice(-5), // Log last 5 args including output file
-      tempFile 
+      tempFile
     });
     
     // Check if temp file gets created within first few seconds
@@ -392,6 +393,14 @@ export async function startRecording({
       directory: path.dirname(outputPath)
     });
 
+    // Set recording start time AFTER log tracker is initialized
+    // This ensures the timeline starts when the tracker is ready to capture events
+    recordingStartTime = Date.now();
+    logger.info('Recording timeline started', { 
+      recordingStartTime,
+      recordingStartTimeReadable: new Date(recordingStartTime).toISOString()
+    });
+
     if (currentRecording.all) {
       currentRecording.all.setEncoding('utf8');
       currentRecording.all.on('data', (data) => {
@@ -622,6 +631,12 @@ export async function stopRecording() {
       icons: appTrackingResults.icons, // Include application icons metadata
       logs: logTrackingResults // Include log tracking results
     };
+    
+    logger.info('Recording stopped with clientStartDate', {
+      clientStartDate: recordingStartTime,
+      clientStartDateReadable: new Date(recordingStartTime).toISOString(),
+      duration: result.duration
+    });
 
     currentRecording = null;
     recordingStartTime = null;

package/lib/tracking/FileTracker.js

@@ -1,5 +1,6 @@
 import { Tail } from 'tail';
 import { logger } from '../logger.js';
+import fs from 'fs';
 
 // Simple function to get stats for events in the last minute
 function getStats(eventTimes = []) {
@@ -40,6 +41,12 @@ export class FileTracker {
     this.trackedFile = trackedFile;
 
     try {
+      // Ensure the file exists before creating the Tail watcher
+      if (!fs.existsSync(this.trackedFile)) {
+        logger.warn(`File does not exist, creating: ${this.trackedFile}`);
+        fs.writeFileSync(this.trackedFile, '', 'utf8');
+      }
+      
       this.tail = new Tail(this.trackedFile, { encoding: 'ascii' });
       this.tail.on('line', (line) => {
         const time = Date.now();

package/lib/tracking/LogsTracker.js

@@ -55,6 +55,7 @@ export class LogsTracker {
 
     this.files[filePath] = {
       status,
+      filePath, // Store file path for later reference
       unsubscribe: this.fileTrackerManager.subscribe(filePath, callback),
     };
     
@@ -98,13 +99,25 @@ export class LogsTracker {
 
   getStatus() {
     let items = [];
+    let filePathMap = {};
+    
     if (this.isWatchOnly) {
-      items = Object.keys(this.files).map((filePath) => ({
-        ...this.fileTrackerManager.getStats(filePath),
-        item: this.fileToIndex[filePath],
-      }));
+      items = Object.keys(this.files).map((filePath) => {
+        const index = this.fileToIndex[filePath];
+        filePathMap[index] = filePath;
+        return {
+          ...this.fileTrackerManager.getStats(filePath),
+          item: index, // Keep numeric index to match events
+        };
+      });
     } else {
-      items = Object.values(this.files).map(({ status }) => status);
+      items = Object.values(this.files).map(({ status, filePath }) => {
+        const index = status.item;
+        filePathMap[index] = filePath;
+        return {
+          ...status,
+        };
+      });
     }
 
     const totalCount = items.reduce((acc, status) => acc + status.count, 0);
@@ -112,11 +125,12 @@ export class LogsTracker {
     return [
       {
         id: 'CLI',
-        name: 'CLI',
+        name: 'File Logs', // More descriptive name
         type: 'cli',
         fileLocation: this.fileLocation,
         items: items,
         count: totalCount,
+        filePathMap: filePathMap, // Include mapping for UI to display file paths
       },
     ];
   }
@@ -126,7 +140,7 @@ export class LogsTracker {
     const status = this.getStatus();
     return status.length > 0 ? status[0] : {
       id: 'CLI',
-      name: 'CLI', 
+      name: 'File Logs', 
       type: 'cli',
       fileLocation: this.fileLocation,
       items: [],

package/lib/uploader.js

@@ -371,8 +371,12 @@ export async function upload(filePath, metadata = {}) {
     for (const logStatus of trimmedLogs) {
       if (logStatus.count > 0 && logStatus.trimmedFileLocation && fs.existsSync(logStatus.trimmedFileLocation)) {
         try {
+          // Use the name from the status, or a default descriptive name
+          // The name is what shows in the "App" dropdown, not the file path
+          let logName = logStatus.name || 'File Logs';
+          
           logger.debug('Creating log STS credentials', {
-            name: logStatus.name || `Log ${logStatus.id}`,
+            name: logName,
             type: logStatus.type,
             count: logStatus.count
           });
@@ -380,7 +384,7 @@ export async function upload(filePath, metadata = {}) {
           const logSts = await auth.createLogSts(
             newReplay.replay.id,
             logStatus.id || `log-${Date.now()}`,
-            logStatus.name || `Log ${logStatus.id}`,
+            logName,
             logStatus.type || 'application'
           );
           
@@ -440,9 +444,13 @@ export async function upload(filePath, metadata = {}) {
   });
 
   logExit();
+  
+  // Replace app.dashcam.io with app.testdriver.ai in the share link
+  const shareLink = newReplay.replay.shareLink?.replace('app.dashcam.io', 'app.testdriver.ai') || newReplay.replay.shareLink;
+  
   return {
     replay: newReplay.replay,
-    shareLink: newReplay.replay.shareLink
+    shareLink: shareLink
   };
 }
 

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "dashcam",
-  "version": "1.0.1-beta.4",
+  "version": "1.0.1-beta.6",
   "description": "Minimal CLI version of Dashcam desktop app",
   "main": "bin/index.js",
   "bin": {
@@ -55,6 +55,9 @@
     "@yao-pkg/pkg": "^6.10.1",
     "esbuild": "^0.19.0"
   },
+  "overrides": {
+    "@mapbox/node-pre-gyp": "^2.0.0"
+  },
   "type": "module",
   "engines": {
     "node": ">=20.0.0"

package/test_workflow.sh

@@ -30,44 +30,93 @@ if [ ! -f "$TEMP_FILE" ]; then
 fi
 echo "✅ File tracking configured"
 
-# 4. Start background process that logs current time to the temporary file
+# 4. Start dashcam recording in background
 echo ""
-echo "4. Starting background logging process..."
-(
-  while true; do
-    echo "$(date): Current time logged" >> "$TEMP_FILE"
-    sleep 2
-  done
-) &
-LOGGER_PID=$!
-echo "✅ Background logger started (PID: $LOGGER_PID)"
+echo "4. Starting dashcam recording in background..."
+# Start recording and redirect output to a log file so we can still monitor it
+./bin/dashcam.js record --title "Sync Test Recording" --description "Testing video/log synchronization with timestamped events" > /tmp/dashcam-recording.log 2>&1 &
+RECORD_PID=$!
 
-# 5. Start dashcam recording in background
+# Wait for recording to initialize and log tracker to start
+echo "Waiting for recording to initialize (PID: $RECORD_PID)..."
+sleep 1
+
+# Write first event after log tracker is fully ready
+RECORDING_START=$(date +%s)
+echo "━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━"
+echo "🔴 EVENT 1: Recording START at $(date '+%H:%M:%S')"
+echo "━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━"
+echo "[EVENT 1] Recording started at $(date '+%H:%M:%S') - TIMESTAMP: $RECORDING_START" >> "$TEMP_FILE"
+
+# Verify recording is actually running
+if ps -p $RECORD_PID > /dev/null; then
+  echo "✅ Recording started successfully"
+else
+  echo "❌ Recording process died, check /tmp/dashcam-recording.log"
+  exit 1
+fi
+
+# 5. Create synchronized log events with visual markers
+echo ""
+echo "5. Creating synchronized test events..."
+echo ""
+echo "╔════════════════════════════════════════════════════════════════╗"
+echo "║  SYNC TEST - Watch for these markers in the recording!        ║"
+echo "╚════════════════════════════════════════════════════════════════╝"
 echo ""
-echo "5. Starting dashcam recording in background..."
-./bin/dashcam.js record --title "Test Workflow Recording" --description "Testing CLI workflow with web and file tracking" &
 
-# Give the recording a moment to initialize
-sleep 2
-echo "✅ Recording started in background"
+# Event 1 was already written above - now continue with the rest
+sleep 3
 
-# 6. Let recording run for a few seconds
+# Event 2 - after 3 seconds
 echo ""
-echo "6. Letting recording run for 20 seconds..."
-sleep 20
-echo "✅ Recording completed"
+echo "🟡 EVENT 2: 3 seconds mark at $(date '+%H:%M:%S')"
+echo "[EVENT 2] 3 seconds elapsed at $(date '+%H:%M:%S')" >> "$TEMP_FILE"
+sleep 3
 
-# 7. Stop recording and upload (this will kill the background recording process)
+# Event 3 - after 6 seconds
 echo ""
-echo "7. Stopping recording and uploading..."
+echo "🟢 EVENT 3: 6 seconds mark at $(date '+%H:%M:%S')"
+echo "[EVENT 3] 6 seconds elapsed at $(date '+%H:%M:%S')" >> "$TEMP_FILE"
+sleep 3
+
+# Event 4 - after 9 seconds
+echo ""
+echo "🔵 EVENT 4: 9 seconds mark at $(date '+%H:%M:%S')"
+echo "[EVENT 4] 9 seconds elapsed at $(date '+%H:%M:%S')" >> "$TEMP_FILE"
+sleep 3
+
+# Event 5 - after 12 seconds
+echo ""
+echo "🟣 EVENT 5: 12 seconds mark at $(date '+%H:%M:%S')"
+echo "[EVENT 5] 12 seconds elapsed at $(date '+%H:%M:%S')" >> "$TEMP_FILE"
+sleep 3
+
+# Event 6 - before ending
+echo ""
+echo "━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━"
+echo "⚫ EVENT 6: Recording END at $(date '+%H:%M:%S')"
+echo "━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━"
+RECORDING_END=$(date +%s)
+echo "[EVENT 6] Recording ending at $(date '+%H:%M:%S') - TIMESTAMP: $RECORDING_END" >> "$TEMP_FILE"
+
+DURATION=$((RECORDING_END - RECORDING_START))
+echo ""
+echo "✅ Test events completed (Duration: ${DURATION}s)"
+
+# Give a moment for the last event to be fully processed
+echo ""
+echo "Waiting 2 seconds to ensure all events are captured..."
+sleep 2
+
+# 6. Stop recording and upload (this will kill the background recording process)
+echo ""
+echo "6. Stopping recording and uploading..."
 ./bin/dashcam.js stop
 echo "✅ Recording stopped and uploaded"
 
-# Cleanup: Stop the background logger
 echo ""
 echo "🧹 Cleaning up..."
-kill $LOGGER_PID 2>/dev/null || true
-echo "✅ Background logger stopped"
 
 echo ""
 echo "🎉 Test workflow completed successfully!"
@@ -78,3 +127,28 @@ echo ""
 echo "📊 Final Status:"
 ./bin/dashcam.js status
 
+echo ""
+echo "╔════════════════════════════════════════════════════════════════╗"
+echo "║                  SYNC VERIFICATION GUIDE                       ║"
+echo "╚════════════════════════════════════════════════════════════════╝"
+echo ""
+echo "To verify video/log synchronization in the recording:"
+echo ""
+echo "1. Open the uploaded recording in your browser"
+echo "2. Check the log panel for '$TEMP_FILE'"
+echo "3. Verify these events appear at the correct times:"
+echo ""
+echo "   Time   | Terminal Display          | Log Entry"
+echo "   -------|---------------------------|---------------------------"
+echo "   0:00   | 🔴 EVENT 1               | [EVENT 1] Recording started"
+echo "   0:03   | 🟡 EVENT 2               | [EVENT 2] 3 seconds elapsed"
+echo "   0:06   | 🟢 EVENT 3               | [EVENT 3] 6 seconds elapsed"
+echo "   0:09   | 🔵 EVENT 4               | [EVENT 4] 9 seconds elapsed"
+echo "   0:12   | 🟣 EVENT 5               | [EVENT 5] 12 seconds elapsed"
+echo "   0:15   | ⚫ EVENT 6               | [EVENT 6] Recording ending"
+echo ""
+echo "4. The log timestamps should match the video timeline exactly"
+echo "5. Each colored event marker should appear in the video"
+echo "   at the same moment as the corresponding log entry"
+echo ""
+

package/.github/workflows/build.yml

@@ -1,103 +0,0 @@
-name: Build Binaries
-
-on:
-  workflow_dispatch:
-  workflow_call:
-    inputs:
-      upload_artifacts:
-        description: 'Whether to upload artifacts'
-        required: false
-        type: boolean
-        default: true
-
-jobs:
-  build:
-    runs-on: ${{ matrix.os }}
-    strategy:
-      matrix:
-        os: [ubuntu-latest, macos-latest, windows-latest]
-        
-    steps:
-      - name: Checkout code
-        uses: actions/checkout@v4
-
-      - name: Setup Node.js
-        uses: actions/setup-node@v4
-        with:
-          node-version: '20'
-          cache: 'npm'
-
-      - name: Setup Python (Windows)
-        if: matrix.os == 'windows-latest'
-        uses: actions/setup-python@v5
-        with:
-          python-version: '3.11'
-
-      - name: Install dependencies
-        run: npm ci
-
-      - name: Build bundle
-        run: npm run bundle
-
-      - name: Verify bundle created
-        run: |
-          ls -la dist/ || dir dist\
-        shell: bash
-
-      - name: Build binaries (macOS)
-        if: matrix.os == 'macos-latest'
-        run: npm run build:macos
-
-      - name: Build binaries (Linux)
-        if: matrix.os == 'ubuntu-latest'
-        run: npm run build:linux
-
-      - name: Build binaries (Windows)
-        if: matrix.os == 'windows-latest'
-        run: npm run build:windows
-        continue-on-error: true
-        
-      - name: Check Windows build
-        if: matrix.os == 'windows-latest'
-        run: |
-          if (Test-Path dist/bundle-x64.exe) {
-            Write-Host "Windows build successful"
-            exit 0
-          } else {
-            Write-Host "Windows build failed, but continuing..."
-            exit 0
-          }
-        shell: pwsh
-
-      - name: List built files
-        run: |
-          ls -la dist/ || dir dist\
-        shell: bash
-
-      - name: Upload artifacts (macOS)
-        if: matrix.os == 'macos-latest' && (inputs.upload_artifacts || github.event_name == 'pull_request')
-        uses: actions/upload-artifact@v4
-        with:
-          name: dashcam-macos
-          path: |
-            dist/bundle-arm64
-            dist/bundle-x64
-
-      - name: Upload artifacts (Linux)
-        if: matrix.os == 'ubuntu-latest' && (inputs.upload_artifacts || github.event_name == 'pull_request')
-        uses: actions/upload-artifact@v4
-        with:
-          name: dashcam-linux
-          path: |
-            dist/bundle-arm64
-            dist/bundle-x64
-
-      - name: Upload artifacts (Windows)
-        if: (matrix.os == 'windows-latest' && hashFiles('dist/bundle-x64.exe') != '') && (inputs.upload_artifacts || github.event_name == 'pull_request')
-        uses: actions/upload-artifact@v4
-        with:
-          name: dashcam-windows
-          path: |
-            dist/bundle-x64.exe
-            dist/bundle-arm64.exe
-          if-no-files-found: warn