dashcam 1.0.1-beta.32 → 1.0.1-beta.34

package/bin/dashcam-background.js

@@ -55,8 +55,13 @@ function writeUploadResult(result) {
       timestamp: Date.now()
     }, null, 2));
     logger.info('Successfully wrote upload result to file');
+    // Verify the file was written
+    if (fs.existsSync(RESULT_FILE)) {
+      const content = fs.readFileSync(RESULT_FILE, 'utf8');
+      logger.info('Verified upload result file exists and contains', { content: content.substring(0, 100) });
+    }
   } catch (error) {
-    logger.error('Failed to write upload result file', { error });
+    logger.error('Failed to write upload result file', { error: error.message, stack: error.stack });
   }
 }
 
@@ -99,10 +104,11 @@ async function runBackgroundRecording() {
       }
       isShuttingDown = true;
       
-      logger.info(`Received ${signal}, stopping background recording...`);
+      logger.info(`Received ${signal} signal, stopping background recording...`, { pid: process.pid });
       
       try {
         // Stop the recording
+        logger.info('Calling stopRecording...');
         const stopResult = await stopRecording();
         
         if (stopResult) {
@@ -128,10 +134,12 @@ async function runBackgroundRecording() {
           logger.info('Upload complete', { shareLink: uploadResult.shareLink });
           
           // Write upload result for stop command to read
+          logger.info('About to write upload result...');
           writeUploadResult({
             shareLink: uploadResult.shareLink,
             replayId: uploadResult.replay?.id
           });
+          logger.info('Upload result written successfully');
         }
         
         // Update status to indicate recording stopped
@@ -144,13 +152,19 @@ async function runBackgroundRecording() {
         logger.info('Background process exiting successfully');
         process.exit(0);
       } catch (error) {
-        logger.error('Error during shutdown:', error);
+        logger.error('Error during shutdown:', { error: error.message, stack: error.stack });
         process.exit(1);
       }
     };
     
-    process.on('SIGINT', () => handleShutdown('SIGINT'));
-    process.on('SIGTERM', () => handleShutdown('SIGTERM'));
+    process.on('SIGINT', () => {
+      logger.info('SIGINT handler triggered');
+      handleShutdown('SIGINT');
+    });
+    process.on('SIGTERM', () => {
+      logger.info('SIGTERM handler triggered');
+      handleShutdown('SIGTERM');
+    });
     
     // Keep the process alive
     logger.info('Background recording is now running. Waiting for stop signal...');

package/bin/dashcam.js

@@ -136,10 +136,7 @@ async function recordingAction(options, command) {
       log('Use "dashcam status" to check progress');
       log('Use "dashcam stop" to stop recording and upload');
       
-      // Close stdout/stderr and exit immediately to prevent blocking
-      // when called from automation scripts with piped output
-      process.stdout.end();
-      process.stderr.end();
+      // Process can exit now - background process is detached
       process.exit(0);
       
     } catch (error) {

package/lib/processManager.js

@@ -59,22 +59,26 @@ class ProcessManager {
       logger.info('Successfully wrote upload result to file');
       // Verify it was written
       if (fs.existsSync(RESULT_FILE)) {
-        logger.info('Verified upload result file exists');
+        const fileSize = fs.statSync(RESULT_FILE).size;
+        logger.info('Verified upload result file exists', { size: fileSize });
       } else {
         logger.error('Upload result file does not exist after write!');
       }
     } catch (error) {
-      logger.error('Failed to write upload result file', { error });
+      logger.error('Failed to write upload result file', { error: error.message, stack: error.stack });
     }
   }
 
   readUploadResult() {
     try {
+      logger.debug('Checking for upload result file', { path: RESULT_FILE, exists: fs.existsSync(RESULT_FILE) });
       if (!fs.existsSync(RESULT_FILE)) return null;
       const data = fs.readFileSync(RESULT_FILE, 'utf8');
-      return JSON.parse(data);
+      const result = JSON.parse(data);
+      logger.debug('Successfully read upload result', { shareLink: result.shareLink });
+      return result;
     } catch (error) {
-      logger.error('Failed to read upload result file', { error });
+      logger.error('Failed to read upload result file', { error: error.message, stack: error.stack });
       return null;
     }
   }
@@ -128,11 +132,23 @@ class ProcessManager {
   cleanup(options = {}) {
     const { preserveResult = false } = options;
     try {
-      if (fs.existsSync(PID_FILE)) fs.unlinkSync(PID_FILE);
-      if (fs.existsSync(STATUS_FILE)) fs.unlinkSync(STATUS_FILE);
-      if (!preserveResult && fs.existsSync(RESULT_FILE)) fs.unlinkSync(RESULT_FILE);
+      logger.debug('Cleanup called', { preserveResult, resultFileExists: fs.existsSync(RESULT_FILE) });
+      if (fs.existsSync(PID_FILE)) {
+        fs.unlinkSync(PID_FILE);
+        logger.debug('Deleted PID file');
+      }
+      if (fs.existsSync(STATUS_FILE)) {
+        fs.unlinkSync(STATUS_FILE);
+        logger.debug('Deleted STATUS file');
+      }
+      if (!preserveResult && fs.existsSync(RESULT_FILE)) {
+        fs.unlinkSync(RESULT_FILE);
+        logger.debug('Deleted RESULT file');
+      } else if (preserveResult && fs.existsSync(RESULT_FILE)) {
+        logger.debug('Preserved RESULT file');
+      }
     } catch (error) {
-      logger.error('Failed to cleanup process files', { error });
+      logger.error('Failed to cleanup process files', { error: error.message });
     }
   }
 
@@ -159,11 +175,19 @@ class ProcessManager {
       const isWindows = process.platform === 'win32';
       
       if (isWindows) {
-        logger.info('Windows detected, using taskkill to stop process');
+        logger.info('Windows detected, attempting graceful shutdown first');
         try {
-          // Use taskkill to forcefully stop the process tree on Windows
+          // First try graceful shutdown without /F (force) flag
+          // This sends CTRL+C which Node.js can handle
           const { execSync } = await import('child_process');
-          execSync(`taskkill /PID ${pid} /F /T`, { stdio: 'ignore' });
+          try {
+            execSync(`taskkill /PID ${pid} /T`, { stdio: 'ignore', timeout: 5000 });
+            logger.info('Sent graceful shutdown signal to process');
+          } catch (error) {
+            // If graceful shutdown fails or times out, force kill
+            logger.warn('Graceful shutdown failed, forcing termination');
+            execSync(`taskkill /PID ${pid} /F /T`, { stdio: 'ignore' });
+          }
         } catch (error) {
           logger.warn('Failed to kill process with taskkill', { error: error.message });
         }
@@ -238,20 +262,11 @@ class ProcessManager {
     const __dirname = path.dirname(__filename);
     const backgroundScript = path.join(__dirname, '..', 'bin', 'dashcam-background.js');
     
-    // On Windows, we need to ensure stdio is completely detached
-    const isWindows = process.platform === 'win32';
-    const spawnOptions = {
+    // Spawn a detached background process
+    const child = spawn(process.execPath, [backgroundScript, JSON.stringify(options)], {
       detached: true,
       stdio: 'ignore'
-    };
-    
-    // On Windows, also create a new process group to fully detach
-    if (isWindows) {
-      spawnOptions.windowsHide = true;
-    }
-    
-    // Spawn a detached background process
-    const child = spawn(process.execPath, [backgroundScript, JSON.stringify(options)], spawnOptions);
+    });
     
     // Unref so the parent process can exit
     child.unref();
@@ -263,8 +278,7 @@ class ProcessManager {
 
     logger.info('Background process spawned successfully', { 
       pid,
-      backgroundScript,
-      platform: process.platform
+      backgroundScript
     });
     
     // Wait a moment for the background process to write its status

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "dashcam",
-  "version": "1.0.1-beta.32",
+  "version": "1.0.1-beta.34",
   "description": "Minimal CLI version of Dashcam desktop app",
   "main": "bin/index.js",
   "bin": {