dashcam 1.0.1-beta.24 → 1.0.1-beta.26

package/bin/dashcam.js

@@ -417,12 +417,22 @@ program
 
         console.log('Recording stopped successfully');
         
-        // Wait a moment for upload to complete (background process handles this)
+        // Wait for upload to complete (background process handles this)
         logger.debug('Waiting for background upload to complete...');
-        await new Promise(resolve => setTimeout(resolve, 5000));
+        console.log('⏳ Uploading recording...');
+        
+        // Wait up to 2 minutes for upload result to appear
+        const maxWaitForUpload = 120000; // 2 minutes
+        const startWaitForUpload = Date.now();
+        let uploadResult = null;
+        
+        while (!uploadResult && (Date.now() - startWaitForUpload) < maxWaitForUpload) {
+          uploadResult = processManager.readUploadResult();
+          if (!uploadResult) {
+            await new Promise(resolve => setTimeout(resolve, 1000)); // Check every second
+          }
+        }
         
-        // Try to read the upload result from the background process
-        const uploadResult = processManager.readUploadResult();
         logger.debug('Upload result read attempt', { found: !!uploadResult, shareLink: uploadResult?.shareLink });
         
         if (uploadResult && uploadResult.shareLink) {
@@ -616,7 +626,7 @@ program
       
       if (options.recover) {
         // Try to recover from interrupted recording
-        const tempFileInfoPath = path.join(process.cwd(), '.dashcam', 'temp-file.json');
+        const tempFileInfoPath = path.join(APP.configDir, 'temp-file.json');
         
         if (fs.existsSync(tempFileInfoPath)) {
           console.log('Found interrupted recording, attempting recovery...');

package/lib/processManager.js

@@ -160,8 +160,9 @@ class ProcessManager {
       logger.info('Stopping active recording process', { pid });
       process.kill(pid, 'SIGINT');
       
-      // Wait for the process to actually finish
-      const maxWaitTime = 30000; // 30 seconds max
+      // Wait for the process to actually finish and upload
+      // Increase timeout to allow for upload to complete
+      const maxWaitTime = 120000; // 2 minutes max to allow for upload
       const startWait = Date.now();
       
       while (this.isProcessRunning(pid) && (Date.now() - startWait) < maxWaitTime) {

package/lib/recorder.js

@@ -4,6 +4,7 @@ import { createGif, createSnapshot } from './ffmpeg.js';
 import { applicationTracker } from './applicationTracker.js';
 import { logsTrackerManager, trimLogs } from './logs/index.js';
 import { getFfmpegPath } from './binaries.js';
+import { APP } from './config.js';
 import path from 'path';
 import os from 'os';
 import fs from 'fs';
@@ -145,8 +146,8 @@ let outputPath = null;
 let recordingStartTime = null;
 let currentTempFile = null;
 
-// File paths - use system temp for runtime data
-const DASHCAM_TEMP_DIR = path.join(os.tmpdir(), 'dashcam');
+// File paths - use APP config directory for better Windows compatibility
+const DASHCAM_TEMP_DIR = APP.configDir;
 const TEMP_FILE_INFO_PATH = path.join(DASHCAM_TEMP_DIR, 'temp-file.json');
 
 // Platform-specific configurations
@@ -238,12 +239,12 @@ async function getPlatformArgs({ fps, includeAudio }) {
 }
 
 /**
- * Clear the tmp/recordings directory
+ * Clear the recordings directory
  */
 function clearRecordingsDirectory() {
   const logExit = logFunctionCall('clearRecordingsDirectory');
   
-  const directory = path.join(process.cwd(), 'tmp', 'recordings');
+  const directory = APP.recordingsDir;
   
   try {
     if (fs.existsSync(directory)) {
@@ -281,8 +282,8 @@ function generateOutputPath() {
   const logExit = logFunctionCall('generateOutputPath');
   
   const timestamp = new Date().toISOString().replace(/[:.]/g, '-');
-  // Use system temp directory with dashcam subdirectory
-  const directory = path.join(os.tmpdir(), 'dashcam', 'recordings');
+  // Use APP recordings directory for consistent cross-platform location
+  const directory = APP.recordingsDir;
   const filepath = path.join(directory, `recording-${timestamp}.webm`);
   
   logger.verbose('Generating output path', {

package/lib/systemInfo.js

@@ -0,0 +1,141 @@
+import si from 'systeminformation';
+import { logger } from './logger.js';
+
+/**
+ * Collects comprehensive system information including CPU, memory, OS, and graphics data.
+ * This matches the data format expected by the Dashcam backend (same as desktop app).
+ * 
+ * @returns {Promise<Object>} System information object
+ */
+export async function getSystemInfo() {
+  try {
+    logger.debug('Collecting system information...');
+    
+    // Collect only essential system information quickly
+    // Graphics info can be very slow, so we skip it or use a short timeout
+    const [cpu, mem, osInfo, system] = await Promise.all([
+      si.cpu(),
+      si.mem(),
+      si.osInfo(),
+      si.system()
+    ]);
+    
+    // Try to get graphics info with a very short timeout (optional)
+    let graphics = { controllers: [], displays: [] };
+    try {
+      graphics = await Promise.race([
+        si.graphics(),
+        new Promise((_, reject) => setTimeout(() => reject(new Error('Graphics timeout')), 2000))
+      ]);
+    } catch (error) {
+      logger.debug('Graphics info timed out, using empty graphics data');
+    }
+
+    const systemInfo = {
+      cpu: {
+        manufacturer: cpu.manufacturer,
+        brand: cpu.brand,
+        vendor: cpu.vendor,
+        family: cpu.family,
+        model: cpu.model,
+        stepping: cpu.stepping,
+        revision: cpu.revision,
+        voltage: cpu.voltage,
+        speed: cpu.speed,
+        speedMin: cpu.speedMin,
+        speedMax: cpu.speedMax,
+        cores: cpu.cores,
+        physicalCores: cpu.physicalCores,
+        processors: cpu.processors,
+        socket: cpu.socket,
+        cache: cpu.cache
+      },
+      mem: {
+        total: mem.total,
+        free: mem.free,
+        used: mem.used,
+        active: mem.active,
+        available: mem.available,
+        swaptotal: mem.swaptotal,
+        swapused: mem.swapused,
+        swapfree: mem.swapfree
+      },
+      os: {
+        platform: osInfo.platform,
+        distro: osInfo.distro,
+        release: osInfo.release,
+        codename: osInfo.codename,
+        kernel: osInfo.kernel,
+        arch: osInfo.arch,
+        hostname: osInfo.hostname,
+        fqdn: osInfo.fqdn,
+        codepage: osInfo.codepage,
+        logofile: osInfo.logofile,
+        build: osInfo.build,
+        servicepack: osInfo.servicepack,
+        uefi: osInfo.uefi
+      },
+      graphics: {
+        controllers: graphics.controllers?.map(controller => ({
+          vendor: controller.vendor,
+          model: controller.model,
+          bus: controller.bus,
+          vram: controller.vram,
+          vramDynamic: controller.vramDynamic
+        })),
+        displays: graphics.displays?.map(display => ({
+          vendor: display.vendor,
+          model: display.model,
+          main: display.main,
+          builtin: display.builtin,
+          connection: display.connection,
+          resolutionX: display.resolutionX,
+          resolutionY: display.resolutionY,
+          sizeX: display.sizeX,
+          sizeY: display.sizeY,
+          pixelDepth: display.pixelDepth,
+          currentResX: display.currentResX,
+          currentResY: display.currentResY,
+          currentRefreshRate: display.currentRefreshRate
+        }))
+      },
+      system: {
+        manufacturer: system.manufacturer,
+        model: system.model,
+        version: system.version,
+        serial: system.serial,
+        uuid: system.uuid,
+        sku: system.sku,
+        virtual: system.virtual
+      }
+    };
+
+    logger.verbose('System information collected', {
+      cpuBrand: cpu.brand,
+      totalMemoryGB: (mem.total / (1024 * 1024 * 1024)).toFixed(2),
+      os: `${osInfo.distro} ${osInfo.release}`,
+      graphicsControllers: graphics.controllers?.length || 0,
+      displays: graphics.displays?.length || 0
+    });
+
+    return systemInfo;
+  } catch (error) {
+    logger.error('Failed to collect system information:', {
+      message: error.message,
+      stack: error.stack
+    });
+    
+    // Return minimal system info as fallback
+    return {
+      cpu: { brand: 'Unknown', cores: 0 },
+      mem: { total: 0 },
+      os: { 
+        platform: process.platform,
+        arch: process.arch,
+        release: process.version
+      },
+      graphics: { controllers: [], displays: [] },
+      system: { manufacturer: 'Unknown', model: 'Unknown' }
+    };
+  }
+}

package/lib/uploader.js

@@ -5,6 +5,7 @@ import { logger, logFunctionCall } from './logger.js';
 import path from 'path';
 import { auth } from './auth.js';
 import got from 'got';
+import { getSystemInfo } from './systemInfo.js';
 
 class Uploader {
   constructor() {
@@ -200,6 +201,15 @@ export async function upload(filePath, metadata = {}) {
     hasProject: !!metadata.project
   });
 
+  // Collect system information
+  logger.debug('Collecting system information...');
+  const systemInfo = await getSystemInfo();
+  logger.verbose('System information collected for upload', {
+    cpuBrand: systemInfo.cpu?.brand,
+    osDistro: systemInfo.os?.distro,
+    totalMemGB: systemInfo.mem?.total ? (systemInfo.mem.total / (1024 * 1024 * 1024)).toFixed(2) : 'unknown'
+  });
+
   // Handle project ID - use provided project or fetch first available project
   let projectId = metadata.project;
   if (!projectId) {
@@ -229,11 +239,7 @@ export async function upload(filePath, metadata = {}) {
     duration: metadata.duration || 0,
     apps: metadata.apps && metadata.apps.length > 0 ? metadata.apps : ['Screen Recording'], // Use tracked apps or fallback
     title: metadata.title || defaultTitle,
-    system: {
-      platform: process.platform,
-      arch: process.arch,
-      nodeVersion: process.version
-    },
+    system: systemInfo, // Include system information
     clientStartDate: metadata.clientStartDate || Date.now() // Use actual recording start time
   };
 

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "dashcam",
-  "version": "1.0.1-beta.24",
+  "version": "1.0.1-beta.26",
   "description": "Minimal CLI version of Dashcam desktop app",
   "main": "bin/index.js",
   "bin": {
@@ -47,6 +47,7 @@
     "mask-sensitive-data": "^0.11.5",
     "node-fetch": "^2.7.0",
     "open": "^9.1.0",
+    "systeminformation": "^5.18.15",
     "tail": "^2.2.6",
     "winston": "^3.11.0",
     "ws": "^8.18.3"

package/test-system-info.js

@@ -0,0 +1,105 @@
+#!/usr/bin/env node
+/**
+ * Test script to verify system information collection
+ */
+
+import { getSystemInfo } from './lib/systemInfo.js';
+import { logger } from './lib/logger.js';
+
+async function testSystemInfo() {
+  console.log('Testing system information collection...\n');
+  
+  try {
+    const systemInfo = await getSystemInfo();
+    
+    console.log('✓ System information collected successfully\n');
+    console.log('System Information:');
+    console.log('==================\n');
+    
+    console.log('CPU:');
+    console.log(`  Brand: ${systemInfo.cpu.brand}`);
+    console.log(`  Cores: ${systemInfo.cpu.cores}`);
+    console.log(`  Speed: ${systemInfo.cpu.speed} GHz`);
+    console.log();
+    
+    console.log('Memory:');
+    console.log(`  Total: ${(systemInfo.mem.total / (1024 ** 3)).toFixed(2)} GB`);
+    console.log(`  Free: ${(systemInfo.mem.free / (1024 ** 3)).toFixed(2)} GB`);
+    console.log(`  Used: ${(systemInfo.mem.used / (1024 ** 3)).toFixed(2)} GB`);
+    console.log();
+    
+    console.log('Operating System:');
+    console.log(`  Platform: ${systemInfo.os.platform}`);
+    console.log(`  Distribution: ${systemInfo.os.distro}`);
+    console.log(`  Release: ${systemInfo.os.release}`);
+    console.log(`  Architecture: ${systemInfo.os.arch}`);
+    console.log(`  Hostname: ${systemInfo.os.hostname}`);
+    console.log();
+    
+    console.log('Graphics:');
+    console.log(`  Controllers: ${systemInfo.graphics.controllers?.length || 0}`);
+    if (systemInfo.graphics.controllers?.length > 0) {
+      systemInfo.graphics.controllers.forEach((controller, index) => {
+        console.log(`    ${index + 1}. ${controller.vendor} ${controller.model}`);
+        if (controller.vram) {
+          console.log(`       VRAM: ${controller.vram} MB`);
+        }
+      });
+    }
+    console.log(`  Displays: ${systemInfo.graphics.displays?.length || 0}`);
+    if (systemInfo.graphics.displays?.length > 0) {
+      systemInfo.graphics.displays.forEach((display, index) => {
+        console.log(`    ${index + 1}. ${display.model || 'Unknown'}`);
+        console.log(`       Resolution: ${display.currentResX}x${display.currentResY}`);
+        console.log(`       Refresh Rate: ${display.currentRefreshRate} Hz`);
+      });
+    }
+    console.log();
+    
+    console.log('System:');
+    console.log(`  Manufacturer: ${systemInfo.system.manufacturer}`);
+    console.log(`  Model: ${systemInfo.system.model}`);
+    console.log(`  Virtual: ${systemInfo.system.virtual ? 'Yes' : 'No'}`);
+    console.log();
+    
+    // Verify all required fields are present
+    console.log('Validation:');
+    console.log('===========\n');
+    
+    const validations = [
+      { name: 'CPU info', valid: !!systemInfo.cpu && !!systemInfo.cpu.brand },
+      { name: 'Memory info', valid: !!systemInfo.mem && systemInfo.mem.total > 0 },
+      { name: 'OS info', valid: !!systemInfo.os && !!systemInfo.os.platform },
+      { name: 'Graphics info', valid: !!systemInfo.graphics },
+      { name: 'System info', valid: !!systemInfo.system }
+    ];
+    
+    let allValid = true;
+    validations.forEach(v => {
+      const status = v.valid ? '✓' : '✗';
+      console.log(`${status} ${v.name}: ${v.valid ? 'OK' : 'MISSING'}`);
+      if (!v.valid) allValid = false;
+    });
+    
+    console.log();
+    
+    if (allValid) {
+      console.log('✓ All system information fields are properly populated');
+      console.log('✓ System information is ready to be uploaded to the API');
+    } else {
+      console.log('✗ Some system information is missing');
+    }
+    
+    // Show the JSON structure that would be sent to the API
+    console.log('\nJSON Structure for API:');
+    console.log('======================\n');
+    console.log(JSON.stringify(systemInfo, null, 2));
+    
+  } catch (error) {
+    console.error('✗ Failed to collect system information:', error.message);
+    console.error(error.stack);
+    process.exit(1);
+  }
+}
+
+testSystemInfo();