dashcam 1.0.1-beta.21 → 1.0.1-beta.22

package/lib/ffmpeg.js

@@ -18,7 +18,7 @@ export async function createSnapshot(inputVideoPath, outputSnapshotPath, snapsho
     '-i', inputVideoPath,
     '-frames:v', '1',
     '-vf', 'scale=640:-1:force_original_aspect_ratio=decrease:eval=frame',
-    '-compression_level', '6', // Use default compression (was 100, which is extremely slow)
+    '-compression_level', '0', // Fast compression for speed (0 = fastest, 9 = slowest)
     outputSnapshotPath,
     '-y',
     '-hide_banner'
@@ -94,62 +94,32 @@ export async function createGif(inputVideoPath, outputGifPath) {
       stdout
     });
     
-    // Fallback: Just sample the video at a fixed rate (e.g., 1 frame every 3 seconds)
-    const framesPath = path.join(os.tmpdir(), `frames_${id}_%04d.png`);
+    // Fallback: Single-pass GIF creation at fixed rate
+    const filters = `fps=1/3,scale=640:-1:flags=lanczos,split[s0][s1];[s0]palettegen=max_colors=128[p];[s1][p]paletteuse=dither=bayer:bayer_scale=5`;
+    
     await execa(ffmpegPath, [
       '-i', inputVideoPath,
-      '-vf', `fps=1/3`, // Sample 1 frame every 3 seconds
-      framesPath
-    ]);
-
-    // Create GIF from frames
-    await execa(ffmpegPath, [
-      '-framerate', `${gifFps}`,
-      '-i', framesPath,
+      '-vf', filters,
       '-loop', '0',
       outputGifPath,
       '-y',
       '-hide_banner'
     ]);
-
-    // Clean up temporary frame files
-    const framesToDelete = fs.readdirSync(os.tmpdir())
-      .filter(file => file.startsWith(`frames_${id}_`) && file.endsWith('.png'))
-      .map(file => path.join(os.tmpdir(), file));
-    
-    for (const frame of framesToDelete) {
-      fs.unlinkSync(frame);
-    }
     
     return;
   }
   
   const extractedFramesInterval = videoDuration / gifFrames;
 
-  // Extract frames
-  const framesPath = path.join(os.tmpdir(), `frames_${id}_%04d.png`);
+  // Single-pass GIF creation with palette for better quality and performance
+  const filters = `fps=1/${extractedFramesInterval},scale=640:-1:flags=lanczos,split[s0][s1];[s0]palettegen=max_colors=128[p];[s1][p]paletteuse=dither=bayer:bayer_scale=5`;
+  
   await execa(ffmpegPath, [
     '-i', inputVideoPath,
-    '-vf', `fps=1/${extractedFramesInterval}`,
-    framesPath
-  ]);
-
-  // Create GIF from frames
-  await execa(ffmpegPath, [
-    '-framerate', `${gifFps}`,
-    '-i', framesPath,
+    '-vf', filters,
     '-loop', '0',
     outputGifPath,
     '-y',
     '-hide_banner'
   ]);
-
-  // Clean up temporary frame files
-  const framesToDelete = fs.readdirSync(os.tmpdir())
-    .filter(file => file.startsWith(`frames_${id}_`) && file.endsWith('.png'))
-    .map(file => path.join(os.tmpdir(), file));
-  
-  for (const frame of framesToDelete) {
-    fs.unlinkSync(frame);
-  }
 }

package/lib/processManager.js

@@ -174,41 +174,27 @@ class ProcessManager {
         await new Promise(resolve => setTimeout(resolve, 1000));
       }
       
-      // Call the actual recorder's stopRecording function to get complete results
+      // The background process handles stopRecording() internally via SIGINT
+      // We just need to return the basic result from the status file
       if (status) {
-        try {
-          const { stopRecording } = await import('./recorder.js');
-          const result = await stopRecording();
-          
-          logger.info('Recording stopped successfully via recorder', { 
-            outputPath: result.outputPath,
-            duration: result.duration,
-            hasLogs: result.logs?.length > 0,
-            hasApps: result.apps?.length > 0
-          });
-          
-          // Cleanup process files but preserve upload result for stop command
-          this.cleanup({ preserveResult: true });
-          
-          return result;
-        } catch (recorderError) {
-          logger.warn('Failed to stop via recorder, falling back to basic result', { error: recorderError.message });
-          
-          // Fallback to basic result if recorder fails
-          const basePath = status.outputPath.substring(0, status.outputPath.lastIndexOf('.'));
-          const result = {
-            outputPath: status.outputPath,
-            gifPath: `${basePath}.gif`,
-            snapshotPath: `${basePath}.png`,
-            duration: Date.now() - status.startTime,
-            clientStartDate: status.startTime,
-            apps: [],
-            logs: []
-          };
-          
-          this.cleanup({ preserveResult: true });
-          return result;
-        }
+        logger.info('Background recording stopped, returning status', { 
+          outputPath: status.outputPath,
+          duration: Date.now() - status.startTime
+        });
+        
+        const basePath = status.outputPath.substring(0, status.outputPath.lastIndexOf('.'));
+        const result = {
+          outputPath: status.outputPath,
+          gifPath: `${basePath}.gif`,
+          snapshotPath: `${basePath}.png`,
+          duration: Date.now() - status.startTime,
+          clientStartDate: status.startTime,
+          apps: [],
+          logs: []
+        };
+        
+        this.cleanup({ preserveResult: true });
+        return result;
       } else {
         throw new Error('No status information available for active recording');
       }

package/lib/recorder.js

@@ -322,9 +322,9 @@ export async function startRecording({
   const platformArgs = await getPlatformArgs({ fps, includeAudio });
   const outputArgs = [
     '-c:v', 'libvpx-vp9',  // Use VP9 codec for better quality and compression
-    '-quality', 'good',     // Use 'good' quality preset (better than realtime, not as slow as best)
-    '-cpu-used', '4',       // Faster encoding (0-8, higher = faster but lower quality)
-    '-deadline', 'good',    // Good quality encoding mode
+    '-quality', 'realtime', // Use realtime quality preset for faster encoding
+    '-cpu-used', '8',       // Maximum speed (0-8, higher = faster but lower quality)
+    '-deadline', 'realtime',// Realtime encoding mode for lowest latency
     '-b:v', '2M',           // Target bitrate
     '-r', fps.toString(),   // Ensure output framerate matches input
     '-g', fps.toString(),   // Keyframe interval = 1 second (every fps frames) - ensures frequent keyframes
@@ -528,24 +528,23 @@ export async function stopRecording() {
       currentRecording.stdin.end(); // Close stdin to signal end
     }
 
-    // Wait longer for FFmpeg to finish gracefully - critical for VP9 encoding
-    // VP9 encoding needs time to flush buffers and finalize the container
+    // Wait for FFmpeg to finish gracefully with realtime encoding
     const gracefulTimeout = setTimeout(() => {
       if (currentRecording && !currentRecording.killed) {
-        logger.warn('FFmpeg did not exit gracefully after 8s, sending SIGTERM...');
+        logger.warn('FFmpeg did not exit gracefully after 5s, sending SIGTERM...');
         // If still running, try SIGTERM
         process.kill(currentRecording.pid, 'SIGTERM');
       }
-    }, 8000); // Increased to 8 seconds for VP9 finalization
+    }, 5000); // Faster with realtime encoding
 
-    // Wait up to 15 seconds for SIGTERM to work
+    // Wait up to 10 seconds for SIGTERM to work
     const hardKillTimeout = setTimeout(() => {
       if (currentRecording && !currentRecording.killed) {
         logger.error('FFmpeg still running after SIGTERM, using SIGKILL...');
         // If still not dead, use SIGKILL as last resort
         process.kill(currentRecording.pid, 'SIGKILL');
       }
-    }, 15000); // Increased to 15 seconds
+    }, 10000); // Faster timeout
 
     // Wait for the process to fully exit
     if (currentRecording) {
@@ -556,10 +555,10 @@ export async function stopRecording() {
     clearTimeout(gracefulTimeout);
     clearTimeout(hardKillTimeout);
 
-    // Additional wait to ensure filesystem is synced and encoder buffers are flushed
-    // This is especially important for VP9 which has larger encoding buffers
-    logger.debug('Waiting for filesystem sync and VP9 encoder finalization...');
-    await new Promise(resolve => setTimeout(resolve, 3000)); // Keep at 3 seconds after process exit
+    // Additional wait to ensure filesystem is synced
+    // Realtime encoding has smaller buffers so this can be shorter
+    logger.debug('Waiting for filesystem sync...');
+    await new Promise(resolve => setTimeout(resolve, 1000)); // Reduced from 3s with realtime encoding
 
     // Read temp file path from disk (for cross-process access)
     let tempFile = currentTempFile; // Try in-memory first
@@ -607,8 +606,7 @@ export async function stopRecording() {
       path: tempFile
     });
 
-    // Since WebM is already a valid streaming format, re-mux it to ensure
-    // proper container metadata (duration, seekability, etc.)
+    // Re-mux to ensure proper container metadata (duration, seekability, etc.)
     logger.debug('Re-muxing temp file to fix container metadata...');
     
     try {

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "dashcam",
-  "version": "1.0.1-beta.21",
+  "version": "1.0.1-beta.22",
   "description": "Minimal CLI version of Dashcam desktop app",
   "main": "bin/index.js",
   "bin": {