dashcam 1.0.1-beta.2 → 1.0.1-beta.21

package/lib/tracking/icons/linux.js

@@ -0,0 +1,277 @@
+import { logger } from "../../logger.js";
+import { execa } from "execa";
+import fs from "fs";
+import path from "path";
+import os from "os";
+
+/**
+ * Find icon for a Linux application using various strategies
+ */
+const findLinuxIcon = async (appName) => {
+  // Strategy 1: Look for .desktop file
+  const desktopFile = await findDesktopFile(appName);
+  if (desktopFile) {
+    const iconName = await extractIconFromDesktop(desktopFile);
+    if (iconName) {
+      const iconPath = await findIconInTheme(iconName);
+      if (iconPath) {
+        logger.debug("Found icon via .desktop file", { appName, iconPath });
+        return iconPath;
+      }
+    }
+  }
+
+  // Strategy 2: Try to find icon directly in icon themes
+  const iconPath = await findIconInTheme(appName);
+  if (iconPath) {
+    logger.debug("Found icon in theme", { appName, iconPath });
+    return iconPath;
+  }
+
+  // Strategy 3: Common application paths
+  const commonPaths = [
+    `/usr/share/pixmaps/${appName}.png`,
+    `/usr/share/pixmaps/${appName}.svg`,
+    `/usr/share/icons/hicolor/48x48/apps/${appName}.png`,
+    `/usr/share/icons/hicolor/scalable/apps/${appName}.svg`,
+  ];
+
+  for (const iconPath of commonPaths) {
+    if (fs.existsSync(iconPath)) {
+      logger.debug("Found icon in common path", { appName, iconPath });
+      return iconPath;
+    }
+  }
+
+  logger.debug("No icon found for Linux app", { appName });
+  return null;
+};
+
+/**
+ * Find .desktop file for an application
+ */
+const findDesktopFile = async (appName) => {
+  const desktopDirs = [
+    "/usr/share/applications",
+    "/usr/local/share/applications",
+    path.join(os.homedir(), ".local/share/applications"),
+  ];
+
+  // Try exact match first
+  for (const dir of desktopDirs) {
+    const desktopFile = path.join(dir, `${appName}.desktop`);
+    if (fs.existsSync(desktopFile)) {
+      return desktopFile;
+    }
+  }
+
+  // Try case-insensitive search
+  for (const dir of desktopDirs) {
+    try {
+      if (!fs.existsSync(dir)) continue;
+      
+      const files = fs.readdirSync(dir);
+      const match = files.find(
+        (f) => f.toLowerCase() === `${appName.toLowerCase()}.desktop`
+      );
+      if (match) {
+        return path.join(dir, match);
+      }
+    } catch (error) {
+      logger.debug("Error reading desktop directory", { dir, error: error.message });
+    }
+  }
+
+  return null;
+};
+
+/**
+ * Extract icon name from .desktop file
+ */
+const extractIconFromDesktop = async (desktopFilePath) => {
+  try {
+    const content = fs.readFileSync(desktopFilePath, "utf8");
+    const iconMatch = content.match(/^Icon=(.+)$/m);
+    if (iconMatch) {
+      return iconMatch[1].trim();
+    }
+  } catch (error) {
+    logger.debug("Error reading desktop file", { 
+      desktopFilePath, 
+      error: error.message 
+    });
+  }
+  return null;
+};
+
+/**
+ * Find icon in XDG icon themes
+ */
+const findIconInTheme = async (iconName) => {
+  // Common icon theme locations and sizes
+  const iconThemes = ["hicolor", "gnome", "Adwaita", "breeze", "oxygen"];
+  const iconSizes = ["48x48", "64x64", "scalable", "128x128", "256x256"];
+  const iconFormats = ["png", "svg", "xpm"];
+
+  const searchPaths = [
+    "/usr/share/icons",
+    "/usr/local/share/icons",
+    path.join(os.homedir(), ".local/share/icons"),
+    path.join(os.homedir(), ".icons"),
+  ];
+
+  for (const basePath of searchPaths) {
+    if (!fs.existsSync(basePath)) continue;
+
+    for (const theme of iconThemes) {
+      const themePath = path.join(basePath, theme);
+      if (!fs.existsSync(themePath)) continue;
+
+      for (const size of iconSizes) {
+        const sizePath = path.join(themePath, size, "apps");
+        if (!fs.existsSync(sizePath)) continue;
+
+        for (const format of iconFormats) {
+          const iconPath = path.join(sizePath, `${iconName}.${format}`);
+          if (fs.existsSync(iconPath)) {
+            return iconPath;
+          }
+        }
+      }
+    }
+  }
+
+  return null;
+};
+
+/**
+ * Convert image to PNG if needed
+ */
+const convertToPng = async (iconPath) => {
+  const ext = path.extname(iconPath).toLowerCase();
+  
+  // If already PNG, read and return
+  if (ext === ".png") {
+    return fs.readFileSync(iconPath);
+  }
+
+  // For SVG, try to convert using ImageMagick or rsvg-convert
+  if (ext === ".svg") {
+    const tmpPngPath = path.join(os.tmpdir(), `icon-${Date.now()}.png`);
+    
+    try {
+      // Try rsvg-convert first (commonly available on Linux)
+      await execa("rsvg-convert", [
+        "-w", "48",
+        "-h", "48",
+        "-o", tmpPngPath,
+        iconPath
+      ]);
+      
+      const buffer = fs.readFileSync(tmpPngPath);
+      fs.unlinkSync(tmpPngPath);
+      return buffer;
+    } catch (error) {
+      logger.debug("rsvg-convert failed, trying ImageMagick", { error: error.message });
+      
+      try {
+        // Fallback to ImageMagick convert
+        await execa("convert", [
+          "-background", "none",
+          "-resize", "48x48",
+          iconPath,
+          tmpPngPath
+        ]);
+        
+        const buffer = fs.readFileSync(tmpPngPath);
+        fs.unlinkSync(tmpPngPath);
+        return buffer;
+      } catch (convertError) {
+        logger.debug("ImageMagick convert failed", { error: convertError.message });
+        
+        // Clean up temp file if it exists
+        if (fs.existsSync(tmpPngPath)) {
+          fs.unlinkSync(tmpPngPath);
+        }
+        
+        return null;
+      }
+    }
+  }
+
+  // For XPM, try ImageMagick
+  if (ext === ".xpm") {
+    const tmpPngPath = path.join(os.tmpdir(), `icon-${Date.now()}.png`);
+    
+    try {
+      await execa("convert", [
+        "-background", "none",
+        "-resize", "48x48",
+        iconPath,
+        tmpPngPath
+      ]);
+      
+      const buffer = fs.readFileSync(tmpPngPath);
+      fs.unlinkSync(tmpPngPath);
+      return buffer;
+    } catch (error) {
+      logger.debug("Failed to convert XPM to PNG", { error: error.message });
+      
+      // Clean up temp file if it exists
+      if (fs.existsSync(tmpPngPath)) {
+        fs.unlinkSync(tmpPngPath);
+      }
+      
+      return null;
+    }
+  }
+
+  logger.debug("Unsupported icon format", { ext, iconPath });
+  return null;
+};
+
+/**
+ * Get icon as buffer for Linux application
+ * @param {string} appPath - Path to the application or process name
+ */
+const getIconAsBuffer = async (appPath) => {
+  try {
+    // Extract app name from path
+    let appName = path.basename(appPath);
+    
+    // Remove common extensions
+    appName = appName.replace(/\.(exe|bin|sh|py|js)$/i, "");
+    
+    logger.debug("Extracting icon for Linux app", { appName, appPath });
+    
+    // Find the icon file
+    const iconPath = await findLinuxIcon(appName);
+    if (!iconPath) {
+      logger.debug("No icon found for Linux app", { appName });
+      return null;
+    }
+    
+    // Convert to PNG if needed
+    const buffer = await convertToPng(iconPath);
+    if (!buffer) {
+      logger.debug("Failed to convert icon to PNG", { iconPath });
+      return null;
+    }
+    
+    logger.debug("Successfully extracted Linux icon", {
+      appName,
+      iconPath,
+      bufferSize: buffer.length,
+    });
+    
+    return { extension: "png", buffer };
+  } catch (error) {
+    logger.warn("Failed to extract Linux icon", {
+      appPath,
+      error: error.message,
+    });
+    return null;
+  }
+};
+
+export { getIconAsBuffer };

package/lib/uploader.js

@@ -371,8 +371,12 @@ export async function upload(filePath, metadata = {}) {
     for (const logStatus of trimmedLogs) {
       if (logStatus.count > 0 && logStatus.trimmedFileLocation && fs.existsSync(logStatus.trimmedFileLocation)) {
         try {
+          // Use the name from the status, or a default descriptive name
+          // The name is what shows in the "App" dropdown, not the file path
+          let logName = logStatus.name || 'File Logs';
+          
           logger.debug('Creating log STS credentials', {
-            name: logStatus.name || `Log ${logStatus.id}`,
+            name: logName,
             type: logStatus.type,
             count: logStatus.count
           });
@@ -380,7 +384,7 @@ export async function upload(filePath, metadata = {}) {
           const logSts = await auth.createLogSts(
             newReplay.replay.id,
             logStatus.id || `log-${Date.now()}`,
-            logStatus.name || `Log ${logStatus.id}`,
+            logName,
             logStatus.type || 'application'
           );
           
@@ -440,9 +444,12 @@ export async function upload(filePath, metadata = {}) {
   });
 
   logExit();
+  
+  const shareLink = newReplay.replay.shareLink;
+  
   return {
     replay: newReplay.replay,
-    shareLink: newReplay.replay.shareLink
+    shareLink: shareLink
   };
 }
 

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "dashcam",
-  "version": "1.0.1-beta.2",
+  "version": "1.0.1-beta.21",
   "description": "Minimal CLI version of Dashcam desktop app",
   "main": "bin/index.js",
   "bin": {
@@ -55,6 +55,9 @@
     "@yao-pkg/pkg": "^6.10.1",
     "esbuild": "^0.19.0"
   },
+  "overrides": {
+    "@mapbox/node-pre-gyp": "^2.0.0"
+  },
   "type": "module",
   "engines": {
     "node": ">=20.0.0"

package/scripts/sync-version.sh

@@ -0,0 +1,48 @@
+#!/bin/bash
+
+# Sync local version with npm registry
+# This fixes version drift when publishes fail
+
+echo "🔍 Checking version sync..."
+
+# Get current version in package.json
+LOCAL_VERSION=$(node -p "require('./package.json').version")
+echo "📦 Local version: $LOCAL_VERSION"
+
+# Get current beta version from npm
+NPM_BETA_VERSION=$(npm view dashcam dist-tags.beta 2>/dev/null)
+if [ -z "$NPM_BETA_VERSION" ]; then
+  echo "⚠️  No beta tag found on npm, checking latest version..."
+  NPM_BETA_VERSION=$(npm view dashcam versions --json | jq -r '.[] | select(contains("beta"))' | tail -1)
+fi
+echo "📡 NPM beta version: $NPM_BETA_VERSION"
+
+# Get all local git tags
+echo ""
+echo "🏷️  Local git tags:"
+git tag | grep beta | tail -5
+
+echo ""
+echo "📡 NPM published versions:"
+npm view dashcam versions --json | jq -r '.[] | select(contains("beta"))' | tail -5
+
+echo ""
+if [ "$LOCAL_VERSION" != "$NPM_BETA_VERSION" ]; then
+  echo "⚠️  Version mismatch detected!"
+  echo "   Local:  $LOCAL_VERSION"
+  echo "   NPM:    $NPM_BETA_VERSION"
+  echo ""
+  read -p "Do you want to sync package.json to $NPM_BETA_VERSION? (y/n) " -n 1 -r
+  echo
+  if [[ $REPLY =~ ^[Yy]$ ]]; then
+    npm version $NPM_BETA_VERSION --no-git-tag-version --allow-same-version
+    echo "✅ Synced package.json to $NPM_BETA_VERSION"
+    echo ""
+    echo "⚠️  Note: You may have unpublished git tags. To clean them up:"
+    echo "   git tag | grep beta | tail -10  # Review tags"
+    echo "   git tag -d v1.0.1-beta.XX       # Delete unpublished tags"
+    echo "   git push origin :refs/tags/v1.0.1-beta.XX  # Delete remote tags"
+  fi
+else
+  echo "✅ Versions are in sync!"
+fi

package/test-short-recording.js

@@ -0,0 +1,287 @@
+#!/usr/bin/env node
+
+/**
+ * Test script for analyzing short recording issues
+ * 
+ * This tests whether very short recordings produce valid multi-frame videos
+ * with properly finalized WebM container metadata.
+ * 
+ * Known issue: If ffmpeg/VP9 encoder is killed too quickly, the WebM container
+ * metadata (especially duration) may be incomplete, causing playback issues.
+ * 
+ * Usage:
+ *   node test-short-recording.js                    # Run recording tests
+ *   node test-short-recording.js analyze <file>     # Analyze existing video
+ *   node test-short-recording.js fix <input> <output> # Fix broken video container
+ * 
+ * Platform notes:
+ *   - macOS: Uses AVFoundation for screen capture
+ *   - Linux: Uses X11grab for screen capture
+ *   - Windows: Uses gdigrab for screen capture
+ */
+
+import { startRecording, stopRecording, fixVideoContainer } from './lib/recorder.js';
+import { execa } from 'execa';
+import { getFfprobePath } from './lib/binaries.js';
+import fs from 'fs';
+import path from 'path';
+import os from 'os';
+
+async function analyzeVideo(videoPath) {
+  const ffprobePath = await getFfprobePath();
+  
+  console.log(`\n📊 Analyzing video: ${videoPath}`);
+  console.log('─'.repeat(80));
+  
+  // Check if file exists
+  if (!fs.existsSync(videoPath)) {
+    console.error(`❌ Video file does not exist: ${videoPath}`);
+    return null;
+  }
+  
+  const stats = fs.statSync(videoPath);
+  console.log(`📁 File size: ${(stats.size / 1024).toFixed(2)} KB`);
+  
+  try {
+    // Get basic format info
+    const formatResult = await execa(ffprobePath, [
+      '-v', 'error',
+      '-show_entries', 'format=duration,size,bit_rate',
+      '-of', 'json',
+      videoPath
+    ]);
+    
+    const formatData = JSON.parse(formatResult.stdout);
+    console.log(`⏱️  Duration: ${formatData.format.duration || 'unknown'}s`);
+    console.log(`📊 Bit rate: ${formatData.format.bit_rate || 'unknown'} bits/s`);
+    
+    // Get stream info
+    const streamResult = await execa(ffprobePath, [
+      '-v', 'error',
+      '-show_entries', 'stream=codec_name,width,height,r_frame_rate,duration',
+      '-of', 'json',
+      videoPath
+    ]);
+    
+    const streamData = JSON.parse(streamResult.stdout);
+    const videoStream = streamData.streams.find(s => s.codec_name);
+    
+    if (videoStream) {
+      console.log(`🎥 Codec: ${videoStream.codec_name}`);
+      console.log(`📐 Resolution: ${videoStream.width}x${videoStream.height}`);
+      console.log(`🎞️  Frame rate: ${videoStream.r_frame_rate}`);
+    }
+    
+    // Count actual frames
+    const frameResult = await execa(ffprobePath, [
+      '-v', 'error',
+      '-count_frames',
+      '-select_streams', 'v:0',
+      '-show_entries', 'stream=nb_read_frames',
+      '-of', 'default=nokey=1:noprint_wrappers=1',
+      videoPath
+    ], { reject: false });
+    
+    const frameCount = parseInt(frameResult.stdout.trim());
+    console.log(`🖼️  Frame count: ${frameCount || 'unknown'}`);
+    
+    if (frameResult.stderr) {
+      console.log(`⚠️  FFprobe warnings: ${frameResult.stderr.trim()}`);
+    }
+    
+    // Check if duration is available in container
+    const hasDuration = formatData.format.duration && !isNaN(parseFloat(formatData.format.duration));
+    
+    // Determine if this is a single-frame video issue
+    const isSingleFrame = frameCount === 1;
+    const hasEncodingIssues = frameResult.stderr.includes('File ended prematurely');
+    const hasMissingMetadata = !hasDuration;
+    
+    console.log('\n📋 Analysis Result:');
+    console.log(`   Single frame: ${isSingleFrame ? '❌ YES (BUG!)' : '✅ NO'}`);
+    console.log(`   Encoding issues: ${hasEncodingIssues ? '⚠️  YES' : '✅ NO'}`);
+    console.log(`   Missing metadata: ${hasMissingMetadata ? '⚠️  YES (container incomplete)' : '✅ NO'}`);
+    console.log(`   Platform: ${os.platform()}`);
+    
+    return {
+      exists: true,
+      size: stats.size,
+      duration: parseFloat(formatData.format.duration),
+      frameCount,
+      codec: videoStream?.codec_name,
+      resolution: videoStream ? `${videoStream.width}x${videoStream.height}` : 'unknown',
+      isSingleFrame,
+      hasEncodingIssues,
+      hasMissingMetadata,
+      platform: os.platform()
+    };
+    
+  } catch (error) {
+    console.error(`❌ Error analyzing video: ${error.message}`);
+    return null;
+  }
+}
+
+async function testShortRecording(duration = 3000) {
+  console.log(`\n🎬 Testing ${duration}ms recording...`);
+  console.log('═'.repeat(80));
+  
+  try {
+    // Start recording
+    console.log('▶️  Starting recording...');
+    const { outputPath, startTime } = await startRecording({ 
+      fps: 30,
+      includeAudio: false 
+    });
+    
+    console.log(`✅ Recording started at: ${outputPath}`);
+    
+    // Wait for specified duration
+    console.log(`⏳ Recording for ${duration}ms...`);
+    await new Promise(resolve => setTimeout(resolve, duration));
+    
+    // Stop recording
+    console.log('⏹️  Stopping recording...');
+    const result = await stopRecording();
+    
+    console.log(`✅ Recording stopped`);
+    console.log(`   Duration: ${result.duration}ms`);
+    console.log(`   File: ${result.outputPath}`);
+    
+    // Analyze the output
+    await analyzeVideo(result.outputPath);
+    
+    return result;
+    
+  } catch (error) {
+    console.error(`❌ Test failed: ${error.message}`);
+    console.error(error.stack);
+    throw error;
+  }
+}
+
+async function testExistingVideo(videoPath) {
+  console.log('\n🔍 Testing existing video...');
+  console.log('═'.repeat(80));
+  
+  return await analyzeVideo(videoPath);
+}
+
+// Main test runner
+async function main() {
+  const args = process.argv.slice(2);
+  
+  console.log('\n🧪 Short Recording Test Suite');
+  console.log('═'.repeat(80));
+  console.log(`Platform: ${os.platform()}`);
+  console.log(`Architecture: ${os.arch()}`);
+  console.log(`Node version: ${process.version}`);
+  
+  if (args[0] === 'analyze' && args[1]) {
+    // Analyze existing video
+    const videoPath = path.resolve(args[1]);
+    const result = await testExistingVideo(videoPath);
+    
+    if (result?.isSingleFrame) {
+      console.log('\n❌ SINGLE-FRAME VIDEO DETECTED!');
+      process.exit(1);
+    } else if (result?.hasMissingMetadata) {
+      console.log('\n⚠️  WARNING: Video container metadata is incomplete!');
+      console.log('   This can cause playback issues in some players.');
+      console.log('   The video has frames but duration is not in the container.');
+      console.log('\n💡 Try fixing it with:');
+      console.log(`   node test-short-recording.js fix ${args[1]} ${args[1].replace(/\.(webm|mp4)$/, '-fixed.$1')}`);
+      process.exit(1);
+    }
+  } else if (args[0] === 'fix' && args[1] && args[2]) {
+    // Fix existing broken video
+    const inputPath = path.resolve(args[1]);
+    const outputPath = path.resolve(args[2]);
+    
+    console.log('\n🔧 Fixing video container...');
+    console.log('═'.repeat(80));
+    console.log(`Input:  ${inputPath}`);
+    console.log(`Output: ${outputPath}`);
+    
+    if (!fs.existsSync(inputPath)) {
+      console.error(`❌ Input file does not exist: ${inputPath}`);
+      process.exit(1);
+    }
+    
+    // Analyze before
+    console.log('\n📊 BEFORE:');
+    const beforeResult = await analyzeVideo(inputPath);
+    
+    // Fix the video
+    const fixSuccess = await fixVideoContainer(inputPath, outputPath);
+    
+    if (!fixSuccess) {
+      console.error('\n❌ Failed to fix video!');
+      process.exit(1);
+    }
+    
+    // Analyze after
+    console.log('\n📊 AFTER:');
+    const afterResult = await analyzeVideo(outputPath);
+    
+    console.log('\n✅ Video fixed successfully!');
+    console.log(`   Before: ${beforeResult?.hasMissingMetadata ? 'Missing metadata ⚠️' : 'Has metadata ✅'}`);
+    console.log(`   After:  ${afterResult?.hasMissingMetadata ? 'Missing metadata ⚠️' : 'Has metadata ✅'}`);
+    
+    if (afterResult?.hasMissingMetadata) {
+      console.log('\n⚠️  Warning: Metadata still missing after fix. The source file may be corrupted.');
+      process.exit(1);
+    }
+  } else {
+    // Run recording tests with different durations
+    const testDurations = [1000, 2000, 3000, 5000];
+    const results = [];
+    
+    for (const duration of testDurations) {
+      try {
+        const result = await testShortRecording(duration);
+        results.push({ duration, success: true, result });
+        
+        // Clean up
+        try {
+          fs.unlinkSync(result.outputPath);
+          if (result.gifPath && fs.existsSync(result.gifPath)) {
+            fs.unlinkSync(result.gifPath);
+          }
+          if (result.snapshotPath && fs.existsSync(result.snapshotPath)) {
+            fs.unlinkSync(result.snapshotPath);
+          }
+        } catch (cleanupError) {
+          console.warn(`⚠️  Cleanup warning: ${cleanupError.message}`);
+        }
+      } catch (error) {
+        results.push({ duration, success: false, error: error.message });
+      }
+      
+      // Wait between tests
+      await new Promise(resolve => setTimeout(resolve, 2000));
+    }
+    
+    // Summary
+    console.log('\n\n📊 TEST SUMMARY');
+    console.log('═'.repeat(80));
+    
+    for (const result of results) {
+      const status = result.success ? '✅' : '❌';
+      console.log(`${status} ${result.duration}ms recording: ${result.success ? 'PASSED' : result.error}`);
+    }
+    
+    const allPassed = results.every(r => r.success);
+    if (!allPassed) {
+      console.log('\n❌ Some tests failed!');
+      process.exit(1);
+    } else {
+      console.log('\n✅ All tests passed!');
+    }
+  }
+}
+
+main().catch(error => {
+  console.error('Fatal error:', error);
+  process.exit(1);
+});