dashboard-shell-shell 1.0.113 → 1.0.114

package/components/form/__tests__/Probe.test.ts

@@ -6,20 +6,18 @@ import { DefaultProps } from 'vue/types/options';
 
 describe('component: Probe', () => {
   describe.each([
-    [{ httpGet: { scheme: 'https' } }, ['port', 'path']],
-    [{ tcpSocket: {} }, ['socket']],
-    [{ exec: {} }, ['command']],
-  ])('given kind %p', (value, extraFields) => {
+    ['HTTPS', ['port', 'path']],
+    ['tcp', ['socket']],
+    ['exec', ['command']],
+  ])('given kind %p', (kind, extraFields) => {
     it.each([
       ...extraFields,
       'successThreshold',
       'failureThreshold',
     ])('should emit an update on %p input', (field) => {
       const wrapper = mount(Probe as unknown as ExtendedVue<Vue, {}, {}, {}, DefaultProps>, {
-        props: {
-          mode: _EDIT,
-          value,
-        },
+        props: { mode: _EDIT },
+        data:  () => ({ kind })
       });
       const input = wrapper.find(`[data-testid="input-probe-${ field }"]`).find('input');
       const newValue = 123;
@@ -35,10 +33,8 @@ describe('component: Probe', () => {
       'timeoutSeconds',
     ])('should emit an update on %p input and blur', (field) => {
       const wrapper = mount(Probe as unknown as ExtendedVue<Vue, {}, {}, {}, DefaultProps>, {
-        props: {
-          mode: _EDIT,
-          value
-        },
+        props: { mode: _EDIT },
+        data:  () => ({ kind })
       });
       const input = wrapper.find(`[data-testid="input-probe-${ field }"]`).find('input');
       const newValue = 123;

package/components/form/__tests__/SSHKnownHosts.test.ts

@@ -2,17 +2,6 @@ import { mount } from '@vue/test-utils';
 import { _EDIT, _VIEW } from '@shell/config/query-params';
 import SSHKnownHosts from '@shell/components/form/SSHKnownHosts/index.vue';
 
-jest.mock('focus-trap', () => {
-  return {
-    createFocusTrap: jest.fn().mockImplementation(() => {
-      return {
-        activate:   jest.fn(),
-        deactivate: jest.fn(),
-      };
-    }),
-  };
-});
-
 describe('component: SSHKnownHosts', () => {
   it.each([
     ['0 entities', '', 0],

package/components/form/__tests__/Select.test.ts

@@ -27,41 +27,4 @@ describe('select.vue', () => {
     // eslint-disable-next-line no-console
     expect(console.warn).not.toHaveBeenCalled();
   });
-
-  it('a11y: adding ARIA props should correctly fill out the appropriate fields on the component', async() => {
-    const label = 'Foo';
-    const value = 'foo';
-    const ariaDescribedById = 'some-described-by-id';
-    const ariaLabelText = 'some-aria-label';
-
-    const wrapper = shallowMount(SelectComponent, {
-      props: {
-        value,
-        options: [
-          { label, value },
-        ],
-      },
-      attrs: {
-        'aria-describedby': ariaDescribedById,
-        'aria-label':       ariaLabelText,
-      }
-    });
-
-    const labeledSelectContainer = wrapper.find('.unlabeled-select');
-    const ariaExpanded = labeledSelectContainer.attributes('aria-expanded');
-    const ariaDescribedBy = labeledSelectContainer.attributes('aria-describedby');
-    const ariaLabel = labeledSelectContainer.attributes('aria-label');
-
-    const vSelectInput = wrapper.find('.inline');
-
-    expect(ariaExpanded).toBe('false');
-    expect(ariaDescribedBy).toBe(ariaDescribedById);
-    expect(ariaLabel).toBe(ariaLabelText);
-
-    // make sure it's hardcoded to a "neutral" value so that
-    // in the current architecture of the component
-    // screen readers won't pick up the default "Select option" aria-label
-    // from the library
-    expect(vSelectInput.attributes('aria-label')).toBe('-');
-  });
 });

package/components/form/__tests__/UnitInput.test.ts

@@ -11,7 +11,7 @@ describe('component: UnitInput', () => {
     expect(wrapper.isVisible()).toBe(true);
   });
 
-  it.each(['blur', 'update:value'])('should emit input event when "%p" is fired', async(event) => {
+  it.each(['blur', 'change'])('should emit input event when "%p" is fired', async(event) => {
     const wrapper = mount(UnitInput, { props: { value: 1, delay: 0 } });
     const input = wrapper.find('input');
 
@@ -20,7 +20,7 @@ describe('component: UnitInput', () => {
     input.trigger(event);
 
     expect(wrapper.emitted('update:value')).toBeTruthy();
-    expect(wrapper.emitted('update:value')[1]).toStrictEqual([4]);
+    expect(wrapper.emitted('update:value')[2]).toStrictEqual([4]);
   });
 
   it.each([
@@ -184,7 +184,7 @@ describe('component: UnitInput', () => {
     input.trigger('blur');
 
     expect(wrapper.emitted('update:value')).toBeTruthy();
-    expect(wrapper.emitted('update:value')[0][0]).toBe(value);
+    expect(wrapper.emitted('update:value')[3][0]).toBe(value);
   });
 
   describe.each([
@@ -207,7 +207,7 @@ describe('component: UnitInput', () => {
       expect(inputElement.value).toBe('123');
     });
 
-    it.each(['update:value', 'blur'])('on %p 123 should display input value 123', async(trigger) => {
+    it.each(['input', 'blur'])('on %p 123 should display input value 123', async(trigger) => {
       const wrapper = mount(UnitInput, {
         props: {
           value: '0',
@@ -248,6 +248,7 @@ describe('component: UnitInput', () => {
       const input = wrapper.find('input');
 
       await input.trigger('update:value');
+      await input.trigger('input');
 
       expect(input.element.value).toBe('123');
     });

package/components/formatter/BadgeStateFormatter.vue

@@ -1,9 +1,8 @@
 <script>
 import { BadgeState } from '@components/BadgeState';
-import DotState from '@shell/components/DotState'
 import { colorForState, stateDisplay } from '@shell/plugins/dashboard-store/resource-class';
 export default {
-  components: { BadgeState, DotState },
+  components: { BadgeState },
   props:      {
     value: {
       type:    String,
@@ -50,17 +49,15 @@ export default {
 <template>
   <div>
     <div v-if="arbitrary">
-      <!-- <BadgeState
+      <BadgeState
         v-if="value"
         :color="stateBackground"
         :label="stateDisplay"
-      /> -->
-      <DotState  v-if="value" :color="stateBackground" :label="stateDisplay" />
+      />
     </div>
-    <!-- <BadgeState
+    <BadgeState
       v-else
       :value="row"
-    /> -->
-    <DotState v-else :value="row" />
+    />
   </div>
 </template>

package/components/formatter/ExtensionCache.vue

@@ -0,0 +1,74 @@
+<script>
+import { BadgeState } from '@components/BadgeState';
+import { stateDisplay } from '@shell/plugins/dashboard-store/resource-class';
+
+export default {
+  props: {
+    value: {
+      type:    String,
+      default: ''
+    }
+  },
+
+  components: { BadgeState },
+
+  data() {
+    const STATES = {
+      cached: {
+        color: 'info', icon: 'dot-open', label: 'Cached', compoundIcon: 'checkmark'
+      },
+      pending: {
+        color: 'warning', icon: 'tag', label: 'In Progress', compoundIcon: 'info'
+      },
+      disabled: {
+        color: 'error', icon: 'dot-half', label: 'Cache Disabled', compoundIcon: 'info'
+      },
+    };
+
+    return {
+      STATES,
+      stateDisplay:    '',
+      stateBackground: ''
+    };
+  },
+
+  watch: {
+    value: {
+      handler() {
+        const out = this.value || 'pending';
+        const color = this.colorForState(out);
+
+        this.stateDisplay = stateDisplay(out);
+        this.stateBackground = color.replace('text-', 'bg-');
+      },
+      immediate: true
+    }
+  },
+
+  methods: {
+    colorForState(state) {
+      const key = (state).toLowerCase();
+      let color;
+
+      if ( this.STATES[key] && this.STATES[key].color ) {
+        color = this.STATES[key].color;
+      }
+
+      if ( !color ) {
+        color = 'info';
+      }
+
+      return `text-${ color }`;
+    }
+  }
+};
+</script>
+
+<template>
+  <div>
+    <BadgeState
+      :color="stateBackground"
+      :label="stateDisplay"
+    />
+  </div>
+</template>

package/components/formatter/InternalExternalIP.vue

@@ -28,7 +28,6 @@ export default {
   <span>
     <template v-if="isIp(row.externalIp)">
       {{ row.externalIp }} <CopyToClipboard
-        :aria-label="t('internalExternalIP.copyExternalIp')"
         label-as="tooltip"
         :text="row.externalIp"
         class="icon-btn"
@@ -44,7 +43,6 @@ export default {
     </template>
     <template v-else-if="isIp(row.internalIp)">
       {{ row.internalIp }}<CopyToClipboard
-        :aria-label="t('internalExternalIP.copyInternalIp')"
         label-as="tooltip"
         :text="row.internalIp"
         class="icon-btn"

package/components/formatter/Port.vue

@@ -0,0 +1,24 @@
+<script>
+export default {
+  props: {
+    value: {
+      type:    Array,
+      default: () => []
+    }
+  },
+  data() {
+    const { hostPort = '', protocol = '' } = this.value[0] || {};
+
+    return { hostPort, protocol };
+  }
+};
+</script>
+
+<template>
+  <div v-if="hostPort">
+    {{ hostPort+'/'+protocol }}
+  </div>
+  <div v-else>
+    —
+  </div>
+</template>

package/components/formatter/SecretData.vue

@@ -13,25 +13,17 @@ export default {
     },
   },
 
-  beforeMount() {
+  data() {
     if (this.value.issuer) {
       const { cn, notAfter, sans = [] } = this.value;
 
-      this.expiration = notAfter;
-      this.sans = sans;
-      this.cn = cn;
-      this.isTLS = true;
+      return {
+        cn, expiration: notAfter, sans, isTLS: true
+      };
+    } else {
+      return { isTLS: false };
     }
   },
-
-  data() {
-    return {
-      isTLS:      false,
-      cn:         null,
-      sans:       [],
-      expiration: null,
-    };
-  },
   computed: {
     // use 'text-warning' or 'text-error' classes if the cert is <8 days from expiring or expired respectively
     dateClass() {
@@ -51,12 +43,7 @@ export default {
 
 <template>
   <div v-if="isTLS">
-    <t k="secret.certificate.cn" />
-    {{ cn }}
-    <span v-if="row.unrepeatedSans && row.unrepeatedSans.length">
-      {{ t('secret.certificate.plusMore', {n:row.unrepeatedSans.length}) }}
-    </span>
-    <br>
+    <t k="secret.certificate.cn" /> {{ cn }} <span v-if="row.unrepeatedSans && row.unrepeatedSans.length">{{ t('secret.certificate.plusMore', {n:row.unrepeatedSans.length}) }}</span><br>
     <t k="secret.certificate.expires" />: <DateComponent
       :class="dateClass"
       :value="expiration"

package/components/formatter/SecretType.vue

@@ -0,0 +1,41 @@
+<script>
+import { SERVICE_ACCOUNT } from '@shell/config/types';
+export default {
+  props: {
+    value: {
+      type:    [String, Object],
+      default: 'Opaque'
+    }
+  },
+  data() {
+    if (this.value.typeDisplay) {
+      this.findServiceAccount();
+
+      return { typeDisplay: this.value.typeDisplay, serviceAccountLink: null };
+    }
+
+    return { typeDisplay: this.value, serviceAccountLink: null };
+  },
+  methods: {
+    async findServiceAccount() {
+      const serviceAccount = await this.$store.dispatch('cluster/find', { type: SERVICE_ACCOUNT, id: this.value.serviceAccountID });
+
+      if (serviceAccount) {
+        this.serviceAccountLink = serviceAccount.detailLocation;
+      }
+    }
+  }
+};
+</script>>
+
+<template>
+  <router-link
+    v-if="serviceAccountLink"
+    :to="serviceAccountLink"
+  >
+    {{ typeDisplay }}
+  </router-link>
+  <div v-else>
+    {{ typeDisplay }}
+  </div>
+</template>

package/components/nav/Favorite.vue

@@ -10,9 +10,6 @@ export default {
   computed: {
     isFavorite() {
       return this.$store.getters['type-map/isFavorite'](this.resource);
-    },
-    ariaLabel() {
-      return this.t(`resourceDetail.masthead.ariaLabel.${ this.isFavorite ? 'unfavoriteAction' : 'favoriteAction' }`, { resource: this.resource });
     }
   },
 
@@ -31,11 +28,10 @@ export default {
 <template>
   <i
     :tabindex="0"
-    :aria-pressed="!!isFavorite"
+    :aria-checked="!!isFavorite"
     class="favorite icon"
     :class="{'icon-star-open': !isFavorite, 'icon-star': isFavorite}"
     aria-role="button"
-    :aria-label="ariaLabel"
     @click.stop.prevent="toggle"
     @keydown.enter.prevent="toggle"
     @keydown.space.prevent="toggle"

package/components/nav/Group.vue

@@ -158,17 +158,6 @@ export default {
         items = this.group;
       }
 
-      let parentPath = '';
-      const cluster = this.$route.params?.cluster;
-
-      // Where we use nested route configuration, consider the parent route when trying to identify the nav location
-      if (this.$route.matched.length > 1) {
-        const parentRoute = this.$route.matched[this.$route.matched.length - 2];
-
-        parentPath = parentRoute.path.replace(':cluster', cluster);
-        parentPath = parentPath === '/' ? undefined : parentPath;
-      }
-
       for (const item of items.children) {
         if (item.children && this.hasActiveRoute(item)) {
           return true;
@@ -177,11 +166,8 @@ export default {
           const matchesNavLevel = navLevels.filter((param) => !this.$route.params[param] || this.$route.params[param] !== item.route.params[param]).length === 0;
           const withoutHash = this.$route.hash ? this.$route.fullPath.slice(0, this.$route.fullPath.indexOf(this.$route.hash)) : this.$route.fullPath;
           const withoutQuery = withoutHash.split('?')[0];
-          const itemFullPath = this.$router.resolve(item.route).fullPath;
 
-          if (matchesNavLevel || itemFullPath === withoutQuery) {
-            return true;
-          } else if (parentPath && itemFullPath === parentPath) {
+          if (matchesNavLevel || this.$router.resolve(item.route).fullPath === withoutQuery) {
             return true;
           }
         }
@@ -245,11 +231,8 @@ export default {
         </router-link>
         <h6
           v-else
-           @click="peek($event, true)"
         >
-        <i :class="'nav-icon icon-'+group.name.replace(/\s+/g, '').toLowerCase()" />
-        {{ group.labelDisplay || group.label }}
-          <!-- <span v-clean-html="group.labelDisplay || group.label" /> -->
+          <span v-clean-html="group.labelDisplay || group.label" />
         </h6>
       </slot>
       <i
@@ -277,7 +260,7 @@ export default {
           v-if="child.divider"
           :key="idx"
         >
-          <hr role="none">
+          <hr>
         </li>
         <!-- <div v-else-if="child[childrenKey] && hideGroup(child[childrenKey])" :key="child.name">
           HIDDEN
@@ -359,28 +342,21 @@ export default {
       }
 
       &.active {
-        color: var(--nav-hover-color);
-        background-color: var(--nav-active);
+        color: var(--primary-hover-text);
+        background-color: var(--primary-hover-bg);
 
         h6 {
-          /* padding: 8px 0 8px 16px;
-          font-weight: bold; */
-          color: var(--nav-hover-color);
-        }
-        I{
-          color: var(--nav-hover-color);
+          padding: 8px 0 8px 16px;
+          font-weight: bold;
+          color: var(--primary-hover-text);
         }
 
-        /* &:hover {
+        &:hover {
           background-color: var(--primary-hover-bg);
-        } */
+        }
       }
       &:hover:not(.active) {
-        background-color: var(--nav-active);
-        color: var(--nav-hover-color);
-        h6{
-          color: var(--nav-hover-color);
-        }
+        background-color: var(--nav-hover);
       }
     }
   }
@@ -388,53 +364,49 @@ export default {
   .accordion {
     &.depth-0 {
       > .header {
-        /* padding: 8px 0; */
-        padding: 0px 0px 0px 20px;
-        height: 50px;
 
         &.noHover {
           cursor: default;
         }
 
         > H6 {
-          font-size: 14px;
           text-transform: none;
-          line-height: 50px;
-          display: flex;
-          align-items: center;
+          padding: 8px 0 8px 16px;
         }
 
         > I {
           position: absolute;
           right: 0;
           top: 0;
-          padding: 0px 20px 0px 0px;
+          padding: 10px 10px 9px 7px;
           user-select: none;
-          line-height: 50px;
         }
       }
 
       > .body {
         margin-left: 0;
       }
+
+      &.group-highlight {
+        background: var(--nav-active);
+      }
     }
 
     &.depth-1 {
       > .header {
+        padding-left: 20px;
         > H6 {
-          font-size: 13px;
-          line-height: 16px;
+          line-height: 18px;
           padding: 8px 0 7px 5px !important;
         }
         > I {
-          padding: 9px 7px 8px 7px !important;
+          padding: 10px 7px 9px 7px !important;
         }
       }
     }
 
     &:not(.depth-0) {
       > .header {
-        padding-left: 10px;
         > H6 {
           // Child groups that aren't linked themselves
           display: inline-block;
@@ -456,16 +428,13 @@ export default {
     padding: 0;
 
     A, A I {
-      /* color: var(--primary-hover-text); */
-      color: var(--nav-hover-color);
+      color: var(--primary-hover-text);
     }
 
     A {
-      background-color: var(--nav-active);
-      ::v-deep .icon {
-          /* color: var(--body-text); */
-          color: var(--nav-hover-color);
-        }
+      color: var(--primary-hover-text);
+      background-color: var(--primary-hover-bg);
+      font-weight: bold;
     }
   }
 
@@ -474,6 +443,9 @@ export default {
       border-left: solid 5px transparent;
       line-height: 16px;
       font-size: 14px;
+      padding-left: 24px;
+      display: flex;
+      justify-content: space-between;
     }
 
     A:focus {
@@ -487,9 +459,4 @@ export default {
       }
     }
   }
-  .nav-icon{
-    font-size: 32px;
-    margin-top: -11px;
-    color: #a8abb2;
-  }
 </style>