dart-decimate 0.0.63 → 0.0.65

This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
package/Cargo.lock CHANGED
@@ -102,7 +102,7 @@ checksum = "a31eee39dddec8330830986fcd7625edb5a24ec90ea038215273bbc3adb08ac6"
102
102
 
103
103
  [[package]]
104
104
  name = "dart-decimate"
105
- version = "0.0.63"
105
+ version = "0.0.65"
106
106
  dependencies = [
107
107
  "clap",
108
108
  "glob",
package/Cargo.toml CHANGED
@@ -1,6 +1,6 @@
1
1
  [package]
2
2
  name = "dart-decimate"
3
- version = "0.0.63"
3
+ version = "0.0.65"
4
4
  edition = "2024"
5
5
  rust-version = "1.90"
6
6
  description = "Rust-native codebase intelligence for Dart and Flutter module graphs."
package/README.md CHANGED
@@ -90,7 +90,7 @@ You do not need to install anything permanently. Use the command above.
90
90
  For repeatable automation, pin the version:
91
91
 
92
92
  ```bash
93
- pnpm dlx dart-decimate@0.0.63
93
+ pnpm dlx dart-decimate@0.0.65
94
94
  ```
95
95
 
96
96
  Add this to `package.json` if you want a short project command:
@@ -101,7 +101,7 @@ Add this to `package.json` if you want a short project command:
101
101
  "dart-decimate": "dart-decimate json ."
102
102
  },
103
103
  "devDependencies": {
104
- "dart-decimate": "0.0.63"
104
+ "dart-decimate": "0.0.65"
105
105
  }
106
106
  }
107
107
  ```
@@ -117,7 +117,7 @@ pnpm run dart-decimate
117
117
  If you prefer Cargo, install the matching tagged source:
118
118
 
119
119
  ```bash
120
- cargo install --git https://github.com/sgaabdu4/dart-decimate.git --tag v0.0.63 --locked
120
+ cargo install --git https://github.com/sgaabdu4/dart-decimate.git --tag v0.0.65 --locked
121
121
  ```
122
122
 
123
123
  The npm release `X.Y.Z` and Cargo tag `vX.Y.Z` are verified against each other
@@ -128,7 +128,7 @@ Confirm a Cargo build's version with:
128
128
 
129
129
  ```bash
130
130
  dart-decimate --version
131
- # dart-decimate 0.0.63
131
+ # dart-decimate 0.0.65
132
132
  ```
133
133
 
134
134
  ## pnpm dlx
@@ -539,7 +539,7 @@ Example shape:
539
539
  {
540
540
  "schema_version": "dart-decimate.report.v1",
541
541
  "kind": "combined",
542
- "tool": "dart-decimate 0.0.63",
542
+ "tool": "dart-decimate 0.0.65",
543
543
  "command": "check",
544
544
  "verdict": "fail",
545
545
  "summary": {
@@ -555,7 +555,7 @@ Example shape:
555
555
 
556
556
  The `dart-decimate.report.v1` field layout is unchanged. Its existing `tool`
557
557
  string includes the producing version so saved reports identify the exact
558
- build, for example `dart-decimate 0.0.63`.
558
+ build, for example `dart-decimate 0.0.65`.
559
559
 
560
560
  When grouped security findings hide additional occurrences, `next_steps` can
561
561
  include `review-security-surface`, which reruns
@@ -643,7 +643,7 @@ you need the installed binary's exact list.
643
643
  For a complete repository check, including discovered local packages:
644
644
 
645
645
  ```bash
646
- pnpm dlx dart-decimate@0.0.63 --strict
646
+ pnpm dlx dart-decimate@0.0.65 --strict
647
647
  ```
648
648
 
649
649
  This runs every enabled check from the repository root. The default duplication
@@ -686,7 +686,7 @@ This repository forbids `unsafe_code`.
686
686
 
687
687
  ## Release Flow
688
688
 
689
- Current source version: `0.0.63`.
689
+ Current source version: `0.0.65`.
690
690
 
691
691
  After the first public release, changes should go through pull requests. PRs to
692
692
  `main` must bump both `Cargo.toml` and `package.json` above the base branch and to
@@ -16,12 +16,10 @@ const root = path.resolve(__dirname, "../..");
16
16
  const exeExt = process.platform === "win32" ? ".exe" : "";
17
17
  const cargo = process.env.CARGO || "cargo";
18
18
  const cacheDir = path.join(root, "npm", "bin-cache");
19
- const packageJson = JSON.parse(
20
- fs.readFileSync(path.join(root, "package.json"), "utf8"),
21
- );
19
+ const packageVersion = readPackageVersion();
22
20
  const releaseBaseUrl =
23
21
  process.env.DART_DECIMATE_RELEASE_BASE_URL ||
24
- `https://github.com/sgaabdu4/dart-decimate/releases/download/v${packageJson.version}`;
22
+ `https://github.com/sgaabdu4/dart-decimate/releases/download/v${packageVersion}`;
25
23
 
26
24
  install()
27
25
  .then(() => process.exit(0))
@@ -30,6 +28,21 @@ install()
30
28
  process.exit(1);
31
29
  });
32
30
 
31
+ function readPackageVersion() {
32
+ const packageJson = JSON.parse(
33
+ fs.readFileSync(path.join(root, "package.json"), "utf8"),
34
+ );
35
+ const version =
36
+ packageJson instanceof Object && "version" in packageJson
37
+ ? packageJson.version
38
+ : undefined;
39
+ if (typeof version === "string") {
40
+ return version;
41
+ }
42
+ console.error("dart-decimate: install failed: package.json has no version");
43
+ process.exit(1);
44
+ }
45
+
33
46
  async function install() {
34
47
  fs.mkdirSync(cacheDir, { recursive: true });
35
48
 
package/package.json CHANGED
@@ -1,6 +1,6 @@
1
1
  {
2
2
  "name": "dart-decimate",
3
- "version": "0.0.63",
3
+ "version": "0.0.65",
4
4
  "description": "Rust-native codebase intelligence for Dart and Flutter module graphs.",
5
5
  "license": "MIT",
6
6
  "bin": {
@@ -46,7 +46,7 @@ fn skips_generated_and_non_library_files() -> Result<(), Box<dyn std::error::Err
46
46
  let gaps =
47
47
  detect_boundary_coverage(&project, &[BoundaryRule::new("lib/domain", "lib/ui")], &[]);
48
48
 
49
- assert!(gaps.is_empty());
49
+ assert_eq!(gaps, []);
50
50
 
51
51
  Ok(())
52
52
  }
package/src/cli/tests.rs CHANGED
@@ -293,7 +293,7 @@ fn open_html_rejects_explicit_non_html_format() -> Result<(), Box<dyn std::error
293
293
  };
294
294
 
295
295
  assert!(matches!(error, CliError::HtmlOpenRequiresHtml));
296
- assert!(output.is_empty());
296
+ assert_eq!(output, [] as [u8; 0]);
297
297
 
298
298
  Ok(())
299
299
  }
@@ -209,7 +209,7 @@ void main() {}\n",
209
209
  let Some(type_only_importers) = json["type_only_importers"].as_array() else {
210
210
  panic!("type_only_importers array");
211
211
  };
212
- assert!(type_only_importers.is_empty());
212
+ assert_eq!(type_only_importers, &Vec::<Value>::new());
213
213
  assert_eq!(json["declared_in"][0]["pubspec_path"], "pubspec.yaml");
214
214
  assert_eq!(json["declared_in"][0]["section"], "dependencies");
215
215
  assert_eq!(json["declared_in"][0]["line"], 3);
@@ -109,7 +109,7 @@ dev_dependencies:\n collection: ^1.0.0\n",
109
109
 
110
110
  let report = analyze_dependency_hygiene(&project)?;
111
111
 
112
- assert!(report.unlisted_dependencies.is_empty());
112
+ assert_eq!(report.unlisted_dependencies, []);
113
113
  assert_eq!(report.unused_dependencies.len(), 1);
114
114
  assert_eq!(report.unused_dependencies[0].dependency, "collection");
115
115
  assert_eq!(
@@ -140,7 +140,7 @@ dev_dependencies:\n args: ^2.0.0\n",
140
140
 
141
141
  let report = analyze_dependency_hygiene(&project)?;
142
142
 
143
- assert!(report.unlisted_dependencies.is_empty());
143
+ assert_eq!(report.unlisted_dependencies, []);
144
144
  assert_eq!(report.unused_dependencies.len(), 1);
145
145
  assert_eq!(
146
146
  report.unused_dependencies[0].issue,
@@ -203,8 +203,8 @@ dev_dependencies:\n test: ^1.0.0\n",
203
203
 
204
204
  let report = analyze_dependency_hygiene(&project)?;
205
205
 
206
- assert!(report.unlisted_dependencies.is_empty());
207
- assert!(report.unused_dependencies.is_empty());
206
+ assert_eq!(report.unlisted_dependencies, []);
207
+ assert_eq!(report.unused_dependencies, []);
208
208
 
209
209
  Ok(())
210
210
  }
@@ -312,7 +312,7 @@ dependency_overrides:\n stale: ^1.0.0\n",
312
312
  let report = analyze_dependency_hygiene(&project)?;
313
313
 
314
314
  assert_eq!(report.unused_dependencies.len(), 1);
315
- assert!(report.misconfigured_dependency_overrides.is_empty());
315
+ assert_eq!(report.misconfigured_dependency_overrides, []);
316
316
  assert_eq!(report.unused_dependencies[0].dependency, "stale");
317
317
  assert_eq!(
318
318
  report.unused_dependencies[0].issue,
@@ -380,8 +380,8 @@ dependency_overrides:\n patched: ^1.0.0\n",
380
380
 
381
381
  let report = analyze_dependency_hygiene(&project)?;
382
382
 
383
- assert!(report.unused_dependencies.is_empty());
384
- assert!(report.unlisted_dependencies.is_empty());
383
+ assert_eq!(report.unused_dependencies, []);
384
+ assert_eq!(report.unlisted_dependencies, []);
385
385
 
386
386
  Ok(())
387
387
  }
@@ -533,8 +533,8 @@ dependencies:\n collection: ^1.0.0\n",
533
533
 
534
534
  let report = analyze_dependency_hygiene(&project)?;
535
535
 
536
- assert!(report.unused_dependencies.is_empty());
537
- assert!(report.unlisted_dependencies.is_empty());
536
+ assert_eq!(report.unused_dependencies, []);
537
+ assert_eq!(report.unlisted_dependencies, []);
538
538
 
539
539
  Ok(())
540
540
  }
@@ -618,7 +618,7 @@ fn analyzes_workspace_packages_independently() -> Result<(), Box<dyn std::error:
618
618
 
619
619
  let report = analyze_dependency_hygiene(&project)?;
620
620
 
621
- assert!(report.unlisted_dependencies.is_empty());
621
+ assert_eq!(report.unlisted_dependencies, []);
622
622
  assert!(
623
623
  report
624
624
  .unused_dependencies
@@ -667,7 +667,7 @@ fn skips_nested_checkout_packages_and_sources() -> Result<(), Box<dyn std::error
667
667
  .iter()
668
668
  .all(|file| !file.path.to_string_lossy().contains("worktrees"))
669
669
  );
670
- assert!(report.unused_dependencies.is_empty());
670
+ assert_eq!(report.unused_dependencies, []);
671
671
 
672
672
  Ok(())
673
673
  }
@@ -690,7 +690,7 @@ fn skips_gitignored_nested_package_dependencies() -> Result<(), Box<dyn std::err
690
690
 
691
691
  assert_eq!(packages.len(), 1);
692
692
  assert_eq!(packages[0].name, "app");
693
- assert!(report.unused_dependencies.is_empty());
693
+ assert_eq!(report.unused_dependencies, []);
694
694
 
695
695
  Ok(())
696
696
  }
@@ -718,7 +718,7 @@ fn reports_dev_dependency_in_production_for_owning_workspace_package()
718
718
 
719
719
  let report = analyze_dependency_hygiene(&project)?;
720
720
 
721
- assert!(report.unlisted_dependencies.is_empty());
721
+ assert_eq!(report.unlisted_dependencies, []);
722
722
  assert_eq!(report.unused_dependencies.len(), 1);
723
723
  assert_eq!(report.unused_dependencies[0].package, "app");
724
724
  assert!(
@@ -76,7 +76,7 @@ fn filters_short_blocks_and_generated_files() -> Result<(), Box<dyn std::error::
76
76
 
77
77
  let report = detect_duplicates(&project, &options(DuplicateMode::Semantic, 1, 24))?;
78
78
 
79
- assert!(report.clone_groups.is_empty());
79
+ assert_eq!(report.clone_groups, []);
80
80
 
81
81
  Ok(())
82
82
  }
@@ -136,7 +136,7 @@ fn copied_package_filter_ignores_unrelated_malformed_pubspec()
136
136
 
137
137
  let report = detect_duplicates(&project, &DuplicateOptions::default())?;
138
138
 
139
- assert!(report.clone_groups.is_empty());
139
+ assert_eq!(report.clone_groups, []);
140
140
 
141
141
  Ok(())
142
142
  }
@@ -374,7 +374,7 @@ fn assert_fingerprint_collision_is_not_a_clone(
374
374
 
375
375
  let project = scan_project(fixture.path())?;
376
376
  let report = detect_duplicates(&project, &options)?;
377
- assert!(report.clone_groups.is_empty());
377
+ assert_eq!(report.clone_groups, []);
378
378
 
379
379
  write(&fixture, "lib/exact_copy.dart", first_source)?;
380
380
  let project = scan_project(fixture.path())?;
@@ -61,7 +61,7 @@ fn skips_comments_and_generated_files() -> Result<(), Box<dyn std::error::Error>
61
61
 
62
62
  let report = detect_feature_flags(&project, &FeatureFlagOptions::default())?;
63
63
 
64
- assert!(report.flags.is_empty());
64
+ assert_eq!(report.flags, []);
65
65
  assert_eq!(report.total_occurrences, 0);
66
66
 
67
67
  Ok(())
@@ -27,7 +27,7 @@ fn builds_edges_for_library_augment_directives() -> Result<(), Box<dyn std::erro
27
27
  strip_root(fixture.root(), &dependencies[0].to_path),
28
28
  "lib/base.dart"
29
29
  );
30
- assert!(graph.unresolved().is_empty());
30
+ assert_eq!(graph.unresolved(), []);
31
31
 
32
32
  Ok(())
33
33
  }
@@ -118,7 +118,7 @@ fn duplicate_part_directives_in_same_library_are_deduped() -> Result<(), Box<dyn
118
118
  let graph = build_module_graph(fixture.root(), &[library, generated])?;
119
119
 
120
120
  assert_eq!(graph.edge_count(), 1);
121
- assert!(graph.invalid_part_relationships().is_empty());
121
+ assert_eq!(graph.invalid_part_relationships(), []);
122
122
 
123
123
  Ok(())
124
124
  }
@@ -59,7 +59,7 @@ fn resolves_package_imports_using_ancestor_package_config_from_member_root()
59
59
  strip_root(fixture.path(), &graph.dependencies()[0].to_path),
60
60
  PathBuf::from("packages/shared/lib/shared.dart")
61
61
  );
62
- assert!(graph.unresolved().is_empty());
62
+ assert_eq!(graph.unresolved(), []);
63
63
 
64
64
  Ok(())
65
65
  }
@@ -92,7 +92,7 @@ fn nested_pubspec_missing_path_dependency_does_not_use_ancestor_package_config()
92
92
  let graph = build_module_graph(fixture.path(), &[worker, shared])?;
93
93
 
94
94
  assert_eq!(graph.edge_count(), 0);
95
- assert!(graph.unresolved().is_empty());
95
+ assert_eq!(graph.unresolved(), []);
96
96
 
97
97
  Ok(())
98
98
  }
@@ -124,7 +124,7 @@ fn nested_pubspec_missing_path_dependency_ignores_unowned_nested_pubspec()
124
124
  let graph = build_module_graph(fixture.path(), &[worker, shared])?;
125
125
 
126
126
  assert_eq!(graph.edge_count(), 0);
127
- assert!(graph.unresolved().is_empty());
127
+ assert_eq!(graph.unresolved(), []);
128
128
 
129
129
  Ok(())
130
130
  }
@@ -53,7 +53,7 @@ fn pubspec_overrides_workspace_replaces_pubspec_workspace() -> Result<(), Box<dy
53
53
  let graph = build_module_graph(fixture.root(), &[main, shared])?;
54
54
 
55
55
  assert_eq!(graph.package_names(), vec!["root", "shared"]);
56
- assert!(graph.unresolved().is_empty());
56
+ assert_eq!(graph.unresolved(), []);
57
57
 
58
58
  Ok(())
59
59
  }
@@ -27,7 +27,7 @@ fn builds_edges_for_relative_imports_and_exports() -> Result<(), Box<dyn std::er
27
27
 
28
28
  assert_eq!(graph.node_count(), 4);
29
29
  assert_eq!(graph.edge_count(), 3);
30
- assert!(graph.unresolved().is_empty());
30
+ assert_eq!(graph.unresolved(), []);
31
31
  assert_eq!(
32
32
  graph
33
33
  .dependencies()
@@ -124,7 +124,7 @@ fn platform_environment_selects_one_configurable_import_branch()
124
124
  strip_root(fixture.root(), &dependencies[0].to_path),
125
125
  "lib/web.dart"
126
126
  );
127
- assert!(graph.unresolved().is_empty());
127
+ assert_eq!(graph.unresolved(), []);
128
128
 
129
129
  Ok(())
130
130
  }
@@ -161,7 +161,7 @@ fn platform_environment_falls_back_to_default_configurable_import()
161
161
  strip_root(fixture.root(), &dependencies[0].to_path),
162
162
  "lib/io.dart"
163
163
  );
164
- assert!(graph.unresolved().is_empty());
164
+ assert_eq!(graph.unresolved(), []);
165
165
 
166
166
  Ok(())
167
167
  }
@@ -198,7 +198,7 @@ fn platform_environment_selects_package_uri_branches_before_resolution()
198
198
  strip_root(fixture.root(), &dependencies[0].to_path),
199
199
  "packages/shared/lib/web.dart"
200
200
  );
201
- assert!(graph.unresolved().is_empty());
201
+ assert_eq!(graph.unresolved(), []);
202
202
 
203
203
  Ok(())
204
204
  }
@@ -229,7 +229,7 @@ fn default_graph_keeps_all_configurable_import_branches() -> Result<(), Box<dyn
229
229
  .collect::<Vec<_>>(),
230
230
  vec!["io.dart".to_owned(), "web.dart".to_owned()]
231
231
  );
232
- assert!(graph.unresolved().is_empty());
232
+ assert_eq!(graph.unresolved(), []);
233
233
 
234
234
  Ok(())
235
235
  }
@@ -276,7 +276,7 @@ fn resolves_package_imports_using_package_config_root_uri_and_package_uri()
276
276
  "packages/generated/src/api.dart".to_owned(),
277
277
  ]
278
278
  );
279
- assert!(graph.unresolved().is_empty());
279
+ assert_eq!(graph.unresolved(), []);
280
280
 
281
281
  Ok(())
282
282
  }
@@ -372,7 +372,7 @@ fn package_config_hosted_entries_remain_external() -> Result<(), Box<dyn std::er
372
372
  let graph = build_module_graph(fixture.root(), &[main])?;
373
373
 
374
374
  assert_eq!(graph.edge_count(), 0);
375
- assert!(graph.unresolved().is_empty());
375
+ assert_eq!(graph.unresolved(), []);
376
376
 
377
377
  Ok(())
378
378
  }
@@ -406,7 +406,7 @@ fn package_config_prevents_nested_same_name_fallback() -> Result<(), Box<dyn std
406
406
  let graph = build_module_graph(fixture.root(), &[main, nested])?;
407
407
 
408
408
  assert_eq!(graph.edge_count(), 0);
409
- assert!(graph.unresolved().is_empty());
409
+ assert_eq!(graph.unresolved(), []);
410
410
 
411
411
  Ok(())
412
412
  }
@@ -437,7 +437,7 @@ fn package_config_owned_import_missing_from_config_ignores_nested_pubspec()
437
437
  let graph = build_module_graph(fixture.root(), &[main, nested])?;
438
438
 
439
439
  assert_eq!(graph.edge_count(), 0);
440
- assert!(graph.unresolved().is_empty());
440
+ assert_eq!(graph.unresolved(), []);
441
441
 
442
442
  Ok(())
443
443
  }
@@ -606,7 +606,7 @@ fn builds_edges_for_part_directives() -> Result<(), Box<dyn std::error::Error>>
606
606
  let graph = build_module_graph(fixture.root(), &[library, generated])?;
607
607
 
608
608
  assert_eq!(graph.edge_count(), 1);
609
- assert!(graph.invalid_part_relationships().is_empty());
609
+ assert_eq!(graph.invalid_part_relationships(), []);
610
610
  assert_eq!(graph.dependencies()[0].kind, DependencyKind::Part);
611
611
  assert_eq!(
612
612
  strip_root(fixture.root(), &graph.dependencies()[0].to_path),
@@ -763,7 +763,7 @@ fn resolves_package_imports_to_nested_local_pubspecs() -> Result<(), Box<dyn std
763
763
 
764
764
  assert_eq!(graph.package_names(), vec!["app", "repo"]);
765
765
  assert_eq!(graph.edge_count(), 1);
766
- assert!(graph.unresolved().is_empty());
766
+ assert_eq!(graph.unresolved(), []);
767
767
 
768
768
  Ok(())
769
769
  }
@@ -25,7 +25,7 @@ fn directive_uri_paths_are_percent_decoded_for_graph_resolution()
25
25
 
26
26
  let graph = build_module_graph(fixture.root(), &[main, local, shared])?;
27
27
 
28
- assert!(graph.unresolved().is_empty());
28
+ assert_eq!(graph.unresolved(), []);
29
29
  assert_eq!(
30
30
  graph
31
31
  .dependencies()
@@ -213,8 +213,8 @@ end_of_record
213
213
  },
214
214
  )?;
215
215
 
216
- assert!(report.coverage_gaps.is_empty());
217
- assert!(report.crap.is_empty());
216
+ assert_eq!(report.coverage_gaps, []);
217
+ assert_eq!(report.crap, []);
218
218
  assert_eq!(report.max_crap_score, 0);
219
219
 
220
220
  Ok(())
@@ -245,7 +245,7 @@ fn reports_functions_above_the_default_unit_size() -> Result<(), Box<dyn std::er
245
245
  report.large_functions[0].kind,
246
246
  ComplexityFunctionKind::Function
247
247
  );
248
- assert!(report.complexity.is_empty());
248
+ assert_eq!(report.complexity, []);
249
249
 
250
250
  Ok(())
251
251
  }
@@ -274,7 +274,7 @@ fn unit_size_override_can_suppress_a_matching_function() -> Result<(), Box<dyn s
274
274
 
275
275
  let report = analyze_health(&project, &options)?;
276
276
 
277
- assert!(report.large_functions.is_empty());
277
+ assert_eq!(report.large_functions, []);
278
278
  assert_eq!(
279
279
  report.threshold_overrides[0].status,
280
280
  HealthThresholdOverrideStatus::Active
@@ -34,8 +34,7 @@ struct SuppressionState {
34
34
  reported: Vec<ReportedFinding>,
35
35
  }
36
36
 
37
- /// The identity a directive needs to decide whether it merely sits on the
38
- /// wrong line rather than covering nothing at all.
37
+ /// Tells a misplaced directive from one that covers nothing.
39
38
  #[derive(Debug)]
40
39
  struct ReportedFinding {
41
40
  path: String,
@@ -126,9 +125,7 @@ impl SuppressionState {
126
125
  .collect()
127
126
  }
128
127
 
129
- /// Where the directive's own rules still fire in the same file. A clone
130
- /// group anchors on the common token run, so a directive can miss the line
131
- /// it was written for while the finding it names is very much alive.
128
+ /// Nearest line where the directive's rules still fire; clone groups anchor on the token run.
132
129
  fn nearest_match(
133
130
  &self,
134
131
  key: &SuppressionKey,
@@ -145,8 +142,7 @@ impl SuppressionState {
145
142
  .any(|rule| rule_matches_kind(rule, &finding.rule_id, finding.kind))
146
143
  })
147
144
  .map(|finding| finding.line)
148
- // Ties break toward the lower line, so the message does not depend
149
- // on the order findings happen to arrive in.
145
+ // Ties break toward the lower line so the message is order-independent.
150
146
  .min_by_key(|line| (line.abs_diff(key.line), *line))
151
147
  }
152
148
 
@@ -286,22 +282,18 @@ struct ParsedSuppression {
286
282
 
287
283
  fn parse_suppression(line: &str) -> Option<ParsedSuppression> {
288
284
  let comment = line.trim_start().strip_prefix("//")?.trim_start();
289
- for directive in ["dart-decimate-ignore-next-line"] {
290
- if let Some(rest) = comment.strip_prefix(directive)
291
- && rest.chars().next().is_none_or(char::is_whitespace)
292
- {
293
- let (rules, reason) = split_reason(rest.trim_start());
294
- return Some(ParsedSuppression {
295
- rules: rules
296
- .split(|character: char| character == ',' || character.is_whitespace())
297
- .filter(|rule| !rule.is_empty())
298
- .map(str::to_owned)
299
- .collect(),
300
- has_reason: reason.is_some_and(|value| !value.trim().is_empty()),
301
- });
302
- }
303
- }
304
- None
285
+ let rest = comment
286
+ .strip_prefix("dart-decimate-ignore-next-line")
287
+ .filter(|rest| rest.chars().next().is_none_or(char::is_whitespace))?;
288
+ let (rules, reason) = split_reason(rest.trim_start());
289
+ Some(ParsedSuppression {
290
+ rules: rules
291
+ .split(|character: char| character == ',' || character.is_whitespace())
292
+ .filter(|rule| !rule.is_empty())
293
+ .map(str::to_owned)
294
+ .collect(),
295
+ has_reason: reason.is_some_and(|value| !value.trim().is_empty()),
296
+ })
305
297
  }
306
298
 
307
299
  fn split_reason(rest: &str) -> (&str, Option<&str>) {
package/src/routes.rs CHANGED
@@ -230,7 +230,7 @@ mod tests {
230
230
 
231
231
  let report = detect_route_collisions(&project);
232
232
 
233
- assert!(report.collisions.is_empty());
233
+ assert_eq!(report.collisions, []);
234
234
  Ok(())
235
235
  }
236
236
 
@@ -254,7 +254,7 @@ class OrderRoute extends GoRouteData {}
254
254
 
255
255
  let report = detect_route_collisions(&project);
256
256
 
257
- assert!(report.collisions.is_empty());
257
+ assert_eq!(report.collisions, []);
258
258
  Ok(())
259
259
  }
260
260
 
@@ -274,7 +274,7 @@ class OrderRoute extends GoRouteData {}
274
274
 
275
275
  let report = detect_route_collisions(&project);
276
276
 
277
- assert!(report.collisions.is_empty());
277
+ assert_eq!(report.collisions, []);
278
278
  Ok(())
279
279
  }
280
280
 
@@ -312,7 +312,7 @@ final router = GoRouter(routes: [
312
312
 
313
313
  let report = detect_route_collisions(&project);
314
314
 
315
- assert!(report.collisions.is_empty());
315
+ assert_eq!(report.collisions, []);
316
316
  Ok(())
317
317
  }
318
318
 
@@ -335,7 +335,7 @@ final router = GoRouter(routes: [
335
335
 
336
336
  let report = detect_route_collisions(&project);
337
337
 
338
- assert!(report.collisions.is_empty());
338
+ assert_eq!(report.collisions, []);
339
339
  Ok(())
340
340
  }
341
341
 
package/src/scan/tests.rs CHANGED
@@ -70,7 +70,7 @@ fn scans_local_path_dependencies_for_graph_resolution() -> Result<(), Box<dyn st
70
70
 
71
71
  assert_eq!(project.files.len(), 2);
72
72
  assert_eq!(project.graph.edge_count(), 1);
73
- assert!(project.graph.unresolved().is_empty());
73
+ assert_eq!(project.graph.unresolved(), []);
74
74
 
75
75
  Ok(())
76
76
  }
@@ -102,7 +102,7 @@ fn scans_local_package_config_roots_for_graph_resolution() -> Result<(), Box<dyn
102
102
 
103
103
  assert_eq!(project.files.len(), 2);
104
104
  assert_eq!(project.graph.edge_count(), 1);
105
- assert!(project.graph.unresolved().is_empty());
105
+ assert_eq!(project.graph.unresolved(), []);
106
106
 
107
107
  Ok(())
108
108
  }
@@ -152,7 +152,7 @@ fn scans_workspace_package_config_from_member_root() -> Result<(), Box<dyn std::
152
152
 
153
153
  assert_eq!(project.files.len(), 2);
154
154
  assert_eq!(project.graph.edge_count(), 1);
155
- assert!(project.graph.unresolved().is_empty());
155
+ assert_eq!(project.graph.unresolved(), []);
156
156
 
157
157
  Ok(())
158
158
  }
@@ -187,7 +187,7 @@ fn does_not_scan_pub_cache_package_config_roots() -> Result<(), Box<dyn std::err
187
187
 
188
188
  assert_eq!(project.files.len(), 1);
189
189
  assert_eq!(project.graph.edge_count(), 0);
190
- assert!(project.graph.unresolved().is_empty());
190
+ assert_eq!(project.graph.unresolved(), []);
191
191
 
192
192
  Ok(())
193
193
  }
@@ -216,7 +216,7 @@ fn scans_pub_workspace_member_files() -> Result<(), Box<dyn std::error::Error>>
216
216
 
217
217
  assert_eq!(project.files.len(), 2);
218
218
  assert_eq!(project.graph.edge_count(), 1);
219
- assert!(project.graph.unresolved().is_empty());
219
+ assert_eq!(project.graph.unresolved(), []);
220
220
 
221
221
  Ok(())
222
222
  }
@@ -350,7 +350,7 @@ fn existing_ignored_dependency_targets_are_not_unresolved() -> Result<(), Box<dy
350
350
  assert_eq!(project.files.len(), 1);
351
351
  assert_eq!(project.graph.node_count(), 1);
352
352
  assert_eq!(project.graph.edge_count(), 0);
353
- assert!(project.graph.unresolved().is_empty());
353
+ assert_eq!(project.graph.unresolved(), []);
354
354
  Ok(())
355
355
  }
356
356
 
@@ -369,7 +369,7 @@ fn scans_all_conditional_import_targets() -> Result<(), Box<dyn std::error::Erro
369
369
  let project = scan_project(fixture.path())?;
370
370
 
371
371
  assert_eq!(project.graph.edge_count(), 2);
372
- assert!(project.graph.unresolved().is_empty());
372
+ assert_eq!(project.graph.unresolved(), []);
373
373
 
374
374
  Ok(())
375
375
  }
@@ -99,7 +99,7 @@ Future<void> query(dynamic db, String id) => db.rawQuery('SELECT * FROM users WH
99
99
  let project = scan_project(fixture.path())?;
100
100
  let report = analyze_security(&project, &SecurityOptions::default(), None)?;
101
101
 
102
- assert!(report.candidates.is_empty());
102
+ assert_eq!(report.candidates, []);
103
103
  assert_eq!(report.total_occurrences, 0);
104
104
 
105
105
  Ok(())
@@ -137,7 +137,7 @@ class Copy {
137
137
  let project = scan_project(fixture.path())?;
138
138
  let report = analyze_security(&project, &SecurityOptions::default(), None)?;
139
139
 
140
- assert!(report.candidates.is_empty());
140
+ assert_eq!(report.candidates, []);
141
141
  assert_eq!(report.total_occurrences, 0);
142
142
 
143
143
  Ok(())
@@ -162,7 +162,7 @@ void main() {
162
162
  let project = scan_project(fixture.path())?;
163
163
  let report = analyze_security(&project, &SecurityOptions::default(), None)?;
164
164
 
165
- assert!(report.candidates.is_empty());
165
+ assert_eq!(report.candidates, []);
166
166
  assert_eq!(report.total_occurrences, 0);
167
167
 
168
168
  Ok(())
@@ -369,7 +369,7 @@ const emptyOptions = FirebaseOptions(apiKey: '', appId: '1:123:web:def');
369
369
  let project = scan_project(fixture.path())?;
370
370
  let report = analyze_security(&project, &SecurityOptions::default(), None)?;
371
371
 
372
- assert!(report.candidates.is_empty());
372
+ assert_eq!(report.candidates, []);
373
373
  assert_eq!(report.total_occurrences, 0);
374
374
 
375
375
  Ok(())
@@ -508,7 +508,7 @@ fn skips_javascript_password_autofill_when_assignment_is_not_literal()
508
508
  let project = scan_project(fixture.path())?;
509
509
  let report = analyze_security(&project, &SecurityOptions::default(), None)?;
510
510
 
511
- assert!(report.candidates.is_empty());
511
+ assert_eq!(report.candidates, []);
512
512
  assert_eq!(report.total_occurrences, 0);
513
513
 
514
514
  Ok(())
@@ -531,7 +531,7 @@ fn skips_javascript_password_autofill_when_password_hint_is_unrelated()
531
531
  let project = scan_project(fixture.path())?;
532
532
  let report = analyze_security(&project, &SecurityOptions::default(), None)?;
533
533
 
534
- assert!(report.candidates.is_empty());
534
+ assert_eq!(report.candidates, []);
535
535
  assert_eq!(report.total_occurrences, 0);
536
536
 
537
537
  Ok(())
@@ -554,7 +554,7 @@ fn skips_javascript_password_autofill_when_value_target_is_unrelated()
554
554
  let project = scan_project(fixture.path())?;
555
555
  let report = analyze_security(&project, &SecurityOptions::default(), None)?;
556
556
 
557
- assert!(report.candidates.is_empty());
557
+ assert_eq!(report.candidates, []);
558
558
  assert_eq!(report.total_occurrences, 0);
559
559
 
560
560
  Ok(())
@@ -578,7 +578,7 @@ fn skips_javascript_password_autofill_when_password_hint_is_negative()
578
578
  let project = scan_project(fixture.path())?;
579
579
  let report = analyze_security(&project, &SecurityOptions::default(), None)?;
580
580
 
581
- assert!(report.candidates.is_empty());
581
+ assert_eq!(report.candidates, []);
582
582
  assert_eq!(report.total_occurrences, 0);
583
583
 
584
584
  Ok(())
@@ -601,7 +601,7 @@ fn skips_javascript_password_autofill_when_target_selector_is_negative()
601
601
  let project = scan_project(fixture.path())?;
602
602
  let report = analyze_security(&project, &SecurityOptions::default(), None)?;
603
603
 
604
- assert!(report.candidates.is_empty());
604
+ assert_eq!(report.candidates, []);
605
605
  assert_eq!(report.total_occurrences, 0);
606
606
 
607
607
  Ok(())
@@ -625,7 +625,7 @@ fn skips_javascript_password_autofill_when_only_parent_target_is_password_named(
625
625
  let project = scan_project(fixture.path())?;
626
626
  let report = analyze_security(&project, &SecurityOptions::default(), None)?;
627
627
 
628
- assert!(report.candidates.is_empty());
628
+ assert_eq!(report.candidates, []);
629
629
  assert_eq!(report.total_occurrences, 0);
630
630
 
631
631
  Ok(())
@@ -63,7 +63,7 @@ fn skips_private_entry_generated_and_dead_file_declarations()
63
63
 
64
64
  let report = analyze_unused_exports(&project, &dead_code);
65
65
 
66
- assert!(report.unused_exports.is_empty());
66
+ assert_eq!(report.unused_exports, []);
67
67
 
68
68
  Ok(())
69
69
  }
@@ -82,7 +82,7 @@ fn include_entry_exports_reports_entry_declarations_except_main()
82
82
  let dead_code = find_dead_code(&project.graph, ["lib/main.dart"]);
83
83
 
84
84
  let default_report = analyze_symbols(&project, Some(&dead_code));
85
- assert!(default_report.unused_exports.is_empty());
85
+ assert_eq!(default_report.unused_exports, []);
86
86
 
87
87
  let report = analyze_symbols_with_options(
88
88
  &project,
@@ -152,7 +152,7 @@ fn treats_public_library_part_declarations_as_api_usage() -> Result<(), Box<dyn
152
152
 
153
153
  let report = analyze_unused_exports(&project, &dead_code);
154
154
 
155
- assert!(report.unused_exports.is_empty());
155
+ assert_eq!(report.unused_exports, []);
156
156
 
157
157
  Ok(())
158
158
  }
@@ -265,7 +265,7 @@ fn skips_enum_constants_on_public_api_enums() -> Result<(), Box<dyn std::error::
265
265
 
266
266
  let report = analyze_unused_exports(&project, &dead_code);
267
267
 
268
- assert!(report.unused_members.is_empty());
268
+ assert_eq!(report.unused_members, []);
269
269
 
270
270
  Ok(())
271
271
  }
@@ -480,7 +480,7 @@ fn duplicate_exports_respect_show_and_hide() -> Result<(), Box<dyn std::error::E
480
480
 
481
481
  let report = analyze_symbols(&project, None);
482
482
 
483
- assert!(report.duplicate_exports.is_empty());
483
+ assert_eq!(report.duplicate_exports, []);
484
484
 
485
485
  Ok(())
486
486
  }
@@ -549,7 +549,7 @@ fn duplicate_exports_respect_show_hide_at_each_chain_hop() -> Result<(), Box<dyn
549
549
 
550
550
  let report = analyze_symbols(&project, None);
551
551
 
552
- assert!(report.duplicate_exports.is_empty());
552
+ assert_eq!(report.duplicate_exports, []);
553
553
 
554
554
  Ok(())
555
555
  }
@@ -569,7 +569,7 @@ fn does_not_treat_private_src_barrel_as_public_surface() -> Result<(), Box<dyn s
569
569
 
570
570
  let report = analyze_symbols(&project, None);
571
571
 
572
- assert!(report.duplicate_exports.is_empty());
572
+ assert_eq!(report.duplicate_exports, []);
573
573
 
574
574
  Ok(())
575
575
  }
@@ -681,7 +681,7 @@ fn private_type_leaks_require_same_dart_library_private_type()
681
681
  },
682
682
  );
683
683
 
684
- assert!(report.private_type_leaks.is_empty());
684
+ assert_eq!(report.private_type_leaks, []);
685
685
 
686
686
  Ok(())
687
687
  }
@@ -712,7 +712,7 @@ class _Hidden {}
712
712
  },
713
713
  );
714
714
 
715
- assert!(report.private_type_leaks.is_empty());
715
+ assert_eq!(report.private_type_leaks, []);
716
716
 
717
717
  Ok(())
718
718
  }
@@ -32,7 +32,7 @@ fn traces_file_dependencies_importers_exports_and_declarations()
32
32
  assert_eq!(report.declarations[0].name, "Barrel");
33
33
  assert_eq!(report.imported_by[0].from, "lib/main.dart");
34
34
  assert_eq!(report.re_exports[0].to, "lib/src/api.dart");
35
- assert!(report.imports_from.is_empty());
35
+ assert_eq!(report.imports_from, []);
36
36
 
37
37
  Ok(())
38
38
  }
@@ -102,7 +102,7 @@ fn traces_unused_symbol_without_marking_it_deleted() -> Result<(), Box<dyn std::
102
102
 
103
103
  assert!(report.found);
104
104
  assert!(report.reachable_file);
105
- assert!(report.direct_references.is_empty());
105
+ assert_eq!(report.direct_references, []);
106
106
  assert_eq!(report.reason, "symbol has no reachable direct references");
107
107
 
108
108
  Ok(())
@@ -134,7 +134,7 @@ fn trace_symbol_re_export_chains_respect_show_hide() -> Result<(), Box<dyn std::
134
134
  let hidden = trace_symbol(&project, &dead_code, "lib/src/api.dart", "HiddenApi");
135
135
 
136
136
  assert_eq!(public.re_export_chains.len(), 1);
137
- assert!(hidden.re_export_chains.is_empty());
137
+ assert_eq!(hidden.re_export_chains, Vec::<Vec<String>>::new());
138
138
 
139
139
  Ok(())
140
140
  }
@@ -164,7 +164,7 @@ void main() {}\n",
164
164
  assert!(report.is_used);
165
165
  assert!(!report.used_in_scripts);
166
166
  assert_eq!(report.total_import_count, 2);
167
- assert!(report.type_only_importers.is_empty());
167
+ assert_eq!(report.type_only_importers, []);
168
168
  assert_eq!(report.declared_in[0].pubspec_path, "pubspec.yaml");
169
169
  assert_eq!(
170
170
  report.declared_in[0].section,
@@ -193,8 +193,8 @@ fn traces_missing_pub_dependency_without_failing() -> Result<(), Box<dyn std::er
193
193
  assert!(!report.declared);
194
194
  assert!(!report.is_used);
195
195
  assert_eq!(report.total_import_count, 0);
196
- assert!(report.declared_in.is_empty());
197
- assert!(report.importing_files.is_empty());
196
+ assert_eq!(report.declared_in, []);
197
+ assert_eq!(report.importing_files, []);
198
198
 
199
199
  Ok(())
200
200
  }
@@ -437,19 +437,46 @@ fn function_expression_body_constructor_name(node: Node<'_>, source: &str) -> Op
437
437
  if node.kind() != "call_expression" {
438
438
  return None;
439
439
  }
440
- let function = node.child_by_field_name("function")?;
440
+ let callee = node.child_by_field_name("function")?;
441
+ let (function, named_constructor) = if callee.kind() == "member_expression" {
442
+ (
443
+ callee.child_by_field_name("object")?,
444
+ Some(callee.child_by_field_name("property")?),
445
+ )
446
+ } else {
447
+ (callee, None)
448
+ };
441
449
  if function.kind() != "function_expression" {
442
450
  return None;
443
451
  }
444
452
  let body = function.child_by_field_name("body")?;
445
453
  let mut expression = body.named_child(0)?;
446
454
  while expression.kind() == "conditional_expression" {
447
- expression = expression.named_children(&mut expression.walk()).last()?;
455
+ expression = expression.child_by_field_name("alternative")?;
456
+ }
457
+ if let Some(named_constructor) = named_constructor {
458
+ return split_closure_body_named_constructor(expression, named_constructor, source);
448
459
  }
449
460
  constructor_call_type_name(expression, source)
450
461
  .or_else(|| split_closure_body_constructor_name(node, expression, source))
451
462
  }
452
463
 
464
+ fn split_closure_body_named_constructor(
465
+ expression: Node<'_>,
466
+ named_constructor: Node<'_>,
467
+ source: &str,
468
+ ) -> Option<String> {
469
+ if !matches!(expression.kind(), "identifier" | "type_identifier") {
470
+ return None;
471
+ }
472
+ let constructor = format!(
473
+ "{}.{}",
474
+ expression.utf8_text(source.as_bytes()).ok()?,
475
+ named_constructor.utf8_text(source.as_bytes()).ok()?
476
+ );
477
+ (!constructor_name_candidates(&constructor).is_empty()).then_some(constructor)
478
+ }
479
+
453
480
  fn constructor_call_type_name(node: Node<'_>, source: &str) -> Option<String> {
454
481
  if !is_object_constructor(node) {
455
482
  return None;
@@ -780,8 +807,14 @@ mod tests {
780
807
 
781
808
  #[test]
782
809
  fn constructor_name_candidates_ignore_lowercase_calls() {
783
- assert!(constructor_name_candidates("buildHeader").is_empty());
784
- assert!(constructor_name_candidates("context.watch").is_empty());
810
+ assert_eq!(
811
+ constructor_name_candidates("buildHeader"),
812
+ Vec::<String>::new()
813
+ );
814
+ assert_eq!(
815
+ constructor_name_candidates("context.watch"),
816
+ Vec::<String>::new()
817
+ );
785
818
  }
786
819
 
787
820
  #[test]