danger 14.0.5 → 14.0.6

This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
package/CHANGELOG.md CHANGED
@@ -18,6 +18,12 @@
18
18
 
19
19
  <!-- Your comment above this -->
20
20
 
21
+ ## 14.0.6
22
+
23
+ The prebuilt macOS binaries (what `brew install danger/tap/danger-js` gives you) now embed node 24 instead of node 18.
24
+ Those binaries ship their own copy of node, and the old one was too old for the networking library Danger uses, so every
25
+ call to GitHub failed with `TypeError: terminated`. They work again. - [@orta]
26
+
21
27
  ## 14.0.0-5
22
28
 
23
29
  Release faff as I migrate to OIDC deploys for danger - orta
package/README.md CHANGED
@@ -101,12 +101,16 @@ repository ruleset, so the set of people who can ship a release is that ruleset'
101
101
 
102
102
  - Checkout the `main` branch. Ensure your working tree is clean, and make sure you have the latest changes by running
103
103
  `git pull; yarn`.
104
- - Bump and tag - `npm run release -- patch`. This bumps `package.json`, commits, tags and pushes. It no longer publishes
104
+ - Bump and tag - `npm run release -- patch --ci`. This bumps `package.json`, commits, tags and pushes. It no longer publishes
105
105
  to npm from your machine, so there's no OTP to enter.
106
106
  - Pushing the tag runs [`npm_publish.yml`](.github/workflows/npm_publish.yml), which publishes to npm using npm's
107
107
  trusted publishing (there is no `NPM_TOKEN` secret) and then kicks off `release.yml` for the macOS native builds and
108
108
  the homebrew tap.
109
109
 
110
+ The publish job runs in the `npm-release` environment, which only tags can deploy to. Combined with the tag ruleset,
111
+ that means a branch can never obtain npm's OIDC credentials. Changes to anything under `.github/workflows/` need a
112
+ review from an admin, via [CODEOWNERS](.github/CODEOWNERS).
113
+
110
114
  :ship:
111
115
 
112
116
  ## License, Contributor's Guidelines and Code of Conduct
package/package.json CHANGED
@@ -1,6 +1,6 @@
1
1
  {
2
2
  "name": "danger",
3
- "version": "14.0.5",
3
+ "version": "14.0.6",
4
4
  "description": "Unit tests for Team Culture",
5
5
  "main": "distribution/danger.js",
6
6
  "typings": "distribution/danger.d.ts",
@@ -67,8 +67,8 @@
67
67
  "build:watch": "tsc -w",
68
68
  "link": "yarn run build && yarn link",
69
69
  "package": "yarn run pkg . --output brew-distribution/danger && zip -j brew-distribution/danger-macos.zip brew-distribution/danger && shasum -a 256 brew-distribution/danger-macos.zip",
70
- "package:x64": "yarn run pkg . --output brew-distribution/danger-x64 --targets node18-macos-x64 && zip -j brew-distribution/danger-macos-x64.zip brew-distribution/danger-x64 && shasum -a 256 brew-distribution/danger-macos-x64.zip",
71
- "package:arm64": "yarn run pkg . --output brew-distribution/danger-arm64 --targets node18-macos-arm64 && zip -j brew-distribution/danger-macos-arm64.zip brew-distribution/danger-arm64 && shasum -a 256 brew-distribution/danger-macos-arm64.zip",
70
+ "package:x64": "yarn run pkg . --output brew-distribution/danger-x64 --targets node24-macos-x64 && zip -j brew-distribution/danger-macos-x64.zip brew-distribution/danger-x64 && shasum -a 256 brew-distribution/danger-macos-x64.zip",
71
+ "package:arm64": "yarn run pkg . --output brew-distribution/danger-arm64 --targets node24-macos-arm64 && zip -j brew-distribution/danger-macos-arm64.zip brew-distribution/danger-arm64 && shasum -a 256 brew-distribution/danger-macos-arm64.zip",
72
72
  "declarations": "ts-node ./scripts/create-danger-dts.ts",
73
73
  "docs:cp_defs": "mkdir docs/docs_generate && cp source/danger.d.ts docs/docs_generate && cp node_modules/@octokit/rest/index.d.ts docs/docs_generate/github.d.ts",
74
74
  "docs": "yarn run docs:cp_defs && yarn typedoc --ignoreCompilerErrors --mode modules --json docs/js_ref_dsl_docs.json --includeDeclarations source",
@@ -117,6 +117,7 @@
117
117
  "@types/voca": "^1.4.0",
118
118
  "@typescript-eslint/eslint-plugin": "^5.10.1",
119
119
  "@typescript-eslint/parser": "^5.10.1",
120
+ "@yao-pkg/pkg": "^6.22.0",
120
121
  "danger-plugin-jest": "^1.0.1",
121
122
  "danger-plugin-yarn": "^1.3.1",
122
123
  "date-fns": "^1.29.0",
@@ -131,7 +132,6 @@
131
132
  "lint-staged": "^12.3.7",
132
133
  "madge": "^6.0.1",
133
134
  "nock": "^14.0.15",
134
- "pkg": "^5.8.1",
135
135
  "prettier": "^2.5.1",
136
136
  "release-it": "^18.1.2",
137
137
  "shx": "^0.3.4",