danger 11.2.8 → 11.3.1

package/CHANGELOG.md

@@ -17,6 +17,16 @@
 <!-- Your comment below this -->
 <!-- Your comment above this -->
 
+## 11.3.1
+
+- Adds `pull_number` into `thisPR` in the GitHub SDL  [@radimsv]
+- Clear missing DSL timeout when DSL is found so danger runner can exit faster when done [@normano64]
+- Customise GHE actions bot user ID via `DANGER_GHE_ACTIONS_BOT_USER_ID` #1404  [@dimitar-hristov]
+
+## 11.3.0
+
+- GitLab: Upgrade `@gitbeaker/node` from `^21.3.0` to `^35.8.1` [@buffcode]
+
 ## 11.2.8
 
 - Another fix for Gitlab inline comments #1395 [@glensc]
@@ -1963,6 +1973,7 @@ Not usable for others, only stubs of classes etc. - [@orta]
 [@azz]: https://github.com/azz
 [@bdotdub]: https://github.com/bdotdub
 [@bigkraig]: https://github.com/bigkraig
+[@buffcode]: https://github.com/buffcode
 [@caffodian]: https://github.com/caffodian
 [@codestergit]: https://github.com/codestergit
 [@cwright017]: https://github.com/Cwright017
@@ -1973,6 +1984,7 @@ Not usable for others, only stubs of classes etc. - [@orta]
 [@dbgrandi]: https://github.com/dbgrandi
 [@dblandin]: https://github.com/dblandin
 [@denieler]: https://github.com/denieler
+[@dimitar-hristov]: https://github.com/dimitar-hristov
 [@dfalling]: https://github.com/dfalling
 [@dkundel]: https://github.com/dkundel
 [@doniyor2109]: https://github.com/doniyor2109
@@ -2041,6 +2053,7 @@ Not usable for others, only stubs of classes etc. - [@orta]
 [@ravanscafi]: https://github.com/ravanscafi
 [@rogerluan]: https://github.com/rogerluan
 [@rohit-gohri]: https://github.com/rohit-gohri
+[@radimsv]: https://github.com/radimsv
 [@rouby]: https://github.com/rouby
 [@rzgry]: https://github.com/rzgry
 [@sajjadzamani]: https://github.com/sajjadzamani

package/distribution/ci_source/providers/GitHubActions.d.ts

@@ -54,6 +54,26 @@ import { Env, CISource } from "../ci_source";
  * Note it's likely the version number should change, but you get the point. This will run Danger
  * self-encapsulated inside a GitHub action.
  *
+ * If you are using DangerJS on GitHub Enteprise, you will need to set the Danger user ID to
+ * the GitHub Actions bot. This will enable Danger to correctly comment and update on PRs.
+ *
+ * * ```yml
+ * name: "Danger JS"
+ * on: [pull_request]
+ *
+ * jobs:
+ *   build:
+ *     name: Danger JS
+ *     runs-on: ubuntu-latest
+ *     steps:
+ *     - uses: actions/checkout@v1
+ *     - name: Danger
+ *       uses: danger/danger-js@9.1.6
+ *       env:
+ *         GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
+ *         DANGER_GHE_ACTIONS_BOT_USER_ID: *user_id*
+ * ```
+ *
  * <!-- !JS --!>
  * <!-- Swift --!>
  *

package/distribution/ci_source/providers/GitHubActions.js

@@ -59,6 +59,26 @@ var fs_1 = require("fs");
  * Note it's likely the version number should change, but you get the point. This will run Danger
  * self-encapsulated inside a GitHub action.
  *
+ * If you are using DangerJS on GitHub Enteprise, you will need to set the Danger user ID to
+ * the GitHub Actions bot. This will enable Danger to correctly comment and update on PRs.
+ *
+ * * ```yml
+ * name: "Danger JS"
+ * on: [pull_request]
+ *
+ * jobs:
+ *   build:
+ *     name: Danger JS
+ *     runs-on: ubuntu-latest
+ *     steps:
+ *     - uses: actions/checkout@v1
+ *     - name: Danger
+ *       uses: danger/danger-js@9.1.6
+ *       env:
+ *         GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
+ *         DANGER_GHE_ACTIONS_BOT_USER_ID: *user_id*
+ * ```
+ *
  * <!-- !JS --!>
  * <!-- Swift --!>
  *

package/distribution/ci_source/providers/GitHubActions.js.map

@@ -1 +1 @@
-{"version":3,"file":"GitHubActions.js","sourceRoot":"","sources":["../../../source/ci_source/providers/GitHubActions.ts"],"names":[],"mappings":";;;AACA,0DAAyD;AACzD,yBAA6C;AAE7C,wCAAwC;AAExC;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;GA4LG;AAEH;IAGE,uBAA6B,GAAQ,EAAE,KAAsB;QAAtB,sBAAA,EAAA,iBAAsB;QAAhC,QAAG,GAAH,GAAG,CAAK;QAC3B,IAAA,iBAAiB,GAAK,GAAG,kBAAR,CAAQ;QACjC,IAAM,aAAa,GAAG,iBAAiB,IAAI,6BAA6B,CAAA;QAExE,IAAI,KAAK,KAAK,SAAS,EAAE;YACvB,IAAI,CAAC,KAAK,GAAG,KAAK,CAAA;SACnB;aAAM,IAAI,IAAA,eAAU,EAAC,aAAa,CAAC,EAAE;YACpC,IAAM,OAAK,GAAG,IAAA,iBAAY,EAAC,aAAa,EAAE,MAAM,CAAC,CAAA;YACjD,IAAI,CAAC,KAAK,GAAG,IAAI,CAAC,KAAK,CAAC,OAAK,CAAC,CAAA;SAC/B;IACH,CAAC;IAED,sBAAI,+BAAI;aAAR;YACE,OAAO,gBAAgB,CAAA;QACzB,CAAC;;;OAAA;IAED,sBAAI,+BAAI;aAAR;YACE,OAAO,IAAA,sCAAkB,EAAC,IAAI,CAAC,GAAG,EAAE,CAAC,iBAAiB,CAAC,CAAC,CAAA;QAC1D,CAAC;;;OAAA;IAED,sBAAI,+BAAI;aAAR;YACE,sEAAsE;YACtE,OAAO,IAAI,CAAA;QACb,CAAC;;;OAAA;IAED,sBAAI,sCAAW;aAAf;YACE,OAAO,IAAI,CAAC,KAAK,CAAC,YAAY,KAAK,SAAS,IAAI,IAAI,CAAC,KAAK,CAAC,KAAK,KAAK,SAAS,CAAA;QAChF,CAAC;;;OAAA;IAED,sBAAI,wCAAa;aAAjB;YACE,IAAI,IAAI,CAAC,KAAK,CAAC,YAAY,KAAK,SAAS,EAAE;gBACzC,OAAO,IAAI,CAAC,KAAK,CAAC,YAAY,CAAC,MAAM,CAAA;aACtC;iBAAM,IAAI,IAAI,CAAC,KAAK,CAAC,KAAK,KAAK,SAAS,EAAE;gBACzC,OAAO,IAAI,CAAC,KAAK,CAAC,KAAK,CAAC,MAAM,CAAA;aAC/B;YAED,MAAM,IAAI,KAAK,CAAC,+DAA+D,CAAC,CAAA;QAClF,CAAC;;;OAAA;IAED,sBAAI,mCAAQ;aAAZ;YACE,IAAI,IAAI,CAAC,KAAK,CAAC,YAAY,KAAK,SAAS,EAAE;gBACzC,OAAO,IAAI,CAAC,KAAK,CAAC,YAAY,CAAC,IAAI,CAAC,IAAI,CAAC,SAAS,CAAA;aACnD;iBAAM,IAAI,IAAI,CAAC,KAAK,CAAC,UAAU,KAAK,SAAS,EAAE;gBAC9C,OAAO,IAAI,CAAC,KAAK,CAAC,UAAU,CAAC,SAAS,CAAA;aACvC;YAED,MAAM,IAAI,KAAK,CAAC,0DAA0D,CAAC,CAAA;QAC7E,CAAC;;;OAAA;IAMH,oBAAC;AAAD,CAAC,AAxDD,IAwDC;AAxDY,sCAAa"}
+{"version":3,"file":"GitHubActions.js","sourceRoot":"","sources":["../../../source/ci_source/providers/GitHubActions.ts"],"names":[],"mappings":";;;AACA,0DAAyD;AACzD,yBAA6C;AAE7C,wCAAwC;AAExC;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;GAgNG;AAEH;IAGE,uBAA6B,GAAQ,EAAE,KAAsB;QAAtB,sBAAA,EAAA,iBAAsB;QAAhC,QAAG,GAAH,GAAG,CAAK;QAC3B,IAAA,iBAAiB,GAAK,GAAG,kBAAR,CAAQ;QACjC,IAAM,aAAa,GAAG,iBAAiB,IAAI,6BAA6B,CAAA;QAExE,IAAI,KAAK,KAAK,SAAS,EAAE;YACvB,IAAI,CAAC,KAAK,GAAG,KAAK,CAAA;SACnB;aAAM,IAAI,IAAA,eAAU,EAAC,aAAa,CAAC,EAAE;YACpC,IAAM,OAAK,GAAG,IAAA,iBAAY,EAAC,aAAa,EAAE,MAAM,CAAC,CAAA;YACjD,IAAI,CAAC,KAAK,GAAG,IAAI,CAAC,KAAK,CAAC,OAAK,CAAC,CAAA;SAC/B;IACH,CAAC;IAED,sBAAI,+BAAI;aAAR;YACE,OAAO,gBAAgB,CAAA;QACzB,CAAC;;;OAAA;IAED,sBAAI,+BAAI;aAAR;YACE,OAAO,IAAA,sCAAkB,EAAC,IAAI,CAAC,GAAG,EAAE,CAAC,iBAAiB,CAAC,CAAC,CAAA;QAC1D,CAAC;;;OAAA;IAED,sBAAI,+BAAI;aAAR;YACE,sEAAsE;YACtE,OAAO,IAAI,CAAA;QACb,CAAC;;;OAAA;IAED,sBAAI,sCAAW;aAAf;YACE,OAAO,IAAI,CAAC,KAAK,CAAC,YAAY,KAAK,SAAS,IAAI,IAAI,CAAC,KAAK,CAAC,KAAK,KAAK,SAAS,CAAA;QAChF,CAAC;;;OAAA;IAED,sBAAI,wCAAa;aAAjB;YACE,IAAI,IAAI,CAAC,KAAK,CAAC,YAAY,KAAK,SAAS,EAAE;gBACzC,OAAO,IAAI,CAAC,KAAK,CAAC,YAAY,CAAC,MAAM,CAAA;aACtC;iBAAM,IAAI,IAAI,CAAC,KAAK,CAAC,KAAK,KAAK,SAAS,EAAE;gBACzC,OAAO,IAAI,CAAC,KAAK,CAAC,KAAK,CAAC,MAAM,CAAA;aAC/B;YAED,MAAM,IAAI,KAAK,CAAC,+DAA+D,CAAC,CAAA;QAClF,CAAC;;;OAAA;IAED,sBAAI,mCAAQ;aAAZ;YACE,IAAI,IAAI,CAAC,KAAK,CAAC,YAAY,KAAK,SAAS,EAAE;gBACzC,OAAO,IAAI,CAAC,KAAK,CAAC,YAAY,CAAC,IAAI,CAAC,IAAI,CAAC,SAAS,CAAA;aACnD;iBAAM,IAAI,IAAI,CAAC,KAAK,CAAC,UAAU,KAAK,SAAS,EAAE;gBAC9C,OAAO,IAAI,CAAC,KAAK,CAAC,UAAU,CAAC,SAAS,CAAA;aACvC;YAED,MAAM,IAAI,KAAK,CAAC,0DAA0D,CAAC,CAAA;QAC7E,CAAC;;;OAAA;IAMH,oBAAC;AAAD,CAAC,AAxDD,IAwDC;AAxDY,sCAAa"}

package/distribution/commands/danger-runner.js

@@ -88,6 +88,7 @@ var run = function (config) { return function (jsonString) { return __awaiter(vo
                 platform = (0, platform_1.getPlatformForEnv)(process.env, source);
                 d("Got STDIN for Danger Run");
                 foundDSL = true;
+                clearTimeout(missingDSLTimeout);
                 dangerFile = (0, fileUtils_1.dangerfilePath)(commander_1.default);
                 return [4 /*yield*/, (0, jsonToContext_1.jsonToContext)(jsonString, commander_1.default, source)];
             case 3:
@@ -125,9 +126,9 @@ var run = function (config) { return function (jsonString) { return __awaiter(vo
     }
 });
 // Add a timeout so that CI doesn't run forever if something has broken.
-setTimeout(function () {
+var missingDSLTimeout = setTimeout(function () {
     if (!foundDSL) {
-        console.error(chalk_1.default.red("Timeout: Failed to get the Danger DSL after 1 second"));
+        console.error(chalk_1.default.red("Timeout: Failed to get the Danger DSL after 10 second"));
         process.exitCode = 1;
         process.exit(1);
     }

package/distribution/commands/danger-runner.js.map

@@ -1 +1 @@
-{"version":3,"file":"danger-runner.js","sourceRoot":"","sources":["../../source/commands/danger-runner.ts"],"names":[],"mappings":";;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;AAEA,sFAAuE;AACvE,8DAAsC;AAEtC,wDAA+B;AAC/B,kCAAgC;AAChC,wDAAgC;AAChC,gDAAyB;AAEzB,oEAA6C;AAC7C,+CAAkD;AAClD,yDAAuD;AAGvD,kFAA2D;AAC3D,kDAAyD;AACzD,yBAA2B;AAC3B,yBAAkC;AAClC,6BAA2B;AAC3B,iCAAoC;AAEpC,IAAM,CAAC,GAAG,IAAA,aAAK,EAAC,QAAQ,CAAC,CAAA;AAEzB,4FAA4F;AAC5F,EAAE;AACF,2MAA2M;AAC3M,EAAE;AACF,mGAAmG;AAEnG,mBAAO;KACJ,KAAK,CAAC,WAAW,CAAC;KAClB,WAAW,CACV,6JAA6J,CAC9J;IACD,6CAA6C;IAC7C,8CAA8C;KAC7C,kBAAkB,CAAC,IAAI,CAAC,CAAA;AAE3B,IAAM,SAAS,GAAG,OAAO,CAAC,IAAI,CAAC,KAAK,CAAC,CAAC,CAAC,CAAA;AACvC,IAAA,8BAAa,EAAC,mBAAO,CAAC,CAAC,KAAK,CAAC,SAAS,CAAC,CAAA;AAEvC,CAAC,CAAC,qCAA8B,mBAAO,CAAC,IAAI,CAAE,CAAC,CAAA;AAE/C,IAAI,QAAQ,GAAG,KAAK,CAAA;AACpB,IAAI,UAAU,GAAG,EAAS,CAAA;AAE1B,IAAM,GAAG,GAAG,UAAC,MAAiB,IAAK,OAAA,UAAO,UAAkB;;;;;gBAC3C,KAAA,CAAC,MAAM,IAAI,MAAM,CAAC,MAAM,CAAC,CAAA;wBAAzB,wBAAyB;gBAAK,qBAAM,IAAA,4BAAkB,EAAC,MAAM,CAAC,EAAA;;gBAAjC,KAAA,CAAC,SAAgC,CAAC,CAAA;;;gBAAxE,MAAM,KAAkE;gBACxE,QAAQ,GAAG,IAAA,4BAAiB,EAAC,OAAO,CAAC,GAAG,EAAE,MAAM,CAAC,CAAA;gBAEvD,CAAC,CAAC,0BAA0B,CAAC,CAAA;gBAC7B,QAAQ,GAAG,IAAI,CAAA;gBACT,UAAU,GAAG,IAAA,0BAAc,EAAC,mBAAO,CAAC,CAAA;gBAG1B,qBAAM,IAAA,6BAAa,EAAC,UAAU,EAAE,mBAAO,EAAE,MAAM,CAAC,EAAA;;gBAA1D,OAAO,GAAG,SAAgD;gBACnD,qBAAM,gBAAM,CAAC,kCAAkC,CAAC,OAAO,CAAC,EAAA;;gBAArE,UAAU,GAAG,SAAwD,CAAA;gBACrE,CAAC,CAAC,qBAAc,UAAU,CAAE,CAAC,CAAA;qBAGzB,QAAQ,CAAC,yBAAyB,EAAlC,wBAAkC;gBACpC,qBAAM,QAAQ,CAAC,yBAAyB,CAAC,gBAAM,CAAC,wBAAwB,EAAE,UAAU,EAAE,UAAU,CAAC,EAAA;;gBAAjG,SAAiG,CAAA;;oBAEjG,qBAAM,gBAAM,CAAC,wBAAwB,CAAC,CAAC,CAAC,UAAU,EAAE,KAAK,CAAC,CAAC,EAAE,CAAC,SAAS,CAAC,EAAE,UAAU,CAAC,EAAA;;gBAArF,SAAqF,CAAA;;;;;KAExF,EAnBkC,CAmBlC,CAAA;AAED,kEAAkE;AAClE,oEAAoE;AACpE,kDAAkD;AAClD,IAAA,sBAAW,EAAC,UAAC,QAAgB,EAAE,MAAc;IAC3C,IAAM,OAAO,GAAkB,UAAU,CAAC,OAAO,CAAA;IACjD,CAAC,CAAC,oCAA6B,QAAQ,4DAAkD,MAAM,IAAI,EAAE,CAAE,CAAC,CAAA;IACxG,CAAC,CACC,iBAAU,OAAO,CAAC,SAAS,CAAC,MAAM,gBAAM,OAAO,CAAC,QAAQ,CAAC,MAAM,gBAAM,OAAO,CAAC,KAAK,CAAC,MAAM,gBAAM,OAAO,CAAC,QAAQ,CAAC,MAAM,CAAE,CACzH,CAAA;IACD,IAAI,QAAQ,EAAE;QACZ,IAAM,QAAQ,GAAG,yBAAkB,IAAA,oBAAW,EAAC,CAAC,CAAC,CAAC,QAAQ,CAAC,KAAK,CAAC,UAAO,CAAA;QACxE,IAAM,WAAW,GAAG,IAAA,WAAI,EAAC,IAAA,WAAM,GAAE,EAAE,QAAQ,CAAC,CAAA;QAC5C,CAAC,CAAC,+BAAwB,WAAW,CAAE,CAAC,CAAA;QACxC,IAAA,kBAAa,EAAC,WAAW,EAAE,IAAI,CAAC,SAAS,CAAC,OAAO,EAAE,IAAI,EAAE,CAAC,CAAC,EAAE,MAAM,CAAC,CAAA;QACpE,OAAO,CAAC,MAAM,CAAC,KAAK,CAAC,kBAAkB,GAAG,WAAW,CAAC,CAAA;KACvD;AACH,CAAC,CAAC,CAAA;AAEF,wEAAwE;AACxE,UAAU,CAAC;IACT,IAAI,CAAC,QAAQ,EAAE;QACb,OAAO,CAAC,KAAK,CAAC,eAAK,CAAC,GAAG,CAAC,sDAAsD,CAAC,CAAC,CAAA;QAChF,OAAO,CAAC,QAAQ,GAAG,CAAC,CAAA;QACpB,OAAO,CAAC,IAAI,CAAC,CAAC,CAAC,CAAA;KAChB;AACH,CAAC,EAAE,KAAK,CAAC,CAAA;AAET,qCAAqC;AACrC,IAAA,mBAAQ,GAAE,CAAC,IAAI,CAAC,GAAG,CAAC,mBAAc,CAAC,CAAC,CAAA"}
+{"version":3,"file":"danger-runner.js","sourceRoot":"","sources":["../../source/commands/danger-runner.ts"],"names":[],"mappings":";;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;AAEA,sFAAuE;AACvE,8DAAsC;AAEtC,wDAA+B;AAC/B,kCAAgC;AAChC,wDAAgC;AAChC,gDAAyB;AAEzB,oEAA6C;AAC7C,+CAAkD;AAClD,yDAAuD;AAGvD,kFAA2D;AAC3D,kDAAyD;AACzD,yBAA2B;AAC3B,yBAAkC;AAClC,6BAA2B;AAC3B,iCAAoC;AAEpC,IAAM,CAAC,GAAG,IAAA,aAAK,EAAC,QAAQ,CAAC,CAAA;AAEzB,4FAA4F;AAC5F,EAAE;AACF,2MAA2M;AAC3M,EAAE;AACF,mGAAmG;AAEnG,mBAAO;KACJ,KAAK,CAAC,WAAW,CAAC;KAClB,WAAW,CACV,6JAA6J,CAC9J;IACD,6CAA6C;IAC7C,8CAA8C;KAC7C,kBAAkB,CAAC,IAAI,CAAC,CAAA;AAE3B,IAAM,SAAS,GAAG,OAAO,CAAC,IAAI,CAAC,KAAK,CAAC,CAAC,CAAC,CAAA;AACvC,IAAA,8BAAa,EAAC,mBAAO,CAAC,CAAC,KAAK,CAAC,SAAS,CAAC,CAAA;AAEvC,CAAC,CAAC,qCAA8B,mBAAO,CAAC,IAAI,CAAE,CAAC,CAAA;AAE/C,IAAI,QAAQ,GAAG,KAAK,CAAA;AACpB,IAAI,UAAU,GAAG,EAAS,CAAA;AAE1B,IAAM,GAAG,GAAG,UAAC,MAAiB,IAAK,OAAA,UAAO,UAAkB;;;;;gBAC3C,KAAA,CAAC,MAAM,IAAI,MAAM,CAAC,MAAM,CAAC,CAAA;wBAAzB,wBAAyB;gBAAK,qBAAM,IAAA,4BAAkB,EAAC,MAAM,CAAC,EAAA;;gBAAjC,KAAA,CAAC,SAAgC,CAAC,CAAA;;;gBAAxE,MAAM,KAAkE;gBACxE,QAAQ,GAAG,IAAA,4BAAiB,EAAC,OAAO,CAAC,GAAG,EAAE,MAAM,CAAC,CAAA;gBAEvD,CAAC,CAAC,0BAA0B,CAAC,CAAA;gBAC7B,QAAQ,GAAG,IAAI,CAAA;gBACf,YAAY,CAAC,iBAAiB,CAAC,CAAA;gBACzB,UAAU,GAAG,IAAA,0BAAc,EAAC,mBAAO,CAAC,CAAA;gBAG1B,qBAAM,IAAA,6BAAa,EAAC,UAAU,EAAE,mBAAO,EAAE,MAAM,CAAC,EAAA;;gBAA1D,OAAO,GAAG,SAAgD;gBACnD,qBAAM,gBAAM,CAAC,kCAAkC,CAAC,OAAO,CAAC,EAAA;;gBAArE,UAAU,GAAG,SAAwD,CAAA;gBACrE,CAAC,CAAC,qBAAc,UAAU,CAAE,CAAC,CAAA;qBAGzB,QAAQ,CAAC,yBAAyB,EAAlC,wBAAkC;gBACpC,qBAAM,QAAQ,CAAC,yBAAyB,CAAC,gBAAM,CAAC,wBAAwB,EAAE,UAAU,EAAE,UAAU,CAAC,EAAA;;gBAAjG,SAAiG,CAAA;;oBAEjG,qBAAM,gBAAM,CAAC,wBAAwB,CAAC,CAAC,CAAC,UAAU,EAAE,KAAK,CAAC,CAAC,EAAE,CAAC,SAAS,CAAC,EAAE,UAAU,CAAC,EAAA;;gBAArF,SAAqF,CAAA;;;;;KAExF,EApBkC,CAoBlC,CAAA;AAED,kEAAkE;AAClE,oEAAoE;AACpE,kDAAkD;AAClD,IAAA,sBAAW,EAAC,UAAC,QAAgB,EAAE,MAAc;IAC3C,IAAM,OAAO,GAAkB,UAAU,CAAC,OAAO,CAAA;IACjD,CAAC,CAAC,oCAA6B,QAAQ,4DAAkD,MAAM,IAAI,EAAE,CAAE,CAAC,CAAA;IACxG,CAAC,CACC,iBAAU,OAAO,CAAC,SAAS,CAAC,MAAM,gBAAM,OAAO,CAAC,QAAQ,CAAC,MAAM,gBAAM,OAAO,CAAC,KAAK,CAAC,MAAM,gBAAM,OAAO,CAAC,QAAQ,CAAC,MAAM,CAAE,CACzH,CAAA;IACD,IAAI,QAAQ,EAAE;QACZ,IAAM,QAAQ,GAAG,yBAAkB,IAAA,oBAAW,EAAC,CAAC,CAAC,CAAC,QAAQ,CAAC,KAAK,CAAC,UAAO,CAAA;QACxE,IAAM,WAAW,GAAG,IAAA,WAAI,EAAC,IAAA,WAAM,GAAE,EAAE,QAAQ,CAAC,CAAA;QAC5C,CAAC,CAAC,+BAAwB,WAAW,CAAE,CAAC,CAAA;QACxC,IAAA,kBAAa,EAAC,WAAW,EAAE,IAAI,CAAC,SAAS,CAAC,OAAO,EAAE,IAAI,EAAE,CAAC,CAAC,EAAE,MAAM,CAAC,CAAA;QACpE,OAAO,CAAC,MAAM,CAAC,KAAK,CAAC,kBAAkB,GAAG,WAAW,CAAC,CAAA;KACvD;AACH,CAAC,CAAC,CAAA;AAEF,wEAAwE;AACxE,IAAM,iBAAiB,GAAG,UAAU,CAAC;IACnC,IAAI,CAAC,QAAQ,EAAE;QACb,OAAO,CAAC,KAAK,CAAC,eAAK,CAAC,GAAG,CAAC,uDAAuD,CAAC,CAAC,CAAA;QACjF,OAAO,CAAC,QAAQ,GAAG,CAAC,CAAA;QACpB,OAAO,CAAC,IAAI,CAAC,CAAC,CAAC,CAAA;KAChB;AACH,CAAC,EAAE,KAAK,CAAC,CAAA;AAET,qCAAqC;AACrC,IAAA,mBAAQ,GAAE,CAAC,IAAI,CAAC,GAAG,CAAC,mBAAc,CAAC,CAAC,CAAA"}

package/distribution/danger.d.ts

@@ -3,7 +3,8 @@
 //
 
 import { Octokit as GitHub } from "@octokit/rest"
-import { Gitlab } from "@gitbeaker/node"
+import { Gitlab, Types } from "@gitbeaker/node"
+import { Types as CoreTypes } from "@gitbeaker/core/dist"
 import { File } from "parse-diff"
 
 type MarkdownString = string
@@ -1460,8 +1461,13 @@ interface GitHubAPIPR {
   owner: string
   /** The repo name */
   repo: string
-  /** The PR number */
+  /**
+   * The PR number
+   * @deprecated use `pull_number` instead
+   */
   number: number
+  /** The PR number */
+  pull_number: number
 }
 
 interface GitHubReviewers {
@@ -1475,11 +1481,11 @@ interface GitLabJSONDSL {
   /** Info about the repo */
   metadata: RepoMetaData
   /** Info about the merge request */
-  mr: GitLabMR
-  /** All of the individual commits in the merge request */
-  commits: GitLabMRCommit[]
+  mr: CoreTypes.ExpandedMergeRequestSchema
+  /** All the individual commits in the merge request */
+  commits: Types.CommitSchema[]
   /** Merge Request-level MR approvals Configuration */
-  approvals: GitLabApproval
+  approvals: Types.MergeRequestLevelMergeRequestApprovalSchema
 }
 
 // danger.gitlab
@@ -1493,274 +1499,6 @@ interface GitLabDSL extends GitLabJSONDSL {
   api: InstanceType<typeof Gitlab>
 }
 
-// ---
-// JSON responses from API
-
-interface GitLabUser {
-  id: number
-  name: string
-  username: string
-  state: "active" | "blocked"
-  avatar_url: string | null
-  web_url: string
-}
-
-interface GitLabUserProfile extends GitLabUser {
-  created_at: string
-  bio: string | null
-  location: string | null
-  public_email: string
-  skype: string
-  linkedin: string
-  twitter: string
-  website_url: string
-  organization: string
-  last_sign_in_at: string
-  confirmed_at: string
-  theme_id: number
-  last_activity_on: string
-  color_scheme_id: number
-  projects_limit: number
-  current_sign_in_at: string
-  identities: [{ provider: string; extern_uid: string }]
-  can_create_group: boolean
-  can_create_project: boolean
-  two_factor_enabled: boolean
-  external: boolean
-  private_profile: boolean
-}
-
-interface GitLabMRBase {
-  /** The MR's id */
-  id: number
-
-  /** The unique ID for this MR */
-  iid: number
-
-  /** The project ID for this MR */
-  project_id: number
-
-  /** The given name of the MR */
-  title: string
-
-  /** The body text describing the MR */
-  description: string
-
-  /** The MR's current availability */
-  state: "closed" | "open" | "locked" | "merged"
-
-  /** When was the MR made */
-  created_at: string
-
-  /** When was the MR updated */
-  updated_at: string
-
-  /** What branch is this MR being merged into */
-  target_branch: string
-  /** What branch is this MR come from */
-  source_branch: string
-
-  /** How many folks have given it an upvote */
-  upvotes: number
-  /** How many folks have given it an downvote */
-  downvotes: number
-
-  /** Who made it */
-  author: GitLabUser
-  /** Access rights for the user who created the MR */
-  user: {
-    /** Does the author have access to merge? */
-    can_merge: boolean
-  }
-  /** Who was assigned as the person to review */
-  assignee?: GitLabUser
-  assignees: GitLabUser[]
-  /** Users who were added as reviewers to the MR */
-  reviewers: GitLabUser[]
-  source_project_id: number
-  target_project_id: number
-  labels: string[]
-  work_in_progress: boolean
-  milestone: {
-    id: number
-    iid: number
-    project_id: number
-    title: string
-    description: string
-    state: "closed" | "active"
-    created_at: string
-    updated_at: string
-    due_date: string
-    start_date: string
-    web_url: string
-  }
-  merge_when_pipeline_succeeds: boolean
-  merge_status: "can_be_merged" // XXX: other statuses?
-  merge_error: null | null
-  sha: string
-  merge_commit_sha: string | null
-  user_notes_count: number
-  discussion_locked: null | null
-  should_remove_source_branch: boolean
-  force_remove_source_branch: boolean
-  allow_collaboration: boolean
-  allow_maintainer_to_push: boolean
-  web_url: string
-  time_stats: {
-    time_estimate: number
-    total_time_spent: number
-    human_time_estimate: number | null
-    human_total_time_spent: number | null
-  }
-}
-
-/** TODO: These need more comments from someone who uses GitLab, see GitLabDSL.ts in the danger-js repo */
-interface GitLabMR extends GitLabMRBase {
-  squash: boolean
-  subscribed: boolean
-  changes_count: string
-  merged_by: GitLabUser
-  merged_at: string
-  closed_by: GitLabUser | null
-  closed_at: string | null
-  latest_build_started_at: string
-  latest_build_finished_at: string
-  first_deployed_to_production_at: string | null
-  pipeline: {
-    id: number
-    sha: string
-    ref: string
-    status: "canceled" | "failed" | "pending" | "running" | "skipped" | "success"
-    web_url: string
-  }
-  diff_refs: {
-    base_sha: string
-    head_sha: string
-    start_sha: string
-  }
-  diverged_commits_count: number
-  rebase_in_progress: boolean
-  approvals_before_merge: null | null
-}
-
-interface GitLabMRChange {
-  old_path: string
-  new_path: string
-  a_mode: string
-  b_mode: string
-  diff: string
-  new_file: boolean
-  renamed_file: boolean
-  deleted_file: boolean
-}
-
-interface GitLabMRChanges extends GitLabMRBase {
-  changes: GitLabMRChange[]
-}
-
-interface GitLabNote {
-  id: number
-  type: "DiffNote" | "DiscussionNote" | null // XXX: other types? null means "normal comment"
-  body: string
-  attachment: null // XXX: what can an attachment be?
-  author: GitLabUser
-  created_at: string
-  updated_at: string
-  system: boolean
-  noteable_id: number
-  noteable_type: "MergeRequest" // XXX: other types...?
-  resolvable: boolean
-  noteable_iid: number
-}
-
-interface GitLabDiscussion {
-  id: string //40 character hex
-  individual_note: boolean
-  notes: GitLabNote[]
-}
-
-interface GitLabDiscussionTextPosition {
-  position_type: "text"
-  base_sha: string
-  start_sha: string
-  head_sha: string
-  new_path: string
-  new_line: number
-  old_path: string
-  old_line: number | null
-}
-
-interface GitLabDiscussionCreationOptions {
-  position?: GitLabDiscussionTextPosition
-}
-
-interface GitLabInlineNote extends GitLabNote {
-  position: {
-    base_sha: string
-    start_sha: string
-    head_sha: string
-    old_path: string
-    new_path: string
-    position_type: "text" // XXX: other types?
-    old_line: number | null
-    new_line: number
-  }
-  resolvable: boolean
-  resolved: boolean
-  resolved_by: GitLabUser | null
-}
-
-interface GitLabMRCommit {
-  id: string
-  short_id: string
-  created_at: string
-  parent_ids: string[]
-  title: string
-  message: string
-  author_name: string
-  author_email: string
-  authored_date: string
-  committer_name: string
-  committer_email: string
-  committed_date: string
-}
-
-interface GitLabCommit {
-  id: string
-  short_id: string
-  title: string
-  author_name: string
-  author_email: string
-  created_at: string
-}
-
-interface GitLabRepositoryCompare {
-  commit: GitLabCommit
-  commits: GitLabCommit[]
-  diffs: GitLabMRChange[]
-  compare_timeout: boolean
-  compare_same_ref: boolean
-}
-
-interface GitLabApproval {
-  id: number
-  iid: number
-  project_id: number
-  title: string
-  description: string
-  state: "closed" | "open" | "locked" | "merged"
-  created_at: string
-  updated_at: string
-  merge_status: "can_be_merged"
-  approvals_required: number
-  approvals_left: number
-  approved_by?:
-    | {
-        user: GitLabUser
-      }[]
-    | GitLabUser[]
-}
-
 /** Key details about a repo */
 interface RepoMetaData {
   /** A path like "artsy/eigen" */
@@ -1828,7 +1566,7 @@ type Scheduleable = Promise<any> | Promise<void> | CallbackableFn
 declare function schedule(asyncFunction: Scheduleable): void
 
 /**
- * Fails a build, outputting a specific reason for failing into a HTML table.
+ * Highlights critical issues. Message is shown inside a HTML table.
  *
  * @param {MarkdownString} message the String to output
  * @param {string | undefined} file a file which this message should be attached to
@@ -1837,8 +1575,7 @@ declare function schedule(asyncFunction: Scheduleable): void
 declare function fail(message: MarkdownString, file?: string, line?: number): void
 
 /**
- * Highlights low-priority issues, but does not fail the build. Message
- * is shown inside a HTML table.
+ * Highlights low-priority issues. Message is shown inside a HTML table.
  *
  * @param {MarkdownString} message the String to output
  * @param {string | undefined} file a file which this message should be attached to