dal-engine-core-js-lib-dev 0.0.5 → 0.0.6

package/dist/index.cjs

@@ -465,6 +465,14 @@ class Behavior extends Base {
     }
 }
 
+class TransitionAlreadyExistsError extends DALEngineError {
+    constructor (behaviorName, transitionName) {
+        let msg = `Node with behavior named "${behaviorName}" already has a transition\
+         to behavior "${transitionName}".`;
+        super(msg);
+    }
+}
+
 class GraphNode extends Base {
     /**
      * Class representing a behavioral control graph node. Each node has a
@@ -537,8 +545,13 @@ class GraphNode extends Base {
     /**
      * Adds a behavior to the transitions from this node.
      * @param {String} behaviorId ID of behavior.
+     * @throws {TransitionAlreadyExistsError} Raised when a transition to the
+     * provided behavior already exists.
      */
     addGoToBehavior (behaviorId) {
+        if (this._goToBehaviorIds.includes(behaviorId)) {
+            throw new TransitionAlreadyExistsError(this.behaviorName, behaviorId);
+        }
         this._goToBehaviorIds.push(behaviorId);
     }
 
@@ -922,7 +935,6 @@ class DALEngine {
         this.graphs = new Graphs();
         this.graph = this.graphs.getActiveGraph();
         this._loadArgs(args);
-        console.log("Initialized DAL Engine with graphs: ", this.graphs);
     }
 
     /**
@@ -1095,6 +1107,8 @@ class DALEngine {
      * a valid behavior in the graph.
      */
     removeNode (behaviorId) {
+        // TODO: Move this to graph class, this class shouldn't
+        // modifiy the graph structure directly.
         const node = this.graph.findNode(behaviorId);
         const nodeIndex = this.graph.nodes.indexOf(node);
         const removedNode = this.graph.nodes.splice(nodeIndex, 1);

package/dist/index.esm.js

@@ -463,6 +463,14 @@ class Behavior extends Base {
     }
 }
 
+class TransitionAlreadyExistsError extends DALEngineError {
+    constructor (behaviorName, transitionName) {
+        let msg = `Node with behavior named "${behaviorName}" already has a transition\
+         to behavior "${transitionName}".`;
+        super(msg);
+    }
+}
+
 class GraphNode extends Base {
     /**
      * Class representing a behavioral control graph node. Each node has a
@@ -535,8 +543,13 @@ class GraphNode extends Base {
     /**
      * Adds a behavior to the transitions from this node.
      * @param {String} behaviorId ID of behavior.
+     * @throws {TransitionAlreadyExistsError} Raised when a transition to the
+     * provided behavior already exists.
      */
     addGoToBehavior (behaviorId) {
+        if (this._goToBehaviorIds.includes(behaviorId)) {
+            throw new TransitionAlreadyExistsError(this.behaviorName, behaviorId);
+        }
         this._goToBehaviorIds.push(behaviorId);
     }
 
@@ -920,7 +933,6 @@ class DALEngine {
         this.graphs = new Graphs();
         this.graph = this.graphs.getActiveGraph();
         this._loadArgs(args);
-        console.log("Initialized DAL Engine with graphs: ", this.graphs);
     }
 
     /**
@@ -1093,6 +1105,8 @@ class DALEngine {
      * a valid behavior in the graph.
      */
     removeNode (behaviorId) {
+        // TODO: Move this to graph class, this class shouldn't
+        // modifiy the graph structure directly.
         const node = this.graph.findNode(behaviorId);
         const nodeIndex = this.graph.nodes.indexOf(node);
         const removedNode = this.graph.nodes.splice(nodeIndex, 1);

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "dal-engine-core-js-lib-dev",
-  "version": "0.0.5",
+  "version": "0.0.6",
   "main": "dist/index.cjs",
   "module": "dist/index.esm.js",
   "type": "module",

package/src/BehavioralControlGraph/GraphNode.js

@@ -1,5 +1,6 @@
 import Base from "../Base";
 import MissingAttributes from "../Errors/MissingAttributes";
+import TransitionAlreadyExistsError from "../Errors/TransitionAlreadyExistsError";
 import isLoadedFromFile from "../helpers/isLoadedFromFile";
 import Behavior from "../Members/Behavior";
 import ENGINE_TYPES from "../TYPES";
@@ -77,8 +78,13 @@ class GraphNode extends Base {
     /**
      * Adds a behavior to the transitions from this node.
      * @param {String} behaviorId ID of behavior.
+     * @throws {TransitionAlreadyExistsError} Raised when a transition to the
+     * provided behavior already exists.
      */
     addGoToBehavior (behaviorId) {
+        if (this._goToBehaviorIds.includes(behaviorId)) {
+            throw new TransitionAlreadyExistsError(this.behaviorName, behaviorId);
+        }
         this._goToBehaviorIds.push(behaviorId);
     }
 

package/src/DALEngine.js

@@ -30,7 +30,6 @@ export class DALEngine {
         this.graphs = new Graphs();
         this.graph = this.graphs.getActiveGraph();
         this._loadArgs(args);
-        console.log("Initialized DAL Engine with graphs: ", this.graphs);
     }
 
     /**
@@ -203,6 +202,8 @@ export class DALEngine {
      * a valid behavior in the graph.
      */
     removeNode (behaviorId) {
+        // TODO: Move this to graph class, this class shouldn't
+        // modifiy the graph structure directly.
         const node = this.graph.findNode(behaviorId);
         const nodeIndex = this.graph.nodes.indexOf(node);
         const removedNode = this.graph.nodes.splice(nodeIndex, 1);

package/src/Errors/TransitionAlreadyExistsError.js

@@ -0,0 +1,11 @@
+import DALEngineError from "./DALEngineError";
+
+class TransitionAlreadyExistsError extends DALEngineError {
+    constructor (behaviorName, transitionName) {
+        let msg = `Node with behavior named "${behaviorName}" already has a transition\
+         to behavior "${transitionName}".`;
+        super(msg);
+    }
+}
+
+export default TransitionAlreadyExistsError;

package/tests/DALEngine.test.js

@@ -7,6 +7,7 @@ import {DALEngine} from "../src/DALEngine.js";
 import BehaviorAlreadyExistsError from "../src/Errors/BehaviorAlreadyExistsError.js";
 import InvalidTransitionError from "../src/Errors/InvalidTransitionError.js";
 import MissingAttributes from "../src/Errors/MissingAttributes.js";
+import TransitionAlreadyExistsError from "../src/Errors/TransitionAlreadyExistsError.js";
 import UnknownBehaviorError from "../src/Errors/UnknownBehaviorError.js";
 import ENGINE_TYPES from "../src/TYPES.js";
 
@@ -128,6 +129,16 @@ describe("DALEngine", () => {
         expect(lastInvariant).toBe(invariant);
     });
 
+    it ("add duplicate transition and check error is raised", () => {
+        const d = new DALEngine({name: "Library Manager"});
+        const node1 = d.addNode("AcceptBookFromUser", []);
+        const node2 = d.addNode("AddBookToBasket", []);
+        node1.addGoToBehavior("AddBookToBasket");
+        expect(() => {
+            node1.addGoToBehavior("AddBookToBasket");
+        }).toThrow(TransitionAlreadyExistsError);
+    });
+
     it("serialize to file and deseralize from file", async () => {
         let d = new DALEngine({name: "Library Manager"});
         const book = d.createParticipant({name: "book"});