cypress 3.3.0 → 3.4.1

package/lib/cli.js

@@ -38,6 +38,7 @@ var coerceFalse = function coerceFalse(arg) {
 var spaceDelimitedSpecsMsg = function spaceDelimitedSpecsMsg(files) {
   logger.log();
   logger.warn(stripIndent(_templateObject, logSymbols.warning, files.join(' ')));
+
   logger.log();
 };
 
@@ -143,6 +144,8 @@ module.exports = {
     // in usage help docs
     program._name = 'cypress';
 
+    program.usage('<command> [options]');
+
     program.command('help').description('Shows CLI help and exits').action(function () {
       program.help();
     });

package/lib/errors.js

@@ -1,21 +1,22 @@
 'use strict';
 
-var _templateObject = _taggedTemplateLiteral(['\n    Search for an existing issue or open a GitHub issue at\n\n      ', '\n  '], ['\n    Search for an existing issue or open a GitHub issue at\n\n      ', '\n  ']),
-    _templateObject2 = _taggedTemplateLiteral(['\n    \nPlease reinstall Cypress by running: ', '\n  '], ['\n    \\nPlease reinstall Cypress by running: ', '\n  ']),
-    _templateObject3 = _taggedTemplateLiteral(['\n\n    Reasons this may happen:\n\n    - node was installed as \'root\' or with \'sudo\'\n    - the cypress npm package as \'root\' or with \'sudo\'\n\n    Please check that you have the appropriate user permissions.\n  '], ['\\n\n    Reasons this may happen:\n\n    - node was installed as \'root\' or with \'sudo\'\n    - the cypress npm package as \'root\' or with \'sudo\'\n\n    Please check that you have the appropriate user permissions.\n  ']),
-    _templateObject4 = _taggedTemplateLiteral(['\n\n    We expected the binary to be installed here: ', '\n\n    Reasons it may be missing:\n\n    - You\'re caching \'node_modules\' but are not caching this path: ', '\n    - You ran \'npm install\' at an earlier build step but did not persist: ', '\n\n    Properly caching the binary will fix this error and avoid downloading and unzipping Cypress.\n\n    Alternatively, you can run \'cypress install\' to download the binary again.\n\n    ', '\n  '], ['\\n\n    We expected the binary to be installed here: ', '\n\n    Reasons it may be missing:\n\n    - You\'re caching \'node_modules\' but are not caching this path: ', '\n    - You ran \'npm install\' at an earlier build step but did not persist: ', '\n\n    Properly caching the binary will fix this error and avoid downloading and unzipping Cypress.\n\n    Alternatively, you can run \'cypress install\' to download the binary again.\n\n    ', '\n  ']),
-    _templateObject5 = _taggedTemplateLiteral(['\n    There was a problem spawning Xvfb.\n\n    This is likely a problem with your system, permissions, or installation of Xvfb.\n    '], ['\n    There was a problem spawning Xvfb.\n\n    This is likely a problem with your system, permissions, or installation of Xvfb.\n    ']),
-    _templateObject6 = _taggedTemplateLiteral(['\n    Install XVFB and run Cypress again.\n\n    Read our documentation on dependencies for more information:\n\n      ', '\n\n    If you are using Docker, we provide containers with all required dependencies installed.\n    '], ['\n    Install XVFB and run Cypress again.\n\n    Read our documentation on dependencies for more information:\n\n      ', '\n\n    If you are using Docker, we provide containers with all required dependencies installed.\n    ']),
-    _templateObject7 = _taggedTemplateLiteral(['\n    This command failed with the following output:\n\n    ', '\n\n    '], ['\n    This command failed with the following output:\n\n    ', '\n\n    ']),
-    _templateObject8 = _taggedTemplateLiteral(['\n      Cypress failed to start after spawning a new XVFB server.\n\n      The error logs we received were:\n\n      ', '\n\n      ', '\n\n      ', '\n\n      This is usually caused by a missing library or dependency.\n\n      The error above should indicate which dependency is missing.\n\n        ', '\n\n      If you are using Docker, we provide containers with all required dependencies installed.\n    '], ['\n      Cypress failed to start after spawning a new XVFB server.\n\n      The error logs we received were:\n\n      ', '\n\n      ', '\n\n      ', '\n\n      This is usually caused by a missing library or dependency.\n\n      The error above should indicate which dependency is missing.\n\n        ', '\n\n      If you are using Docker, we provide containers with all required dependencies installed.\n    ']),
-    _templateObject9 = _taggedTemplateLiteral(['\n    This is usually caused by a missing library or dependency.\n\n    The error below should indicate which dependency is missing.\n\n      ', '\n\n    If you are using Docker, we provide containers with all required dependencies installed.\n  '], ['\n    This is usually caused by a missing library or dependency.\n\n    The error below should indicate which dependency is missing.\n\n      ', '\n\n    If you are using Docker, we provide containers with all required dependencies installed.\n  ']),
-    _templateObject10 = _taggedTemplateLiteral(['\n    See discussion and possible solutions at\n    ', '\n  '], ['\n    See discussion and possible solutions at\n    ', '\n  ']),
-    _templateObject11 = _taggedTemplateLiteral(['\n    Please search Cypress documentation for possible solutions:\n\n      ', '\n\n    Check if there is a GitHub issue describing this crash:\n\n      ', '\n\n    Consider opening a new issue.\n  '], ['\n    Please search Cypress documentation for possible solutions:\n\n      ', '\n\n    Check if there is a GitHub issue describing this crash:\n\n      ', '\n\n    Consider opening a new issue.\n  ']),
-    _templateObject12 = _taggedTemplateLiteral(['\n    The environment variable CYPRESS_BINARY_VERSION has been renamed to CYPRESS_INSTALL_BINARY as of version ', '\n    '], ['\n    The environment variable CYPRESS_BINARY_VERSION has been renamed to CYPRESS_INSTALL_BINARY as of version ', '\n    ']),
-    _templateObject13 = _taggedTemplateLiteral(['\n    You should set CYPRESS_INSTALL_BINARY instead.\n    '], ['\n    You should set CYPRESS_INSTALL_BINARY instead.\n    ']),
-    _templateObject14 = _taggedTemplateLiteral(['\n    The environment variable CYPRESS_SKIP_BINARY_INSTALL has been removed as of version ', '\n    '], ['\n    The environment variable CYPRESS_SKIP_BINARY_INSTALL has been removed as of version ', '\n    ']),
-    _templateObject15 = _taggedTemplateLiteral(['\n      To skip the binary install, set CYPRESS_INSTALL_BINARY=0\n    '], ['\n      To skip the binary install, set CYPRESS_INSTALL_BINARY=0\n    ']),
-    _templateObject16 = _taggedTemplateLiteral(['\n    Platform: ', ' (', ')\n    Cypress Version: ', '\n  '], ['\n    Platform: ', ' (', ')\n    Cypress Version: ', '\n  ']);
+var _templateObject = _taggedTemplateLiteral(['\n  Does your workplace require a proxy to be used to access the Internet? If so, you must configure the HTTP_PROXY environment variable before downloading Cypress. Read more: https://on.cypress.io/proxy-configuration\n\n  Otherwise, please check network connectivity and try again:'], ['\n  Does your workplace require a proxy to be used to access the Internet? If so, you must configure the HTTP_PROXY environment variable before downloading Cypress. Read more: https://on.cypress.io/proxy-configuration\n\n  Otherwise, please check network connectivity and try again:']),
+    _templateObject2 = _taggedTemplateLiteral(['\n    Search for an existing issue or open a GitHub issue at\n\n      ', '\n  '], ['\n    Search for an existing issue or open a GitHub issue at\n\n      ', '\n  ']),
+    _templateObject3 = _taggedTemplateLiteral(['\n    \nPlease reinstall Cypress by running: ', '\n  '], ['\n    \\nPlease reinstall Cypress by running: ', '\n  ']),
+    _templateObject4 = _taggedTemplateLiteral(['\n\n    Reasons this may happen:\n\n    - node was installed as \'root\' or with \'sudo\'\n    - the cypress npm package as \'root\' or with \'sudo\'\n\n    Please check that you have the appropriate user permissions.\n  '], ['\\n\n    Reasons this may happen:\n\n    - node was installed as \'root\' or with \'sudo\'\n    - the cypress npm package as \'root\' or with \'sudo\'\n\n    Please check that you have the appropriate user permissions.\n  ']),
+    _templateObject5 = _taggedTemplateLiteral(['\n\n    We expected the binary to be installed here: ', '\n\n    Reasons it may be missing:\n\n    - You\'re caching \'node_modules\' but are not caching this path: ', '\n    - You ran \'npm install\' at an earlier build step but did not persist: ', '\n\n    Properly caching the binary will fix this error and avoid downloading and unzipping Cypress.\n\n    Alternatively, you can run \'cypress install\' to download the binary again.\n\n    ', '\n  '], ['\\n\n    We expected the binary to be installed here: ', '\n\n    Reasons it may be missing:\n\n    - You\'re caching \'node_modules\' but are not caching this path: ', '\n    - You ran \'npm install\' at an earlier build step but did not persist: ', '\n\n    Properly caching the binary will fix this error and avoid downloading and unzipping Cypress.\n\n    Alternatively, you can run \'cypress install\' to download the binary again.\n\n    ', '\n  ']),
+    _templateObject6 = _taggedTemplateLiteral(['\n    There was a problem spawning Xvfb.\n\n    This is likely a problem with your system, permissions, or installation of Xvfb.\n    '], ['\n    There was a problem spawning Xvfb.\n\n    This is likely a problem with your system, permissions, or installation of Xvfb.\n    ']),
+    _templateObject7 = _taggedTemplateLiteral(['\n    Install Xvfb and run Cypress again.\n\n    Read our documentation on dependencies for more information:\n\n      ', '\n\n    If you are using Docker, we provide containers with all required dependencies installed.\n    '], ['\n    Install Xvfb and run Cypress again.\n\n    Read our documentation on dependencies for more information:\n\n      ', '\n\n    If you are using Docker, we provide containers with all required dependencies installed.\n    ']),
+    _templateObject8 = _taggedTemplateLiteral(['\n    This command failed with the following output:\n\n    ', '\n\n    '], ['\n    This command failed with the following output:\n\n    ', '\n\n    ']),
+    _templateObject9 = _taggedTemplateLiteral(['\n      Cypress failed to start after spawning a new Xvfb server.\n\n      The error logs we received were:\n\n      ', '\n\n      ', '\n\n      ', '\n\n      This is usually caused by a missing library or dependency.\n\n      The error above should indicate which dependency is missing.\n\n        ', '\n\n      If you are using Docker, we provide containers with all required dependencies installed.\n    '], ['\n      Cypress failed to start after spawning a new Xvfb server.\n\n      The error logs we received were:\n\n      ', '\n\n      ', '\n\n      ', '\n\n      This is usually caused by a missing library or dependency.\n\n      The error above should indicate which dependency is missing.\n\n        ', '\n\n      If you are using Docker, we provide containers with all required dependencies installed.\n    ']),
+    _templateObject10 = _taggedTemplateLiteral(['\n    This is usually caused by a missing library or dependency.\n\n    The error below should indicate which dependency is missing.\n\n      ', '\n\n    If you are using Docker, we provide containers with all required dependencies installed.\n  '], ['\n    This is usually caused by a missing library or dependency.\n\n    The error below should indicate which dependency is missing.\n\n      ', '\n\n    If you are using Docker, we provide containers with all required dependencies installed.\n  ']),
+    _templateObject11 = _taggedTemplateLiteral(['\n    See discussion and possible solutions at\n    ', '\n  '], ['\n    See discussion and possible solutions at\n    ', '\n  ']),
+    _templateObject12 = _taggedTemplateLiteral(['\n    Please search Cypress documentation for possible solutions:\n\n      ', '\n\n    Check if there is a GitHub issue describing this crash:\n\n      ', '\n\n    Consider opening a new issue.\n  '], ['\n    Please search Cypress documentation for possible solutions:\n\n      ', '\n\n    Check if there is a GitHub issue describing this crash:\n\n      ', '\n\n    Consider opening a new issue.\n  ']),
+    _templateObject13 = _taggedTemplateLiteral(['\n    The environment variable CYPRESS_BINARY_VERSION has been renamed to CYPRESS_INSTALL_BINARY as of version ', '\n    '], ['\n    The environment variable CYPRESS_BINARY_VERSION has been renamed to CYPRESS_INSTALL_BINARY as of version ', '\n    ']),
+    _templateObject14 = _taggedTemplateLiteral(['\n    You should set CYPRESS_INSTALL_BINARY instead.\n    '], ['\n    You should set CYPRESS_INSTALL_BINARY instead.\n    ']),
+    _templateObject15 = _taggedTemplateLiteral(['\n    The environment variable CYPRESS_SKIP_BINARY_INSTALL has been removed as of version ', '\n    '], ['\n    The environment variable CYPRESS_SKIP_BINARY_INSTALL has been removed as of version ', '\n    ']),
+    _templateObject16 = _taggedTemplateLiteral(['\n      To skip the binary install, set CYPRESS_INSTALL_BINARY=0\n    '], ['\n      To skip the binary install, set CYPRESS_INSTALL_BINARY=0\n    ']),
+    _templateObject17 = _taggedTemplateLiteral(['\n    Platform: ', ' (', ')\n    Cypress Version: ', '\n  '], ['\n    Platform: ', ' (', ')\n    Cypress Version: ', '\n  ']);
 
 function _taggedTemplateLiteral(strings, raw) { return Object.freeze(Object.defineProperties(strings, { raw: { value: Object.freeze(raw) } })); }
 
@@ -46,49 +47,49 @@ var hr = '----------';
 // common errors Cypress application can encounter
 var failedDownload = {
   description: 'The Cypress App could not be downloaded.',
-  solution: 'Please check network connectivity and try again:'
+  solution: stripIndent(_templateObject)
 };
 
 var failedUnzip = {
   description: 'The Cypress App could not be unzipped.',
-  solution: stripIndent(_templateObject, chalk.blue(util.issuesUrl))
+  solution: stripIndent(_templateObject2, chalk.blue(util.issuesUrl))
 };
 
 var missingApp = function missingApp(binaryDir) {
   return {
     description: 'No version of Cypress is installed in: ' + chalk.cyan(binaryDir),
-    solution: stripIndent(_templateObject2, chalk.cyan('cypress install'))
+    solution: stripIndent(_templateObject3, chalk.cyan('cypress install'))
   };
 };
 
 var binaryNotExecutable = function binaryNotExecutable(executable) {
   return {
     description: 'Cypress cannot run because this binary file does not have executable permissions here:\n\n' + executable,
-    solution: stripIndent(_templateObject3)
+    solution: stripIndent(_templateObject4)
   };
 };
 
 var notInstalledCI = function notInstalledCI(executable) {
   return {
     description: 'The cypress npm package is installed, but the Cypress binary is missing.',
-    solution: stripIndent(_templateObject4, chalk.cyan(executable), util.getCacheDir(), util.getCacheDir(), chalk.blue('https://on.cypress.io/not-installed-ci-error'))
+    solution: stripIndent(_templateObject5, chalk.cyan(executable), util.getCacheDir(), util.getCacheDir(), chalk.blue('https://on.cypress.io/not-installed-ci-error'))
   };
 };
 
 var nonZeroExitCodeXvfb = {
-  description: 'XVFB exited with a non zero exit code.',
-  solution: stripIndent(_templateObject5)
+  description: 'Xvfb exited with a non zero exit code.',
+  solution: stripIndent(_templateObject6)
 };
 
 var missingXvfb = {
-  description: 'Your system is missing the dependency: XVFB',
-  solution: stripIndent(_templateObject6, chalk.blue(requiredDependenciesUrl))
+  description: 'Your system is missing the dependency: Xvfb',
+  solution: stripIndent(_templateObject7, chalk.blue(requiredDependenciesUrl))
 };
 
 var smokeTestFailure = function smokeTestFailure(smokeTestCommand, timedOut) {
   return {
     description: 'Cypress verification ' + (timedOut ? 'timed out' : 'failed') + '.',
-    solution: stripIndent(_templateObject7, smokeTestCommand)
+    solution: stripIndent(_templateObject8, smokeTestCommand)
   };
 };
 
@@ -96,19 +97,19 @@ var invalidSmokeTestDisplayError = {
   code: 'INVALID_SMOKE_TEST_DISPLAY_ERROR',
   description: 'Cypress verification failed.',
   solution: function solution(msg) {
-    return stripIndent(_templateObject8, hr, msg, hr, chalk.blue(requiredDependenciesUrl));
+    return stripIndent(_templateObject9, hr, msg, hr, chalk.blue(requiredDependenciesUrl));
   }
 };
 
 var missingDependency = {
   description: 'Cypress failed to start.',
   // this message is too Linux specific
-  solution: stripIndent(_templateObject9, chalk.blue(requiredDependenciesUrl))
+  solution: stripIndent(_templateObject10, chalk.blue(requiredDependenciesUrl))
 };
 
 var invalidCacheDirectory = {
   description: 'Cypress cannot write to the cache directory due to file permissions',
-  solution: stripIndent(_templateObject10, chalk.blue(util.getGitHubIssueUrl(1281)))
+  solution: stripIndent(_templateObject11, chalk.blue(util.getGitHubIssueUrl(1281)))
 };
 
 var versionMismatch = {
@@ -118,17 +119,17 @@ var versionMismatch = {
 
 var unexpected = {
   description: 'An unexpected error occurred while verifying the Cypress executable.',
-  solution: stripIndent(_templateObject11, chalk.blue(docsUrl), chalk.blue(util.issuesUrl))
+  solution: stripIndent(_templateObject12, chalk.blue(docsUrl), chalk.blue(util.issuesUrl))
 };
 
 var removed = {
   CYPRESS_BINARY_VERSION: {
-    description: stripIndent(_templateObject12, chalk.green('3.0.0')),
-    solution: stripIndent(_templateObject13)
+    description: stripIndent(_templateObject13, chalk.green('3.0.0')),
+    solution: stripIndent(_templateObject14)
   },
   CYPRESS_SKIP_BINARY_INSTALL: {
-    description: stripIndent(_templateObject14, chalk.green('3.0.0')),
-    solution: stripIndent(_templateObject15)
+    description: stripIndent(_templateObject15, chalk.green('3.0.0')),
+    solution: stripIndent(_templateObject16)
   }
 };
 
@@ -145,7 +146,7 @@ var CYPRESS_RUN_BINARY = {
 
 function getPlatformInfo() {
   return util.getOsVersionAsync().then(function (version) {
-    return stripIndent(_templateObject16, os.platform(), version, util.pkgVersion());
+    return stripIndent(_templateObject17, os.platform(), version, util.pkgVersion());
   });
 }
 

package/lib/exec/spawn.js

@@ -18,8 +18,9 @@ var _require = require('../errors'),
 
 var isXlibOrLibudevRe = /^(?:Xlib|libudev)/;
 var isHighSierraWarningRe = /\*\*\* WARNING/;
+var isRenderWorkerRe = /\.RenderWorker-/;
 
-var GARBAGE_WARNINGS = [isXlibOrLibudevRe, isHighSierraWarningRe];
+var GARBAGE_WARNINGS = [isXlibOrLibudevRe, isHighSierraWarningRe, isRenderWorkerRe];
 
 var isGarbageLineWarning = function isGarbageLineWarning(str) {
   return _.some(GARBAGE_WARNINGS, function (re) {
@@ -50,7 +51,7 @@ function getStdio(needsXvfb) {
   if (needsStderrPiped(needsXvfb)) {
     // returning pipe here so we can massage stderr
     // and remove garbage from Xlib and libuv
-    // due to starting the XVFB process on linux
+    // due to starting the Xvfb process on linux
     return ['inherit', 'inherit', 'pipe'];
   }
 
@@ -58,6 +59,8 @@ function getStdio(needsXvfb) {
 }
 
 module.exports = {
+  isGarbageLineWarning: isGarbageLineWarning,
+
   start: function start(args) {
     var options = arguments.length > 1 && arguments[1] !== undefined ? arguments[1] : {};
 
@@ -68,9 +71,11 @@ module.exports = {
       executable = path.resolve(util.getEnv('CYPRESS_RUN_BINARY'));
     }
 
-    debug('needs to start own XVFB?', needsXvfb);
+    debug('needs to start own Xvfb?', needsXvfb);
 
     // always push cwd into the args
+    // which additionally acts as a signal to the
+    // binary that it was invoked through the NPM module
     args = [].concat(args, '--cwd', process.cwd());
 
     _.defaults(options, {
@@ -224,7 +229,7 @@ module.exports = {
 
     // if we are on linux and there's already a DISPLAY
     // set, then we may need to rerun cypress after
-    // spawning our own XVFB server
+    // spawning our own Xvfb server
     var linuxWithDisplayEnv = util.isPossibleLinuxWithIncorrectDisplay();
 
     return userFriendlySpawn(linuxWithDisplayEnv);

package/lib/exec/xvfb.js

@@ -1,6 +1,6 @@
 'use strict';
 
-var _templateObject = _taggedTemplateLiteral(['\n        DISPLAY environment variable is set to ', ' on Linux\n        Assuming this DISPLAY points at working X11 server,\n        Cypress will not spawn own XVFB\n\n        NOTE: if the X11 server is NOT working, Cypress will exit without explanation,\n          see ', '\n        Solution: Unset the DISPLAY variable and try again:\n          DISPLAY= npx cypress run ...\n      '], ['\n        DISPLAY environment variable is set to ', ' on Linux\n        Assuming this DISPLAY points at working X11 server,\n        Cypress will not spawn own XVFB\n\n        NOTE: if the X11 server is NOT working, Cypress will exit without explanation,\n          see ', '\n        Solution: Unset the DISPLAY variable and try again:\n          DISPLAY= npx cypress run ...\n      ']);
+var _templateObject = _taggedTemplateLiteral(['\n        DISPLAY environment variable is set to ', ' on Linux\n        Assuming this DISPLAY points at working X11 server,\n        Cypress will not spawn own Xvfb\n\n        NOTE: if the X11 server is NOT working, Cypress will exit without explanation,\n          see ', '\n        Solution: Unset the DISPLAY variable and try again:\n          DISPLAY= npx cypress run ...\n      '], ['\n        DISPLAY environment variable is set to ', ' on Linux\n        Assuming this DISPLAY points at working X11 server,\n        Cypress will not spawn own Xvfb\n\n        NOTE: if the X11 server is NOT working, Cypress will exit without explanation,\n          see ', '\n        Solution: Unset the DISPLAY variable and try again:\n          DISPLAY= npx cypress run ...\n      ']);
 
 function _taggedTemplateLiteral(strings, raw) { return Object.freeze(Object.defineProperties(strings, { raw: { value: Object.freeze(raw) } })); }
 
@@ -35,7 +35,7 @@ module.exports = {
   _xvfb: xvfb, // expose for testing
 
   start: function start() {
-    debug('Starting XVFB');
+    debug('Starting Xvfb');
 
     return xvfb.startAsync().return(null).catch({ nonZeroExitCode: true }, throwFormErrorText(errors.nonZeroExitCodeXvfb)).catch(function (err) {
       if (err.known) {
@@ -46,7 +46,7 @@ module.exports = {
     });
   },
   stop: function stop() {
-    debug('Stopping XVFB');
+    debug('Stopping Xvfb');
 
     return xvfb.stopAsync().return(null).catch(function () {
       // noop
@@ -68,7 +68,7 @@ module.exports = {
     }
 
     debug('undefined DISPLAY environment variable');
-    debug('Cypress will spawn its own XVFB');
+    debug('Cypress will spawn its own Xvfb');
 
     return true;
   },

package/lib/tasks/download.js

@@ -1,9 +1,10 @@
 'use strict';
 
-var _arguments = arguments;
-
 var _templateObject = _taggedTemplateLiteral(['\n    URL: ', '\n    ', '\n  '], ['\n    URL: ', '\n    ', '\n  ']),
-    _templateObject2 = _taggedTemplateLiteral(['\n          Failed downloading the Cypress binary.\n          Response code: ', '\n          Response message: ', '\n        '], ['\n          Failed downloading the Cypress binary.\n          Response code: ', '\n          Response message: ', '\n        ']);
+    _templateObject2 = _taggedTemplateLiteral(['\n          Corrupted download\n\n          Expected downloaded file to have checksum: ', '\n          Computed checksum: ', '\n\n          Expected downloaded file to have size: ', '\n          Computed size: ', '\n        '], ['\n          Corrupted download\n\n          Expected downloaded file to have checksum: ', '\n          Computed checksum: ', '\n\n          Expected downloaded file to have size: ', '\n          Computed size: ', '\n        ']),
+    _templateObject3 = _taggedTemplateLiteral(['\n        Corrupted download\n\n        Expected downloaded file to have checksum: ', '\n        Computed checksum: ', '\n      '], ['\n        Corrupted download\n\n        Expected downloaded file to have checksum: ', '\n        Computed checksum: ', '\n      ']),
+    _templateObject4 = _taggedTemplateLiteral(['\n          Corrupted download\n\n          Expected downloaded file to have size: ', '\n          Computed size: ', '\n        '], ['\n          Corrupted download\n\n          Expected downloaded file to have size: ', '\n          Computed size: ', '\n        ']),
+    _templateObject5 = _taggedTemplateLiteral(['\n          Failed downloading the Cypress binary.\n          Response code: ', '\n          Response message: ', '\n        '], ['\n          Failed downloading the Cypress binary.\n          Response code: ', '\n          Response message: ', '\n        ']);
 
 function _taggedTemplateLiteral(strings, raw) { return Object.freeze(Object.defineProperties(strings, { raw: { value: Object.freeze(raw) } })); }
 
@@ -30,6 +31,10 @@ var util = require('../util');
 
 var defaultBaseUrl = 'https://download.cypress.io/';
 
+var getProxyUrl = function getProxyUrl() {
+  return process.env.HTTPS_PROXY || process.env.https_proxy || process.env.npm_config_https_proxy || process.env.HTTP_PROXY || process.env.http_proxy || process.env.npm_config_proxy || null;
+};
+
 var getRealOsArch = function getRealOsArch() {
   // os.arch() returns the arch for which this node was compiled
   // we want the operating system's arch instead: x64 or x86
@@ -88,6 +93,71 @@ var prettyDownloadErr = function prettyDownloadErr(err, version) {
   return throwFormErrorText(errors.failedDownload)(msg);
 };
 
+/**
+ * Checks checksum and file size for the given file. Allows both
+ * values or just one of them to be checked.
+ */
+var verifyDownloadedFile = function verifyDownloadedFile(filename, expectedSize, expectedChecksum) {
+  if (expectedSize && expectedChecksum) {
+    debug('verifying checksum and file size');
+
+    return Promise.join(util.getFileChecksum(filename), util.getFileSize(filename), function (checksum, filesize) {
+      if (checksum === expectedChecksum && filesize === expectedSize) {
+        debug('downloaded file has the expected checksum and size ✅');
+
+        return;
+      }
+
+      debug('raising error: checksum or file size mismatch');
+      var text = stripIndent(_templateObject2, expectedChecksum, checksum, expectedSize, filesize);
+
+      debug(text);
+
+      throw new Error(text);
+    });
+  }
+
+  if (expectedChecksum) {
+    debug('only checking expected file checksum %d', expectedChecksum);
+
+    return util.getFileChecksum(filename).then(function (checksum) {
+      if (checksum === expectedChecksum) {
+        debug('downloaded file has the expected checksum ✅');
+
+        return;
+      }
+
+      debug('raising error: file checksum mismatch');
+      var text = stripIndent(_templateObject3, expectedChecksum, checksum);
+
+      throw new Error(text);
+    });
+  }
+
+  if (expectedSize) {
+    // maybe we don't have a checksum, but at least CDN returns content length
+    // which we can check against the file size
+    debug('only checking expected file size %d', expectedSize);
+
+    return util.getFileSize(filename).then(function (filesize) {
+      if (filesize === expectedSize) {
+        debug('downloaded file has the expected size ✅');
+
+        return;
+      }
+
+      debug('raising error: file size mismatch');
+      var text = stripIndent(_templateObject4, expectedSize, filesize);
+
+      throw new Error(text);
+    });
+  }
+
+  debug('downloaded file lacks checksum or size to verify');
+
+  return Promise.resolve();
+};
+
 // downloads from given url
 // return an object with
 // {filename: ..., downloaded: true}
@@ -97,13 +167,19 @@ var downloadFromUrl = function downloadFromUrl(_ref) {
       progress = _ref.progress;
 
   return new Promise(function (resolve, reject) {
-    debug('Downloading from', url);
-    debug('Saving file to', downloadDestination);
+    var proxy = getProxyUrl();
+
+    debug('Downloading package', {
+      url: url,
+      proxy: proxy,
+      downloadDestination: downloadDestination
+    });
 
     var redirectVersion = void 0;
 
     var req = request({
       url: url,
+      proxy: proxy,
       followRedirect: function followRedirect(response) {
         var version = response.headers['x-version'];
 
@@ -122,10 +198,30 @@ var downloadFromUrl = function downloadFromUrl(_ref) {
 
     // closure
     var started = null;
+    var expectedSize = void 0;
+    var expectedChecksum = void 0;
 
     requestProgress(req, {
       throttle: progress.throttle
     }).on('response', function (response) {
+      // we have computed checksum and filesize during test runner binary build
+      // and have set it on the S3 object as user meta data, available via
+      // these custom headers "x-amz-meta-..."
+      // see https://github.com/cypress-io/cypress/pull/4092
+      expectedSize = response.headers['x-amz-meta-size'] || response.headers['content-length'];
+
+      expectedChecksum = response.headers['x-amz-meta-checksum'];
+
+      if (expectedChecksum) {
+        debug('expected checksum %s', expectedChecksum);
+      }
+
+      if (expectedSize) {
+        // convert from string (all Amazon custom headers are strings)
+        expectedSize = Number(expectedSize);
+        debug('expected file size %d', expectedSize);
+      }
+
       // start counting now once we've gotten
       // response headers
       started = new Date();
@@ -134,7 +230,7 @@ var downloadFromUrl = function downloadFromUrl(_ref) {
       if (!/^2/.test(response.statusCode)) {
         debug('response code %d', response.statusCode);
 
-        var err = new Error(stripIndent(_templateObject2, response.statusCode, response.statusMessage));
+        var err = new Error(stripIndent(_templateObject5, response.statusCode, response.statusMessage));
 
         reject(err);
       }
@@ -143,27 +239,38 @@ var downloadFromUrl = function downloadFromUrl(_ref) {
       // starting on our first progress notification
       var elapsed = new Date() - started;
 
-      var eta = util.calculateEta(state.percent, elapsed);
+      // request-progress sends a value between 0 and 1
+      var percentage = util.convertPercentToPercentage(state.percent);
+
+      var eta = util.calculateEta(percentage, elapsed);
 
       // send up our percent and seconds remaining
-      progress.onProgress(state.percent, util.secsRemaining(eta));
+      progress.onProgress(percentage, util.secsRemaining(eta));
     })
     // save this download here
     .pipe(fs.createWriteStream(downloadDestination)).on('finish', function () {
       debug('downloading finished');
 
-      resolve(redirectVersion);
+      verifyDownloadedFile(downloadDestination, expectedSize, expectedChecksum).then(function () {
+        return resolve(redirectVersion);
+      }, reject);
     });
   });
 };
 
-var start = function start(_ref2) {
-  var version = _ref2.version,
-      downloadDestination = _ref2.downloadDestination,
-      progress = _ref2.progress;
+/**
+ * Download Cypress.zip from external url to local file.
+ * @param [string] version Could be "3.3.0" or full URL
+ * @param [string] downloadDestination Local filename to save as
+ */
+var start = function start(opts) {
+  var version = opts.version,
+      downloadDestination = opts.downloadDestination,
+      progress = opts.progress;
+
 
   if (!downloadDestination) {
-    la(is.unemptyString(downloadDestination), 'missing download dir', _arguments);
+    la(is.unemptyString(downloadDestination), 'missing download dir', opts);
   }
 
   if (!progress) {
@@ -177,6 +284,7 @@ var start = function start(_ref2) {
   progress.throttle = 100;
 
   debug('needed Cypress version: %s', version);
+  debug('source url %s', url);
   debug('downloading cypress.zip to "' + downloadDestination + '"');
 
   // ensure download dir exists
@@ -189,5 +297,6 @@ var start = function start(_ref2) {
 
 module.exports = {
   start: start,
-  getUrl: getUrl
+  getUrl: getUrl,
+  getProxyUrl: getProxyUrl
 };

package/lib/tasks/install.js

@@ -1,6 +1,6 @@
 'use strict';
 
-var _templateObject = _taggedTemplateLiteral(['    \n      Skipping installation:\n  \n        Pass the ', ' option if you\'d like to reinstall anyway.\n    '], ['    \n      Skipping installation:\n  \n        Pass the ', ' option if you\'d like to reinstall anyway.\n    ']),
+var _templateObject = _taggedTemplateLiteral(['\n      Skipping installation:\n\n        Pass the ', ' option if you\'d like to reinstall anyway.\n    '], ['\n      Skipping installation:\n\n        Pass the ', ' option if you\'d like to reinstall anyway.\n    ']),
     _templateObject2 = _taggedTemplateLiteral(['\n      ', ' Warning: It looks like you\'ve installed Cypress globally.\n\n        This will work, but it\'s not recommended.\n\n        The recommended way to install Cypress is as a devDependency per project.\n\n        You should probably run these commands:\n\n        - ', '\n        - ', '\n    '], ['\n      ', ' Warning: It looks like you\\\'ve installed Cypress globally.\n\n        This will work, but it\'\\s not recommended.\n\n        The recommended way to install Cypress is as a devDependency per project.\n\n        You should probably run these commands:\n\n        - ', '\n        - ', '\n    ']),
     _templateObject3 = _taggedTemplateLiteral(['\n        ', ' Skipping binary installation: Environment variable CYPRESS_INSTALL_BINARY = 0.'], ['\n        ', ' Skipping binary installation: Environment variable CYPRESS_INSTALL_BINARY = 0.']),
     _templateObject4 = _taggedTemplateLiteral(['\n        ', ' Overriding Cypress cache directory to: ', '\n\n              Previous installs of Cypress may not be found.\n      '], ['\n        ', ' Overriding Cypress cache directory to: ', '\n\n              Previous installs of Cypress may not be found.\n      ']),
@@ -144,13 +144,17 @@ var start = function start() {
   // let this environment variable reset the binary version we need
   if (util.getEnv('CYPRESS_INSTALL_BINARY')) {
 
-    var envVarVersion = util.getEnv('CYPRESS_INSTALL_BINARY');
+    // because passed file paths are often double quoted
+    // and might have extra whitespace around, be robust and trim the string
+    var trimAndRemoveDoubleQuotes = true;
+    var envVarVersion = util.getEnv('CYPRESS_INSTALL_BINARY', trimAndRemoveDoubleQuotes);
 
-    debug('using environment variable CYPRESS_INSTALL_BINARY %s', envVarVersion);
+    debug('using environment variable CYPRESS_INSTALL_BINARY "%s"', envVarVersion);
 
     if (envVarVersion === '0') {
       debug('environment variable CYPRESS_INSTALL_BINARY = 0, skipping install');
       logger.log(stripIndent(_templateObject3, chalk.yellow('Note:')));
+
       logger.log();
 
       return Promise.resolve();
@@ -169,6 +173,7 @@ var start = function start() {
     var envCache = util.getEnv('CYPRESS_CACHE_FOLDER');
 
     logger.log(stripIndent(_templateObject4, chalk.yellow('Note:'), chalk.cyan(envCache)));
+
     logger.log();
   }
 
@@ -192,6 +197,7 @@ var start = function start() {
 
     logger.log();
     logger.log(stripIndent(_templateObject6, chalk.green(binaryVersion), chalk.cyan(installDir)));
+
     logger.log();
 
     if (options.force) {
@@ -218,6 +224,7 @@ var start = function start() {
 
     if (needVersion !== pkgVersion) {
       logger.log(chalk.yellow(stripIndent(_templateObject7, logSymbols.warning, chalk.green(pkgVersion), chalk.green(needVersion))));
+
       logger.log();
     }
 

package/lib/tasks/verify.js

@@ -30,6 +30,8 @@ var logger = require('../logger');
 var xvfb = require('../exec/xvfb');
 var state = require('./state');
 
+var VERIFY_TEST_RUNNER_TIMEOUT_MS = 30000;
+
 var checkExecutable = function checkExecutable(binaryDir) {
   var executable = state.getPathToExecutable(binaryDir);
 
@@ -78,7 +80,7 @@ var runSmokeTest = function runSmokeTest(binaryDir, options) {
 
   var needsXvfb = xvfb.isNeeded();
 
-  debug('needs XVFB?', needsXvfb);
+  debug('needs Xvfb?', needsXvfb);
 
   /**
    * Spawn Cypress running smoke test to check if all operating system
@@ -88,8 +90,6 @@ var runSmokeTest = function runSmokeTest(binaryDir, options) {
     var random = _.random(0, 1000);
     var args = ['--smoke-test', '--ping=' + random];
 
-    process.env.ELECTRON_ENABLE_LOGGING = true;
-
     if (options.dev) {
       executable = 'node';
       args.unshift(path.resolve(__dirname, '..', '..', '..', 'scripts', 'start.js'));
@@ -100,8 +100,18 @@ var runSmokeTest = function runSmokeTest(binaryDir, options) {
     debug('running smoke test');
     debug('using Cypress executable %s', executable);
     debug('smoke test command:', smokeTestCommand);
+    debug('smoke test timeout %d ms', options.smokeTestTimeout);
+
+    var env = _.extend({}, process.env, {
+      ELECTRON_ENABLE_LOGGING: true
+    });
 
-    return Promise.resolve(util.exec(executable, args, { timeout: options.smokeTestTimeout })).catch(onSmokeTestError(smokeTestCommand, linuxWithDisplayEnv)).then(function (result) {
+    var stdioOptions = _.extend({}, {
+      env: env,
+      timeout: options.smokeTestTimeout
+    });
+
+    return Promise.resolve(util.exec(executable, args, stdioOptions)).catch(onSmokeTestError(smokeTestCommand, linuxWithDisplayEnv)).then(function (result) {
       // TODO: when execa > 1.1 is released
       // change this to `result.all` for both stderr and stdout
       var smokeTestReturned = result.stdout;
@@ -136,7 +146,7 @@ var runSmokeTest = function runSmokeTest(binaryDir, options) {
 
   // if we are on linux and there's already a DISPLAY
   // set, then we may need to rerun cypress after
-  // spawning our own XVFB server
+  // spawning our own Xvfb server
   var linuxWithDisplayEnv = util.isPossibleLinuxWithIncorrectDisplay();
 
   return userFriendlySpawn(linuxWithDisplayEnv);
@@ -217,7 +227,7 @@ var start = function start() {
     dev: false,
     force: false,
     welcomeMessage: true,
-    smokeTestTimeout: 10000
+    smokeTestTimeout: VERIFY_TEST_RUNNER_TIMEOUT_MS
   });
 
   if (options.dev) {
@@ -229,6 +239,7 @@ var start = function start() {
 
     debug('CYPRESS_RUN_BINARY exists, =', envBinaryPath);
     logger.log(stripIndent(_templateObject3, chalk.yellow('Note:'), chalk.white('CYPRESS_RUN_BINARY='), chalk.cyan(envBinaryPath)));
+
     logger.log();
 
     return util.isExecutableAsync(envBinaryPath).then(function (isExecutable) {
@@ -293,5 +304,6 @@ var start = function start() {
 };
 
 module.exports = {
-  start: start
+  start: start,
+  VERIFY_TEST_RUNNER_TIMEOUT_MS: VERIFY_TEST_RUNNER_TIMEOUT_MS
 };