cx 26.0.14 → 26.1.1

package/src/ui/app/History.ts

@@ -1,133 +1,133 @@
-import { Url } from "./Url";
-import { batchUpdatesAndNotify } from "../batchUpdates";
-import { SubscriberList } from "../../util/SubscriberList";
-import { View } from "../../data/View";
-
-interface Transition {
-   url: string;
-   state: any;
-   title: string | null;
-   replace: boolean;
-   completed?: boolean;
-}
-
-type NavigateConfirmationCallback = (state: any) => boolean | Promise<boolean>;
-
-let last = 0;
-let next = 1;
-let transitions: Record<number, Transition> = {};
-let subscribers: SubscriberList | null = null;
-let reload = false;
-let navigateConfirmationCallback: NavigateConfirmationCallback | null = null;
-let permanentNavigateConfirmation = false;
-
-export class History {
-   static store: View;
-   static urlBinding: string;
-   static hashBinding?: string;
-
-   static connect(store: View, urlBinding: string, hashBinding?: string): void {
-      this.store = store;
-      this.urlBinding = urlBinding;
-      this.hashBinding = hashBinding;
-      this.updateStore();
-      window.onpopstate = () => {
-         this.updateStore();
-      };
-   }
-
-   static pushState(state: any, title: string | null, url: string): boolean {
-      return this.confirmAndNavigate(state, title, url);
-   }
-
-   static replaceState(state: any, title: string | null, url: string): boolean {
-      return this.navigate(state, title, url, true);
-   }
-
-   static reloadOnNextChange(): void {
-      reload = true;
-   }
-
-   static addNavigateConfirmation(callback: NavigateConfirmationCallback, permanent = false): void {
-      navigateConfirmationCallback = callback;
-      permanentNavigateConfirmation = permanent;
-   }
-
-   static confirm(continueCallback: () => boolean, state: any): boolean {
-      if (!navigateConfirmationCallback) return continueCallback();
-
-      let result = navigateConfirmationCallback(state);
-      Promise.resolve(result).then((value) => {
-         if (value) {
-            if (!permanentNavigateConfirmation) navigateConfirmationCallback = null;
-            continueCallback();
-         }
-      });
-
-      return false;
-   }
-
-   static confirmAndNavigate(state: any, title: string | null, url: string, replace?: boolean): boolean {
-      return this.confirm(() => this.navigate(state, title, url, replace), url);
-   }
-
-   static navigate(state: any, title: string | null, url: string, replace = false): boolean {
-      url = Url.resolve(url);
-
-      if (!window.history.pushState || reload) {
-         window.location[replace ? "replace" : "assign"](url);
-         return true;
-      }
-
-      let transition: Transition | undefined;
-      let changed = false;
-      batchUpdatesAndNotify(
-         () => {
-            changed = this.updateStore(url);
-            if (changed)
-               transitions[++last] = transition = {
-                  url,
-                  state,
-                  title,
-                  replace,
-               };
-         },
-         () => {
-            if (transition) transition.completed = true;
-
-            //update history once the page is rendered and the title is set
-            while (transitions[next] && transitions[next].completed) {
-               let tr = transitions[next];
-               delete transitions[next];
-               next++;
-               if (tr.replace) {
-                  window.history.replaceState(tr.state, tr.title ?? "", tr.url);
-                  if (subscribers) subscribers.notify(tr.url, "replaceState");
-               } else {
-                  window.history.pushState(tr.state, tr.title ?? "", tr.url);
-                  if (subscribers) subscribers.notify(tr.url, "pushState");
-               }
-            }
-         },
-      );
-
-      return changed;
-   }
-
-   static updateStore(href?: string): boolean {
-      let url = Url.unresolve(href || document.location.href);
-      let hash: string | null = null;
-      let hashIndex = url.indexOf("#");
-      if (hashIndex !== -1) {
-         hash = url.substring(hashIndex);
-         url = url.substring(0, hashIndex);
-      }
-      if (this.hashBinding) this.store.set(this.hashBinding, hash);
-      return this.store.set(this.urlBinding, url);
-   }
-
-   static subscribe(callback: (url: string, op: string) => void): () => void {
-      if (!subscribers) subscribers = new SubscriberList();
-      return subscribers.subscribe(callback);
-   }
-}
+import { Url } from "./Url";
+import { batchUpdatesAndNotify } from "../batchUpdates";
+import { SubscriberList } from "../../util/SubscriberList";
+import { View } from "../../data/View";
+
+interface Transition {
+   url: string;
+   state: any;
+   title: string | null;
+   replace: boolean;
+   completed?: boolean;
+}
+
+type NavigateConfirmationCallback = (state: any) => boolean | Promise<boolean>;
+
+let last = 0;
+let next = 1;
+let transitions: Record<number, Transition> = {};
+let subscribers: SubscriberList | null = null;
+let reload = false;
+let navigateConfirmationCallback: NavigateConfirmationCallback | null = null;
+let permanentNavigateConfirmation = false;
+
+export class History {
+   static store: View;
+   static urlBinding: string;
+   static hashBinding?: string;
+
+   static connect(store: View, urlBinding: string, hashBinding?: string): void {
+      this.store = store;
+      this.urlBinding = urlBinding;
+      this.hashBinding = hashBinding;
+      this.updateStore();
+      window.onpopstate = () => {
+         this.updateStore();
+      };
+   }
+
+   static pushState(state: any, title: string | null, url: string): boolean {
+      return this.confirmAndNavigate(state, title, url);
+   }
+
+   static replaceState(state: any, title: string | null, url: string): boolean {
+      return this.navigate(state, title, url, true);
+   }
+
+   static reloadOnNextChange(): void {
+      reload = true;
+   }
+
+   static addNavigateConfirmation(callback: NavigateConfirmationCallback, permanent = false): void {
+      navigateConfirmationCallback = callback;
+      permanentNavigateConfirmation = permanent;
+   }
+
+   static confirm(continueCallback: () => boolean, state: any): boolean {
+      if (!navigateConfirmationCallback) return continueCallback();
+
+      let result = navigateConfirmationCallback(state);
+      Promise.resolve(result).then((value) => {
+         if (value) {
+            if (!permanentNavigateConfirmation) navigateConfirmationCallback = null;
+            continueCallback();
+         }
+      });
+
+      return false;
+   }
+
+   static confirmAndNavigate(state: any, title: string | null, url: string, replace?: boolean): boolean {
+      return this.confirm(() => this.navigate(state, title, url, replace), url);
+   }
+
+   static navigate(state: any, title: string | null, url: string, replace = false): boolean {
+      url = Url.resolve(url);
+
+      if (!window.history.pushState || reload) {
+         window.location[replace ? "replace" : "assign"](url);
+         return true;
+      }
+
+      let transition: Transition | undefined;
+      let changed = false;
+      batchUpdatesAndNotify(
+         () => {
+            changed = this.updateStore(url);
+            if (changed)
+               transitions[++last] = transition = {
+                  url,
+                  state,
+                  title,
+                  replace,
+               };
+         },
+         () => {
+            if (transition) transition.completed = true;
+
+            //update history once the page is rendered and the title is set
+            while (transitions[next] && transitions[next].completed) {
+               let tr = transitions[next];
+               delete transitions[next];
+               next++;
+               if (tr.replace) {
+                  window.history.replaceState(tr.state, tr.title ?? "", tr.url);
+                  if (subscribers) subscribers.notify(tr.url, "replaceState");
+               } else {
+                  window.history.pushState(tr.state, tr.title ?? "", tr.url);
+                  if (subscribers) subscribers.notify(tr.url, "pushState");
+               }
+            }
+         },
+      );
+
+      return changed;
+   }
+
+   static updateStore(href?: string): boolean {
+      let url = Url.unresolve(href || document.location.href);
+      let hash: string | null = null;
+      let hashIndex = url.indexOf("#");
+      if (hashIndex !== -1) {
+         hash = url.substring(hashIndex);
+         url = url.substring(0, hashIndex);
+      }
+      if (this.hashBinding) this.store.set(this.hashBinding, hash);
+      return this.store.set(this.urlBinding, url);
+   }
+
+   static subscribe(callback: (url: string, op: string) => void): () => void {
+      if (!subscribers) subscribers = new SubscriberList();
+      return subscribers.subscribe(callback);
+   }
+}

package/src/ui/app/Url.spec.ts

@@ -1,50 +1,50 @@
-import { Url } from "./Url";
-import Route from "route-parser";
-import assert from "assert";
-describe("Url", function () {
-   describe(".unresolve", function () {
-      it("preserves query parameters", function () {
-         Url.absoluteBase = "https://cxjs.io/docs/";
-         assert.equal("~/?state=1", Url.unresolve("https://cxjs.io/docs/?state=1"));
-      });
-
-      it("doesn't touch unresolved urls", function () {
-         assert.equal("~/test", Url.unresolve("~/test"));
-      });
-   });
-
-   describe(".getBaseFromScriptSrc", () => {
-      it("ignores query strings", function () {
-         assert.equal(Url.getBaseFromScriptSrc("/vendor.js?qs=1", "~/vendor.js"), "/");
-      });
-
-      it("allows wildcards", function () {
-         assert.equal(Url.getBaseFromScriptSrc("/vendor.123.js?qs=1", "~/vendor.*.js"), "/");
-      });
-
-      it("works for an application folder", function () {
-         assert.equal(Url.getBaseFromScriptSrc("/datasync/vendor.124c82.js", "~/vendor.*.js"), "/datasync/");
-      });
-   });
-});
-
-describe("Route", function () {
-   it("matches query param", function () {
-      let route = new Route("~/?state=:state");
-      let result = route.match("~/?state=1");
-      assert(result !== false);
-      assert.equal(result.state, "1");
-   });
-
-   it("matches routes with extra query params", function () {
-      let route = new Route("~/?state=:state");
-      let result = route.match("~/?state=1&more=2");
-      assert(result);
-   });
-
-   it.skip("matches query params in any order", function () {
-      let route = new Route("~/?a=:a&b=:b");
-      let result = route.match("~/?b=1&a=2");
-      assert(result);
-   });
-});
+import { Url } from "./Url";
+import Route from "route-parser";
+import assert from "assert";
+describe("Url", function () {
+   describe(".unresolve", function () {
+      it("preserves query parameters", function () {
+         Url.absoluteBase = "https://cxjs.io/docs/";
+         assert.equal("~/?state=1", Url.unresolve("https://cxjs.io/docs/?state=1"));
+      });
+
+      it("doesn't touch unresolved urls", function () {
+         assert.equal("~/test", Url.unresolve("~/test"));
+      });
+   });
+
+   describe(".getBaseFromScriptSrc", () => {
+      it("ignores query strings", function () {
+         assert.equal(Url.getBaseFromScriptSrc("/vendor.js?qs=1", "~/vendor.js"), "/");
+      });
+
+      it("allows wildcards", function () {
+         assert.equal(Url.getBaseFromScriptSrc("/vendor.123.js?qs=1", "~/vendor.*.js"), "/");
+      });
+
+      it("works for an application folder", function () {
+         assert.equal(Url.getBaseFromScriptSrc("/datasync/vendor.124c82.js", "~/vendor.*.js"), "/datasync/");
+      });
+   });
+});
+
+describe("Route", function () {
+   it("matches query param", function () {
+      let route = new Route("~/?state=:state");
+      let result = route.match("~/?state=1");
+      assert(result !== false);
+      assert.equal(result.state, "1");
+   });
+
+   it("matches routes with extra query params", function () {
+      let route = new Route("~/?state=:state");
+      let result = route.match("~/?state=1&more=2");
+      assert(result);
+   });
+
+   it.skip("matches query params in any order", function () {
+      let route = new Route("~/?a=:a&b=:b");
+      let result = route.match("~/?b=1&a=2");
+      assert(result);
+   });
+});

package/src/ui/app/startAppLoop.tsx

@@ -1,6 +1,7 @@
 /** @jsxImportSource react */
 
-import { Widget, VDOM, WidgetConfig } from "../Widget";
+import type { Root } from "cx-react";
+import { Widget, VDOM } from "../Widget";
 import { Store } from "../../data/Store";
 import { Cx } from "../Cx";
 import { Instance } from "../Instance";
@@ -44,11 +45,8 @@ export function startAppLoop(
       />
    ) as any;
 
-   let root: any = null;
-   if (VDOM.DOM.createRoot) {
-      root = VDOM.DOM.createRoot(parentDOMElement);
-      root.render(content);
-   } else VDOM.DOM.render(content, parentDOMElement);
+   let root = VDOM.DOM.createRoot(parentDOMElement);
+   root.render(content);
 
    let stopped = false;
 
@@ -66,10 +64,8 @@ export function startAppLoop(
    };
 }
 
-function destroy(parentDOMElement: HTMLElement, options: StartAppLoopOptions, root: any): void {
+function destroy(parentDOMElement: HTMLElement, options: StartAppLoopOptions, root: Root): void {
    if (root) root.unmount();
-   else VDOM.DOM.unmountComponentAtNode(parentDOMElement);
-
    if (options.removeParentDOMElement && parentDOMElement.parentNode)
       parentDOMElement.parentNode.removeChild(parentDOMElement);
 }

package/src/ui/app/startHotAppLoop.ts

@@ -1,41 +1,41 @@
-import { startAppLoop, StartAppLoopOptions } from "./startAppLoop";
-import { Widget, WidgetConfig } from "../Widget";
-import { Store } from "../../data/Store";
-import { Create } from "../../util/Component";
-
-export interface HotModule {
-   hot?: {
-      accept: () => void;
-      dispose: (callback: (data: any) => void) => void;
-      data?: any;
-   };
-}
-
-export function startHotAppLoop(
-   appModule: HotModule,
-   element: HTMLElement,
-   store: Store,
-   widgets: Create<typeof Widget> | Create<typeof Widget>[],
-   options: StartAppLoopOptions = {},
-): () => void {
-   let stop: (() => void) | undefined;
-   //webpack (HMR)
-   if (appModule.hot) {
-      // accept itself
-      appModule.hot.accept();
-
-      // remember data on dispose
-      appModule.hot.dispose(function (data: any) {
-         data.state = store.getData();
-         if (stop) stop();
-      });
-
-      //apply data on hot replace
-      if (appModule.hot.data?.state) store.load(appModule.hot.data.state);
-   }
-
-   Widget.resetCounter();
-
-   //app loop
-   return (stop = startAppLoop(element, store, widgets, options));
-}
+import { startAppLoop, StartAppLoopOptions } from "./startAppLoop";
+import { Widget, WidgetConfig } from "../Widget";
+import { Store } from "../../data/Store";
+import { Create } from "../../util/Component";
+
+export interface HotModule {
+   hot?: {
+      accept: () => void;
+      dispose: (callback: (data: any) => void) => void;
+      data?: any;
+   };
+}
+
+export function startHotAppLoop(
+   appModule: HotModule,
+   element: HTMLElement,
+   store: Store,
+   widgets: Create<typeof Widget> | Create<typeof Widget>[],
+   options: StartAppLoopOptions = {},
+): () => void {
+   let stop: (() => void) | undefined;
+   //webpack (HMR)
+   if (appModule.hot) {
+      // accept itself
+      appModule.hot.accept();
+
+      // remember data on dispose
+      appModule.hot.dispose(function (data: any) {
+         data.state = store.getData();
+         if (stop) stop();
+      });
+
+      //apply data on hot replace
+      if (appModule.hot.data?.state) store.load(appModule.hot.data.state);
+   }
+
+   Widget.resetCounter();
+
+   //app loop
+   return (stop = startAppLoop(element, store, widgets, options));
+}

package/src/ui/createFunctionalComponent.spec.tsx

@@ -2,7 +2,7 @@ import { Store } from "../data/Store";
 import { createFunctionalComponent } from "./createFunctionalComponent";
 import { bind } from "./bind";
 import { expr } from "./expr";
-import { createTestRenderer } from "../util/test/createTestRenderer";
+import { createTestRenderer, act } from "../util/test/createTestRenderer";
 
 import assert from "assert";
 import { Rescope } from "./Rescope";
@@ -66,7 +66,7 @@ describe("createFunctionalComponent type safety", () => {
 });
 
 describe("createFunctionalComponent", () => {
-   it("allows spread", () => {
+   it("allows spread", async () => {
       const SuperDiv = createFunctionalComponent(({ ...props }) => {
          return (
             <cx>
@@ -88,7 +88,7 @@ describe("createFunctionalComponent", () => {
 
       let store = new Store();
 
-      const component = createTestRenderer(store, widget);
+      const component = await createTestRenderer(store, widget);
 
       let tree = component.toJSON();
       assert.deepEqual(tree, {
@@ -103,7 +103,7 @@ describe("createFunctionalComponent", () => {
       });
    });
 
-   it("visible and Rescope behave as expected", () => {
+   it("visible and Rescope behave as expected", async () => {
       const RootRescope = createFunctionalComponent(({}) => {
          return (
             <cx>
@@ -128,7 +128,7 @@ describe("createFunctionalComponent", () => {
          },
       });
 
-      const component = createTestRenderer(store, widget);
+      const component = await createTestRenderer(store, widget);
 
       let tree = component.toJSON();
       assert.deepEqual(tree, {
@@ -138,7 +138,7 @@ describe("createFunctionalComponent", () => {
       });
    });
 
-   it("visible and multiple items behave as expected", () => {
+   it("visible and multiple items behave as expected", async () => {
       const FComponent = createFunctionalComponent(({}) => {
          return (
             <cx>
@@ -157,7 +157,7 @@ describe("createFunctionalComponent", () => {
 
       let store = new Store();
 
-      const component = createTestRenderer(store, widget);
+      const component = await createTestRenderer(store, widget);
 
       let tree = component.toJSON();
       assert.deepEqual(tree, [
@@ -174,7 +174,7 @@ describe("createFunctionalComponent", () => {
       ]);
    });
 
-   it("respects inner layouts", () => {
+   it("respects inner layouts", async () => {
       const FComponent = createFunctionalComponent(({}) => {
          return (
             <cx>
@@ -194,7 +194,7 @@ describe("createFunctionalComponent", () => {
 
       let store = new Store();
 
-      const component = createTestRenderer(store, widget);
+      const component = await createTestRenderer(store, widget);
 
       let tree = component.toJSON();
 
@@ -279,7 +279,7 @@ describe("createFunctionalComponent", () => {
       });
    });
 
-   it("can use refs for data bindings", () => {
+   it("can use refs for data bindings", async () => {
       const X = createFunctionalComponent(({}) => {
          let { ref } = useStoreMethods();
          let x = ref("x", "OK");
@@ -298,7 +298,7 @@ describe("createFunctionalComponent", () => {
 
       let store = new Store();
 
-      const component = createTestRenderer(store, widget);
+      const component = await createTestRenderer(store, widget);
 
       let tree = component.toJSON();
       assert.deepEqual(tree, {
@@ -308,7 +308,7 @@ describe("createFunctionalComponent", () => {
       });
    });
 
-   it("adds children at the right place", () => {
+   it("adds children at the right place", async () => {
       const X = createFunctionalComponent(({ children }: { children: any }) => (
          <cx>
             <header />
@@ -327,7 +327,7 @@ describe("createFunctionalComponent", () => {
 
       let store = new Store();
 
-      const component = createTestRenderer(store, widget);
+      const component = await createTestRenderer(store, widget);
 
       let tree = component.toJSON();
 
@@ -356,7 +356,7 @@ describe("createFunctionalComponent", () => {
       ]);
    });
 
-   it("works well with repeaters", () => {
+   it("works well with repeaters", async () => {
       const X = createFunctionalComponent(({}) => {
          let { ref } = useStoreMethods();
          let text = ref("$record.text");
@@ -377,7 +377,7 @@ describe("createFunctionalComponent", () => {
 
       let store = new Store({ data: { array: [{ text: "0" }, { text: "1" }, { text: "2" }] } });
 
-      const component = createTestRenderer(store, widget);
+      const component = await createTestRenderer(store, widget);
 
       let tree = component.toJSON();
 
@@ -399,7 +399,9 @@ describe("createFunctionalComponent", () => {
          },
       ]);
 
-      store.update("array", (array) => [array[0], { text: "10" }, array[2]]);
+      await act(async () => {
+         store.update("array", (array) => [array[0], { text: "10" }, array[2]]);
+      });
 
       tree = component.toJSON();
 
@@ -422,7 +424,7 @@ describe("createFunctionalComponent", () => {
       ]);
    });
 
-   it("can have its own layout", () => {
+   it("can have its own layout", async () => {
       const X = createFunctionalComponent(() => (
          <cx>
             <div>1</div>
@@ -439,7 +441,7 @@ describe("createFunctionalComponent", () => {
 
       let store = new Store();
 
-      const component = createTestRenderer(store, widget);
+      const component = await createTestRenderer(store, widget);
 
       let tree = component.toJSON();