cursor-mcp-feedback 2.0.4 → 2.0.5

package/README.md

@@ -138,7 +138,7 @@ On first startup (or `npm install -g`), the MCP server **automatically configure
 
 - **Cursor rule** (`~/.cursor/rules/cursor-mcp-feedback.mdc`) — instructs the agent to call `interactive_feedback`
 - **Cursor hooks** (`~/.cursor/hooks/`) — subagent protection + pending message delivery + event logging
-- **hooks.json entries** — registers `sessionStart`, `subagentStart`, `subagentStop`, `beforeMCPExecution`, `preToolUse`, `afterMCPExecution` hooks
+- **hooks.json entries** — registers `subagentStart`, `subagentStop`, `beforeMCPExecution`, `afterMCPExecution`, `preToolUse` hooks
 
 All auto-installed files are kept in sync on every startup (hash-based diffing, idempotent).
 
@@ -182,11 +182,8 @@ Add to `~/Library/Application Support/Claude/claude_desktop_config.json` (macOS)
 
 | Hook | Event | Purpose |
 |------|-------|---------|
-| `block-cursor-mcp-feedback.js` | `sessionStart` | Create per-session directory & metadata |
-| `block-cursor-mcp-feedback.js` | `sessionEnd` | Mark session inactive, reset subagent counter |
 | `block-cursor-mcp-feedback.js` | `subagentStart` | Increment active subagent counter for parent conversation |
 | `block-cursor-mcp-feedback.js` | `subagentStop` | Decrement active subagent counter |
-| `block-cursor-mcp-feedback.js` | `preToolUse` | Deny feedback tool calls when subagents are active (matcher: `MCP:interactive_feedback\|MCP:submit_feedback`) |
 | `block-cursor-mcp-feedback.js` | `beforeMCPExecution` | Deny cursor-mcp-feedback MCP calls when subagents are active |
 | `block-cursor-mcp-feedback.js` | `afterMCPExecution` | Log feedback_request/response events to events.jsonl |
 | `consume-pending.js` | `preToolUse` | Consume pending messages and inject as agent feedback |

package/dist/main.js

@@ -99,16 +99,13 @@ function installCursorHooks() {
         // Each entry has a unique _source tag for idempotent upsert.
         // Multiple entries per event are supported via distinct _source values.
         const entries = [
-            { event: "sessionStart", hook: { command: `${node} ${blockHook} sessionStart`, _source: "cursor-mcp-feedback" } },
-            { event: "sessionEnd", hook: { command: `${node} ${blockHook} sessionEnd`, _source: "cursor-mcp-feedback" } },
             { event: "subagentStart", hook: { command: `${node} ${blockHook} subagentStart`, _source: "cursor-mcp-feedback" } },
             { event: "subagentStop", hook: { command: `${node} ${blockHook} subagentStop`, _source: "cursor-mcp-feedback" } },
             { event: "beforeMCPExecution", hook: { command: `${node} ${blockHook} beforeMCPExecution`, failClosed: true, _source: "cursor-mcp-feedback" } },
             { event: "afterMCPExecution", hook: { command: `${node} ${blockHook} afterMCPExecution`, _source: "cursor-mcp-feedback" } },
             { event: "preToolUse", hook: { command: `${node} ${pendingHook}`, _source: "cursor-mcp-feedback" } },
-            { event: "preToolUse", hook: { command: `${node} ${blockHook} preToolUse`, matcher: "MCP:interactive_feedback|MCP:submit_feedback", failClosed: true, _source: "cursor-mcp-feedback-block" } },
         ];
-        const allSources = new Set(entries.map((e) => e.hook._source));
+        const allSources = new Set([...entries.map((e) => e.hook._source), "cursor-mcp-feedback-block"]);
         const before = JSON.stringify(config);
         // First pass: remove ALL our entries from every event (clean slate)
         for (const arr of Object.values(config.hooks)) {

package/hooks/block-cursor-mcp-feedback.js

@@ -1,12 +1,11 @@
 #!/usr/bin/env node
-// Cursor hook: session lifecycle + subagent protection.
+// Cursor hook: subagent protection + feedback event logging.
 //
 // Events (argv[2]):
-//   sessionStart         — create per-session directory & meta
-//   sessionEnd           — mark session inactive
-//   subagentStart        — record subagent to negative list
-//   subagentStop         — remove subagent
-//   beforeMCPExecution   — deny cursor-mcp-feedback calls from subagents
+//   subagentStart        — increment active subagent counter
+//   subagentStop         — decrement active subagent counter
+//   beforeMCPExecution   — deny cursor-mcp-feedback calls when subagents active
+//   afterMCPExecution    — log feedback events to events.jsonl
 
 'use strict';
 
@@ -20,42 +19,11 @@ process.stdin.on('end', () => {
   let input;
   try { input = JSON.parse(raw); } catch { input = {}; }
 
-  if (event === 'sessionStart') {
-    su.cleanupStaleSessions();
-    const convId = input.session_id || input.conversation_id;
-    if (convId) {
-      const workspace = (input.workspace_roots || [])[0] || '';
-      su.createSession(convId, {
-        workspace,
-        mode: input.composer_mode || 'agent',
-        model: input.model || '',
-        is_background: input.is_background_agent || false,
-        transcript_path: input.transcript_path || null,
-      });
-    }
-    su.writeHookOutput({});
-    return;
-  }
-
-  if (event === 'sessionEnd') {
-    const convId = input.session_id || input.conversation_id;
-    if (convId) {
-      su.endSession(convId, input.reason || 'unknown');
-      su.resetActiveSubagents(convId);
-    }
-    su.writeHookOutput({});
-    return;
-  }
-
   if (event === 'subagentStart') {
     const subagentId = input.subagent_id;
     const parentConvId = input.parent_conversation_id || input.conversation_id;
-    if (subagentId) {
-      su.recordSubagent(subagentId, parentConvId);
-    }
-    if (parentConvId) {
-      su.incrementActiveSubagents(parentConvId);
-    }
+    if (subagentId) su.recordSubagent(subagentId, parentConvId);
+    if (parentConvId) su.incrementActiveSubagents(parentConvId);
     su.writeHookOutput({});
     return;
   }
@@ -64,41 +32,11 @@ process.stdin.on('end', () => {
     const subagentId = input.subagent_id || input.conversation_id;
     const parentConvId = input.parent_conversation_id || input.conversation_id;
     if (subagentId) su.removeSubagent(subagentId);
-    if (parentConvId) {
-      su.decrementActiveSubagents(parentConvId);
-    }
+    if (parentConvId) su.decrementActiveSubagents(parentConvId);
     su.writeHookOutput({});
     return;
   }
 
-  if (event === 'preToolUse') {
-    const toolName = (input.tool_name || '').toLowerCase();
-    const isFeedbackTool =
-      toolName.includes('interactive_feedback') ||
-      toolName.includes('submit_feedback');
-
-    if (!isFeedbackTool) {
-      su.writeHookOutput({});
-      return;
-    }
-
-    const convId = input.conversation_id;
-    if (convId && su.hasActiveSubagents(convId)) {
-      su.writeHookOutput({
-        permission: 'deny',
-        user_message: '[Hook] Blocked feedback tool call — subagent(s) active',
-        agent_message:
-          'DENIED by preToolUse hook. ' +
-          'cursor-mcp-feedback tools are for the MAIN agent only. ' +
-          'Active subagents detected for this conversation. ' +
-          'Return your results as text in your final response instead.',
-      });
-    } else {
-      su.writeHookOutput({});
-    }
-    return;
-  }
-
   if (event === 'beforeMCPExecution') {
     const command = (input.command || '').toLowerCase();
     const isFeedbackApp =
@@ -114,7 +52,7 @@ process.stdin.on('end', () => {
     if (convId && su.hasActiveSubagents(convId)) {
       su.writeHookOutput({
         permission: 'deny',
-        user_message: '[Hook] Blocked cursor-mcp-feedback call — subagent(s) active',
+        user_message: '[Hook] Blocked cursor-mcp-feedback — subagent(s) active',
         agent_message:
           'DENIED by beforeMCPExecution hook. ' +
           'cursor-mcp-feedback tools are for the MAIN agent only. ' +
@@ -137,6 +75,11 @@ process.stdin.on('end', () => {
 
     const isFeedback = toolName === 'interactive_feedback' || toolName === 'submit_feedback';
     if (convId && isFeedback) {
+      su.ensureSession(convId, {
+        workspace: (input.workspace_roots || [])[0] || '',
+        model: input.model || '',
+      });
+
       const eventsFile = require('path').join(su.sessionDir(convId), 'events.jsonl');
       let toolInput = {};
       try { toolInput = typeof input.tool_input === 'string' ? JSON.parse(input.tool_input) : (input.tool_input || {}); } catch {}

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "cursor-mcp-feedback",
-  "version": "2.0.4",
+  "version": "2.0.5",
   "description": "MCP App for interactive feedback — renders a chat UI directly inside MCP hosts (Claude, Cursor, etc.)",
   "type": "module",
   "main": "dist/main.js",