cursedbelt-server 3.0.0 → 3.0.1

package/dist/server/activity/index.d.ts

@@ -10,7 +10,7 @@
  *
  * ── Retention ───────────────────────────────────────────────────────────────
  * This package never deletes an event. An app whose stream is high-volume opts
- * into the fleet standard (`docs/retention.md` in `cursed-satellites`) by
+ * into the fleet standard (`cursedbelt-server/retention`, in this package) by
  * declaring the table, which puts the number under the owner's control in the
  * station rather than in a constant here:
  *

package/dist/server/activity/index.js

@@ -10,7 +10,7 @@
  *
  * ── Retention ───────────────────────────────────────────────────────────────
  * This package never deletes an event. An app whose stream is high-volume opts
- * into the fleet standard (`docs/retention.md` in `cursed-satellites`) by
+ * into the fleet standard (`cursedbelt-server/retention`, in this package) by
  * declaring the table, which puts the number under the owner's control in the
  * station rather than in a constant here:
  *

package/dist/server/master-lock/guard.js

@@ -168,6 +168,24 @@ export function createMasterLockGuard(options) {
         }
         if (path === MASTER_LOCK_PATHS.change) {
             const body = await readJson(req);
+            /*
+             * 🔴 An OLDER client sends a freshly-minted `kdf` with a rotation, because that is
+             * what the wire looked like before accounts existed. Ignoring it silently would be
+             * a lockout, not a compatibility shim: the verifier in the same body was derived
+             * under THAT salt, so storing it would leave a hash nothing can ever match — the
+             * owner would set a new password, be logged out by the rotation, and find that
+             * neither the old nor the new one opens the app.
+             *
+             * There is no safe way to honour it either, since every account on this app shares
+             * one descriptor. So it is refused, loudly, with the one thing that distinguishes
+             * it from a wrong password.
+             */
+            if (body?.kdf !== undefined) {
+                const supplied = body.kdf;
+                if (!lock.kdf || supplied?.salt !== lock.kdf.salt) {
+                    return Response.json({ error: "stale-client" }, { status: 409, headers: noStore });
+                }
+            }
             const result = await lock.change(req, {
                 currentVerifier: typeof body?.currentVerifier === "string" ? body.currentVerifier : "",
                 verifier: typeof body?.verifier === "string" ? body.verifier : "",

package/package.json

@@ -1,6 +1,6 @@
 {
 	"name": "cursedbelt-server",
-	"version": "3.0.0",
+	"version": "3.0.1",
 	"license": "ISC",
 	"type": "module",
 	"description": "The app-facing Bun/Hono server tier of the cursedbelt split \u2014 storage, sharing, activity, guard, sync. React-free; cursedbelt-core below it.",

package/src/server/activity/index.ts

@@ -10,7 +10,7 @@
  *
  * ── Retention ───────────────────────────────────────────────────────────────
  * This package never deletes an event. An app whose stream is high-volume opts
- * into the fleet standard (`docs/retention.md` in `cursed-satellites`) by
+ * into the fleet standard (`cursedbelt-server/retention`, in this package) by
  * declaring the table, which puts the number under the owner's control in the
  * station rather than in a constant here:
  *

package/src/server/master-lock/guard.spec.ts

@@ -157,6 +157,31 @@ describe("while locked", () => {
 		expect(JSON.stringify(body)).not.toContain("argon2");
 	});
 
+	test("🔴 a rotation carrying a STALE kdf is refused, not silently honoured", async () => {
+		// The pre-accounts wire minted a fresh salt on every rotation. Every account now
+		// derives under one shared descriptor, so honouring that would store a verifier hash
+		// nothing can ever match — the owner sets a new password, the rotation logs him out,
+		// and neither the old nor the new one opens the app. `409 stale-client` is the one
+		// refusal here that is deliberately distinguishable from a wrong password.
+		const { guard } = build();
+		const cookie = await open(guard);
+		const stale = await guard.handle(
+			post(
+				MASTER_LOCK_PATHS.change,
+				{
+					currentVerifier: VERIFIER,
+					kdf: { v: 1, alg: "PBKDF2-SHA256", iter: 600_000, salt: "ZZZZZZZZZZZZZZZZZZZZZZ" },
+					verifier: "whatever-that-salt-produced",
+				},
+				cookie,
+			),
+		);
+		expect(stale?.status).toBe(409);
+		expect(await stale?.json()).toEqual({ error: "stale-client" });
+		// And the password that already worked still does.
+		expect((await guard.handle(post(MASTER_LOCK_PATHS.unlock, { verifier: VERIFIER })))?.status).toBe(200);
+	});
+
 	test("🔴 status never says how many accounts this app has", async () => {
 		// The lock screen must read identically whether the owner keeps one tenant or ten:
 		// the number of master passwords is itself a fact worth hiding, and `status` is

package/src/server/master-lock/guard.ts

@@ -259,6 +259,27 @@ export function createMasterLockGuard(options: MasterLockGuardOptions): MasterLo
 		}
 		if (path === MASTER_LOCK_PATHS.change) {
 			const body = await readJson(req);
+			/*
+			 * 🔴 An OLDER client sends a freshly-minted `kdf` with a rotation, because that is
+			 * what the wire looked like before accounts existed. Ignoring it silently would be
+			 * a lockout, not a compatibility shim: the verifier in the same body was derived
+			 * under THAT salt, so storing it would leave a hash nothing can ever match — the
+			 * owner would set a new password, be logged out by the rotation, and find that
+			 * neither the old nor the new one opens the app.
+			 *
+			 * There is no safe way to honour it either, since every account on this app shares
+			 * one descriptor. So it is refused, loudly, with the one thing that distinguishes
+			 * it from a wrong password.
+			 */
+			if (body?.kdf !== undefined) {
+				const supplied = body.kdf as { salt?: unknown };
+				if (!lock.kdf || supplied?.salt !== lock.kdf.salt) {
+					return Response.json(
+						{ error: "stale-client" },
+						{ status: 409, headers: noStore },
+					);
+				}
+			}
 			const result = await lock.change(req, {
 				currentVerifier: typeof body?.currentVerifier === "string" ? body.currentVerifier : "",
 				verifier: typeof body?.verifier === "string" ? body.verifier : "",