cueloop 0.1.0-alpha.62 → 0.1.0-alpha.64

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "cueloop",
-  "version": "0.1.0-alpha.62",
+  "version": "0.1.0-alpha.64",
   "description": "Terminal review surface for coding agents: annotate plans and diffs, return a verdict, send structured feedback back",
   "homepage": "https://github.com/mmurakaru/cueloop#readme",
   "bugs": {
@@ -30,10 +30,11 @@
     "build:binary": "bun build --compile --external cpu-features ./src/main.ts --outfile dist/cueloop"
   },
   "dependencies": {
-    "@cueloop/adapters": "0.1.0-alpha.62",
-    "@cueloop/client": "0.1.0-alpha.62",
-    "@cueloop/daemon": "0.1.0-alpha.62",
-    "@cueloop/schema": "0.1.0-alpha.62"
+    "@cueloop/adapters": "0.1.0-alpha.64",
+    "@cueloop/client": "0.1.0-alpha.64",
+    "@cueloop/daemon": "0.1.0-alpha.64",
+    "@cueloop/schema": "0.1.0-alpha.64",
+    "valibot": "^1.4.2"
   },
   "engines": {
     "bun": ">=1.3.0"

package/src/args.ts

@@ -1,5 +1,7 @@
 /** Tiny flag parser: --key value, --key=value, boolean --flag, positionals. */
 
+import * as v from "valibot";
+
 export interface ParsedArgs {
   positional: string[];
   flags: Record<string, string | boolean>;
@@ -40,7 +42,7 @@ export function stringFlag(
   flags: Record<string, string | boolean>,
   key: string,
 ): string | undefined {
-  const value = flags[key];
+  const result = v.safeParse(v.string(), flags[key]);
 
-  return typeof value === "string" ? value : undefined;
+  return result.success ? result.output : undefined;
 }

package/src/main.ts

@@ -98,7 +98,11 @@ async function shareEntry(rest: string[]): Promise<number> {
 
 type CommandHandler = (rest: string[]) => number | Promise<number>;
 
-const commandHandlers: Record<string, CommandHandler> = {
+interface CommandHandlers {
+  [command: string]: CommandHandler;
+}
+
+const commandHandlers: CommandHandlers = {
   session: (rest) => sessionCommand(rest),
   daemon: (rest) => daemonCommand(rest),
   plan: (rest) => planCommand(rest),

package/src/session-commands.ts

@@ -4,10 +4,11 @@
  * JSON on stdout; exit code 0 unless the daemon returned an error.
  */
 
-import { newAnnotationId, type ArtifactType, type VerdictKind } from "@cueloop/schema";
+import { ARTIFACT_TYPES, isArtifactType, newAnnotationId } from "@cueloop/schema";
+import * as v from "valibot";
 import { DaemonClient } from "@cueloop/daemon/client";
 import { openHerdrPaneForReview } from "@cueloop/daemon/herdr-pane";
-import { openReview, verdictResponse, type ReviewNote } from "@cueloop/daemon/review";
+import { openReview, verdictResponse } from "@cueloop/daemon/review";
 import { loadConfig, quickActionBody, resolveQuickAction } from "@cueloop/client/config";
 import { parseArgs, stringFlag } from "./args";
 
@@ -15,24 +16,34 @@ async function readStdin(): Promise<string> {
   return await new Response(Bun.stdin.stream()).text();
 }
 
-function out(value: unknown): void {
+function out(value: Parameters<typeof JSON.stringify>[0]): void {
   console.log(JSON.stringify(value, null, 2));
 }
 
+const ReviewNotesSchema = v.array(v.object({ path: v.string(), body: v.string() }));
+const SessionStatusSchema = v.picklist(["pending", "resolved"]);
+const VerdictKindSchema = v.picklist(["comment", "approve", "request_changes"]);
+
 type SessionFlags = Record<string, string | boolean>;
 type SessionContext = { client: DaemonClient; positional: string[]; flags: SessionFlags };
 type SessionVerbHandler = (context: SessionContext) => Promise<number>;
 
 async function sessionCreate({ client, flags }: SessionContext): Promise<number> {
+  const type = stringFlag(flags, "type") ?? "plan";
+
+  if (!isArtifactType(type)) {
+    console.error(`unknown artifact type "${type}" - one of: ${ARTIFACT_TYPES.join(", ")}`);
+    return 2;
+  }
   const contentFile = stringFlag(flags, "content-file");
   const content = contentFile ? await Bun.file(contentFile).text() : await readStdin();
   // per-file agent notes for diff sessions: a JSON array of { path, body }
   const notesFile = stringFlag(flags, "notes-file");
   const notes = notesFile
-    ? (JSON.parse(await Bun.file(notesFile).text()) as ReviewNote[])
+    ? v.parse(ReviewNotesSchema, JSON.parse(await Bun.file(notesFile).text()))
     : undefined;
   const review = await openReview(client, {
-    type: (stringFlag(flags, "type") ?? "plan") as ArtifactType,
+    type,
     content,
     cwd: stringFlag(flags, "cwd"),
     agent: stringFlag(flags, "agent"),
@@ -57,7 +68,8 @@ async function sessionGetCommand({ client, positional }: SessionContext): Promis
 }
 
 async function sessionListCommand({ client, flags }: SessionContext): Promise<number> {
-  const status = stringFlag(flags, "status") as "pending" | "resolved" | undefined;
+  const rawStatus = stringFlag(flags, "status");
+  const status = rawStatus ? v.parse(SessionStatusSchema, rawStatus) : undefined;
 
   out(await client.sessionList(status ? { status } : undefined));
 
@@ -103,7 +115,7 @@ async function sessionAnnotateCommand({
           suffix: stringFlag(flags, "suffix") ?? "",
         },
         body,
-        ...(author ? { author } : {}),
+        author,
       },
       stringFlag(flags, "author-name"),
     ),
@@ -118,7 +130,7 @@ async function sessionResolveCommand({
   flags,
 }: SessionContext): Promise<number> {
   const id = required(positional[1], "session id");
-  const kind = required(stringFlag(flags, "verdict"), "--verdict") as VerdictKind;
+  const kind = v.parse(VerdictKindSchema, required(stringFlag(flags, "verdict"), "--verdict"));
 
   out(await client.sessionResolve(id, kind, stringFlag(flags, "summary") ?? ""));
 
@@ -144,7 +156,11 @@ async function sessionSubmitRevisionCommand({
   return 0;
 }
 
-const sessionVerbHandlers: Record<string, SessionVerbHandler> = {
+interface SessionVerbHandlers {
+  [verb: string]: SessionVerbHandler;
+}
+
+const sessionVerbHandlers: SessionVerbHandlers = {
   create: sessionCreate,
   get: sessionGetCommand,
   list: sessionListCommand,

package/src/share-command.test.ts

@@ -30,11 +30,20 @@ function annotationFixture(id: string, author?: string): Annotation {
   return author ? { ...base, author } : base;
 }
 
+const unimplemented = (member: string) => () =>
+  Promise.reject(new Error(`fakeClient does not implement ${member}`));
+
 /** A SessionClient that answers get/list from a fixed list and records the share/merge verbs. */
 function fakeClient(sessions: ReviewSession[]): SessionClient {
   return {
+    onEvent: () => () => {},
+    subscribe: async () => {},
     sessionGet: async (id: string) => sessions.find((session) => session.id === id)!,
     sessionList: async () => sessions,
+    sessionAnnotate: unimplemented("sessionAnnotate"),
+    sessionRemoveAnnotation: unimplemented("sessionRemoveAnnotation"),
+    sessionSetWorkingCopy: unimplemented("sessionSetWorkingCopy"),
+    sessionSetViewed: unimplemented("sessionSetViewed"),
     sessionSetShareId: mock(async (id: string, shareId: string) => {
       const session = sessions.find((candidate) => candidate.id === id)!;
 
@@ -51,7 +60,11 @@ function fakeClient(sessions: ReviewSession[]): SessionClient {
 
       return session;
     }),
-  } as unknown as SessionClient;
+    sessionDelete: unimplemented("sessionDelete"),
+    sessionSetSelfName: unimplemented("sessionSetSelfName"),
+    sessionResolve: unimplemented("sessionResolve"),
+    close: () => {},
+  };
 }
 
 function depsSpy(overrides: Partial<ShareDeps> = {}): ShareDeps & { lines: string[] } {