crysk 0.3.1 → 0.3.2
This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
- package/README.md +9 -5
- package/dist/SKILL-6j27707y.md +140 -0
- package/dist/SKILL-816621e5.md +74 -0
- package/dist/SKILL-bnh7nrjz.md +74 -0
- package/dist/SKILL-fv8x6hhx.md +140 -0
- package/dist/SKILL-nv32jpc5.md +74 -0
- package/dist/SKILL-qnfc8yp3.md +539 -0
- package/dist/SKILL-xr56f0b6.md +140 -0
- package/dist/SKILL-yz6wk92g.md +542 -0
- package/dist/ci-admission-09k2ba89.md +126 -0
- package/dist/ci-admission-f19qh39t.md +128 -0
- package/dist/ci-admission-tcqsj7b2.md +126 -0
- package/dist/cli.js +1831 -1150
- package/dist/index.js +1464 -911
- package/dist/materiality-f1qwnvg1.md +27 -0
- package/package.json +3 -2
- package/prompts/materiality.md +27 -0
- package/skills/crysk/SKILL.md +2 -2
- package/skills/crysk-ci-setup/SKILL.md +13 -7
- package/skills/crysk-ci-setup/references/ci-admission.md +4 -0
- package/skills/crysk-loop/SKILL.md +32 -5
- package/src/asset-manifest.ts +2 -0
- package/src/assets.ts +4 -1
- package/src/brand.ts +11 -9
- package/src/ci/cli-record.ts +1 -1
- package/src/ci/gates.ts +31 -0
- package/src/ci/outcome.ts +2 -1
- package/src/ci/override.ts +11 -10
- package/src/ci/publish.ts +44 -103
- package/src/ci/reporter.ts +34 -5
- package/src/ci/review-levels.ts +21 -0
- package/src/ci/setup.ts +1 -2
- package/src/commands/post.ts +17 -0
- package/src/compare/loop.ts +356 -0
- package/src/compare/materiality.ts +266 -0
- package/src/compare/noise.ts +166 -0
- package/src/diversity/projection.ts +3 -0
- package/src/index.ts +1 -1
- package/src/model/routing.ts +62 -0
- package/src/pr/admission.ts +13 -1
- package/src/pr/discovery.ts +17 -5
- package/src/pr/inline.ts +15 -1
- package/src/pr/plan.ts +5 -0
- package/src/pr/post-floor.ts +30 -0
- package/src/pr/posting.ts +4 -0
- package/src/pr/pr-status.ts +14 -0
- package/src/pr/pr.ts +50 -34
- package/src/pr/preflight.ts +2 -2
- package/src/pr/publish-outcome.ts +4 -0
- package/src/pr/review-pr.ts +65 -26
- package/src/pr/teardown.ts +1 -1
- package/src/rereview/prepare.ts +16 -0
- package/src/rereview/state.ts +206 -25
- package/src/review/boundary.ts +4 -1
- package/src/review/dedupe.ts +48 -4
- package/src/review/findings.ts +47 -1
- package/src/review/materiality-gate.ts +134 -0
- package/src/review/pipeline.ts +521 -41
- package/src/review/preflight.ts +69 -0
- package/src/review/report.ts +73 -10
- package/src/review/review.ts +16 -0
- package/src/review/route-preflight.ts +29 -1
- package/src/review/run.ts +2 -0
- package/src/ui/config.ts +8 -0
- package/src/updater.ts +1 -1
package/src/review/preflight.ts
CHANGED
|
@@ -19,6 +19,7 @@ import type {
|
|
|
19
19
|
RoutingConfig,
|
|
20
20
|
RunnerBackend,
|
|
21
21
|
} from "#model/routing";
|
|
22
|
+
import { POST_MIN_SEVERITIES, type PostMinSeverity } from "#pr/post-floor";
|
|
22
23
|
import type { SuspicionPrior } from "#review/prompt-set";
|
|
23
24
|
import { type AgentSpec, isSafeSlug, type ReviewSpec } from "#review/spec";
|
|
24
25
|
import {
|
|
@@ -2178,7 +2179,15 @@ export const CONFIG_DIRECTION: Record<keyof LocalConfig, ConfigDirection> = {
|
|
|
2178
2179
|
max_changed_lines: "capped",
|
|
2179
2180
|
max_changed_files: "capped",
|
|
2180
2181
|
scout: "capped",
|
|
2182
|
+
// `capped` like the scout, for the same reason: switching it on adds one
|
|
2183
|
+
// judge spawn per blocking finding, so a committed file may turn it off but
|
|
2184
|
+
// never on against the operator's global ceiling.
|
|
2185
|
+
materiality_gate: "capped",
|
|
2181
2186
|
post: "capped",
|
|
2187
|
+
// `person`: a global floor applies to every repo, and a repo file overrides
|
|
2188
|
+
// it either way. It changes only what a PR shows, never what a review costs,
|
|
2189
|
+
// so the spend asymmetry behind `capped` does not apply.
|
|
2190
|
+
post_min_severity: "person",
|
|
2182
2191
|
ci_review_policy: "repo",
|
|
2183
2192
|
ci_max_attempts: "repo",
|
|
2184
2193
|
ci_max_reviews: "repo",
|
|
@@ -2219,7 +2228,12 @@ export interface LocalConfig {
|
|
|
2219
2228
|
max_changed_lines?: number;
|
|
2220
2229
|
max_changed_files?: number;
|
|
2221
2230
|
scout?: boolean;
|
|
2231
|
+
// Opt-in judge that demotes immaterial blocking findings to advisory
|
|
2232
|
+
// (review/materiality-gate.ts). Absent means off.
|
|
2233
|
+
materiality_gate?: boolean;
|
|
2222
2234
|
post?: boolean;
|
|
2235
|
+
// The lowest finding a PR review posts (pr/post-floor.ts). Absent posts all.
|
|
2236
|
+
post_min_severity?: PostMinSeverity;
|
|
2223
2237
|
// CI admission: when to spend on a synchronize push (see ci/review-admission.ts).
|
|
2224
2238
|
ci_review_policy?: CiReviewPolicyMode;
|
|
2225
2239
|
ci_max_attempts?: number;
|
|
@@ -2458,7 +2472,13 @@ function parseConfigLayer(
|
|
|
2458
2472
|
file,
|
|
2459
2473
|
);
|
|
2460
2474
|
const scout = parseOptionalBoolean(config.scout, "scout", file);
|
|
2475
|
+
const materialityGate = parseOptionalBoolean(
|
|
2476
|
+
config.materiality_gate,
|
|
2477
|
+
"materiality_gate",
|
|
2478
|
+
file,
|
|
2479
|
+
);
|
|
2461
2480
|
const post = parseOptionalBoolean(config.post, "post", file);
|
|
2481
|
+
const postMinSeverity = parsePostMinSeverity(config.post_min_severity, file);
|
|
2462
2482
|
const ciReviewPolicy = parseCiReviewPolicyMode(config.ci_review_policy, file);
|
|
2463
2483
|
const ciMaxAttempts = parseCiAdmissionInteger(
|
|
2464
2484
|
config.ci_max_attempts,
|
|
@@ -2528,7 +2548,13 @@ function parseConfigLayer(
|
|
|
2528
2548
|
? {}
|
|
2529
2549
|
: { max_changed_files: maxChangedFiles }),
|
|
2530
2550
|
...(scout === undefined ? {} : { scout }),
|
|
2551
|
+
...(materialityGate === undefined
|
|
2552
|
+
? {}
|
|
2553
|
+
: { materiality_gate: materialityGate }),
|
|
2531
2554
|
...(post === undefined ? {} : { post }),
|
|
2555
|
+
...(postMinSeverity === undefined
|
|
2556
|
+
? {}
|
|
2557
|
+
: { post_min_severity: postMinSeverity }),
|
|
2532
2558
|
...(ciReviewPolicy === undefined
|
|
2533
2559
|
? {}
|
|
2534
2560
|
: { ci_review_policy: ciReviewPolicy }),
|
|
@@ -2863,6 +2889,22 @@ function parseCiAdmissionInteger(
|
|
|
2863
2889
|
return parsed;
|
|
2864
2890
|
}
|
|
2865
2891
|
|
|
2892
|
+
function parsePostMinSeverity(
|
|
2893
|
+
value: unknown,
|
|
2894
|
+
file: string,
|
|
2895
|
+
): PostMinSeverity | undefined {
|
|
2896
|
+
if (value === undefined) return undefined;
|
|
2897
|
+
if (
|
|
2898
|
+
typeof value !== "string" ||
|
|
2899
|
+
!(POST_MIN_SEVERITIES as readonly string[]).includes(value)
|
|
2900
|
+
) {
|
|
2901
|
+
throw new CliUsageError(
|
|
2902
|
+
`${file} post_min_severity must be one of: ${POST_MIN_SEVERITIES.join(", ")}`,
|
|
2903
|
+
);
|
|
2904
|
+
}
|
|
2905
|
+
return value as PostMinSeverity;
|
|
2906
|
+
}
|
|
2907
|
+
|
|
2866
2908
|
function parseCiReviewPolicyMode(
|
|
2867
2909
|
value: unknown,
|
|
2868
2910
|
file: string,
|
|
@@ -2927,6 +2969,14 @@ export function resolveScout(
|
|
|
2927
2969
|
return options.scout ?? config.scout ?? false;
|
|
2928
2970
|
}
|
|
2929
2971
|
|
|
2972
|
+
// No CLI flag on purpose: the gate is opt-in through config only, so the
|
|
2973
|
+
// merged config is the whole answer and absent means off.
|
|
2974
|
+
export function resolveMaterialityGate(
|
|
2975
|
+
config: Pick<ConfigLayer, "materiality_gate">,
|
|
2976
|
+
): boolean {
|
|
2977
|
+
return config.materiality_gate ?? false;
|
|
2978
|
+
}
|
|
2979
|
+
|
|
2930
2980
|
export function resolvePost(
|
|
2931
2981
|
options: Pick<CliOptions, "post">,
|
|
2932
2982
|
config: Pick<ConfigLayer, "post">,
|
|
@@ -3089,12 +3139,23 @@ export function mergeConfig(
|
|
|
3089
3139
|
(layer) => layer.scout,
|
|
3090
3140
|
(a, b) => a && b,
|
|
3091
3141
|
);
|
|
3142
|
+
const materialityGate = foldKey(
|
|
3143
|
+
layers,
|
|
3144
|
+
CONFIG_DIRECTION.materiality_gate,
|
|
3145
|
+
(layer) => layer.materiality_gate,
|
|
3146
|
+
(a, b) => a && b,
|
|
3147
|
+
);
|
|
3092
3148
|
const post = foldKey(
|
|
3093
3149
|
layers,
|
|
3094
3150
|
CONFIG_DIRECTION.post,
|
|
3095
3151
|
(layer) => layer.post,
|
|
3096
3152
|
(a, b) => a && b,
|
|
3097
3153
|
);
|
|
3154
|
+
const postMinSeverity = foldKey(
|
|
3155
|
+
layers,
|
|
3156
|
+
CONFIG_DIRECTION.post_min_severity,
|
|
3157
|
+
(layer) => layer.post_min_severity,
|
|
3158
|
+
);
|
|
3098
3159
|
const routing = foldKey(
|
|
3099
3160
|
layers,
|
|
3100
3161
|
CONFIG_DIRECTION.routing,
|
|
@@ -3178,7 +3239,13 @@ export function mergeConfig(
|
|
|
3178
3239
|
? {}
|
|
3179
3240
|
: { max_changed_files: maxFiles.value }),
|
|
3180
3241
|
...(scout.value === undefined ? {} : { scout: scout.value }),
|
|
3242
|
+
...(materialityGate.value === undefined
|
|
3243
|
+
? {}
|
|
3244
|
+
: { materiality_gate: materialityGate.value }),
|
|
3181
3245
|
...(post.value === undefined ? {} : { post: post.value }),
|
|
3246
|
+
...(postMinSeverity.value === undefined
|
|
3247
|
+
? {}
|
|
3248
|
+
: { post_min_severity: postMinSeverity.value }),
|
|
3182
3249
|
...(ciReviewPolicy.value === undefined
|
|
3183
3250
|
? {}
|
|
3184
3251
|
: { ci_review_policy: ciReviewPolicy.value }),
|
|
@@ -3218,7 +3285,9 @@ export function mergeConfig(
|
|
|
3218
3285
|
max_changed_lines: maxLines.source,
|
|
3219
3286
|
max_changed_files: maxFiles.source,
|
|
3220
3287
|
scout: scout.source,
|
|
3288
|
+
materiality_gate: materialityGate.source,
|
|
3221
3289
|
post: post.source,
|
|
3290
|
+
post_min_severity: postMinSeverity.source,
|
|
3222
3291
|
ci_review_policy: ciReviewPolicy.source,
|
|
3223
3292
|
ci_max_attempts: ciMaxAttempts.source,
|
|
3224
3293
|
ci_max_reviews: ciMaxReviews.source,
|
package/src/review/report.ts
CHANGED
|
@@ -9,6 +9,7 @@
|
|
|
9
9
|
|
|
10
10
|
import { listPaths } from "#git/refs";
|
|
11
11
|
import type { ResolvedModelRoute, ResolvedStepRoute } from "#model/routing";
|
|
12
|
+
import type { PostMinSeverity } from "#pr/post-floor";
|
|
12
13
|
import {
|
|
13
14
|
type CiMode,
|
|
14
15
|
findingMarker,
|
|
@@ -20,13 +21,14 @@ import {
|
|
|
20
21
|
type RecoveredSeverity,
|
|
21
22
|
SEVERITY_UNRECOVERABLE,
|
|
22
23
|
} from "#rereview/classify";
|
|
23
|
-
import
|
|
24
|
-
Finding,
|
|
25
|
-
FindingsDocument,
|
|
26
|
-
|
|
27
|
-
|
|
28
|
-
|
|
29
|
-
|
|
24
|
+
import {
|
|
25
|
+
type Finding,
|
|
26
|
+
type FindingsDocument,
|
|
27
|
+
isCausallyExempt,
|
|
28
|
+
type RefuterVerdict,
|
|
29
|
+
type RunStatus,
|
|
30
|
+
type Severity,
|
|
31
|
+
type Tier,
|
|
30
32
|
} from "#review/findings";
|
|
31
33
|
import {
|
|
32
34
|
clusterByRootCause,
|
|
@@ -726,6 +728,9 @@ export function renderPrComment(
|
|
|
726
728
|
// compacts from the last entry backwards, one entry at a time, until the
|
|
727
729
|
// body fits. Omitted or past the end, the section is byte-identical.
|
|
728
730
|
compactFrom?: number,
|
|
731
|
+
// Findings below `post_min_severity` (pr/post-floor.ts): left out of `doc`
|
|
732
|
+
// by the caller, counted here in one line so the summary says they exist.
|
|
733
|
+
notPosted?: { count: number; floor: PostMinSeverity },
|
|
729
734
|
): string {
|
|
730
735
|
// Normalize away one trailing slash so `gh repo view` output and a
|
|
731
736
|
// hand-typed URL build the same links.
|
|
@@ -875,12 +880,23 @@ export function renderPrComment(
|
|
|
875
880
|
// Item 7 C7: zero new findings is also not a clean bill when priors
|
|
876
881
|
// remain live (carried / unconfirmed / deferred / suppressed) or this
|
|
877
882
|
// run returned / re-tiered a prior. MatchResult.resolved cannot say so.
|
|
878
|
-
|
|
883
|
+
const cleanBill = cleanBillLine(doc.run_status, delta?.rereview);
|
|
884
|
+
// The ✅ claims nothing was found. With findings held back by the floor
|
|
885
|
+
// that claim is false, so it narrows to what the floor let through.
|
|
886
|
+
out.push(
|
|
887
|
+
notPosted !== undefined && cleanBill === CLEAN_BILL
|
|
888
|
+
? `No findings at or above ${code(notPosted.floor)} severity.`
|
|
889
|
+
: cleanBill,
|
|
890
|
+
);
|
|
879
891
|
out.push("");
|
|
880
892
|
} else {
|
|
881
893
|
out.push(...findingIndexLines(doc.findings, commentUrlByFindingId));
|
|
882
894
|
out.push("");
|
|
883
895
|
}
|
|
896
|
+
if (notPosted !== undefined) {
|
|
897
|
+
out.push(notPostedLine(notPosted));
|
|
898
|
+
out.push("");
|
|
899
|
+
}
|
|
884
900
|
out.push(...liveFindingLines(delta?.rereview));
|
|
885
901
|
if (outsideDiffFindings.length > 0) {
|
|
886
902
|
out.push(
|
|
@@ -1058,7 +1074,21 @@ function cleanBillLine(
|
|
|
1058
1074
|
if (!rereviewIsClean(rereview) && rereview !== undefined) {
|
|
1059
1075
|
return `No new findings this delta. Live: ${liveBits(rereview).join(" · ")}.`;
|
|
1060
1076
|
}
|
|
1061
|
-
return
|
|
1077
|
+
return CLEAN_BILL;
|
|
1078
|
+
}
|
|
1079
|
+
|
|
1080
|
+
const CLEAN_BILL = "✅ Crysk reviewed this PR and found nothing to report.";
|
|
1081
|
+
|
|
1082
|
+
function notPostedLine(notPosted: {
|
|
1083
|
+
count: number;
|
|
1084
|
+
floor: PostMinSeverity;
|
|
1085
|
+
}): string {
|
|
1086
|
+
const noun = notPosted.count === 1 ? "finding" : "findings";
|
|
1087
|
+
const what = notPosted.floor === "blocking" ? "advisory" : "lower-severity";
|
|
1088
|
+
return (
|
|
1089
|
+
`${notPosted.count} ${what} ${noun} not posted ` +
|
|
1090
|
+
`(${code(`post_min_severity: ${notPosted.floor}`)}).`
|
|
1091
|
+
);
|
|
1062
1092
|
}
|
|
1063
1093
|
|
|
1064
1094
|
function deltaLine(delta: PrCommentDelta): string {
|
|
@@ -1255,6 +1285,22 @@ function tierExplanationLines(finding: Finding): string[] {
|
|
|
1255
1285
|
const isBlockerClass =
|
|
1256
1286
|
finding.severity === "BLOCKER" || finding.severity === "CRITICAL";
|
|
1257
1287
|
if (!isBlockerClass || finding.tier !== "advisory") return [];
|
|
1288
|
+
// FIRST, ahead of the refuter text: a finding the materiality gate demoted
|
|
1289
|
+
// may carry a `corroborated` verdict, and "the refuter returned
|
|
1290
|
+
// corroborated" would explain nothing about why it is advisory.
|
|
1291
|
+
if (finding.materiality?.label === "immaterial") {
|
|
1292
|
+
return [
|
|
1293
|
+
"⚖️ Demoted to advisory — not material under normal use: " +
|
|
1294
|
+
materialityReason(finding.materiality.reason),
|
|
1295
|
+
];
|
|
1296
|
+
}
|
|
1297
|
+
// #457: a finding the PR did not cause is advisory whatever the refuter
|
|
1298
|
+
// said, so the refuter text would explain nothing about its tier.
|
|
1299
|
+
if (isCausallyExempt(finding)) {
|
|
1300
|
+
return [
|
|
1301
|
+
"⚖️ Advisory — this PR did not introduce it, so it does not block the gate",
|
|
1302
|
+
];
|
|
1303
|
+
}
|
|
1258
1304
|
// `not_submitted` never reached the refuter, so "the refuter returned" it
|
|
1259
1305
|
// would be false, and printing the engine's word here would contradict the
|
|
1260
1306
|
// header, which says `refuter: unchecked` (refuterLabel).
|
|
@@ -1278,6 +1324,23 @@ function tierExplanationLines(finding: Finding): string[] {
|
|
|
1278
1324
|
return lines;
|
|
1279
1325
|
}
|
|
1280
1326
|
|
|
1327
|
+
// The judge's reason is model text written about author-controlled input,
|
|
1328
|
+
// and it is posted. One line (a newline would end the list item and could
|
|
1329
|
+
// start a forged header line), capped, with HTML comment delimiters broken so
|
|
1330
|
+
// it can never open or close a marker the comment parsers read, and `@`
|
|
1331
|
+
// defused so it cannot notify anyone.
|
|
1332
|
+
const MATERIALITY_REASON_MAX = 280;
|
|
1333
|
+
|
|
1334
|
+
function materialityReason(reason: string): string {
|
|
1335
|
+
const flat = oneLine(reason)
|
|
1336
|
+
.replaceAll("<!--", "<!‐‐")
|
|
1337
|
+
.replaceAll("-->", "‐‐>")
|
|
1338
|
+
.replaceAll("@", "@\u200b");
|
|
1339
|
+
return flat.length <= MATERIALITY_REASON_MAX
|
|
1340
|
+
? flat
|
|
1341
|
+
: `${flat.slice(0, MATERIALITY_REASON_MAX - 1).trimEnd()}…`;
|
|
1342
|
+
}
|
|
1343
|
+
|
|
1281
1344
|
// Item "Prompt to fix with AI" (Juanma's PR #2 feedback): a copy-pasteable
|
|
1282
1345
|
// prompt, not a deep link — Greptile's equivalent hands off to a hosted IDE
|
|
1283
1346
|
// integration this project does not have, and inventing a link to a service
|
|
@@ -1741,7 +1804,7 @@ function commentDisclaimer(ciMode: CiMode): string {
|
|
|
1741
1804
|
// Hunter-authored text lands inside code spans and list items. A stray
|
|
1742
1805
|
// backtick in a path or proof_ref would break out of its span and mangle
|
|
1743
1806
|
// every line after it, so spans are built here and never by hand.
|
|
1744
|
-
function code(text: string): string {
|
|
1807
|
+
export function code(text: string): string {
|
|
1745
1808
|
return `\`${oneLine(text).replaceAll("`", "'")}\``;
|
|
1746
1809
|
}
|
|
1747
1810
|
|
package/src/review/review.ts
CHANGED
|
@@ -32,12 +32,14 @@ import {
|
|
|
32
32
|
type CliOptions,
|
|
33
33
|
createRunDir,
|
|
34
34
|
emptyDiffMessage,
|
|
35
|
+
resolveMaterialityGate,
|
|
35
36
|
resolveMaxConcurrentSteps,
|
|
36
37
|
resolveSharedPrefix,
|
|
37
38
|
} from "#review/preflight";
|
|
38
39
|
import { estimateCost } from "#review/report";
|
|
39
40
|
import {
|
|
40
41
|
pipelineConsolidateInput,
|
|
42
|
+
pipelineMaterialityInput,
|
|
41
43
|
pipelineScoutInput,
|
|
42
44
|
pipelineSummarizerInput,
|
|
43
45
|
} from "#review/route-preflight";
|
|
@@ -238,6 +240,7 @@ export async function review(options: CliOptions): Promise<number> {
|
|
|
238
240
|
agentFiles,
|
|
239
241
|
routingConfig: config.routing,
|
|
240
242
|
summary,
|
|
243
|
+
materialityEnabled: resolveMaterialityGate(config),
|
|
241
244
|
});
|
|
242
245
|
const routePlan = productionRoute?.routePlan;
|
|
243
246
|
const productionAdmission = productionRoute?.productionAdmission;
|
|
@@ -355,6 +358,17 @@ export async function review(options: CliOptions): Promise<number> {
|
|
|
355
358
|
// same signal and refuses to start another attempt. Two controllers would
|
|
356
359
|
// leave the ceiling unable to stop the steps it is waiting on.
|
|
357
360
|
const ceilingController = new AbortController();
|
|
361
|
+
// Local mode has no PR, so the materiality judge reads the reviewed head's
|
|
362
|
+
// commit subject as the title (S9). Only asked for when the gate is on, so
|
|
363
|
+
// a run with it off spawns exactly the processes it always did. A failed
|
|
364
|
+
// read leaves it absent and the pipeline renders its fallback.
|
|
365
|
+
let prTitle: string | undefined;
|
|
366
|
+
if (resolveMaterialityGate(config)) {
|
|
367
|
+
const subject = await git(repoRoot, ["log", "-1", "--format=%s", headSha]);
|
|
368
|
+
if (subject.ok && subject.stdout.trim() !== "") {
|
|
369
|
+
prTitle = subject.stdout.trim();
|
|
370
|
+
}
|
|
371
|
+
}
|
|
358
372
|
let productionRuntime: ProductionRuntime | undefined;
|
|
359
373
|
try {
|
|
360
374
|
const prepared = await prepareRunnerForRoute({
|
|
@@ -395,6 +409,8 @@ export async function review(options: CliOptions): Promise<number> {
|
|
|
395
409
|
...pipelineSummarizerInput(summary),
|
|
396
410
|
...pipelineScoutInput(options),
|
|
397
411
|
...pipelineConsolidateInput(),
|
|
412
|
+
...pipelineMaterialityInput(config),
|
|
413
|
+
...(prTitle === undefined ? {} : { prTitle }),
|
|
398
414
|
...(resolveSharedPrefix(options) ? { sharedPrefix: true } : {}),
|
|
399
415
|
...pipelineConfigInput(loaded),
|
|
400
416
|
...(routePlan === undefined ? {} : { routePlan }),
|
|
@@ -32,7 +32,12 @@ import {
|
|
|
32
32
|
} from "../transport-registry";
|
|
33
33
|
import type { OpenCodeSdkLike } from "../transports/opencode-client";
|
|
34
34
|
import { DEFAULT_CONSOLIDATE_MODEL, DEFAULT_SCOUT_MODEL } from "./pipeline";
|
|
35
|
-
import
|
|
35
|
+
import {
|
|
36
|
+
type CliOptions,
|
|
37
|
+
type ConfigLayer,
|
|
38
|
+
resolveMaterialityGate,
|
|
39
|
+
type SummarySettings,
|
|
40
|
+
} from "./preflight";
|
|
36
41
|
import { type ParsedAgent, parseAgentFile } from "./prompt-set";
|
|
37
42
|
import type { ReviewSpec } from "./spec";
|
|
38
43
|
|
|
@@ -85,6 +90,23 @@ export function pipelineConsolidateInput(): {
|
|
|
85
90
|
};
|
|
86
91
|
}
|
|
87
92
|
|
|
93
|
+
// The materiality gate (odd/tasks/materiality-gate.md) is ENGINE-owned like
|
|
94
|
+
// the consolidation pass but OFF by default: it is config-only
|
|
95
|
+
// (`materiality_gate`), and absent means today's pipeline, byte for byte. The
|
|
96
|
+
// judge's model is pinned inside the pipeline, so nothing but the prompt path
|
|
97
|
+
// travels here.
|
|
98
|
+
export function pipelineMaterialityInput(
|
|
99
|
+
config: Pick<ConfigLayer, "materiality_gate">,
|
|
100
|
+
): { materiality: { promptPath: string } } | Record<string, never> {
|
|
101
|
+
return resolveMaterialityGate(config)
|
|
102
|
+
? {
|
|
103
|
+
materiality: {
|
|
104
|
+
promptPath: resolveEngineAssets().materialityPromptPath,
|
|
105
|
+
},
|
|
106
|
+
}
|
|
107
|
+
: {};
|
|
108
|
+
}
|
|
109
|
+
|
|
88
110
|
export async function buildCliRoutePlan(params: {
|
|
89
111
|
spec: ReviewSpec;
|
|
90
112
|
options: CliOptions;
|
|
@@ -97,6 +119,9 @@ export async function buildCliRoutePlan(params: {
|
|
|
97
119
|
// that skips discovery passes false, the scout's condition, so the plan
|
|
98
120
|
// never carries a route for a step that will not run.
|
|
99
121
|
consolidateEnabled?: boolean;
|
|
122
|
+
// Defaults OFF, unlike consolidation: the gate is opt-in, and a judge key in
|
|
123
|
+
// the plan changes its fingerprint, so absent must mean today's plan.
|
|
124
|
+
materialityEnabled?: boolean;
|
|
100
125
|
}): Promise<ResolvedRoutePlan> {
|
|
101
126
|
const summarizerEnabled = params.summarizerEnabled ?? params.summary.enabled;
|
|
102
127
|
const scoutEnabled = params.scoutEnabled ?? params.options.scout;
|
|
@@ -165,6 +190,9 @@ export async function buildCliRoutePlan(params: {
|
|
|
165
190
|
},
|
|
166
191
|
}
|
|
167
192
|
: {}),
|
|
193
|
+
...(params.materialityEnabled === true
|
|
194
|
+
? { materiality: true as const }
|
|
195
|
+
: {}),
|
|
168
196
|
});
|
|
169
197
|
}
|
|
170
198
|
|
package/src/review/run.ts
CHANGED
|
@@ -461,6 +461,7 @@ export async function resolvePipelineRoute(params: {
|
|
|
461
461
|
summarizerEnabled?: boolean;
|
|
462
462
|
scoutEnabled?: boolean;
|
|
463
463
|
consolidateEnabled?: boolean;
|
|
464
|
+
materialityEnabled?: boolean;
|
|
464
465
|
}): Promise<ProductionRoutePlanResult | undefined> {
|
|
465
466
|
return resolveProductionRoutePlanAtConfirm({
|
|
466
467
|
routingConfigured: params.routingConfigured,
|
|
@@ -475,6 +476,7 @@ export async function resolvePipelineRoute(params: {
|
|
|
475
476
|
summarizerEnabled: params.summarizerEnabled,
|
|
476
477
|
scoutEnabled: params.scoutEnabled,
|
|
477
478
|
consolidateEnabled: params.consolidateEnabled,
|
|
479
|
+
materialityEnabled: params.materialityEnabled,
|
|
478
480
|
}),
|
|
479
481
|
});
|
|
480
482
|
}
|
package/src/ui/config.ts
CHANGED
|
@@ -179,7 +179,15 @@ export function configRows(
|
|
|
179
179
|
sources.max_changed_files,
|
|
180
180
|
),
|
|
181
181
|
scout: cell(effective.scout?.toString(), sources.scout),
|
|
182
|
+
materiality_gate: cell(
|
|
183
|
+
effective.materiality_gate?.toString(),
|
|
184
|
+
sources.materiality_gate,
|
|
185
|
+
),
|
|
182
186
|
post: cell(effective.post?.toString(), sources.post),
|
|
187
|
+
post_min_severity: cell(
|
|
188
|
+
effective.post_min_severity,
|
|
189
|
+
sources.post_min_severity,
|
|
190
|
+
),
|
|
183
191
|
ci_review_policy: cell(
|
|
184
192
|
effective.ci_review_policy,
|
|
185
193
|
sources.ci_review_policy,
|
package/src/updater.ts
CHANGED
|
@@ -54,7 +54,7 @@ export function detectInstallMethod(
|
|
|
54
54
|
): InstallMethod {
|
|
55
55
|
const home = options.home ?? os.homedir();
|
|
56
56
|
const execPath = options.execPath ?? process.execPath;
|
|
57
|
-
const version = options.version ?? "0.3.
|
|
57
|
+
const version = options.version ?? "0.3.2";
|
|
58
58
|
const exists = options.exists ?? existsSync;
|
|
59
59
|
|
|
60
60
|
const isSource =
|