cry-synced-db-client 2.0.0 → 2.0.3

package/CHANGELOG.md

@@ -1,5 +1,42 @@
 # Versions
 
+## 2.0.2 (2026-07-13)
+
+### Fix: `PendingChangesManager.schedule` — deleted fields resurrected from prior pending save
+
+When two rapid `save()` calls arrived before the first Dexie debounce
+flushed, `PendingChangesManager.schedule` merged them via
+`Object.assign(existing.data, data)`. The second call's `data` was the
+result of `applyObjDiff` — which **physically removes** keys set to
+`undefined` (delete-by-path). `Object.assign` doesn't delete keys
+absent from the source, so the first save's value silently survived in
+the pending payload, resurrecting fields the caller had explicitly
+cleared.
+
+**Real-world trigger (klikvet):** `mounted()` calls
+`save({ sedajObdeluje: "primoz" })` → `beforeRouteLeave` calls
+`save({ sedajObdeluje: undefined })`. Both land in `PendingChanges`
+before Dexie debounce fires. The merged row kept `sedajObdeluje: "primoz"`
+in Dexie indefinitely — `razveljaviSamoVpogledSpremembe` never saw the
+field cleared in the `objDiff` between `racunObVstopu` and
+`this.racun`.
+
+**Fix in `PendingChangesManager.schedule`:** replace shallow
+`Object.assign(existing.data, data)` with key-aware merge — copy all
+keys from `existing.data`, overwrite with keys in `data`, and
+**delete** any key that exists in the existing row but is absent from
+`data` (excluding `_id`, `_rev`, `_ts`).
+
+**Fix in `SyncedDb.save()`:** diff against **in-mem** state (when
+available) instead of stale Dexie. If PendingChanges holds writes that
+haven't reached Dexie, deletions made against the live in-mem value
+are invisible when diffing against stale Dexie (existing field is
+missing from Dexie → no diff), and the field silently resurrects
+from the in-mem base during `applyObjDiff`.
+
+**New test:** `test/node-only/pendingChangesDeleteField.test.ts` —
+2 cases covering the two-rapid-save-delete scenario.
+
 ## 2.0.0 (2026-07-10)
 
 ### Dual-channel ebus support: `db/` + `dbbracketed/`

package/dist/index.js

@@ -2723,7 +2723,17 @@ var PendingChangesManager = class {
     }
     const deltaWithId = existing ? data : __spreadProps(__spreadValues({}, data), { _id: id });
     savePendingWrite(this.tenant, collection, id, deltaWithId);
-    const fullData = existing ? Object.assign(existing.data, data, { _id: id }) : __spreadProps(__spreadValues({}, data), { _id: id });
+    let fullData;
+    if (existing) {
+      fullData = __spreadProps(__spreadValues(__spreadValues({}, existing.data), data), { _id: id });
+      for (const key2 of Object.keys(existing.data)) {
+        if (key2 !== "_id" && !(key2 in data)) {
+          delete fullData[key2];
+        }
+      }
+    } else {
+      fullData = __spreadProps(__spreadValues({}, data), { _id: id });
+    }
     const timer = setTimeout(() => {
       this.executePendingChange(key);
     }, this.debounceDexieWritesMs);
@@ -4512,7 +4522,7 @@ var ServerUpdateHandler = class {
     return updatedIds;
   }
   async processBracketedItem(collection, item) {
-    var _a, _b, _c, _d, _e, _f;
+    var _a, _b, _c, _d, _e, _f, _g, _h;
     const localItem = await this.dexieDb.getById(collection, item._id);
     if (!localItem) {
       if (item.operation === "insert" && item.bracketedData) {
@@ -4529,8 +4539,7 @@ var ServerUpdateHandler = class {
     const revAction = this.checkRev(
       item._rev,
       item._ts,
-      void 0,
-      // bracketedData doesn't carry _lastUpdaterId
+      (_b = item._lastUpdaterId) != null ? _b : (_a = item.bracketedData) == null ? void 0 : _a._lastUpdaterId,
       localItem
     );
     switch (revAction) {
@@ -4559,8 +4568,8 @@ var ServerUpdateHandler = class {
         this.callOnEbusUpdateSkipped({
           collection,
           _id: item._id,
-          incomingRev: (_a = item._rev) != null ? _a : 0,
-          localRev: (_b = localItem._rev) != null ? _b : 0,
+          incomingRev: (_c = item._rev) != null ? _c : 0,
+          localRev: (_d = localItem._rev) != null ? _d : 0,
           reason: "fetch-failed"
         });
         return false;
@@ -4573,8 +4582,8 @@ var ServerUpdateHandler = class {
       const diff = this.stripMetaFromDiff(item.bracketedData);
       const currentInMemState = Object.assign({}, localItem, pendingChange.data);
       const merged = applyObjDiff(currentInMemState, diff, item._id, "bracketed");
-      merged._rev = (_c = item._rev) != null ? _c : localItem._rev;
-      merged._ts = (_d = item._ts) != null ? _d : localItem._ts;
+      merged._rev = (_e = item._rev) != null ? _e : localItem._rev;
+      merged._ts = (_f = item._ts) != null ? _f : localItem._ts;
       if (!merged._deleted && !merged._archived) {
         this.deps.writeToInMemBatch(collection, [this.stripLocalFields(merged)], "upsert", {
           source: "incremental"
@@ -4586,8 +4595,8 @@ var ServerUpdateHandler = class {
     if (dirtyChange && item.operation === "update") {
       const diff = this.stripMetaFromDiff(item.bracketedData);
       const merged = applyObjDiff(localItem, diff, item._id, "bracketed");
-      merged._rev = (_e = item._rev) != null ? _e : localItem._rev;
-      merged._ts = (_f = item._ts) != null ? _f : localItem._ts;
+      merged._rev = (_g = item._rev) != null ? _g : localItem._rev;
+      merged._ts = (_h = item._ts) != null ? _h : localItem._ts;
       if (!merged._deleted && !merged._archived) {
         await this.dexieDb.insert(collection, merged);
         this.deps.writeToInMemBatch(collection, [this.stripLocalFields(merged)], "upsert", {
@@ -6516,26 +6525,22 @@ var _SyncedDb = class _SyncedDb {
       delete update._id;
     }
     update = _SyncedDb.stringifyObjectIds(update);
+    const isWriteOnly = (_b = (_a = this.collections.get(collection)) == null ? void 0 : _a.writeOnly) != null ? _b : false;
     const existing = await this.dexieDb.getById(collection, id);
-    if (!existing && !((_a = this.collections.get(collection)) == null ? void 0 : _a.writeOnly)) {
+    if (!existing && !isWriteOnly) {
       console.warn(
         `[SyncedDb] SyncedDb.save: Object ${String(id)} not found in ${collection}, creating new`
       );
     }
     const fullChanges = __spreadProps(__spreadValues({}, update), { _lastUpdaterId: this.updaterId });
-    const diff = computeObjDiff(existing, fullChanges);
+    const currentMem = isWriteOnly ? null : this.inMemDb.getById(collection, id);
+    const base = currentMem != null ? currentMem : existing;
+    const diff = computeObjDiff(base, fullChanges);
     await this.dexieDb.addDirtyChange(collection, id, diff, {
       _ts: existing == null ? void 0 : existing._ts,
       _rev: existing == null ? void 0 : existing._rev
     });
-    const isWriteOnly = (_b = this.collections.get(collection)) == null ? void 0 : _b.writeOnly;
-    const currentMem = isWriteOnly ? null : this.inMemDb.getById(collection, id);
-    const merged = applyObjDiff(
-      currentMem != null ? currentMem : existing,
-      diff,
-      id,
-      collection
-    );
+    const merged = applyObjDiff(base, diff, id, collection);
     this.pendingChanges.schedule(
       collection,
       id,

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "cry-synced-db-client",
-  "version": "2.0.0",
+  "version": "2.0.3",
   "type": "module",
   "main": "./dist/index.js",
   "module": "./dist/index.js",