crossbind 2.0.0-beta.50 → 2.0.0-beta.51

package/CHANGELOG.md

@@ -1,5 +1,16 @@
 # crossbind
 
+## 2.0.0-beta.51
+
+### Patch Changes
+
+- **Android builds work on Apple Silicon again.** Google ships the linux NDK host tools for x86_64
+  only, so the android toolchain image is amd64-only and its multi-arch index carries no arm64 leaf.
+  Three call sites asked docker for that image by the leaf ref; the pull that runs before bridge
+  generation asked for the index instead, and on an arm64 host docker answered "no matching manifest
+  for linux/arm64/v8". Machines that already had the image cached never noticed, which is why this
+  reached beta.50 - a fresh install on an Apple Silicon Mac could not build for android at all.
+
 ## 2.0.0-beta.50
 
 ### Major Changes

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "crossbind",
-  "version": "2.0.0-beta.50",
+  "version": "2.0.0-beta.51",
   "license": "MIT",
   "homepage": "https://crossbind.dev",
   "repository": {

package/src/actions/run.js

@@ -91,7 +91,9 @@ export default function run(program, params = [], platformPrefix = null, target
     // wasi is host-run only with a locally configured wasi-sdk; otherwise docker carries it.
     const wasiHostSdk = target?.platform === 'wasi' ? resolveWasiSdkPath(state.config.system) : null;
     if ((target?.platform !== 'ios' && !(target?.platform === 'wasi' && wasiHostSdk)) || program !== null) {
-        pullDockerImage(imageRoleFor(target));
+        // Google ships the linux NDK for x86_64 only, so the android index carries no arm64 leaf;
+        // pull its amd64 leaf by ref or an arm64 host finds no matching manifest.
+        pullDockerImage(imageRoleFor(target), target?.platform === 'android' ? 'linux/amd64' : undefined);
     }
 
     let dProgram = program;

package/vitest.config.js

@@ -15,25 +15,31 @@ export default defineConfig({
         coverage: {
             provider: 'v8',
             reporter: ['text', 'html'],
-            // The unit-testable surface: pure helpers, config/state derivation, and the JS
-            // runtime that ships into consumer apps. src/actions/ stays out - it shells out to
-            // docker/emcc/cargo, so a unit test there would pin the command line rather than
-            // behaviour, and the e2e suites already cover that layer.
-            include: ['src/utils/**/*.js', 'src/state/**/*.js', 'src/assets/**/*.js'],
+            // src/actions/ used to be excluded on the grounds that it only shells out to
+            // docker/emcc/cargo, so a test there would pin a command line rather than behaviour,
+            // and that the e2e suites already covered it. 2.0.0-beta.50 disproved the second half:
+            // one call site asked docker for an image ref that does not exist on arm64, no e2e
+            // exercised a machine without that image already cached, and android builds shipped
+            // broken to every Apple Silicon user. Which command line these actions build IS the
+            // behaviour, so the layer is measured.
+            include: ['src/utils/**/*.js', 'src/state/**/*.js', 'src/assets/**/*.js', 'src/actions/**/*.js'],
             all: true,
             // A floor with a one-point band, not a ratchet. Coverage is not identical across
             // environments - resolveEmbindRust walks the real node_modules layout, so which of its
             // catch branches run differs between a dev machine and a fresh CI install - and the
             // totals land a few hundredths apart. Auto-raising these locally while enforcing them
             // exactly on CI therefore fails on that difference rather than on a regression: CI
-            // measured 81.67/76.66/84.31/82.72 against floors written from a local run. These are
-            // the CI numbers minus about a point; raise them deliberately when a gain is worth
+            // measured 81.67/76.66/84.31/82.72 against floors written from a local run. The
+            // figures below are a local run of the widened surface (62.18/55.64/65.96/62.09) minus
+            // about a point. They read lower than the numbers they replace because they now count
+            // src/actions/, not because anything regressed - the old floors simply were not
+            // measuring the layer that broke. Raise them deliberately when a gain is worth
             // locking in.
             thresholds: {
-                statements: 80.6,
-                branches: 75.6,
-                functions: 83.3,
-                lines: 81.7,
+                statements: 61.2,
+                branches: 54.6,
+                functions: 65.0,
+                lines: 61.1,
             },
         },
     },