critique 0.1.87 → 0.1.103

package/AGENTS.md

@@ -131,3 +131,14 @@ npx opensrc <owner>/<repo>      # GitHub repo (e.g., npx opensrc vercel/ai)
 ```
 
 <!-- opensrc:end -->
+
+## opentui fork
+
+we are using an opentui fork with name opentuah with my personal PRs merged
+
+"@opentui/core": "npm:@opentuah/core@^0.1.80",
+"@opentui/react": "npm:@opentuah/react@^0.1.80",
+
+To find my opentui folder with that fork see kimaki projects via kimaki cli, the one named opentui.
+
+To apply fixes there you must create a new branch and then merge it in the branch called opentuah. then publish and update the versions here. to publish there is a script specifically for opentuah.

package/CHANGELOG.md

@@ -1,3 +1,108 @@
+# 0.1.103
+
+- Syntax highlighting:
+  - JSON: render punctuation (quotes/brackets/separators) using comment color instead of operator red / full-bright
+
+# 0.1.102
+
+- `critique --web` / `critique web`:
+  - Render the upload notice block in a single muted color (no mixed emphasis)
+
+# 0.1.101
+
+- `critique` / `critique --web` / OG images:
+  - Pass `addedBg`/`removedBg` alongside content backgrounds so opentui's word-level highlights don't inherit dark defaults on light themes
+  - Keep a small `github-light`-only `addedWordBg` override to make added word highlights visible in images
+
+# 0.1.100
+
+- Dependencies:
+  - Update `@opentui/core` / `@opentui/react` npm aliases to `@opentuah/*@0.1.88`
+  - Remove `@opentuah/core-darwin-arm64` optional dependency (core pulls the correct platform binary via its own optional deps)
+
+# 0.1.99
+
+- `critique` / `critique review` / `critique web` / `critique hunks list`:
+  - Define `--filter <pattern>` as an array schema in goke so repeated flags are parsed explicitly as `string[]`
+- `critique review`:
+  - Define `--session <id>` as an array schema so repeated session flags are handled natively
+
+# 0.1.98
+
+- Dependencies:
+  - Replace `@xmorse/cac` with `goke` for CLI argument parsing
+
+# 0.1.97
+
+- `README`:
+  - Make the `CodeRabbit` sponsor text clickable while keeping the compact logo link
+
+# 0.1.96
+
+- `README`:
+  - Add a bottom `Sponsors` section with a compact CodeRabbit logo link to `https://coderabbit.link/remorses`
+
+# 0.1.95
+
+- Syntax highlighting:
+  - `json`:
+    - Color JSON quote characters (`"`) separately as `punctuation.delimiter` while keeping string text highlighted as `property` (keys) and `string` (values)
+
+# 0.1.94
+
+- Syntax highlighting:
+  - Fix JSON syntax highlighting by using local query file with captures compatible with themes.ts (nvim-treesitter uses incompatible `#set!` and `#eq?` predicates)
+  - Fix syntax highlighting in web preview by pre-initializing TreeSitter client before rendering
+
+# 0.1.93
+
+- Dependencies:
+  - Update `@opentui/core` and `@opentui/react` npm aliases to `@opentuah/*@^0.1.81`
+
+# 0.1.92
+
+- `critique`:
+  - Keep dropdown search on `<textarea>` and fix filtering by syncing `plainText` from `onContentChange` in a microtask, plus extract shared filtering logic for deterministic matching across theme/file pickers
+  - Make watch-mode loading/empty backgrounds reactive to the selected theme by subscribing to `useAppStore` instead of reading `getState()` once
+- `critique pick`:
+  - Use the active global theme for picker UI colors instead of always forcing the default theme
+- `diff rendering`:
+  - Remount the `DiffView` wrapper on theme changes so internal diff backgrounds refresh more reliably when switching themes
+- Tests:
+  - Add `src/components/diff-view.test.tsx` to verify theme-switch background updates in `DiffView`
+  - Add dropdown filtering coverage via exported `filterDropdownOptions` tests in `src/dropdown.test.tsx`
+
+# 0.1.91
+
+- `critique`:
+  - Improve main diff layout scrolling behavior by allowing the scrollbox to shrink within the column layout (`flexShrink: 1`)
+- Tests:
+  - Add `src/cli-scroll.test.tsx` using opentui test renderer to verify mouse-wheel scrolling changes visible content in the main diff view
+  - Guard CLI entrypoint parsing with `import.meta.main` and export `App`/`AppProps` to support renderer-driven CLI view tests
+
+# 0.1.90
+
+- `critique`:
+  - Fix dropdown search input in file/theme pickers by switching to `<input onInput>` so typed text filters options immediately
+  - Ensure diff internals fully refresh on theme change by remounting `<diff>` when `themeName` changes
+  - Make loading/empty-state backgrounds reactive to theme changes in watch mode
+- `critique pick`:
+  - Use the currently selected global theme instead of always forcing the default theme
+- Tests:
+  - Add a dropdown regression test that reproduces and verifies theme search filtering
+  - Add a DiffView regression test that verifies diff background colors actually change after a runtime theme switch
+
+# 0.1.89
+
+- `critique`:
+  - Keep the main diff scrollbox focused so mouse-wheel scrolling works reliably in the default diff view
+
+# 0.1.88
+
+- Dependencies:
+  - Keep `@opentui/*` imports/package names and install Jake's fork via npm alias mapping
+  - Map `@opentui/core` -> `npm:@opentuah/core@latest` and `@opentui/react` -> `npm:@opentuah/react@latest`
+
 # 0.1.87
 
 - `hunks`:

package/README.md

@@ -318,6 +318,14 @@ Files with more than 6000 lines of diff are also hidden for performance.
 - [diff](https://github.com/kpdecker/jsdiff) - Diff algorithm
 - [Hono](https://hono.dev/) - Web framework for the preview worker
 
+## Sponsors
+
+<a href="https://coderabbit.link/remorses" target="_blank" rel="noopener noreferrer">
+  <img src="https://github.com/coderabbitai.png" alt="CodeRabbit" height="24" />
+</a>
+
+Sponsored by [CodeRabbit](https://coderabbit.link/remorses).
+
 ## License
 
 MIT

package/global.d.ts

@@ -0,0 +1,5 @@
+// Type declarations for importing .scm files with Bun
+declare module "*.scm" {
+  const value: string
+  export default value
+}

package/package.json

@@ -2,7 +2,7 @@
   "name": "critique",
   "module": "src/diff.tsx",
   "type": "module",
-  "version": "0.1.87",
+  "version": "0.1.103",
   "license": "MIT",
   "private": false,
   "bin": "./src/cli.tsx",
@@ -28,10 +28,10 @@
   "dependencies": {
     "@agentclientprotocol/sdk": "^0.13.1",
     "@clack/prompts": "1.0.0-alpha.9",
-    "@opentui/core": "^0.1.77",
-    "@opentui/react": "^0.1.77",
+    "@opentui/core": "npm:@opentuah/core@0.1.88",
+    "@opentui/react": "npm:@opentuah/react@0.1.88",
     "@parcel/watcher": "^2.5.6",
-    "@xmorse/cac": "^6.0.7",
+    "goke": "^6.1.3",
     "diff": "^8.0.2",
     "js-yaml": "^4.1.1",
     "marked": "^17.0.1",

package/parsers-config.ts

@@ -3,6 +3,14 @@
 // Warn: when taking queries from the nvim-treesitter repo, make sure to include the query dependencies as well
 //       marked with for example `; inherits: ecma` at the top of the file. Just put the dependencies before the actual query.
 //       ALSO: Some queries use breaking changes in the nvim-treesitter repo, that are not compatible with the (web-)tree-sitter parser.
+import { resolve, dirname } from "path"
+import { fileURLToPath } from "url"
+
+// Local query files for languages where remote queries have incompatible predicates
+import jsonHighlights from "./queries/json/highlights.scm" with { type: "file" }
+
+const __dirname = dirname(fileURLToPath(import.meta.url))
+
 export default {
   parsers: [
     {
@@ -164,7 +172,9 @@ export default {
       wasm: "https://github.com/tree-sitter/tree-sitter-json/releases/download/v0.24.8/tree-sitter-json.wasm",
       queries: {
         highlights: [
-          "https://raw.githubusercontent.com/nvim-treesitter/nvim-treesitter/refs/heads/master/queries/json/highlights.scm",
+          // Local query file - nvim-treesitter and tree-sitter-json queries use predicates/captures
+          // incompatible with web-tree-sitter or themes.ts
+          resolve(__dirname, jsonHighlights),
         ],
       },
     },

package/queries/json/highlights.scm

@@ -0,0 +1,42 @@
+; JSON highlights query for critique
+; Uses captures compatible with themes.ts mappings
+; No predicates (like #set! or #eq?) that are unsupported by web-tree-sitter
+
+(pair
+  key: (string
+    (string_content) @property))
+
+(pair
+  value: (string
+    (string_content) @string))
+
+(array
+  (string
+    (string_content) @string))
+
+(number) @number
+
+[
+  (true)
+  (false)
+] @boolean
+
+(null) @constant
+
+(escape_sequence) @string
+
+; Keep JSON punctuation muted (not operator-red / not full-bright)
+("\"") @comment
+
+; JSON separators should render muted, not like operators
+[
+  ","
+  ":"
+] @comment
+
+[
+  "["
+  "]"
+  "{"
+  "}"
+] @comment

package/scripts/fixtures/json-syntax-example.json

@@ -0,0 +1,13 @@
+{
+  "_comment": "Example JSON for critique syntax highlighting preview.",
+  "name": "critique",
+  "count": 12,
+  "enabled": true,
+  "ratio": 0.125,
+  "tags": ["diff", "tui", "web"],
+  "nested": {
+    "a": 1,
+    "b": null,
+    "url": "https://critique.work/v/example"
+  }
+}

package/src/cli-scroll.test.tsx

@@ -0,0 +1,66 @@
+// Tests mouse-wheel scrolling behavior in the main diff App scrollbox.
+
+import * as React from "react"
+import { afterEach, describe, expect, it } from "bun:test"
+import { act } from "react"
+import { testRender } from "@opentui/react/test-utils"
+import { App } from "./cli.tsx"
+import type { ParsedFile } from "./diff-utils.ts"
+
+function createParsedFile(index: number): ParsedFile {
+  const path = `src/file-${index.toString().padStart(2, "0")}.ts`
+
+  return {
+    oldFileName: `a/${path}`,
+    newFileName: `b/${path}`,
+    hunks: [{ lines: [`+export const value${index} = ${index}`] }],
+    rawDiff: [
+      `diff --git a/${path} b/${path}`,
+      `--- a/${path}`,
+      `+++ b/${path}`,
+      "@@ -0,0 +1 @@",
+      `+export const value${index} = ${index}`,
+    ].join("\n"),
+  }
+}
+
+describe("App scrollbox", () => {
+  let testSetup: Awaited<ReturnType<typeof testRender>>
+
+  afterEach(() => {
+    if (testSetup) {
+      act(() => {
+        testSetup.renderer.destroy()
+      })
+    }
+  })
+
+  it("scrolls diff view content with mouse wheel", async () => {
+    const parsedFiles = Array.from({ length: 40 }, (_, index) => createParsedFile(index))
+
+    testSetup = await testRender(<App parsedFiles={parsedFiles} />, {
+      width: 80,
+      height: 20,
+    })
+
+    await act(async () => {
+      await testSetup.renderOnce()
+    })
+
+    const before = testSetup.captureCharFrame()
+    expect(before).toContain("file-00.ts")
+    expect(before).not.toContain("a/src/file-")
+
+    for (let i = 0; i < 20; i++) {
+      await act(async () => {
+        await testSetup.mockMouse.scroll(10, 10, "down")
+        await testSetup.renderOnce()
+      })
+    }
+
+    const after = testSetup.captureCharFrame()
+    expect(after).not.toBe(before)
+    expect(after).toContain("a/src/file-")
+    expect(after).not.toContain("file-00.ts")
+  })
+})