critique 0.1.103 → 0.1.104

package/AGENTS.md

@@ -17,8 +17,8 @@ gh pr view 536 -R anomalyco/opentui --json commits --jq '.commits[-1].oid[:40]'
 then use it in package.json:
 
 ```
-https://pkg.pr.new/anomalyco/opentui/@opentui/core@<hash>
-https://pkg.pr.new/anomalyco/opentui/@opentui/react@<hash>
+https://pkg.pr.new/anomalyco/opentui/@opentuah/core@<hash>
+https://pkg.pr.new/anomalyco/opentui/@opentuah/react@<hash>
 ```
 
 YOU MUST ALWAYS use the commit hash 40 characters long when changing the pkg.pr.new url! not the pr number! 
@@ -134,10 +134,7 @@ npx opensrc <owner>/<repo>      # GitHub repo (e.g., npx opensrc vercel/ai)
 
 ## opentui fork
 
-we are using an opentui fork with name opentuah with my personal PRs merged
-
-"@opentui/core": "npm:@opentuah/core@^0.1.80",
-"@opentui/react": "npm:@opentuah/react@^0.1.80",
+we are using an opentui fork published as `@opentuah`. imports use `@opentuah/core` and `@opentuah/react` directly (no npm alias remapping).
 
 To find my opentui folder with that fork see kimaki projects via kimaki cli, the one named opentui.
 

package/CHANGELOG.md

@@ -1,3 +1,12 @@
+# 0.1.104
+
+- `critique --stdin` (pager mode):
+  - Force scrollback mode for `--stdin` pager usage to fix lazygit integration (#25)
+  - When used as a pager (e.g. `critique --stdin` in lazygit), critique now correctly outputs static colored text instead of interactive TUI escape sequences
+- `critique`:
+  - Fix crash in Bun compiled binaries where terminal TTY `columns`/`rows` report as 0, causing NaN framebuffer dimensions
+  - Replace `@opentui/*` npm alias remapping with direct `@opentuah/*` imports
+
 # 0.1.103
 
 - Syntax highlighting:

package/package.json

@@ -2,7 +2,7 @@
   "name": "critique",
   "module": "src/diff.tsx",
   "type": "module",
-  "version": "0.1.103",
+  "version": "0.1.104",
   "license": "MIT",
   "private": false,
   "bin": "./src/cli.tsx",
@@ -28,11 +28,11 @@
   "dependencies": {
     "@agentclientprotocol/sdk": "^0.13.1",
     "@clack/prompts": "1.0.0-alpha.9",
-    "@opentui/core": "npm:@opentuah/core@0.1.88",
-    "@opentui/react": "npm:@opentuah/react@0.1.88",
+    "@opentuah/core": "0.1.95",
+    "@opentuah/react": "0.1.95",
     "@parcel/watcher": "^2.5.6",
-    "goke": "^6.1.3",
     "diff": "^8.0.2",
+    "goke": "^6.1.3",
     "js-yaml": "^4.1.1",
     "marked": "^17.0.1",
     "picocolors": "^1.1.1",

package/scripts/preview-review.tsx

@@ -3,12 +3,12 @@
 // Renders example hunks and review data to preview TUI appearance.
 // Run with: bun run scripts/preview-review.tsx (TUI) or --web (HTML upload).
 
-import { createCliRenderer, addDefaultParsers } from "@opentui/core"
+import { createCliRenderer, addDefaultParsers } from "@opentuah/core"
 import parsersConfig from "../parsers-config.ts"
 
 // Register custom syntax highlighting parsers
 addDefaultParsers(parsersConfig.parsers)
-import { createRoot } from "@opentui/react"
+import { createRoot } from "@opentuah/react"
 import * as React from "react"
 import { ReviewApp, ReviewAppView } from "../src/review/review-app.tsx"
 import { createHunk } from "../src/review/hunk-parser.ts"

package/src/ansi-html.ts

@@ -2,8 +2,8 @@
 // Uses opentui's test renderer to capture structured span data and generates responsive HTML documents
 // with proper font scaling to fit terminal content within viewport width.
 
-import { TextAttributes, rgbToHex, type RGBA } from "@opentui/core"
-import type { CapturedFrame, CapturedLine, CapturedSpan } from "@opentui/core"
+import { TextAttributes, rgbToHex, type RGBA } from "@opentuah/core"
+import type { CapturedFrame, CapturedLine, CapturedSpan } from "@opentuah/core"
 
 export interface ToHtmlOptions {
   /** Background color for the container */

package/src/ansi-output.test.ts

@@ -1,7 +1,7 @@
 import { describe, test, expect } from "bun:test"
 import { spanToAnsi, frameToAnsi } from "./ansi-output.ts"
-import { RGBA } from "@opentui/core"
-import type { CapturedFrame, CapturedSpan, CapturedLine } from "@opentui/core"
+import { RGBA } from "@opentuah/core"
+import type { CapturedFrame, CapturedSpan, CapturedLine } from "@opentuah/core"
 
 const themeBg = RGBA.fromValues(0, 0, 0, 1) // Black background
 

package/src/ansi-output.ts

@@ -3,8 +3,8 @@
 // Falls back gracefully: truecolor → 256 → 16 → plain text.
 
 import supportsColor from "supports-color"
-import { TextAttributes, type RGBA } from "@opentui/core"
-import type { CapturedFrame, CapturedSpan, CapturedLine } from "@opentui/core"
+import { TextAttributes, type RGBA } from "@opentuah/core"
+import type { CapturedFrame, CapturedSpan, CapturedLine } from "@opentuah/core"
 
 // Color support levels: 0=none, 1=16 colors, 2=256 colors, 3=truecolor
 type ColorLevel = 0 | 1 | 2 | 3

package/src/cli-scroll.test.tsx

@@ -3,7 +3,7 @@
 import * as React from "react"
 import { afterEach, describe, expect, it } from "bun:test"
 import { act } from "react"
-import { testRender } from "@opentui/react/test-utils"
+import { testRender } from "@opentuah/react/test-utils"
 import { App } from "./cli.tsx"
 import type { ParsedFile } from "./diff-utils.ts"
 

package/src/cli.tsx

@@ -3,6 +3,10 @@
 // Provides TUI diff viewing, AI-powered review generation, and web preview upload.
 // Commands: default (diff), review (AI analysis), web (HTML upload), pick (cherry-pick files).
 
+// Must be first import: patches process.stdout.columns/rows for Bun compiled binaries
+// where they incorrectly return 0 instead of actual terminal dimensions.
+import "./patch-terminal-dimensions.ts";
+
 import { goke, wrapJsonSchema } from "goke";
 import {
   createRoot,
@@ -11,7 +15,7 @@ import {
   useOnResize,
   useRenderer,
   useTerminalDimensions,
-} from "@opentui/react";
+} from "@opentuah/react";
 import { useCopySelection } from "./hooks/use-copy-selection.ts";
 import * as React from "react";
 import { exec, execSync } from "child_process";
@@ -22,7 +26,7 @@ import {
   ScrollBoxRenderable,
   BoxRenderable,
   addDefaultParsers,
-} from "@opentui/core";
+} from "@opentuah/core";
 import parsersConfig from "../parsers-config.ts";
 
 // Register custom syntax highlighting parsers
@@ -1826,7 +1830,7 @@ cli
       return;
     }
 
-    if (options.scrollback || !process.stdout.isTTY) {
+    if (options.scrollback || options.stdin || !process.stdout.isTTY) {
       // For scrollback, prefer terminal width over --cols default (240 is for web)
       const scrollbackCols = process.stdout.columns || parseInt(options.cols) || 120;
       await runScrollbackMode(cleanedDiff, {

package/src/components/diff-view.test.tsx

@@ -3,7 +3,7 @@
 import * as React from "react"
 import { afterEach, describe, expect, it } from "bun:test"
 import { act } from "react"
-import { testRender } from "@opentui/react/test-utils"
+import { testRender } from "@opentuah/react/test-utils"
 import { DiffView } from "./diff-view.tsx"
 import { useAppStore } from "../store.ts"
 

package/src/components/diff-view.tsx

@@ -3,7 +3,7 @@
 // Supports split and unified view modes with line numbers.
 
 import * as React from "react"
-import { SyntaxStyle } from "@opentui/core"
+import { SyntaxStyle } from "@opentuah/core"
 import { getSyntaxTheme, getResolvedTheme, rgbaToHex } from "../themes.ts"
 
 export interface DiffViewProps {

package/src/diff-utils.ts

@@ -459,7 +459,7 @@ export function processFiles<T extends ParsedFile>(
 
 /**
  * Detect filetype from filename for syntax highlighting
- * Maps to tree-sitter parsers available in @opentui/core and parsers-config.ts
+ * Maps to tree-sitter parsers available in @opentuah/core and parsers-config.ts
  */
 export function detectFiletype(filePath: string): string | undefined {
   const ext = filePath.split(".").pop()?.toLowerCase();

package/src/directory-tree.test.tsx

@@ -2,7 +2,7 @@
 // Uses opentui test renderer with captureCharFrame() for visual testing
 
 import { afterEach, describe, expect, it } from "bun:test"
-import { testRender } from "@opentui/react/test-utils"
+import { testRender } from "@opentuah/react/test-utils"
 import { buildDirectoryTree, type TreeFileInfo, type TreeNode } from "./directory-tree.ts"
 import { DirectoryTreeView } from "./components/directory-tree-view.tsx"
 

package/src/dropdown.test.tsx

@@ -1,7 +1,7 @@
 import * as React from "react"
 import { afterEach, describe, expect, it } from "bun:test"
 import { act } from "react"
-import { testRender } from "@opentui/react/test-utils"
+import { testRender } from "@opentuah/react/test-utils"
 import Dropdown, { filterDropdownOptions } from "./dropdown.tsx"
 import { getResolvedTheme } from "./themes.ts"
 

package/src/dropdown.tsx

@@ -3,8 +3,8 @@
 // Used by main diff view for file picker and theme picker overlays.
 
 import React, { useCallback, useEffect, useRef, useState, type ReactNode } from "react";
-import { useKeyboard } from "@opentui/react";
-import { TextAttributes, TextareaRenderable } from "@opentui/core";
+import { useKeyboard } from "@opentuah/react";
+import { TextAttributes, TextareaRenderable } from "@opentuah/core";
 import { type ResolvedTheme, rgbaToHex } from "./themes";
 
 export interface DropdownOption {

package/src/hooks/use-copy-selection.ts

@@ -2,7 +2,7 @@
 // Automatically copies selected text to clipboard when user releases mouse button.
 // Uses native clipboard commands (pbcopy, xclip, etc.) with OSC52 fallback.
 
-import { useRenderer } from "@opentui/react"
+import { useRenderer } from "@opentuah/react"
 import { spawn } from "child_process"
 
 /**

package/src/image.ts

@@ -2,7 +2,7 @@
 // Uses opentui-image.ts for generic frame-to-image conversion.
 // Adds theme resolution and diff/review-specific rendering.
 
-import type { CapturedFrame } from "@opentui/core"
+import type { CapturedFrame } from "@opentuah/core"
 import { getResolvedTheme, rgbaToHex } from "./themes.ts"
 import {
   renderFrameToImage,

package/src/opentui-image.ts

@@ -4,8 +4,8 @@
 import { tmpdir } from "os"
 import { join } from "path"
 import fs from "fs"
-import { TextAttributes, rgbToHex, type RGBA } from "@opentui/core"
-import type { CapturedFrame, CapturedLine, CapturedSpan } from "@opentui/core"
+import { TextAttributes, rgbToHex, type RGBA } from "@opentuah/core"
+import type { CapturedFrame, CapturedLine, CapturedSpan } from "@opentuah/core"
 
 // ─────────────────────────────────────────────────────────────
 // Types

package/src/patch-terminal-dimensions.ts

@@ -0,0 +1,51 @@
+// Polyfill for terminal dimensions in Bun compiled binaries.
+// Bun's `--compile` produces binaries where process.stdout.columns/rows are 0
+// instead of the actual terminal size (even when isTTY is true).
+// This must be imported before any opentui imports, since opentui reads
+// stdout.columns at init time and uses `?? fallback` which doesn't catch 0.
+
+import { execSync } from "child_process"
+
+function getTerminalSize(): { cols: number; rows: number } | null {
+  try {
+    const cols = parseInt(
+      execSync("tput cols", {
+        encoding: "utf-8",
+        stdio: ["inherit", "pipe", "pipe"],
+      }).trim(),
+    )
+    const rows = parseInt(
+      execSync("tput lines", {
+        encoding: "utf-8",
+        stdio: ["inherit", "pipe", "pipe"],
+      }).trim(),
+    )
+    if (cols > 0 && rows > 0) return { cols, rows }
+  } catch {}
+  return null
+}
+
+if (process.stdout.isTTY && process.stdout.columns === 0) {
+  const size = getTerminalSize()
+  if (size) {
+    Object.defineProperty(process.stdout, "columns", {
+      value: size.cols,
+      writable: true,
+      configurable: true,
+    })
+    Object.defineProperty(process.stdout, "rows", {
+      value: size.rows,
+      writable: true,
+      configurable: true,
+    })
+
+    // Keep patched values updated on terminal resize
+    process.on("SIGWINCH", () => {
+      const newSize = getTerminalSize()
+      if (newSize) {
+        process.stdout.columns = newSize.cols
+        process.stdout.rows = newSize.rows
+      }
+    })
+  }
+}

package/src/review/review-app.test.tsx

@@ -1,7 +1,7 @@
 // Test for ReviewAppView rendering with example YAML data
 
 import { afterEach, describe, expect, it } from "bun:test"
-import { testRender } from "@opentui/react/test-utils"
+import { testRender } from "@opentuah/react/test-utils"
 import { ReviewAppView } from "./review-app.tsx"
 import { createHunk } from "./hunk-parser.ts"
 import type { ReviewYaml } from "./types.ts"

package/src/review/review-app.tsx

@@ -3,8 +3,8 @@
 // Supports live generation updates, theme switching, and resume from saved reviews.
 
 import * as React from "react"
-import { useKeyboard, useRenderer, useTerminalDimensions } from "@opentui/react"
-import { MacOSScrollAccel, SyntaxStyle, BoxRenderable, CodeRenderable, TextRenderable, ScrollBoxRenderable } from "@opentui/core"
+import { useKeyboard, useRenderer, useTerminalDimensions } from "@opentuah/react"
+import { MacOSScrollAccel, SyntaxStyle, BoxRenderable, CodeRenderable, TextRenderable, ScrollBoxRenderable } from "@opentuah/core"
 import { useCopySelection } from "../hooks/use-copy-selection.ts"
 import type { Token } from "marked"
 import { getResolvedTheme, getSyntaxTheme, defaultThemeName, themeNames, rgbaToHex } from "../themes.ts"

package/src/review/stream-display.test.tsx

@@ -1,7 +1,7 @@
 // Tests for StreamDisplay component
 
 import { afterEach, describe, expect, it } from "bun:test"
-import { testRender } from "@opentui/react/test-utils"
+import { testRender } from "@opentuah/react/test-utils"
 import type { SessionNotification } from "@agentclientprotocol/sdk"
 import { StreamDisplay } from "./stream-display.tsx"
 

package/src/review/stream-display.tsx

@@ -3,7 +3,7 @@
 // Shows formatted tool operations with file names and edit statistics.
 
 import * as React from "react"
-import { SyntaxStyle } from "@opentui/core"
+import { SyntaxStyle } from "@opentuah/core"
 import type { SessionNotification } from "@agentclientprotocol/sdk"
 import { formatNotifications, SYMBOLS, COLORS, isEditTool, type StreamLine } from "./acp-stream-display.ts"
 import { getSyntaxTheme, getResolvedTheme, rgbaToHex } from "../themes.ts"

package/src/stdin-pager.test.ts

@@ -0,0 +1,86 @@
+// Tests for --stdin pager mode (lazygit integration).
+// Reproduces https://github.com/remorses/critique/issues/25
+//
+// Problem: When critique is used as a pager in lazygit:
+//   git.paging.pager: critique --stdin
+//
+// Lazygit runs the pager using a PTY (github.com/creack/pty), so from critique's
+// perspective process.stdout.isTTY is true. The current mode selection logic:
+//
+//   if (options.scrollback || !process.stdout.isTTY)  →  scrollback mode
+//   else  →  TUI mode (interactive, cursor positioning, mouse tracking)
+//
+// Since stdout IS a TTY (PTY), critique enters TUI mode and outputs raw escape
+// sequences like [?1000h (mouse tracking), [row;col;H (cursor positioning) etc.
+// Lazygit's pager panel can't interpret these → shows garbled text.
+//
+// Fix: --stdin should always force scrollback mode. A pager consumer never
+// expects interactive TUI — it expects static colored text output.
+
+import { describe, test, expect } from "bun:test"
+
+describe("--stdin pager mode selection (lazygit issue #25)", () => {
+  // This test validates the decision logic that determines whether to use
+  // scrollback mode or TUI mode. It tests the condition directly.
+  test("--stdin should force scrollback mode regardless of TTY status", () => {
+    // Current buggy condition (cli.tsx:1829):
+    const buggyCondition = (options: { scrollback?: boolean; stdin?: boolean }, isTTY: boolean) =>
+      options.scrollback || !isTTY
+
+    // Fixed condition:
+    const fixedCondition = (options: { scrollback?: boolean; stdin?: boolean }, isTTY: boolean) =>
+      options.scrollback || options.stdin || !isTTY
+
+    // Scenario 1: lazygit PTY - stdout IS a TTY, --stdin flag set
+    const lazygitOptions = { stdin: true }
+
+    // BUG: current logic sends lazygit to TUI mode
+    expect(buggyCondition(lazygitOptions, true)).toBe(false) // false = TUI mode (wrong!)
+
+    // FIX: stdin flag should force scrollback
+    expect(fixedCondition(lazygitOptions, true)).toBe(true) // true = scrollback mode (correct!)
+
+    // Scenario 2: piped stdout (non-TTY) - both conditions work
+    expect(buggyCondition(lazygitOptions, false)).toBe(true)
+    expect(fixedCondition(lazygitOptions, false)).toBe(true)
+
+    // Scenario 3: normal TUI usage (no --stdin, real TTY)
+    const normalOptions = {}
+    expect(buggyCondition(normalOptions, true)).toBe(false) // TUI mode
+    expect(fixedCondition(normalOptions, true)).toBe(false) // TUI mode (unchanged)
+
+    // Scenario 4: explicit --scrollback
+    const scrollbackOptions = { scrollback: true }
+    expect(buggyCondition(scrollbackOptions, true)).toBe(true)
+    expect(fixedCondition(scrollbackOptions, true)).toBe(true)
+  })
+
+  // Verify the exact line in cli.tsx has the bug
+  test("cli.tsx line 1829 should include options.stdin in the condition", async () => {
+    const fs = await import("fs")
+    const path = await import("path")
+    const cliSource = fs.readFileSync(path.join(import.meta.dir, "cli.tsx"), "utf-8")
+
+    // The current buggy condition
+    const hasBuggyCondition = cliSource.includes("options.scrollback || !process.stdout.isTTY")
+
+    // The fixed condition should include options.stdin
+    const hasFixedCondition = cliSource.includes("options.stdin") &&
+      /options\.scrollback\s*\|\|\s*options\.stdin\s*\|\|\s*!process\.stdout\.isTTY/.test(cliSource)
+
+    // This test will fail until the fix is applied, documenting the bug
+    if (hasBuggyCondition && !hasFixedCondition) {
+      // Bug is present — document it
+      expect(hasBuggyCondition).toBe(true)
+      // After fix, this assertion should change
+      console.log(
+        "BUG CONFIRMED: cli.tsx:1829 does not include options.stdin in scrollback condition.\n" +
+        "Fix: Change 'options.scrollback || !process.stdout.isTTY'\n" +
+        "  to: 'options.scrollback || options.stdin || !process.stdout.isTTY'"
+      )
+    } else {
+      // Fix has been applied
+      expect(hasFixedCondition).toBe(true)
+    }
+  })
+})

package/src/themes.ts

@@ -2,7 +2,7 @@
 // Loads JSON theme files lazily on demand, resolves color references,
 // and provides both UI colors and Tree-sitter compatible syntax styles.
 
-import { parseColor, RGBA } from "@opentui/core";
+import { parseColor, RGBA } from "@opentuah/core";
 import { fileURLToPath } from "url";
 
 // Only import the default theme statically for fast startup

package/src/web-utils.test.ts

@@ -1,8 +1,8 @@
 import { describe, test, expect, afterEach } from "bun:test"
-import { createTestRenderer } from "@opentui/core/testing"
-import { createRoot } from "@opentui/react"
+import { createTestRenderer } from "@opentuah/core/testing"
+import { createRoot } from "@opentuah/react"
 import React from "react"
-import { RGBA } from "@opentui/core"
+import { RGBA } from "@opentuah/core"
 
 describe("getSpanLines rendering", () => {
   let renderer: Awaited<ReturnType<typeof createTestRenderer>>["renderer"] | null = null

package/src/web-utils.tsx

@@ -8,7 +8,7 @@ import fs from "fs"
 import { tmpdir } from "os"
 import { join } from "path"
 import { getResolvedTheme, rgbaToHex } from "./themes.ts"
-import type { CapturedFrame, RootRenderable, CliRenderer } from "@opentui/core"
+import type { CapturedFrame, RootRenderable, CliRenderer } from "@opentuah/core"
 import type { IndexedHunk, ReviewYaml } from "./review/types.ts"
 import { loadStoredLicenseKey, loadOrCreateOwnerSecret } from "./license.ts"
 
@@ -118,9 +118,9 @@ export async function renderDiffToFrame(
   diffContent: string,
   options: CaptureOptions
 ): Promise<CapturedFrame> {
-  const { createTestRenderer } = await import("@opentui/core/testing")
-  const { createRoot } = await import("@opentui/react")
-  const { getTreeSitterClient } = await import("@opentui/core")
+  const { createTestRenderer } = await import("@opentuah/core/testing")
+  const { createRoot } = await import("@opentuah/react")
+  const { getTreeSitterClient } = await import("@opentuah/core")
   const React = await import("react")
   const { parsePatch, formatPatch } = await import("diff")
   
@@ -375,9 +375,9 @@ export interface ReviewRenderOptions extends CaptureOptions {
 export async function renderReviewToFrame(
   options: ReviewRenderOptions
 ): Promise<CapturedFrame> {
-  const { createTestRenderer } = await import("@opentui/core/testing")
-  const { createRoot } = await import("@opentui/react")
-  const { getTreeSitterClient } = await import("@opentui/core")
+  const { createTestRenderer } = await import("@opentuah/core/testing")
+  const { createRoot } = await import("@opentuah/react")
+  const { getTreeSitterClient } = await import("@opentuah/core")
   const React = await import("react")
   
   // Pre-initialize TreeSitter client to ensure syntax highlighting works

package/tsconfig.json

@@ -7,7 +7,7 @@
     "module": "Preserve",
     "moduleDetection": "force",
     "jsx": "react-jsx",
-    "jsxImportSource": "@opentui/react",
+    "jsxImportSource": "@opentuah/react",
     "allowJs": true,
 
     "noImplicitAny": false,