critique 0.0.13 → 0.0.14

package/CHANGELOG.md

@@ -1,3 +1,10 @@
+# 0.0.14
+
+- Default command:
+  - Fix `/dev/null` appearing as filename for new/deleted files
+  - Simplify top navigation by removing "prev file" and "next file" text labels
+  - Move file counter from top to bottom navigation bar next to "select file"
+
 # 0.0.13
 
 - Default command:

package/package.json

@@ -2,7 +2,7 @@
   "name": "critique",
   "module": "src/diff.tsx",
   "type": "module",
-  "version": "0.0.13",
+  "version": "0.0.14",
   "private": false,
   "bin": "./src/cli.tsx",
   "scripts": {

package/src/cli.tsx

@@ -35,6 +35,17 @@ const IGNORED_FILES = [
 
 const BACKGROUND_COLOR = "#0f0f0f";
 
+function getFileName(file: { oldFileName?: string; newFileName?: string }): string {
+  const newName = file.newFileName;
+  const oldName = file.oldFileName;
+  
+  // Filter out /dev/null which appears for new/deleted files
+  if (newName && newName !== "/dev/null") return newName;
+  if (oldName && oldName !== "/dev/null") return oldName;
+  
+  return "unknown";
+}
+
 function execSyncWithError(
   command: string,
   options?: any,
@@ -147,7 +158,7 @@ function App({ parsedFiles }: AppProps) {
     );
   }
 
-  const fileName = currentFile.newFileName || currentFile.oldFileName || "unknown";
+  const fileName = getFileName(currentFile);
 
   // Calculate additions and deletions
   let additions = 0;
@@ -160,7 +171,7 @@ function App({ parsedFiles }: AppProps) {
   });
 
   const dropdownOptions = parsedFiles.map((file, idx) => {
-    const name = file.newFileName || file.oldFileName || "unknown";
+    const name = getFileName(file);
     return {
       title: name,
       value: String(idx),
@@ -200,18 +211,13 @@ function App({ parsedFiles }: AppProps) {
       {/* Navigation header */}
       <box style={{ paddingBottom: 1, paddingLeft: 1, paddingRight: 1, flexShrink: 0, flexDirection: "row", alignItems: "center" }}>
         <text fg="#ffffff">←</text>
-        <text fg="#666666"> prev file</text>
         <box flexGrow={1} />
         <text onMouseDown={() => setShowDropdown(true)}>
           {fileName.trim()} 
         </text>
         <text fg="#00ff00"> +{additions}</text>
-        <text fg="#ff0000">-{deletions} </text>
-        <text fg="#666666">
-          ({validIndex + 1}/{parsedFiles.length})
-        </text>
+        <text fg="#ff0000">-{deletions}</text>
         <box flexGrow={1} />
-        <text fg="#666666">next file </text>
         <text fg="#ffffff">→</text>
       </box>
 
@@ -250,7 +256,8 @@ function App({ parsedFiles }: AppProps) {
         <text fg="#666666"> prev file</text>
         <box flexGrow={1} />
         <text fg="#ffffff">ctrl p</text>
-        <text fg="#666666"> select file</text>
+        <text fg="#666666"> select file </text>
+        <text fg="#666666">({validIndex + 1}/{parsedFiles.length})</text>
         <box flexGrow={1} />
         <text fg="#666666">next file </text>
         <text fg="#ffffff">→</text>
@@ -307,7 +314,7 @@ cli
               const files = parsePatch(gitDiff);
 
               const filteredFiles = files.filter((file) => {
-                const fileName = file.newFileName || file.oldFileName || "";
+                const fileName = getFileName(file);
                 const baseName = fileName.split("/").pop() || "";
 
                 if (IGNORED_FILES.includes(baseName) || baseName.endsWith(".lock")) {