critical-gate 2.0.1 → 2.1.0
This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
- package/README.md +163 -0
- package/dist/cli.d.ts +7 -2
- package/dist/cli.d.ts.map +1 -1
- package/dist/cli.js +469 -20
- package/dist/cli.js.map +1 -1
- package/dist/config/critical-gate-config.d.ts +41 -0
- package/dist/config/critical-gate-config.d.ts.map +1 -1
- package/dist/config/critical-gate-config.js +193 -4
- package/dist/config/critical-gate-config.js.map +1 -1
- package/dist/config/index.d.ts +2 -1
- package/dist/config/index.d.ts.map +1 -1
- package/dist/config/index.js +2 -1
- package/dist/config/index.js.map +1 -1
- package/dist/config/learning-policy.d.ts +9 -0
- package/dist/config/learning-policy.d.ts.map +1 -0
- package/dist/config/learning-policy.js +34 -0
- package/dist/config/learning-policy.js.map +1 -0
- package/dist/detectors/api-surface-detector.d.ts.map +1 -1
- package/dist/detectors/api-surface-detector.js +123 -5
- package/dist/detectors/api-surface-detector.js.map +1 -1
- package/dist/detectors/confidence-calibration.d.ts +11 -0
- package/dist/detectors/confidence-calibration.d.ts.map +1 -0
- package/dist/detectors/confidence-calibration.js +53 -0
- package/dist/detectors/confidence-calibration.js.map +1 -0
- package/dist/detectors/existing-solution-detector.js +6 -0
- package/dist/detectors/existing-solution-detector.js.map +1 -1
- package/dist/detectors/expected-companions-detector.d.ts.map +1 -1
- package/dist/detectors/expected-companions-detector.js +208 -10
- package/dist/detectors/expected-companions-detector.js.map +1 -1
- package/dist/detectors/index.d.ts +1 -0
- package/dist/detectors/index.d.ts.map +1 -1
- package/dist/detectors/index.js +1 -0
- package/dist/detectors/index.js.map +1 -1
- package/dist/detectors/intent-verification-detector.d.ts.map +1 -1
- package/dist/detectors/intent-verification-detector.js +64 -1
- package/dist/detectors/intent-verification-detector.js.map +1 -1
- package/dist/detectors/reason-chain.d.ts +4 -0
- package/dist/detectors/reason-chain.d.ts.map +1 -0
- package/dist/detectors/reason-chain.js +102 -0
- package/dist/detectors/reason-chain.js.map +1 -0
- package/dist/detectors/repair-contract.d.ts +4 -0
- package/dist/detectors/repair-contract.d.ts.map +1 -0
- package/dist/detectors/repair-contract.js +45 -0
- package/dist/detectors/repair-contract.js.map +1 -0
- package/dist/detectors/repository-intelligence-detector.d.ts.map +1 -1
- package/dist/detectors/repository-intelligence-detector.js +17 -4
- package/dist/detectors/repository-intelligence-detector.js.map +1 -1
- package/dist/detectors/rewrite-detector.d.ts.map +1 -1
- package/dist/detectors/rewrite-detector.js +5 -2
- package/dist/detectors/rewrite-detector.js.map +1 -1
- package/dist/detectors/runner.d.ts +1 -0
- package/dist/detectors/runner.d.ts.map +1 -1
- package/dist/detectors/runner.js +50 -3
- package/dist/detectors/runner.js.map +1 -1
- package/dist/detectors/secret-path-detector.js +1 -1
- package/dist/detectors/secret-path-detector.js.map +1 -1
- package/dist/detectors/test-weakening-detector.d.ts.map +1 -1
- package/dist/detectors/test-weakening-detector.js +188 -39
- package/dist/detectors/test-weakening-detector.js.map +1 -1
- package/dist/detectors/types.d.ts +2 -0
- package/dist/detectors/types.d.ts.map +1 -1
- package/dist/diff/git-diff-reader.d.ts +1 -0
- package/dist/diff/git-diff-reader.d.ts.map +1 -1
- package/dist/diff/git-diff-reader.js +6 -3
- package/dist/diff/git-diff-reader.js.map +1 -1
- package/dist/diff/path-classifier.d.ts.map +1 -1
- package/dist/diff/path-classifier.js +9 -1
- package/dist/diff/path-classifier.js.map +1 -1
- package/dist/frameworks/detect.d.ts +11 -0
- package/dist/frameworks/detect.d.ts.map +1 -0
- package/dist/frameworks/detect.js +29 -0
- package/dist/frameworks/detect.js.map +1 -0
- package/dist/frameworks/index.d.ts +5 -0
- package/dist/frameworks/index.d.ts.map +1 -0
- package/dist/frameworks/index.js +4 -0
- package/dist/frameworks/index.js.map +1 -0
- package/dist/frameworks/packs.d.ts +3 -0
- package/dist/frameworks/packs.d.ts.map +1 -0
- package/dist/frameworks/packs.js +146 -0
- package/dist/frameworks/packs.js.map +1 -0
- package/dist/frameworks/path-patterns.d.ts +3 -0
- package/dist/frameworks/path-patterns.d.ts.map +1 -0
- package/dist/frameworks/path-patterns.js +16 -0
- package/dist/frameworks/path-patterns.js.map +1 -0
- package/dist/frameworks/types.d.ts +15 -0
- package/dist/frameworks/types.d.ts.map +1 -0
- package/dist/frameworks/types.js +2 -0
- package/dist/frameworks/types.js.map +1 -0
- package/dist/index.d.ts +2 -0
- package/dist/index.d.ts.map +1 -1
- package/dist/index.js +2 -0
- package/dist/index.js.map +1 -1
- package/dist/intent/diff-coherence-score.d.ts +13 -0
- package/dist/intent/diff-coherence-score.d.ts.map +1 -0
- package/dist/intent/diff-coherence-score.js +125 -0
- package/dist/intent/diff-coherence-score.js.map +1 -0
- package/dist/intent/index.d.ts +2 -0
- package/dist/intent/index.d.ts.map +1 -1
- package/dist/intent/index.js +2 -0
- package/dist/intent/index.js.map +1 -1
- package/dist/intent/intent-core.d.ts.map +1 -1
- package/dist/intent/intent-core.js +17 -1
- package/dist/intent/intent-core.js.map +1 -1
- package/dist/intent/intent-model.d.ts.map +1 -1
- package/dist/intent/intent-model.js +39 -2
- package/dist/intent/intent-model.js.map +1 -1
- package/dist/intent/task-intent-quality.d.ts +4 -0
- package/dist/intent/task-intent-quality.d.ts.map +1 -0
- package/dist/intent/task-intent-quality.js +98 -0
- package/dist/intent/task-intent-quality.js.map +1 -0
- package/dist/knowledge/history-index.d.ts.map +1 -1
- package/dist/knowledge/history-index.js +10 -3
- package/dist/knowledge/history-index.js.map +1 -1
- package/dist/knowledge/index.d.ts +2 -1
- package/dist/knowledge/index.d.ts.map +1 -1
- package/dist/knowledge/index.js +1 -0
- package/dist/knowledge/index.js.map +1 -1
- package/dist/knowledge/normal-change-model.d.ts +8 -0
- package/dist/knowledge/normal-change-model.d.ts.map +1 -0
- package/dist/knowledge/normal-change-model.js +121 -0
- package/dist/knowledge/normal-change-model.js.map +1 -0
- package/dist/knowledge/solution-index.d.ts.map +1 -1
- package/dist/knowledge/solution-index.js +43 -3
- package/dist/knowledge/solution-index.js.map +1 -1
- package/dist/knowledge/types.d.ts +11 -0
- package/dist/knowledge/types.d.ts.map +1 -1
- package/dist/reporters/index.d.ts +4 -1
- package/dist/reporters/index.d.ts.map +1 -1
- package/dist/reporters/index.js +6 -0
- package/dist/reporters/index.js.map +1 -1
- package/dist/reporters/markdown-reporter.d.ts.map +1 -1
- package/dist/reporters/markdown-reporter.js +67 -0
- package/dist/reporters/markdown-reporter.js.map +1 -1
- package/dist/reporters/pr-comment-reporter.d.ts +3 -0
- package/dist/reporters/pr-comment-reporter.d.ts.map +1 -0
- package/dist/reporters/pr-comment-reporter.js +105 -0
- package/dist/reporters/pr-comment-reporter.js.map +1 -0
- package/dist/reporters/repair-contract.d.ts +3 -0
- package/dist/reporters/repair-contract.d.ts.map +1 -0
- package/dist/reporters/repair-contract.js +25 -0
- package/dist/reporters/repair-contract.js.map +1 -0
- package/dist/reporters/repair-reporter.d.ts.map +1 -1
- package/dist/reporters/repair-reporter.js +19 -1
- package/dist/reporters/repair-reporter.js.map +1 -1
- package/dist/reporters/reviewer-checklist.d.ts +10 -0
- package/dist/reporters/reviewer-checklist.d.ts.map +1 -0
- package/dist/reporters/reviewer-checklist.js +112 -0
- package/dist/reporters/reviewer-checklist.js.map +1 -0
- package/dist/repository/api-snapshot.d.ts +41 -0
- package/dist/repository/api-snapshot.d.ts.map +1 -0
- package/dist/repository/api-snapshot.js +219 -0
- package/dist/repository/api-snapshot.js.map +1 -0
- package/dist/repository/index.d.ts +2 -0
- package/dist/repository/index.d.ts.map +1 -1
- package/dist/repository/index.js +2 -0
- package/dist/repository/index.js.map +1 -1
- package/dist/repository/monorepo.d.ts +7 -0
- package/dist/repository/monorepo.d.ts.map +1 -0
- package/dist/repository/monorepo.js +189 -0
- package/dist/repository/monorepo.js.map +1 -0
- package/dist/schema/gate-result.schema.d.ts +272 -0
- package/dist/schema/gate-result.schema.d.ts.map +1 -1
- package/dist/schema/gate-result.schema.js +148 -1
- package/dist/schema/gate-result.schema.js.map +1 -1
- package/dist/schema/index.d.ts +1 -1
- package/dist/schema/index.d.ts.map +1 -1
- package/dist/schema/index.js.map +1 -1
- package/dist/schema/types.d.ts +63 -0
- package/dist/schema/types.d.ts.map +1 -1
- package/package.json +1 -1
|
@@ -0,0 +1,4 @@
|
|
|
1
|
+
import type { DiffFile, Finding, FindingRepairContract } from "../schema/index.js";
|
|
2
|
+
export declare function enrichFindingWithRepairContract(finding: Finding, files: DiffFile[]): Finding;
|
|
3
|
+
export declare function buildRepairContract(finding: Finding, files: DiffFile[]): FindingRepairContract;
|
|
4
|
+
//# sourceMappingURL=repair-contract.d.ts.map
|
|
@@ -0,0 +1 @@
|
|
|
1
|
+
{"version":3,"file":"repair-contract.d.ts","sourceRoot":"","sources":["../../src/detectors/repair-contract.ts"],"names":[],"mappings":"AAAA,OAAO,KAAK,EAAE,QAAQ,EAAE,OAAO,EAAE,qBAAqB,EAAE,MAAM,oBAAoB,CAAC;AAInF,wBAAgB,+BAA+B,CAAC,OAAO,EAAE,OAAO,EAAE,KAAK,EAAE,QAAQ,EAAE,GAAG,OAAO,CAK5F;AAED,wBAAgB,mBAAmB,CAAC,OAAO,EAAE,OAAO,EAAE,KAAK,EAAE,QAAQ,EAAE,GAAG,qBAAqB,CAsB9F"}
|
|
@@ -0,0 +1,45 @@
|
|
|
1
|
+
const maxListedFiles = 8;
|
|
2
|
+
export function enrichFindingWithRepairContract(finding, files) {
|
|
3
|
+
return {
|
|
4
|
+
...finding,
|
|
5
|
+
repairContract: buildRepairContract(finding, files)
|
|
6
|
+
};
|
|
7
|
+
}
|
|
8
|
+
export function buildRepairContract(finding, files) {
|
|
9
|
+
const evidenceFiles = getEvidenceFiles(finding);
|
|
10
|
+
const allowedFiles = evidenceFiles.length > 0 ? evidenceFiles : files.map((file) => file.path);
|
|
11
|
+
const changedFiles = files.map((file) => file.path);
|
|
12
|
+
const forbiddenFiles = changedFiles
|
|
13
|
+
.filter((path) => !allowedFiles.includes(path))
|
|
14
|
+
.slice(0, maxListedFiles);
|
|
15
|
+
return {
|
|
16
|
+
instructions: [
|
|
17
|
+
finding.repair,
|
|
18
|
+
"Keep the repair limited to the allowed files unless the task intent explicitly requires more.",
|
|
19
|
+
"Do not broaden scope, add dependencies, weaken tests, or rewrite unrelated code while repairing this finding."
|
|
20
|
+
],
|
|
21
|
+
allowedFiles: allowedFiles.slice(0, maxListedFiles),
|
|
22
|
+
forbiddenFiles,
|
|
23
|
+
successCriteria: [
|
|
24
|
+
`The finding ${finding.id} no longer appears after rerunning Critical Gate.`,
|
|
25
|
+
"The original task intent is still satisfied.",
|
|
26
|
+
"No new blocker or high-severity Critical Gate finding is introduced."
|
|
27
|
+
]
|
|
28
|
+
};
|
|
29
|
+
}
|
|
30
|
+
function getEvidenceFiles(finding) {
|
|
31
|
+
const paths = new Set();
|
|
32
|
+
for (const evidence of finding.evidence) {
|
|
33
|
+
if (evidence.path !== undefined) {
|
|
34
|
+
paths.add(evidence.path);
|
|
35
|
+
}
|
|
36
|
+
for (const key of ["expectedPath", "existingPath", "changedPath"]) {
|
|
37
|
+
const value = evidence.data?.[key];
|
|
38
|
+
if (typeof value === "string" && value.length > 0) {
|
|
39
|
+
paths.add(value);
|
|
40
|
+
}
|
|
41
|
+
}
|
|
42
|
+
}
|
|
43
|
+
return [...paths];
|
|
44
|
+
}
|
|
45
|
+
//# sourceMappingURL=repair-contract.js.map
|
|
@@ -0,0 +1 @@
|
|
|
1
|
+
{"version":3,"file":"repair-contract.js","sourceRoot":"","sources":["../../src/detectors/repair-contract.ts"],"names":[],"mappings":"AAEA,MAAM,cAAc,GAAG,CAAC,CAAC;AAEzB,MAAM,UAAU,+BAA+B,CAAC,OAAgB,EAAE,KAAiB;IACjF,OAAO;QACL,GAAG,OAAO;QACV,cAAc,EAAE,mBAAmB,CAAC,OAAO,EAAE,KAAK,CAAC;KACpD,CAAC;AACJ,CAAC;AAED,MAAM,UAAU,mBAAmB,CAAC,OAAgB,EAAE,KAAiB;IACrE,MAAM,aAAa,GAAG,gBAAgB,CAAC,OAAO,CAAC,CAAC;IAChD,MAAM,YAAY,GAAG,aAAa,CAAC,MAAM,GAAG,CAAC,CAAC,CAAC,CAAC,aAAa,CAAC,CAAC,CAAC,KAAK,CAAC,GAAG,CAAC,CAAC,IAAI,EAAE,EAAE,CAAC,IAAI,CAAC,IAAI,CAAC,CAAC;IAC/F,MAAM,YAAY,GAAG,KAAK,CAAC,GAAG,CAAC,CAAC,IAAI,EAAE,EAAE,CAAC,IAAI,CAAC,IAAI,CAAC,CAAC;IACpD,MAAM,cAAc,GAAG,YAAY;SAChC,MAAM,CAAC,CAAC,IAAI,EAAE,EAAE,CAAC,CAAC,YAAY,CAAC,QAAQ,CAAC,IAAI,CAAC,CAAC;SAC9C,KAAK,CAAC,CAAC,EAAE,cAAc,CAAC,CAAC;IAE5B,OAAO;QACL,YAAY,EAAE;YACZ,OAAO,CAAC,MAAM;YACd,+FAA+F;YAC/F,+GAA+G;SAChH;QACD,YAAY,EAAE,YAAY,CAAC,KAAK,CAAC,CAAC,EAAE,cAAc,CAAC;QACnD,cAAc;QACd,eAAe,EAAE;YACf,eAAe,OAAO,CAAC,EAAE,mDAAmD;YAC5E,8CAA8C;YAC9C,sEAAsE;SACvE;KACF,CAAC;AACJ,CAAC;AAED,SAAS,gBAAgB,CAAC,OAAgB;IACxC,MAAM,KAAK,GAAG,IAAI,GAAG,EAAU,CAAC;IAEhC,KAAK,MAAM,QAAQ,IAAI,OAAO,CAAC,QAAQ,EAAE,CAAC;QACxC,IAAI,QAAQ,CAAC,IAAI,KAAK,SAAS,EAAE,CAAC;YAChC,KAAK,CAAC,GAAG,CAAC,QAAQ,CAAC,IAAI,CAAC,CAAC;QAC3B,CAAC;QAED,KAAK,MAAM,GAAG,IAAI,CAAC,cAAc,EAAE,cAAc,EAAE,aAAa,CAAC,EAAE,CAAC;YAClE,MAAM,KAAK,GAAG,QAAQ,CAAC,IAAI,EAAE,CAAC,GAAG,CAAC,CAAC;YAEnC,IAAI,OAAO,KAAK,KAAK,QAAQ,IAAI,KAAK,CAAC,MAAM,GAAG,CAAC,EAAE,CAAC;gBAClD,KAAK,CAAC,GAAG,CAAC,KAAK,CAAC,CAAC;YACnB,CAAC;QACH,CAAC;IACH,CAAC;IAED,OAAO,CAAC,GAAG,KAAK,CAAC,CAAC;AACpB,CAAC"}
|
|
@@ -1 +1 @@
|
|
|
1
|
-
{"version":3,"file":"repository-intelligence-detector.d.ts","sourceRoot":"","sources":["../../src/detectors/repository-intelligence-detector.ts"],"names":[],"mappings":"
|
|
1
|
+
{"version":3,"file":"repository-intelligence-detector.d.ts","sourceRoot":"","sources":["../../src/detectors/repository-intelligence-detector.ts"],"names":[],"mappings":"AAGA,OAAO,KAAK,EAAE,QAAQ,EAAE,MAAM,YAAY,CAAC;AAE3C,eAAO,MAAM,8BAA8B,EAAE,QAoB5C,CAAC"}
|
|
@@ -1,7 +1,8 @@
|
|
|
1
1
|
export const repositoryIntelligenceDetector = {
|
|
2
2
|
name: "repository-intelligence",
|
|
3
3
|
run: ({ diff, context }) => {
|
|
4
|
-
const
|
|
4
|
+
const history = context?.knowledge?.getHistoryIndex();
|
|
5
|
+
const profile = context?.repositoryProfile ?? history?.profile;
|
|
5
6
|
if (profile === undefined || profile.commitCount < profile.minConfidenceCommitCount) {
|
|
6
7
|
return [];
|
|
7
8
|
}
|
|
@@ -11,7 +12,7 @@ export const repositoryIntelligenceDetector = {
|
|
|
11
12
|
}
|
|
12
13
|
return diff.files
|
|
13
14
|
.filter((file) => isHistoricallyUnrelated(file, changedPaths, profile))
|
|
14
|
-
.map((file) => toFinding(file, changedPaths, profile));
|
|
15
|
+
.map((file) => toFinding(file, changedPaths, profile, history));
|
|
15
16
|
}
|
|
16
17
|
};
|
|
17
18
|
function isHistoricallyUnrelated(file, changedPaths, profile) {
|
|
@@ -22,9 +23,10 @@ function isHistoricallyUnrelated(file, changedPaths, profile) {
|
|
|
22
23
|
const relatedChangedPaths = coChange.relatedPaths.filter((related) => changedPaths.includes(related.path));
|
|
23
24
|
return relatedChangedPaths.length === 0;
|
|
24
25
|
}
|
|
25
|
-
function toFinding(file, changedPaths, profile) {
|
|
26
|
+
function toFinding(file, changedPaths, profile, history) {
|
|
26
27
|
const coChange = profile.coChanges.find((entry) => entry.path === file.path);
|
|
27
28
|
const topRelated = coChange?.relatedPaths.slice(0, 3).map((related) => related.path) ?? [];
|
|
29
|
+
const normalPatterns = getNormalPatternsForPath(file.path, history?.normalPatterns ?? []);
|
|
28
30
|
return {
|
|
29
31
|
id: `repository-intelligence:${file.path}`,
|
|
30
32
|
detector: "repository-intelligence",
|
|
@@ -40,7 +42,13 @@ function toFinding(file, changedPaths, profile) {
|
|
|
40
42
|
data: {
|
|
41
43
|
commitCount: profile.commitCount,
|
|
42
44
|
fileChangeCount: coChange?.count ?? 0,
|
|
43
|
-
historicallyRelatedPaths: topRelated
|
|
45
|
+
historicallyRelatedPaths: topRelated,
|
|
46
|
+
normalPatterns: normalPatterns.map((pattern) => ({
|
|
47
|
+
kind: pattern.kind,
|
|
48
|
+
relatedPath: pattern.relatedPath,
|
|
49
|
+
support: pattern.support,
|
|
50
|
+
confidence: pattern.confidence
|
|
51
|
+
}))
|
|
44
52
|
}
|
|
45
53
|
}
|
|
46
54
|
],
|
|
@@ -48,4 +56,9 @@ function toFinding(file, changedPaths, profile) {
|
|
|
48
56
|
tags: ["scope"]
|
|
49
57
|
};
|
|
50
58
|
}
|
|
59
|
+
function getNormalPatternsForPath(path, normalPatterns) {
|
|
60
|
+
return normalPatterns
|
|
61
|
+
.filter((pattern) => pattern.sourcePath === path || pattern.relatedPath === path)
|
|
62
|
+
.slice(0, 5);
|
|
63
|
+
}
|
|
51
64
|
//# sourceMappingURL=repository-intelligence-detector.js.map
|
|
@@ -1 +1 @@
|
|
|
1
|
-
{"version":3,"file":"repository-intelligence-detector.js","sourceRoot":"","sources":["../../src/detectors/repository-intelligence-detector.ts"],"names":[],"mappings":"
|
|
1
|
+
{"version":3,"file":"repository-intelligence-detector.js","sourceRoot":"","sources":["../../src/detectors/repository-intelligence-detector.ts"],"names":[],"mappings":"AAKA,MAAM,CAAC,MAAM,8BAA8B,GAAa;IACtD,IAAI,EAAE,yBAAyB;IAC/B,GAAG,EAAE,CAAC,EAAE,IAAI,EAAE,OAAO,EAAE,EAAE,EAAE;QACzB,MAAM,OAAO,GAAG,OAAO,EAAE,SAAS,EAAE,eAAe,EAAE,CAAC;QACtD,MAAM,OAAO,GAAG,OAAO,EAAE,iBAAiB,IAAI,OAAO,EAAE,OAAO,CAAC;QAE/D,IAAI,OAAO,KAAK,SAAS,IAAI,OAAO,CAAC,WAAW,GAAG,OAAO,CAAC,wBAAwB,EAAE,CAAC;YACpF,OAAO,EAAE,CAAC;QACZ,CAAC;QAED,MAAM,YAAY,GAAG,IAAI,CAAC,KAAK,CAAC,GAAG,CAAC,CAAC,IAAI,EAAE,EAAE,CAAC,IAAI,CAAC,IAAI,CAAC,CAAC;QAEzD,IAAI,YAAY,CAAC,MAAM,GAAG,CAAC,EAAE,CAAC;YAC5B,OAAO,EAAE,CAAC;QACZ,CAAC;QAED,OAAO,IAAI,CAAC,KAAK;aACd,MAAM,CAAC,CAAC,IAAI,EAAE,EAAE,CAAC,uBAAuB,CAAC,IAAI,EAAE,YAAY,EAAE,OAAO,CAAC,CAAC;aACtE,GAAG,CAAC,CAAC,IAAI,EAAE,EAAE,CAAC,SAAS,CAAC,IAAI,EAAE,YAAY,EAAE,OAAO,EAAE,OAAO,CAAC,CAAC,CAAC;IACpE,CAAC;CACF,CAAC;AAEF,SAAS,uBAAuB,CAC9B,IAAc,EACd,YAAsB,EACtB,OAA0B;IAE1B,MAAM,QAAQ,GAAG,OAAO,CAAC,SAAS,CAAC,IAAI,CAAC,CAAC,KAAK,EAAE,EAAE,CAAC,KAAK,CAAC,IAAI,KAAK,IAAI,CAAC,IAAI,CAAC,CAAC;IAE7E,IAAI,QAAQ,KAAK,SAAS,IAAI,QAAQ,CAAC,KAAK,KAAK,CAAC,EAAE,CAAC;QACnD,OAAO,KAAK,CAAC;IACf,CAAC;IAED,MAAM,mBAAmB,GAAG,QAAQ,CAAC,YAAY,CAAC,MAAM,CAAC,CAAC,OAAO,EAAE,EAAE,CACnE,YAAY,CAAC,QAAQ,CAAC,OAAO,CAAC,IAAI,CAAC,CACpC,CAAC;IAEF,OAAO,mBAAmB,CAAC,MAAM,KAAK,CAAC,CAAC;AAC1C,CAAC;AAED,SAAS,SAAS,CAChB,IAAc,EACd,YAAsB,EACtB,OAA0B,EAC1B,OAAiC;IAEjC,MAAM,QAAQ,GAAG,OAAO,CAAC,SAAS,CAAC,IAAI,CAAC,CAAC,KAAK,EAAE,EAAE,CAAC,KAAK,CAAC,IAAI,KAAK,IAAI,CAAC,IAAI,CAAC,CAAC;IAC7E,MAAM,UAAU,GAAG,QAAQ,EAAE,YAAY,CAAC,KAAK,CAAC,CAAC,EAAE,CAAC,CAAC,CAAC,GAAG,CAAC,CAAC,OAAO,EAAE,EAAE,CAAC,OAAO,CAAC,IAAI,CAAC,IAAI,EAAE,CAAC;IAC3F,MAAM,cAAc,GAAG,wBAAwB,CAAC,IAAI,CAAC,IAAI,EAAE,OAAO,EAAE,cAAc,IAAI,EAAE,CAAC,CAAC;IAE1F,OAAO;QACL,EAAE,EAAE,2BAA2B,IAAI,CAAC,IAAI,EAAE;QAC1C,QAAQ,EAAE,yBAAyB;QACnC,QAAQ,EAAE,QAAQ;QAClB,UAAU,EAAE,IAAI;QAChB,KAAK,EAAE,mCAAmC;QAC1C,OAAO,EAAE,GAAG,IAAI,CAAC,IAAI,8EAA8E;QACnG,QAAQ,EAAE;YACR;gBACE,IAAI,EAAE,SAAS;gBACf,IAAI,EAAE,IAAI,CAAC,IAAI;gBACf,OAAO,EAAE,wCAAwC,YAAY,CAAC,IAAI,CAAC,IAAI,CAAC,GAAG;gBAC3E,IAAI,EAAE;oBACJ,WAAW,EAAE,OAAO,CAAC,WAAW;oBAChC,eAAe,EAAE,QAAQ,EAAE,KAAK,IAAI,CAAC;oBACrC,wBAAwB,EAAE,UAAU;oBACpC,cAAc,EAAE,cAAc,CAAC,GAAG,CAAC,CAAC,OAAO,EAAE,EAAE,CAAC,CAAC;wBAC/C,IAAI,EAAE,OAAO,CAAC,IAAI;wBAClB,WAAW,EAAE,OAAO,CAAC,WAAW;wBAChC,OAAO,EAAE,OAAO,CAAC,OAAO;wBACxB,UAAU,EAAE,OAAO,CAAC,UAAU;qBAC/B,CAAC,CAAC;iBACJ;aACF;SACF;QACD,MAAM,EACJ,4GAA4G;QAC9G,IAAI,EAAE,CAAC,OAAO,CAAC;KAChB,CAAC;AACJ,CAAC;AAED,SAAS,wBAAwB,CAC/B,IAAY,EACZ,cAAqC;IAErC,OAAO,cAAc;SAClB,MAAM,CAAC,CAAC,OAAO,EAAE,EAAE,CAAC,OAAO,CAAC,UAAU,KAAK,IAAI,IAAI,OAAO,CAAC,WAAW,KAAK,IAAI,CAAC;SAChF,KAAK,CAAC,CAAC,EAAE,CAAC,CAAC,CAAC;AACjB,CAAC"}
|
|
@@ -1 +1 @@
|
|
|
1
|
-
{"version":3,"file":"rewrite-detector.d.ts","sourceRoot":"","sources":["../../src/detectors/rewrite-detector.ts"],"names":[],"mappings":"AAGA,OAAO,KAAK,EAAE,QAAQ,EAAE,MAAM,YAAY,CAAC;AAM3C,eAAO,MAAM,eAAe,EAAE,
|
|
1
|
+
{"version":3,"file":"rewrite-detector.d.ts","sourceRoot":"","sources":["../../src/detectors/rewrite-detector.ts"],"names":[],"mappings":"AAGA,OAAO,KAAK,EAAE,QAAQ,EAAE,MAAM,YAAY,CAAC;AAM3C,eAAO,MAAM,eAAe,EAAE,QAkB7B,CAAC"}
|
|
@@ -1,4 +1,4 @@
|
|
|
1
|
-
import { analyzeTaskIntent } from "../intent/index.js";
|
|
1
|
+
import { analyzeTaskIntent, getTaskIntentQualityWarnings } from "../intent/index.js";
|
|
2
2
|
const minimumRewriteChurn = 80;
|
|
3
3
|
const minimumBalancedSide = 30;
|
|
4
4
|
const minimumBalanceRatio = 0.55;
|
|
@@ -11,9 +11,12 @@ export const rewriteDetector = {
|
|
|
11
11
|
}
|
|
12
12
|
return diff.files
|
|
13
13
|
.filter(isRewriteCandidate)
|
|
14
|
-
.map((file) => toFinding(file, analysis.complexity === "small" ? "high" : "medium"));
|
|
14
|
+
.map((file) => toFinding(file, analysis.complexity === "small" || hasWeakIntentBoundary(task) ? "high" : "medium"));
|
|
15
15
|
}
|
|
16
16
|
};
|
|
17
|
+
function hasWeakIntentBoundary(task) {
|
|
18
|
+
return getTaskIntentQualityWarnings(task).some((warning) => warning.code === "vague-task" || warning.code === "generic-only");
|
|
19
|
+
}
|
|
17
20
|
function isRewriteCandidate(file) {
|
|
18
21
|
if (file.role !== "source" || file.status === "added" || file.status === "deleted") {
|
|
19
22
|
return false;
|
|
@@ -1 +1 @@
|
|
|
1
|
-
{"version":3,"file":"rewrite-detector.js","sourceRoot":"","sources":["../../src/detectors/rewrite-detector.ts"],"names":[],"mappings":"AAAA,OAAO,EAAE,iBAAiB,EAAE,MAAM,oBAAoB,CAAC;
|
|
1
|
+
{"version":3,"file":"rewrite-detector.js","sourceRoot":"","sources":["../../src/detectors/rewrite-detector.ts"],"names":[],"mappings":"AAAA,OAAO,EAAE,iBAAiB,EAAE,4BAA4B,EAAE,MAAM,oBAAoB,CAAC;AAKrF,MAAM,mBAAmB,GAAG,EAAE,CAAC;AAC/B,MAAM,mBAAmB,GAAG,EAAE,CAAC;AAC/B,MAAM,mBAAmB,GAAG,IAAI,CAAC;AAEjC,MAAM,CAAC,MAAM,eAAe,GAAa;IACvC,IAAI,EAAE,SAAS;IACf,GAAG,EAAE,CAAC,EAAE,IAAI,EAAE,IAAI,EAAE,EAAE,EAAE;QACtB,MAAM,QAAQ,GAAG,iBAAiB,CAAC,IAAI,CAAC,CAAC;QAEzC,IAAI,QAAQ,CAAC,UAAU,KAAK,OAAO,EAAE,CAAC;YACpC,OAAO,EAAE,CAAC;QACZ,CAAC;QAED,OAAO,IAAI,CAAC,KAAK;aACd,MAAM,CAAC,kBAAkB,CAAC;aAC1B,GAAG,CAAC,CAAC,IAAI,EAAE,EAAE,CACZ,SAAS,CACP,IAAI,EACJ,QAAQ,CAAC,UAAU,KAAK,OAAO,IAAI,qBAAqB,CAAC,IAAI,CAAC,CAAC,CAAC,CAAC,MAAM,CAAC,CAAC,CAAC,QAAQ,CACnF,CACF,CAAC;IACN,CAAC;CACF,CAAC;AAEF,SAAS,qBAAqB,CAAC,IAA4C;IACzE,OAAO,4BAA4B,CAAC,IAAI,CAAC,CAAC,IAAI,CAC5C,CAAC,OAAO,EAAE,EAAE,CAAC,OAAO,CAAC,IAAI,KAAK,YAAY,IAAI,OAAO,CAAC,IAAI,KAAK,cAAc,CAC9E,CAAC;AACJ,CAAC;AAED,SAAS,kBAAkB,CAAC,IAAc;IACxC,IAAI,IAAI,CAAC,IAAI,KAAK,QAAQ,IAAI,IAAI,CAAC,MAAM,KAAK,OAAO,IAAI,IAAI,CAAC,MAAM,KAAK,SAAS,EAAE,CAAC;QACnF,OAAO,KAAK,CAAC;IACf,CAAC;IAED,MAAM,WAAW,GAAG,IAAI,CAAC,GAAG,CAAC,IAAI,CAAC,SAAS,EAAE,IAAI,CAAC,SAAS,CAAC,CAAC;IAC7D,MAAM,UAAU,GAAG,IAAI,CAAC,GAAG,CAAC,IAAI,CAAC,SAAS,EAAE,IAAI,CAAC,SAAS,CAAC,CAAC;IAC5D,MAAM,KAAK,GAAG,IAAI,CAAC,SAAS,GAAG,IAAI,CAAC,SAAS,CAAC;IAE9C,OAAO,CACL,KAAK,IAAI,mBAAmB;QAC5B,WAAW,IAAI,mBAAmB;QAClC,WAAW,GAAG,UAAU,IAAI,mBAAmB,CAChD,CAAC;AACJ,CAAC;AAED,SAAS,SAAS,CAAC,IAAc,EAAE,QAAyB;IAC1D,MAAM,gBAAgB,GAAG,IAAI,CAAC,KAAK;SAChC,OAAO,CAAC,CAAC,IAAI,EAAE,EAAE,CAAC,IAAI,CAAC,KAAK,CAAC;SAC7B,IAAI,CAAC,CAAC,IAAI,EAAE,EAAE,CAAC,IAAI,CAAC,IAAI,KAAK,KAAK,IAAI,IAAI,CAAC,IAAI,KAAK,QAAQ,CAAC,CAAC;IACjE,MAAM,UAAU,GAAG,gBAAgB,EAAE,aAAa,IAAI,gBAAgB,EAAE,aAAa,CAAC;IACtF,MAAM,KAAK,GAAG,IAAI,CAAC,SAAS,GAAG,IAAI,CAAC,SAAS,CAAC;IAC9C,MAAM,YAAY,GAAG,IAAI,CAAC,KAAK,CAC7B,CAAC,IAAI,CAAC,GAAG,CAAC,IAAI,CAAC,SAAS,EAAE,IAAI,CAAC,SAAS,CAAC,GAAG,IAAI,CAAC,GAAG,CAAC,IAAI,CAAC,SAAS,EAAE,IAAI,CAAC,SAAS,CAAC,CAAC,GAAG,GAAG,CAC5F,CAAC;IAEF,OAAO;QACL,EAAE,EAAE,WAAW,IAAI,CAAC,IAAI,EAAE;QAC1B,QAAQ,EAAE,SAAS;QACnB,QAAQ;QACR,UAAU,EAAE,QAAQ,KAAK,MAAM,CAAC,CAAC,CAAC,IAAI,CAAC,CAAC,CAAC,IAAI;QAC7C,KAAK,EAAE,iCAAiC;QACxC,OAAO,EAAE,GAAG,IAAI,CAAC,IAAI,QAAQ,KAAK,mFAAmF;QACrH,QAAQ,EAAE;YACR;gBACE,IAAI,EAAE,QAAQ;gBACd,IAAI,EAAE,IAAI,CAAC,IAAI;gBACf,SAAS,EAAE,UAAU;gBACrB,OAAO,EAAE,UAAU;gBACnB,OAAO,EAAE,cAAc,IAAI,CAAC,SAAS,gBAAgB,IAAI,CAAC,SAAS,sBAAsB,YAAY,IAAI;gBACzG,IAAI,EAAE;oBACJ,SAAS,EAAE,IAAI,CAAC,SAAS;oBACzB,SAAS,EAAE,IAAI,CAAC,SAAS;oBACzB,KAAK;oBACL,YAAY;iBACb;aACF;SACF;QACD,MAAM,EACJ,uHAAuH;QACzH,IAAI,EAAE,CAAC,SAAS,CAAC;KAClB,CAAC;AACJ,CAAC"}
|
|
@@ -3,6 +3,7 @@ import type { Detector, DetectorRepoContext } from "./types.js";
|
|
|
3
3
|
export interface FindingDecisionPolicy {
|
|
4
4
|
observationDetectors?: string[];
|
|
5
5
|
blockingDetectors?: string[];
|
|
6
|
+
failOn?: "blocker" | "high" | "medium";
|
|
6
7
|
}
|
|
7
8
|
export declare function runDetectors(task: TaskIntent, diff: GateResult["diff"], context?: DetectorRepoContext, detectors?: Detector[]): Finding[];
|
|
8
9
|
export declare function summarizeFindings(findings: Finding[], task?: TaskIntent, diff?: GateResult["diff"], policy?: FindingDecisionPolicy): GateResult["summary"];
|
|
@@ -1 +1 @@
|
|
|
1
|
-
{"version":3,"file":"runner.d.ts","sourceRoot":"","sources":["../../src/detectors/runner.ts"],"names":[],"mappings":"AAAA,OAAO,KAAK,EAAE,OAAO,EAAE,UAAU,EAAE,UAAU,EAAE,MAAM,oBAAoB,CAAC;
|
|
1
|
+
{"version":3,"file":"runner.d.ts","sourceRoot":"","sources":["../../src/detectors/runner.ts"],"names":[],"mappings":"AAAA,OAAO,KAAK,EAAE,OAAO,EAAE,UAAU,EAAE,UAAU,EAAE,MAAM,oBAAoB,CAAC;AAwB1E,OAAO,KAAK,EAAE,QAAQ,EAAE,mBAAmB,EAAE,MAAM,YAAY,CAAC;AAEhE,MAAM,WAAW,qBAAqB;IACpC,oBAAoB,CAAC,EAAE,MAAM,EAAE,CAAC;IAChC,iBAAiB,CAAC,EAAE,MAAM,EAAE,CAAC;IAC7B,MAAM,CAAC,EAAE,SAAS,GAAG,MAAM,GAAG,QAAQ,CAAC;CACxC;AA2BD,wBAAgB,YAAY,CAC1B,IAAI,EAAE,UAAU,EAChB,IAAI,EAAE,UAAU,CAAC,MAAM,CAAC,EACxB,OAAO,CAAC,EAAE,mBAAmB,EAC7B,SAAS,aAAmB,GAC3B,OAAO,EAAE,CAIX;AAED,wBAAgB,iBAAiB,CAC/B,QAAQ,EAAE,OAAO,EAAE,EACnB,IAAI,CAAC,EAAE,UAAU,EACjB,IAAI,CAAC,EAAE,UAAU,CAAC,MAAM,CAAC,EACzB,MAAM,GAAE,qBAA0B,GACjC,UAAU,CAAC,SAAS,CAAC,CAyBvB"}
|
package/dist/detectors/runner.js
CHANGED
|
@@ -1,6 +1,7 @@
|
|
|
1
|
-
import { calculateDiffCostScore, calculateScopeExpansionScore } from "../intent/index.js";
|
|
1
|
+
import { calculateDiffCoherenceScore, calculateDiffCostScore, calculateScopeExpansionScore } from "../intent/index.js";
|
|
2
2
|
import { apiSurfaceDetector } from "./api-surface-detector.js";
|
|
3
3
|
import { blastRadiusDetector } from "./blast-radius-detector.js";
|
|
4
|
+
import { calibrateFindingConfidence } from "./confidence-calibration.js";
|
|
4
5
|
import { configChangeDetector } from "./config-change-detector.js";
|
|
5
6
|
import { dependencyDetector } from "./dependency-detector.js";
|
|
6
7
|
import { existingSolutionDetector } from "./existing-solution-detector.js";
|
|
@@ -9,6 +10,8 @@ import { intentVerificationDetector } from "./intent-verification-detector.js";
|
|
|
9
10
|
import { patternViolationDetector } from "./pattern-violation-detector.js";
|
|
10
11
|
import { rewriteDetector } from "./rewrite-detector.js";
|
|
11
12
|
import { repositoryIntelligenceDetector } from "./repository-intelligence-detector.js";
|
|
13
|
+
import { enrichFindingWithReasonChain } from "./reason-chain.js";
|
|
14
|
+
import { enrichFindingWithRepairContract } from "./repair-contract.js";
|
|
12
15
|
import { secretPathDetector } from "./secret-path-detector.js";
|
|
13
16
|
import { scopeDetector } from "./scope-detector.js";
|
|
14
17
|
import { testWeakeningDetector } from "./test-weakening-detector.js";
|
|
@@ -37,7 +40,9 @@ const defaultDetectors = [
|
|
|
37
40
|
patternViolationDetector
|
|
38
41
|
];
|
|
39
42
|
export function runDetectors(task, diff, context, detectors = defaultDetectors) {
|
|
40
|
-
return dedupeFindings(detectors.flatMap((detector) => detector.run({ task, diff, context })))
|
|
43
|
+
return dedupeFindings(detectors.flatMap((detector) => detector.run({ task, diff, context })))
|
|
44
|
+
.map(enrichFindingWithReasonChain)
|
|
45
|
+
.map((finding) => enrichFindingWithRepairContract(finding, diff.files));
|
|
41
46
|
}
|
|
42
47
|
export function summarizeFindings(findings, task, diff, policy = {}) {
|
|
43
48
|
const blockerCount = countSeverity(findings, "blocker");
|
|
@@ -51,14 +56,30 @@ export function summarizeFindings(findings, task, diff, policy = {}) {
|
|
|
51
56
|
mediumCount: countSeverity(findings, "medium"),
|
|
52
57
|
lowCount: countSeverity(findings, "low"),
|
|
53
58
|
infoCount: countSeverity(findings, "info"),
|
|
59
|
+
confidenceCalibration: summarizeConfidenceCalibration(findings, policy),
|
|
54
60
|
diffCostScore: task !== undefined && diff !== undefined ? calculateDiffCostScore(task, diff.files) : 0,
|
|
55
61
|
scopeExpansionScore: task !== undefined && diff !== undefined
|
|
56
62
|
? calculateScopeExpansionScore(task, diff.files, findings)
|
|
63
|
+
: undefined,
|
|
64
|
+
diffCoherenceScore: task !== undefined && diff !== undefined
|
|
65
|
+
? calculateDiffCoherenceScore(task, diff.files, findings)
|
|
57
66
|
: undefined
|
|
58
67
|
};
|
|
59
68
|
}
|
|
69
|
+
function summarizeConfidenceCalibration(findings, policy) {
|
|
70
|
+
return {
|
|
71
|
+
blockingEligibleCount: findings.filter((finding) => isBlockingFinding(finding, policy)).length,
|
|
72
|
+
observationModeCount: findings.filter((finding) => isObservationModeFinding(finding, policy))
|
|
73
|
+
.length,
|
|
74
|
+
confidenceSuppressedCount: findings.filter(isConfidenceSuppressedFinding).length
|
|
75
|
+
};
|
|
76
|
+
}
|
|
60
77
|
function isBlockingFinding(finding, policy) {
|
|
61
|
-
if (finding
|
|
78
|
+
if (!meetsFailSeverity(finding, policy.failOn ?? "high")) {
|
|
79
|
+
return false;
|
|
80
|
+
}
|
|
81
|
+
const calibration = calibrateFindingConfidence(finding);
|
|
82
|
+
if (!calibration.blockingEligible) {
|
|
62
83
|
return false;
|
|
63
84
|
}
|
|
64
85
|
if (policy.blockingDetectors?.includes(finding.detector) === true) {
|
|
@@ -67,6 +88,32 @@ function isBlockingFinding(finding, policy) {
|
|
|
67
88
|
const observationDetectors = policy.observationDetectors ?? defaultObservationDetectors;
|
|
68
89
|
return !observationDetectors.includes(finding.detector);
|
|
69
90
|
}
|
|
91
|
+
function isObservationModeFinding(finding, policy) {
|
|
92
|
+
if (!meetsFailSeverity(finding, policy.failOn ?? "high")) {
|
|
93
|
+
return false;
|
|
94
|
+
}
|
|
95
|
+
if (!calibrateFindingConfidence(finding).blockingEligible) {
|
|
96
|
+
return false;
|
|
97
|
+
}
|
|
98
|
+
if (policy.blockingDetectors?.includes(finding.detector) === true) {
|
|
99
|
+
return false;
|
|
100
|
+
}
|
|
101
|
+
const observationDetectors = policy.observationDetectors ?? defaultObservationDetectors;
|
|
102
|
+
return observationDetectors.includes(finding.detector);
|
|
103
|
+
}
|
|
104
|
+
function meetsFailSeverity(finding, failOn) {
|
|
105
|
+
if (failOn === "blocker") {
|
|
106
|
+
return finding.severity === "blocker";
|
|
107
|
+
}
|
|
108
|
+
if (failOn === "medium") {
|
|
109
|
+
return (finding.severity === "blocker" || finding.severity === "high" || finding.severity === "medium");
|
|
110
|
+
}
|
|
111
|
+
return finding.severity === "blocker" || finding.severity === "high";
|
|
112
|
+
}
|
|
113
|
+
function isConfidenceSuppressedFinding(finding) {
|
|
114
|
+
return ((finding.severity === "blocker" || finding.severity === "high") &&
|
|
115
|
+
!calibrateFindingConfidence(finding).blockingEligible);
|
|
116
|
+
}
|
|
70
117
|
function countSeverity(findings, severity) {
|
|
71
118
|
return findings.filter((finding) => finding.severity === severity).length;
|
|
72
119
|
}
|
|
@@ -1 +1 @@
|
|
|
1
|
-
{"version":3,"file":"runner.js","sourceRoot":"","sources":["../../src/detectors/runner.ts"],"names":[],"mappings":"AAEA,OAAO,
|
|
1
|
+
{"version":3,"file":"runner.js","sourceRoot":"","sources":["../../src/detectors/runner.ts"],"names":[],"mappings":"AAEA,OAAO,EACL,2BAA2B,EAC3B,sBAAsB,EACtB,4BAA4B,EAC7B,MAAM,oBAAoB,CAAC;AAC5B,OAAO,EAAE,kBAAkB,EAAE,MAAM,2BAA2B,CAAC;AAC/D,OAAO,EAAE,mBAAmB,EAAE,MAAM,4BAA4B,CAAC;AACjE,OAAO,EAAE,0BAA0B,EAAE,MAAM,6BAA6B,CAAC;AACzE,OAAO,EAAE,oBAAoB,EAAE,MAAM,6BAA6B,CAAC;AACnE,OAAO,EAAE,kBAAkB,EAAE,MAAM,0BAA0B,CAAC;AAC9D,OAAO,EAAE,wBAAwB,EAAE,MAAM,iCAAiC,CAAC;AAC3E,OAAO,EAAE,0BAA0B,EAAE,MAAM,mCAAmC,CAAC;AAC/E,OAAO,EAAE,0BAA0B,EAAE,MAAM,mCAAmC,CAAC;AAC/E,OAAO,EAAE,wBAAwB,EAAE,MAAM,iCAAiC,CAAC;AAC3E,OAAO,EAAE,eAAe,EAAE,MAAM,uBAAuB,CAAC;AACxD,OAAO,EAAE,8BAA8B,EAAE,MAAM,uCAAuC,CAAC;AACvF,OAAO,EAAE,4BAA4B,EAAE,MAAM,mBAAmB,CAAC;AACjE,OAAO,EAAE,+BAA+B,EAAE,MAAM,sBAAsB,CAAC;AACvE,OAAO,EAAE,kBAAkB,EAAE,MAAM,2BAA2B,CAAC;AAC/D,OAAO,EAAE,aAAa,EAAE,MAAM,qBAAqB,CAAC;AACpD,OAAO,EAAE,qBAAqB,EAAE,MAAM,8BAA8B,CAAC;AACrE,OAAO,EAAE,0BAA0B,EAAE,MAAM,mCAAmC,CAAC;AAS/E,MAAM,2BAA2B,GAAG;IAClC,qBAAqB;IACrB,cAAc;IACd,mBAAmB;IACnB,mBAAmB;IACnB,qBAAqB;CACtB,CAAC;AAEF,MAAM,gBAAgB,GAAe;IACnC,kBAAkB;IAClB,qBAAqB;IACrB,oBAAoB;IACpB,kBAAkB;IAClB,kBAAkB;IAClB,0BAA0B;IAC1B,mBAAmB;IACnB,aAAa;IACb,eAAe;IACf,8BAA8B;IAC9B,0BAA0B;IAC1B,0BAA0B;IAC1B,wBAAwB;IACxB,wBAAwB;CACzB,CAAC;AAEF,MAAM,UAAU,YAAY,CAC1B,IAAgB,EAChB,IAAwB,EACxB,OAA6B,EAC7B,SAAS,GAAG,gBAAgB;IAE5B,OAAO,cAAc,CAAC,SAAS,CAAC,OAAO,CAAC,CAAC,QAAQ,EAAE,EAAE,CAAC,QAAQ,CAAC,GAAG,CAAC,EAAE,IAAI,EAAE,IAAI,EAAE,OAAO,EAAE,CAAC,CAAC,CAAC;SAC1F,GAAG,CAAC,4BAA4B,CAAC;SACjC,GAAG,CAAC,CAAC,OAAO,EAAE,EAAE,CAAC,+BAA+B,CAAC,OAAO,EAAE,IAAI,CAAC,KAAK,CAAC,CAAC,CAAC;AAC5E,CAAC;AAED,MAAM,UAAU,iBAAiB,CAC/B,QAAmB,EACnB,IAAiB,EACjB,IAAyB,EACzB,SAAgC,EAAE;IAElC,MAAM,YAAY,GAAG,aAAa,CAAC,QAAQ,EAAE,SAAS,CAAC,CAAC;IACxD,MAAM,SAAS,GAAG,aAAa,CAAC,QAAQ,EAAE,MAAM,CAAC,CAAC;IAClD,MAAM,gBAAgB,GAAG,QAAQ,CAAC,MAAM,CAAC,CAAC,OAAO,EAAE,EAAE,CAAC,iBAAiB,CAAC,OAAO,EAAE,MAAM,CAAC,CAAC,CAAC;IAE1F,OAAO;QACL,QAAQ,EAAE,gBAAgB,CAAC,MAAM,GAAG,CAAC,CAAC,CAAC,CAAC,MAAM,CAAC,CAAC,CAAC,MAAM;QACvD,YAAY,EAAE,QAAQ,CAAC,MAAM;QAC7B,YAAY;QACZ,SAAS;QACT,WAAW,EAAE,aAAa,CAAC,QAAQ,EAAE,QAAQ,CAAC;QAC9C,QAAQ,EAAE,aAAa,CAAC,QAAQ,EAAE,KAAK,CAAC;QACxC,SAAS,EAAE,aAAa,CAAC,QAAQ,EAAE,MAAM,CAAC;QAC1C,qBAAqB,EAAE,8BAA8B,CAAC,QAAQ,EAAE,MAAM,CAAC;QACvE,aAAa,EACX,IAAI,KAAK,SAAS,IAAI,IAAI,KAAK,SAAS,CAAC,CAAC,CAAC,sBAAsB,CAAC,IAAI,EAAE,IAAI,CAAC,KAAK,CAAC,CAAC,CAAC,CAAC,CAAC;QACzF,mBAAmB,EACjB,IAAI,KAAK,SAAS,IAAI,IAAI,KAAK,SAAS;YACtC,CAAC,CAAC,4BAA4B,CAAC,IAAI,EAAE,IAAI,CAAC,KAAK,EAAE,QAAQ,CAAC;YAC1D,CAAC,CAAC,SAAS;QACf,kBAAkB,EAChB,IAAI,KAAK,SAAS,IAAI,IAAI,KAAK,SAAS;YACtC,CAAC,CAAC,2BAA2B,CAAC,IAAI,EAAE,IAAI,CAAC,KAAK,EAAE,QAAQ,CAAC;YACzD,CAAC,CAAC,SAAS;KAChB,CAAC;AACJ,CAAC;AAED,SAAS,8BAA8B,CACrC,QAAmB,EACnB,MAA6B;IAE7B,OAAO;QACL,qBAAqB,EAAE,QAAQ,CAAC,MAAM,CAAC,CAAC,OAAO,EAAE,EAAE,CAAC,iBAAiB,CAAC,OAAO,EAAE,MAAM,CAAC,CAAC,CAAC,MAAM;QAC9F,oBAAoB,EAAE,QAAQ,CAAC,MAAM,CAAC,CAAC,OAAO,EAAE,EAAE,CAAC,wBAAwB,CAAC,OAAO,EAAE,MAAM,CAAC,CAAC;aAC1F,MAAM;QACT,yBAAyB,EAAE,QAAQ,CAAC,MAAM,CAAC,6BAA6B,CAAC,CAAC,MAAM;KACjF,CAAC;AACJ,CAAC;AAED,SAAS,iBAAiB,CAAC,OAAgB,EAAE,MAA6B;IACxE,IAAI,CAAC,iBAAiB,CAAC,OAAO,EAAE,MAAM,CAAC,MAAM,IAAI,MAAM,CAAC,EAAE,CAAC;QACzD,OAAO,KAAK,CAAC;IACf,CAAC;IAED,MAAM,WAAW,GAAG,0BAA0B,CAAC,OAAO,CAAC,CAAC;IAExD,IAAI,CAAC,WAAW,CAAC,gBAAgB,EAAE,CAAC;QAClC,OAAO,KAAK,CAAC;IACf,CAAC;IAED,IAAI,MAAM,CAAC,iBAAiB,EAAE,QAAQ,CAAC,OAAO,CAAC,QAAQ,CAAC,KAAK,IAAI,EAAE,CAAC;QAClE,OAAO,IAAI,CAAC;IACd,CAAC;IAED,MAAM,oBAAoB,GAAG,MAAM,CAAC,oBAAoB,IAAI,2BAA2B,CAAC;IAExF,OAAO,CAAC,oBAAoB,CAAC,QAAQ,CAAC,OAAO,CAAC,QAAQ,CAAC,CAAC;AAC1D,CAAC;AAED,SAAS,wBAAwB,CAAC,OAAgB,EAAE,MAA6B;IAC/E,IAAI,CAAC,iBAAiB,CAAC,OAAO,EAAE,MAAM,CAAC,MAAM,IAAI,MAAM,CAAC,EAAE,CAAC;QACzD,OAAO,KAAK,CAAC;IACf,CAAC;IAED,IAAI,CAAC,0BAA0B,CAAC,OAAO,CAAC,CAAC,gBAAgB,EAAE,CAAC;QAC1D,OAAO,KAAK,CAAC;IACf,CAAC;IAED,IAAI,MAAM,CAAC,iBAAiB,EAAE,QAAQ,CAAC,OAAO,CAAC,QAAQ,CAAC,KAAK,IAAI,EAAE,CAAC;QAClE,OAAO,KAAK,CAAC;IACf,CAAC;IAED,MAAM,oBAAoB,GAAG,MAAM,CAAC,oBAAoB,IAAI,2BAA2B,CAAC;IAExF,OAAO,oBAAoB,CAAC,QAAQ,CAAC,OAAO,CAAC,QAAQ,CAAC,CAAC;AACzD,CAAC;AAED,SAAS,iBAAiB,CACxB,OAAgB,EAChB,MAAoD;IAEpD,IAAI,MAAM,KAAK,SAAS,EAAE,CAAC;QACzB,OAAO,OAAO,CAAC,QAAQ,KAAK,SAAS,CAAC;IACxC,CAAC;IAED,IAAI,MAAM,KAAK,QAAQ,EAAE,CAAC;QACxB,OAAO,CACL,OAAO,CAAC,QAAQ,KAAK,SAAS,IAAI,OAAO,CAAC,QAAQ,KAAK,MAAM,IAAI,OAAO,CAAC,QAAQ,KAAK,QAAQ,CAC/F,CAAC;IACJ,CAAC;IAED,OAAO,OAAO,CAAC,QAAQ,KAAK,SAAS,IAAI,OAAO,CAAC,QAAQ,KAAK,MAAM,CAAC;AACvE,CAAC;AAED,SAAS,6BAA6B,CAAC,OAAgB;IACrD,OAAO,CACL,CAAC,OAAO,CAAC,QAAQ,KAAK,SAAS,IAAI,OAAO,CAAC,QAAQ,KAAK,MAAM,CAAC;QAC/D,CAAC,0BAA0B,CAAC,OAAO,CAAC,CAAC,gBAAgB,CACtD,CAAC;AACJ,CAAC;AAED,SAAS,aAAa,CAAC,QAAmB,EAAE,QAA6B;IACvE,OAAO,QAAQ,CAAC,MAAM,CAAC,CAAC,OAAO,EAAE,EAAE,CAAC,OAAO,CAAC,QAAQ,KAAK,QAAQ,CAAC,CAAC,MAAM,CAAC;AAC5E,CAAC;AAED,SAAS,cAAc,CAAC,QAAmB;IACzC,MAAM,gBAAgB,GAAG,IAAI,GAAG,CAC9B,QAAQ;SACL,MAAM,CAAC,CAAC,OAAO,EAAE,EAAE,CAAC,OAAO,CAAC,QAAQ,KAAK,cAAc,CAAC;SACxD,OAAO,CAAC,CAAC,OAAO,EAAE,EAAE,CAAC,OAAO,CAAC,QAAQ,CAAC,GAAG,CAAC,CAAC,QAAQ,EAAE,EAAE,CAAC,QAAQ,CAAC,IAAI,CAAC,CAAC;SACvE,MAAM,CAAC,CAAC,IAAI,EAAkB,EAAE,CAAC,IAAI,KAAK,SAAS,CAAC,CACxD,CAAC;IACF,MAAM,4BAA4B,GAAG,IAAI,GAAG,CAC1C,QAAQ;SACL,MAAM,CAAC,CAAC,OAAO,EAAE,EAAE,CAAC,OAAO,CAAC,QAAQ,KAAK,qBAAqB,CAAC;SAC/D,OAAO,CAAC,CAAC,OAAO,EAAE,EAAE,CAAC,OAAO,CAAC,QAAQ,CAAC,GAAG,CAAC,CAAC,QAAQ,EAAE,EAAE,CAAC,QAAQ,CAAC,IAAI,CAAC,CAAC;SACvE,MAAM,CAAC,CAAC,IAAI,EAAkB,EAAE,CAAC,IAAI,KAAK,SAAS,CAAC,CACxD,CAAC;IAEF,IAAI,gBAAgB,CAAC,IAAI,KAAK,CAAC,IAAI,4BAA4B,CAAC,IAAI,KAAK,CAAC,EAAE,CAAC;QAC3E,OAAO,QAAQ,CAAC;IAClB,CAAC;IAED,OAAO,QAAQ,CAAC,MAAM,CAAC,CAAC,OAAO,EAAE,EAAE;QACjC,IACE,OAAO,CAAC,QAAQ,KAAK,yBAAyB;YAC9C,OAAO,CAAC,QAAQ,CAAC,IAAI,CACnB,CAAC,QAAQ,EAAE,EAAE,CAAC,QAAQ,CAAC,IAAI,KAAK,SAAS,IAAI,4BAA4B,CAAC,GAAG,CAAC,QAAQ,CAAC,IAAI,CAAC,CAC7F,EACD,CAAC;YACD,OAAO,KAAK,CAAC;QACf,CAAC;QAED,IAAI,OAAO,CAAC,QAAQ,KAAK,OAAO,IAAI,OAAO,CAAC,QAAQ,KAAK,QAAQ,EAAE,CAAC;YAClE,OAAO,IAAI,CAAC;QACd,CAAC;QAED,OAAO,CAAC,OAAO,CAAC,QAAQ,CAAC,IAAI,CAC3B,CAAC,QAAQ,EAAE,EAAE,CAAC,QAAQ,CAAC,IAAI,KAAK,SAAS,IAAI,gBAAgB,CAAC,GAAG,CAAC,QAAQ,CAAC,IAAI,CAAC,CACjF,CAAC;IACJ,CAAC,CAAC,CAAC;AACL,CAAC"}
|
|
@@ -27,7 +27,7 @@ function detectSecretAssignment(file, line) {
|
|
|
27
27
|
}
|
|
28
28
|
const quote = match[1] ?? "";
|
|
29
29
|
const value = match[2] ?? "";
|
|
30
|
-
if (quote.length === 0 && !/[0-
|
|
30
|
+
if (quote.length === 0 && !/[0-9]/.test(value)) {
|
|
31
31
|
return undefined;
|
|
32
32
|
}
|
|
33
33
|
return {
|
|
@@ -1 +1 @@
|
|
|
1
|
-
{"version":3,"file":"secret-path-detector.js","sourceRoot":"","sources":["../../src/detectors/secret-path-detector.ts"],"names":[],"mappings":"AAgBA,MAAM,uBAAuB,GAC3B,uJAAuJ,CAAC;AAC1J,MAAM,qBAAqB,GAAG;IAC5B,2BAA2B;IAC3B,2BAA2B;IAC3B,kCAAkC;IAClC,sBAAsB;CACvB,CAAC;AACF,MAAM,0BAA0B,GAAG,uDAAuD,CAAC;AAC3F,MAAM,wBAAwB,GAAG,iEAAiE,CAAC;AACnG,MAAM,kBAAkB,GACtB,6GAA6G,CAAC;AAEhH,MAAM,CAAC,MAAM,kBAAkB,GAAa;IAC1C,IAAI,EAAE,aAAa;IACnB,GAAG,EAAE,CAAC,EAAE,IAAI,EAAE,EAAE,EAAE,CAAC,IAAI,CAAC,KAAK,CAAC,OAAO,CAAC,gCAAgC,CAAC;CACxE,CAAC;AAEF,SAAS,cAAc,CAAC,IAAc,EAAE,IAAc;IACpD,OAAO;QACL,sBAAsB,CAAC,IAAI,EAAE,IAAI,CAAC;QAClC,mBAAmB,CAAC,IAAI,EAAE,IAAI,CAAC;QAC/B,kBAAkB,CAAC,IAAI,EAAE,IAAI,CAAC;QAC9B,iBAAiB,CAAC,IAAI,EAAE,IAAI,CAAC;KAC9B,CAAC,MAAM,CAAC,CAAC,MAAM,EAA8B,EAAE,CAAC,MAAM,KAAK,SAAS,CAAC,CAAC;AACzE,CAAC;AAED,SAAS,sBAAsB,CAAC,IAAc,EAAE,IAAc;IAC5D,MAAM,KAAK,GAAG,uBAAuB,CAAC,IAAI,CAAC,IAAI,CAAC,OAAO,CAAC,CAAC;IAEzD,IAAI,KAAK,KAAK,IAAI,EAAE,CAAC;QACnB,OAAO,SAAS,CAAC;IACnB,CAAC;IAED,MAAM,KAAK,GAAG,KAAK,CAAC,CAAC,CAAC,IAAI,EAAE,CAAC;IAC7B,MAAM,KAAK,GAAG,KAAK,CAAC,CAAC,CAAC,IAAI,EAAE,CAAC;IAE7B,IAAI,KAAK,CAAC,MAAM,KAAK,CAAC,IAAI,CAAC,
|
|
1
|
+
{"version":3,"file":"secret-path-detector.js","sourceRoot":"","sources":["../../src/detectors/secret-path-detector.ts"],"names":[],"mappings":"AAgBA,MAAM,uBAAuB,GAC3B,uJAAuJ,CAAC;AAC1J,MAAM,qBAAqB,GAAG;IAC5B,2BAA2B;IAC3B,2BAA2B;IAC3B,kCAAkC;IAClC,sBAAsB;CACvB,CAAC;AACF,MAAM,0BAA0B,GAAG,uDAAuD,CAAC;AAC3F,MAAM,wBAAwB,GAAG,iEAAiE,CAAC;AACnG,MAAM,kBAAkB,GACtB,6GAA6G,CAAC;AAEhH,MAAM,CAAC,MAAM,kBAAkB,GAAa;IAC1C,IAAI,EAAE,aAAa;IACnB,GAAG,EAAE,CAAC,EAAE,IAAI,EAAE,EAAE,EAAE,CAAC,IAAI,CAAC,KAAK,CAAC,OAAO,CAAC,gCAAgC,CAAC;CACxE,CAAC;AAEF,SAAS,cAAc,CAAC,IAAc,EAAE,IAAc;IACpD,OAAO;QACL,sBAAsB,CAAC,IAAI,EAAE,IAAI,CAAC;QAClC,mBAAmB,CAAC,IAAI,EAAE,IAAI,CAAC;QAC/B,kBAAkB,CAAC,IAAI,EAAE,IAAI,CAAC;QAC9B,iBAAiB,CAAC,IAAI,EAAE,IAAI,CAAC;KAC9B,CAAC,MAAM,CAAC,CAAC,MAAM,EAA8B,EAAE,CAAC,MAAM,KAAK,SAAS,CAAC,CAAC;AACzE,CAAC;AAED,SAAS,sBAAsB,CAAC,IAAc,EAAE,IAAc;IAC5D,MAAM,KAAK,GAAG,uBAAuB,CAAC,IAAI,CAAC,IAAI,CAAC,OAAO,CAAC,CAAC;IAEzD,IAAI,KAAK,KAAK,IAAI,EAAE,CAAC;QACnB,OAAO,SAAS,CAAC;IACnB,CAAC;IAED,MAAM,KAAK,GAAG,KAAK,CAAC,CAAC,CAAC,IAAI,EAAE,CAAC;IAC7B,MAAM,KAAK,GAAG,KAAK,CAAC,CAAC,CAAC,IAAI,EAAE,CAAC;IAE7B,IAAI,KAAK,CAAC,MAAM,KAAK,CAAC,IAAI,CAAC,OAAO,CAAC,IAAI,CAAC,KAAK,CAAC,EAAE,CAAC;QAC/C,OAAO,SAAS,CAAC;IACnB,CAAC;IAED,OAAO;QACL,EAAE,EAAE,mBAAmB;QACvB,KAAK,EAAE,iCAAiC;QACxC,OAAO,EAAE,yCAAyC;QAClD,MAAM,EACJ,0FAA0F;QAC5F,QAAQ,EAAE,SAAS;QACnB,UAAU,EAAE,IAAI;QAChB,IAAI,EAAE,IAAI,CAAC,IAAI;QACf,UAAU,EAAE,IAAI,CAAC,aAAa;QAC9B,eAAe,EAAE,UAAU,CAAC,IAAI,CAAC,OAAO,CAAC;KAC1C,CAAC;AACJ,CAAC;AAED,SAAS,mBAAmB,CAAC,IAAc,EAAE,IAAc;IACzD,MAAM,OAAO,GAAG,qBAAqB,CAAC,IAAI,CAAC,CAAC,OAAO,EAAE,EAAE,CAAC,OAAO,CAAC,IAAI,CAAC,IAAI,CAAC,OAAO,CAAC,CAAC,CAAC;IAEpF,IAAI,CAAC,OAAO,EAAE,CAAC;QACb,OAAO,SAAS,CAAC;IACnB,CAAC;IAED,OAAO;QACL,EAAE,EAAE,gBAAgB;QACpB,KAAK,EAAE,8BAA8B;QACrC,OAAO,EAAE,gEAAgE;QACzE,MAAM,EAAE,uFAAuF;QAC/F,QAAQ,EAAE,SAAS;QACnB,UAAU,EAAE,IAAI;QAChB,IAAI,EAAE,IAAI,CAAC,IAAI;QACf,UAAU,EAAE,IAAI,CAAC,aAAa;QAC9B,eAAe,EAAE,UAAU,CAAC,IAAI,CAAC,OAAO,CAAC;KAC1C,CAAC;AACJ,CAAC;AAED,SAAS,kBAAkB,CAAC,IAAc,EAAE,IAAc;IACxD,IAAI,mBAAmB,CAAC,IAAI,CAAC,EAAE,CAAC;QAC9B,OAAO,SAAS,CAAC;IACnB,CAAC;IAED,MAAM,OAAO,GACX,0BAA0B,CAAC,IAAI,CAAC,IAAI,CAAC,OAAO,CAAC,IAAI,wBAAwB,CAAC,IAAI,CAAC,IAAI,CAAC,OAAO,CAAC,CAAC;IAE/F,IAAI,CAAC,OAAO,EAAE,CAAC;QACb,OAAO,SAAS,CAAC;IACnB,CAAC;IAED,OAAO;QACL,EAAE,EAAE,eAAe;QACnB,KAAK,EAAE,0CAA0C;QACjD,OAAO,EAAE,kDAAkD;QAC3D,MAAM,EACJ,wFAAwF;QAC1F,QAAQ,EAAE,QAAQ;QAClB,UAAU,EAAE,IAAI;QAChB,IAAI,EAAE,IAAI,CAAC,IAAI;QACf,UAAU,EAAE,IAAI,CAAC,aAAa;QAC9B,eAAe,EAAE,UAAU,CAAC,IAAI,CAAC,OAAO,CAAC;KAC1C,CAAC;AACJ,CAAC;AAED,SAAS,iBAAiB,CAAC,IAAc,EAAE,IAAc;IACvD,IAAI,mBAAmB,CAAC,IAAI,CAAC,EAAE,CAAC;QAC9B,OAAO,SAAS,CAAC;IACnB,CAAC;IAED,IAAI,CAAC,kBAAkB,CAAC,IAAI,CAAC,IAAI,CAAC,OAAO,CAAC,EAAE,CAAC;QAC3C,OAAO,SAAS,CAAC;IACnB,CAAC;IAED,OAAO;QACL,EAAE,EAAE,cAAc;QAClB,KAAK,EAAE,6BAA6B;QACpC,OAAO,EAAE,oDAAoD;QAC7D,MAAM,EAAE,qFAAqF;QAC7F,QAAQ,EAAE,QAAQ;QAClB,UAAU,EAAE,IAAI;QAChB,IAAI,EAAE,IAAI,CAAC,IAAI;QACf,UAAU,EAAE,IAAI,CAAC,aAAa;QAC9B,eAAe,EAAE,UAAU,CAAC,IAAI,CAAC,OAAO,CAAC;KAC1C,CAAC;AACJ,CAAC;AAED,SAAS,mBAAmB,CAAC,IAAc;IACzC,OAAO,IAAI,CAAC,IAAI,KAAK,MAAM,IAAI,IAAI,CAAC,IAAI,KAAK,MAAM,CAAC;AACtD,CAAC;AAED,SAAS,UAAU,CAAC,OAAe;IACjC,OAAO,OAAO;SACX,OAAO,CAAC,uBAAuB,EAAE,CAAC,KAAK,EAAE,MAAc,EAAE,MAAc,EAAE,EAAE,CAC1E,KAAK,CAAC,OAAO,CAAC,MAAM,EAAE,MAAM,CAAC,MAAM,CAAC,CAAC,CACtC;SACA,OAAO,CAAC,4BAA4B,EAAE,CAAC,KAAK,EAAE,EAAE,CAAC,MAAM,CAAC,KAAK,CAAC,CAAC;SAC/D,OAAO,CAAC,4BAA4B,EAAE,CAAC,KAAK,EAAE,EAAE,CAAC,MAAM,CAAC,KAAK,CAAC,CAAC;SAC/D,OAAO,CAAC,mCAAmC,EAAE,CAAC,KAAK,EAAE,EAAE,CAAC,MAAM,CAAC,KAAK,CAAC,CAAC;SACtE,OAAO,CAAC,uBAAuB,EAAE,CAAC,KAAK,EAAE,EAAE,CAAC,MAAM,CAAC,KAAK,CAAC,CAAC;SAC1D,OAAO,CAAC,0BAA0B,EAAE,CAAC,KAAK,EAAE,IAAY,EAAE,EAAE,CAAC,KAAK,CAAC,OAAO,CAAC,IAAI,EAAE,MAAM,CAAC,IAAI,CAAC,CAAC,CAAC;SAC/F,OAAO,CAAC,wBAAwB,EAAE,CAAC,KAAK,EAAE,IAAY,EAAE,EAAE,CAAC,KAAK,CAAC,OAAO,CAAC,IAAI,EAAE,MAAM,CAAC,IAAI,CAAC,CAAC,CAAC;SAC7F,OAAO,CAAC,kBAAkB,EAAE,CAAC,KAAK,EAAE,EAAE,CAAC,MAAM,CAAC,KAAK,CAAC,CAAC,CAAC;AAC3D,CAAC;AAED,SAAS,MAAM,CAAC,KAAa;IAC3B,IAAI,KAAK,CAAC,MAAM,IAAI,CAAC,EAAE,CAAC;QACtB,OAAO,YAAY,CAAC;IACtB,CAAC;IAED,OAAO,GAAG,KAAK,CAAC,KAAK,CAAC,CAAC,EAAE,CAAC,CAAC,mBAAmB,KAAK,CAAC,KAAK,CAAC,CAAC,CAAC,CAAC,EAAE,CAAC;AAClE,CAAC;AAED,SAAS,SAAS,CAAC,MAAwB;IACzC,OAAO;QACL,EAAE,EAAE,eAAe,MAAM,CAAC,IAAI,IAAI,MAAM,CAAC,EAAE,IAAI,MAAM,CAAC,UAAU,IAAI,SAAS,EAAE;QAC/E,QAAQ,EAAE,aAAa;QACvB,QAAQ,EAAE,MAAM,CAAC,QAAQ;QACzB,UAAU,EAAE,MAAM,CAAC,UAAU;QAC7B,KAAK,EAAE,MAAM,CAAC,KAAK;QACnB,OAAO,EAAE,MAAM,CAAC,OAAO;QACvB,QAAQ,EAAE;YACR;gBACE,IAAI,EAAE,MAAM;gBACZ,IAAI,EAAE,MAAM,CAAC,IAAI;gBACjB,SAAS,EAAE,MAAM,CAAC,UAAU;gBAC5B,OAAO,EAAE,MAAM,CAAC,UAAU;gBAC1B,OAAO,EAAE,MAAM,CAAC,eAAe,CAAC,IAAI,EAAE;gBACtC,IAAI,EAAE;oBACJ,MAAM,EAAE,MAAM,CAAC,EAAE;iBAClB;aACF;SACF;QACD,MAAM,EAAE,MAAM,CAAC,MAAM;QACrB,IAAI,EAAE,CAAC,QAAQ,CAAC;KACjB,CAAC;AACJ,CAAC;AAED,MAAM,UAAU,gCAAgC,CAAC,IAAc;IAC7D,OAAO,IAAI,CAAC,KAAK,CAAC,OAAO,CAAC,CAAC,IAAI,EAAE,EAAE,CACjC,IAAI,CAAC,KAAK;SACP,MAAM,CAAC,CAAC,IAAI,EAAE,EAAE,CAAC,IAAI,CAAC,IAAI,KAAK,KAAK,CAAC;SACrC,OAAO,CAAC,CAAC,IAAI,EAAE,EAAE,CAAC,cAAc,CAAC,IAAI,EAAE,IAAI,CAAC,CAAC,GAAG,CAAC,SAAS,CAAC,CAAC,CAChE,CAAC;AACJ,CAAC"}
|
|
@@ -1 +1 @@
|
|
|
1
|
-
{"version":3,"file":"test-weakening-detector.d.ts","sourceRoot":"","sources":["../../src/detectors/test-weakening-detector.ts"],"names":[],"mappings":"AAEA,OAAO,KAAK,EAAE,QAAQ,EAAE,MAAM,YAAY,CAAC;
|
|
1
|
+
{"version":3,"file":"test-weakening-detector.d.ts","sourceRoot":"","sources":["../../src/detectors/test-weakening-detector.ts"],"names":[],"mappings":"AAEA,OAAO,KAAK,EAAE,QAAQ,EAAE,MAAM,YAAY,CAAC;AAyE3C,eAAO,MAAM,qBAAqB,EAAE,QAGnC,CAAC"}
|
|
@@ -10,6 +10,36 @@ const skipPatterns = [
|
|
|
10
10
|
/\b(?:it|test)\.todo\s*\(/,
|
|
11
11
|
/\b(?:it|test|describe)\.only\s*\(/
|
|
12
12
|
];
|
|
13
|
+
const genericMatcherPatterns = [
|
|
14
|
+
/\.toBeDefined\s*\(/,
|
|
15
|
+
/\.toBeUndefined\s*\(/,
|
|
16
|
+
/\.toBeTruthy\s*\(/,
|
|
17
|
+
/\.toBeFalsy\s*\(/,
|
|
18
|
+
/\.toBeNull\s*\(/,
|
|
19
|
+
/\.toBeInTheDocument\s*\(/,
|
|
20
|
+
/\.toExist\s*\(/
|
|
21
|
+
];
|
|
22
|
+
const behaviorMatcherPatterns = [
|
|
23
|
+
/\.toHaveBeenCalledWith\s*\(/,
|
|
24
|
+
/\.toHaveBeenNthCalledWith\s*\(/,
|
|
25
|
+
/\.toHaveTextContent\s*\(/,
|
|
26
|
+
/\.toHaveAttribute\s*\(/,
|
|
27
|
+
/\.toHaveClass\s*\(/,
|
|
28
|
+
/\.toThrow\s*\(/,
|
|
29
|
+
/\.rejects\./,
|
|
30
|
+
/\.resolves\./,
|
|
31
|
+
/\.toMatchObject\s*\(/,
|
|
32
|
+
/\.toStrictEqual\s*\(/,
|
|
33
|
+
/\.toEqual\s*\(/,
|
|
34
|
+
/\.toContain\s*\(/,
|
|
35
|
+
/\.toMatch\s*\(/
|
|
36
|
+
];
|
|
37
|
+
const renderPresencePatterns = [
|
|
38
|
+
/screen\.(?:get|query|find)By(?:Text|Role|TestId|LabelText|PlaceholderText|AltText|Title)\s*\(/,
|
|
39
|
+
/render\s*\(/,
|
|
40
|
+
/\bcontainer\b/,
|
|
41
|
+
/\.toBeInTheDocument\s*\(/
|
|
42
|
+
];
|
|
13
43
|
export const testWeakeningDetector = {
|
|
14
44
|
name: "test-weakening",
|
|
15
45
|
run: ({ diff }) => diff.files.filter(isTestFile).flatMap(extractSignals).map(toFinding)
|
|
@@ -18,45 +48,58 @@ function isTestFile(file) {
|
|
|
18
48
|
return file.role === "test";
|
|
19
49
|
}
|
|
20
50
|
function extractSignals(file) {
|
|
21
|
-
return file.hunks.flatMap((hunk) =>
|
|
22
|
-
const
|
|
23
|
-
|
|
24
|
-
|
|
25
|
-
|
|
26
|
-
|
|
27
|
-
|
|
28
|
-
|
|
29
|
-
|
|
30
|
-
|
|
31
|
-
|
|
32
|
-
|
|
33
|
-
|
|
34
|
-
|
|
51
|
+
return file.hunks.flatMap((hunk) => {
|
|
52
|
+
const addedAssertions = hunk.lines
|
|
53
|
+
.filter((candidate) => candidate.kind === "add" && isAssertionLine(candidate))
|
|
54
|
+
.map(toAssertionSignal);
|
|
55
|
+
return hunk.lines.flatMap((line) => {
|
|
56
|
+
if (line.kind === "delete" && isAssertionLine(line)) {
|
|
57
|
+
const removedAssertion = toAssertionSignal(line);
|
|
58
|
+
const replacement = findLikelyReplacement(removedAssertion, addedAssertions);
|
|
59
|
+
if (replacement !== undefined) {
|
|
60
|
+
const weakening = getSpecificityWeakening(removedAssertion, replacement);
|
|
61
|
+
if (weakening !== undefined) {
|
|
62
|
+
return [toSpecificityDeltaSignal(file, removedAssertion, replacement, weakening)];
|
|
63
|
+
}
|
|
64
|
+
return [];
|
|
35
65
|
}
|
|
36
|
-
|
|
37
|
-
|
|
38
|
-
|
|
39
|
-
|
|
40
|
-
|
|
41
|
-
|
|
42
|
-
|
|
43
|
-
|
|
44
|
-
|
|
45
|
-
|
|
46
|
-
:
|
|
47
|
-
|
|
48
|
-
|
|
49
|
-
|
|
50
|
-
|
|
51
|
-
|
|
52
|
-
|
|
53
|
-
|
|
54
|
-
|
|
55
|
-
|
|
56
|
-
|
|
57
|
-
|
|
58
|
-
|
|
59
|
-
|
|
66
|
+
return [
|
|
67
|
+
{
|
|
68
|
+
id: "removed-assertion",
|
|
69
|
+
title: "Test assertion removed",
|
|
70
|
+
message: "The diff removes a test assertion, which can weaken behavioral coverage.",
|
|
71
|
+
repair: "Restore the removed assertion or replace it with an equally specific behavioral assertion.",
|
|
72
|
+
severity: "high",
|
|
73
|
+
confidence: 0.9,
|
|
74
|
+
path: file.path,
|
|
75
|
+
lineNumber: line.oldLineNumber,
|
|
76
|
+
content: line.content
|
|
77
|
+
}
|
|
78
|
+
];
|
|
79
|
+
}
|
|
80
|
+
if (line.kind === "add" && isSkipLine(line)) {
|
|
81
|
+
const isOnly = /\.only\s*\(/.test(line.content);
|
|
82
|
+
return [
|
|
83
|
+
{
|
|
84
|
+
id: isOnly ? "focused-test" : "skipped-test",
|
|
85
|
+
title: isOnly ? "Focused test committed" : "Skipped or todo test added",
|
|
86
|
+
message: isOnly
|
|
87
|
+
? "The diff adds a focused test marker that can hide the rest of the suite."
|
|
88
|
+
: "The diff adds a skipped or todo test, which can reduce effective coverage.",
|
|
89
|
+
repair: isOnly
|
|
90
|
+
? "Remove the focused test marker and ensure the full test suite runs."
|
|
91
|
+
: "Implement the test or remove the skip/todo marker before merging.",
|
|
92
|
+
severity: isOnly ? "blocker" : "high",
|
|
93
|
+
confidence: 0.95,
|
|
94
|
+
path: file.path,
|
|
95
|
+
lineNumber: line.newLineNumber,
|
|
96
|
+
content: line.content
|
|
97
|
+
}
|
|
98
|
+
];
|
|
99
|
+
}
|
|
100
|
+
return [];
|
|
101
|
+
});
|
|
102
|
+
});
|
|
60
103
|
}
|
|
61
104
|
function isAssertionLine(line) {
|
|
62
105
|
return assertionPatterns.some((pattern) => pattern.test(line.content));
|
|
@@ -64,6 +107,111 @@ function isAssertionLine(line) {
|
|
|
64
107
|
function isSkipLine(line) {
|
|
65
108
|
return skipPatterns.some((pattern) => pattern.test(line.content));
|
|
66
109
|
}
|
|
110
|
+
function toAssertionSignal(line) {
|
|
111
|
+
return {
|
|
112
|
+
line,
|
|
113
|
+
specificity: scoreAssertionSpecificity(line.content)
|
|
114
|
+
};
|
|
115
|
+
}
|
|
116
|
+
function scoreAssertionSpecificity(content) {
|
|
117
|
+
const reasons = [];
|
|
118
|
+
let score = 45;
|
|
119
|
+
let label = "structural";
|
|
120
|
+
if (genericMatcherPatterns.some((pattern) => pattern.test(content))) {
|
|
121
|
+
score = 30;
|
|
122
|
+
label = "generic";
|
|
123
|
+
reasons.push("generic matcher");
|
|
124
|
+
}
|
|
125
|
+
if (renderPresencePatterns.some((pattern) => pattern.test(content))) {
|
|
126
|
+
score = Math.min(score, 25);
|
|
127
|
+
label = "presence";
|
|
128
|
+
reasons.push("render presence assertion");
|
|
129
|
+
}
|
|
130
|
+
if (/\.(?:toHaveLength|toBeGreaterThan|toBeLessThan|toBeGreaterThanOrEqual|toBeLessThanOrEqual)\s*\(/.test(content)) {
|
|
131
|
+
score = Math.max(score, 62);
|
|
132
|
+
label = "specific";
|
|
133
|
+
reasons.push("quantified assertion");
|
|
134
|
+
}
|
|
135
|
+
if (/\.(?:toBe|toEqual)\s*\(\s*(?:true|false|null|undefined|["'`]\S|[-]?\d)/.test(content)) {
|
|
136
|
+
score = Math.max(score, 68);
|
|
137
|
+
label = "specific";
|
|
138
|
+
reasons.push("exact expected value");
|
|
139
|
+
}
|
|
140
|
+
if (behaviorMatcherPatterns.some((pattern) => pattern.test(content))) {
|
|
141
|
+
score = Math.max(score, 78);
|
|
142
|
+
label = "behavioral";
|
|
143
|
+
reasons.push("behavioral matcher");
|
|
144
|
+
}
|
|
145
|
+
if (/\b(?:error|message|status|code|payload|body|url|href|value|role|label|aria-|calledWith)\b/i.test(content)) {
|
|
146
|
+
score += 8;
|
|
147
|
+
reasons.push("domain-specific expectation");
|
|
148
|
+
}
|
|
149
|
+
if (/\b(?:toBeTruthy|toBeDefined|toBeInTheDocument|container|render)\b/.test(content)) {
|
|
150
|
+
score -= 8;
|
|
151
|
+
}
|
|
152
|
+
return {
|
|
153
|
+
score: Math.max(0, Math.min(100, score)),
|
|
154
|
+
label,
|
|
155
|
+
reasons: reasons.length > 0 ? reasons : ["assertion present"]
|
|
156
|
+
};
|
|
157
|
+
}
|
|
158
|
+
function findLikelyReplacement(removed, addedAssertions) {
|
|
159
|
+
if (addedAssertions.length === 0) {
|
|
160
|
+
return undefined;
|
|
161
|
+
}
|
|
162
|
+
if (addedAssertions.length === 1) {
|
|
163
|
+
return addedAssertions[0];
|
|
164
|
+
}
|
|
165
|
+
return [...addedAssertions].sort((left, right) => tokenOverlap(removed.line.content, right.line.content) -
|
|
166
|
+
tokenOverlap(removed.line.content, left.line.content) ||
|
|
167
|
+
right.specificity.score - left.specificity.score)[0];
|
|
168
|
+
}
|
|
169
|
+
function tokenOverlap(left, right) {
|
|
170
|
+
const leftTokens = new Set(extractTokens(left));
|
|
171
|
+
return extractTokens(right).filter((token) => leftTokens.has(token)).length;
|
|
172
|
+
}
|
|
173
|
+
function extractTokens(value) {
|
|
174
|
+
return value
|
|
175
|
+
.toLowerCase()
|
|
176
|
+
.split(/[^a-z0-9_]+/)
|
|
177
|
+
.filter((token) => token.length >= 3 && !["expect", "tobe", "true", "false"].includes(token));
|
|
178
|
+
}
|
|
179
|
+
function getSpecificityWeakening(removed, replacement) {
|
|
180
|
+
const delta = removed.specificity.score - replacement.specificity.score;
|
|
181
|
+
const highToLow = ["behavioral", "specific"].includes(removed.specificity.label) &&
|
|
182
|
+
["presence", "generic"].includes(replacement.specificity.label);
|
|
183
|
+
if (delta < 25 && !highToLow) {
|
|
184
|
+
return undefined;
|
|
185
|
+
}
|
|
186
|
+
return {
|
|
187
|
+
delta,
|
|
188
|
+
reason: highToLow
|
|
189
|
+
? "behavioral assertion replaced with generic or presence assertion"
|
|
190
|
+
: "assertion specificity score decreased"
|
|
191
|
+
};
|
|
192
|
+
}
|
|
193
|
+
function toSpecificityDeltaSignal(file, removed, replacement, weakening) {
|
|
194
|
+
return {
|
|
195
|
+
id: "assertion-specificity-dropped",
|
|
196
|
+
title: "Test assertion became less meaningful",
|
|
197
|
+
message: "The diff replaces a stronger behavioral assertion with a weaker generic or rendering-presence assertion.",
|
|
198
|
+
repair: "Keep the replacement only if it preserves the same behavior check; otherwise restore an equally specific assertion.",
|
|
199
|
+
severity: "high",
|
|
200
|
+
confidence: weakening.delta >= 35 ? 0.9 : 0.84,
|
|
201
|
+
path: file.path,
|
|
202
|
+
lineNumber: replacement.line.newLineNumber ?? removed.line.oldLineNumber,
|
|
203
|
+
content: replacement.line.content,
|
|
204
|
+
data: {
|
|
205
|
+
signal: "assertion-specificity-dropped",
|
|
206
|
+
previousAssertion: removed.line.content.trim(),
|
|
207
|
+
replacementAssertion: replacement.line.content.trim(),
|
|
208
|
+
previousSpecificity: removed.specificity,
|
|
209
|
+
replacementSpecificity: replacement.specificity,
|
|
210
|
+
delta: weakening.delta,
|
|
211
|
+
reason: weakening.reason
|
|
212
|
+
}
|
|
213
|
+
};
|
|
214
|
+
}
|
|
67
215
|
function toFinding(signal) {
|
|
68
216
|
return {
|
|
69
217
|
id: `test-weakening:${signal.path}:${signal.id}:${signal.lineNumber ?? "unknown"}`,
|
|
@@ -80,7 +228,8 @@ function toFinding(signal) {
|
|
|
80
228
|
endLine: signal.lineNumber,
|
|
81
229
|
message: signal.content.trim(),
|
|
82
230
|
data: {
|
|
83
|
-
signal: signal.id
|
|
231
|
+
signal: signal.id,
|
|
232
|
+
...signal.data
|
|
84
233
|
}
|
|
85
234
|
}
|
|
86
235
|
],
|