cricinfo-cli-go 0.1.1 → 0.1.4

package/internal/cricinfo/coverage_ledger_test.go

@@ -137,7 +137,7 @@ func TestFieldPathFamilyCoverageLedgerKnownFamiliesMapped(t *testing.T) {
 func researchedTemplatesFromTSV(t *testing.T) []string {
 	t.Helper()
 
-	path := filepath.Join(repoRoot(t), "gg", "agent-outputs", "cricinfo-working-templates.tsv")
+	path := filepath.Join("testdata", "coverage", "cricinfo-working-templates.tsv")
 	file, err := os.Open(path)
 	if err != nil {
 		t.Fatalf("open working templates TSV %q: %v", path, err)
@@ -177,7 +177,7 @@ func researchedTemplatesFromTSV(t *testing.T) []string {
 func researchedFieldPathFamilies(t *testing.T) map[string]struct{} {
 	t.Helper()
 
-	path := filepath.Join(repoRoot(t), "gg", "agent-outputs", "cricinfo-field-path-catalog.txt")
+	path := filepath.Join("testdata", "coverage", "cricinfo-field-path-catalog.txt")
 	file, err := os.Open(path)
 	if err != nil {
 		t.Fatalf("open field-path catalog %q: %v", path, err)
@@ -231,23 +231,3 @@ func isNumericToken(value string) bool {
 	}
 	return true
 }
-
-func repoRoot(t *testing.T) string {
-	t.Helper()
-
-	dir, err := os.Getwd()
-	if err != nil {
-		t.Fatalf("getwd: %v", err)
-	}
-
-	for {
-		if _, err := os.Stat(filepath.Join(dir, "go.mod")); err == nil {
-			return dir
-		}
-		parent := filepath.Dir(dir)
-		if parent == dir {
-			t.Fatalf("unable to locate repository root from %q", dir)
-		}
-		dir = parent
-	}
-}

package/internal/cricinfo/entity_index.go

@@ -472,12 +472,39 @@ func mergeAliasSlices(slices ...[]string) []string {
 			}
 			seen[normalized] = struct{}{}
 			out = append(out, value)
+			if acronym := aliasAcronym(normalized); acronym != "" {
+				if _, ok := seen[acronym]; !ok {
+					seen[acronym] = struct{}{}
+					out = append(out, acronym)
+				}
+			}
 		}
 	}
 	sort.Strings(out)
 	return out
 }
 
+func aliasAcronym(normalized string) string {
+	tokens := strings.Fields(strings.TrimSpace(normalized))
+	if len(tokens) < 2 {
+		return ""
+	}
+
+	var builder strings.Builder
+	for _, token := range tokens {
+		if token == "" {
+			continue
+		}
+		builder.WriteByte(token[0])
+	}
+
+	acronym := strings.TrimSpace(builder.String())
+	if len(acronym) < 2 {
+		return ""
+	}
+	return acronym
+}
+
 func aliasSet(aliases []string) map[string]struct{} {
 	set := map[string]struct{}{}
 	for _, alias := range aliases {

package/internal/cricinfo/historical_hydration.go

@@ -6,6 +6,7 @@ import (
 	"sort"
 	"strconv"
 	"strings"
+	"sync"
 	"time"
 )
 
@@ -133,6 +134,8 @@ type HistoricalScopeSession struct {
 	partnershipWarnByMatch map[string][]string
 
 	metrics HydrationMetrics
+
+	resolveMu sync.Mutex
 }
 
 func newHistoricalScopeSession(client *Client, resolver *Resolver, opts HistoricalScopeOptions) *HistoricalScopeSession {
@@ -292,52 +295,78 @@ func (s *HistoricalScopeSession) HydratePlayerMatchSummaries(ctx context.Context
 			continue
 		}
 
-		for _, entry := range entries {
-			playerID := strings.TrimSpace(entry.PlayerID)
-			if playerID == "" {
-				continue
-			}
-			if strings.TrimSpace(entry.DisplayName) == "" && s.resolver != nil {
-				_ = s.resolver.seedPlayerByID(ctx, playerID, match.LeagueID, match.ID)
-			}
-			entry = s.enrichRosterEntryFromIndex(entry)
+		type playerHydrationResult struct {
+			item    *PlayerMatch
+			warning string
+		}
+		results := make([]playerHydrationResult, len(entries))
+		sem := make(chan struct{}, detailSubresourceFetchConcurrency)
+		var wg sync.WaitGroup
+		for i, entry := range entries {
+			wg.Add(1)
+			go func(index int, entry TeamRosterEntry, team Team) {
+				defer wg.Done()
+				sem <- struct{}{}
+				defer func() { <-sem }()
 
-			statsRef := rosterPlayerStatisticsRef(match, team, entry)
-			if statsRef == "" {
-				warnings = append(warnings, fmt.Sprintf("player %s has no match statistics route", playerID))
-				continue
-			}
+				playerID := strings.TrimSpace(entry.PlayerID)
+				if playerID == "" {
+					return
+				}
+				if strings.TrimSpace(entry.DisplayName) == "" && s.resolver != nil {
+					_ = s.resolver.seedPlayerByID(ctx, playerID, match.LeagueID, match.ID)
+				}
+				entry = s.enrichRosterEntryFromIndex(entry)
 
-			statsDoc, err := s.resolve(ctx, statsRef)
-			if err != nil {
-				warnings = append(warnings, fmt.Sprintf("player statistics %s: %v", statsRef, err))
-				continue
-			}
+				statsRef := rosterPlayerStatisticsRef(match, team, entry)
+				if statsRef == "" {
+					results[index] = playerHydrationResult{warning: fmt.Sprintf("player %s has no match statistics route", playerID)}
+					return
+				}
 
-			categories, err := NormalizeStatCategories(statsDoc.Body)
-			if err != nil {
-				warnings = append(warnings, fmt.Sprintf("player statistics %s: %v", statsDoc.CanonicalRef, err))
+				statsDoc, err := s.resolve(ctx, statsRef)
+				if err != nil {
+					results[index] = playerHydrationResult{warning: fmt.Sprintf("player statistics %s: %v", statsRef, err)}
+					return
+				}
+
+				categories, err := NormalizeStatCategories(statsDoc.Body)
+				if err != nil {
+					results[index] = playerHydrationResult{warning: fmt.Sprintf("player statistics %s: %v", statsDoc.CanonicalRef, err)}
+					return
+				}
+
+				batting, bowling, fielding := splitPlayerStatCategories(categories)
+				playerMatch := PlayerMatch{
+					PlayerID:      playerID,
+					PlayerRef:     entry.PlayerRef,
+					PlayerName:    nonEmpty(entry.DisplayName, "Unknown Player"),
+					MatchID:       match.ID,
+					CompetitionID: nonEmpty(match.CompetitionID, match.ID),
+					EventID:       match.EventID,
+					LeagueID:      match.LeagueID,
+					TeamID:        team.ID,
+					TeamName:      nonEmpty(team.ShortName, team.Name, "Unknown Team"),
+					StatisticsRef: statsDoc.CanonicalRef,
+					LinescoresRef: rosterPlayerLinescoresRef(match, team, entry),
+					Batting:       batting,
+					Bowling:       bowling,
+					Fielding:      fielding,
+					Summary:       summarizePlayerMatchCategories(categories),
+				}
+				results[index] = playerHydrationResult{item: &playerMatch}
+			}(i, entry, team)
+		}
+		wg.Wait()
+
+		for _, result := range results {
+			if strings.TrimSpace(result.warning) != "" {
+				warnings = append(warnings, result.warning)
 				continue
 			}
-
-			batting, bowling, fielding := splitPlayerStatCategories(categories)
-			items = append(items, PlayerMatch{
-				PlayerID:      playerID,
-				PlayerRef:     entry.PlayerRef,
-				PlayerName:    nonEmpty(entry.DisplayName, "Unknown Player"),
-				MatchID:       match.ID,
-				CompetitionID: nonEmpty(match.CompetitionID, match.ID),
-				EventID:       match.EventID,
-				LeagueID:      match.LeagueID,
-				TeamID:        team.ID,
-				TeamName:      nonEmpty(team.ShortName, team.Name, "Unknown Team"),
-				StatisticsRef: statsDoc.CanonicalRef,
-				LinescoresRef: rosterPlayerLinescoresRef(match, team, entry),
-				Batting:       batting,
-				Bowling:       bowling,
-				Fielding:      fielding,
-				Summary:       summarizePlayerMatchCategories(categories),
-			})
+			if result.item != nil {
+				items = append(items, *result.item)
+			}
 		}
 	}
 
@@ -1397,23 +1426,34 @@ func (s *HistoricalScopeSession) resolve(ctx context.Context, ref string) (*Reso
 		return nil, fmt.Errorf("ref is empty")
 	}
 
+	s.resolveMu.Lock()
 	if cached, ok := s.resolvedDocs[ref]; ok {
 		s.metrics.ResolveCacheHits++
+		s.resolveMu.Unlock()
 		return cached, nil
 	}
+	s.resolveMu.Unlock()
 
 	resolved, err := s.client.ResolveRefChain(ctx, ref)
 	if err != nil {
 		return nil, err
 	}
-	s.metrics.ResolveCacheMisses++
 
 	copied := *resolved
 	pointer := &copied
 	keys := compactWarnings([]string{ref, copied.RequestedRef, copied.CanonicalRef})
+
+	s.resolveMu.Lock()
+	if cached, ok := s.resolvedDocs[ref]; ok {
+		s.metrics.ResolveCacheHits++
+		s.resolveMu.Unlock()
+		return cached, nil
+	}
+	s.metrics.ResolveCacheMisses++
 	for _, key := range keys {
 		s.resolvedDocs[key] = pointer
 	}
+	s.resolveMu.Unlock()
 	return pointer, nil
 }