crewly 1.20.349 → 1.20.350

package/dist/backend/backend/src/constants.js

@@ -1413,12 +1413,20 @@ export const COMPLETION_EVIDENCE_CONSTANTS = {
     /** The two rollout modes for a completion that carries no evidence. */
     MODES: ['warn', 'enforce'],
     /**
-     * Default mode for a completion with no evidence. `warn` (this release):
-     * accepted, logged, and the response carries a `warning`. `enforce` (next
-     * release): 400. Malformed evidence, missing artifacts, failing commands and
-     * `blocked` entries are handled the same in both modes.
+     * Default mode for a completion with no evidence. `enforce` (default since
+     * #1312): 400 `evidence_required`. `warn` (the escape hatch, set with
+     * {@link ENV_MODE}): accepted, logged, and the response carries a `warning`.
+     * Malformed evidence, missing artifacts, failing commands and `blocked`
+     * entries are handled the same in both modes.
      */
-    EVIDENCE_ENFORCEMENT_MODE: 'warn',
+    EVIDENCE_ENFORCEMENT_MODE: 'enforce',
+    /**
+     * WorkItem types whose completion must carry evidence: a worker's
+     * deliverable. Every other type is harness bookkeeping (triage, replans,
+     * retros, reconciles, notifications) and may complete without it. An item
+     * with no known type is treated as a deliverable.
+     */
+    REQUIRED_FOR_TYPES: ['delegate', 'project_task', 'review'],
     /** Env var that overrides {@link EVIDENCE_ENFORCEMENT_MODE} (`warn` | `enforce`). */
     ENV_MODE: 'CREWLY_EVIDENCE_MODE',
     /** Most evidence entries accepted on one completion. */
@@ -1434,8 +1442,27 @@ export const COMPLETION_EVIDENCE_CONSTANTS = {
         MISSING: 'evidence_required',
         ARTIFACT_NOT_FOUND: 'evidence_artifact_not_found',
         ARTIFACT_UNRESOLVABLE: 'evidence_artifact_relative_path',
+        ARTIFACT_EMPTY: 'evidence_artifact_empty',
+        ARTIFACT_STALE: 'evidence_artifact_stale',
         COMMAND_FAILED: 'evidence_command_failed',
+        REVIEW_UNCHECKED: 'review_unchecked',
+        REVIEW_CHECKS_MALFORMED: 'review_checks_malformed',
+        REVIEW_CHECK_FAILED: 'review_check_failed',
     },
+    /** Worker evidence entries listed, numbered, in a review item's description (#1314). */
+    REVIEW_LISTED_ENTRIES: 10,
+    /** Outcomes a reviewer records for one check (#1314). */
+    CHECK_OUTCOMES: ['pass', 'fail'],
+    /** The shape of a reviewer's check record, quoted in every refusal (#1314). */
+    CHECKS_HINT: 'Send body.result.checks: an array of {"entry":<index in the worker\'s output.evidence, or null for a direct look at the work>,' +
+        '"did":"<what you did: opened it and read X / re-ran it, exit 0 / looked at the page>","outcome":"pass"|"fail"}. ' +
+        'At least one check must name a worker evidence entry when there is any. A failed check cannot be accepted: send it back with {"verdict":"rejected","feedback":"..."}.',
+    /**
+     * A local file artifact last modified more than this before its WorkItem
+     * was created is stale: it was not made for this task (#1313). The slack
+     * covers clock skew and a file saved just before the item was filed.
+     */
+    STALE_GRACE_MS: 5 * 60_000,
     /** The shape a worker must send, quoted in every rejection and warning. */
     SHAPE_HINT: 'Send body.result.evidence: an array of {"type":"artifact","path":"<existing file or https URL>"}, ' +
         '{"type":"command","command":"<cmd>","exitCode":0,"outputTail":"<last lines>"}, ' +