crewly 1.20.316 → 1.20.317

package/config/skills/_common/lib.sh

@@ -378,6 +378,26 @@ error_exit() {
   exit 1
 }
 
+# -----------------------------------------------------------------------------
+# unknown_arg_exit arg
+# Reports an unrecognised CLI argument as ONE machine-readable JSON line on
+# stderr (always the LAST line, so `| tail -1` still shows it) and exits 2.
+# An unknown flag gets the bare message. A bare word (not starting with "-") is almost always text that was split
+# because an unescaped double quote ended a --content/--message/--comment
+# string, so the hint says nothing was sent and how to avoid it.
+# Call this INSTEAD of printing usage afterwards; print usage first if wanted.
+# -----------------------------------------------------------------------------
+unknown_arg_exit() {
+  local arg="${1:-}" msg
+  if [[ "$arg" == -* ]]; then
+    msg="Unknown argument: ${arg}"
+  else
+    msg="Unknown argument: ${arg} — nothing was sent. If your text contains double quotes, they ended the string (this word is the rest of it); use --content-file <path>, a heredoc via stdin, or single quotes."
+  fi
+  jq -cn --arg e "$msg" '{"success":false,"error":$e}' >&2
+  exit 2
+}
+
 # -----------------------------------------------------------------------------
 # require_param name value
 # Exits with error if value is empty.

package/config/skills/_common/lib.test.sh

@@ -360,6 +360,24 @@ CREWLY_SESSION_NAME=dev-1 CREWLY_SCHEDULER_CREDENTIAL=scheduler.sig bash "$TEMP_
 assert_eq "api_call: an agent session wins over a leaked scheduler credential" "0" "$(grep -c 'X-Crewly-Internal' "$ARGS_OUT" || true)"
 unset ARGS_OUT
 
+# ---- Test 31: unknown_arg_exit — the error is the LAST line, one JSON object, exit 2 ----
+UA_OUT=$(bash -c 'source "$1"; unknown_arg_exit app; ' _ "$SCRIPT_DIR/lib.sh" 2>&1 >/dev/null; echo "rc=$?")
+assert_contains "unknown_arg_exit: bare word → nothing sent + quoting hint" "nothing was sent" "$UA_OUT"
+assert_contains "unknown_arg_exit: hint names content-file" "content-file" "$UA_OUT"
+assert_contains "unknown_arg_exit: exit code 2" "rc=2" "$UA_OUT"
+assert_eq "unknown_arg_exit: success:false" "false" "$(printf '%s' "$UA_OUT" | head -1 | jq -r .success)"
+UA_FLAG=$(bash -c 'source "$1"; unknown_arg_exit --bogus' _ "$SCRIPT_DIR/lib.sh" 2>&1 >/dev/null || true)
+assert_eq "unknown_arg_exit: unknown flag → bare message, no quoting hint" "Unknown argument: --bogus" "$(printf '%s' "$UA_FLAG" | jq -r .error)"
+
+# ---- Test 32: reply-channel with a split --content (the 2026-10-12 incident) ----
+RC_OUT=$(CREWLY_SESSION_NAME=t bash "$SCRIPT_DIR/../agent/core/reply-channel/execute.sh" --channel C1 --content 是我理解错了:我问要不要先不用 app 画面 2>&1 | tail -1; echo "rc=${PIPESTATUS[0]}")
+assert_contains "reply-channel split content: LAST line is the JSON error" '"success":false' "$RC_OUT"
+assert_contains "reply-channel split content: says nothing was sent" "nothing was sent" "$RC_OUT"
+RC_RC=$(CREWLY_SESSION_NAME=t bash "$SCRIPT_DIR/../agent/core/reply-channel/execute.sh" --channel C1 --content a b c >/dev/null 2>&1; echo $?)
+assert_eq "reply-channel split content: exit code 2" "2" "$RC_RC"
+AF_RC=$(CREWLY_SESSION_NAME=t bash "$SCRIPT_DIR/../agent/core/attach-file/execute.sh" --channel C1 --path /x --comment a b c 2>&1 | tail -1 || true)
+assert_contains "attach-file split comment: LAST line is the JSON error" '"success":false' "$AF_RC"
+
 echo ""
 echo "=== Results: $PASS/$TOTAL passed, $FAIL failed ==="
 

package/config/skills/agent/core/app-comments/execute.sh

@@ -65,7 +65,7 @@ while [[ $# -gt 0 ]]; do
     --status) [ $# -ge 2 ] || error_exit "--status requires a value"; STATUS="$2"; shift 2 ;;
     --text)   [ $# -ge 2 ] || error_exit "--text requires a value"; TEXT="$2"; HAS_TEXT=1; shift 2 ;;
     --help|-h) print_usage; exit 0 ;;
-    *) error_exit "Unknown option: $1" ;;
+    *) unknown_arg_exit "$1" ;;
   esac
 done
 

package/config/skills/agent/core/app-data/execute.sh

@@ -169,7 +169,7 @@ while [[ $# -gt 0 ]]; do
     --scope)     [ $# -ge 2 ] || error_exit "--scope requires a value";     SCOPE="$2"; shift 2 ;;
     --reason)    [ $# -ge 2 ] || error_exit "--reason requires a value";    REASON="$2"; shift 2 ;;
     --help|-h)   print_usage; exit 0 ;;
-    *) error_exit "Unknown option: $1" ;;
+    *) unknown_arg_exit "$1" ;;
   esac
 done
 

package/config/skills/agent/core/attach-file/SKILL.md

@@ -60,6 +60,12 @@ they will want to edit it.
 
 Text still goes through `reply-channel` — send the words, attach the file.
 
+Put `--comment` in single quotes (or leave quotation marks out of it): a
+double quote inside `--comment "..."` splits the text into extra arguments and
+the file is not sent. Read the JSON result; do not cut it off with `| tail -1`.
+The file is also recorded in the chat history under your name, so teammates
+reading the thread see you delivered it.
+
 ## Output
 
 `{"success":true,"data":{"slackChannelId":"C…","threadTs":"1758…","fileId":"F…","asAgentBot":true}}`

package/config/skills/agent/core/attach-file/execute.sh

@@ -41,7 +41,7 @@ while [ $# -gt 0 ]; do
     --ticket)     TICKET="${2:-}"; shift 2 ;;
     --to)         TO="${2:-}"; shift 2 ;;
     -h|--help)    usage; exit 0 ;;
-    *) echo "{\"error\":\"Unknown argument: $1\"}" >&2; exit 1 ;;
+    *) unknown_arg_exit "$1" ;;
   esac
 done
 

package/config/skills/agent/core/break-down-request/execute.sh

@@ -69,7 +69,7 @@ while [[ $# -gt 0 ]]; do
         INPUT_JSON="$1"
         shift
       else
-        error_exit "Unknown argument: $1. Use --help for usage."
+        unknown_arg_exit "$1"
       fi
       ;;
   esac

package/config/skills/agent/core/calendar-create/execute.sh

@@ -55,7 +55,7 @@ while [[ $# -gt 0 ]]; do
                        ATTENDEES_JSON=$(jq -cn --argjson arr "$ATTENDEES_JSON" --arg v "$2" '$arr + [$v]'); shift 2 ;;
     --account)  [ $# -ge 2 ] || error_exit "--account requires a value"; ACCOUNT="$2"; shift 2 ;;
     --help|-h)         print_usage; exit 0 ;;
-    *) error_exit "Unknown option: $1" ;;
+    *) unknown_arg_exit "$1" ;;
   esac
 done
 

package/config/skills/agent/core/calendar-create/execute.test.sh

@@ -74,7 +74,7 @@ check "missing summary errors" "$(run_err --start 2026-10-01 --end 2026-10-02)"
 check "missing start errors" "$(run_err --summary x --end 2026-10-02)" "Missing required parameter: start (--start)"
 check "missing end errors" "$(run_err --summary x --start 2026-10-01)" "Missing required parameter: end (--end)"
 check "validation: no request made" "$(cat "$STUB_LOG")" ""
-check "unknown option errors" "$(run_err --bogus 1)" "Unknown option: --bogus"
+check "unknown option errors" "$(run_err --bogus 1)" "Unknown argument: --bogus"
 
 echo "=== Results: $PASS passed, $FAIL failed ==="
 [ "$FAIL" -eq 0 ]

package/config/skills/agent/core/calendar-list/execute.sh

@@ -58,7 +58,7 @@ while [[ $# -gt 0 ]]; do
     --max|-n)      [ $# -ge 2 ] || error_exit "--max requires a value";      MAX="$2";      shift 2 ;;
     --account)  [ $# -ge 2 ] || error_exit "--account requires a value"; ACCOUNT="$2"; shift 2 ;;
     --help|-h)     print_usage; exit 0 ;;
-    *) error_exit "Unknown option: $1" ;;
+    *) unknown_arg_exit "$1" ;;
   esac
 done
 

package/config/skills/agent/core/calendar-list/execute.test.sh

@@ -65,7 +65,7 @@ OUT=$(CREWLY_API_URL="http://127.0.0.1:${PORT}" bash "$EXEC" --calendar no-grant
 check "409: exit code" "$RC" "1"
 check "409: reason + hint" "$OUT" '{"success":false,"reason":"not_connected","hint":"https://cloud/start?token=j","message":"no grant"}'
 
-check "unknown option errors" "$(run_err --bogus 1)" "Unknown option: --bogus"
+check "unknown option errors" "$(run_err --bogus 1)" "Unknown argument: --bogus"
 
 echo "=== Results: $PASS passed, $FAIL failed ==="
 [ "$FAIL" -eq 0 ]

package/config/skills/agent/core/cancel-followup/execute.sh

@@ -51,8 +51,7 @@ while [[ $# -gt 0 ]]; do
       if [[ -z "$INPUT_JSON" && ${1:0:1} == '{' ]]; then
         INPUT_JSON="$1"; shift
       else
-        echo '{"error":"Unknown argument: '"$1"'"}' >&2
-        exit 1
+        unknown_arg_exit "$1"
       fi
       ;;
   esac

package/config/skills/agent/core/canva-create/execute.sh

@@ -63,7 +63,7 @@ while [[ $# -gt 0 ]]; do
     --size)    [ $# -ge 2 ] || error_exit "--size requires a value";   SIZE="$2";   shift 2 ;;
     --asset)   [ $# -ge 2 ] || error_exit "--asset requires a value";  ASSET="$2";  shift 2 ;;
     --help|-h) print_usage; exit 0 ;;
-    *) error_exit "Unknown option: $1" ;;
+    *) unknown_arg_exit "$1" ;;
   esac
 done
 if [ -n "$INPUT_JSON" ]; then

package/config/skills/agent/core/canva-designs/execute.sh

@@ -67,7 +67,7 @@ while [[ $# -gt 0 ]]; do
     --limit|-n)     [ $# -ge 2 ] || error_exit "--limit requires a value"; LIMIT="$2"; shift 2 ;;
     --continuation) [ $# -ge 2 ] || error_exit "--continuation requires a value"; CONT="$2"; shift 2 ;;
     --help|-h)      print_usage; exit 0 ;;
-    *) error_exit "Unknown option: $1" ;;
+    *) unknown_arg_exit "$1" ;;
   esac
 done
 if [ -n "$INPUT_JSON" ]; then

package/config/skills/agent/core/canva-export/execute.sh

@@ -69,7 +69,7 @@ while [[ $# -gt 0 ]]; do
     --out|-o)        [ $# -ge 2 ] || error_exit "--out requires a value";           OUT_PATH="$2"; shift 2 ;;
     --out-dir)       [ $# -ge 2 ] || error_exit "--out-dir requires a value";       OUT_DIR="$2";  shift 2 ;;
     --help|-h)       print_usage; exit 0 ;;
-    *) error_exit "Unknown option: $1" ;;
+    *) unknown_arg_exit "$1" ;;
   esac
 done
 if [ -n "$INPUT_JSON" ]; then

package/config/skills/agent/core/canva-upload/execute.sh

@@ -55,7 +55,7 @@ while [[ $# -gt 0 ]]; do
     --path|-p) [ $# -ge 2 ] || error_exit "--path requires a value"; FILE="$2"; shift 2 ;;
     --name)    [ $# -ge 2 ] || error_exit "--name requires a value"; NAME="$2"; shift 2 ;;
     --help|-h) print_usage; exit 0 ;;
-    *) error_exit "Unknown option: $1" ;;
+    *) unknown_arg_exit "$1" ;;
   esac
 done
 if [ -n "$INPUT_JSON" ]; then

package/config/skills/agent/core/create-mission/execute.sh

@@ -85,7 +85,7 @@ while [[ $# -gt 0 ]]; do
         INPUT_JSON="$1"
         shift
       else
-        error_exit "Unknown argument: $1. Use --help for usage."
+        unknown_arg_exit "$1"
       fi
       ;;
   esac

package/config/skills/agent/core/create-request/execute.sh

@@ -90,7 +90,7 @@ while [[ $# -gt 0 ]]; do
         INPUT_JSON="$1"
         shift
       else
-        error_exit "Unknown argument: $1. Use --help for usage."
+        unknown_arg_exit "$1"
       fi
       ;;
   esac

package/config/skills/agent/core/create-task/execute.sh

@@ -114,7 +114,7 @@ while [[ $# -gt 0 ]]; do
         INPUT_JSON="$1"
         shift
       else
-        error_exit "Unknown argument: $1. Use --help for usage."
+        unknown_arg_exit "$1"
       fi
       ;;
   esac

package/config/skills/agent/core/docs-comment/execute.sh

@@ -87,7 +87,7 @@ while [[ $# -gt 0 ]]; do
     --account)          [ $# -ge 2 ] || error_exit "--account requires a value"; ACCOUNT="$2"; shift 2 ;;
     --batch)            [ $# -ge 2 ] || error_exit "--batch requires a value";   BATCH="$2";   shift 2 ;;
     --help|-h)          print_usage; exit 0 ;;
-    *) error_exit "Unknown option: $1" ;;
+    *) unknown_arg_exit "$1" ;;
   esac
 done
 if [ -n "$INPUT_JSON" ]; then

package/config/skills/agent/core/docs-read/execute.sh

@@ -55,7 +55,7 @@ while [[ $# -gt 0 ]]; do
     --id)      [ $# -ge 2 ] || error_exit "--id requires a value"; ID="$2"; shift 2 ;;
     --account)  [ $# -ge 2 ] || error_exit "--account requires a value"; ACCOUNT="$2"; shift 2 ;;
     --help|-h) print_usage; exit 0 ;;
-    *) error_exit "Unknown option: $1" ;;
+    *) unknown_arg_exit "$1" ;;
   esac
 done
 if [ -n "$INPUT_JSON" ]; then

package/config/skills/agent/core/docs-write/execute.sh

@@ -65,7 +65,7 @@ while [[ $# -gt 0 ]]; do
     --text-file) [ $# -ge 2 ] || error_exit "--text-file requires a value"; TEXT_FILE="$2"; shift 2 ;;
     --account)  [ $# -ge 2 ] || error_exit "--account requires a value"; ACCOUNT="$2"; shift 2 ;;
     --help|-h)   print_usage; exit 0 ;;
-    *) error_exit "Unknown option: $1" ;;
+    *) unknown_arg_exit "$1" ;;
   esac
 done
 if [ -n "$INPUT_JSON" ]; then

package/config/skills/agent/core/drive-read/execute.sh

@@ -57,7 +57,7 @@ while [[ $# -gt 0 ]]; do
     --out|-o)  [ $# -ge 2 ] || error_exit "--out requires a value"; OUT_PATH="$2"; shift 2 ;;
     --account)  [ $# -ge 2 ] || error_exit "--account requires a value"; ACCOUNT="$2"; shift 2 ;;
     --help|-h) print_usage; exit 0 ;;
-    *) error_exit "Unknown option: $1" ;;
+    *) unknown_arg_exit "$1" ;;
   esac
 done
 if [ -n "$INPUT_JSON" ]; then

package/config/skills/agent/core/drive-search/execute.sh

@@ -61,7 +61,7 @@ while [[ $# -gt 0 ]]; do
     --max|-n)   [ $# -ge 2 ] || error_exit "--max requires a value";   MAX="$2";   shift 2 ;;
     --account)  [ $# -ge 2 ] || error_exit "--account requires a value"; ACCOUNT="$2"; shift 2 ;;
     --help|-h)  print_usage; exit 0 ;;
-    *) error_exit "Unknown option: $1" ;;
+    *) unknown_arg_exit "$1" ;;
   esac
 done
 if [ -n "$INPUT_JSON" ]; then

package/config/skills/agent/core/drive-upload/execute.sh

@@ -68,7 +68,7 @@ while [[ $# -gt 0 ]]; do
     --convert) [ $# -ge 2 ] || error_exit "--convert requires a value"; CONVERT="$2"; shift 2 ;;
     --account)  [ $# -ge 2 ] || error_exit "--account requires a value"; ACCOUNT="$2"; shift 2 ;;
     --help|-h) print_usage; exit 0 ;;
-    *) error_exit "Unknown option: $1" ;;
+    *) unknown_arg_exit "$1" ;;
   esac
 done
 if [ -n "$INPUT_JSON" ]; then

package/config/skills/agent/core/experiment-card/execute.sh

@@ -103,7 +103,7 @@ while [[ $# -gt 0 ]]; do
     --status)        [ $# -ge 2 ] || error_exit "--status requires a value"; STATUS="$2"; shift 2 ;;
     --reason)        [ $# -ge 2 ] || error_exit "--reason requires a value"; REASON="$2"; shift 2 ;;
     --help|-h)       print_usage; exit 0 ;;
-    *) error_exit "Unknown option: $1" ;;
+    *) unknown_arg_exit "$1" ;;
   esac
 done
 

package/config/skills/agent/core/experiment-card/execute.test.sh

@@ -102,7 +102,7 @@ check "measure: not due" "$(run_err measure --id EXP-1 | grep -c 'not due')" "1"
 
 # --- unknown action / option ---
 check "unknown action" "$(run_err frobnicate | grep -c 'Unknown action')" "1"
-check "unknown option" "$(run_err list --nope | grep -c 'Unknown option')" "1"
+check "unknown option" "$(run_err list --nope | grep -c 'Unknown argument')" "1"
 
 echo "experiment-card: $PASS passed, $FAIL failed"
 [ "$FAIL" -eq 0 ]

package/config/skills/agent/core/find-app-template/execute.sh

@@ -37,7 +37,7 @@ while [[ $# -gt 0 ]]; do
     --category) [ $# -ge 2 ] || error_exit "--category requires a value"; CATEGORY="$2"; shift 2 ;;
     --limit)    [ $# -ge 2 ] || error_exit "--limit requires a value"; LIMIT="$2"; shift 2 ;;
     --help|-h)  print_usage; exit 0 ;;
-    *) if [ -z "$QUERY" ] && [ "${1:0:1}" != "-" ]; then QUERY="$1"; shift; else error_exit "Unknown option: $1"; fi ;;
+    *) if [ -z "$QUERY" ] && [ "${1:0:1}" != "-" ]; then QUERY="$1"; shift; else unknown_arg_exit "$1"; fi ;;
   esac
 done
 if [ -n "$INPUT_JSON" ]; then

package/config/skills/agent/core/find-skill/execute.sh

@@ -40,7 +40,7 @@ while [[ $# -gt 0 ]]; do
     --query|-q) [ $# -ge 2 ] || error_exit "--query requires a value"; QUERY="$2"; shift 2 ;;
     --limit)    [ $# -ge 2 ] || error_exit "--limit requires a value"; LIMIT="$2"; shift 2 ;;
     --help|-h)  print_usage; exit 0 ;;
-    *) error_exit "Unknown option: $1" ;;
+    *) unknown_arg_exit "$1" ;;
   esac
 done
 if [ -n "$INPUT_JSON" ]; then

package/config/skills/agent/core/find-skill/execute.test.sh

@@ -63,7 +63,7 @@ check "backend error: message" "$(printf '%s' "$OUT" | jq -r .error)" "registry
 
 check "missing query" "$(run_err)" "Missing required parameter: query (--query)"
 check "bad limit" "$(run_err --query x --limit lots)" "--limit must be a number"
-check "unknown option" "$(run_err --install)" "Unknown option: --install"
+check "unknown option" "$(run_err --install)" "Unknown argument: --install"
 
 echo "=== Results: $PASS passed, $FAIL failed ==="
 [ "$FAIL" -eq 0 ]

package/config/skills/agent/core/get-my-active-work/execute.sh

@@ -77,7 +77,7 @@ while [[ $# -gt 0 ]]; do
         INPUT_JSON="$1"
         shift
       else
-        error_exit "Unknown argument: $1. Use --help for usage."
+        unknown_arg_exit "$1"
       fi
       ;;
   esac

package/config/skills/agent/core/get-my-context/execute.sh

@@ -65,7 +65,7 @@ while [[ $# -gt 0 ]]; do
         INPUT_JSON="$1"
         shift
       else
-        error_exit "Unknown argument: $1. Use --help for usage."
+        unknown_arg_exit "$1"
       fi
       ;;
   esac

package/config/skills/agent/core/get-my-tasks/execute.sh

@@ -59,7 +59,7 @@ while [[ $# -gt 0 ]]; do
         INPUT_JSON="$1"
         shift
       else
-        error_exit "Unknown argument: $1. Use --help for usage."
+        unknown_arg_exit "$1"
       fi
       ;;
   esac

package/config/skills/agent/core/gmail-attachment/execute.sh

@@ -37,7 +37,7 @@ while [[ $# -gt 0 ]]; do
     --out|-o)        [ $# -ge 2 ] || error_exit "--out requires a value"; OUT="$2"; shift 2 ;;
     --account)       [ $# -ge 2 ] || error_exit "--account requires a value"; ACCOUNT="$2"; shift 2 ;;
     --help|-h) print_usage; exit 0 ;;
-    *) error_exit "Unknown option: $1" ;;
+    *) unknown_arg_exit "$1" ;;
   esac
 done
 if [ -n "$INPUT_JSON" ]; then

package/config/skills/agent/core/gmail-read/execute.sh

@@ -39,7 +39,7 @@ while [[ $# -gt 0 ]]; do
     --id|-i)   [ $# -ge 2 ] || error_exit "--id requires a value"; ID="$2"; shift 2 ;;
     --account)  [ $# -ge 2 ] || error_exit "--account requires a value"; ACCOUNT="$2"; shift 2 ;;
     --help|-h) print_usage; exit 0 ;;
-    *) error_exit "Unknown option: $1" ;;
+    *) unknown_arg_exit "$1" ;;
   esac
 done
 

package/config/skills/agent/core/gmail-read/execute.test.sh

@@ -62,7 +62,7 @@ OUT=$(CREWLY_API_URL="http://127.0.0.1:${PORT}" bash "$EXEC" --id no-grant 2>/de
 check "409: hint is the connect URL" "$(printf '%s' "$OUT" | jq -r .hint)" "https://cloud/start?token=j"
 
 check "missing id errors" "$(run_err)" "Missing required parameter: id (--id)"
-check "unknown option errors" "$(run_err --bogus 1)" "Unknown option: --bogus"
+check "unknown option errors" "$(run_err --bogus 1)" "Unknown argument: --bogus"
 
 echo "=== Results: $PASS passed, $FAIL failed ==="
 [ "$FAIL" -eq 0 ]

package/config/skills/agent/core/gmail-search/execute.sh

@@ -43,7 +43,7 @@ while [[ $# -gt 0 ]]; do
     --max|-n)   [ $# -ge 2 ] || error_exit "--max requires a value";   MAX="$2";   shift 2 ;;
     --account)  [ $# -ge 2 ] || error_exit "--account requires a value"; ACCOUNT="$2"; shift 2 ;;
     --help|-h)  print_usage; exit 0 ;;
-    *) error_exit "Unknown option: $1" ;;
+    *) unknown_arg_exit "$1" ;;
   esac
 done
 

package/config/skills/agent/core/gmail-search/execute.test.sh

@@ -61,7 +61,7 @@ check "409: reason + hint" "$OUT" '{"success":false,"reason":"not_connected","hi
 
 # --- validation ---
 check "missing query errors" "$(run_err --max 3)" "Missing required parameter: query (--query)"
-check "unknown option errors" "$(run_err --bogus 1)" "Unknown option: --bogus"
+check "unknown option errors" "$(run_err --bogus 1)" "Unknown argument: --bogus"
 
 echo "=== Results: $PASS passed, $FAIL failed ==="
 [ "$FAIL" -eq 0 ]

package/config/skills/agent/core/gmail-send/execute.sh

@@ -58,7 +58,7 @@ while [[ $# -gt 0 ]]; do
     --dry-run)     DRY_RUN=1; shift ;;
     --account)  [ $# -ge 2 ] || error_exit "--account requires a value"; ACCOUNT="$2"; shift 2 ;;
     --help|-h)     print_usage; exit 0 ;;
-    *) error_exit "Unknown option: $1" ;;
+    *) unknown_arg_exit "$1" ;;
   esac
 done
 

package/config/skills/agent/core/gmail-send/execute.test.sh

@@ -88,7 +88,7 @@ check "missing subject errors" "$(run_err --to a@b.c --text x)" "Missing require
 check "missing text errors" "$(run_err --to a@b.c --subject Hi)" "Missing required parameter: text (--text or --text-file)"
 check "missing text file errors" "$(run_err --to a@b.c --subject Hi --text-file /nonexistent/x.txt)" "text file not found: /nonexistent/x.txt"
 check "validation: no request made" "$(cat "$STUB_LOG")" ""
-check "unknown option errors" "$(run_err --bogus 1)" "Unknown option: --bogus"
+check "unknown option errors" "$(run_err --bogus 1)" "Unknown argument: --bogus"
 
 echo "=== Results: $PASS passed, $FAIL failed ==="
 [ "$FAIL" -eq 0 ]

package/config/skills/agent/core/google-connect/execute.sh

@@ -39,7 +39,7 @@ while [ $# -gt 0 ]; do
     --account) ACCOUNT="${2:-}"; shift 2 ;;
     --resend) shift ;;
     -h|--help) print_usage; exit 0 ;;
-    *) echo "Unknown option: $1" >&2; print_usage >&2; exit 2 ;;
+    *) print_usage >&2; unknown_arg_exit "$1" ;;
   esac
 done
 

package/config/skills/agent/core/install-skill/execute.sh

@@ -48,7 +48,7 @@ while [[ $# -gt 0 ]]; do
     --owner-said)        [ $# -ge 2 ] || error_exit "--owner-said requires a value"; OWNER_SAID="$2"; shift 2 ;;
     --force)             FORCE=true; shift ;;
     --help|-h)           print_usage; exit 0 ;;
-    *) error_exit "Unknown option: $1" ;;
+    *) unknown_arg_exit "$1" ;;
   esac
 done
 if [ -n "$INPUT_JSON" ]; then

package/config/skills/agent/core/install-skill/execute.test.sh

@@ -68,7 +68,7 @@ OUT=$(run --id ready-one)
 check "already ready" "$(printf '%s' "$OUT" | jq -c '{state, executePath}')" '{"state":"already-ready","executePath":"/x/execute.sh"}'
 
 check "missing id" "$(run_err)" "Missing required parameter: id (--id)"
-check "unknown option" "$(run_err --yes)" "Unknown option: --yes"
+check "unknown option" "$(run_err --yes)" "Unknown argument: --yes"
 
 echo "=== Results: $PASS passed, $FAIL failed ==="
 [ "$FAIL" -eq 0 ]

package/config/skills/agent/core/list-channels/execute.sh

@@ -14,7 +14,7 @@ while [[ $# -gt 0 ]]; do
       echo "  Lists the channels you are a member of; --all lists every channel."
       echo "  Post in one with: reply-channel --channel '#name' --content \"...\""
       exit 0 ;;
-    *) echo "Unknown argument: $1" >&2; exit 2 ;;
+    *) unknown_arg_exit "$1" ;;
   esac
 done
 

package/config/skills/agent/core/list-my-crons/execute.sh

@@ -48,8 +48,7 @@ while [[ $# -gt 0 ]]; do
       if [[ -z "$INPUT_JSON" && ${1:0:1} == '{' ]]; then
         INPUT_JSON="$1"; shift
       else
-        echo '{"error":"Unknown argument: '"$1"'"}' >&2
-        exit 1
+        unknown_arg_exit "$1"
       fi
       ;;
   esac

package/config/skills/agent/core/list-my-followups/execute.sh

@@ -48,8 +48,7 @@ while [[ $# -gt 0 ]]; do
       if [[ -z "$INPUT_JSON" && ${1:0:1} == '{' ]]; then
         INPUT_JSON="$1"; shift
       else
-        echo '{"error":"Unknown argument: '"$1"'"}' >&2
-        exit 1
+        unknown_arg_exit "$1"
       fi
       ;;
   esac

package/config/skills/agent/core/project-tickets/execute.sh

@@ -217,7 +217,7 @@ while [[ $# -gt 0 ]]; do
     --skip-labels)   [ $# -ge 2 ] || error_exit "--skip-labels requires a comma-separated list or default"; AP_SKIP="$2"; shift 2 ;;
     --full)          shift ;;
     --help|-h)       print_usage; exit 0 ;;
-    *) error_exit "Unknown option: $1" ;;
+    *) unknown_arg_exit "$1" ;;
   esac
 done
 

package/config/skills/agent/core/publish-app/execute.sh

@@ -137,7 +137,7 @@ while [[ $# -gt 0 ]]; do
     --unlist-template) [ $# -ge 2 ] || error_exit "--unlist-template requires a template id"; UNLIST_TEMPLATE="$2"; shift 2 ;;
     --my-templates)  MY_TEMPLATES=true; shift ;;
     --help|-h)  print_usage; exit 0 ;;
-    *) error_exit "Unknown option: $1" ;;
+    *) unknown_arg_exit "$1" ;;
   esac
 done
 

package/config/skills/agent/core/recall/execute.sh

@@ -57,7 +57,7 @@ while [[ $# -gt 0 ]]; do
         INPUT_JSON="$1"
         shift
       else
-        error_exit "Unknown argument: $1"
+        unknown_arg_exit "$1"
       fi
       ;;
   esac

package/config/skills/agent/core/receive-file/execute.sh

@@ -45,7 +45,7 @@ while [[ $# -gt 0 ]]; do
     --dir)     [ $# -ge 2 ] || error_exit "--dir requires a value"; DIR="$2"; shift 2 ;;
     --no-ack)  ACK=0; shift ;;
     --help|-h) print_usage; exit 0 ;;
-    *) error_exit "Unknown option: $1" ;;
+    *) unknown_arg_exit "$1" ;;
   esac
 done
 [ -n "$ID" ] || error_exit "--id is required"

package/config/skills/agent/core/record-learning/execute.sh

@@ -90,7 +90,7 @@ EOF
         INPUT_JSON="$1"
         shift
       else
-        error_exit "Unknown argument: $1"
+        unknown_arg_exit "$1"
       fi
       ;;
   esac

package/config/skills/agent/core/record-prediction/execute.sh

@@ -53,7 +53,7 @@ while [[ $# -gt 0 ]]; do
       [ $# -ge 2 ] || error_exit "--session requires a value"
       SESSION_NAME="$2"; shift 2 ;;
     --help|-h) print_usage; exit 0 ;;
-    *) error_exit "Unknown option: $1" ;;
+    *) unknown_arg_exit "$1" ;;
   esac
 done
 

package/config/skills/agent/core/register-self/execute.sh

@@ -71,7 +71,7 @@ while [[ $# -gt 0 ]]; do
         INPUT_JSON="$1"
         shift
       else
-        error_exit "Unknown argument: $1. Use --help for usage."
+        unknown_arg_exit "$1"
       fi
       ;;
   esac

package/config/skills/agent/core/remember/execute.sh

@@ -99,7 +99,7 @@ while [[ $# -gt 0 ]]; do
         INPUT_JSON="$1"
         shift
       else
-        error_exit "Unknown argument: $1. Use --help for usage."
+        unknown_arg_exit "$1"
       fi
       ;;
   esac

package/config/skills/agent/core/reply/SKILL.md

@@ -91,6 +91,11 @@ bash config/skills/agent/core/reply/execute.sh --new-thread "Wiki link audit" "F
 Keep the `CREWLY_SESSION_NAME=<you>` prefix when your prompt shows one — it
 tells the system that you are the one replying.
 
+**Text with double quotes or several lines:** pipe it on stdin
+(`cat <<'EOF' | bash .../reply/execute.sh` ... `EOF`) instead of a quoted
+argument -- a stray `"` splits the text and nothing is sent. Check for
+`"success":true` in the output; do not cut it off with `| tail -1`.
+
 ## Options
 
 | Flag | What it does |

package/config/skills/agent/core/reply/execute.sh

@@ -84,7 +84,7 @@ while [[ $# -gt 0 ]]; do
     --ack) ACK="1"; shift ;;
     --help|-h) print_usage; exit 0 ;;
     --) shift; if [[ $# -gt 0 && -z "$TEXT" ]]; then TEXT="$*"; fi; break ;;
-    -*) echo "{\"success\":false,\"error\":\"Unknown option: $1\"}" >&2; print_usage >&2; exit 2 ;;
+    -*) print_usage >&2; unknown_arg_exit "$1" ;;
     *) if [ -z "$TEXT" ]; then TEXT="$1"; else TEXT="$TEXT $1"; fi; shift ;;
   esac
 done