crewly 1.13.1 → 1.14.1

package/dist/cli/backend/src/services/chat-v2/chat-v2.dispatcher.service.js

@@ -0,0 +1,420 @@
+/**
+ * ChatV2DispatcherService — deliver user-origin chat messages to the
+ * bound agent session.
+ *
+ * Flow:
+ *   HTTP POST /api/chat/channels/:id/messages
+ *     → ChatV2Service.sendMessage (persist + dedupe)
+ *     → controller broadcasts WS message frame (user bubble)
+ *     → controller calls ChatV2Dispatcher.dispatchToAgent(channel, messageDTO)
+ *     → sendMessageToAgent(agent_session, "[CHAT:<id>] <content>\n<hint>")
+ *     → agent processes + calls `reply-chat` skill
+ *     → skill POSTs back to /api/chat/channels/:id/messages as the agent
+ *     → same controller path → WS message frame (agent bubble)
+ *
+ * This service is intentionally thin — a couple of dozen lines of glue
+ * around the AgentRegistrationService's `sendMessageToAgent` primitive.
+ * The dispatch prompt is extracted so tests can assert the format, which
+ * is the contract the `reply-chat` skill relies on.
+ *
+ * @module services/chat-v2/chat-v2.dispatcher.service
+ */
+import { LoggerService } from '../core/logger.service.js';
+// ---------------------------------------------------------------------------
+// Prompt formatter
+// ---------------------------------------------------------------------------
+/**
+ * Default prompt formatter the agent sees when a user sends in their
+ * chat channel.
+ *
+ * Format is intentionally stable and tag-prefixed so the `reply-chat`
+ * skill (and future tooling) can reliably extract the channelId without
+ * regex ambiguity. The `回复:` hint line gives the agent a one-step
+ * instruction on how to reply.
+ */
+export function defaultFormatPrompt(args) {
+    const { channelId, channelName, senderId, content, clientMessageId, responseMode, threadId, replyVia } = args;
+    const trimmed = content.trim();
+    const idHint = clientMessageId ? ` [cmid:${clientMessageId}]` : '';
+    // Default to "required" so DM and single-mention channel dispatches
+    // preserve the legacy "must reply" semantic. Only huddles flip this
+    // to "optional" for non-@'d members.
+    const mode = responseMode ?? 'required';
+    let replyHint;
+    if (replyVia === 'reply-channel') {
+        // Slack team channel: reply as yourself into the channel, in-thread.
+        const cmd = `bash config/skills/agent/core/reply-channel/execute.sh --channel ${channelId}${threadId ? ` --thread ${threadId}` : ''} --content "<your reply>"`;
+        replyHint = mode === 'optional'
+            ? `回复本频道: 这是团队频道，你收到此消息但未被 @ — 如有必要用 \`reply-channel\` skill 回复（${cmd}），否则不回复也可以。`
+            : `回复本频道: 用 \`reply-channel\` skill（${cmd}）。回复会以你的名字发到 Slack 同一个 thread。`;
+    }
+    else {
+        replyHint = mode === 'optional'
+            ? `回复本频道: 你在此 huddle 中收到此消息但未被 @ — 如有必要可用 \`reply-chat\` skill (conversationId="${channelId}") 回复，否则不回复也可以。`
+            : `回复本频道: 用 \`reply-chat\` skill, 参数 conversationId="${channelId}"、content="<your reply>"。`;
+    }
+    return [
+        `[CHAT:${channelId}]${idHint} <${senderId}@${channelName}>`,
+        ``,
+        trimmed,
+        ``,
+        `---`,
+        replyHint,
+    ].join('\n');
+}
+// ---------------------------------------------------------------------------
+// Service
+// ---------------------------------------------------------------------------
+/**
+ * Dispatches user-origin chat messages to the agent session bound to the
+ * channel. Invoked from the chat controller after `ChatV2Service.sendMessage`
+ * returns.
+ */
+export class ChatV2DispatcherService {
+    agentSink;
+    formatPrompt;
+    mentionResolver;
+    huddleMembersFor;
+    activateAgent;
+    logger;
+    constructor(options) {
+        this.agentSink = options.agentSink;
+        this.formatPrompt = options.formatPrompt ?? defaultFormatPrompt;
+        this.mentionResolver = options.mentionResolver;
+        this.huddleMembersFor = options.huddleMembersFor;
+        this.activateAgent = options.activateAgent;
+        this.logger = LoggerService.getInstance().createComponentLogger('ChatV2Dispatcher');
+    }
+    /**
+     * Phase C BE.3 entry point — choose the routing strategy from
+     * `channel.type` and the message's mentions, then fan out.
+     *
+     * Routing rules (SEALED §2.1):
+     *   - `type='dm'` → existing 1:1 path via `dispatchToAgent`. Mentions
+     *     in DMs are advisory only (the channel already binds to one
+     *     agent); the dispatcher does not currently re-route them.
+     *   - `type='channel'` → resolve `message.mentions` via the injected
+     *     `mentionResolver`, then dispatch the formatted prompt to each
+     *     resolved sessionName. No mentions → no dispatch (the message
+     *     still persists; nobody is paged).
+     *   - Agent-origin messages always skip dispatch (no self-loopback).
+     *
+     * Always resolves; per-recipient errors are captured in
+     * {@link DispatchMessageResult.mentionOutcomes} and never thrown.
+     *
+     * @param channel - The channel DTO (provides `type`, name, agentSession).
+     * @param message - The persisted message DTO (provides senderType, mentions).
+     * @returns Aggregate result describing the strategy + outcomes.
+     */
+    async dispatchMessage(channel, message, options = {}) {
+        if (message.senderType !== 'user') {
+            return {
+                strategy: 'skip',
+                dispatched: false,
+                reason: 'not a user-origin message',
+            };
+        }
+        if (channel.type === 'channel') {
+            return this.dispatchChannelMentions(channel, message);
+        }
+        if (channel.type === 'huddle') {
+            return this.dispatchHuddleBroadcast(channel, message, options);
+        }
+        // Default to the DM path for any other type (including legacy /
+        // missing — `type` is non-null after Phase A migration but defensive
+        // here keeps the dispatcher robust).
+        const dmResult = await this.dispatchToAgent(channel, message);
+        return {
+            strategy: 'dm',
+            dispatched: dmResult.dispatched,
+            dmResult,
+        };
+    }
+    /**
+     * Phase B-2 — fan a user message out to every member of a huddle.
+     *
+     * Resolution path:
+     *   1. Look up the roster via the injected `huddleMembersFor`. No
+     *      resolver wired → return `strategy: 'skip'` (the message still
+     *      persists; nobody is paged).
+     *   2. Empty roster → same skip path. Should not happen since
+     *      `createHuddle` rejects empty membership, but defensive.
+     *   3. For each member, derive `responseMode` from whether their
+     *      session appears in `message.mentions[]`. Format the prompt
+     *      accordingly and call `sendMessageToAgent`.
+     *
+     * Always resolves; per-member errors are captured in
+     * {@link DispatchMessageResult.huddleOutcomes} and never thrown.
+     *
+     * @param channel - The huddle channel.
+     * @param message - The persisted user message.
+     * @returns Aggregate result with one outcome per member.
+     */
+    async dispatchHuddleBroadcast(channel, message, options = {}) {
+        if (!this.huddleMembersFor) {
+            this.logger.debug('chat-v2 huddle dispatch skipped — no roster lookup wired', {
+                channelId: channel.id,
+                messageId: message.id,
+            });
+            return {
+                strategy: 'skip',
+                dispatched: false,
+                reason: 'no huddleMembersFor resolver wired',
+            };
+        }
+        const members = this.huddleMembersFor(channel.id);
+        if (members.length === 0) {
+            return {
+                strategy: 'skip',
+                dispatched: false,
+                reason: 'huddle has no members',
+            };
+        }
+        // Pre-build the mention set so each member lookup is O(1). The
+        // wire mention is the agent session id (same shape as the roster
+        // entries) so a simple Set membership check is enough.
+        const mentioned = new Set(Array.isArray(message.mentions) ? message.mentions : []);
+        const outcomes = [];
+        let anyDispatched = false;
+        for (const sessionName of members) {
+            const responseMode = mentioned.has(sessionName) ? 'required' : 'optional';
+            const prompt = this.formatPrompt({
+                channelId: channel.id,
+                channelName: channel.name,
+                agentSession: sessionName,
+                senderId: message.senderId,
+                content: message.content,
+                clientMessageId: typeof message.metadata?.clientMessageId === 'string'
+                    ? message.metadata.clientMessageId
+                    : undefined,
+                responseMode,
+                threadId: options.threadId,
+                replyVia: options.replyVia,
+            });
+            try {
+                const result = await this.agentSink.sendMessageToAgent(sessionName, prompt);
+                if (result.success) {
+                    outcomes.push({ sessionName, responseMode, dispatched: true });
+                    anyDispatched = true;
+                }
+                else {
+                    this.logger.warn('chat-v2 huddle dispatch reported failure', {
+                        channelId: channel.id,
+                        sessionName,
+                        err: result.error,
+                    });
+                    outcomes.push({
+                        sessionName,
+                        responseMode,
+                        dispatched: false,
+                        error: result.error ?? 'unknown sink failure',
+                    });
+                }
+            }
+            catch (err) {
+                const errMsg = err instanceof Error ? err.message : String(err);
+                this.logger.error('chat-v2 huddle dispatch threw', {
+                    channelId: channel.id,
+                    sessionName,
+                    err: errMsg,
+                });
+                outcomes.push({ sessionName, responseMode, dispatched: false, error: errMsg });
+            }
+        }
+        return {
+            strategy: 'huddle-broadcast',
+            dispatched: anyDispatched,
+            huddleOutcomes: outcomes,
+        };
+    }
+    /**
+     * Dispatch a `type='channel'` message to its resolved mentions.
+     *
+     * Skips entirely when:
+     *   - No mention resolver is wired (return strategy=skip).
+     *   - `mentions` is empty (return strategy=skip).
+     *   - The resolver returns no targets (return strategy=channel-mentions
+     *     with empty `mentionOutcomes`; `dispatched=false`).
+     *
+     * @param channel - The team channel.
+     * @param message - The persisted user message.
+     * @returns Aggregate result with one outcome per resolved recipient.
+     */
+    async dispatchChannelMentions(channel, message) {
+        if (!this.mentionResolver) {
+            this.logger.debug('chat-v2 dispatch skipped — no mention resolver wired', {
+                channelId: channel.id,
+                messageId: message.id,
+            });
+            return {
+                strategy: 'skip',
+                dispatched: false,
+                reason: 'no mention resolver wired for type=channel',
+            };
+        }
+        const mentions = Array.isArray(message.mentions) ? message.mentions : [];
+        if (mentions.length === 0) {
+            return {
+                strategy: 'skip',
+                dispatched: false,
+                reason: 'no mentions on type=channel message',
+            };
+        }
+        const ctx = { teamId: channel.teamId };
+        const targets = await this.mentionResolver.resolve(mentions, ctx);
+        const outcomes = [];
+        let anyDispatched = false;
+        for (const target of targets) {
+            const prompt = this.formatPrompt({
+                channelId: channel.id,
+                channelName: channel.name,
+                agentSession: target.sessionName,
+                senderId: message.senderId,
+                content: message.content,
+                clientMessageId: typeof message.metadata?.clientMessageId === 'string'
+                    ? message.metadata.clientMessageId
+                    : undefined,
+            });
+            try {
+                const result = await this.agentSink.sendMessageToAgent(target.sessionName, prompt);
+                if (result.success) {
+                    outcomes.push({ target, dispatched: true });
+                    anyDispatched = true;
+                }
+                else {
+                    this.logger.warn('chat-v2 mention dispatch reported failure', {
+                        channelId: channel.id,
+                        sessionName: target.sessionName,
+                        err: result.error,
+                    });
+                    outcomes.push({
+                        target,
+                        dispatched: false,
+                        error: result.error ?? 'unknown sink failure',
+                    });
+                }
+            }
+            catch (err) {
+                const errMsg = err instanceof Error ? err.message : String(err);
+                this.logger.error('chat-v2 mention dispatch threw', {
+                    channelId: channel.id,
+                    sessionName: target.sessionName,
+                    err: errMsg,
+                });
+                outcomes.push({ target, dispatched: false, error: errMsg });
+            }
+        }
+        return {
+            strategy: 'channel-mentions',
+            dispatched: anyDispatched,
+            mentionOutcomes: outcomes,
+        };
+    }
+    /**
+     * Push a newly-persisted user message to the agent.
+     *
+     * Dispatch is fire-and-forget at the API-response level (the HTTP 201 has
+     * already been serialized), but we still await the write so tests can
+     * observe the outcome and the logger can record failures.
+     *
+     * Messages where `senderType !== "user"` are a no-op — we never loop an
+     * agent's own reply back into its own PTY.
+     *
+     * @deprecated Issue #334 — `dispatchToAgent` is the legacy 1:1 entry
+     * point. New callers MUST go through `dispatchMessage`, which routes
+     * type='dm' messages here and adds the type='channel' (@mentions /
+     * @team) path. Direct callers of `dispatchToAgent` silently bypass
+     * the mention-resolution layer.
+     *
+     * Conversion: replace `dispatchToAgent(channel, message)` with
+     * `dispatchMessage(channel, message)` and read the `dmResult` field
+     * of the returned object. See chat-v2.dispatcher.service.ts:dispatchMessage
+     * for the contract.
+     *
+     * @param channel - Channel DTO (provides `agentSession` + display name)
+     * @param message - Persisted message DTO
+     */
+    async dispatchToAgent(channel, message) {
+        if (message.senderType !== 'user') {
+            return { dispatched: false, error: 'not a user-origin message' };
+        }
+        if (!channel.agentSession) {
+            this.logger.warn('chat-v2 dispatch skipped — no agentSession', {
+                channelId: channel.id,
+            });
+            return { dispatched: false, error: 'channel has no bound agent' };
+        }
+        const prompt = this.formatPrompt({
+            channelId: channel.id,
+            channelName: channel.name,
+            agentSession: channel.agentSession,
+            senderId: message.senderId,
+            content: message.content,
+            clientMessageId: typeof message.metadata?.clientMessageId === 'string'
+                ? message.metadata.clientMessageId
+                : undefined,
+        });
+        let result;
+        try {
+            result = await this.agentSink.sendMessageToAgent(channel.agentSession, prompt);
+        }
+        catch (err) {
+            const errMsg = err instanceof Error ? err.message : String(err);
+            this.logger.error('chat-v2 dispatch threw', {
+                channelId: channel.id,
+                agentSession: channel.agentSession,
+                err: errMsg,
+            });
+            return { dispatched: false, error: errMsg };
+        }
+        if (!result.success) {
+            // Auto-activate on send: the agent's session doesn't exist (inactive).
+            // When an activation hook is wired, start the agent and retry delivery
+            // once — so messaging an offline agent wakes it and delivers, instead
+            // of silently queueing. This is user-initiated, so it bypasses the
+            // orchestrator wake-gate by design.
+            if (this.activateAgent) {
+                this.logger.info('chat-v2 dispatch: agent inactive — activating on send', {
+                    channelId: channel.id,
+                    agentSession: channel.agentSession,
+                });
+                let activated = false;
+                try {
+                    activated = await this.activateAgent(channel.agentSession);
+                }
+                catch (err) {
+                    this.logger.warn('chat-v2 activate-on-send failed', {
+                        agentSession: channel.agentSession,
+                        err: err instanceof Error ? err.message : String(err),
+                    });
+                }
+                if (activated) {
+                    try {
+                        result = await this.agentSink.sendMessageToAgent(channel.agentSession, prompt);
+                    }
+                    catch (err) {
+                        return {
+                            dispatched: false,
+                            error: err instanceof Error ? err.message : String(err),
+                        };
+                    }
+                }
+            }
+            if (!result.success) {
+                this.logger.warn('chat-v2 dispatch reported failure', {
+                    channelId: channel.id,
+                    agentSession: channel.agentSession,
+                    err: result.error,
+                });
+                return { dispatched: false, error: result.error ?? 'unknown sink failure' };
+            }
+        }
+        this.logger.debug('chat-v2 dispatched', {
+            channelId: channel.id,
+            agentSession: channel.agentSession,
+            queued: result.queued ?? false,
+        });
+        return { dispatched: true };
+    }
+}
+//# sourceMappingURL=chat-v2.dispatcher.service.js.map

package/dist/cli/backend/src/services/chat-v2/chat-v2.dispatcher.service.js.map

@@ -0,0 +1 @@
+{"version":3,"file":"chat-v2.dispatcher.service.js","sourceRoot":"","sources":["../../../../../../backend/src/services/chat-v2/chat-v2.dispatcher.service.ts"],"names":[],"mappings":"AAAA;;;;;;;;;;;;;;;;;;;;GAoBG;AAQH,OAAO,EAAE,aAAa,EAAmB,MAAM,2BAA2B,CAAC;AA8K3E,8EAA8E;AAC9E,mBAAmB;AACnB,8EAA8E;AAE9E;;;;;;;;GAQG;AACH,MAAM,UAAU,mBAAmB,CAAC,IAAsB;IACxD,MAAM,EAAE,SAAS,EAAE,WAAW,EAAE,QAAQ,EAAE,OAAO,EAAE,eAAe,EAAE,YAAY,EAAE,QAAQ,EAAE,QAAQ,EAAE,GAAG,IAAI,CAAC;IAC9G,MAAM,OAAO,GAAG,OAAO,CAAC,IAAI,EAAE,CAAC;IAC/B,MAAM,MAAM,GAAG,eAAe,CAAC,CAAC,CAAC,UAAU,eAAe,GAAG,CAAC,CAAC,CAAC,EAAE,CAAC;IACnE,oEAAoE;IACpE,oEAAoE;IACpE,qCAAqC;IACrC,MAAM,IAAI,GAAG,YAAY,IAAI,UAAU,CAAC;IACxC,IAAI,SAAiB,CAAC;IACtB,IAAI,QAAQ,KAAK,eAAe,EAAE,CAAC;QACjC,qEAAqE;QACrE,MAAM,GAAG,GAAG,oEAAoE,SAAS,GAAG,QAAQ,CAAC,CAAC,CAAC,aAAa,QAAQ,EAAE,CAAC,CAAC,CAAC,EAAE,2BAA2B,CAAC;QAC/J,SAAS,GAAG,IAAI,KAAK,UAAU;YAC7B,CAAC,CAAC,gEAAgE,GAAG,aAAa;YAClF,CAAC,CAAC,oCAAoC,GAAG,gCAAgC,CAAC;IAC9E,CAAC;SAAM,CAAC;QACN,SAAS,GAAG,IAAI,KAAK,UAAU;YAC7B,CAAC,CAAC,gFAAgF,SAAS,iBAAiB;YAC5G,CAAC,CAAC,qDAAqD,SAAS,2BAA2B,CAAC;IAChG,CAAC;IACD,OAAO;QACL,SAAS,SAAS,IAAI,MAAM,KAAK,QAAQ,IAAI,WAAW,GAAG;QAC3D,EAAE;QACF,OAAO;QACP,EAAE;QACF,KAAK;QACL,SAAS;KACV,CAAC,IAAI,CAAC,IAAI,CAAC,CAAC;AACf,CAAC;AAED,8EAA8E;AAC9E,UAAU;AACV,8EAA8E;AAE9E;;;;GAIG;AACH,MAAM,OAAO,uBAAuB;IACjB,SAAS,CAAmB;IAC5B,YAAY,CAAqC;IACjD,eAAe,CAAyB;IACxC,gBAAgB,CAA4C;IAC5D,aAAa,CAA8C;IAC3D,MAAM,CAAkB;IAEzC,YAAY,OAAgC;QAC1C,IAAI,CAAC,SAAS,GAAG,OAAO,CAAC,SAAS,CAAC;QACnC,IAAI,CAAC,YAAY,GAAG,OAAO,CAAC,YAAY,IAAI,mBAAmB,CAAC;QAChE,IAAI,CAAC,eAAe,GAAG,OAAO,CAAC,eAAe,CAAC;QAC/C,IAAI,CAAC,gBAAgB,GAAG,OAAO,CAAC,gBAAgB,CAAC;QACjD,IAAI,CAAC,aAAa,GAAG,OAAO,CAAC,aAAa,CAAC;QAC3C,IAAI,CAAC,MAAM,GAAG,aAAa,CAAC,WAAW,EAAE,CAAC,qBAAqB,CAAC,kBAAkB,CAAC,CAAC;IACtF,CAAC;IAED;;;;;;;;;;;;;;;;;;;;OAoBG;IACH,KAAK,CAAC,eAAe,CACnB,OAAuB,EACvB,OAAuB,EACvB,UAAkC,EAAE;QAEpC,IAAI,OAAO,CAAC,UAAU,KAAK,MAAM,EAAE,CAAC;YAClC,OAAO;gBACL,QAAQ,EAAE,MAAM;gBAChB,UAAU,EAAE,KAAK;gBACjB,MAAM,EAAE,2BAA2B;aACpC,CAAC;QACJ,CAAC;QAED,IAAI,OAAO,CAAC,IAAI,KAAK,SAAS,EAAE,CAAC;YAC/B,OAAO,IAAI,CAAC,uBAAuB,CAAC,OAAO,EAAE,OAAO,CAAC,CAAC;QACxD,CAAC;QAED,IAAI,OAAO,CAAC,IAAI,KAAK,QAAQ,EAAE,CAAC;YAC9B,OAAO,IAAI,CAAC,uBAAuB,CAAC,OAAO,EAAE,OAAO,EAAE,OAAO,CAAC,CAAC;QACjE,CAAC;QAED,gEAAgE;QAChE,qEAAqE;QACrE,qCAAqC;QACrC,MAAM,QAAQ,GAAG,MAAM,IAAI,CAAC,eAAe,CAAC,OAAO,EAAE,OAAO,CAAC,CAAC;QAC9D,OAAO;YACL,QAAQ,EAAE,IAAI;YACd,UAAU,EAAE,QAAQ,CAAC,UAAU;YAC/B,QAAQ;SACT,CAAC;IACJ,CAAC;IAED;;;;;;;;;;;;;;;;;;;OAmBG;IACK,KAAK,CAAC,uBAAuB,CACnC,OAAuB,EACvB,OAAuB,EACvB,UAAkC,EAAE;QAEpC,IAAI,CAAC,IAAI,CAAC,gBAAgB,EAAE,CAAC;YAC3B,IAAI,CAAC,MAAM,CAAC,KAAK,CAAC,0DAA0D,EAAE;gBAC5E,SAAS,EAAE,OAAO,CAAC,EAAE;gBACrB,SAAS,EAAE,OAAO,CAAC,EAAE;aACtB,CAAC,CAAC;YACH,OAAO;gBACL,QAAQ,EAAE,MAAM;gBAChB,UAAU,EAAE,KAAK;gBACjB,MAAM,EAAE,oCAAoC;aAC7C,CAAC;QACJ,CAAC;QAED,MAAM,OAAO,GAAG,IAAI,CAAC,gBAAgB,CAAC,OAAO,CAAC,EAAE,CAAC,CAAC;QAClD,IAAI,OAAO,CAAC,MAAM,KAAK,CAAC,EAAE,CAAC;YACzB,OAAO;gBACL,QAAQ,EAAE,MAAM;gBAChB,UAAU,EAAE,KAAK;gBACjB,MAAM,EAAE,uBAAuB;aAChC,CAAC;QACJ,CAAC;QAED,+DAA+D;QAC/D,iEAAiE;QACjE,uDAAuD;QACvD,MAAM,SAAS,GAAG,IAAI,GAAG,CAAC,KAAK,CAAC,OAAO,CAAC,OAAO,CAAC,QAAQ,CAAC,CAAC,CAAC,CAAC,OAAO,CAAC,QAAQ,CAAC,CAAC,CAAC,EAAE,CAAC,CAAC;QAEnF,MAAM,QAAQ,GAA4B,EAAE,CAAC;QAC7C,IAAI,aAAa,GAAG,KAAK,CAAC;QAE1B,KAAK,MAAM,WAAW,IAAI,OAAO,EAAE,CAAC;YAClC,MAAM,YAAY,GAA4B,SAAS,CAAC,GAAG,CAAC,WAAW,CAAC,CAAC,CAAC,CAAC,UAAU,CAAC,CAAC,CAAC,UAAU,CAAC;YACnG,MAAM,MAAM,GAAG,IAAI,CAAC,YAAY,CAAC;gBAC/B,SAAS,EAAE,OAAO,CAAC,EAAE;gBACrB,WAAW,EAAE,OAAO,CAAC,IAAI;gBACzB,YAAY,EAAE,WAAW;gBACzB,QAAQ,EAAE,OAAO,CAAC,QAAQ;gBAC1B,OAAO,EAAE,OAAO,CAAC,OAAO;gBACxB,eAAe,EACb,OAAO,OAAO,CAAC,QAAQ,EAAE,eAAe,KAAK,QAAQ;oBACnD,CAAC,CAAE,OAAO,CAAC,QAAQ,CAAC,eAA0B;oBAC9C,CAAC,CAAC,SAAS;gBACf,YAAY;gBACZ,QAAQ,EAAE,OAAO,CAAC,QAAQ;gBAC1B,QAAQ,EAAE,OAAO,CAAC,QAAQ;aAC3B,CAAC,CAAC;YAEH,IAAI,CAAC;gBACH,MAAM,MAAM,GAAG,MAAM,IAAI,CAAC,SAAS,CAAC,kBAAkB,CAAC,WAAW,EAAE,MAAM,CAAC,CAAC;gBAC5E,IAAI,MAAM,CAAC,OAAO,EAAE,CAAC;oBACnB,QAAQ,CAAC,IAAI,CAAC,EAAE,WAAW,EAAE,YAAY,EAAE,UAAU,EAAE,IAAI,EAAE,CAAC,CAAC;oBAC/D,aAAa,GAAG,IAAI,CAAC;gBACvB,CAAC;qBAAM,CAAC;oBACN,IAAI,CAAC,MAAM,CAAC,IAAI,CAAC,0CAA0C,EAAE;wBAC3D,SAAS,EAAE,OAAO,CAAC,EAAE;wBACrB,WAAW;wBACX,GAAG,EAAE,MAAM,CAAC,KAAK;qBAClB,CAAC,CAAC;oBACH,QAAQ,CAAC,IAAI,CAAC;wBACZ,WAAW;wBACX,YAAY;wBACZ,UAAU,EAAE,KAAK;wBACjB,KAAK,EAAE,MAAM,CAAC,KAAK,IAAI,sBAAsB;qBAC9C,CAAC,CAAC;gBACL,CAAC;YACH,CAAC;YAAC,OAAO,GAAG,EAAE,CAAC;gBACb,MAAM,MAAM,GAAG,GAAG,YAAY,KAAK,CAAC,CAAC,CAAC,GAAG,CAAC,OAAO,CAAC,CAAC,CAAC,MAAM,CAAC,GAAG,CAAC,CAAC;gBAChE,IAAI,CAAC,MAAM,CAAC,KAAK,CAAC,+BAA+B,EAAE;oBACjD,SAAS,EAAE,OAAO,CAAC,EAAE;oBACrB,WAAW;oBACX,GAAG,EAAE,MAAM;iBACZ,CAAC,CAAC;gBACH,QAAQ,CAAC,IAAI,CAAC,EAAE,WAAW,EAAE,YAAY,EAAE,UAAU,EAAE,KAAK,EAAE,KAAK,EAAE,MAAM,EAAE,CAAC,CAAC;YACjF,CAAC;QACH,CAAC;QAED,OAAO;YACL,QAAQ,EAAE,kBAAkB;YAC5B,UAAU,EAAE,aAAa;YACzB,cAAc,EAAE,QAAQ;SACzB,CAAC;IACJ,CAAC;IAED;;;;;;;;;;;;OAYG;IACK,KAAK,CAAC,uBAAuB,CACnC,OAAuB,EACvB,OAAuB;QAEvB,IAAI,CAAC,IAAI,CAAC,eAAe,EAAE,CAAC;YAC1B,IAAI,CAAC,MAAM,CAAC,KAAK,CAAC,sDAAsD,EAAE;gBACxE,SAAS,EAAE,OAAO,CAAC,EAAE;gBACrB,SAAS,EAAE,OAAO,CAAC,EAAE;aACtB,CAAC,CAAC;YACH,OAAO;gBACL,QAAQ,EAAE,MAAM;gBAChB,UAAU,EAAE,KAAK;gBACjB,MAAM,EAAE,4CAA4C;aACrD,CAAC;QACJ,CAAC;QAED,MAAM,QAAQ,GAAG,KAAK,CAAC,OAAO,CAAC,OAAO,CAAC,QAAQ,CAAC,CAAC,CAAC,CAAC,OAAO,CAAC,QAAQ,CAAC,CAAC,CAAC,EAAE,CAAC;QACzE,IAAI,QAAQ,CAAC,MAAM,KAAK,CAAC,EAAE,CAAC;YAC1B,OAAO;gBACL,QAAQ,EAAE,MAAM;gBAChB,UAAU,EAAE,KAAK;gBACjB,MAAM,EAAE,qCAAqC;aAC9C,CAAC;QACJ,CAAC;QAED,MAAM,GAAG,GAA2B,EAAE,MAAM,EAAE,OAAO,CAAC,MAAM,EAAE,CAAC;QAC/D,MAAM,OAAO,GAAG,MAAM,IAAI,CAAC,eAAe,CAAC,OAAO,CAAC,QAAQ,EAAE,GAAG,CAAC,CAAC;QAElE,MAAM,QAAQ,GAA6B,EAAE,CAAC;QAC9C,IAAI,aAAa,GAAG,KAAK,CAAC;QAE1B,KAAK,MAAM,MAAM,IAAI,OAAO,EAAE,CAAC;YAC7B,MAAM,MAAM,GAAG,IAAI,CAAC,YAAY,CAAC;gBAC/B,SAAS,EAAE,OAAO,CAAC,EAAE;gBACrB,WAAW,EAAE,OAAO,CAAC,IAAI;gBACzB,YAAY,EAAE,MAAM,CAAC,WAAW;gBAChC,QAAQ,EAAE,OAAO,CAAC,QAAQ;gBAC1B,OAAO,EAAE,OAAO,CAAC,OAAO;gBACxB,eAAe,EACb,OAAO,OAAO,CAAC,QAAQ,EAAE,eAAe,KAAK,QAAQ;oBACnD,CAAC,CAAE,OAAO,CAAC,QAAQ,CAAC,eAA0B;oBAC9C,CAAC,CAAC,SAAS;aAChB,CAAC,CAAC;YAEH,IAAI,CAAC;gBACH,MAAM,MAAM,GAAG,MAAM,IAAI,CAAC,SAAS,CAAC,kBAAkB,CAAC,MAAM,CAAC,WAAW,EAAE,MAAM,CAAC,CAAC;gBACnF,IAAI,MAAM,CAAC,OAAO,EAAE,CAAC;oBACnB,QAAQ,CAAC,IAAI,CAAC,EAAE,MAAM,EAAE,UAAU,EAAE,IAAI,EAAE,CAAC,CAAC;oBAC5C,aAAa,GAAG,IAAI,CAAC;gBACvB,CAAC;qBAAM,CAAC;oBACN,IAAI,CAAC,MAAM,CAAC,IAAI,CAAC,2CAA2C,EAAE;wBAC5D,SAAS,EAAE,OAAO,CAAC,EAAE;wBACrB,WAAW,EAAE,MAAM,CAAC,WAAW;wBAC/B,GAAG,EAAE,MAAM,CAAC,KAAK;qBAClB,CAAC,CAAC;oBACH,QAAQ,CAAC,IAAI,CAAC;wBACZ,MAAM;wBACN,UAAU,EAAE,KAAK;wBACjB,KAAK,EAAE,MAAM,CAAC,KAAK,IAAI,sBAAsB;qBAC9C,CAAC,CAAC;gBACL,CAAC;YACH,CAAC;YAAC,OAAO,GAAG,EAAE,CAAC;gBACb,MAAM,MAAM,GAAG,GAAG,YAAY,KAAK,CAAC,CAAC,CAAC,GAAG,CAAC,OAAO,CAAC,CAAC,CAAC,MAAM,CAAC,GAAG,CAAC,CAAC;gBAChE,IAAI,CAAC,MAAM,CAAC,KAAK,CAAC,gCAAgC,EAAE;oBAClD,SAAS,EAAE,OAAO,CAAC,EAAE;oBACrB,WAAW,EAAE,MAAM,CAAC,WAAW;oBAC/B,GAAG,EAAE,MAAM;iBACZ,CAAC,CAAC;gBACH,QAAQ,CAAC,IAAI,CAAC,EAAE,MAAM,EAAE,UAAU,EAAE,KAAK,EAAE,KAAK,EAAE,MAAM,EAAE,CAAC,CAAC;YAC9D,CAAC;QACH,CAAC;QAED,OAAO;YACL,QAAQ,EAAE,kBAAkB;YAC5B,UAAU,EAAE,aAAa;YACzB,eAAe,EAAE,QAAQ;SAC1B,CAAC;IACJ,CAAC;IAED;;;;;;;;;;;;;;;;;;;;;;;OAuBG;IACH,KAAK,CAAC,eAAe,CACnB,OAAuB,EACvB,OAAuB;QAEvB,IAAI,OAAO,CAAC,UAAU,KAAK,MAAM,EAAE,CAAC;YAClC,OAAO,EAAE,UAAU,EAAE,KAAK,EAAE,KAAK,EAAE,2BAA2B,EAAE,CAAC;QACnE,CAAC;QACD,IAAI,CAAC,OAAO,CAAC,YAAY,EAAE,CAAC;YAC1B,IAAI,CAAC,MAAM,CAAC,IAAI,CAAC,4CAA4C,EAAE;gBAC7D,SAAS,EAAE,OAAO,CAAC,EAAE;aACtB,CAAC,CAAC;YACH,OAAO,EAAE,UAAU,EAAE,KAAK,EAAE,KAAK,EAAE,4BAA4B,EAAE,CAAC;QACpE,CAAC;QAED,MAAM,MAAM,GAAG,IAAI,CAAC,YAAY,CAAC;YAC/B,SAAS,EAAE,OAAO,CAAC,EAAE;YACrB,WAAW,EAAE,OAAO,CAAC,IAAI;YACzB,YAAY,EAAE,OAAO,CAAC,YAAY;YAClC,QAAQ,EAAE,OAAO,CAAC,QAAQ;YAC1B,OAAO,EAAE,OAAO,CAAC,OAAO;YACxB,eAAe,EACb,OAAO,OAAO,CAAC,QAAQ,EAAE,eAAe,KAAK,QAAQ;gBACnD,CAAC,CAAE,OAAO,CAAC,QAAQ,CAAC,eAA0B;gBAC9C,CAAC,CAAC,SAAS;SAChB,CAAC,CAAC;QAEH,IAAI,MAAmE,CAAC;QACxE,IAAI,CAAC;YACH,MAAM,GAAG,MAAM,IAAI,CAAC,SAAS,CAAC,kBAAkB,CAAC,OAAO,CAAC,YAAY,EAAE,MAAM,CAAC,CAAC;QACjF,CAAC;QAAC,OAAO,GAAG,EAAE,CAAC;YACb,MAAM,MAAM,GAAG,GAAG,YAAY,KAAK,CAAC,CAAC,CAAC,GAAG,CAAC,OAAO,CAAC,CAAC,CAAC,MAAM,CAAC,GAAG,CAAC,CAAC;YAChE,IAAI,CAAC,MAAM,CAAC,KAAK,CAAC,wBAAwB,EAAE;gBAC1C,SAAS,EAAE,OAAO,CAAC,EAAE;gBACrB,YAAY,EAAE,OAAO,CAAC,YAAY;gBAClC,GAAG,EAAE,MAAM;aACZ,CAAC,CAAC;YACH,OAAO,EAAE,UAAU,EAAE,KAAK,EAAE,KAAK,EAAE,MAAM,EAAE,CAAC;QAC9C,CAAC;QAED,IAAI,CAAC,MAAM,CAAC,OAAO,EAAE,CAAC;YACpB,uEAAuE;YACvE,uEAAuE;YACvE,sEAAsE;YACtE,mEAAmE;YACnE,oCAAoC;YACpC,IAAI,IAAI,CAAC,aAAa,EAAE,CAAC;gBACvB,IAAI,CAAC,MAAM,CAAC,IAAI,CAAC,uDAAuD,EAAE;oBACxE,SAAS,EAAE,OAAO,CAAC,EAAE;oBACrB,YAAY,EAAE,OAAO,CAAC,YAAY;iBACnC,CAAC,CAAC;gBACH,IAAI,SAAS,GAAG,KAAK,CAAC;gBACtB,IAAI,CAAC;oBACH,SAAS,GAAG,MAAM,IAAI,CAAC,aAAa,CAAC,OAAO,CAAC,YAAY,CAAC,CAAC;gBAC7D,CAAC;gBAAC,OAAO,GAAG,EAAE,CAAC;oBACb,IAAI,CAAC,MAAM,CAAC,IAAI,CAAC,iCAAiC,EAAE;wBAClD,YAAY,EAAE,OAAO,CAAC,YAAY;wBAClC,GAAG,EAAE,GAAG,YAAY,KAAK,CAAC,CAAC,CAAC,GAAG,CAAC,OAAO,CAAC,CAAC,CAAC,MAAM,CAAC,GAAG,CAAC;qBACtD,CAAC,CAAC;gBACL,CAAC;gBACD,IAAI,SAAS,EAAE,CAAC;oBACd,IAAI,CAAC;wBACH,MAAM,GAAG,MAAM,IAAI,CAAC,SAAS,CAAC,kBAAkB,CAAC,OAAO,CAAC,YAAY,EAAE,MAAM,CAAC,CAAC;oBACjF,CAAC;oBAAC,OAAO,GAAG,EAAE,CAAC;wBACb,OAAO;4BACL,UAAU,EAAE,KAAK;4BACjB,KAAK,EAAE,GAAG,YAAY,KAAK,CAAC,CAAC,CAAC,GAAG,CAAC,OAAO,CAAC,CAAC,CAAC,MAAM,CAAC,GAAG,CAAC;yBACxD,CAAC;oBACJ,CAAC;gBACH,CAAC;YACH,CAAC;YAED,IAAI,CAAC,MAAM,CAAC,OAAO,EAAE,CAAC;gBACpB,IAAI,CAAC,MAAM,CAAC,IAAI,CAAC,mCAAmC,EAAE;oBACpD,SAAS,EAAE,OAAO,CAAC,EAAE;oBACrB,YAAY,EAAE,OAAO,CAAC,YAAY;oBAClC,GAAG,EAAE,MAAM,CAAC,KAAK;iBAClB,CAAC,CAAC;gBACH,OAAO,EAAE,UAAU,EAAE,KAAK,EAAE,KAAK,EAAE,MAAM,CAAC,KAAK,IAAI,sBAAsB,EAAE,CAAC;YAC9E,CAAC;QACH,CAAC;QAED,IAAI,CAAC,MAAM,CAAC,KAAK,CAAC,oBAAoB,EAAE;YACtC,SAAS,EAAE,OAAO,CAAC,EAAE;YACrB,YAAY,EAAE,OAAO,CAAC,YAAY;YAClC,MAAM,EAAE,MAAM,CAAC,MAAM,IAAI,KAAK;SAC/B,CAAC,CAAC;QACH,OAAO,EAAE,UAAU,EAAE,IAAI,EAAE,CAAC;IAC9B,CAAC;CACF"}

package/dist/cli/backend/src/services/chat-v2/chat-v2.mention-resolver.d.ts

@@ -0,0 +1,134 @@
+/**
+ * ChatV2MentionResolver — turn `mentions[]` from a chat message into a
+ * deduplicated list of agent-session dispatch targets.
+ *
+ * Phase C BE.2 scaffolding for Slack-like team-chat mention dispatch
+ * (SEALED §2.1 routing rules):
+ *
+ *   - **`@agent` mention** (mention id matches a `TeamMember.id`):
+ *     resolves to that member's tmux/agent `sessionName`. The dispatcher
+ *     will deliver the message directly into that agent's session.
+ *
+ *   - **`@team` mention** (mention id matches a `Team.id`): resolves to
+ *     that team's TL — the canonical primary responder per the spec
+ *     ("the Team Lead is the primary responder; if busy, queue in the
+ *     Team's Task Pool"). TL is selected as: first member with both
+ *     `hierarchyLevel === 1` and `canDelegate === true`, falling back
+ *     to any `canDelegate` member, then `members[0]` so the rule is
+ *     deterministic even on legacy teams without hierarchy fields.
+ *
+ *   - **Unknown mention id** (not a team or a known member): skipped
+ *     with a debug log. The dispatcher must always succeed even when
+ *     the FE includes a stale/typo mention; the chat HTTP ack has
+ *     already been sent by the time we resolve.
+ *
+ * Phase C F2a (issue #333) — cross-tenant scope enforcement: when the
+ * caller passes `context.teamId`, the resolver enforces the channel's
+ * tenant boundary. `@agent` mentions to members of any other team are
+ * dropped (cross-tenant leak vector pinned by Arch on PR #331); `@team`
+ * mentions to any team still resolve (cross-team pings are a useful
+ * coordination affordance), but a mismatch emits a warn for audit.
+ *
+ * The resolver is the boundary between the chat-v2 wire (id strings)
+ * and the agent runtime (session names). It deliberately does NOT
+ * touch the agent registry — it only produces the addresses that the
+ * dispatcher will hand to `AgentMessageSink.sendMessageToAgent`.
+ *
+ * The team list is loaded via an injected `loadTeams()` callback so
+ * tests can drive it without a real `StorageService`. Production wiring
+ * passes `() => storageService.getTeams()`.
+ *
+ * @module services/chat-v2/chat-v2.mention-resolver
+ */
+import type { Team } from '../../types/index.js';
+/** Kind of mention that resolved to a target. */
+export type MentionTargetKind = 'agent' | 'team';
+/**
+ * One resolved dispatch target. The dispatcher will call
+ * `sendMessageToAgent(sessionName, prompt)` for each unique entry.
+ */
+export interface MentionTarget {
+    /** Whether this target came from an `@agent` (member) or `@team` mention. */
+    kind: MentionTargetKind;
+    /** The original mention id as it appeared in the wire `mentions[]`. */
+    mentionId: string;
+    /** Resolved member id. For `kind='team'`, this is the TL's member id. */
+    memberId: string;
+    /** Resolved agent session name — the address `sendMessageToAgent` expects. */
+    sessionName: string;
+    /** For `kind='team'`, the matched team's id. Undefined for `kind='agent'`. */
+    teamId?: string;
+}
+/** Optional context the resolver may use to disambiguate. */
+export interface MentionResolverContext {
+    /**
+     * The channel's `teamId` (when the channel is `type='channel'`). When set,
+     * the resolver enforces cross-tenant scope (Phase C F2a, issue #333):
+     *
+     *   - `@agent` mentions are restricted to members whose owning team's
+     *     id equals `teamId`. Mentions to agents of any other team are
+     *     dropped with a debug log so a foreign-team agent never receives
+     *     a dispatch frame from a channel they are not a member of.
+     *
+     *   - `@team` mentions to any team id still resolve to that team's TL
+     *     (they remain useful for cross-team coordination), but a mismatch
+     *     between the channel's `teamId` and the mentioned team's id emits
+     *     a warn so the cross-team ping is observable in audit/log.
+     *
+     * Leave undefined (or empty string) to disable scoping — used by the
+     * legacy DM dispatch path and by tests that need the global resolver.
+     */
+    teamId?: string;
+}
+/**
+ * Dependencies. The team-list source is callable so tests don't need a
+ * StorageService; the production path injects `() => storage.getTeams()`.
+ */
+export interface MentionResolverDeps {
+    /**
+     * Returns the current team list. May be sync or async — the resolver
+     * awaits the result either way. Errors propagate; the resolver
+     * surfaces an empty-target list on caller error so a transient
+     * storage hiccup never crashes the chat dispatch path.
+     */
+    loadTeams: () => Promise<Team[]> | Team[];
+}
+/**
+ * Stateless resolver — instances are cheap to construct. Each `resolve()`
+ * call loads the team list fresh so dispatch always sees the latest
+ * member/session bindings (a new agent comes online → next mention
+ * resolves correctly without a restart).
+ */
+export declare class ChatV2MentionResolver {
+    private readonly loadTeams;
+    private readonly logger;
+    constructor(deps: MentionResolverDeps);
+    /**
+     * Resolve `mentions` to dispatch targets.
+     *
+     * Behavior:
+     *   - Empty / whitespace mention ids are skipped silently.
+     *   - Each id is classified as team-first, then agent-first; ties go to
+     *     the team interpretation since team ids and member ids share the
+     *     same UUID-shape namespace and team mentions are higher-impact.
+     *   - Unknown ids are logged at debug level and skipped.
+     *   - Duplicate `sessionName`s are collapsed (first-seen wins, keeping
+     *     `kind` ordering stable for tests).
+     *   - Targets with empty `sessionName` are skipped — there is no agent
+     *     to dispatch to.
+     *
+     * Phase C F2a (#333) — when `context.teamId` is set:
+     *   - `@agent` mentions whose owning team !== `context.teamId` are
+     *     dropped at debug level (cross-tenant leak guard).
+     *   - `@team` mentions to a different team still resolve to that
+     *     team's TL but emit a warn so cross-team pings are auditable.
+     *   - A blank/whitespace `context.teamId` is treated as "no scope"
+     *     so DM dispatch and back-compat tests keep current behavior.
+     *
+     * @param mentions - The raw mention id list from `ChatMessageDTO.mentions`.
+     * @param context - Optional resolver context (teamId etc.).
+     * @returns Deduplicated dispatch targets, in input order with team-first ties.
+     */
+    resolve(mentions: string[], context?: MentionResolverContext): Promise<MentionTarget[]>;
+}
+//# sourceMappingURL=chat-v2.mention-resolver.d.ts.map

package/dist/cli/backend/src/services/chat-v2/chat-v2.mention-resolver.d.ts.map

@@ -0,0 +1 @@
+{"version":3,"file":"chat-v2.mention-resolver.d.ts","sourceRoot":"","sources":["../../../../../../backend/src/services/chat-v2/chat-v2.mention-resolver.ts"],"names":[],"mappings":"AAAA;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;GAyCG;AAEH,OAAO,KAAK,EAAE,IAAI,EAAc,MAAM,sBAAsB,CAAC;AAQ7D,iDAAiD;AACjD,MAAM,MAAM,iBAAiB,GAAG,OAAO,GAAG,MAAM,CAAC;AAEjD;;;GAGG;AACH,MAAM,WAAW,aAAa;IAC5B,6EAA6E;IAC7E,IAAI,EAAE,iBAAiB,CAAC;IACxB,uEAAuE;IACvE,SAAS,EAAE,MAAM,CAAC;IAClB,yEAAyE;IACzE,QAAQ,EAAE,MAAM,CAAC;IACjB,8EAA8E;IAC9E,WAAW,EAAE,MAAM,CAAC;IACpB,8EAA8E;IAC9E,MAAM,CAAC,EAAE,MAAM,CAAC;CACjB;AAED,6DAA6D;AAC7D,MAAM,WAAW,sBAAsB;IACrC;;;;;;;;;;;;;;;;OAgBG;IACH,MAAM,CAAC,EAAE,MAAM,CAAC;CACjB;AAED;;;GAGG;AACH,MAAM,WAAW,mBAAmB;IAClC;;;;;OAKG;IACH,SAAS,EAAE,MAAM,OAAO,CAAC,IAAI,EAAE,CAAC,GAAG,IAAI,EAAE,CAAC;CAC3C;AAMD;;;;;GAKG;AACH,qBAAa,qBAAqB;IAChC,OAAO,CAAC,QAAQ,CAAC,SAAS,CAAmC;IAC7D,OAAO,CAAC,QAAQ,CAAC,MAAM,CAAkB;gBAE7B,IAAI,EAAE,mBAAmB;IAKrC;;;;;;;;;;;;;;;;;;;;;;;;;OAyBG;IACG,OAAO,CAAC,QAAQ,EAAE,MAAM,EAAE,EAAE,OAAO,CAAC,EAAE,sBAAsB,GAAG,OAAO,CAAC,aAAa,EAAE,CAAC;CAgJ9F"}