crewly 1.11.6 → 1.12.1

package/packages/crewly-agent/src/runtime/model-manager.ts

@@ -0,0 +1,363 @@
+/**
+ * Crewly Agent Model Manager
+ *
+ * Multi-provider model factory that creates AI SDK model instances
+ * from configuration. Supports Anthropic, OpenAI, Google, DeepSeek, and
+ * Ollama providers.
+ *
+ * API keys for cloud providers are resolved through the settings service
+ * (skill → runtime → global → env var) and injected into process.env so the
+ * provider SDKs can pick them up:
+ * - ANTHROPIC_API_KEY
+ * - OPENAI_API_KEY
+ * - GOOGLE_GENERATIVE_AI_API_KEY
+ * - DEEPSEEK_API_KEY (DeepSeek; served via OpenAI-compatible API)
+ *
+ * Ollama runs locally and does not require an API key.
+ * Configure the Ollama base URL via OLLAMA_BASE_URL (default: http://localhost:11434).
+ *
+ * @module services/agent/crewly-agent/model-manager
+ */
+
+import type { LanguageModel } from 'ai';
+import { type ModelConfig, type ModelProvider, CREWLY_AGENT_DEFAULTS } from './types.js';
+/**
+ * Standalone runtime resolves API keys from environment variables only — it
+ * does not depend on OSS's settings service. Anyone running this binary on
+ * a user machine sets keys via env (.env, shell profile, or the harness that
+ * spawns the process), keeping the runtime credential-isolated.
+ *
+ * OSS-side bridging code can still pre-set env vars before spawning the
+ * subprocess, which gives users the same "configure key in UI" experience
+ * without coupling the runtime to OSS internals.
+ */
+type ApiKeyProvider = 'gemini' | 'anthropic' | 'openai' | 'deepseek';
+
+interface SettingsServiceLike {
+  getApiKey(provider: ApiKeyProvider, context: { runtime: string }): Promise<string | null>;
+}
+
+function getSettingsService(): SettingsServiceLike {
+  return {
+    getApiKey: async (provider) => {
+      switch (provider) {
+        case 'gemini':
+          return process.env.GOOGLE_GENERATIVE_AI_API_KEY ?? process.env.GEMINI_API_KEY ?? null;
+        case 'anthropic':
+          return process.env.ANTHROPIC_API_KEY ?? null;
+        case 'openai':
+          return process.env.OPENAI_API_KEY ?? null;
+        case 'deepseek':
+          return process.env.DEEPSEEK_API_KEY ?? null;
+        default:
+          return null;
+      }
+    },
+  };
+}
+import { teeAndParse, type ParsedDeepseekSse } from './deepseek-sse-transform.js';
+
+/**
+ * Base URL for DeepSeek's OpenAI-compatible chat completions endpoint.
+ * DeepSeek implements /chat/completions only — not /responses — so we
+ * must route via the `.chat(modelId)` factory of @ai-sdk/openai's
+ * createOpenAI() return value. Extracted per CLAUDE.md no-hardcoded-values rule.
+ */
+const DEEPSEEK_BASE_URL = 'https://api.deepseek.com/v1';
+
+/**
+ * Factory for creating AI SDK language model instances from configuration.
+ *
+ * Uses dynamic imports to avoid loading provider SDKs that aren't needed,
+ * keeping the startup cost minimal when only one provider is used.
+ *
+ * @example
+ * ```typescript
+ * const manager = new ModelManager();
+ * const model = await manager.getModel({ provider: 'anthropic', modelId: 'claude-sonnet-4-20250514' });
+ * ```
+ */
+export class ModelManager {
+  /** Cached provider module references to avoid re-importing */
+  private providerCache = new Map<ModelProvider, (modelId: string) => LanguageModel>();
+
+  /**
+   * Per-instance buffer of parsed DeepSeek-R1 reasoning_content from in-flight
+   * and recently-completed HTTP calls. Each `streamText` call to a DeepSeek
+   * model triggers one or more fetch calls (one per agentic step); each fetch
+   * appends its parsed reasoning to this buffer. Consumer (agent-runner) reads
+   * via `consumeDeepseekReasoning()` after `await streamResult` and the buffer
+   * resets to `''` on read.
+   *
+   * **Concurrency:** AgentRunner uses one ModelManager per session and calls
+   * streamText serially per session (the rate limiter enforces this).
+   * Cross-session concurrency is not a concern because each AgentRunner gets
+   * its own ModelManager via `new ModelManager()` in the constructor.
+   */
+  private deepseekReasoningBuffer = '';
+
+  /** Tracks in-flight parsed-SSE handles so we can wait for drain on consume. */
+  private deepseekParsedHandles: ParsedDeepseekSse[] = [];
+
+  /**
+   * Get an AI SDK language model instance for the given configuration.
+   *
+   * Resolves API keys from settings (with override chain) and injects them
+   * into the environment before creating the model, so provider SDKs can find them.
+   *
+   * @param config - Model configuration specifying provider and model ID
+   * @returns AI SDK LanguageModel instance ready for use with generateText
+   * @throws Error if the provider is unknown or the SDK is not installed
+   */
+  async getModel(config: ModelConfig = CREWLY_AGENT_DEFAULTS.DEFAULT_MODEL): Promise<LanguageModel> {
+    // Ensure the provider's API key is in the environment from settings
+    await this.ensureApiKeyInEnv(config.provider);
+
+    const providerFn = await this.getProviderFunction(config.provider);
+    return providerFn(config.modelId);
+  }
+
+  /**
+   * Get provider function, using cache for repeated calls.
+   *
+   * @param provider - Provider name
+   * @returns Function that creates a model from a model ID string
+   */
+  private async getProviderFunction(provider: ModelProvider): Promise<(modelId: string) => LanguageModel> {
+    const cached = this.providerCache.get(provider);
+    if (cached) return cached;
+
+    let providerFn: (modelId: string) => LanguageModel;
+
+    try {
+      switch (provider) {
+        case 'anthropic': {
+          const { anthropic } = await import('@ai-sdk/anthropic');
+          providerFn = (modelId: string) => anthropic(modelId);
+          break;
+        }
+        case 'openai': {
+          const { openai } = await import('@ai-sdk/openai');
+          providerFn = (modelId: string) => openai(modelId);
+          break;
+        }
+        case 'google': {
+          const { google } = await import('@ai-sdk/google');
+          providerFn = (modelId: string) => google(modelId);
+          break;
+        }
+        case 'ollama': {
+          const { createOllama } = await import('ollama-ai-provider');
+          const baseURL = process.env.OLLAMA_BASE_URL || CREWLY_AGENT_DEFAULTS.OLLAMA_BASE_URL;
+          const ollamaProvider = createOllama({ baseURL });
+          // ollama-ai-provider exports LanguageModelV1 which is compatible but
+          // doesn't extend the newer LanguageModel union — safe to cast.
+          providerFn = (modelId: string) => ollamaProvider(modelId) as unknown as LanguageModel;
+          break;
+        }
+        case 'deepseek': {
+          // DeepSeek API is OpenAI-compatible — reuse the OpenAI SDK with a custom baseURL.
+          // IMPORTANT: must call deepseekProvider.chat(modelId), NOT deepseekProvider(modelId).
+          // The bare function-call form on @ai-sdk/openai >=3.x routes to /responses, which
+          // DeepSeek does not implement — it only exposes /chat/completions. The .chat factory
+          // forces the chat-completions path. See PR #400 review for full trace.
+          //
+          // **I2 — reasoning_content extraction:**
+          // Pass a custom `fetch` that tees the SSE response body. One branch flows
+          // through to AI SDK unmodified (zero impact on existing behavior); the other
+          // branch is parsed for `delta.reasoning_content` text and accumulated into
+          // `this.deepseekReasoningBuffer`, which agent-runner consumes after
+          // streamResult drains. See deepseek-sse-transform.ts for the parser.
+          const { createOpenAI } = await import('@ai-sdk/openai');
+          const customFetch = this.makeDeepseekFetch();
+          const deepseekProvider = createOpenAI({
+            baseURL: DEEPSEEK_BASE_URL,
+            apiKey: process.env.DEEPSEEK_API_KEY,
+            fetch: customFetch as unknown as typeof globalThis.fetch,
+          });
+          providerFn = (modelId: string) => deepseekProvider.chat(modelId);
+          break;
+        }
+        default:
+          throw new Error(`Unknown model provider: ${provider}`);
+      }
+    } catch (error) {
+      if (error instanceof Error && error.message.startsWith('Unknown model provider:')) {
+        throw error;
+      }
+      throw new Error(
+        `Failed to load provider SDK for '${provider}'. Is the package installed? ` +
+        `Original error: ${error instanceof Error ? error.message : String(error)}`
+      );
+    }
+
+    this.providerCache.set(provider, providerFn);
+    return providerFn;
+  }
+
+  /**
+   * Check which providers have API keys configured (settings + env vars).
+   *
+   * @returns Object indicating which providers are available
+   */
+  async getAvailableProviders(): Promise<Record<ModelProvider, boolean>> {
+    const settingsService = getSettingsService();
+    const context = { runtime: 'crewly-agent' };
+
+    const [geminiKey, anthropicKey, openaiKey, deepseekKey] = await Promise.all([
+      settingsService.getApiKey('gemini', context),
+      settingsService.getApiKey('anthropic', context),
+      settingsService.getApiKey('openai', context),
+      settingsService.getApiKey('deepseek', context),
+    ]);
+
+    return {
+      anthropic: !!anthropicKey,
+      openai: !!openaiKey,
+      google: !!geminiKey,
+      ollama: true, // Ollama runs locally, always "available" if installed
+      deepseek: !!deepseekKey,
+    };
+  }
+
+  /**
+   * Map model provider name to API key provider name.
+   * Only applicable for cloud providers wired through the settings service
+   * (anthropic, openai, google, deepseek). Ollama runs locally and is
+   * excluded.
+   *
+   * @param provider - Cloud model provider
+   * @returns Corresponding ApiKeyProvider name
+   */
+  private static providerToApiKeyProvider(provider: Exclude<ModelProvider, 'ollama'>): ApiKeyProvider {
+    return provider === 'google' ? 'gemini' : provider;
+  }
+
+  /**
+   * Ensure the API key for a provider is available in process.env
+   * by resolving it from settings if not already present.
+   *
+   * No-op for 'ollama' (runs locally, no key required). All other providers —
+   * including 'deepseek' — flow through the settings service so users can
+   * configure them from the UI without touching env vars.
+   *
+   * @param provider - The model provider
+   */
+  private async ensureApiKeyInEnv(provider: ModelProvider): Promise<void> {
+    if (provider === 'ollama') return; // Ollama is local, no API key needed
+    const apiKeyProvider = ModelManager.providerToApiKeyProvider(provider);
+    const settingsService = getSettingsService();
+    const key = await settingsService.getApiKey(apiKeyProvider, { runtime: 'crewly-agent' });
+
+    if (!key) return;
+
+    // Set env vars so the provider SDKs can find them.
+    // Always override — settings keys take priority over stale env vars.
+    switch (provider) {
+      case 'anthropic':
+        process.env.ANTHROPIC_API_KEY = key;
+        break;
+      case 'openai':
+        process.env.OPENAI_API_KEY = key;
+        break;
+      case 'google':
+        process.env.GOOGLE_GENERATIVE_AI_API_KEY = key;
+        break;
+      case 'deepseek':
+        process.env.DEEPSEEK_API_KEY = key;
+        break;
+    }
+  }
+
+  /**
+   * Clear the provider cache (useful for testing or reconfiguration).
+   * Also clears any buffered DeepSeek reasoning so a fresh test/run starts clean.
+   */
+  clearCache(): void {
+    this.providerCache.clear();
+    this.deepseekReasoningBuffer = '';
+    this.deepseekParsedHandles = [];
+  }
+
+  /**
+   * Build the custom fetch wrapper for the DeepSeek provider.
+   *
+   * Returns a function with the same signature as `globalThis.fetch` that:
+   * 1. Calls native fetch with the supplied input/init.
+   * 2. If the response is a streaming SSE body, tees it and parses one branch
+   *    for `delta.reasoning_content`, accumulating into `this.deepseekReasoningBuffer`.
+   * 3. Returns a new Response wrapping the un-tampered passthrough branch as
+   *    its body, so AI SDK consumes exactly the bytes DeepSeek sent.
+   *
+   * If the response is not an SSE stream (e.g. error JSON, no body), it is
+   * returned unchanged.
+   *
+   * **Why a method, not a free function:** the wrapper closes over `this` to
+   * append to the per-instance reasoning buffer. Each ModelManager instance
+   * has its own buffer (one per AgentRunner per session).
+   */
+  private makeDeepseekFetch(): (input: unknown, init?: unknown) => Promise<Response> {
+    return async (input: unknown, init?: unknown): Promise<Response> => {
+      // Cast through `any` because @ai-sdk/openai's fetch type is the standard
+      // global fetch shape; we re-export native fetch behavior identically.
+      const response: Response = await (globalThis.fetch as any)(input, init);
+
+      // Only intercept successful streaming responses. Non-stream errors
+      // (4xx/5xx with JSON body) and empty bodies pass through untouched.
+      if (!response.ok || !response.body) return response;
+      const contentType = response.headers.get('content-type') ?? '';
+      if (!contentType.includes('text/event-stream')) return response;
+
+      const parsed = teeAndParse(response.body);
+      this.deepseekParsedHandles.push(parsed);
+
+      // Wrap into a new Response with the passthrough branch as body.
+      // Headers, status, and statusText are copied so AI SDK sees an identical
+      // response shape.
+      return new Response(parsed.passthroughBody, {
+        status: response.status,
+        statusText: response.statusText,
+        headers: response.headers,
+      });
+    };
+  }
+
+  /**
+   * Drain any in-flight DeepSeek SSE parser branches and return the accumulated
+   * `reasoning_content` string. Resets the buffer to `''` on each call (consume
+   * semantics).
+   *
+   * **Caller contract:** call AFTER `await streamResult` resolves in agent-runner.
+   * The AI SDK consumer branch must have been fully drained for the parser branch
+   * (which lags slightly due to tee buffering) to have caught up.
+   *
+   * **Multi-step accumulation:** if a single `streamText` call made multiple HTTP
+   * calls (one per agentic step), reasoning from all steps is concatenated in
+   * call order — not separated by step boundary. This matches the user-facing
+   * mental model of "what was the model's full chain of thought for this turn."
+   *
+   * **Returns `null` if no reasoning was captured.** Empty string means a fetch
+   * happened but produced no reasoning content (e.g. non-R1 DeepSeek model).
+   */
+  async consumeDeepseekReasoning(): Promise<string | null> {
+    const handles = this.deepseekParsedHandles;
+    this.deepseekParsedHandles = [];
+    if (handles.length === 0) {
+      const buffered = this.deepseekReasoningBuffer;
+      this.deepseekReasoningBuffer = '';
+      return buffered || null;
+    }
+    // Wait for all parser branches to finish draining (they should already be
+    // done if AI SDK consumer drained, but allow up to one event-loop tick).
+    for (const h of handles) {
+      if (!h.isDrained()) {
+        // Yield once so the parser background reader can flush.
+        await new Promise((r) => setImmediate(r));
+      }
+      this.deepseekReasoningBuffer += h.getReasoning();
+    }
+    const out = this.deepseekReasoningBuffer;
+    this.deepseekReasoningBuffer = '';
+    return out || null;
+  }
+}

package/packages/crewly-agent/src/runtime/output-filter.service.ts

@@ -0,0 +1,175 @@
+/**
+ * Output Filter Service — API Key Redaction
+ *
+ * Scans all agent text output for API key patterns and replaces them
+ * with [REDACTED] before the output reaches users or logs.
+ *
+ * Detects patterns from major providers (OpenAI, Anthropic, Google, AWS)
+ * as well as generic key/token/secret assignments.
+ *
+ * @module services/agent/crewly-agent/output-filter.service
+ *
+ * @example
+ * ```typescript
+ * const filter = new OutputFilterService();
+ * const safe = filter.redact('My key is sk-abc123xyz');
+ * // => 'My key is [REDACTED]'
+ * ```
+ */
+
+/**
+ * A single API key detection pattern with a label for audit logging.
+ */
+export interface KeyPattern {
+  /** Regex to match the key in text */
+  pattern: RegExp;
+  /** Human-readable label for audit/logging */
+  label: string;
+}
+
+/**
+ * Result of scanning text for API keys.
+ */
+export interface ScanResult {
+  /** Whether any keys were detected */
+  detected: boolean;
+  /** Number of keys found */
+  count: number;
+  /** Labels of the matched patterns */
+  matchedPatterns: string[];
+  /** Redacted text with keys replaced */
+  redactedText: string;
+}
+
+/**
+ * API key patterns for major providers and generic secrets.
+ *
+ * Each pattern uses word boundaries or lookbehind/lookahead to minimize
+ * false positives while catching real key formats.
+ */
+export const API_KEY_PATTERNS: readonly KeyPattern[] = [
+  // OpenAI: sk-<org>-<rest> or sk-<48+ chars>
+  { pattern: /\bsk-[A-Za-z0-9_-]{20,}/g, label: 'OpenAI API Key' },
+  // Anthropic: sk-ant-api03-<rest>
+  { pattern: /\bsk-ant-[A-Za-z0-9_-]{20,}/g, label: 'Anthropic API Key' },
+  // Google AI: AIza<rest>
+  { pattern: /\bAIza[A-Za-z0-9_-]{30,}/g, label: 'Google API Key' },
+  // AWS Access Key: AKIA<16 alphanumeric>
+  { pattern: /\bAKIA[A-Z0-9]{16}\b/g, label: 'AWS Access Key' },
+  // AWS Secret Key (often follows access key)
+  { pattern: /(?<=aws_secret_access_key\s*[=:]\s*)[A-Za-z0-9/+=]{30,}/g, label: 'AWS Secret Key' },
+  // GitHub tokens: ghp_, gho_, ghu_, ghs_, ghr_
+  { pattern: /\bgh[pousr]_[A-Za-z0-9_]{30,}/g, label: 'GitHub Token' },
+  // Stripe: sk_live_ or sk_test_
+  { pattern: /\bsk_(live|test)_[A-Za-z0-9]{20,}/g, label: 'Stripe API Key' },
+  // Supabase anon/service keys (JWT-like, start with eyJ)
+  { pattern: /\beyJ[A-Za-z0-9_-]{50,}\.[A-Za-z0-9_-]{50,}\.[A-Za-z0-9_-]{20,}/g, label: 'JWT Token' },
+  // Generic key=value patterns (key, token, secret, password, api_key, apikey)
+  { pattern: /(?<=(?:api[_-]?key|api[_-]?secret|api[_-]?token|secret[_-]?key|access[_-]?token|auth[_-]?token|password|secret)\s*[=:]\s*["']?)[A-Za-z0-9_/+=.-]{16,}/gi, label: 'Generic Secret' },
+  // Environment variable assignments with sensitive names
+  { pattern: /(?<=(?:ANTHROPIC_API_KEY|OPENAI_API_KEY|GOOGLE_API_KEY|AWS_SECRET_ACCESS_KEY|STRIPE_SECRET_KEY|SUPABASE_SERVICE_ROLE_KEY|DATABASE_URL|REDIS_URL)\s*=\s*["']?)[^\s"']{8,}/g, label: 'Environment Variable Secret' },
+] as const;
+
+/** Replacement text for redacted keys */
+export const REDACTION_PLACEHOLDER = '[REDACTED]';
+
+/**
+ * Service that scans and redacts API keys from agent output text.
+ */
+export class OutputFilterService {
+  private readonly patterns: readonly KeyPattern[];
+
+  /**
+   * Creates a new OutputFilterService.
+   * @param customPatterns - Optional additional patterns to detect (appended to defaults)
+   */
+  constructor(customPatterns?: KeyPattern[]) {
+    this.patterns = customPatterns
+      ? [...API_KEY_PATTERNS, ...customPatterns]
+      : API_KEY_PATTERNS;
+  }
+
+  /**
+   * Scans text for API keys and returns detailed results.
+   *
+   * @param text - Text to scan for API keys
+   * @returns Scan result with detection info and redacted text
+   */
+  scan(text: string): ScanResult {
+    if (!text) {
+      return { detected: false, count: 0, matchedPatterns: [], redactedText: text };
+    }
+
+    let redacted = text;
+    let totalCount = 0;
+    const matchedLabels: Set<string> = new Set();
+
+    for (const { pattern, label } of this.patterns) {
+      // Reset regex lastIndex for global patterns
+      const regex = new RegExp(pattern.source, pattern.flags);
+      const matches = redacted.match(regex);
+      if (matches) {
+        totalCount += matches.length;
+        matchedLabels.add(label);
+        redacted = redacted.replace(regex, REDACTION_PLACEHOLDER);
+      }
+    }
+
+    return {
+      detected: totalCount > 0,
+      count: totalCount,
+      matchedPatterns: Array.from(matchedLabels),
+      redactedText: redacted,
+    };
+  }
+
+  /**
+   * Redacts all API keys in the given text.
+   * Convenience method that returns only the redacted string.
+   *
+   * @param text - Text to redact
+   * @returns Text with all detected API keys replaced with [REDACTED]
+   */
+  redact(text: string): string {
+    return this.scan(text).redactedText;
+  }
+
+  /**
+   * Checks if text contains any API keys without modifying it.
+   *
+   * @param text - Text to check
+   * @returns True if any API key patterns are detected
+   */
+  containsKeys(text: string): boolean {
+    if (!text) return false;
+    for (const { pattern } of this.patterns) {
+      const regex = new RegExp(pattern.source, pattern.flags);
+      if (regex.test(text)) return true;
+    }
+    return false;
+  }
+
+  /**
+   * Redacts API keys from a structured object (recursively scans string values).
+   * Useful for sanitizing tool call arguments and results before logging.
+   *
+   * @param obj - Object to scan and redact
+   * @returns Deep copy with all string values redacted
+   */
+  redactObject(obj: unknown): unknown {
+    if (typeof obj === 'string') {
+      return this.redact(obj);
+    }
+    if (Array.isArray(obj)) {
+      return obj.map((item) => this.redactObject(item));
+    }
+    if (typeof obj === 'object' && obj !== null) {
+      const result: Record<string, unknown> = {};
+      for (const [key, value] of Object.entries(obj)) {
+        result[key] = this.redactObject(value);
+      }
+      return result;
+    }
+    return obj;
+  }
+}