crewly 1.0.3 → 1.0.5

package/dist/backend/backend/src/controllers/team/team.controller.js

@@ -8,6 +8,8 @@ import { ActivityMonitorService } from '../../services/monitoring/activity-monit
 import { MemoryService } from '../../services/memory/memory.service.js';
 import { SubAgentMessageQueue } from '../../services/messaging/sub-agent-message-queue.service.js';
 import { SUB_AGENT_QUEUE_CONSTANTS } from '../../constants.js';
+import { LoggerService } from '../../services/core/logger.service.js';
+const logger = LoggerService.getInstance().createComponentLogger('TeamController');
 /**
  * Module-level EventBusService instance, injected at startup.
  * Used to auto-subscribe the orchestrator to agent lifecycle events.
@@ -122,7 +124,7 @@ async function _startTeamMemberCore(context, team, member, projectPath) {
                         }
                         else {
                             // Session exists but appears zombie - kill it and proceed with new creation
-                            console.warn(`Cleaning up zombie session: ${member.sessionName}`);
+                            logger.warn('Cleaning up zombie session', { sessionName: member.sessionName });
                             await context.tmuxService.killSession(member.sessionName).catch(() => {
                                 // Ignore errors if session doesn't exist
                             });
@@ -133,7 +135,7 @@ async function _startTeamMemberCore(context, team, member, projectPath) {
                     }
                     catch (error) {
                         // If we can't check the session, assume it's zombie and clean it up
-                        console.warn(`Error checking session ${member.sessionName}, treating as zombie:`, error);
+                        logger.warn('Error checking session, treating as zombie', { sessionName: member.sessionName, error: error instanceof Error ? error.message : String(error) });
                         await context.tmuxService.killSession(member.sessionName).catch(() => {
                             // Ignore errors if session doesn't exist
                         });
@@ -232,7 +234,7 @@ async function _startTeamMemberCore(context, team, member, projectPath) {
                 await memoryService.initializeForSession(sessionName, currentMember.role, projectPath || process.cwd());
             }
             catch (memError) {
-                console.warn(`[TeamController] Failed to initialize memory for ${sessionName}:`, memError);
+                logger.warn('Failed to initialize memory', { sessionName, error: memError instanceof Error ? memError.message : String(memError) });
             }
             // CRITICAL: Load fresh data again after session creation to preserve MCP registration updates
             const finalTeams = await context.storageService.getTeams();
@@ -255,7 +257,7 @@ async function _startTeamMemberCore(context, team, member, projectPath) {
                 };
             }
             else {
-                console.error(`Team or member not found after session creation: teamId=${team.id}, memberId=${member.id}`);
+                logger.error('Team or member not found after session creation', { teamId: team.id, memberId: member.id });
                 return {
                     success: false,
                     memberName: member.name,
@@ -278,7 +280,7 @@ async function _startTeamMemberCore(context, team, member, projectPath) {
                 failureMember.updatedAt = new Date().toISOString();
                 await context.storageService.saveTeam(failureTeam);
             }
-            console.error(`All ${MAX_CREATION_RETRIES} session creation attempts failed for ${member.name}: ${lastError}`);
+            logger.error('All session creation attempts failed', { retries: MAX_CREATION_RETRIES, memberName: member.name, lastError });
             return {
                 success: false,
                 memberName: member.name,
@@ -301,7 +303,7 @@ async function _startTeamMemberCore(context, team, member, projectPath) {
             errorMember.updatedAt = new Date().toISOString();
             await context.storageService.saveTeam(errorTeam);
         }
-        console.error('Error starting team member:', error);
+        logger.error('Error starting team member', { error: error instanceof Error ? error.message : String(error) });
         return {
             success: false,
             memberName: member.name,
@@ -325,7 +327,7 @@ async function _stopTeamMemberCore(context, team, member) {
         if (member.sessionName) {
             const stopResult = await context.agentRegistrationService.terminateAgentSession(member.sessionName, member.role);
             if (!stopResult.success) {
-                console.error('Failed to terminate team member session:', stopResult.error);
+                logger.error('Failed to terminate team member session', { error: stopResult.error });
                 return {
                     success: false,
                     memberName: member.name,
@@ -353,7 +355,7 @@ async function _stopTeamMemberCore(context, team, member) {
         };
     }
     catch (error) {
-        console.error('Error stopping team member:', error);
+        logger.error('Error stopping team member', { error: error instanceof Error ? error.message : String(error) });
         return {
             success: false,
             memberName: member.name,
@@ -462,7 +464,7 @@ export async function createTeam(req, res) {
         });
     }
     catch (error) {
-        console.error('Error creating team:', error);
+        logger.error('Error creating team', { error: error instanceof Error ? error.message : String(error) });
         res.status(500).json({
             success: false,
             error: error instanceof Error ? error.message : 'Failed to create team'
@@ -513,7 +515,7 @@ export async function getTeams(req, res) {
         });
     }
     catch (error) {
-        console.error('Error getting teams:', error);
+        logger.error('Error getting teams', { error: error instanceof Error ? error.message : String(error) });
         res.status(500).json({
             success: false,
             error: 'Failed to retrieve teams'
@@ -570,7 +572,7 @@ export async function getTeam(req, res) {
         res.json({ success: true, data: team });
     }
     catch (error) {
-        console.error('Error getting team:', error);
+        logger.error('Error getting team', { error: error instanceof Error ? error.message : String(error) });
         res.status(500).json({ success: false, error: 'Failed to retrieve team' });
     }
 }
@@ -654,7 +656,7 @@ export async function startTeam(req, res) {
         });
     }
     catch (error) {
-        console.error('Error starting team:', error);
+        logger.error('Error starting team', { error: error instanceof Error ? error.message : String(error) });
         res.status(500).json({ success: false, error: 'Failed to start team' });
     }
 }
@@ -717,13 +719,13 @@ export async function stopTeam(req, res) {
                 }
             }
             catch (error) {
-                console.error('Error cancelling team scheduled messages:', error);
+                logger.error('Error cancelling team scheduled messages', { error: error instanceof Error ? error.message : String(error) });
             }
         }
         res.json({ success: true, message: `Team stopped. Stopped ${sessionsStopped} sessions, ${sessionsNotFound} were already stopped.`, data: { sessionsStopped, sessionsNotFound, results } });
     }
     catch (error) {
-        console.error('Error stopping team:', error);
+        logger.error('Error stopping team', { error: error instanceof Error ? error.message : String(error) });
         res.status(500).json({ success: false, error: 'Failed to stop team' });
     }
 }
@@ -747,7 +749,7 @@ export async function getTeamWorkload(req, res) {
         res.json({ success: true, data: { teamId: id, teamName: team.name, assignedTickets, completedTickets, workloadPercentage: assignedTickets > 0 ? Math.round((completedTickets / assignedTickets) * 100) : 0 } });
     }
     catch (error) {
-        console.error('Error getting team workload:', error);
+        logger.error('Error getting team workload', { error: error instanceof Error ? error.message : String(error) });
         res.status(500).json({ success: false, error: 'Failed to retrieve team workload' });
     }
 }
@@ -774,7 +776,7 @@ export async function deleteTeam(req, res) {
             }
         }
         catch (notificationError) {
-            console.warn('Failed to notify orchestrator about team deletion:', notificationError);
+            logger.warn('Failed to notify orchestrator about team deletion', { error: notificationError instanceof Error ? notificationError.message : String(notificationError) });
         }
         if (team.members && team.members.length > 0) {
             for (const member of team.members) {
@@ -784,7 +786,7 @@ export async function deleteTeam(req, res) {
                         this.schedulerService.cancelAllChecksForSession(member.sessionName);
                     }
                     catch (error) {
-                        console.warn(`Failed to kill session for member ${member.name}:`, error);
+                        logger.warn('Failed to kill session for member', { memberName: member.name, error: error instanceof Error ? error.message : String(error) });
                     }
                 }
             }
@@ -793,7 +795,7 @@ export async function deleteTeam(req, res) {
         res.json({ success: true, message: 'Team terminated successfully' });
     }
     catch (error) {
-        console.error('Error deleting team:', error);
+        logger.error('Error deleting team', { error: error instanceof Error ? error.message : String(error) });
         res.status(500).json({ success: false, error: 'Failed to terminate team' });
     }
 }
@@ -820,7 +822,7 @@ export async function getTeamMemberSession(req, res) {
         res.json({ success: true, data: { memberId: member.id, memberName: member.name, sessionName: member.sessionName, output, timestamp: new Date().toISOString() } });
     }
     catch (error) {
-        console.error('Error getting team member session:', error);
+        logger.error('Error getting team member session', { error: error instanceof Error ? error.message : String(error) });
         res.status(500).json({ success: false, error: 'Failed to get team member session' });
     }
 }
@@ -857,7 +859,7 @@ export async function addTeamMember(req, res) {
         res.json({ success: true, data: newMember, message: 'Team member added successfully' });
     }
     catch (error) {
-        console.error('Error adding team member:', error);
+        logger.error('Error adding team member', { error: error instanceof Error ? error.message : String(error) });
         res.status(500).json({ success: false, error: 'Failed to add team member' });
     }
 }
@@ -883,7 +885,7 @@ export async function updateTeamMember(req, res) {
         res.json({ success: true, data: updatedMember, message: 'Team member updated successfully' });
     }
     catch (error) {
-        console.error('Error updating team member:', error);
+        logger.error('Error updating team member', { error: error instanceof Error ? error.message : String(error) });
         res.status(500).json({ success: false, error: 'Failed to update team member' });
     }
 }
@@ -907,7 +909,7 @@ export async function deleteTeamMember(req, res) {
                 await this.tmuxService.killSession(member.sessionName);
             }
             catch (error) {
-                console.warn(`Failed to kill tmux session ${member.sessionName}:`, error);
+                logger.warn('Failed to kill tmux session', { sessionName: member.sessionName, error: error instanceof Error ? error.message : String(error) });
             }
         }
         team.members.splice(memberIndex, 1);
@@ -916,7 +918,7 @@ export async function deleteTeamMember(req, res) {
         res.json({ success: true, message: 'Team member removed successfully' });
     }
     catch (error) {
-        console.error('Error deleting team member:', error);
+        logger.error('Error deleting team member', { error: error instanceof Error ? error.message : String(error) });
         res.status(500).json({ success: false, error: 'Failed to delete team member' });
     }
 }
@@ -995,7 +997,7 @@ export async function startTeamMember(req, res) {
         }
     }
     catch (error) {
-        console.error('Error starting team member:', error);
+        logger.error('Error starting team member', { error: error instanceof Error ? error.message : String(error) });
         res.status(500).json({ success: false, error: 'Failed to start team member' });
     }
 }
@@ -1034,7 +1036,7 @@ export async function stopTeamMember(req, res) {
         }
     }
     catch (error) {
-        console.error('Error stopping team member:', error);
+        logger.error('Error stopping team member', { error: error instanceof Error ? error.message : String(error) });
         res.status(500).json({ success: false, error: 'Failed to stop team member' });
     }
 }
@@ -1064,12 +1066,12 @@ export async function reportMemberReady(req, res) {
             }
         }
         if (!memberFound) {
-            console.warn(`Session ${sessionName} not found in any team, but reporting ready anyway`);
+            logger.warn('Session not found in any team, but reporting ready anyway', { sessionName });
         }
         res.json({ success: true, message: `Agent ${sessionName} reported ready with role ${role}`, data: { sessionName, role, capabilities, readyAt } });
     }
     catch (error) {
-        console.error('Error reporting member ready:', error);
+        logger.error('Error reporting member ready', { error: error instanceof Error ? error.message : String(error) });
         res.status(500).json({ success: false, error: 'Failed to report member ready' });
     }
 }
@@ -1106,7 +1108,7 @@ export async function registerMemberStatus(req, res) {
                 return;
             }
             catch (error) {
-                console.error('Error updating orchestrator status:', error);
+                logger.error('Error updating orchestrator status', { error: error instanceof Error ? error.message : String(error) });
                 res.status(500).json({ success: false, error: 'Failed to update orchestrator status' });
                 return;
             }
@@ -1130,7 +1132,7 @@ export async function registerMemberStatus(req, res) {
         }
         // Load fresh team data and apply registration changes to avoid race conditions
         if (!targetTeamId || !targetMemberId) {
-            console.warn(`registerMemberStatus: agent not found in any team`, { sessionName, role, memberId });
+            logger.warn('registerMemberStatus: agent not found in any team', { sessionName, role, memberId });
             res.status(404).json({ success: false, error: `Agent with sessionName '${sessionName}' not found in any team` });
             return;
         }
@@ -1157,7 +1159,7 @@ export async function registerMemberStatus(req, res) {
             }
             catch (persistError) {
                 // Non-fatal: resume just won't work on next restart
-                console.warn('Failed to persist claudeSessionId:', persistError);
+                logger.warn('Failed to persist claudeSessionId', { error: persistError instanceof Error ? persistError.message : String(persistError) });
             }
         }
         res.json({ success: true, message: `Agent ${sessionName} registered as active with role ${role}`, data: { sessionName, role, status: CREWLY_CONSTANTS.AGENT_STATUSES.ACTIVE, registeredAt: registeredAt || new Date().toISOString() } });
@@ -1166,16 +1168,16 @@ export async function registerMemberStatus(req, res) {
         if (subAgentQueue.hasPending(sessionName)) {
             const runtimeType = (freshTeam?.members.find(m => m.id === targetMemberId)?.runtimeType || RUNTIME_TYPES.CLAUDE_CODE);
             const queuedMessages = subAgentQueue.dequeueAll(sessionName);
-            console.log(`[registerMemberStatus] Flushing ${queuedMessages.length} queued message(s) to ${sessionName}`);
+            logger.info('Flushing queued messages', { count: queuedMessages.length, sessionName });
             // Deliver sequentially in the background
             (async () => {
                 for (const queuedMsg of queuedMessages) {
                     try {
                         await this.agentRegistrationService.sendMessageToAgent(sessionName, queuedMsg.data, runtimeType);
-                        console.log(`[registerMemberStatus] Delivered queued message to ${sessionName} (queued at ${new Date(queuedMsg.queuedAt).toISOString()})`);
+                        logger.info('Delivered queued message', { sessionName, queuedAt: new Date(queuedMsg.queuedAt).toISOString() });
                     }
                     catch (flushError) {
-                        console.error(`[registerMemberStatus] Failed to deliver queued message to ${sessionName}:`, flushError);
+                        logger.error('Failed to deliver queued message', { sessionName, error: flushError instanceof Error ? flushError.message : String(flushError) });
                     }
                     // Delay between messages to let the agent process each one
                     if (queuedMessages.indexOf(queuedMsg) < queuedMessages.length - 1) {
@@ -1183,12 +1185,12 @@ export async function registerMemberStatus(req, res) {
                     }
                 }
             })().catch(err => {
-                console.error(`[registerMemberStatus] Queue flush failed for ${sessionName}:`, err);
+                logger.error('Queue flush failed', { sessionName, error: err instanceof Error ? err.message : String(err) });
             });
         }
     }
     catch (error) {
-        console.error('Error in registerMemberStatus:', error);
+        logger.error('Error in registerMemberStatus', { error: error instanceof Error ? error.message : String(error) });
         res.status(500).json({ success: false, error: 'Failed to register member status' });
     }
 }
@@ -1222,7 +1224,7 @@ export async function generateMemberContext(req, res) {
         res.json({ success: true, data: { teamId, memberId, memberName: member.name, contextPrompt, generatedAt: new Date().toISOString() } });
     }
     catch (error) {
-        console.error('Error generating member context:', error);
+        logger.error('Error generating member context', { error: error instanceof Error ? error.message : String(error) });
         res.status(500).json({ success: false, error: 'Failed to generate member context' });
     }
 }
@@ -1256,7 +1258,7 @@ export async function injectContextIntoSession(req, res) {
         res.json({ success: true, data: { teamId, memberId, memberName: member.name, sessionName: member.sessionName, contextInjected: true, injectedAt: new Date().toISOString() } });
     }
     catch (error) {
-        console.error('Error injecting context into session:', error);
+        logger.error('Error injecting context into session', { error: error instanceof Error ? error.message : String(error) });
         res.status(500).json({ success: false, error: 'Failed to inject context into session' });
     }
 }
@@ -1286,7 +1288,7 @@ export async function refreshMemberContext(req, res) {
         res.json({ success: true, data: { teamId, memberId, memberName: member.name, contextPath, refreshedAt: new Date().toISOString() } });
     }
     catch (error) {
-        console.error('Error refreshing member context:', error);
+        logger.error('Error refreshing member context', { error: error instanceof Error ? error.message : String(error) });
         res.status(500).json({ success: false, error: 'Failed to refresh member context' });
     }
 }
@@ -1384,7 +1386,7 @@ export async function getTeamActivityStatus(req, res) {
                             });
                         }
                         catch (error) {
-                            console.error(`Error checking activity for member ${member.id}:`, error);
+                            logger.error('Error checking activity for member', { memberId: member.id, error: error instanceof Error ? error.message : String(error) });
                             // Clear terminal output on error to prevent memory leak
                             delete mutableMember.lastTerminalOutput;
                             const currentTask = tasksByMember.get(member.id) || null;
@@ -1449,7 +1451,7 @@ export async function getTeamActivityStatus(req, res) {
         });
     }
     catch (error) {
-        console.error('Error checking team activity status:', error);
+        logger.error('Error checking team activity status', { error: error instanceof Error ? error.message : String(error) });
         res.status(500).json({ success: false, error: 'Failed to check team activity status' });
     }
 }
@@ -1531,7 +1533,7 @@ export async function updateTeamMemberRuntime(req, res) {
         });
     }
     catch (error) {
-        console.error('Error updating team member runtime:', error);
+        logger.error('Error updating team member runtime', { error: error instanceof Error ? error.message : String(error) });
         res.status(500).json({
             success: false,
             error: 'Failed to update team member runtime'
@@ -1646,7 +1648,7 @@ export async function updateTeam(req, res) {
         });
     }
     catch (error) {
-        console.error('Error updating team:', error);
+        logger.error('Error updating team', { error: error instanceof Error ? error.message : String(error) });
         res.status(500).json({
             success: false,
             error: 'Failed to update team'