crewforth 3.4.0 → 3.5.0-rc.1

package/kit/studio/web/map-plan.js

@@ -315,6 +315,14 @@ export function inspectOf(node, doc, edges, findings) {
       other: node.structure?.otherFiles ?? 0,
       tests: node.structure?.testFiles ?? 0,
     } : null,
+    // Where its tests are (its own test files and a test project named for it), how often it changed in the commits
+    // the scan read, and the WHY/HACK/FIXME lines in its code: what someone about to change it asks first.
+    testFiles: Array.isArray(node.tests?.files) ? node.tests.files.filter((f) => typeof f === 'string') : [],
+    testTotal: Number.isInteger(node.tests?.total) ? node.tests.total : 0,
+    changed: Number.isInteger(node.commits) && Number.isInteger(doc?.source?.commitsRead) && doc.source.commitsRead > 0
+      ? `Changed in ${node.commits} of the last ${doc.source.commitsRead} ${doc.source.commitsRead === 1 ? 'commit' : 'commits'}` : null,
+    notes: (node.markers?.evidence ?? []).filter((e) => e && typeof e.file === 'string').map((e) => ({ at: `${e.file}:${e.line}`, text: String(e.text ?? '') })),
+    notesTotal: node.markers?.evidenceTotal ?? (node.markers?.evidence ?? []).length,
     connectsTo: out,
     connections: { out, in: into },
     byKind: Object.entries(byKind).sort(([a], [b]) => (a < b ? -1 : a > b ? 1 : 0)),
@@ -385,23 +393,61 @@ export function layoutOf(nodes, { width = 960, chips = {}, rowKey = null } = {})
   return { bands, pos, width: Math.max(width, right + GAP_X), height: y };
 }
 
-/** A line between two cards: out of the bottom of the upper one into the top of the lower, or side to side. */
-export function pathOf(a, b) {
+/**
+ * A line between two cards: out of the bottom of the upper one into the top of the lower, or side to side.
+ * `pa` and `pb` say where along its side the line leaves `a` and enters `b`, as a fraction of that side (½ = the
+ * middle); `routesOf` spreads them so lines that share a side do not share a pixel.
+ */
+export function pathOf(a, b, pa = 0.5, pb = 0.5) {
   if (!a || !b) return null;
   const down = b.y >= a.y + a.h;
   const up = a.y >= b.y + b.h;
   if (down || up) {
-    const [s, t] = down ? [a, b] : [b, a];
-    const x1 = s.x + s.w / 2; const y1 = s.y + s.h; const x2 = t.x + t.w / 2; const y2 = t.y;
+    const [s, t, fs, ft] = down ? [a, b, pa, pb] : [b, a, pb, pa];
+    const x1 = s.x + s.w * fs; const y1 = s.y + s.h; const x2 = t.x + t.w * ft; const y2 = t.y;
     const m = (y1 + y2) / 2;
     return { d: `M${x1} ${y1} C${x1} ${m} ${x2} ${m} ${x2} ${y2}`, mid: [(x1 + x2) / 2, m] };
   }
-  const [s, t] = a.x <= b.x ? [a, b] : [b, a];
-  const x1 = s.x + s.w; const y1 = s.y + s.h / 2; const x2 = t.x; const y2 = t.y + t.h / 2;
-  return { d: `M${x1} ${y1} L${x2} ${y2}`, mid: [(x1 + x2) / 2, (y1 + y2) / 2] };
+  const [s, t, fs, ft] = a.x <= b.x ? [a, b, pa, pb] : [b, a, pb, pa];
+  const x1 = s.x + s.w; const y1 = s.y + s.h * fs; const x2 = t.x; const y2 = t.y + t.h * ft;
+  const mx = (x1 + x2) / 2;
+  // Level ends are one straight line; ends at two heights turn square halfway, so no line runs on a slant.
+  if (y1 === y2) return { d: `M${x1} ${y1} L${x2} ${y2}`, mid: [mx, y1] };
+  return { d: `M${x1} ${y1} H${mx} V${y2} H${x2}`, mid: [mx, (y1 + y2) / 2] };
+}
+
+/**
+ * Every edge's line, with the lines that leave or enter one side of one card spread along it: the k-th of N at
+ * k/(N+1), ranked by where the other end sits, so neighbours do not cross. Measured on the crew-map-test fixtures and
+ * Crewforth's own map before this: 48 line ends shared a pixel with another across 46 edges, so a card with three
+ * dependents showed one line. A side with one line keeps the middle, as before.
+ */
+export function routesOf(edges, pos) {
+  const sides = new Map();
+  const add = (key, i, c) => { if (!sides.has(key)) sides.set(key, []); sides.get(key).push({ i, c }); };
+  const geo = edges.map((e, i) => {
+    const a = pos[e.from]; const b = pos[e.to];
+    if (!a || !b) return null;
+    const vertical = b.y >= a.y + a.h || a.y >= b.y + b.h;
+    if (vertical) {
+      const aBelow = a.y >= b.y + b.h;
+      const ka = `${e.from}:${aBelow ? 'top' : 'bottom'}`; const kb = `${e.to}:${aBelow ? 'bottom' : 'top'}`;
+      add(ka, i, b.x + b.w / 2); add(kb, i, a.x + a.w / 2);
+      return { a, b, ka, kb };
+    }
+    const aLeft = a.x <= b.x;
+    const ka = `${e.from}:${aLeft ? 'right' : 'left'}`; const kb = `${e.to}:${aLeft ? 'left' : 'right'}`;
+    add(ka, i, b.y + b.h / 2); add(kb, i, a.y + a.h / 2);
+    return { a, b, ka, kb };
+  });
+  const at = new Map();
+  for (const [key, list] of sides) {
+    list.sort((p, q) => p.c - q.c || p.i - q.i);
+    list.forEach((p, k) => at.set(`${key}|${p.i}`, (k + 1) / (list.length + 1)));
+  }
+  return geo.map((g, i) => (g ? pathOf(g.a, g.b, at.get(`${g.ka}|${i}`), at.get(`${g.kb}|${i}`)) : null));
 }
 
-/** The endpoint chips of a module, as the Endpoints layer lists them: what it provides, then what it calls. */
 export function chipsOf(node, doc) {
   const p = (doc.provides?.endpoints ?? []).filter((e) => e.module === node.id).map((e) => `${e.method} ${e.path}`);
   const c = (doc.consumes?.endpoints ?? []).filter((e) => e.module === node.id).map((e) => `→ ${e.method} ${e.path}`);

package/kit/studio/web/map.js

@@ -10,7 +10,7 @@
 // nothing; what leaves the page is copied text: a finding as a task, or a file:line.
 import {
   nodesOf, edgesOf, edgeKey, litEdges, findingsOf, findingCounts, cardSub, summaryOf, sourceOf, inspectOf, taskOf,
-  emptyNote, layoutOf, pathOf, chipsOf, inferredOnly, groupsOf, foldView, placed, BANDS, cardOf, tourOf, searchOf, resourceWord,
+  emptyNote, layoutOf, routesOf, chipsOf, inferredOnly, groupsOf, foldView, placed, BANDS, cardOf, tourOf, searchOf, resourceWord,
 } from './map-plan.js';
 import { Viewport, draggable, swallowClick } from './viewport.js';
 
@@ -231,8 +231,9 @@ export class MapView {
     }
     const lines = svg('svg', { class: 'mp-lines', width: lay.width, height: lay.height, 'aria-hidden': 'true' });
     const labels = [];
-    for (const e of edges) {
-      const p = pathOf(lay.pos[e.from], lay.pos[e.to]);
+    const routes = routesOf(edges, lay.pos);
+    for (const [ei, e] of edges.entries()) {
+      const p = routes[ei];
       if (!p) continue;
       const path = svg('path', { d: p.d, class: 'mp-line' });
       path.dataset.solid = String(e.solid);
@@ -495,6 +496,17 @@ export class MapView {
           if (v.inside.other) sec.append(mk('p', 'sub', `${v.inside.other} more files in other folders`));
           if (v.inside.tests) sec.append(mk('p', 'sub', `${v.inside.tests} test ${v.inside.tests === 1 ? 'file' : 'files'}`));
         }
+        if (v.changed) sec.append(mk('p', 'sub', v.changed));
+        if (v.testFiles.length) {
+          sec.append(mk('span', 'lbl', `Tests · ${v.testTotal}`));
+          for (const f of v.testFiles) { const r = mk('div', 'mp-conn mp-inside'); r.append(mk('span', 'mp-file', f)); sec.append(r); }
+          if (v.testTotal > v.testFiles.length) sec.append(mk('p', 'sub', `${v.testTotal - v.testFiles.length} more in the map file`));
+        }
+        if (v.notes.length) {
+          sec.append(mk('span', 'lbl', `Notes in the code · ${v.notesTotal}`));
+          for (const x of v.notes) { const r = mk('div', 'mp-conn mp-inside'); r.append(this.#cite(x.at), mk('span', 'mp-ev', x.text)); sec.append(r); }
+          if (v.notesTotal > v.notes.length) sec.append(mk('p', 'sub', `${v.notesTotal - v.notes.length} more in the map file`));
+        }
         sec.append(mk('span', 'lbl', 'Connects to'));
         if (!v.connectsTo.length) sec.append(mk('p', 'sub', 'Nothing on this map.'));
         for (const c of v.connectsTo) sec.append(this.#conn(c));

package/package.json

@@ -1,7 +1,7 @@
 {
   "name": "crewforth",
-  "version": "3.4.0",
-  "description": "Crewforth \u2014 your engineering crew for Claude Code: agents, skills and tool-level gates, in any stack.",
+  "version": "3.5.0-rc.1",
+  "description": "Crewforth — your engineering crew for Claude Code: agents, skills and tool-level gates, in any stack.",
   "bin": {
     "crewforth": "bin/cli.js"
   },
@@ -15,7 +15,8 @@
     "kit/",
     "VERSION",
     "LICENSE",
-    "README.md", "CHANGELOG.md"
+    "README.md",
+    "CHANGELOG.md"
   ],
   "engines": {
     "node": ">=20"
@@ -42,7 +43,7 @@
     "code-review",
     "git-hooks"
   ],
-  "author": "Bar\u0131\u015f Yerlikaya",
+  "author": "Barış Yerlikaya",
   "homepage": "https://crewforth.com/",
   "repository": {
     "type": "git",

package/start.sh

@@ -33,6 +33,15 @@ if [ "$_HELP_ONLY" = 0 ] && [ ! -d "$SRC" ]; then
   echo "start.sh and kit/ must be in the SAME directory (both come together when you unzip)."
   exit 1
 fi
+# A payload that lost files (a truncated archive, a folder dropped in a copy) is refused before the first write, so
+# a broken download says so instead of installing gates that fail on every call. English, like the check above: it
+# answers before the language is chosen. eval/lib/payload-check.sh says what it reads.
+if [ "$_HELP_ONLY" = 0 ] && [ "${CREW_PAYLOAD_UNCHECKED:-0}" != 1 ] && [ -f "$SRC/eval/lib/payload-check.sh" ]; then
+  _pc="$(bash "$SRC/eval/lib/payload-check.sh" "$SRC" 2>&1)" || {
+    echo "ERROR: the kit/ payload is incomplete — nothing installed:"; printf '%s\n' "$_pc" | sed 's/^/  /'
+    echo "Download it again (npx crewforth@latest, or a fresh archive). CREW_PAYLOAD_UNCHECKED=1 installs it anyway."
+    exit 1; }
+fi
 
 # Refuse to run inside a checkout of the kit's own source repository. This script ends by deleting
 # kit/ and itself, which is correct when the kit has been unpacked into a project and is being
@@ -569,7 +578,7 @@ count_installed() {   # $1=glob  -> count to install
 }
 N_AG="$(count_installed "$SRC/agents/*.md")"
 # Skills and commands the way the README and crewforth.com count them, so the install does not print a third number:
-# a skill whose metadata says `kind: command` is a command, one marked `experimental: true` is neither (it is
+# a skill whose metadata says `kind: command` is a command, one marked `experimental: "true"` is neither (it is
 # installed and works when typed, but nothing advertises it). Read from the frontmatter with builtins only.
 count_showcase() {   # $1 = a skills directory -> N_SKL N_CMD
   N_SKL=0; N_CMD=0; local f l k e d
@@ -577,7 +586,7 @@ count_showcase() {   # $1 = a skills directory -> N_SKL N_CMD
     [ -f "$f" ] || continue; k=0; e=0; d=0
     while IFS= read -r l || [ -n "$l" ]; do
       l="${l%$'\r'}"
-      case "$l" in ---) d=$((d+1)); [ "$d" -ge 2 ] && break ;; "  kind: command") k=1 ;; "  experimental: true") e=1 ;; esac
+      case "$l" in ---) d=$((d+1)); [ "$d" -ge 2 ] && break ;; "  kind: command") k=1 ;; "  experimental: true"|"  experimental: \"true\"") e=1 ;; esac
     done < "$f"
     [ "$e" = 1 ] && continue
     if [ "$k" = 1 ]; then N_CMD=$((N_CMD+1)); else N_SKL=$((N_SKL+1)); fi