creditu-common-library 2.3.3 → 2.3.4

package/debt/models/dto/debt-inputs.dto.d.ts

@@ -100,4 +100,8 @@ export declare class DebtInputs {
      * Relevante para la transacción y futura remesa, no así en boleto
     */
     codebtorLifeInsuranceProportion?: number;
+    /**
+     * Indica si se perdonan los gastos de cobranza para la cuota
+     */
+    isLateChargesFinePardoned?: boolean;
 }

package/debt/models/lates-input.dto.d.ts

@@ -12,4 +12,5 @@ export declare class LatesInput {
     monthNominalLength: number | MonthNominalLength;
     inflationExchangeMethodYearlyToMonthly: InterestType;
     isGraceMonth: boolean;
+    isLateChargesFinePardoned?: boolean;
 }

package/debt/services/installment.service.js

@@ -64,7 +64,8 @@ var InstallmentService = /** @class */ (function () {
             considerNegativeInflation: inputs.considerNegativeInflation,
             monthNominalLength: params.monthNominalLength,
             inflationExchangeMethodYearlyToMonthly: params.inflationExchangeMethodYearlyToMonthly,
-            isGraceMonth: inputs.isGraceMonth
+            isGraceMonth: inputs.isGraceMonth,
+            isLateChargesFinePardoned: inputs.isLateChargesFinePardoned
         }), lateDays = _d.lateDays, lateChargesFine = _d.lateChargesFine, lateInflation = _d.lateInflation, lateInflationaryCorrection = _d.lateInflationaryCorrection, lateChargesInterestRate = _d.lateChargesInterestRate, lateChargesInterest = _d.lateChargesInterest, lateInterestRate = _d.lateInterestRate, lateInterest = _d.lateInterest, lastMonthLateInflation = _d.lastMonthLateInflation, lastMonthLateChargesInterestRate = _d.lastMonthLateChargesInterestRate, lastMonthLateInterestRate = _d.lastMonthLateInterestRate, lastMonthTotalLateRate = _d.lastMonthTotalLateRate, totalLateRate = _d.totalLateRate, totalLateInterest = _d.totalLateInterest, totalLate = _d.totalLate, monthlyPaymentWithLate = _d.monthlyPaymentWithLate;
         var totalMonthlyPayment = monthlyPaymentWithLate;
         var response = {

package/debt/services/late.service.d.ts

@@ -26,5 +26,5 @@ export declare class LateService {
         monthlyPaymentWithLate: number;
     };
     getTotalMonthlyPayment(dueDate: string, today: string, monthlyPaymentWithTAC: number, lateChargesFineRate: number, lateChargesInterestRate: number, interestRate: number, inflationMapLate: Record<string, number>, dailyinflationvalues: number[]): Record<string, number>;
-    getLates({ dueDate, today, totalMonthlyPaymentBeforeLate, lateChargesFineRate, lateChargesInterestRate, annualCreditInterestRate, inflationMap, considerNegativeInflation, monthNominalLength, inflationExchangeMethodYearlyToMonthly, isGraceMonth }: LatesInput): LatesOutput;
+    getLates({ dueDate, today, totalMonthlyPaymentBeforeLate, lateChargesFineRate, lateChargesInterestRate, annualCreditInterestRate, inflationMap, considerNegativeInflation, monthNominalLength, inflationExchangeMethodYearlyToMonthly, isGraceMonth, isLateChargesFinePardoned }: LatesInput): LatesOutput;
 }

package/debt/services/late.service.js

@@ -125,7 +125,7 @@ var LateService = /** @class */ (function () {
     };
     LateService.prototype.getLates = function (_a) {
         var _this = this;
-        var dueDate = _a.dueDate, today = _a.today, totalMonthlyPaymentBeforeLate = _a.totalMonthlyPaymentBeforeLate, lateChargesFineRate = _a.lateChargesFineRate, lateChargesInterestRate = _a.lateChargesInterestRate, annualCreditInterestRate = _a.annualCreditInterestRate, inflationMap = _a.inflationMap, considerNegativeInflation = _a.considerNegativeInflation, monthNominalLength = _a.monthNominalLength, inflationExchangeMethodYearlyToMonthly = _a.inflationExchangeMethodYearlyToMonthly, isGraceMonth = _a.isGraceMonth;
+        var dueDate = _a.dueDate, today = _a.today, totalMonthlyPaymentBeforeLate = _a.totalMonthlyPaymentBeforeLate, lateChargesFineRate = _a.lateChargesFineRate, lateChargesInterestRate = _a.lateChargesInterestRate, annualCreditInterestRate = _a.annualCreditInterestRate, inflationMap = _a.inflationMap, considerNegativeInflation = _a.considerNegativeInflation, monthNominalLength = _a.monthNominalLength, inflationExchangeMethodYearlyToMonthly = _a.inflationExchangeMethodYearlyToMonthly, isGraceMonth = _a.isGraceMonth, _b = _a.isLateChargesFinePardoned, isLateChargesFinePardoned = _b === void 0 ? false : _b;
         var lates = {
             lateDays: 0,
             lateChargesFine: 0,
@@ -160,7 +160,8 @@ var LateService = /** @class */ (function () {
             return lates;
         }
         if (lateDays > 0) {
-            Object.assign(lates, { lateChargesFine: this.math.multiply(lateChargesFineRate, totalMonthlyPaymentBeforeLate) });
+            var actualLateChargesFineRate = isLateChargesFinePardoned ? 0 : lateChargesFineRate;
+            Object.assign(lates, { lateChargesFine: this.math.multiply(actualLateChargesFineRate, totalMonthlyPaymentBeforeLate) });
         }
         var monthlyInterestTypeFunction = {
             COMPOUND: function (a, b, proportion) { return _this.math.subtract(_this.math.multiply(_this.math.add(1 + a), Math.pow(_this.math.add(1 + b), proportion)), 1); },
@@ -169,7 +170,7 @@ var LateService = /** @class */ (function () {
         var monthlyCreditInterestRate = this.interestService.getCompoundPeriodicRate(annualCreditInterestRate, this.MONTHS_ON_YEAR);
         // fecha de inicio de loop es la fecha más temprana entre today y dueDate
         var whileDate = todayDateModel.isSameOrAfter(dueDateDateModel) ? dueDateDateModel : todayDateModel;
-        var _b = whileDate.toString('YYYY-MM-DD').split('-'), startingYear = _b[0], startingMonth = _b[1];
+        var _c = whileDate.toString('YYYY-MM-DD').split('-'), startingYear = _c[0], startingMonth = _c[1];
         // fecha de fin de loop es la fecha más tardía entre today y dueDate
         var endDate = todayDateModel.isSameOrAfter(dueDateDateModel) ? todayDateModel : dueDateDateModel;
         var isDueDate = whileDate.daysDiff(endDate) === 0;
@@ -184,7 +185,7 @@ var LateService = /** @class */ (function () {
                 break;
             }
             var isStartingMonth = "".concat(startingYear, "-").concat(startingMonth) === whileDate.toString('YYYY-MM-DD').substring(0, 7);
-            var _c = whileDate.toString('YYYY-MM-DD').split('-'), whileYear = _c[0], whileMonth = _c[1], whileDay = _c[2];
+            var _d = whileDate.toString('YYYY-MM-DD').split('-'), whileYear = _d[0], whileMonth = _d[1], whileDay = _d[2];
             var totalDaysInMonth = (new Date(Number(whileYear), Number(whileMonth), 0)).getDate(); // Deberíamos usar monthNominalLength??
             var isLastMonthsDay = totalDaysInMonth === Number(whileDay);
             var isLastDay = whileDate.toString('YYYY-MM-DD') === endDate.toString('YYYY-MM-DD');

package/debt/services/monthly-payment.service.js

@@ -33,7 +33,9 @@ var MonthlyPaymentService = /** @class */ (function () {
             inflationaryUpdate: inflationaryUpdate,
             postponedInflationaryUpdate: postponedInflationaryUpdate
         });
-        var monthlyPayment = this.math.add(interestIUB, this.math.subtract(amortizationIUB, amortizationDiff), this.math.subtract(inflationaryUpdate < 0 ? 0 : inflationaryUpdate, inflationaryUpdate < 0 ? 0 : postponedInflationaryUpdate));
+        var monthlyPayment = this.math.add(interestIUB, this.math.subtract(amortizationIUB, amortizationDiff), this.math.subtract(
+        // FIXME: Esto está mal para el caso FIXED con inflación negativa
+        inflationaryUpdate < 0 ? 0 : inflationaryUpdate, inflationaryUpdate < 0 ? 0 : postponedInflationaryUpdate));
         return monthlyPayment;
     };
     /**

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "creditu-common-library",
-  "version": "2.3.3",
+  "version": "2.3.4",
   "description": "",
   "main": "lib/index.js",
   "files": [

package/test/br/new-installment.service.specto.ts

@@ -954,7 +954,7 @@ describe('installment-service', () => {
     });
   });
 
-  describe('Caso 4 - Gilvania Lopes da Silva Santos', () => {
+  describe('Caso 4 - Gilvania Lopes da Silva Santos - Cuota 8', () => {
     // Parámetros de este caso
     const isGraceMonth = false;
     const isAmortizationPostponed = true;
@@ -1091,6 +1091,143 @@ describe('installment-service', () => {
     });
   });
 
+  describe('Caso 4 - Gilvania Lopes da Silva Santos - Cuota 10', () => {
+    // Parámetros de este caso
+    const isGraceMonth = false;
+    const isAmortizationPostponed = true;
+    const numberOfMonths = new NumberOfMonths(360);
+    const paymentNumber = new PaymentNumber(10);
+    const amortizationMethod = AmortizationMethod.GERMAN;
+    const previousBalance = new PreviousBalance(460677.02);
+    const annualRate = 0.095;
+    const inflationaryUpperBound = 0.003;
+    const codebtorLifeInsuranceProportion = 0;
+    const propertyAmount = 537000;
+    const considerNegativeInflation = false;
+    const considerTAC = true;
+    const TACValue = 25;
+    const monthlyCreditInsuranceExpenses = 1065;
+    const monthlyCreditInsurancePrize = 1977.95;
+    const monthlyCreditInsurance = monthlyCreditInsuranceExpenses + monthlyCreditInsurancePrize;
+    // Inflation map debe tener fechas e inflaciones (desfasadas 2 meses)
+    // desde el mes de vencimiento anterior (o fecha de firma) hasta vencimiento de cuota
+    const inflationMap = {
+      '2023-10-08': 0.0023,
+      '2023-11-08': 0.0026
+    };
+    // inflationMapLate debe tener fechas e inflaciones (desfasadas 2 meses)
+    // desde el vencimiento actual hasta el día de hoy (de consulta de deuda)
+    const inflationMapLate = {
+      '2023-11-08': 0.0026,
+      '2023-12-01': 0.0024
+    };
+    // Parámetros fijos
+    const propertyInsuranceRate = new CreditInsuranceRate(0.00003);
+    const debtorLifeInsuranceRate = new CreditInsuranceRate(0.00017);
+    const lateChargesFineRate = 0.02;
+    const lateChargesInterestRate = 0.01;
+    const upperBoundBehaviour = BehaviourCAP.FIXED;
+    const proportionUsesSimpleInterest = true;
+    const inflationExchangeMethodMonthlyToDaily = InterestType.SIMPLE;
+    const insurancesStrategy = InsurancesStrategy.BALANCES;
+    const monthNominalLength = 30;
+    const inflationExchangeMethodYearlyToMonthly = InterestType.COMPOUND;
+
+    it('should yield the right results', () => {
+      // const filePath = './test/br/Producto_LowCode-Desarrollo.xlsx';
+      // const excelValues = new ExcelTranslator(filePath);
+      const inputs: DebtInputs = {
+        today: '2023-12-01',
+        amortizationMethod,
+        isGraceMonth,
+        isAmortizationPostponed,
+        paymentNumber,
+        numberOfMonths,
+        previousBalance,
+        inflationaryUpperBound,
+        propertyAmount,
+        inflationMap,
+        inflationMapLate,
+        proportionUsesSimpleInterest,
+        upperBoundBehaviour,
+        codebtorLifeInsuranceProportion,
+        considerNegativeInflation,
+        considerTAC,
+        TACValue,
+        monthlyCreditInsurance,
+        monthlyCreditInsuranceExpenses,
+        monthlyCreditInsurancePrize
+      };
+      const params: DebtParams = {
+        annualRate,
+        debtorLifeInsuranceRate,
+        propertyInsuranceRate,
+        lateChargesFineRate,
+        lateChargesInterestRate,
+        monthNominalLength,
+        inflationExchangeMethodMonthlyToDaily,
+        insurancesStrategy,
+        inflationExchangeMethodYearlyToMonthly
+      };
+
+      const expectedResult = {
+        inflationByDates: [
+          {}
+        ],
+        balanceValues: {
+          balances: [
+          ],
+          balanceMonetaryUpdateValues: [
+          ]
+        },
+        balanceInflationaryUpdated: null,
+        balanceAfter: null,
+        inflationaryUpdate: null,
+        interest: null, // interestIUB - interestDiff
+        interestDiff: null, // Inflación dentro del interés 🟢
+        interestIUB: null, // Interés corregido ✅
+        monthlyPayment: null,
+        monthlyPaymentWithInsurances: null,
+        monthlyPaymentWithTAC: null,
+        amortization: null,
+        amortizationDiff: null,
+        amortizationIUB: null,
+        upperBound: null,
+        postponedInflationaryUpdate: null,
+        amortizationInflation: null,
+        TACValue: null,
+        totalLifeInsuranceFee: null,
+        debtorLifeInsuranceFee: null,
+        codebtorLifeInsuranceFee: null,
+        propertyInsuranceFee: null,
+        monthlyCreditInsurance: null,
+        monthlyCreditInsuranceExpenses: null,
+        monthlyCreditInsurancePrize: null,
+        lateDays: null,
+        lateChargesFine: null, // Multa en Excel
+        lateChargesInterestRate: null, // Tasa de castigo diaria acumulada en Excel
+        lateChargesInterest: null, // Pendiente de contrastar con el Excel
+        lateInterestRate: null, // Tasa de interés diaria ac. por atraso en Excel
+        lateInterest: null, // Pendiente de contrastar con el Excel
+        lateInflation: null, // Tasa corrección principal en Excel
+        lateInflationaryCorrection: null, // Pendiente de contrastar con el Excel
+        lastMonthLateChargesInterestRate: null, // Pendiente de contrastar con el Excel
+        lastMonthLateInflation: null, // Tasa de inflación mensual en Excel
+        lastMonthLateInterestRate: null, // Tasa de interés mensual por atraso en Excel
+        lastMonthTotalLateRate: null, // Pendiente de contrastar con el Excel
+        totalLateRate: null, // Tasa de penalidad en Excel
+        totalLateInterest: null, // Interés penal en Excel
+        totalLate: null, // Atraso en Excel
+        monthlyPaymentWithLate: null,
+        totalMonthlyPayment: null,
+        walletBalance: null
+      };
+      const result = service.getTotalMonthlyPayment(inputs, params);
+      console.log(getResultForComparison(result));
+      expect(result).toEqual(expectedResult);
+    });
+  });
+
   describe('Caso 5 - Ismael Oliveira Feitosa, cuota 0', () => {
     // Parámetros de este caso
     const isGraceMonth = true;
@@ -7867,7 +8004,7 @@ describe('installment-service', () => {
     });
   });
 
-  describe.only('Caso 45 - Eneas da Silva Dias, cuota 14', () => {
+  describe('Caso 45 - Eneas da Silva Dias, cuota 14', () => {
     // Parámetros de este caso
     const isGraceMonth = false;
     const isAmortizationPostponed = false;
@@ -8626,7 +8763,7 @@ describe('installment-service', () => {
     const walletBalance = 0;
     const considerWallet = false;
     // Parámetros fijos
-    const propertyInsuranceRate = new CreditInsuranceRate(0.000089);
+    const propertyInsuranceRate = new CreditInsuranceRate(0.000089); // No es zurich
     const debtorLifeInsuranceRate = new CreditInsuranceRate(0.00049);
     const codebtorLifeInsuranceRate = new CreditInsuranceRate(0.00049);
     const lateChargesFineRate = 0.02;
@@ -8737,4 +8874,152 @@ describe('installment-service', () => {
       // expect(result).toEqual(expectedResult);
     });
   });
+
+  describe.only('Caso 50 - Mauricio Camporeis, cuota 4 (isLateChargesFinePardoned: true)', () => {
+    // Parámetros de este caso
+    const isGraceMonth = false;
+    const isAmortizationPostponed = true;
+    const isLateChargesFinePardoned = true;
+    const numberOfMonths = new NumberOfMonths(241);
+    const paymentNumber = new PaymentNumber(4);
+    const amortizationMethod = AmortizationMethod.FRENCH;
+    const previousBalance = new PreviousBalance(196012.51);
+    const annualRate = 0.105;
+    const inflationaryUpperBound = 0.003;
+    const codebtorLifeInsuranceProportion = 0;
+    const propertyAmount = 244000;
+    const considerNegativeInflation = false;
+    const considerTAC = true;
+    const TACValue = 25;
+    const monthlyCreditInsurancePrize = 1098;
+    const monthlyCreditInsuranceExpenses = 366;
+    const monthlyCreditInsurance = monthlyCreditInsuranceExpenses + monthlyCreditInsurancePrize;
+    // Inflation map debe tener fechas e inflaciones (desfasadas 2 meses)
+    // desde el mes de vencimiento anterior (o fecha de firma) hasta vencimiento de cuota
+    const inflationMap = {
+      '2023-10-08': 0.0023,
+      '2023-11-08': 0.0026
+    };
+    // inflationMapLate debe tener fechas e inflaciones (desfasadas 2 meses)
+    // desde el vencimiento actual hasta el día de hoy (de consulta de deuda)
+    const inflationMapLate = {
+      '2023-11-08': 0.0026,
+      '2023-12-01': 0.0024
+    };
+    const upperBoundBehaviour = BehaviourCAP.FIXED;
+    const walletBalance = 0;
+    const considerWallet = false;
+    // Parámetros fijos
+    const propertyInsuranceRate = new CreditInsuranceRate(0.00003);
+    const debtorLifeInsuranceRate = new CreditInsuranceRate(0.00017);
+    const codebtorLifeInsuranceRate = new CreditInsuranceRate(0);
+    const lateChargesFineRate = 0.02;
+    const lateChargesInterestRate = 0.01;
+    const proportionUsesSimpleInterest = true;
+    const inflationExchangeMethodMonthlyToDaily = InterestType.SIMPLE;
+    const insurancesStrategy = InsurancesStrategy.BALANCES;
+    const monthNominalLength = 30;
+    const inflationExchangeMethodYearlyToMonthly = InterestType.COMPOUND;
+
+    it('should yield the right results', () => {
+      // const filePath = './test/br/Producto_LowCode-Desarrollo.xlsx';
+      // const excelValues = new ExcelTranslator(filePath);
+      const inputs: DebtInputs = {
+        today: '2023-12-01',
+        amortizationMethod,
+        isGraceMonth,
+        isAmortizationPostponed,
+        paymentNumber,
+        numberOfMonths,
+        previousBalance,
+        inflationaryUpperBound,
+        propertyAmount,
+        inflationMap,
+        inflationMapLate,
+        proportionUsesSimpleInterest,
+        upperBoundBehaviour,
+        codebtorLifeInsuranceProportion,
+        considerNegativeInflation,
+        considerTAC,
+        TACValue,
+        monthlyCreditInsurance,
+        monthlyCreditInsuranceExpenses,
+        monthlyCreditInsurancePrize,
+        walletBalance,
+        considerWallet,
+        isLateChargesFinePardoned
+      };
+      const params: DebtParams = {
+        annualRate,
+        debtorLifeInsuranceRate,
+        codebtorLifeInsuranceRate,
+        propertyInsuranceRate,
+        lateChargesFineRate,
+        lateChargesInterestRate,
+        monthNominalLength,
+        inflationExchangeMethodMonthlyToDaily,
+        insurancesStrategy,
+        inflationExchangeMethodYearlyToMonthly
+      };
+
+      const expectedResult = {
+        inflationByDates: [
+          {}
+        ],
+        balanceValues: {
+          balances: [
+          ],
+          balanceMonetaryUpdateValues: [
+          ]
+        },
+        balanceInflationaryUpdated: null,
+        balanceAfter: null,
+        inflationaryUpdate: null,
+        interest: null, // interestIUB - interestDiff
+        interestDiff: null, // Inflación dentro del interés 🟢
+        interestIUB: null, // Interés corregido ✅
+        monthlyPayment: null,
+        monthlyPaymentWithInsurances: null,
+        monthlyPaymentWithTAC: null,
+        amortization: null,
+        amortizationDiff: null,
+        amortizationIUB: null,
+        upperBound: null,
+        postponedInflationaryUpdate: null,
+        amortizationInflation: null,
+        TACValue: null,
+        totalLifeInsuranceFee: null,
+        debtorLifeInsuranceFee: null,
+        codebtorLifeInsuranceFee: null,
+        propertyInsuranceFee: null,
+        monthlyCreditInsurance: null,
+        monthlyCreditInsuranceExpenses: null,
+        monthlyCreditInsurancePrize: null,
+        lateDays: null,
+        lateChargesFine: null, // Multa en Excel
+        lateChargesInterestRate: null, // Tasa de castigo diaria acumulada en Excel
+        lateChargesInterest: null, // Pendiente de contrastar con el Excel
+        lateInterestRate: null, // Tasa de interés diaria ac. por atraso en Excel
+        lateInterest: null, // Pendiente de contrastar con el Excel
+        lateInflation: null, // Tasa corrección principal en Excel
+        lateInflationaryCorrection: null, // Pendiente de contrastar con el Excel
+        lastMonthLateChargesInterestRate: null, // Pendiente de contrastar con el Excel
+        lastMonthLateInflation: null, // Tasa de inflación mensual en Excel
+        lastMonthLateInterestRate: null, // Tasa de interés mensual por atraso en Excel
+        lastMonthTotalLateRate: null, // Pendiente de contrastar con el Excel
+        totalLateRate: null, // Tasa de penalidad en Excel
+        totalLateInterest: null, // Interés penal en Excel
+        totalLate: null, // Atraso en Excel
+        monthlyPaymentWithLate: null,
+        totalMonthlyPayment: null,
+        walletBalance: null
+      };
+      const result = service.getTotalMonthlyPayment(inputs, params);
+      const resultForComparison = getResultForComparison(result);
+      // console.log(result);
+      // console.log(JSON.stringify(getResultForComparison(result), null, 2));
+      // console.log(Object.values(resultForComparison).join('\n'));
+      // expect(result).toEqual(expectedResult);
+    });
+  });
 });