creditu-common-library 2.3.14 → 2.3.16

package/README.md

@@ -1,7 +1,7 @@
 # Creditú CommonLibrary
 
 ## Descripción
-Esta librería, contiene los módulos y funciones matemáticas y financerias para el manejo de cálculos en el producto digital.
+Esta librería contiene los módulos y funciones matemáticas y financieras para el manejo de cálculos en el producto digital.
 
 ## Instalar en tu repositorio
 
@@ -21,7 +21,7 @@ La librería tiene dos módulos:
 
 - `Finance`: expone varios servicios orientados a un dominio específico, y cuyas funciones resuelven diversas fórmulas financieras en su ámbito.
 Los services expuestos son:
-  - `ConstantsService`: es un servicio auxiliar, que contiene funciones que calculan constantes que, a su vez, agrupan parametros conocidos para diversos propósitos en cálculos financieros.
+  - `ConstantsService`: es un servicio auxiliar, que contiene funciones que calculan constantes que, a su vez, agrupan parámetros conocidos para diversos propósitos en cálculos financieros.
   - `CreditInsuranceService`: este servicio tiene funciones de cálculo para el dominio `Seguros`.
   - `FinanceService`: este servicio auxiliar tiene funciones genéricas de funciones financieras, como interés anual, mensual, etc.
   - `PaymentService`: este servicio tiene funciones de cálculo para el dominio `Dividendo`.

package/middlewares/app-logger-middleware.d.ts

@@ -6,7 +6,10 @@ interface RequestWithStartTime extends Request {
 export declare class AppLoggerMiddleware implements NestMiddleware {
     private logger;
     constructor(logger?: Logger);
+    private readonly defaultSanitizeOptions;
     private logObject;
+    private isBase64;
+    private truncateValue;
     private sanitizeObject;
     use(request: RequestWithStartTime, response: Response, next: NextFunction): void;
 }

package/middlewares/app-logger-middleware.js

@@ -33,35 +33,91 @@ var AppLoggerMiddleware = /** @class */ (function () {
     function AppLoggerMiddleware(logger) {
         if (logger === void 0) { logger = new common_1.Logger('HTTP'); }
         this.logger = logger;
+        this.defaultSanitizeOptions = {
+            maxStringLength: 1000,
+            maxArrayLength: 10,
+            maxDepth: 5,
+            truncateBase64: true,
+            base64Preview: 50
+        };
         this.logObject = function (obj) { return (0, util_1.inspect)(obj, { showHidden: false, depth: null, colors: true }); };
     }
-    AppLoggerMiddleware.prototype.sanitizeObject = function (obj) {
+    AppLoggerMiddleware.prototype.isBase64 = function (str) {
+        try {
+            // Verifica si es una cadena base64 válida
+            return btoa(atob(str)) === str && str.length > 100; // Solo considera base64 si es largo
+        }
+        catch (err) {
+            return false;
+        }
+    };
+    AppLoggerMiddleware.prototype.truncateValue = function (value, options) {
+        if (typeof value === 'string') {
+            // Detectar y truncar base64
+            if (options.truncateBase64 && this.isBase64(value)) {
+                var preview = value.substring(0, options.base64Preview);
+                return "".concat(preview, "... [BASE64_TRUNCATED - Original length: ").concat(value.length, " chars]");
+            }
+            // Truncar strings largos
+            if (value.length > options.maxStringLength) {
+                return "".concat(value.substring(0, options.maxStringLength), "... [TRUNCATED - Original length: ").concat(value.length, " chars]");
+            }
+        }
+        return value;
+    };
+    AppLoggerMiddleware.prototype.sanitizeObject = function (obj, options, currentDepth) {
         var _this = this;
+        if (options === void 0) { options = this.defaultSanitizeOptions; }
+        if (currentDepth === void 0) { currentDepth = 0; }
         if (!obj)
             return obj;
-        // Si es string, lo devolvemos directamente
-        if (typeof obj === 'string')
-            return obj;
+        // Limitar profundidad para evitar recursión infinita
+        if (currentDepth > options.maxDepth) {
+            return '[MAX_DEPTH_REACHED]';
+        }
+        // Si es string, verificar si necesita truncado
+        if (typeof obj === 'string') {
+            return this.truncateValue(obj, options);
+        }
         // Si no es un objeto (número, booleano, etc.), lo devolvemos directamente
         if (typeof obj !== 'object')
             return obj;
         // Si es un array, sanitizamos cada elemento
         if (Array.isArray(obj)) {
-            return obj.map(function (item) { return _this.sanitizeObject(item); });
+            var truncatedArray = obj.slice(0, options.maxArrayLength);
+            var sanitizedArray = truncatedArray.map(function (item) { return _this.sanitizeObject(item, options, currentDepth + 1); });
+            // Si el array fue truncado, añadir información
+            if (obj.length > options.maxArrayLength) {
+                sanitizedArray.push("[ARRAY_TRUNCATED - Showing ".concat(options.maxArrayLength, " of ").concat(obj.length, " items]"));
+            }
+            return sanitizedArray;
         }
         // Si es un objeto, hacemos una copia para no modificar el original
         var sanitized = __assign({}, obj);
         // Lista de campos sensibles a ocultar
         var sensitiveFields = ['password', 'token', 'secret', 'apiKey', 'creditCard', 'Authorization'];
+        // Lista de campos que típicamente contienen datos grandes
+        var largeDataFields = ['file', 'image', 'document', 'attachment', 'data', 'content', 'buffer'];
         var _loop_1 = function (key) {
             // Si es un campo sensible, lo ocultamos
             if (sensitiveFields.some(function (field) { return key.toLowerCase().includes(field.toLowerCase()); })) {
                 sanitized[key] = '[REDACTED]';
                 // eslint-disable-next-line brace-style
             }
+            // Si es un campo que típicamente contiene datos grandes, usar opciones más restrictivas
+            else if (largeDataFields.some(function (field) { return key.toLowerCase().includes(field.toLowerCase()); })) {
+                var restrictiveOptions = __assign(__assign({}, options), { maxStringLength: 100, base64Preview: 30 });
+                sanitized[key] = this_1.sanitizeObject(sanitized[key], restrictiveOptions, currentDepth + 1);
+                // eslint-disable-next-line brace-style
+            }
             // Si es un objeto anidado, lo procesamos recursivamente
             else if (typeof sanitized[key] === 'object' && sanitized[key] !== null) {
-                sanitized[key] = this_1.sanitizeObject(sanitized[key]);
+                sanitized[key] = this_1.sanitizeObject(sanitized[key], options, currentDepth + 1);
+                // eslint-disable-next-line brace-style
+            }
+            // Para valores primitivos, aplicar truncado si es necesario
+            else {
+                sanitized[key] = this_1.truncateValue(sanitized[key], options);
             }
         };
         var this_1 = this;
@@ -75,8 +131,24 @@ var AppLoggerMiddleware = /** @class */ (function () {
     AppLoggerMiddleware.prototype.use = function (request, response, next) {
         // Añadir marca de tiempo al inicio de la petición
         request.startTime = Date.now();
+        // Opciones específicas para request (más permisivo)
+        var requestSanitizeOptions = {
+            maxStringLength: 500,
+            maxArrayLength: 5,
+            maxDepth: 3,
+            truncateBase64: true,
+            base64Preview: 30
+        };
+        // Opciones específicas para response (más restrictivo)
+        var responseSanitizeOptions = {
+            maxStringLength: 300,
+            maxArrayLength: 3,
+            maxDepth: 3,
+            truncateBase64: true,
+            base64Preview: 20
+        };
         // Captura del cuerpo de la solicitud (sanitizado)
-        var requestBody = this.sanitizeObject(request.body);
+        var requestBody = this.sanitizeObject(request.body, requestSanitizeOptions);
         // Interceptar el método write y end para capturar la respuesta
         var originalWrite = response.write;
         var originalEnd = response.end;
@@ -86,7 +158,7 @@ var AppLoggerMiddleware = /** @class */ (function () {
         // eslint-disable-next-line func-names
         response.send = function (body) {
             if (body && typeof body === 'object' && response.statusCode >= 400) {
-                var sanitizedBody = this.sanitizeObject(body);
+                var sanitizedBody = this.sanitizeObject(body, responseSanitizeOptions);
                 var responseTime = Date.now() - request.startTime;
                 this.logger.error("Error Response (".concat(response.statusCode, "): ").concat(JSON.stringify({
                     method: request.method,
@@ -107,7 +179,10 @@ var AppLoggerMiddleware = /** @class */ (function () {
             for (var _i = 1; _i < arguments.length; _i++) {
                 args[_i - 1] = arguments[_i];
             }
-            chunks.push(Buffer.from(chunk));
+            // Solo capturar chunks si no son demasiado grandes
+            if (chunks.length < 10 && chunk.length < 50000) {
+                chunks.push(Buffer.from(chunk));
+            }
             return originalWrite.apply(response, __spreadArray([chunk], args, true));
         };
         // Interceptar end
@@ -117,7 +192,7 @@ var AppLoggerMiddleware = /** @class */ (function () {
             for (var _i = 1; _i < arguments.length; _i++) {
                 args[_i - 1] = arguments[_i];
             }
-            if (chunk) {
+            if (chunk && chunks.length < 10 && chunk.length < 50000) {
                 chunks.push(Buffer.from(chunk));
             }
             var method = request.method, originalUrl = request.originalUrl;
@@ -127,16 +202,29 @@ var AppLoggerMiddleware = /** @class */ (function () {
             var responseBody = '';
             var parsedBody;
             if (chunks.length > 0) {
-                responseBody = Buffer.concat(chunks).toString('utf8');
-                try {
-                    parsedBody = JSON.parse(responseBody);
+                var totalSize = chunks.reduce(function (acc, chunk) { return acc + chunk.length; }, 0);
+                // Si el response es muy grande, no lo parseamos completo
+                if (totalSize > 100000) {
+                    parsedBody = "[RESPONSE_TOO_LARGE - Size: ".concat(totalSize, " bytes]");
                 }
-                catch (e) {
-                    parsedBody = responseBody;
+                else {
+                    responseBody = Buffer.concat(chunks).toString('utf8');
+                    try {
+                        parsedBody = JSON.parse(responseBody);
+                    }
+                    catch (e) {
+                        // Si no es JSON válido y es muy largo, truncarlo
+                        if (responseBody.length > 1000) {
+                            parsedBody = "".concat(responseBody.substring(0, 1000), "... [TRUNCATED]");
+                        }
+                        else {
+                            parsedBody = responseBody;
+                        }
+                    }
                 }
             }
             // Sanitizar la respuesta
-            var sanitizedResponseBody = this.sanitizeObject(parsedBody);
+            var sanitizedResponseBody = this.sanitizeObject(parsedBody, responseSanitizeOptions);
             // Mensaje base con tiempo de respuesta
             var baseMessage = "".concat(method, " ").concat(originalUrl, " ").concat(statusCode, " ").concat(statusMessage !== null && statusMessage !== void 0 ? statusMessage : '', " - ").concat(responseTime, "ms");
             // Mensaje detallado con cuerpos de solicitud y respuesta

package/offer/services/installment.service.d.ts

@@ -81,7 +81,7 @@ export declare class InstallmentService {
     baseBalance(numberOfGraceMonths: number, graceMonthsInterestMethod: GraceMonthsInterestMethod, monthlyInterestRate: number): number;
     /**
      * Calcula la cuota del crédito (Ccr)
-     * Mas info en {@link https://creditu-team.gitlab.io/wiki/content/journeys/acquisition/Offer.html#cuota-del-credito}
+     * Más info en {@link https://creditu-team.gitlab.io/wiki/content/journeys/acquisition/Offer.html#cuota-del-credito}
      * @param monthlyPayment Dividendo (D). Se obtiene amplificando el dividendo unitario (baseMonthlyPayment) por el monto aprobado.
      * @param creditInsuranceFee Cuota del seguro de crédito (C_s^cr)
      * @param lifeInsuranceFee Cuota del seguro de desgravamen (C_s^d)

package/offer/services/installment.service.js

@@ -157,7 +157,7 @@ var InstallmentService = /** @class */ (function () {
     };
     /**
      * Calcula la cuota del crédito (Ccr)
-     * Mas info en {@link https://creditu-team.gitlab.io/wiki/content/journeys/acquisition/Offer.html#cuota-del-credito}
+     * Más info en {@link https://creditu-team.gitlab.io/wiki/content/journeys/acquisition/Offer.html#cuota-del-credito}
      * @param monthlyPayment Dividendo (D). Se obtiene amplificando el dividendo unitario (baseMonthlyPayment) por el monto aprobado.
      * @param creditInsuranceFee Cuota del seguro de crédito (C_s^cr)
      * @param lifeInsuranceFee Cuota del seguro de desgravamen (C_s^d)

package/offer/services/offer.service.d.ts

@@ -1,7 +1,7 @@
-import { CreditInsurancePercentageFinanced, OperationalExpensesFinancing, CreditAmount, CreditTaxRate, CreditTaxRatePercentage } from '../../shared/models';
 import { MathService } from '../../math';
-import { OfferInputs, OfferParams, OfferResponse } from '../models/dto';
+import { CreditAmount, CreditInsurancePercentageFinanced, CreditTaxRate, CreditTaxRatePercentage, OperationalExpensesFinancing } from '../../shared/models';
 import { CreditInsuranceFeeTermDefinition } from '../../shared/models/enum/credit-insurance-fee-term-definition.enum';
+import { OfferInputs, OfferParams, OfferResponse } from '../models/dto';
 /**
  * Servicio que ofrece las funciones necesarias para diversos cálculos financieros.
  */
@@ -73,7 +73,6 @@ export declare class OfferService {
      * Más info en: {@link https://creditu-team.gitlab.io/wiki/content/journeys/acquisition/Offer.html#carga-financiera}
      * @param totalInstallment    Cuota Total (C_tot)
      * @param disposableIncome    Ingresos Mensuales (Im)
-     * @param maximumBackendRatio Máximo (CF)
      */
     getBackEndRatio(totalInstallment: number, disposableIncome: number): number;
     /**

package/offer/services/offer.service.js

@@ -1,17 +1,17 @@
 "use strict";
 Object.defineProperty(exports, "__esModule", { value: true });
 exports.OfferService = void 0;
-var models_1 = require("../../shared/models");
-var finance_service_1 = require("./finance.service");
 var math_1 = require("../../math");
+var models_1 = require("../../shared/models");
+var credit_insurance_fee_term_definition_enum_1 = require("../../shared/models/enum/credit-insurance-fee-term-definition.enum");
+var product_enum_1 = require("../models/product.enum");
+var constants_service_1 = require("./constants.service");
 var credit_insurance_service_1 = require("./credit-insurance.service");
+var finance_service_1 = require("./finance.service");
+var installment_service_1 = require("./installment.service");
 var loan_to_value_service_1 = require("./loan-to-value.service");
 var maximum_local_service_1 = require("./maximum-local.service");
-var installment_service_1 = require("./installment.service");
-var constants_service_1 = require("./constants.service");
 var operational_expenses_1 = require("./operational-expenses");
-var credit_insurance_fee_term_definition_enum_1 = require("../../shared/models/enum/credit-insurance-fee-term-definition.enum");
-var product_enum_1 = require("../models/product.enum");
 /**
  * Servicio que ofrece las funciones necesarias para diversos cálculos financieros.
  */
@@ -158,7 +158,7 @@ var OfferService = /** @class */ (function () {
         var debtGuaranteeViv = this.maximumLocal.debtGuaranteeViv(propertyValue, maximumPropertyLTV, k1Fin, k2Fin);
         var approvedAmountLoanToValue = this.maximumLocal.debtGuarantee(debtGuaranteeViv, debtGuaranteeCr);
         var approvedAmount = this.getApprovedAmount(approvedAmountFinanceCharge, maximumLocalIncomeDividend, approvedAmountLoanToValue);
-        var credituAmount = this.math.round(this.credituAmount(downPayment, subsidy, propertyValue, creditInsuranceFactor, creditInsurancePercentageFinanced, operationalExpensesWeightedSum, operationalExpensesFinancing, creditTaxRate, creditTaxRatePercentage, amountRequestedByClient), 2);
+        var credituAmount = Math.floor((this.credituAmount(downPayment, subsidy, propertyValue, creditInsuranceFactor, creditInsurancePercentageFinanced, operationalExpensesWeightedSum, operationalExpensesFinancing, creditTaxRate, creditTaxRatePercentage, amountRequestedByClient) * 100) / 100); // Redondear a dos decimales
         var creditAmount = this.getCreditAmountToOffer(approvedAmount, credituAmount, creditMinAmount, creditMaxAmount);
         var financingAmount = this.financingAmount(creditAmount, k1Fin, k2Fin);
         var installment = this.installment.getMonthlyPayment(baseMonthlyPayment, creditAmount);
@@ -169,7 +169,7 @@ var OfferService = /** @class */ (function () {
             : operationalExpensesFinanceable;
         var loanToValueCredit = this.ltv.credit(financingAmount, creditInsurancePremium, propertyValue, creditInsurancePercentageFinanced, operationalExpensesFinanced, operationalExpensesFinancing);
         var financingRatio = this.math.divide(financingAmount, amountRequestedByClient);
-        var loanToValueHome = this.ltv.home(financingAmount, propertyValue);
+        var loanToValueHome = this.ltv.home(credituAmount, propertyValue);
         var creditInsuranceInstallment = this.insurance.creditInsurance(financingAmount, creditInsuranceFactor, creditInsurancePercentageFinanced.value(), creditInsuranceNumberOfMonths, isCreditInsuranceAccelerated, creditInsurancePremium, numberOfGraceMonths, installment);
         var lifeInsuranceFee = this.insurance.lifeInsurance(creditAmount, totalLifeInsuranceMonthlyRate);
         var propertyInsuranceFee = this.insurance.propertyInsurance(propertyValue, propertyTypeFactor, propertyInsuranceMonthlyRate);
@@ -281,7 +281,7 @@ var OfferService = /** @class */ (function () {
         var _a = this.math, subtract = _a.subtract, multiply = _a.multiply;
         var calculatedAmount = subtract(multiply(creditAmount, k1Fin), k2Fin);
         // Si el resultado es menor que creditAmount * 0.5, devolver al menos eso
-        return calculatedAmount < (creditAmount * 0.5) ? creditAmount * 0.5 : calculatedAmount;
+        return calculatedAmount < (creditAmount * 0.25) ? creditAmount * 0.25 : calculatedAmount;
     };
     /**
      * Función que calcula la Cuota Total (C_tot)
@@ -311,8 +311,7 @@ var OfferService = /** @class */ (function () {
             creditInstallmentValue = this.math.subtract(creditInstallment, creditInsuranceInstallment);
         }
         var numerator = this.math.add(creditInstallmentValue, otherMortages);
-        var frontEndRatioCalculated = this.math.divide(numerator, monthlyIncome);
-        return frontEndRatioCalculated;
+        return this.math.divide(numerator, monthlyIncome);
     };
     /**
      * Función que calcula la Carga Financiera (CF), en la teoría financiera
@@ -320,11 +319,9 @@ var OfferService = /** @class */ (function () {
      * Más info en: {@link https://creditu-team.gitlab.io/wiki/content/journeys/acquisition/Offer.html#carga-financiera}
      * @param totalInstallment    Cuota Total (C_tot)
      * @param disposableIncome    Ingresos Mensuales (Im)
-     * @param maximumBackendRatio Máximo (CF)
      */
     OfferService.prototype.getBackEndRatio = function (totalInstallment, disposableIncome) {
-        var backEndRatioCalculated = this.math.divide(totalInstallment, disposableIncome);
-        return backEndRatioCalculated;
+        return this.math.divide(totalInstallment, disposableIncome);
     };
     /**
      * Función que calcula el Monto aprobado es el mínimo entre Máximo local
@@ -366,12 +363,16 @@ var OfferService = /** @class */ (function () {
      */
     // eslint-disable-next-line class-methods-use-this
     OfferService.prototype.getCreditAmountToOffer = function (approvedAmount, credituAmount, creditMinAmount, creditMaxAmount) {
+        if (creditMinAmount.value() > creditMaxAmount.value()) {
+            throw new Error('Credit minimum amount cannot be greater than maximum amount');
+        }
         models_1.Guarder.defined(creditMinAmount, 'CreditMinAmount');
+        models_1.Guarder.defined(creditMaxAmount, 'CreditMaxAmount');
         var minApprovedAmount = Math.min(approvedAmount, credituAmount);
         if (minApprovedAmount > creditMaxAmount.value())
             return creditMaxAmount.value();
         if (minApprovedAmount < creditMinAmount.value())
-            return creditMinAmount.value();
+            return 0;
         return minApprovedAmount;
     };
     /**

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "creditu-common-library",
-  "version": "2.3.14",
+  "version": "2.3.16",
   "description": "Common library for Creditu applications",
   "main": "lib/index.js",
   "files": [
@@ -9,6 +9,7 @@
   ],
   "scripts": {
     "build": "tsc",
+    "build:watch": "tsc --watch",
     "lint": "tsc --noEmit && eslint \"src/**/*.ts\" --no-fix",
     "test:unit": "jest",
     "test:cov": "jest --coverage",
@@ -25,9 +26,9 @@
   },
   "homepage": "https://gitlab.com/creditu-team/creditu-common-library#readme",
   "devDependencies": {
-    "@babel/preset-typescript": "^7.27.0",
-    "@nestjs/testing": "^10.4.15",
-    "@types/express": "^5.0.1",
+    "@babel/preset-typescript": "^7.27.1",
+    "@nestjs/testing": "^10.4.18",
+    "@types/express": "^5.0.2",
     "@types/jest": "^29.5.14",
     "@typescript-eslint/eslint-plugin": "^5.62.0",
     "@typescript-eslint/parser": "^5.62.0",
@@ -35,12 +36,12 @@
     "eslint-config-airbnb-base": "^15.0.0",
     "eslint-plugin-import": "^2.31.0",
     "jest": "^29.7.0",
-    "ts-jest": "^29.3.1",
+    "ts-jest": "^29.3.4",
     "ts-node": "^10.9.2",
     "typescript": "^4.9.5"
   },
   "dependencies": {
-    "@nestjs/common": "^10.4.15",
+    "@nestjs/common": "^10.4.18",
     "creditu-date-model": "^2.9.1",
     "dinero.js": "^1.9.1",
     "express": "^4.21.2",

package/test/cl/offer.service.spec.ts

@@ -226,7 +226,7 @@ describe('offerService CL', () => {
     const math = new MathService(true, 20);
     const offerService = new OfferService(math);
     const result = offerService.calculateCreditAmountToOffer(inputs, params);
-    expect(result).toMatchObject(expectedResult);
+    expect(result).toMatchObject({ ...expectedResult, approvedAmount: 0 });
   });
 
   it('CHILE, SUBSIDY, SUBSIDY_1_2 A', () => {

package/test/common/offer-service.spec.ts

@@ -7,28 +7,27 @@ describe('offer service functional tests common', () => {
   const math = new MathService(true, 20);
   const offerService = new OfferService(math);
   describe('getCreditAmountToOffer', () => {
-    it('getCreditAmountToOffer should return 0 when minApprovedAmount < creditMinAmount', () => {
+    it('getCreditAmountToOffer should return 0 when minApprovedAmount < creditMinAmount', async () => {
       // ARRANGE
       const creditMinAmount = new CreditAmount(10);
       const creditMaxAmount = new CreditAmount(0);
       // ACT
-      const result = offerService.getCreditAmountToOffer(
+      expect(() => offerService.getCreditAmountToOffer(
         0,
         9,
         creditMinAmount,
         creditMaxAmount
-      );
+      ))
+        .toThrow('Credit minimum amount cannot be greater than maximum amount');
       // ASSERT
-      expect(result).toBe(0);
     });
-    it('getCreditAmountToOffer should return creditMaxAmount when minApprovedAmount > creditMaxAmount', () => {
-      // ARRANGE
-      const creditMinAmount = new CreditAmount(0);
-      const creditMaxAmount = new CreditAmount(10);
-      // ACT
-      const result = offerService.getCreditAmountToOffer(100, 100, creditMinAmount, creditMaxAmount);
-      // ASSERT
-      expect(result).toBe(10);
+    it('should throw error when creditMinAmount > creditMaxAmount', () => {
+      const creditMinAmount = new CreditAmount(10);
+      const creditMaxAmount = new CreditAmount(0);
+
+      expect(() => {
+        offerService.getCreditAmountToOffer(0, 9, creditMinAmount, creditMaxAmount);
+      }).toThrow('Credit minimum amount cannot be greater than maximum amount');
     });
     it('getCreditAmountToOffer should return approvedAmount when ir more than credituAmount and is in range', () => {
       // ARRANGE