creditu-common-library 2.3.14 → 2.3.15

package/README.md

@@ -1,7 +1,7 @@
 # Creditú CommonLibrary
 
 ## Descripción
-Esta librería, contiene los módulos y funciones matemáticas y financerias para el manejo de cálculos en el producto digital.
+Esta librería contiene los módulos y funciones matemáticas y financieras para el manejo de cálculos en el producto digital.
 
 ## Instalar en tu repositorio
 
@@ -21,7 +21,7 @@ La librería tiene dos módulos:
 
 - `Finance`: expone varios servicios orientados a un dominio específico, y cuyas funciones resuelven diversas fórmulas financieras en su ámbito.
 Los services expuestos son:
-  - `ConstantsService`: es un servicio auxiliar, que contiene funciones que calculan constantes que, a su vez, agrupan parametros conocidos para diversos propósitos en cálculos financieros.
+  - `ConstantsService`: es un servicio auxiliar, que contiene funciones que calculan constantes que, a su vez, agrupan parámetros conocidos para diversos propósitos en cálculos financieros.
   - `CreditInsuranceService`: este servicio tiene funciones de cálculo para el dominio `Seguros`.
   - `FinanceService`: este servicio auxiliar tiene funciones genéricas de funciones financieras, como interés anual, mensual, etc.
   - `PaymentService`: este servicio tiene funciones de cálculo para el dominio `Dividendo`.

package/offer/services/offer.service.js

@@ -366,12 +366,16 @@ var OfferService = /** @class */ (function () {
      */
     // eslint-disable-next-line class-methods-use-this
     OfferService.prototype.getCreditAmountToOffer = function (approvedAmount, credituAmount, creditMinAmount, creditMaxAmount) {
+        if (creditMinAmount.value() > creditMaxAmount.value()) {
+            throw new Error('Credit minimum amount cannot be greater than maximum amount');
+        }
         models_1.Guarder.defined(creditMinAmount, 'CreditMinAmount');
+        models_1.Guarder.defined(creditMaxAmount, 'CreditMaxAmount');
         var minApprovedAmount = Math.min(approvedAmount, credituAmount);
         if (minApprovedAmount > creditMaxAmount.value())
             return creditMaxAmount.value();
         if (minApprovedAmount < creditMinAmount.value())
-            return creditMinAmount.value();
+            return 0;
         return minApprovedAmount;
     };
     /**

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "creditu-common-library",
-  "version": "2.3.14",
+  "version": "2.3.15",
   "description": "Common library for Creditu applications",
   "main": "lib/index.js",
   "files": [

package/test/cl/offer.service.spec.ts

@@ -226,7 +226,7 @@ describe('offerService CL', () => {
     const math = new MathService(true, 20);
     const offerService = new OfferService(math);
     const result = offerService.calculateCreditAmountToOffer(inputs, params);
-    expect(result).toMatchObject(expectedResult);
+    expect(result).toMatchObject({ ...expectedResult, approvedAmount: 0 });
   });
 
   it('CHILE, SUBSIDY, SUBSIDY_1_2 A', () => {

package/test/common/offer-service.spec.ts

@@ -7,28 +7,27 @@ describe('offer service functional tests common', () => {
   const math = new MathService(true, 20);
   const offerService = new OfferService(math);
   describe('getCreditAmountToOffer', () => {
-    it('getCreditAmountToOffer should return 0 when minApprovedAmount < creditMinAmount', () => {
+    it('getCreditAmountToOffer should return 0 when minApprovedAmount < creditMinAmount', async () => {
       // ARRANGE
       const creditMinAmount = new CreditAmount(10);
       const creditMaxAmount = new CreditAmount(0);
       // ACT
-      const result = offerService.getCreditAmountToOffer(
+      expect(() => offerService.getCreditAmountToOffer(
         0,
         9,
         creditMinAmount,
         creditMaxAmount
-      );
+      ))
+        .toThrow('Credit minimum amount cannot be greater than maximum amount');
       // ASSERT
-      expect(result).toBe(0);
     });
-    it('getCreditAmountToOffer should return creditMaxAmount when minApprovedAmount > creditMaxAmount', () => {
-      // ARRANGE
-      const creditMinAmount = new CreditAmount(0);
-      const creditMaxAmount = new CreditAmount(10);
-      // ACT
-      const result = offerService.getCreditAmountToOffer(100, 100, creditMinAmount, creditMaxAmount);
-      // ASSERT
-      expect(result).toBe(10);
+    it('should throw error when creditMinAmount > creditMaxAmount', () => {
+      const creditMinAmount = new CreditAmount(10);
+      const creditMaxAmount = new CreditAmount(0);
+
+      expect(() => {
+        offerService.getCreditAmountToOffer(0, 9, creditMinAmount, creditMaxAmount);
+      }).toThrow('Credit minimum amount cannot be greater than maximum amount');
     });
     it('getCreditAmountToOffer should return approvedAmount when ir more than credituAmount and is in range', () => {
       // ARRANGE