create-shopify-firebase-app 1.2.0 → 1.3.0

package/README.md

@@ -86,19 +86,15 @@ The interactive CLI guides you through everything — creating your Shopify app,
   === Shopify Setup ===
 
   ? How would you like to connect your Shopify app?
-    ❯ Create a new app — we'll guide you through it
-      I already have an app — enter my credentials
-
-  ℹ Opening Shopify Partner Dashboard...
-
-  Follow these steps:
-
-    1. Sign in to your Partner account
-    2. Go to Apps → Create app → Create app manually
-    3. Enter app name: My App
-    4. Copy the Client ID and Client Secret
-
-  ? Paste your Client ID (API Key): abc123...
+    ❯ Create a new app via Shopify CLI
+      Link an existing app via Shopify CLI
+      Enter credentials manually (Client ID + Secret)
+
+  ℹ Logging into Shopify CLI...
+  ✔ Logged into Shopify
+  ℹ Creating a new Shopify app...
+    (Shopify CLI handles app creation interactively)
+  ✔ Client ID: abc123...
   ? Paste your Client Secret: ********
   ? What API access does your app need?
     ❯ Read products            read_products

package/lib/index.js

@@ -128,6 +128,47 @@ function listFirebaseProjects() {
   return [];
 }
 
+// ─── Run an interactive command (user sees prompts) ─────────────────────
+function execInteractive(cmd, cwd) {
+  return new Promise((resolve, reject) => {
+    const child = spawn(cmd, {
+      cwd,
+      shell: true,
+      stdio: "inherit",
+    });
+    child.on("close", (code) => {
+      if (code === 0) resolve();
+      else reject(new Error(`Command exited with code ${code}`));
+    });
+  });
+}
+
+// ─── Check if logged into Shopify CLI ───────────────────────────────────
+function isShopifyLoggedIn() {
+  try {
+    // `shopify app config link --help` doesn't need auth,
+    // but `shopify app info` does — use a quick check
+    const out = execSync("shopify auth login --help", {
+      encoding: "utf8",
+      stdio: ["ignore", "pipe", "ignore"],
+    });
+    return true;
+  } catch {
+    return false;
+  }
+}
+
+// ─── Parse TOML file for client_id ──────────────────────────────────────
+function parseTomlClientId(tomlPath) {
+  try {
+    const content = fs.readFileSync(tomlPath, "utf8");
+    const match = content.match(/client_id\s*=\s*"([^"]+)"/);
+    return match ? match[1] : null;
+  } catch {
+    return null;
+  }
+}
+
 // ─── Create Firebase project ─────────────────────────────────────────────
 async function createFirebaseProject(projectId, displayName) {
   try {
@@ -205,48 +246,97 @@ async function getConfig(args) {
   // ═══════════════════════════════════════════════════════════════════
   section("Shopify Setup");
 
+  const hasShopifyCli = hasCommand("shopify");
+
+  // Build choices based on what's available
+  const shopifyChoices = [];
+  if (hasShopifyCli) {
+    shopifyChoices.push(
+      { title: "Create a new app via Shopify CLI", value: "cli-create" },
+      { title: "Link an existing app via Shopify CLI", value: "cli-link" },
+    );
+  }
+  shopifyChoices.push(
+    { title: `Enter credentials manually ${c.dim}(Client ID + Secret)${c.reset}`, value: "manual" },
+  );
+
   const { shopifySetup } = await prompts({
     type: "select",
     name: "shopifySetup",
     message: "How would you like to connect your Shopify app?",
-    choices: [
-      { title: "Create a new app — we'll guide you through it", value: "create" },
-      { title: "I already have an app — enter my credentials", value: "existing" },
-    ],
+    choices: shopifyChoices,
   }, { onCancel });
 
   let apiKey, apiSecret;
 
-  if (shopifySetup === "create") {
-    console.log();
-    info("Opening Shopify Partner Dashboard...");
-    console.log();
-    console.log(`  ${c.dim}Follow these steps:${c.reset}`);
-    console.log();
-    console.log(`    ${c.cyan}1.${c.reset} Sign in to your Partner account`);
-    console.log(`    ${c.cyan}2.${c.reset} Go to ${c.bold}Apps${c.reset} → ${c.bold}Create app${c.reset} → ${c.bold}Create app manually${c.reset}`);
-    console.log(`    ${c.cyan}3.${c.reset} Enter app name: ${c.cyan}${appName}${c.reset}`);
-    console.log(`    ${c.cyan}4.${c.reset} Copy the ${c.bold}Client ID${c.reset} and ${c.bold}Client Secret${c.reset}`);
-    console.log();
-    openBrowser("https://partners.shopify.com");
+  if (shopifySetup === "cli-create" || shopifySetup === "cli-link") {
+    // ── Use Shopify CLI to create/link the app ────────────────────
+    // We need a temp directory with a shopify.app.toml for the CLI to work
+    const tmpDir = path.resolve(process.cwd(), `__shopify_setup_${Date.now()}`);
+    fs.mkdirSync(tmpDir, { recursive: true });
 
-    const creds = await prompts([
-      {
-        type: "text",
-        name: "apiKey",
-        message: `Paste your Client ID (API Key)`,
-        validate: (v) => (v.trim() ? true : "Required — copy from the app you just created"),
-      },
-      {
+    try {
+      // Ensure logged in
+      console.log();
+      info("Logging into Shopify CLI...");
+      info("A browser window will open — sign in to your Partner account.");
+      console.log();
+      await execInteractive("shopify auth login", tmpDir);
+      ok("Logged into Shopify");
+
+      // Run config link — it handles both create and link interactively
+      console.log();
+      if (shopifySetup === "cli-create") {
+        info("Creating a new Shopify app...");
+        info(`Select ${c.bold}"Create a new app"${c.reset} when prompted.`);
+      } else {
+        info("Linking an existing Shopify app...");
+        info("Select your app from the list when prompted.");
+      }
+      console.log();
+      await execInteractive("shopify app config link", tmpDir);
+
+      // Parse the generated TOML to get client_id
+      const tomlFiles = fs.readdirSync(tmpDir).filter((f) => f.endsWith(".toml"));
+      let parsedKey = null;
+      for (const f of tomlFiles) {
+        parsedKey = parseTomlClientId(path.join(tmpDir, f));
+        if (parsedKey) break;
+      }
+
+      if (parsedKey) {
+        apiKey = parsedKey;
+        ok(`Client ID: ${c.cyan}${apiKey}${c.reset}`);
+      } else {
+        warn("Could not read Client ID from TOML");
+        const res = await prompts({
+          type: "text",
+          name: "apiKey",
+          message: "Paste your Client ID (API Key)",
+          validate: (v) => (v.trim() ? true : "Required"),
+        }, { onCancel });
+        apiKey = res.apiKey;
+      }
+
+      // API Secret is never in the TOML — always need to ask
+      console.log();
+      info("The API Secret is not stored in config files for security.");
+      info(`Find it at: ${c.cyan}https://partners.shopify.com${c.reset} → Apps → your app → Client credentials`);
+      console.log();
+      const { secret } = await prompts({
         type: "password",
-        name: "apiSecret",
+        name: "secret",
         message: "Paste your Client Secret (API Secret)",
-        validate: (v) => (v.trim() ? true : "Required"),
-      },
-    ], { onCancel });
-    apiKey = creds.apiKey;
-    apiSecret = creds.apiSecret;
+        validate: (v) => (v.trim() ? true : "Required — find it in Partner Dashboard → Apps → Client credentials"),
+      }, { onCancel });
+      apiSecret = secret;
+
+    } finally {
+      // Clean up temp directory
+      fs.rmSync(tmpDir, { recursive: true, force: true });
+    }
   } else {
+    // ── Manual entry ──────────────────────────────────────────────
     const creds = await prompts([
       {
         type: "text",

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "create-shopify-firebase-app",
-  "version": "1.2.0",
+  "version": "1.3.0",
   "description": "Create Shopify apps powered by Firebase — serverless, lightweight, zero-framework. The official alternative to Remix for Shopify + Firebase developers.",
   "keywords": [
     "shopify",