create-sdd-project 0.9.1 → 0.9.3
This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
- package/README.md +7 -1
- package/package.json +1 -1
- package/template/.claude/commands/review-plan.md +52 -0
- package/template/.claude/settings.json +1 -1
- package/template/.claude/skills/development-workflow/SKILL.md +8 -1
- package/template/.gemini/commands/review-plan-instructions.md +53 -0
- package/template/.gemini/commands/review-plan.toml +2 -0
- package/template/.gemini/skills/development-workflow/SKILL.md +8 -1
- package/template/CLAUDE.md +4 -3
package/README.md
CHANGED
|
@@ -302,12 +302,18 @@ SDD DevFlow combines three proven practices:
|
|
|
302
302
|
| `bug-workflow` | `report bug`, `fix bug`, `hotfix needed` | Bug triage, investigation, and resolution |
|
|
303
303
|
| `project-memory` | `set up project memory`, `log a bug fix` | Maintains institutional knowledge |
|
|
304
304
|
|
|
305
|
+
### Plan Quality
|
|
306
|
+
|
|
307
|
+
Every Standard/Complex feature plan goes through a **built-in self-review** (Step 2.4) where the agent re-reads its own plan and checks for errors, vague steps, wrong assumptions, and over-engineering before requesting approval.
|
|
308
|
+
|
|
309
|
+
For additional confidence, the optional `/review-plan` command sends the plan to an external AI model (Codex CLI, Gemini CLI, or Claude Code) for independent critique — catching blind spots that same-model review misses.
|
|
310
|
+
|
|
305
311
|
### Workflow (Steps 0–6)
|
|
306
312
|
|
|
307
313
|
```
|
|
308
314
|
0. SPEC → spec-creator drafts specs → Spec Approval
|
|
309
315
|
1. SETUP → Branch, ticket, product tracker → Ticket Approval
|
|
310
|
-
2. PLAN → Planner creates
|
|
316
|
+
2. PLAN → Planner creates plan + self-review → Plan Approval
|
|
311
317
|
3. IMPLEMENT → Developer agent, TDD
|
|
312
318
|
4. FINALIZE → Tests/lint/build, validator → Commit Approval
|
|
313
319
|
5. REVIEW → PR, code review, QA → Merge Approval
|
package/package.json
CHANGED
|
@@ -0,0 +1,52 @@
|
|
|
1
|
+
Review the Implementation Plan in the current ticket using an external model for independent critique.
|
|
2
|
+
|
|
3
|
+
## Prerequisites
|
|
4
|
+
|
|
5
|
+
- An external AI CLI tool installed: [Codex CLI](https://github.com/openai/codex), [Gemini CLI](https://github.com/google-gemini/gemini-cli), or similar
|
|
6
|
+
- An active feature with a completed Implementation Plan (Step 2)
|
|
7
|
+
|
|
8
|
+
## What to do
|
|
9
|
+
|
|
10
|
+
1. **Find the current ticket** — Read `docs/project_notes/product-tracker.md` → Active Session → ticket path
|
|
11
|
+
2. **Extract the plan** — Read the ticket's `## Implementation Plan` section
|
|
12
|
+
3. **Send to external reviewer** — Run the external CLI in read-only mode with this prompt:
|
|
13
|
+
|
|
14
|
+
```
|
|
15
|
+
You are reviewing an Implementation Plan for a software feature. Your job is to find problems, not praise.
|
|
16
|
+
|
|
17
|
+
Review the plan below and report:
|
|
18
|
+
1. **Errors** — Wrong assumptions, impossible steps, missing dependencies
|
|
19
|
+
2. **Gaps** — Missing error handling, edge cases, rollback scenarios
|
|
20
|
+
3. **Vagueness** — Steps too ambiguous to implement with TDD (no clear input/output)
|
|
21
|
+
4. **Over-engineering** — Unnecessary abstractions, premature optimization
|
|
22
|
+
5. **Order issues** — Steps that depend on later steps
|
|
23
|
+
|
|
24
|
+
For each issue, state: [CRITICAL/IMPORTANT/SUGGESTION] — description — proposed fix.
|
|
25
|
+
|
|
26
|
+
End with: VERDICT: APPROVED | VERDICT: REVISE (if any CRITICAL or 2+ IMPORTANT issues)
|
|
27
|
+
|
|
28
|
+
---
|
|
29
|
+
PLAN:
|
|
30
|
+
<paste the Implementation Plan here>
|
|
31
|
+
```
|
|
32
|
+
|
|
33
|
+
Example with Codex CLI:
|
|
34
|
+
```bash
|
|
35
|
+
codex exec -m o4-mini --quiet "Review this Implementation Plan: $(cat docs/tickets/FXXX-*.md | sed -n '/## Implementation Plan/,/## Acceptance Criteria/p')"
|
|
36
|
+
```
|
|
37
|
+
|
|
38
|
+
Example with Gemini CLI:
|
|
39
|
+
```bash
|
|
40
|
+
gemini -m gemini-2.5-pro "Review this Implementation Plan: $(cat docs/tickets/FXXX-*.md | sed -n '/## Implementation Plan/,/## Acceptance Criteria/p')"
|
|
41
|
+
```
|
|
42
|
+
|
|
43
|
+
4. **Process the review** — If VERDICT: REVISE, update the plan addressing CRITICAL and IMPORTANT issues
|
|
44
|
+
5. **Optional second round** — Send the revised plan for a final audit if significant changes were made
|
|
45
|
+
6. **Log the review** — Add a note in the ticket's Completion Log: "Plan reviewed by [model] — N issues found, N addressed"
|
|
46
|
+
|
|
47
|
+
## Notes
|
|
48
|
+
|
|
49
|
+
- This command is **optional** — the workflow's built-in Plan Self-Review (Step 2.4) always runs automatically
|
|
50
|
+
- Most valuable for **Complex** features or plans with 8+ steps
|
|
51
|
+
- The external model runs read-only — it reviews text, not code
|
|
52
|
+
- If no external CLI is available, you can copy-paste the plan into a different AI chat for manual review
|
|
@@ -19,7 +19,7 @@
|
|
|
19
19
|
"hooks": [
|
|
20
20
|
{
|
|
21
21
|
"type": "command",
|
|
22
|
-
"command": "echo '{\"additionalContext\": \"Context was compacted. BEFORE doing anything else:
|
|
22
|
+
"command": "echo '{\"additionalContext\": \"Context was compacted. BEFORE doing anything else: (1) Read the product tracker Active Session (docs/project_notes/product-tracker.md) for context recovery. (2) Re-read the SKILL.md for your current workflow (.claude/skills/development-workflow/SKILL.md) to know what actions are required at your current step. (3) If at Step 5 or later, you MUST read references/merge-checklist.md and fill the Merge Checklist Evidence table in the ticket before requesting merge approval.\"}'",
|
|
23
23
|
"statusMessage": "Injecting recovery context..."
|
|
24
24
|
}
|
|
25
25
|
]
|
|
@@ -99,7 +99,14 @@ See `references/branching-strategy.md` for details.
|
|
|
99
99
|
1. Use Task tool with planner agent (`backend-planner` for backend features, `frontend-planner` for frontend features)
|
|
100
100
|
2. **Fullstack features:** Run `backend-planner` first, then `frontend-planner`. Each writes its own section in the Implementation Plan
|
|
101
101
|
3. Agent writes Implementation Plan into ticket's `## Implementation Plan`
|
|
102
|
-
4.
|
|
102
|
+
4. **Plan Self-Review:** Re-read the complete Implementation Plan you just wrote. Critically evaluate:
|
|
103
|
+
- Missing error handling or edge cases?
|
|
104
|
+
- Steps that are too vague to implement with TDD?
|
|
105
|
+
- Wrong assumptions about existing code or schemas?
|
|
106
|
+
- Dependencies between steps that force a different order?
|
|
107
|
+
- Over-engineering or unnecessary abstractions?
|
|
108
|
+
Update the plan with any fixes found before proceeding.
|
|
109
|
+
5. Update tracker: step `2/6 (Plan)` (Active Session + Features table)
|
|
103
110
|
|
|
104
111
|
**→ CHECKPOINT: Plan Approval**
|
|
105
112
|
|
|
@@ -0,0 +1,53 @@
|
|
|
1
|
+
## Review Plan — Instructions
|
|
2
|
+
|
|
3
|
+
Review the Implementation Plan in the current ticket using an external model for independent critique.
|
|
4
|
+
|
|
5
|
+
### Prerequisites
|
|
6
|
+
|
|
7
|
+
- An external AI CLI tool installed: Codex CLI, Claude Code, or similar
|
|
8
|
+
- An active feature with a completed Implementation Plan (Step 2)
|
|
9
|
+
|
|
10
|
+
### Steps
|
|
11
|
+
|
|
12
|
+
1. **Find the current ticket** — Read `docs/project_notes/product-tracker.md` → Active Session → ticket path
|
|
13
|
+
2. **Extract the plan** — Read the ticket's `## Implementation Plan` section
|
|
14
|
+
3. **Send to external reviewer** — Run the external CLI in read-only mode with this prompt:
|
|
15
|
+
|
|
16
|
+
```
|
|
17
|
+
You are reviewing an Implementation Plan for a software feature. Your job is to find problems, not praise.
|
|
18
|
+
|
|
19
|
+
Review the plan below and report:
|
|
20
|
+
1. Errors — Wrong assumptions, impossible steps, missing dependencies
|
|
21
|
+
2. Gaps — Missing error handling, edge cases, rollback scenarios
|
|
22
|
+
3. Vagueness — Steps too ambiguous to implement with TDD (no clear input/output)
|
|
23
|
+
4. Over-engineering — Unnecessary abstractions, premature optimization
|
|
24
|
+
5. Order issues — Steps that depend on later steps
|
|
25
|
+
|
|
26
|
+
For each issue, state: [CRITICAL/IMPORTANT/SUGGESTION] — description — proposed fix.
|
|
27
|
+
|
|
28
|
+
End with: VERDICT: APPROVED | VERDICT: REVISE (if any CRITICAL or 2+ IMPORTANT issues)
|
|
29
|
+
|
|
30
|
+
---
|
|
31
|
+
PLAN:
|
|
32
|
+
<paste the Implementation Plan here>
|
|
33
|
+
```
|
|
34
|
+
|
|
35
|
+
Example with Claude Code:
|
|
36
|
+
```bash
|
|
37
|
+
claude -m claude-sonnet-4-20250514 --print "Review this plan: $(cat docs/tickets/FXXX-*.md | sed -n '/## Implementation Plan/,/## Acceptance Criteria/p')"
|
|
38
|
+
```
|
|
39
|
+
|
|
40
|
+
Example with Codex CLI:
|
|
41
|
+
```bash
|
|
42
|
+
codex exec -m o4-mini --quiet "Review this plan: $(cat docs/tickets/FXXX-*.md | sed -n '/## Implementation Plan/,/## Acceptance Criteria/p')"
|
|
43
|
+
```
|
|
44
|
+
|
|
45
|
+
4. **Process the review** — If VERDICT: REVISE, update the plan addressing CRITICAL and IMPORTANT issues
|
|
46
|
+
5. **Optional second round** — Send the revised plan for a final audit if significant changes were made
|
|
47
|
+
6. **Log the review** — Add a note in the ticket's Completion Log: "Plan reviewed by [model] — N issues found, N addressed"
|
|
48
|
+
|
|
49
|
+
### Notes
|
|
50
|
+
|
|
51
|
+
- This command is **optional** — the workflow's built-in Plan Self-Review (Step 2.4) always runs automatically
|
|
52
|
+
- Most valuable for Complex features or plans with 8+ steps
|
|
53
|
+
- The external model runs read-only — it reviews text, not code
|
|
@@ -0,0 +1,2 @@
|
|
|
1
|
+
description = "Review the current Implementation Plan using an external AI model for independent critique (optional, for Standard/Complex features)"
|
|
2
|
+
prompt = "Read the file .gemini/commands/review-plan-instructions.md and follow the instructions to review the current Implementation Plan with an external model."
|
|
@@ -99,7 +99,14 @@ See `references/branching-strategy.md` for details.
|
|
|
99
99
|
1. Follow the planner agent instructions (`backend-planner` for backend features, `frontend-planner` for frontend features) in `.gemini/agents/`
|
|
100
100
|
2. **Fullstack features:** Run `backend-planner` first, then `frontend-planner`. Each writes its own section in the Implementation Plan
|
|
101
101
|
3. Write Implementation Plan into ticket's `## Implementation Plan`
|
|
102
|
-
4.
|
|
102
|
+
4. **Plan Self-Review:** Re-read the complete Implementation Plan you just wrote. Critically evaluate:
|
|
103
|
+
- Missing error handling or edge cases?
|
|
104
|
+
- Steps that are too vague to implement with TDD?
|
|
105
|
+
- Wrong assumptions about existing code or schemas?
|
|
106
|
+
- Dependencies between steps that force a different order?
|
|
107
|
+
- Over-engineering or unnecessary abstractions?
|
|
108
|
+
Update the plan with any fixes found before proceeding.
|
|
109
|
+
5. Update tracker: step `2/6 (Plan)` (Active Session + Features table)
|
|
103
110
|
|
|
104
111
|
**→ CHECKPOINT: Plan Approval**
|
|
105
112
|
|
package/template/CLAUDE.md
CHANGED
|
@@ -14,6 +14,7 @@ After context compaction or new session — BEFORE continuing work:
|
|
|
14
14
|
|
|
15
15
|
1. Read product tracker (`docs/project_notes/product-tracker.md`) → **Active Session**
|
|
16
16
|
2. If active feature → read referenced ticket in `docs/tickets/`
|
|
17
|
-
3.
|
|
18
|
-
4.
|
|
19
|
-
5.
|
|
17
|
+
3. Re-read the workflow skill (`.claude/skills/development-workflow/SKILL.md`) to know what actions the current step requires
|
|
18
|
+
4. If at Step 5 or later → read `references/merge-checklist.md` and check if the ticket's `## Merge Checklist Evidence` table needs to be filled
|
|
19
|
+
5. Do NOT proceed past any checkpoint without user confirmation (respect autonomy level)
|
|
20
|
+
6. If Active Session shows a pending checkpoint, ask before continuing
|